Re: [dpdk-dev] [PATCH] bus/pci/windows: guard against sdk/dpdk guid collision

2021-01-13 Thread Tyler Retzlaff
On Wed, Jan 13, 2021 at 08:20:34PM +0300, Dmitry Kozlyuk wrote: > pci/windows: fix build with SDK 10.0.x > > NetUIO device class and interface GUIDs are defined in system > headers starting from platform SDK v10.0.x. Inspect SDK version > to avoid redefinition. > >

Re: [dpdk-dev] [PATCH] net/iavf: fix null pointer dereference

2021-01-13 Thread Zhang, Qi Z
> -Original Message- > From: Su, Simei > Sent: Thursday, January 14, 2021 1:23 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Guo, Junfeng ; Guo, Jia > ; Cao, Yahui ; Su, Simei > > Subject: [PATCH] net/iavf: fix null pointer dereference > > A pointer has already been dereferenced before ch

Re: [dpdk-dev] KNI alternatives

2021-01-13 Thread Stephen Hemminger
Controlling DPDK interfaces with KNI is known to be broken. Kni calls usepspace with network mutex held. The problem is not fixable. The kernel does provide netlink and devlink API's but there is no generic solution with DPDK. On Wed, Jan 13, 2021, 11:54 AM Igor Ryzhov wrote: > > > On Wed, Jan

Re: [dpdk-dev] [PATCH v3 0/3] AVX512 vPMD on i40e

2021-01-13 Thread Zhang, Qi Z
> -Original Message- > From: Rong, Leyi > Sent: Thursday, January 14, 2021 2:40 PM > To: Zhang, Qi Z ; Lu, Wenzhuo ; > Yigit, Ferruh ; Richardson, Bruce > ; Xing, Beilei > Cc: dev@dpdk.org; Rong, Leyi > Subject: [PATCH v3 0/3] AVX512 vPMD on i40e > > This patchset aims to support AVX

[dpdk-dev] [PATCH v3 2/4] net/mlx5: fix the unnecessary checking for RSS action

2021-01-13 Thread Jiawei Wang
RSS action is valid only in NIC-RX domain, this fix bypass the function that getting RSS action from the flow action list under no NIC-RX domain. Fixes: e745f90 ("net/mlx5: optimize flow RSS struct") Cc: sta...@dpdk.org Signed-off-by: Jiawei Wang Acked-by: Viacheslav Ovsiienko --- drivers/net/

[dpdk-dev] [PATCH v3 1/4] app/testpmd: add RSS support in sample action

2021-01-13 Thread Jiawei Wang
Support rss action in the sample sub-actions list. The examples for the sample flow use case and result as below: set sample_actions 0 mark id 0x12 / rss queues 0 1 2 3 end / end flow create 0 ingress group 1 pattern eth / end actions sample ratio 1 index 0 / jump group 2 / end This flow will

[dpdk-dev] [PATCH v3 0/4] Add RSS action support in the sample sub-actions list

2021-01-13 Thread Jiawei Wang
Currently the sample flow only supports Queue action in NIC-Rx domain. This patchset adds the RSS action support in the sample sub-actions list. The examples for the sample flow with RSS action and result as below: set sample_actions 0 mark id 0x12 / rss queues 0 1 2 3 end / end flow cr

[dpdk-dev] [PATCH v3 3/4] net/mlx5: handle the RSS action in the sample

2021-01-13 Thread Jiawei Wang
PMD validates the rss action in the sample sub-actions list, then translates into rdma-core action and it will be used for sample path destination. If the RSS action is in both sample sub-actions list and original flow, the rss level and rss type in the sample sub-actions list should be consistent

[dpdk-dev] [PATCH v3 4/4] doc: update RSS support in sample action

2021-01-13 Thread Jiawei Wang
Add description about mlx5 PMD RSS action support for the Sample action. Signed-off-by: Jiawei Wang Acked-by: Viacheslav Ovsiienko --- doc/guides/nics/mlx5.rst | 1 + doc/guides/rel_notes/release_21_02.rst | 5 + 2 files changed, 6 insertions(+) diff --git a/doc/guides/nics/m

[dpdk-dev] [PATCH] tailq: secondary process may not have all tailq available

2021-01-13 Thread Hemant Agrawal
Secondary process may not have all the tailq available for mapping, so better to ignore the error. e.g. if the primary process is linked with N libs and secondary process is linked with less number of libs. dpdk-procinfo results into following error: EAL: Cannot initialize tailq: VMBUS_RESOURCE_L

[dpdk-dev] [PATCH v2 5/5] crypto/dpaa2_sec: add support for AES CMAC integrity check

2021-01-13 Thread Hemant Agrawal
This patch adds support for AES_CMAC integrity in non-security mode. This patch modifies the camm flib to handles the AES CMAC without conflicting the proto ALG operations. i.e. by creating another ALG operation routine. Signed-off-by: Hemant Agrawal --- doc/guides/cryptodevs/dpaa2_sec.rst

[dpdk-dev] [PATCH v2 4/5] crypto/dpaa_sec: reduce the log on queue closure

2021-01-13 Thread Hemant Agrawal
if for some reason the queue is not close properly, specially in test cases. The QUEUE retire prints are flooding the screen. They are not really required as WARNING. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa_sec/dpaa_sec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[dpdk-dev] [PATCH v2 3/5] common/dpaax/caamflib: update zuc-zuc descriptor sharing

2021-01-13 Thread Hemant Agrawal
From: Akhil Goyal the descriptor sharing needed to be changed for ZUC+ZUC as we were getting invalid CHA combination error due to sharing being done on DECOs simultaneously. Signed-off-by: Akhil Goyal --- drivers/common/dpaax/caamflib/desc/pdcp.h | 4 ++-- 1 file changed, 2 insertions(+), 2 de

[dpdk-dev] [PATCH v2 1/5] crypto/dpaa2_sec: support AES-XCBC-MAC

2021-01-13 Thread Hemant Agrawal
From: Akhil Goyal This patch add support for AES-XCBC-MAC for following cases - AES-XCBC-MAC auth only - AES-CBC/CTR + AES-XCBC-MAC (non-proto) - AES-CBC/CTR + AES-XCBC-MAC (protocol offload) - DES-CBC + AES-XCBC-MAC (non-proto) - 3DES-CBC + AES-XCBC-MAC (non-proto) Signed-off-by: Barry Cao Sig

[dpdk-dev] [PATCH v2 2/5] test/crypto: add AES-XCBC hash only test case

2021-01-13 Thread Hemant Agrawal
This patch adds test case for AES-XCBC hash only for Digest and Digest-verify Signed-off-by: Hemant Agrawal --- app/test/test_cryptodev_hash_test_vectors.h | 35 + 1 file changed, 35 insertions(+) diff --git a/app/test/test_cryptodev_hash_test_vectors.h b/app/test/test_cryp

[dpdk-dev] [Bug 613] [21.02] rule lost after port stopped

2021-01-13 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=613 Bug ID: 613 Summary: [21.02] rule lost after port stopped Product: DPDK Version: unspecified Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal

[dpdk-dev] [PATCH v1 5/5] app/eventdev: remove unnecessary barriers for order test

2021-01-13 Thread Feifei Wang
For the wmb in order_process_stage_1 and order_process_stage_invalid in the order test, they can be removed. This is because when the test results are wrong, the worker core writes 'true' to t->err. Then other worker cores, producer cores and the main core will load the 'error' index and stop testi

[dpdk-dev] [PATCH v1 4/5] app/eventdev: remove unnecessary barriers for pipeline test

2021-01-13 Thread Feifei Wang
For "processed_pkts" function, no operations should keep the order that being executed before loading "worker[i].processed_pkts". Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang --- app/test-eventdev/test_pipeline_common.c | 1 - 1 file changed, 1 deletion(-) diff --git a/app/test-eventde

[dpdk-dev] [PATCH v1 3/5] app/eventdev: replace wmb with thread fence for perf test

2021-01-13 Thread Feifei Wang
Simply replace rte_smp barrier with atomic threand fence. Signed-off-by: Phil Yang Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang --- app/test-eventdev/test_perf_common.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/app/test-eventdev/test_perf_comm

[dpdk-dev] [PATCH v1 2/5] app/eventdev: remove unnecessary barriers for perf test

2021-01-13 Thread Feifei Wang
For "processed_pkts" and "total_latency" functions, no operations should keep the order that being executed before loading "worker[i].processed_pkts". Thus rmb is unnecessary before loading. For "perf_launch_lcores" function, wmb after that the main lcore updates the variable "t->done", which repr

[dpdk-dev] [PATCH v6 9/9] doc: update GENEVE TLV option support

2021-01-13 Thread Shiri Kuzin
GENEVE TLV option support added to mlx5 PMD. The limitations and support were updated in documentation. Signed-off-by: Shiri Kuzin Acked-by: Viacheslav Ovsiienko --- doc/guides/nics/mlx5.rst | 23 ++- doc/guides/rel_notes/release_21_02.rst | 8 2 fil

[dpdk-dev] [PATCH v1 1/5] app/eventdev: fix SMP barrier bugs for perf test

2021-01-13 Thread Feifei Wang
This patch fixes RTE SMP barrier bugs for the perf test of eventdev. For the "perf_process_last_stage" function, wmb after storing processed_pkts should be moved before it. This is because the worker lcore should ensure it has really finished data processing, e.g. event stored into buffers, before

[dpdk-dev] [PATCH v6 7/9] net/mlx5: add GENEVE TLV option flow validation

2021-01-13 Thread Shiri Kuzin
This patch adds validation routine for the GENEVE header TLV option. The GENEVE TLV option match must include all fields with full masks due to NIC does not support masking on option class, type and length. The option data length must be non zero and provided data pattern should be zero neither d

[dpdk-dev] [PATCH v6 8/9] net/mlx5: add GENEVE TLV option flow translation

2021-01-13 Thread Shiri Kuzin
The GENEVE TLV option matching flows must be created using a translation function. This function checks whether we already created a Devx object for the matching and either creates the objects or updates the reference counter. Signed-off-by: Shiri Kuzin Acked-by: Viacheslav Ovsiienko --- drive

[dpdk-dev] [PATCH v6 6/9] net/mlx5: create GENEVE TLV option management

2021-01-13 Thread Shiri Kuzin
Currently firmware supports the only TLV object per device to match on the GENEVE header option. This patch adds the simple TLV object management to the mlx5 PMD. Signed-off-by: Shiri Kuzin Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5.c | 2 + drivers/net/mlx5/mlx5.h

[dpdk-dev] [PATCH v1 0/5] refactor smp barriers in app/eventdev

2021-01-13 Thread Feifei Wang
For smp barriers in app/eventdev, remove the unnecessary barriers or replace them with thread fence. Feifei Wang (5): app/eventdev: fix SMP barrier bugs for perf test app/eventdev: remove unnecessary barriers for perf test app/eventdev: replace wmb with thread fence for perf test app/event

[dpdk-dev] [PATCH v6 5/9] common/mlx5: create GENEVE TLV option object with DevX

2021-01-13 Thread Shiri Kuzin
TLV object is a special firmware maintained entity used to support match on GENEVE header extension option. The TLV object is created with DevX API and accepts the option class, type and lehgth fields. The class type and length fields are set using MLX5_SET and the Devx object is created using ml

[dpdk-dev] [PATCH v6 4/9] common/mlx5: check GENEVE TLV support in HCA attributes

2021-01-13 Thread Shiri Kuzin
This is preparation step to support match on GENEVE TLV option. In this Patch we add the HCA attributes that will allow supporting GENEVE TLV option matching. Signed-off-by: Shiri Kuzin Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c | 7 +++ drivers/common/mlx5/ml

[dpdk-dev] [PATCH v6 3/9] app/testpmd: add GENEVE header option length support

2021-01-13 Thread Shiri Kuzin
From: Viacheslav Ovsiienko The patch adds the GENEVE rte flow option length support to command line interpreter. The flow command with GENEVE option items looks like: flow create 0 ingress pattern eth / ipv4 / udp / geneve vni is 100 optlen is 2 / end actions drop / end The option lengt

[dpdk-dev] [PATCH v6 2/9] app/testpmd: add GENEVE option item support

2021-01-13 Thread Shiri Kuzin
From: Viacheslav Ovsiienko The patch adds the GENEVE option rte flow item support to command line interpreter. The flow command with GENEVE option items looks like: flow create 0 ingress pattern eth / ipv4 / udp / geneve vni is 100 / geneve-opt class is 99 length is 1 type is 0 data is

[dpdk-dev] [PATCH v6 1/9] lib/librte_ethdev: introduce GENEVE header TLV option item

2021-01-13 Thread Shiri Kuzin
The Geneve tunneling protocol is designed to allow the user to specify some data context on the packet. The GENEVE TLV (Type-Length-Variable) Option is the mean intended to present the user data. In order to support GENEVE TLV Option the new rte_flow item "rte_flow_item_geneve_opt" is added. The n

[dpdk-dev] [PATCH v6 0/9] ethdev: introduce GENEVE header TLV option item

2021-01-13 Thread Shiri Kuzin
The Geneve tunneling protocol is designed to allow the user to specify some data context on the packet. The GENEVE TLV (Type-Length-Variable) Option is the mean intended to present the user data. In order to support GENEVE TLV Option the new rte_flow item "rte_flow_item_geneve_opt" is introduce

Re: [dpdk-dev] [PATCH] eal/headers: explicitly cast void * to type *

2021-01-13 Thread Dmitry Kozlyuk
On Wed, 13 Jan 2021 21:45:49 -0800, Tyler Retzlaff wrote: > On Wed, Jan 13, 2021 at 08:52:55PM +0300, Dmitry Kozlyuk wrote: > > On Mon, 11 Jan 2021 17:18:45 -0800, Tyler Retzlaff wrote: > > > Explicitly cast void * to type * so that eal headers may be compiled > > > as C or C++. > > > > Topic

[dpdk-dev] [PATCH v2 4/4] test/lpm: improve coverage on tbl8

2021-01-13 Thread Ruifeng Wang
Existing test cases create 256 tbl8 groups for testing. The number covers only 8 bit next_hop/group field. Since the next_hop/group field had been extended to 24-bits, creating more than 256 groups in tests can improve the coverage. Coverage was not expanded to reach the max supported group number

[dpdk-dev] [PATCH v2 3/4] lpm: fix vector lookup for ppc64

2021-01-13 Thread Ruifeng Wang
rte_lpm_lookupx4 could return wrong next hop when more than 256 tbl8 groups are created. This is caused by incorrect type casting of tbl8 group index that been stored in tbl24 entry. The casting caused group index truncation and hence wrong tbl8 group been searched. Issue fixed by applying proper

[dpdk-dev] [PATCH v2 2/4] lpm: fix vector lookup for x86

2021-01-13 Thread Ruifeng Wang
rte_lpm_lookupx4 could return wrong next hop when more than 256 tbl8 groups are created. This is caused by incorrect type casting of tbl8 group index that been stored in tbl24 entry. The casting caused group index truncation and hence wrong tbl8 group been searched. Issue fixed by applying proper

[dpdk-dev] [PATCH v2 1/4] lpm: fix vector lookup for Arm

2021-01-13 Thread Ruifeng Wang
rte_lpm_lookupx4 could return wrong next hop when more than 256 tbl8 groups are created. This is caused by incorrect type casting of tbl8 group index that been stored in tbl24 entry. The casting caused group index truncation and hence wrong tbl8 group been searched. Issue fixed by applying proper

[dpdk-dev] [PATCH v3 3/3] net/i40e: optimize Tx by using AVX512

2021-01-13 Thread Leyi Rong
Optimize Tx path by using AVX512 instructions and vectorize the tx free bufs process. Signed-off-by: Leyi Rong Signed-off-by: Bruce Richardson --- drivers/net/i40e/i40e_rxtx.c| 19 +++ drivers/net/i40e/i40e_rxtx.h| 4 + drivers/net/i40e/i40e_rxtx_vec_avx512.c | 152 ++

[dpdk-dev] [PATCH v3 0/3] AVX512 vPMD on i40e

2021-01-13 Thread Leyi Rong
This patchset aims to support AVX512 vPMD on i40e. And the changes are only target to AVX512 vector path. --- v3: - Extract get_avx_supported() to get the proper vector data path to choose. v2: - Add return value check on rte_mempool_default_cache(). Leyi Rong (3): net/i40e: remove devarg use

[dpdk-dev] [PATCH v3 2/3] net/i40e: add AVX512 vector path

2021-01-13 Thread Leyi Rong
Add AVX512 support for i40e PMD. This patch adds i40e_rxtx_vec_avx512.c to support i40e AVX512 vPMD. This patch aims to enable AVX512 on i40e vPMD. Main changes are focus on Rx path compared with AVX2 vPMD. Signed-off-by: Leyi Rong Signed-off-by: Bruce Richardson --- drivers/net/i40e/i40e_rxtx

[dpdk-dev] [PATCH v3 1/3] net/i40e: remove devarg use-latest-supported-vec

2021-01-13 Thread Leyi Rong
As eal parameter --force-max-simd-bitwidth is already introduced, to make it more clear when setting rx/tx function, remove devarg use-latest-supported-vec support. Signed-off-by: Leyi Rong Acked-by: Wenzhuo Lu --- doc/guides/nics/i40e.rst | 9 --- drivers/net/i40e/i40e_ethdev.c | 63 +

[dpdk-dev] [PATCH v2 0/4] lpm lookupx4 fixes

2021-01-13 Thread Ruifeng Wang
This series fixed bug in lpm4 vector lookup implementations. When more than 256 tbl8 groups are created, lookupx4 could retrieve next hop data from wrong group. The bug is there since next_hop field was expanded from 8-bit to 24-bit, and inherited by other implementations. Also updated test case t

Re: [dpdk-dev] [PATCH 0/4] lpm lookupx4 fixes

2021-01-13 Thread Ruifeng Wang
> -Original Message- > From: David Marchand > Sent: Wednesday, January 13, 2021 10:53 PM > To: Ruifeng Wang ; Vladimir Medvedkin > ; Bruce Richardson > > Cc: dev ; nd ; jer...@marvell.com; David > Christensen ; Honnappa Nagarahalli > > Subject: Re: [dpdk-dev] [PATCH 0/4] lpm lookupx4 fi

[dpdk-dev] [PATCH] net/i40e: fix out-of-scope variable

2021-01-13 Thread Zhang,Alvin
From: Alvin Zhang Using "key", which points to an out-of-scope variable "rss_key_default". Signed-off-by: Alvin Zhang --- drivers/net/i40e/i40e_hash.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_hash.c b/drivers/net/i40e/i40e_hash.c index e07

Re: [dpdk-dev] [PATCH 4/4] test/lpm: improve coverage on tbl8

2021-01-13 Thread Ruifeng Wang
> -Original Message- > From: Medvedkin, Vladimir > Sent: Thursday, January 14, 2021 2:52 AM > To: Ruifeng Wang ; Bruce Richardson > > Cc: dev@dpdk.org; nd ; jer...@marvell.com; > d...@linux.vnet.ibm.com; Honnappa Nagarahalli > > Subject: Re: [PATCH 4/4] test/lpm: improve coverage on tbl

[dpdk-dev] [PATCH v3 8/8] doc: update release notes for iavf emudev driver

2021-01-13 Thread Chenbo Xia
Update release notes for emulated iavf driver. Signed-off-by: Chenbo Xia --- doc/guides/rel_notes/release_21_02.rst | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/doc/guides/rel_notes/release_21_02.rst b/doc/guides/rel_notes/release_21_02.rst index 9686930de3..90030079

[dpdk-dev] [PATCH v3 7/8] test/emudev: introduce functional test

2021-01-13 Thread Chenbo Xia
This patch introduces functional test for emudev. The implementation of iavf emudev selftest is also added. Signed-off-by: Miao Li Signed-off-by: Chenbo Xia --- app/test/meson.build | 5 +- app/test/test_emudev.c | 29 + drivers/emu/iavf/iavf_emu.c

[dpdk-dev] [PATCH v3 6/8] emu/iavf: add emudev operations to fit in emudev framework

2021-01-13 Thread Chenbo Xia
This patch implements emudev operations to make emulated iavf fit into rte_emudev framework. Lifecycle related and device resource related operations are both implemented. Signed-off-by: Chenbo Xia Signed-off-by: Xiuchun Lu --- drivers/emu/iavf/iavf_emu.c | 229 +

[dpdk-dev] [PATCH v3 5/8] emu/iavf: add resource management and internal logic of iavf

2021-01-13 Thread Chenbo Xia
This patch adds the allocation and release of device resources. Device resources include PCI BARs' memory and interrupt related resources. Device internal logic is also added. Signed-off-by: Chenbo Xia Signed-off-by: Xiuchun Lu --- drivers/emu/iavf/iavf_emu.c | 1 + drivers/emu/iavf/iav

[dpdk-dev] [PATCH v3 4/8] emu/iavf: add vfio-user device register and unregister

2021-01-13 Thread Chenbo Xia
This patch adds vfio-user APIs call in driver probe and remove. rte_vfio_user_register() and rte_vfio_user_unregister() are called to create/destroy a vfio-user device. Notify callbacks that libvfio_user defines are also implemented. Signed-off-by: Chenbo Xia Signed-off-by: Miao Li --- drivers/

[dpdk-dev] [PATCH v3 3/8] emu: introduce emulated iavf driver

2021-01-13 Thread Chenbo Xia
This patch introduces emulated iavf driver. It is a vdev driver emulating all iavf device behavior except data path handling. Signed-off-by: Chenbo Xia Signed-off-by: Xiuchun Lu --- MAINTAINERS | 7 + drivers/emu/iavf/iavf_emu.c | 30 drivers/emu/iavf/i

[dpdk-dev] [PATCH v3 2/8] doc: add emudev library guide

2021-01-13 Thread Chenbo Xia
Add emudev library guide and update release notes. Signed-off-by: Chenbo Xia --- doc/guides/prog_guide/emudev.rst | 122 + doc/guides/prog_guide/index.rst| 1 + doc/guides/rel_notes/release_21_02.rst | 12 +++ 3 files changed, 135 insertions(+) create mo

[dpdk-dev] [PATCH v3 1/8] lib: introduce emudev library

2021-01-13 Thread Chenbo Xia
This patch introduces the emudev library. Emudev library is used to abstract an emulated device, whose type could be general (e.g., network, crypto and etc.). Several device-level APIs are implemented to use or manipulate the device. It can be attached to another data path driver (e.g., ethdev driv

[dpdk-dev] [PATCH v3 0/8] Introduce emudev library and iavf emudev driver

2021-01-13 Thread Chenbo Xia
This series introduces a new device abstraction called emudev for emulated devices. A new library (librte_emudev) is implemented. The first emudev driver is also introduced, which emulates Intel Adaptive Virtual Function (iavf) as a software network device. This series has a dependency on librte_v

[dpdk-dev] 回复: [EXT] [PATCH v3] examples/eventdev: refactor ethdev port stop

2021-01-13 Thread Feifei Wang
> -邮件原件- > 发件人: Pavan Nikhilesh Bhagavatula > 发送时间: 2021年1月5日 18:09 > 收件人: Feifei Wang ; Harry van Haaren > ; Nikhil Rao ; Pavan > Nikhilesh > 抄送: dev@dpdk.org; jer...@marvell.com; nd ; > sta...@dpdk.org; Ruifeng Wang ; Honnappa > Nagarahalli > 主题: RE: [EXT] [PATCH v3] examples/eventdev:

[dpdk-dev] [PATCH v2 9/9] doc: add vfio-user library guide

2021-01-13 Thread Chenbo Xia
Add vfio-user library guide and update release notes. Signed-off-by: Chenbo Xia Signed-off-by: Xiuchun Lu --- doc/guides/prog_guide/index.rst | 1 + doc/guides/prog_guide/vfio_user_lib.rst | 215 doc/guides/rel_notes/release_21_02.rst | 11 ++ 3 files change

[dpdk-dev] [PATCH v2 8/9] test/vfio_user: introduce functional test

2021-01-13 Thread Chenbo Xia
This patch introduces functional test for vfio_user client and server. Note that the test can only be run with server and client both started and server should be started first. Signed-off-by: Chenbo Xia Signed-off-by: Xiuchun Lu --- app/test/meson.build | 4 + app/test/test_vfio_user.c

[dpdk-dev] [PATCH v2 7/9] vfio_user: add client APIs of DMA/IRQ/region

2021-01-13 Thread Chenbo Xia
This patch introduces nine APIs - Device related: rte_vfio_user_get_dev_info and rte_vfio_user_reset - DMA related: rte_vfio_user_dma_map/unmap - Region related: rte_vfio_user_get_reg_info and rte_vfio_user_region_read/write - IRQ related: rte_vfio_user_get_irq_info and rte_vfio_user_set_ir

[dpdk-dev] [PATCH v2 6/9] vfio_user: add client APIs of device attach/detach

2021-01-13 Thread Chenbo Xia
This patch implements two APIs, rte_vfio_user_attach_dev() and rte_vfio_user_detach_dev() for vfio-user client to connect to or disconnect from a vfio-user device on server side. Signed-off-by: Chenbo Xia Signed-off-by: Xiuchun Lu --- lib/librte_vfio_user/meson.build| 3 +- lib/librte

[dpdk-dev] [PATCH v2 5/9] vfio_user: implement interrupt related APIs

2021-01-13 Thread Chenbo Xia
This patch implements two interrupt related APIs, which are rte_vfio_user_get_irq() and rte_vfio_user_set_irq_info(). The former is for devices to get interrupt configuration (e.g., irqfds). The latter is for setting interrupt information before vfio-user starts. Signed-off-by: Chenbo Xia Signed-

[dpdk-dev] [PATCH v2 4/9] vfio_user: implement DMA table and socket address API

2021-01-13 Thread Chenbo Xia
This patch introduces an API called rte_vfio_user_get_mem_table() for emulated devices to acquire DMA memory table from vfio-user library. Notify operations are also introduced to notify the emulated devices of several events. Another socket address API is introduced for translation between device

[dpdk-dev] [PATCH v2 3/9] vfio_user: implement device and region related APIs

2021-01-13 Thread Chenbo Xia
This patch introduces device and region related APIs, which are rte_vfio_user_set_dev_info() and rte_vfio_user_set_reg_info(). The corresponding vfio-user command handling is also added with the definition of all vfio-user command identity. Signed-off-by: Chenbo Xia Signed-off-by: Xiuchun Lu ---

[dpdk-dev] [PATCH v2 2/9] vfio_user: implement lifecycle related APIs

2021-01-13 Thread Chenbo Xia
This patch implements three lifecycle related APIs for vfio-user server, which are rte_vfio_user_register(), rte_vfio_user_unregister() and rte_vfio_user_start(). Socket an device management is implemented along with the API introduction. Signed-off-by: Chenbo Xia Signed-off-by: Xiuchun Lu ---

[dpdk-dev] [PATCH v2 1/9] lib: introduce vfio-user library

2021-01-13 Thread Chenbo Xia
This patch introduces vfio-user library, which follows vfio-user protocol v1.0. As vfio-user has server and client implementation, this patch introduces basic structures and internal functions that will be used by both server and client. Signed-off-by: Chenbo Xia Signed-off-by: Xiuchun Lu --- M

[dpdk-dev] [PATCH v2 0/9] Introduce vfio-user library

2021-01-13 Thread Chenbo Xia
This series enables DPDK to be an alternative I/O device emulation library of building virtualized devices in separate processes outside QEMU. It introduces a new library for device emulation (librte_vfio_user). *librte_vfio_user* library is an implementation of VFIO-over-socket[1] (also known as

[dpdk-dev] 回复: [RFC PATCH v1 4/6] app/eventdev: add release barriers for pipeline test

2021-01-13 Thread Feifei Wang
Hi, Pavan > -邮件原件- > 发件人: Pavan Nikhilesh Bhagavatula > 发送时间: 2021年1月12日 16:29 > 收件人: Feifei Wang ; jer...@marvell.com; Harry > van Haaren > 抄送: dev@dpdk.org; nd ; Honnappa Nagarahalli > ; sta...@dpdk.org; Ruifeng Wang > ; nd ; nd ; nd > > 主题: RE: [RFC PATCH v1 4/6] app/eventdev: add re

Re: [dpdk-dev] [PATCH] eal/headers: explicitly cast void * to type *

2021-01-13 Thread Tyler Retzlaff
On Wed, Jan 13, 2021 at 08:52:55PM +0300, Dmitry Kozlyuk wrote: > On Mon, 11 Jan 2021 17:18:45 -0800, Tyler Retzlaff wrote: > > Explicitly cast void * to type * so that eal headers may be compiled > > as C or C++. > > Topic should probably be "eal/windows". i'll submit a new rev that changes this

[dpdk-dev] [PATCH] net/iavf: fix null pointer dereference

2021-01-13 Thread Simei Su
A pointer has already been dereferenced before checking if it is NULL. It doesn't make any sense, so correct to avoid it. Fixes: 4f3cfcbc3df3 ("net/iavf: support eCPRI msg type 0 for RSS") Coverity issue: 365290 Signed-off-by: Simei Su --- drivers/net/iavf/iavf_hash.c | 8 +--- 1 file chang

Re: [dpdk-dev] [PATCH] app/flow-perf: support meter action

2021-01-13 Thread Alexander Kozyrev
> From: Dong Zhou > Sent: Wednesday, January 13, 2021 7:51 > To: Wisam Monther ; Suanming Mou > ; Alexander Kozyrev ; > NBU-Contact-Thomas Monjalon > Cc: dev@dpdk.org > Subject: [PATCH] app/flow-perf: support meter action > > Currently, test-flow-perf app cannot generate flows with meter > actio

[dpdk-dev] [Bug 608] DPDK cannot allocate 32GB of memory

2021-01-13 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=608 mengxiang0...@gmail.com changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED

Re: [dpdk-dev] [PATCH] net/i40e: fix SFP I X722 with FW4.16

2021-01-13 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Zhang, Qi Z > Sent: Wednesday, January 13, 2021 12:09 PM > To: Weifeng Li ; Xing, Beilei ; > Guo, Jia > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix SFP I X722 with FW4.16 > > > > > -Original Mess

Re: [dpdk-dev] [dpdk-dev v3 0/3] enable UDP ecpri configure in dcf

2021-01-13 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Jia > Sent: Wednesday, January 13, 2021 10:05 PM > To: Zhang, Qi Z ; Wu, Jingjing ; > Yang, Qiming ; Wang, Haiyue > > Cc: dev@dpdk.org; Guo, Jia ; Su, Simei > > Subject: [dpdk-dev v3 0/3] enable UDP ecpri configure in dcf > > Enabling ecpri UDP tunne

Re: [dpdk-dev] [PATCH] net/ice: disable IPv4 checksum offload in vector path

2021-01-13 Thread Zhang, Qi Z
> -Original Message- > From: Murphy Yang > Sent: Friday, January 8, 2021 3:18 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Lu, Wenzhuo > ; Zhang, Qi Z ; Yang, SteveX > ; Yang, MurphyX > Subject: [PATCH] net/ice: disable IPv4 checksum offload in vector path > > ICE choices vector TX path

Re: [dpdk-dev] [RFC] app/testpmd: support multi-process

2021-01-13 Thread oulijun
在 2021/1/12 22:21, Wisam Monther 写道: -Original Message- From: oulijun Sent: Tuesday, January 12, 2021 4:13 PM To: Wisam Monther ; ferruh.yi...@intel.com; wenzhuo...@intel.com; beilei.x...@intel.com; bernard.iremon...@intel.com Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [RFC] app/test

[dpdk-dev] [PATCH v2] net/bnxt: fix lock handling in stop and close

2021-01-13 Thread Ajit Khaparde
From: Somnath Kotur err_recovery_lock needs to be released before returning in stop and close_op if FW_RESET flag is set. Fixes: dd3613560573 ("net/bnxt: check chip reset in dev stop and close") Signed-off-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- v1->v2: rebased to latest dpdk-next-net

[dpdk-dev] [Bug 594] i40e PMD APIs is missing input validation

2021-01-13 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=594 murphy (murphyx.y...@intel.com) changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|---

[dpdk-dev] [PATCH v2] net/bnxt: code refactoring changes

2021-01-13 Thread Ajit Khaparde
From: Somnath Kotur Move all the individual driver fields allocation routines to one routine - bnxt_drv_init(). This houses all such routines where memory needs to be allocated once during the driver's lifetime and does not need to be torn down during error recovery. Rename some function names in

Re: [dpdk-dev] [PATCH v3 2/2] build: i40e PMD on Windows

2021-01-13 Thread Tal Shnaiderman
> Subject: Re: [dpdk-dev] [PATCH v3 2/2] build: i40e PMD on Windows > > External email: Use caution opening links or attachments > > > 13/01/2021 23:55, Ranjit Menon: > > On 1/13/2021 2:52 PM, Thomas Monjalon wrote: > > > 22/12/2020 01:45, Pallavi Kadam: > > >> Allows i40e PMD to compile on Wind

Re: [dpdk-dev] [PATCH v2 0/8] Introduce emudev library and iavf emudev driver

2021-01-13 Thread Xia, Chenbo
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Thursday, January 14, 2021 12:52 AM > To: Xia, Chenbo > Cc: dev@dpdk.org; david.march...@redhat.com; step...@networkplumber.org; > Liang, > Cunming ; Lu, Xiuchun ; Li, > Miao ; Wu, Jingjing ; > techbo...@dpdk.org > Subject:

Re: [dpdk-dev] [PATCH] maintainers: update for testpmd

2021-01-13 Thread Li, Xiaoyun
Acked-by: Xiaoyun Li > -Original Message- > From: Xing, Beilei > Sent: Thursday, December 3, 2020 14:25 > To: dev@dpdk.org > Cc: Li, Xiaoyun ; Yigit, Ferruh > ; > Xing, Beilei > Subject: [PATCH] maintainers: update for testpmd > > From: Beilei Xing > > Replace Beilei Xing with Xiaoy

Re: [dpdk-dev] [PATCH v3 2/2] build: i40e PMD on Windows

2021-01-13 Thread Thomas Monjalon
13/01/2021 23:55, Ranjit Menon: > On 1/13/2021 2:52 PM, Thomas Monjalon wrote: > > 22/12/2020 01:45, Pallavi Kadam: > >> Allows i40e PMD to compile on Windows and disable other drivers. > >> Disable few warnings with Clang such as comparison of integers of > >> different signs and macro redefinitio

Re: [dpdk-dev] [PATCH v3 2/2] build: i40e PMD on Windows

2021-01-13 Thread Ranjit Menon
On 1/13/2021 2:52 PM, Thomas Monjalon wrote: 22/12/2020 01:45, Pallavi Kadam: Allows i40e PMD to compile on Windows and disable other drivers. Disable few warnings with Clang such as comparison of integers of different signs and macro redefinitions. Adds temp folder mlx5/windows as it is requir

Re: [dpdk-dev] [PATCH v3 2/2] build: i40e PMD on Windows

2021-01-13 Thread Thomas Monjalon
22/12/2020 01:45, Pallavi Kadam: > Allows i40e PMD to compile on Windows and disable other drivers. > Disable few warnings with Clang such as comparison of integers of > different signs and macro redefinitions. > > Adds temp folder mlx5/windows as it is required to build this patch > without any b

Re: [dpdk-dev] [PATCH] doc: update Windows support in mlx5 guide

2021-01-13 Thread Thomas Monjalon
03/01/2021 11:28, Tal Shnaiderman: > Windows will be supported by mlx5 PMD. > The mlx5 guide is updated with the needed > information. > > Signed-off-by: Tal Shnaiderman Applied to next-net-mlx, thanks

Re: [dpdk-dev] [PATCH v4] drivers/common: enable Windows common mlx5 compilation

2021-01-13 Thread Thomas Monjalon
12/01/2021 13:58, Tal Shnaiderman: > From: Ophir Munk > > Prior to this commit meson did not progress beyond directory > drivers/common for Windows compilations. This commit enables drivers > compilation under this directory. This commit is not changing compilation of drivers/common/* Changing

Re: [dpdk-dev] [PATCH v2 1/1] devtools: avoid installing static binaries

2021-01-13 Thread Thomas Monjalon
13/01/2021 20:05, Thomas Monjalon: > When testing compilation and checking ABI compatibility, > there is no real need of static binaries eating disks. > > The static linkage of applications was already well tested, > though the static examples tested with meson were limited to "l3fwd" only. > The

Re: [dpdk-dev] [PATCH] fib6: improve lookup performance

2021-01-13 Thread Thomas Monjalon
12/01/2021 15:13, Ananyev, Konstantin: > > > Improved performance for AVX512 FIB6 lookup by doubling the number > > of flows being processed > > > > Signed-off-by: Vladimir Medvedkin > > Acked-by: Konstantin Ananyev Applied, thanks PS: added "AVX512" in the title

Re: [dpdk-dev] [dpdk-stable] [PATCH] build: fix using ELF-only linker flags with COFF

2021-01-13 Thread Thomas Monjalon
13/01/2021 21:27, Ranjit Menon: > On 1/11/2021 4:36 PM, Dmitry Kozlyuk wrote: > > The --export-dynamic linker option is only applicable to ELF. > > On Windows, where COFF is used, it causes warnings: > > > > x86_64-w64-mingw32-ld: warning: --export-dynamic is not supported > > for PE+ tar

Re: [dpdk-dev] [PATCH v2] maintainers: update for testpmd

2021-01-13 Thread Thomas Monjalon
07/12/2020 21:59, Thomas Monjalon: > 02/12/2020 07:33, beilei.x...@intel.com: > > From: Beilei Xing > > > > Replace Beilei Xing with Xiaoyun Li. > > > > Signed-off-by: Beilei Xing > > --- > > Driver testing tool > > M: Wenzhuo Lu > > -M: Beilei Xing > > +M: Xiaoyun Li > > M: Bernard Iremo

Re: [dpdk-dev] [PATCH] build: fix using ELF-only linker flags with COFF

2021-01-13 Thread Ranjit Menon
On 1/11/2021 4:36 PM, Dmitry Kozlyuk wrote: The --export-dynamic linker option is only applicable to ELF. On Windows, where COFF is used, it causes warnings: x86_64-w64-mingw32-ld: warning: --export-dynamic is not supported for PE+ targets, did you mean --export-all-symbols? (MinGW)

Re: [dpdk-dev] [PATCH] doc: add profile with vtune section to prog guide

2021-01-13 Thread Thomas Monjalon
13/01/2021 18:11, Bruce Richardson: > On Wed, Dec 02, 2020 at 08:48:06PM +0300, eugeny.parshu...@linux.intel.com > wrote: > > From: Eugeny Parshutin > > > > Return back 'profiling with vtune' section to profiling programmers > > guide with updated instruction on how to enable vtune profiling > >

Re: [dpdk-dev] KNI alternatives

2021-01-13 Thread Igor Ryzhov
On Wed, Jan 13, 2021 at 9:45 PM Thomas Monjalon wrote: > 13/01/2021 19:17, Igor Ryzhov: > > On Wed, Jan 13, 2021 at 8:10 PM Stephen Hemminger < > > step...@networkplumber.org> wrote: > > > On Wed, Jan 13, 2021, 9:06 AM Thomas Monjalon > wrote: > > > > > > > Hi, > > > > > > > > As discussed today

[dpdk-dev] [PATCH v2 1/1] devtools: avoid installing static binaries

2021-01-13 Thread Thomas Monjalon
When testing compilation and checking ABI compatibility, there is no real need of static binaries eating disks. The static linkage of applications was already well tested, though the static examples tested with meson were limited to "l3fwd" only. The static build test with make is limited to "hell

Re: [dpdk-dev] [PATCH v2 1/5] lpm: add sve support for lookup on Arm platform

2021-01-13 Thread Medvedkin, Vladimir
On 08/01/2021 08:25, Ruifeng Wang wrote: Added new path to do lpm4 lookup by using scalable vector extension. The SVE path will be selected if compiler has flag SVE set. Signed-off-by: Ruifeng Wang --- lib/librte_eal/arm/include/rte_vect.h | 3 + lib/librte_lpm/meson.build|

Re: [dpdk-dev] [PATCH 4/4] test/lpm: improve coverage on tbl8

2021-01-13 Thread Medvedkin, Vladimir
Hi Ruifeng, Please find comment inlined. Apart from that looks good. On 08/01/2021 08:21, Ruifeng Wang wrote: Existing test cases create 256 tbl8 groups for testing. The number covers only 8 bit next_hop/group field. Since the next_hop/group field had been extended to 24-bits, creating more tha

Re: [dpdk-dev] [PATCH 2/4] lpm: fix vector lookup for x86

2021-01-13 Thread Medvedkin, Vladimir
On 08/01/2021 08:21, Ruifeng Wang wrote: rte_lpm_lookupx4 could return wrong next hop when more than 256 tbl8 groups are created. This is caused by incorrect type casting of tbl8 group index that been stored in tbl24 entry. The casting caused group index truncation and hence wrong tbl8 group b

Re: [dpdk-dev] [PATCH 0/4] lpm lookupx4 fixes

2021-01-13 Thread Medvedkin, Vladimir
Hi Ruifeng, LGTM, Thanks! On 08/01/2021 08:21, Ruifeng Wang wrote: This series fixed bug in lpm4 vector lookup implementations. When more than 256 tbl8 groups are created, lookupx4 could retrieve next hop data from wrong group. The bug is there since next_hop field was expanded from 8-bit to 24

Re: [dpdk-dev] KNI alternatives

2021-01-13 Thread Thomas Monjalon
13/01/2021 19:17, Igor Ryzhov: > On Wed, Jan 13, 2021 at 8:10 PM Stephen Hemminger < > step...@networkplumber.org> wrote: > > On Wed, Jan 13, 2021, 9:06 AM Thomas Monjalon wrote: > > > > > Hi, > > > > > > As discussed today in the techboard meeting, KNI has probably > > > better alternatives today

Re: [dpdk-dev] KNI alternatives

2021-01-13 Thread Igor Ryzhov
On Wed, Jan 13, 2021 at 8:10 PM Stephen Hemminger < step...@networkplumber.org> wrote: > Last time I tried. > Virtio user was as fast as KNI and consumed less cpu. Was seeing 10mpps > Tap was much slower. Like 1mpps. > > Vpp uses virtio user. > > Sorry for top post. Only have phone internet > > On

Re: [dpdk-dev] [PATCH v16 03/11] eal: change API of power intrinsics

2021-01-13 Thread Ananyev, Konstantin
> On 13-Jan-21 1:01 PM, Ananyev, Konstantin wrote: > > > >> > >> Instead of passing around pointers and integers, collect everything > >> into struct. This makes API design around these intrinsics much easier. > >> > >> Signed-off-by: Anatoly Burakov > >> Acked-by: Konstantin Ananyev > >> --- >

  1   2   >