On Wed, 13 Jan 2021 21:45:49 -0800, Tyler Retzlaff wrote:
> On Wed, Jan 13, 2021 at 08:52:55PM +0300, Dmitry Kozlyuk wrote:
> > On Mon, 11 Jan 2021 17:18:45 -0800, Tyler Retzlaff wrote:
> > > Explicitly cast void * to type * so that eal headers may be compiled
> > > as C or C++.
> >
> > Topic should probably be "eal/windows".
>
> i'll submit a new rev that changes this, it's not really windows specific
> but i guess windows is the only people crazy enough to use c++.
1. Topic usually describe area of changes, rte_os.h is in windows directory.
2. It's a perfectly valid concern that public headers must be usable from C++.
> > > diff --git a/lib/librte_ethdev/rte_ethdev_pci.h
> > > b/lib/librte_ethdev/rte_ethdev_pci.h
> > > index bf715896a..c20be29b1 100644
> > > --- a/lib/librte_ethdev/rte_ethdev_pci.h
> > > +++ b/lib/librte_ethdev/rte_ethdev_pci.h
> > > @@ -47,7 +47,7 @@ rte_eth_copy_pci_info(struct rte_eth_dev *eth_dev,
> > >
> > > static inline int
> > > eth_dev_pci_specific_init(struct rte_eth_dev *eth_dev, void *bus_device)
> > > {
> > > - struct rte_pci_device *pci_dev = bus_device;
> > > + struct rte_pci_device *pci_dev = (struct rte_pci_device *)bus_device;
> > >
> > > if (!pci_dev)
> > > return -ENODEV;
> >
> > This is a private header, it's never exposed---why the change is needed (not
> > that I have a strong opinion, though)?
>
> interesting, i'll look into why/how it is being included and confirm. i
> suppose
> the question in the back of my mind is if it is private then why is the header
> being installed at all?
+ Bruce
If it's a public header then maybe it's missing a @file?
