> -----Original Message----- > From: David Marchand <[email protected]> > Sent: Wednesday, January 13, 2021 10:53 PM > To: Ruifeng Wang <[email protected]>; Vladimir Medvedkin > <[email protected]>; Bruce Richardson > <[email protected]> > Cc: dev <[email protected]>; nd <[email protected]>; [email protected]; David > Christensen <[email protected]>; Honnappa Nagarahalli > <[email protected]> > Subject: Re: [dpdk-dev] [PATCH 0/4] lpm lookupx4 fixes > > On Fri, Jan 8, 2021 at 9:22 AM Ruifeng Wang <[email protected]> > wrote: > > > > This series fixed bug in lpm4 vector lookup implementations. > > When more than 256 tbl8 groups are created, lookupx4 could retrieve > > next hop data from wrong group. > > The bug is there since next_hop field was expanded from 8-bit to > > 24-bit, and inherited by other implementations. > > This is a single issue: I would squash those 3 patches as a single patch > (with 3 > Fixes: tags).
I split the patch for review purpose. It is OK to squash them into a single one on merge. Thank you. > > > > > Also updated test case to improve coverage to detect such failure. > > > > Ruifeng Wang (4): > > lpm: fix vector lookup for Arm > > lpm: fix vector lookup for x86 > > lpm: fix vector lookup for ppc64 > > test/lpm: improve coverage on tbl8 > > Reviews please? > > > -- > David Marchand
