Hi Ananyev,
Thank you.
Mix enum with corresponding defines for string literals, is the
convention of eal_options.h.
You can have a look at this
https://git.dpdk.org/dpdk/tree/lib/librte_eal/common/eal_options.h.
On Fri, Nov 13, 2020 at 5:27 PM Ananyev, Konstantin
wrote:
>
> Hi,
>
> >
> > Instea
17/11/2020 03:46, Honnappa Nagarahalli:
>
>
> >
> > 16/11/2020 17:16, Bruce Richardson:
> > > On Mon, Nov 16, 2020 at 03:50:31PM +, Juraj Linkeš wrote:
> > > > From: Thomas Monjalon
> > > > > 13/11/2020 15:31, Juraj Linkeš:
> > > > > > The current machine='default' build name is not descrip
Yes, I will remove str_is function and submit the v3 of this patch soon.
On Sat, Nov 14, 2020 at 4:13 PM David Marchand
wrote:
> On Wed, Nov 11, 2020 at 9:17 AM Ibtisam Tariq
> wrote:
> >
> > Instead of using getopt_long return value, strcmp was used to
> > compare the input parameters with the
On 11/16/20 10:23 PM, Ivan Malov wrote:
> Don't free the outer match spec by its pointer in the parsing context
> if it has already been tracked by an entry in the outer rule registry.
>
> Fixes: dadff137931c ("net/sfc: support encap flow items in transfer rules")
>
> Signed-off-by: Ivan Malov
On 11/16/20 10:40 PM, Ivan Malov wrote:
> The changeset that introduced common flow API thread safety
> in fact introduced double locking to this particular PMD as
> RTE flow API implementation in the PMD has been thread-safe
> since the day zero. State this by setting the corresponding
> device fl
On Tue, Nov 17, 2020 at 8:05 AM Dharmappa, Savinay
wrote:
> If so, please submit one patch fixing the qos_sched example (both config and
> doc) and another patch for fixing the ip_pipeline (doc).
> In both of them, describe with a Fixes: tag which commits are being fixed.
>
> >> Instead of new p
-Original Message-
From: David Marchand
Sent: Friday, November 13, 2020 7:28 PM
To: Dharmappa, Savinay
Cc: Dumitrescu, Cristian ; Singh, Jasvinder
; dev@dpdk.org; Thomas Monjalon
Subject: Re: [dpdk-dev] [PATCH v2] examples/qos_sched: update profile
oversubscribe config file
On Thu,
>
> 16/11/2020 17:16, Bruce Richardson:
> > On Mon, Nov 16, 2020 at 03:50:31PM +, Juraj Linkeš wrote:
> > > From: Thomas Monjalon
> > > > 13/11/2020 15:31, Juraj Linkeš:
> > > > > The current machine='default' build name is not descriptive. The
> > > > > actual default build is machine='nat
16/11/2020 16:54, Juraj Linkeš:
> From: Thomas Monjalon
> > 16/11/2020 08:56, Juraj Linkeš:
> > > From: Thomas Monjalon
> > > >
> > > > What do you mean by "disable Arm drivers"?
> > > > What are "Arm drivers"
> > > >
> > >
> > > These are the drivers that we're disableing for Arm builds. I'll ch
16/11/2020 17:16, Bruce Richardson:
> On Mon, Nov 16, 2020 at 03:50:31PM +, Juraj Linkeš wrote:
> > From: Thomas Monjalon
> > > 13/11/2020 15:31, Juraj Linkeš:
> > > > The current machine='default' build name is not descriptive. The
> > > > actual default build is machine='native'. Add an alte
16/11/2020 19:28, Radha Mohan:
> On Fri, Nov 13, 2020 at 2:39 PM Thomas Monjalon wrote:
> > 13/11/2020 20:18, Radha Mohan:
> > > On Tue, Nov 10, 2020 at 11:57 PM Mahipal Challa
> > > wrote:
> > > From: Radha Mohan
> > > Sent: Tuesday, November 10, 2020 11:44 PM
> > > > On Mon, Nov 9, 2020 at 4:
16/11/2020 19:50, Ferruh Yigit:
> On 11/13/2020 11:44 AM, Ferruh Yigit wrote:
> > In 'rte_eth_dev_configure()', if 'DEV_RX_OFFLOAD_JUMBO_FRAME' is not set
> > the max frame size is limited to 'RTE_ETHER_MAX_LEN' (1518).
> > This is mistake because for the PMDs that has frame size bigger than
> > "R
Hi, Maxime
It seems there are some typos (see below).
Beside these ones - ACKed.
> -Original Message-
> From: Maxime Leroy
> Sent: Monday, November 16, 2020 19:03
> To: Matan Azrad ; Shahaf Shuler ;
> Slava Ovsiienko ; Olivier Matz
>
> Cc: dev@dpdk.org; Didier Pallard
> Subject: [PATCH
> -Original Message-
> From: Maxime Leroy
> Sent: Monday, November 16, 2020 19:03
> To: Matan Azrad ; Shahaf Shuler ;
> Slava Ovsiienko ; Alexander Kozyrev
>
> Cc: dev@dpdk.org; NBU-Contact-N?lio Laranjeiro
>
> Subject: [PATCH v3 1/2] net/mlx5: fix Rx queue count calculation
>
> The com
The following assertion fails in case RTE_ENABLE_ASSERT is enabled:
PANIC in mlx5_tx_handle_completion():
assert "(txq->fcqs[txq->cq_ci & txq->cqe_m] >> 16)
== cqe->wqe_counter" failed
The free completion queue only contains an expected WQE counter if
RTE_LIBRTE_MLX5_DEBUG is enabled as we
The changeset that introduced common flow API thread safety
in fact introduced double locking to this particular PMD as
RTE flow API implementation in the PMD has been thread-safe
since the day zero. State this by setting the corresponding
device flag to skip locking imposed by generic RTE flow API
Don't free the outer match spec by its pointer in the parsing context
if it has already been tracked by an entry in the outer rule registry.
Fixes: dadff137931c ("net/sfc: support encap flow items in transfer rules")
Signed-off-by: Ivan Malov
---
drivers/net/sfc/sfc_mae.c | 6 +-
1 file cha
Hi Ferruh,
The failure occur at hash_key_mask_is_same() which uses the size returned by
flow_item_is_proto() for comparison.
Since the rte_flow_item_* of some types is now different than the rte_*_hdr
size of these types, need to use the rte_*_hdr size.
Regards,
Dekel
> -Original Message--
Setting MTU after each 'rte_eth_dev_configure()' prevents using
"--max-pkt-len=N" parameter and "port config all max-pkt-len #" command
This is breaking DTS scatter test case which is using
"--max-pkt-len=9000" testpmd parameter.
Reverting workaround to recover the DTS testcase.
Fixes: 1c21ee95c
On 11/13/2020 11:44 AM, Ferruh Yigit wrote:
In 'rte_eth_dev_configure()', if 'DEV_RX_OFFLOAD_JUMBO_FRAME' is not set
the max frame size is limited to 'RTE_ETHER_MAX_LEN' (1518).
This is mistake because for the PMDs that has frame size bigger than
"RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN" (18 bytes)
On Fri, Nov 13, 2020 at 2:39 PM Thomas Monjalon wrote:
>
> 13/11/2020 20:18, Radha Mohan:
> > On Tue, Nov 10, 2020 at 11:57 PM Mahipal Challa wrote:
> > From: Radha Mohan
> > Sent: Tuesday, November 10, 2020 11:44 PM
> > > On Mon, Nov 9, 2020 at 4:20 PM Radha Mohan Chintakuntla
> > > wrote:
>
Add NULL check before using t->mbuf_pool.
Coverity issue: 363719
Fixes: 83326 ("event/dlb: add PMD self-tests")
Signed-off-by: Timothy McDaniel
---
drivers/event/dlb/dlb_selftest.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/event/dlb/dlb_selftest.c b/drive
From: Didier Pallard
Three bugs in rx_queue_count function:
- One entry may contain several segments, so 'used' must be multiplied
by number of segments per entry to properly reflect the queue usage.
- The number of cqes is equals to (1U << rxq->elts_n) - 1 in non mqrt
mode. The range returne
This patchset provides several bug fixes for rx queue count calculation for
mlx5 driver.
---
V3:
- fix spelling mistakes
- fix second commit for mprq case
V2:
* squash first patch and second patch
* fix wrong init of used for compressed cqes
Didier Pallard (1):
net/mlx5: fix Rx descriptor sta
The commit d2d57605522d ("net/mlx5: fix Rx queue count calculation") is
incorrect because the count calculation is wrong for the next cqe:
Example:
Compressed Set of packets 1 | Compressed Set of packets 2
C | a | e0 | e1 | e2 | e3 | e4 | e5 | C | a | e0
There are 2 compressed set of packets
On 11/16/2020 7:55 AM, Xiaoyu Min wrote:
From: Dekel Peled
The rte_flow_item_eth and rte_flow_item_vlan items were updated in [1].
The rte_flow_item_ipv6 item was updated in [2].
The structs now contain additional metadata following the header data.
The size to use for match should be the heade
On 11/16/2020 7:55 AM, Xiaoyu Min wrote:
From: Xiaoyu Min
The rte_flow_item_vlan items are refined.
The structs do not exactly represent the packet bits captured on the
wire anymore so should only copy real header instead of the whole struct.
Replace the rte_flow_item_* with the existing corre
On Mon, Nov 16, 2020 at 03:50:31PM +, Juraj Linkeš wrote:
>
>
> > -Original Message-
> > From: Thomas Monjalon
> > Sent: Monday, November 16, 2020 8:33 AM
> > To: Juraj Linkeš
> > Cc: bruce.richard...@intel.com; ruifeng.w...@arm.com;
> > honnappa.nagaraha...@arm.com; phil.y...@arm.c
On 11/16/2020 7:55 AM, Xiaoyu Min wrote:
From: Xiaoyu Min
The rte_flow_item_eth and rte_flow_item_vlan items are refined.
The structs do not exactly represent the packet bits captured on the
wire anymore so should only copy real header instead of the whole struct.
Replace the rte_flow_item_* w
> -Original Message-
> From: Thomas Monjalon
> Sent: Monday, November 16, 2020 9:23 AM
> To: Juraj Linkeš
> Cc: bruce.richard...@intel.com; ruifeng.w...@arm.com;
> honnappa.nagaraha...@arm.com; phil.y...@arm.com;
> vcchu...@amazon.com; dharmik.thak...@arm.com; jerinjac...@gmail.com;
> h
> -Original Message-
> From: Thomas Monjalon
> Sent: Monday, November 16, 2020 8:33 AM
> To: Juraj Linkeš
> Cc: bruce.richard...@intel.com; ruifeng.w...@arm.com;
> honnappa.nagaraha...@arm.com; phil.y...@arm.com;
> vcchu...@amazon.com; dharmik.thak...@arm.com; jerinjac...@gmail.com;
> h
On Mon, Nov 16, 2020 at 03:44:33PM +0100, Thomas Monjalon wrote:
> 16/11/2020 15:27, David Marchand:
> > On Thu, Nov 12, 2020 at 5:39 PM Thomas Monjalon wrote:
> > >
> > > For consistency with other variables which can be set from the env,
> > > TEST_MESON_BUILD_VERBOSE and TEST_MESON_BUILD_VERY_V
16/11/2020 15:27, David Marchand:
> On Thu, Nov 12, 2020 at 5:39 PM Thomas Monjalon wrote:
> >
> > For consistency with other variables which can be set from the env,
> > TEST_MESON_BUILD_VERBOSE and TEST_MESON_BUILD_VERY_VERBOSE
> > are renamed
> > DPDK_BUILD_TEST_VERBOSE and DPDK_BUILD_TEST_VERY
Syncing the data types of msix offset mbox response structure
fields wrt rvu_pfvf structure as in msix offset mbox handler,
respective block LFs response field is initialised with rvu_pfvf
and mismatch in the data types of respective fields may lead
to issues.
This mismatch in data types resulted
On Thu, Nov 12, 2020 at 5:39 PM Thomas Monjalon wrote:
>
> For consistency with other variables which can be set from the env,
> TEST_MESON_BUILD_VERBOSE and TEST_MESON_BUILD_VERY_VERBOSE
> are renamed
> DPDK_BUILD_TEST_VERBOSE and DPDK_BUILD_TEST_VERY_VERBOSE.
It seems a bit odd to take inputs f
>
> On 11/12/2020 4:35 PM, Ciara Loftus wrote:
> > 'uint64_t' is used to hold pointers in multiple locations in the
> > copy-mode code (used for kernels before 5.4). For a 32-bit build
> > this assumption is wrong and results in build errors. This commit
> > replaces such instances of 'uint64_t' w
The new flow table resource management API triggered a PMD crash in
tunnel offload mode, when tunnel match flow rule was inserted before
tunnel set rule.
Reason for the crash was double flow table registration. The table was
registered by the tunnel offload code for the first time and once
more by
The original patch was removing active tunnel offload objects from a
tunnels db list without checking its reference counter value.
That action was leading to a PMD crash.
Current patch isolates tunnels db list into a separate API. That API
manages MT protection of the tunnel offload db.
Fixes: e4
Tunnel offload API is implemented for Direct Verbs environment only.
Current patch re-arranges tunnel related functions for compilation in
non Direct Verbs setups to prevent compilation failures. The patch
does not introduce new functions.
Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload"
The original patch allocated tunnel offload objects with invalid
indexes. As the result, PMD tunnel object allocation failed.
In this patch indexed pool provides both an index and memory for a new
tunnel offload object.
Also tunnel offload ipool moved to dv enabled code only.
Fixes: f2e8093 ("net
Tunnel offload implementation introduced 64 bit-field flow_grp_info
structure. Since the structure size is 64 bits, the code passed that
type by value in function calls.
The patch changes that structure passing method to reference.
Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload")
Signe
Fix mlx5_flow_tunnel_action_release and mlx5_flow_tunnel_item_release
callback names to match tunnel offload names pattern.
Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload")
Signed-off-by: Gregory Etelson
Acked-by: Viacheslav Ovsiienko
---
drivers/net/mlx5/mlx5_flow.c | 17 +--
post merge fixes that restore tunnel offload functionality in mlx5.
v2: resolve compilation error in ubuntu inbox.
v3: re-arrange patches to prevent ubuntu compilation error.
v4: more compilation fixes.
v5: rebase on 20.11-rc4
Gregory Etelson (6):
net/mlx5: fix tunnel offload callback names
n
On Fri, Nov 6, 2020 at 6:09 PM Thomas Monjalon wrote:
>
> Reasons for building not supported generally start with lowercase
> because printed as the second part of a line.
>
> Other changes:
> - "linux" should be "Linux" with a capital letter.
> - ARCH_X86_64 may be simply x86_64.
On Mon, 2020-11-16 at 11:12 +0100, Gaetan Rivet wrote:
> The original triple negative was hard to read and the attempt
> to improve the formulation was commendable, unfortunately the new
> comment is the inverse of correct.
>
> Fixes: a65a34a85ebf ("eal: replace usage of blacklist/whitelist in enu
This patch moves memory region mmaping and related
preparation in a dedicated function in order to simplify
VHOST_USER_SET_MEM_TABLE request handling function.
Signed-off-by: Maxime Coquelin
---
lib/librte_vhost/vhost_user.c | 178 ++
1 file changed, 94 insertions
This patch moves the registration of postcopy to a
dedicated function, with the goal of simplifying
VHOST_USER_SET_MEM_TABLE request handling function.
Signed-off-by: Maxime Coquelin
---
lib/librte_vhost/vhost_user.c | 98 +--
1 file changed, 58 insertions(+), 40
The goal of this series is to refactor vhost_user_set_mem_table
function, to make it easier to understand and maintain.
Maxime Coquelin (3):
vhost: refactor postcopy region registration
vhost: refactor postcopy registration
vhost: refactor memory regions mapping
lib/librte_vhost/vhost_user
This patch moves the registration of memory regions to
userfaultfd to a dedicated function, with the goal of
simplifying VHOST_USER_SET_MEM_TABLE request handling
function.
Signed-off-by: Maxime Coquelin
---
lib/librte_vhost/vhost_user.c | 77 +--
1 file changed,
The original triple negative was hard to read and the attempt
to improve the formulation was commendable, unfortunately the new
comment is the inverse of correct.
Fixes: a65a34a85ebf ("eal: replace usage of blacklist/whitelist in enums")
Cc: step...@networkplumber.org
Signed-off-by: Gaetan Rivet
RTE_DEV_WHITELISTED is now replaced with RTE_DEV_ALLOWED.
Fixes: a65a34a85ebf ("eal: replace usage of blacklist/whitelist in enums")
Signed-off-by: David Marchand
---
drivers/bus/vdev/vdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/vdev/vdev.c b/drivers/bu
All EAL flags tests are run by calling the "eal_flags_autotest" command.
There is no compatibility to maintain for sub commands only called by
meson.
Fixes: db27370b5720 ("eal: replace blacklist/whitelist options")
Signed-off-by: David Marchand
---
app/test/meson.build | 2 +-
app/test/tes
-w option in this context is an application option for coremask.
Restore it.
Fixes: db27370b5720 ("eal: replace blacklist/whitelist options")
Signed-off-by: David Marchand
---
doc/guides/sample_app_ug/eventdev_pipeline.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/
The original patch was removing active tunnel offload objects from a
tunnels db list without checking its reference counter value.
That action was leading to a PMD crash.
Current patch isolates tunnels db list into a separate API. That API
manages MT protection of the tunnel offload db.
Fixes: e4
The new flow table resource management API triggered a PMD crash in
tunnel offload mode, when tunnel match flow rule was inserted before
tunnel set rule.
Reason for the crash was double flow table registration. The table was
registered by the tunnel offload code for the first time and once
more by
The original patch allocated tunnel offload objects with invalid
indexes. As the result, PMD tunnel object allocation failed.
In this patch indexed pool provides both an index and memory for a new
tunnel offload object.
Also tunnel offload ipool moved to dv enabled code only.
Fixes: f2e8093 ("net
Tunnel offload implementation introduced 64 bit-field flow_grp_info
structure. Since the structure size is 64 bits, the code passed that
type by value in function calls.
The patch changes that structure passing method to reference.
Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload")
Signe
Tunnel offload API is implemented for Direct Verbs environment only.
Current patch re-arranges tunnel related functions for compilation in
non Direct Verbs setups to prevent compilation failures. The patch
does not introduce new functions.
Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload"
Fix mlx5_flow_tunnel_action_release and mlx5_flow_tunnel_item_release
callback names to match tunnel offload names pattern.
Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload")
Signed-off-by: Gregory Etelson
Acked-by: Viacheslav Ovsiienko
---
drivers/net/mlx5/mlx5_flow.c | 17 +--
post merge fixes that restore tunnel offload functionality in mlx5.
v2: resolve compilation error in ubuntu inbox.
v3: re-arrange patches to prevent ubuntu compilation error.
v4: more compilation fixes.
Gregory Etelson (6):
net/mlx5: fix tunnel offload callback names
net/mlx5: fix build with
The makefiles for some of the multi_process example files were missing
SPDX license headers, so add them. These Makefiles completely replaced
the older makefiles and were written from scratch, not based on previous
versions, so add a new copyright year on them.
Fixes: 13abe17c3cd4 ("examples/multi
On 11/16/2020 2:14 AM, Stephen Hemminger wrote:
Obvious spelling error in SPDX license header.
Fixes: 12b435bf8f2f ("net/iavf: support flex desc metadata extraction")
Cc: jia@intel.com
Signed-off-by: Stephen Hemminger
Acked-by: Ferruh Yigit
On 11/16/2020 9:24 AM, Ferruh Yigit wrote:
Fixes: 12b435bf8f2f ("net/iavf: support flex desc metadata extraction")
Signed-off-by: Ferruh Yigit
---
Cc: Stephen Hemminger
Just recognized that a patch already sent [1], updating this one as rejected.
[1] https://patches.dpdk.org/patch/84196/
On Sun, Nov 15, 2020 at 06:23:47PM -0800, Stephen Hemminger wrote:
> Make is still used for these examples, so add header to Makefile
>
> Signed-off-by: Stephen Hemminger
> ---
> examples/multi_process/Makefile | 3 +++
> examples/multi_process/client_server_mp/Makefile | 3 +++
Fixes: 12b435bf8f2f ("net/iavf: support flex desc metadata extraction")
Signed-off-by: Ferruh Yigit
---
Cc: Stephen Hemminger
---
drivers/net/iavf/rte_pmd_iavf.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/iavf/rte_pmd_iavf.h b/drivers/net/iavf/rte_pmd_iavf.h
16/11/2020 10:13, Bruce Richardson:
> On Mon, Nov 16, 2020 at 08:24:48AM +0100, Thomas Monjalon wrote:
> > 13/11/2020 15:31, Juraj Linkeš:
> > > +option('max_lcores', type: 'integer', value: 0,
> > > + description: 'maximum number of cores/threads supported by EAL. Set to
> > > positive integer to
On 11/15/2020 10:08 PM, Stephen Hemminger wrote:
Current output of check-spdx-tag.sh
Files without SPDX License
--
doc/guides/custom.css
doc/guides/linux_gsg/nic_perf_intel_platform.rst
drivers/net/iavf/rte_pmd_iavf.h
'rte_pmd_iavf.h' has SPDX license but there is typo
The original patch was removing active tunnel offload objects from a
tunnels db list without checking its reference counter value.
That action was leading to a PMD crash.
Current patch isolates tunnels db list into a separate API. That API
manages MT protection of the tunnel offload db.
Fixes: e4
The new flow table resource management API triggered a PMD crash in
tunnel offload mode, when tunnel match flow rule was inserted before
tunnel set rule.
Reason for the crash was double flow table registration. The table was
registered by the tunnel offload code for the first time and once
more by
Tunnel offload implementation introduced 64 bit-field flow_grp_info
structure. Since the structure size is 64 bits, the code passed that
type by value in function calls.
The patch changes that structure passing method to reference.
Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload")
Signe
The original patch allocated tunnel offload objects with invalid
indexes. As the result, PMD tunnel object allocation failed.
In this patch indexed pool provides both an index and memory for a new
tunnel offload object.
Also tunnel offload ipool moved to dv enabled code only.
Fixes: f2e8093 ("net
Tunnel offload API is implemented for Direct Verbs environment only.
Current patch re-arranges tunnel related functions for compilation in
non Direct Verbs setups to prevent compilation failures. The patch
does not introduce new functions.
Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload"
Fix mlx5_flow_tunnel_action_release and mlx5_flow_tunnel_item_release
callback names to match tunnel offload names pattern.
Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload")
Signed-off-by: Gregory Etelson
Acked-by: Viacheslav Ovsiienko
---
drivers/net/mlx5/mlx5_flow.c | 17 +--
post merge fixes that restore tunnel offload functionality in mlx5.
v2: resolve compilation error in ubuntu inbox.
v3: re-arrange patches to prevent ubuntu compilation error
Gregory Etelson (6):
net/mlx5: fix tunnel offload callback names
net/mlx5: fix build with Direct Verbs disabled
net
On Mon, Nov 16, 2020 at 08:24:48AM +0100, Thomas Monjalon wrote:
> 13/11/2020 15:31, Juraj Linkeš:
> > +option('max_lcores', type: 'integer', value: 0,
> > + description: 'maximum number of cores/threads supported by EAL. Set to
> > positive integer to overwrite per-arch or cross-compilation def
16/11/2020 08:56, Juraj Linkeš:
> From: Thomas Monjalon
> >
> > What do you mean by "disable Arm drivers"?
> > What are "Arm drivers"
> >
>
> These are the drivers that we're disableing for Arm builds. I'll change it to
> something more clearer like "disable drivers in Arm builds"
>
> > 13/11
76 matches
Mail list logo
