On Mon, Nov 16, 2020 at 03:44:33PM +0100, Thomas Monjalon wrote: > 16/11/2020 15:27, David Marchand: > > On Thu, Nov 12, 2020 at 5:39 PM Thomas Monjalon <tho...@monjalon.net> wrote: > > > > > > For consistency with other variables which can be set from the env, > > > TEST_MESON_BUILD_VERBOSE and TEST_MESON_BUILD_VERY_VERBOSE > > > are renamed > > > DPDK_BUILD_TEST_VERBOSE and DPDK_BUILD_TEST_VERY_VERBOSE. > > > > It seems a bit odd to take inputs from both the script parameters and > > the env to control something. > > Those TEST_MESON_BUILD* vars seem internal stuff that should not be exposed. > > I have the same opinion. > I cannot find a good reason for controlling verbosity > with environment variables instead of parameters. > > Bruce is there a reason we are missing? > > See the commit 4bcb9b7686043f: > " > When running ninja, the commands are, by default, always printed on top of > each other. For those who want more detail in the output, two levels of > verbose output has been added to the test-meson-builds script. When "-v" is > passed, or the "TEST_MESON_BUILD_VERBOSE" flag is set in the environment, > then the output of ninja is passed through "cat" to prevent each line > overwriting the next. If "-vv" is passed, or > "TEST_MESON_BUILD_VERY_VERBOSE" is set in the environment, then ninja is > called with the "-v" flag to print out each command in full as it is > executing. > "
No particular reason, it was just that many other things seemed to be controlled by env variables (or read from config into environment), so I added that as an option too. Feel free to just drop it in favour of the flags if you like. /Bruce
