Yes, I will remove str_is function and submit the v3 of this patch soon. On Sat, Nov 14, 2020 at 4:13 PM David Marchand <david.march...@redhat.com> wrote:
> On Wed, Nov 11, 2020 at 9:17 AM Ibtisam Tariq <ibtisam.ta...@emumba.com> > wrote: > > > > Instead of using getopt_long return value, strcmp was used to > > compare the input parameters with the struct option array. This > > patch get rid of all those strcmp by directly binding each longopt > > with an int enum. This is to improve readability and consistency in > > all examples. > > > > Bugzilla ID: 238 > > Cc: step...@networkplumber.org > > > > Reported-by: David Marchand <david.march...@redhat.com> > > Signed-off-by: Ibtisam Tariq <ibtisam.ta...@emumba.com> > > This patch breaks compilation with clang: > https://travis-ci.com/github/ovsrobot/dpdk/jobs/433053506#L1019 > > You can remove this str_is helper. > > > -- > David Marchand > > -- - Ibtisam
