On Fri, Nov 6, 2020 at 6:09 PM Thomas Monjalon <tho...@monjalon.net> wrote:
>
> Reasons for building not supported generally start with lowercase
> because printed as the second part of a line.
>
> Other changes:
> - "linux" should be "Linux" with a capital letter.
> - ARCH_X86_64 may be simply x86_64.
> - aarch64 is preferred over arm64.
>
> Signed-off-by: Thomas Monjalon <tho...@monjalon.net>
After patch, we end up with:
1 'missing dependency, DPDK KNI library'
1 'missing dependency, DPDK VMBus driver'
1 'missing dependency, "libAArch64crypto"'
1 'missing dependency, "libbpf"'
1 'missing dependency, "libisal"'
1 'missing dependency, "libnfb"'
1 'missing dependency, "libpcap"'
1 'missing dependency, "librt"'
1 'missing dependency, "libsze2"'
1 'only supported on Linux and Windows'
1 'only supported on x86'
2 ''
2 'missing dependency, DPDK DPAA2 mempool driver'
2 'missing dependency, DPDK vhost library'
2 'missing dependency, "libcrypto"'
2 'missing dependency, "libfdt"'
2 'missing dependency, "' + libname + '"'
2 'missing dependency, "zlib"'
2 'only supported on x86_64 Linux'
3 'only supported on x86_64 and aarch64'
4 'missing dependency, "libmusdk"'
4 'only supported on 64-bit'
4 'only supported on 64-bit Linux'
5 'IPSec_MB version >= @0@ is required, found version @1@'
5 'missing dependency, "libIPSec_MB"'
6 'not supported on Windows'
32 'only supported on Linux'
I wonder if we could use some helper here, like for OS checks and
avoid getting those strings "not supported on XXX" "only supported on
XXX" in libs/drivers meson.build.
But otherwise, I tried it, looked at meson logs, LGTM.
Acked-by: David Marchand <david.march...@redhat.com>
--
David Marchand
