Re: [dpdk-dev] [PATCH v2] net/ice: support show RSS hash configuration

2020-10-28 Thread Zhu, TaoX
Thanks, Qi I'll send v3 patch according to your comments. BRs, Zhu Tao -Original Message- From: Zhang, Qi Z Sent: Thursday, October 29, 2020 1:53 PM To: Zhu, TaoX ; Yang, Qiming Cc: dev@dpdk.org; Zhu, TaoX Subject: RE: [PATCH v2] net/ice: support show RSS hash configuration >

[dpdk-dev] [PATCH v1] gso: add VXLAN UDP GSO support

2020-10-28 Thread yang_y_yi
From: Yi Yang Many NICs can't offload VXLAN UFO, so it is very important to do VXLAN UDP GSO by software to improve VM-to-VM UDP performance, especially for the case that VM MTU is just 1500 but not 9000. With this enabled in DPDK, OVS DPDK can leverage it to improve VM-to-VM UDP performance, pe

[dpdk-dev] [PATCH v3] net/ice: support show RSS hash configuration

2020-10-28 Thread taox . zhu
From: Zhu Tao Implement interface 'ice_rss_hash_conf_get' to support show RSS hash configuration. Note: Not support the same time setting RSS with RTE and classify API. Only return rss_hf from latest dev_configure or dev_rss_hash_update. All configures from rte_flow are ignored. Signed-off-by:

Re: [dpdk-dev] [PATCH v2] net/ice: support show RSS hash configuration

2020-10-28 Thread Zhang, Qi Z
> -Original Message- > From: taox@intel.com > Sent: Thursday, October 29, 2020 1:11 PM > To: Yang, Qiming ; Zhang, Qi Z > > Cc: dev@dpdk.org; Zhu, TaoX > Subject: [PATCH v2] net/ice: support show RSS hash configuration > > From: Zhu Tao > > Implement interface 'ice_rss_hash_con

Re: [dpdk-dev] [PATCH v2] net/ice: fix DCF Rx segmentation fault

2020-10-28 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Haiyue > Sent: Thursday, October 29, 2020 9:13 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Wang, Haiyue > ; Zhang, AlvinX ; Yang, > Qiming ; Guo, Jia > Subject: [PATCH v2] net/ice: fix DCF Rx segmentation fault > > The initialization of selecting the h

[dpdk-dev] [PATCH] app/testpmd: fix the eCPRI command line style

2020-10-28 Thread Bing Zhao
In the current implementation of eCPRI flow item parsing of the CLI, the token items in the list are not connected properly. A command containing "rtc_ctrl rtc_id spec 14857 rtc_id mask 0xff00" will be considered invalid. In order to support spec with mask, the common entry needs to be typed twice

[dpdk-dev] [PATCH v2] net/ice: support show RSS hash configuration

2020-10-28 Thread taox . zhu
From: Zhu Tao Implement interface 'ice_rss_hash_conf_get' to support show RSS hash configuration. Note: Not support the same time setting RSS with RTE and classify API. Signed-off-by: Zhu Tao --- drivers/net/ice/ice_ethdev.c | 15 +-- drivers/net/ice/ice_ethdev.h | 1 + 2 fil

[dpdk-dev] [DPDK] net/ice: support show RSS hash configuration

2020-10-28 Thread taox . zhu
From: Zhu Tao Implement interface 'ice_rss_hash_conf_get' to support show RSS hash configuration. Note: Not support the same time set RSS with RTE and classify API. Signed-off-by: Zhu Tao --- drivers/net/ice/ice_ethdev.c | 15 +-- drivers/net/ice/ice_ethdev.h | 1 + 2 files c

Re: [dpdk-dev] [PATCH] app/testpmd: don't allow to dynamic change nbcore

2020-10-28 Thread Dharmik Thakkar
Hi Zhou, Although, I see that a few of the configuration options are checking for ’test_done’, I am wondering if it is truly required. Since, as per the documentation guidelines: 'Configuration changes only become active when forwarding is started/restarted.’ > On Oct 27, 2020, at 1:42 AM, Zhou

Re: [dpdk-dev] Adding to mailing list

2020-10-28 Thread Venumadhav Josyula
Hi, Please use this link for subscription https://mails.dpdk.org/listinfo/dev#:~:text=To%20post%20a%20message%20to,subscription%2C%20in%20the%20sections%20below.&text=Subscribe%20to%20dev%20by%20filling,others%20from%20gratuitously%20subscribing%20you . or google for dpdk dev subscription. Chee

Re: [dpdk-dev] [RFC PATCH v3 3/6] build: automatic NUMA and cpu counts detection

2020-10-28 Thread Honnappa Nagarahalli
> > > > > > On Wed, Oct 21, 2020 at 01:37:38PM +0200, Juraj Linkeš wrote: > > > > The build machine's number of cpus and numa nodes vary, resulting > > > > in mismatched counts of RTE_MAX_LCORE and > RTE_MAX_NUMA_NODES for > > > many > > > > builds. Automatically discover the host's numa and cpu

Re: [dpdk-dev] [PATCH v7 0/3] enable AVX512 for iavf

2020-10-28 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Wenzhuo Lu > Sent: Thursday, October 29, 2020 9:24 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH v7 0/3] enable AVX512 for iavf > > AVX512 instructions is supported by more and more platforms. These > instructions ca

Re: [dpdk-dev] [dpdk-announce] release candidate 20.11-rc1

2020-10-28 Thread Pei Zhang
Hello Thomas, Testing with dpdk 20.11-rc1 from Red Hat looks good. We cover below 16 scenarios and and all get PASS on RHEL8 testing: (1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS (2)Guest with device assignment(PF) throughput testing(2M hugepage size) : PASS (3)

[dpdk-dev] [PATCH v2] net/ice: fix DCF Rx segmentation fault

2020-10-28 Thread Haiyue Wang
The initialization of selecting the handler for scalar Rx path FlexiMD fields extraction into mbuf is missed, it will cause segmentation fault (core dumped). Also add the missed support to handle RXDID 16, which has RSS hash value on Qword 1. Fixes: 7a340b0b4e03 ("net/ice: refactor Rx FlexiMD han

[dpdk-dev] [PATCH v7 3/3] net/iavf: enable AVX512 for Tx

2020-10-28 Thread Wenzhuo Lu
To enhance the per-core performance, this patch adds some AVX512 instructions to the data path to handle the Tx descriptors. Signed-off-by: Wenzhuo Lu Signed-off-by: Bruce Richardson Signed-off-by: Leyi Rong --- doc/guides/rel_notes/release_20_11.rst | 3 + drivers/net/iavf/iavf_ethdev.c

[dpdk-dev] [PATCH v7 2/3] net/iavf: enable AVX512 for flexible Rx

2020-10-28 Thread Wenzhuo Lu
To enhance the per-core performance, this patch adds some AVX512 instructions to the data path to handle the flexible Rx descriptors. Signed-off-by: Wenzhuo Lu Signed-off-by: Bruce Richardson Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx.c| 10 + drivers/net/iavf/iavf_rx

[dpdk-dev] [PATCH v7 0/3] enable AVX512 for iavf

2020-10-28 Thread Wenzhuo Lu
AVX512 instructions is supported by more and more platforms. These instructions can be used in the data path to enhance the per-core performance of packet processing. Comparing with the existing implementation, this path set introduces some AVX512 instructions into the iavf data path, and we get

[dpdk-dev] [PATCH v7 1/3] net/iavf: enable AVX512 for legacy Rx

2020-10-28 Thread Wenzhuo Lu
To enhance the per-core performance, this patch adds some AVX512 instructions to the data path to handle the legacy Rx descriptors. Signed-off-by: Wenzhuo Lu Signed-off-by: Bruce Richardson Signed-off-by: Leyi Rong --- drivers/net/iavf/iavf_rxtx.c| 29 +- drivers/net/iavf/iavf_rxt

Re: [dpdk-dev] [PATCH v1] net/ice: fix DCF Rx segmentation fault

2020-10-28 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Haiyue > Sent: Thursday, October 29, 2020 12:56 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Wang, Haiyue > ; Zhang, AlvinX ; Yang, > Qiming ; Guo, Jia > Subject: [PATCH v1] net/ice: fix DCF Rx segmentation fault > > The initialization for the handler o

Re: [dpdk-dev] [PATCH v2 1/1] build: add Graviton2(arm64) meson configuration

2020-10-28 Thread Honnappa Nagarahalli
> > > > Hello, > > IMO, Juraj's patch for meson build rework for Arm platforms will > > need > some time. Keeping the RC2 deadline in mind, it makes sense to accept this > patch and target Juraj's patch for 21.02. > > > > Any opinions? > > I feel, Recent Juraj's changes looks in good sh

Re: [dpdk-dev] [PATCH v3] net/mlx5: use C11 atomics in packet scheduling

2020-10-28 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Wednesday, October 28, 2020 2:45 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh > Subject: [PATCH v3] net/mlx5: use C11 atomics in packet scheduling > > The rte_atomic API is deprecated and needs to be replaced with > C11 atom

Re: [dpdk-dev] [EXT] [PATCH v2] eal: fix dereference after null check

2020-10-28 Thread Harman Kalra
On Thu, Oct 15, 2020 at 04:42:30PM +0800, wangyunjian wrote: > External Email > > -- > From: Yunjian Wang > > This patch fixes (dereference after null check) coverity issue. > For this reason, we should add null check at the beg

Re: [dpdk-dev] [DPDK_KMODS v4] linux/igb_uio: add Makefile to build the kernel module

2020-10-28 Thread Narcisa Ana Maria Vasile
On Thu, Oct 08, 2020 at 10:40:08AM +0100, Hariprasad Govindharajan wrote: > With DPDK 20.11 release, the igb_uio module is no more part of DPDK. > There are use cases where this module is required, for example while > testing the virtual ports in OvS, the virtual ports are bound to > igb_uio module

[dpdk-dev] [PATCH v2 3/4] trace: fix metadata dump

2020-10-28 Thread David Marchand
The ctf metadata is written to the metadata file without any check for length, so this string must be null terminated. Fixes: f1a099f5b1f1 ("trace: create CTF TDSL metadata in memory") Signed-off-by: David Marchand --- lib/librte_eal/common/eal_common_trace_ctf.c | 3 ++- 1 file changed, 2 inse

[dpdk-dev] [PATCH v2 4/4] trace: make CTF metadata prettier

2020-10-28 Thread David Marchand
This is simply a cosmetic change. Before: event { id = 17; name = "lib.eal.alarm.set"; fields := struct { uint64_t us;uintptr_t cb_fn;uintptr_t cb_arg;int32_t rc; }; }; After: event { id = 17; name = "lib.eal.alarm.set"; fields := struct { uint64_t us;

[dpdk-dev] [PATCH v2 1/4] trace: fixup CTF event description at registration

2020-10-28 Thread David Marchand
CTF event description is currently built by appending all fields in a single string at trace point registration. When dumping the metadata, this string is split again and inspected to fixup reserved keywords and special tokens like "." or "->". Move this fixup per field at trace point registration

Re: [dpdk-dev] [PATCH v10 0/9] Add PMD power mgmt

2020-10-28 Thread Ajit Khaparde
On Wed, Oct 28, 2020 at 9:47 AM Liang, Ma wrote: > > On 28 Oct 21:27, Jerin Jacob wrote: > > On Wed, Oct 28, 2020 at 9:19 PM Ananyev, Konstantin > > wrote: > > > > > > > > 28/10/2020 14:49, Jerin Jacob: > > > > > > > > > On Wed, Oct 28, 2020 at 7:05 PM Liang, Ma > > > > > > > > > wrote: > > > >

[dpdk-dev] [PATCH v2 0/4] Rework CTF event description storage

2020-10-28 Thread David Marchand
Following recent increase of an internal array that was limiting CTF event descriptions, I had a second look at the code. All of this is slow path, so I see no reason in keeping this limitation and we can go with dynamic allocations. -- David Marchand Changelog since v1: - fix metadata dump, Da

[dpdk-dev] [PATCH v2 2/4] trace: remove size limit on CTF event description

2020-10-28 Thread David Marchand
Rework registration so that it uses dynamic allocations and has no size limit. Signed-off-by: David Marchand Reviewed-by: Jerin Jacob --- lib/librte_eal/common/eal_common_trace.c | 39 +--- lib/librte_eal/common/eal_common_trace_ctf.c | 3 +- lib/librte_eal/common/eal_trace

Re: [dpdk-dev] [PATCH v15 0/8] fib: implement AVX512 vector lookup

2020-10-28 Thread David Marchand
On Tue, Oct 27, 2020 at 4:11 PM Vladimir Medvedkin wrote: > > This patch series implements vectorized lookup using AVX512 for > ipv4 dir24_8 and ipv6 trie algorithms. > Also introduced rte_fib_set_lookup_fn() to change lookup function type. > Added option to select lookup function type in testfib

Re: [dpdk-dev] [PATCH] common/mlx5: fix memory allocation debug stats

2020-10-28 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, October 28, 2020 8:21 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Slava Ovsiienko > ; Matan Azrad > Subject: [PATCH] common/mlx5: fix memory allocation debug stats > > Fix compilation issue for memory allocation s

Re: [dpdk-dev] [PATCH v5 1/7] app/bbdev: add explicit ut for latency vs validation

2020-10-28 Thread Tom Rix
On 10/26/20 10:30 AM, Chautru, Nicolas wrote: >> -Original Message- >> From: Tom Rix >> Sent: Monday, October 26, 2020 5:56 AM >> To: Chautru, Nicolas ; dev@dpdk.org; >> akhil.go...@nxp.com >> Cc: david.march...@redhat.com >> Subject: Re: [PATCH v5 1/7] app/bbdev: add explicit ut for lat

Re: [dpdk-dev] [EXT] [PATCH v2 1/1] librte_eal: rte_intr_callback_unregister_sync() - wrapper around rte_intr_callback_unregister().

2020-10-28 Thread Harman Kalra
On Mon, Aug 17, 2020 at 04:08:27PM +0200, Renata Saiakhova wrote: > External Email > > -- > Avoid race with unregister interrupt hanlder if interrupt > source has some active callbacks at the moment, use wrapper > around rte_intr_

Re: [dpdk-dev] [PATCH v5 3/7] app/bbdev: include explicit HARQ preloading

2020-10-28 Thread Tom Rix
On 10/26/20 9:50 AM, Chautru, Nicolas wrote: >> -Original Message- >> From: Tom Rix >> Sent: Monday, October 26, 2020 6:32 AM >> To: Chautru, Nicolas ; dev@dpdk.org; >> akhil.go...@nxp.com >> Cc: david.march...@redhat.com >> Subject: Re: [PATCH v5 3/7] app/bbdev: include explicit HARQ pr

Re: [dpdk-dev] [PATCH v5 2/7] app/bbdev: add explicit check for counters

2020-10-28 Thread Tom Rix
On 10/26/20 9:29 AM, Chautru, Nicolas wrote: >> -Original Message- >> From: Tom Rix >> Sent: Monday, October 26, 2020 6:06 AM >> To: Chautru, Nicolas ; dev@dpdk.org; >> akhil.go...@nxp.com >> Cc: david.march...@redhat.com >> Subject: Re: [PATCH v5 2/7] app/bbdev: add explicit check for c

Re: [dpdk-dev] [PATCH v5 7/7] app/bbdev: update offload test to dequeue full ring

2020-10-28 Thread Tom Rix
On 10/26/20 9:27 AM, Chautru, Nicolas wrote: >> -Original Message- >> From: Tom Rix >> Sent: Monday, October 26, 2020 6:56 AM >> To: Chautru, Nicolas ; dev@dpdk.org; >> akhil.go...@nxp.com >> Cc: david.march...@redhat.com >> Subject: Re: [PATCH v5 7/7] app/bbdev: update offload test to d

Re: [dpdk-dev] [PATCH v5 4/7] app/bbdev: define wait for offload

2020-10-28 Thread Tom Rix
On 10/26/20 9:04 AM, Chautru, Nicolas wrote: >> From: Tom Rix >> Sent: Monday, October 26, 2020 6:33 AM >> To: Chautru, Nicolas ; dev@dpdk.org; >> akhil.go...@nxp.com >> Cc: david.march...@redhat.com >> Subject: Re: [PATCH v5 4/7] app/bbdev: define wait for offload >> >> >> On 10/23/20 4:42 PM,

[dpdk-dev] [PATCH] common/mlx5: fix memory allocation debug stats

2020-10-28 Thread Alexander Kozyrev
Fix compilation issue for memory allocation stats in case of the RTE_LIBRTE_MLX5_DEBUG is enabled. The mlx5_sys_mem is static and its members should be accessed via member operator, not a pointer. Fixes: 1f34e138f8 ("common/mlx5: use C11 atomics for memory allocation") Signed-off-by: Alexander Ko

[dpdk-dev] [PATCH dpdk-kmods] igb_uio: include MODULE_CFLAGS in Kbuild

2020-10-28 Thread luca . boccassi
From: Luca Boccassi Necessary to get build flags from DKMS. See: https://git.dpdk.org/dpdk/commit/?id=816d967717 Signed-off-by: Luca Boccassi --- linux/igb_uio/Kbuild | 1 + 1 file changed, 1 insertion(+) diff --git a/linux/igb_uio/Kbuild b/linux/igb_uio/Kbuild index 98c98fe..3ab85c4 100644

Re: [dpdk-dev] [PATCH v10 0/9] Add PMD power mgmt

2020-10-28 Thread Ananyev, Konstantin
> -Original Message- > From: Ajit Khaparde > Sent: Wednesday, October 28, 2020 5:02 PM > To: Ma, Liang J > Cc: Jerin Jacob ; Ananyev, Konstantin > ; Thomas Monjalon > ; dpdk-dev ; Ruifeng Wang (Arm Technology > China) ; Wang, Haiyue > ; Richardson, Bruce ; > Hunt, David ; Neil Horman

Re: [dpdk-dev] [PATCH v4] node: switch IPv4 metadata to dynamic mbuf field

2020-10-28 Thread Thomas Monjalon
28/10/2020 11:24, Van Haaren, Harry: > From: Thomas Monjalon > > > + IP4_LOOKUP_NODE_PRIV1_OFF(node->ctx) = node_mbuf_priv1_dynfield_offset; > > > > That's interesting. > > You copy the offset in the node context for better performance. > > How much is it better than with global offset variable? >

Re: [dpdk-dev] [PATCH v5 01/34] net/mlx5: use thread safe index pool for flow objects

2020-10-28 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Wednesday, October 28, 2020 11:33 AM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v5 01/34] net/mlx5: use thread safe index pool for flow > objects > > As mlx5 PMD is c

[dpdk-dev] [PATCH] mlx5/net: fix release of SQ resources in error flow

2020-10-28 Thread Tal Shnaiderman
Fix in error flow in which the function mlx5_txq_release_devx_sq_resources is called twice by setting the release object to NULL after the first call The incorrect flow was introduced in the work done on generic object creation. Once an error flow inside mlx5_txq_create_devx_sq_resources occurs t

[dpdk-dev] [PATCH v1] net/ice: fix DCF Rx segmentation fault

2020-10-28 Thread Haiyue Wang
The initialization for the handler of Rx FlexiMD fields extraction into mbuf is missed, it will cause segmentation fault (core dumped). Fixes: 7a340b0b4e03 ("net/ice: refactor Rx FlexiMD handling") Reported-by: Alvin Zhang Signed-off-by: Haiyue Wang --- drivers/net/ice/ice_dcf.c | 1 + driver

Re: [dpdk-dev] [PATCH v4 2/6] build: refactor Arm build

2020-10-28 Thread Honnappa Nagarahalli
> > * Rename variables to have names that better describe what the variables > store > * Remove unused or superfluous variables > * Change a list to dictionary where key lookup is needed > * Add informatory comments in the code > * Minor code restructure and reformatting > > Signed-off-by: Jura

Re: [dpdk-dev] [PATCH v10 0/9] Add PMD power mgmt

2020-10-28 Thread McDaniel, Timothy
> -Original Message- > From: Ma, Liang J > Sent: Wednesday, October 28, 2020 11:48 AM > To: Jerin Jacob > Cc: Ananyev, Konstantin ; Thomas Monjalon > ; dpdk-dev ; Ruifeng Wang (Arm > Technology China) ; Wang, Haiyue > ; Richardson, Bruce ; > Hunt, David ; Neil Horman ; > McDaniel, Timot

Re: [dpdk-dev] [PATCH v10 0/9] Add PMD power mgmt

2020-10-28 Thread Liang, Ma
On 28 Oct 21:27, Jerin Jacob wrote: > On Wed, Oct 28, 2020 at 9:19 PM Ananyev, Konstantin > wrote: > > > > > > > 28/10/2020 14:49, Jerin Jacob: > > > > > > > > On Wed, Oct 28, 2020 at 7:05 PM Liang, Ma > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > Hi Thomas, > > > > > > > > > I th

Re: [dpdk-dev] [PATCH v10 0/9] Add PMD power mgmt

2020-10-28 Thread Ananyev, Konstantin
> > On Wed, Oct 28, 2020 at 9:19 PM Ananyev, Konstantin > wrote: > > > > > > > > > -Original Message- > > > From: Jerin Jacob > > > Sent: Wednesday, October 28, 2020 3:40 PM > > > To: Ananyev, Konstantin > > > Cc: Thomas Monjalon ; Ma, Liang J > > > ; dpdk-dev ; Ruifeng Wang (Arm > >

Re: [dpdk-dev] [PATCH v2 0/3] Allow overriding of build-time constants

2020-10-28 Thread Bruce Richardson
On Thu, Sep 03, 2020 at 03:49:39PM +0100, Bruce Richardson wrote: > A number of the more advanced DPDK build settings which are not expected to > be user modified are stored in config/rte_config.h. In some cases, for a > custom build a user may want to override those settings via CFLAGS, so we > ne

Re: [dpdk-dev] [EXT] Re: [PATCH 2/2] vfio: fix partial DMA unmapping for VFIO type1

2020-10-28 Thread Nithin Dabilpuram
On Wed, Oct 28, 2020 at 04:07:17PM +, Burakov, Anatoly wrote: > On 28-Oct-20 2:17 PM, Nithin Dabilpuram wrote: > > On Wed, Oct 28, 2020 at 01:04:26PM +, Burakov, Anatoly wrote: > > > On 22-Oct-20 1:13 PM, Nithin Dabilpuram wrote: > > > > Ping. > > > > > > > > On Mon, Oct 19, 2020 at 03:13:

[dpdk-dev] [PATCH v3 3/3] examples/mp_server: clear string truncation warning

2020-10-28 Thread Bruce Richardson
Compiling with GCC 9.3 on Ubuntu 20.04 gives a warning about possible string truncation when getting the RX queue name: In file included from init.c:36: init.c: In function ‘init’: ../shared/common.h:38:28: warning: ‘%u’ directive output may be truncated writing between 1 and 10 bytes into a regi

[dpdk-dev] [PATCH v3 0/3] fixes for example app builds

2020-10-28 Thread Bruce Richardson
While helping prepare some patches for converting the DPDK examples to build using pkg-config, a number of errors and warnings were encountered in the example app builds. These patches fix those issues. v3: Dropped patch 1, since other approaches to fix this are being investigated,

[dpdk-dev] [PATCH v3 1/3] examples/vm_power_manager: fix string truncation warning

2020-10-28 Thread Bruce Richardson
When compiling on ubuntu 20.04, a warning was issued about possible truncation of the path string for the power management socket. channel_manager.c: In function ‘add_all_channels’: channel_manager.c:470:41: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of

[dpdk-dev] [PATCH v3 2/3] examples/mp_server: fix snprintf overflow

2020-10-28 Thread Bruce Richardson
When producing a printable mac address the buffer was appropriately sized for holding the mac address exactly, but the actual snprintf included a '\n' character at the end, which means that the snprintf technically is getting truncated i.e. the \n would not be added due to lack of space. This gets

Re: [dpdk-dev] [PATCH] hash: fix dereference before null check

2020-10-28 Thread Wang, Yipeng1
> -Original Message- > From: wangyunjian > Sent: Tuesday, October 27, 2020 5:51 AM > To: dev@dpdk.org; Wang, Yipeng1 ; Gobriel, Sameh > > Cc: Richardson, Bruce ; > dharmik.thak...@arm.com; jerry.lili...@huawei.com; xudin...@huawei.com; > Yunjian Wang ; sta...@dpdk.org > Subject: [dpdk-dev

Re: [dpdk-dev] [PATCH v10 0/9] Add PMD power mgmt

2020-10-28 Thread Liang, Ma
On 28 Oct 21:31, Jerin Jacob wrote: > On Wed, Oct 28, 2020 at 9:14 PM Liang, Ma wrote: > > > > On 28 Oct 21:06, Jerin Jacob wrote: > > > On Wed, Oct 28, 2020 at 9:00 PM Liang, Ma wrote: > > > > > > > > On 28 Oct 20:44, Jerin Jacob wrote: > > > > > On Wed, Oct 28, 2020 at 8:27 PM Ananyev, Konstant

Re: [dpdk-dev] [EXT] Re: [PATCH 2/2] vfio: fix partial DMA unmapping for VFIO type1

2020-10-28 Thread Burakov, Anatoly
On 28-Oct-20 2:17 PM, Nithin Dabilpuram wrote: On Wed, Oct 28, 2020 at 01:04:26PM +, Burakov, Anatoly wrote: On 22-Oct-20 1:13 PM, Nithin Dabilpuram wrote: Ping. On Mon, Oct 19, 2020 at 03:13:15PM +0530, Nithin Dabilpuram wrote: On Sat, Oct 17, 2020 at 05:14:55PM +0100, Burakov, Anatoly w

Re: [dpdk-dev] [PATCH v10 0/9] Add PMD power mgmt

2020-10-28 Thread Jerin Jacob
On Wed, Oct 28, 2020 at 9:14 PM Liang, Ma wrote: > > On 28 Oct 21:06, Jerin Jacob wrote: > > On Wed, Oct 28, 2020 at 9:00 PM Liang, Ma wrote: > > > > > > On 28 Oct 20:44, Jerin Jacob wrote: > > > > On Wed, Oct 28, 2020 at 8:27 PM Ananyev, Konstantin > > > > wrote: > > > > > > > > > > > > > > > >

Re: [dpdk-dev] [PATCH 0/3] Rework CTF event description storage

2020-10-28 Thread David Marchand
On Wed, Oct 28, 2020 at 4:17 PM David Marchand wrote: > This fixes it: > @@ -37,11 +37,12 @@ meta_copy(char **meta, int *offset, char *str, int rc) > if (rc < 0) > return rc; > > - ptr = realloc(ptr, count + rc); > + ptr = realloc(ptr, count + rc + 1); >

Re: [dpdk-dev] [PATCH v10 0/9] Add PMD power mgmt

2020-10-28 Thread Jerin Jacob
On Wed, Oct 28, 2020 at 9:19 PM Ananyev, Konstantin wrote: > > > > > -Original Message- > > From: Jerin Jacob > > Sent: Wednesday, October 28, 2020 3:40 PM > > To: Ananyev, Konstantin > > Cc: Thomas Monjalon ; Ma, Liang J > > ; dpdk-dev ; Ruifeng Wang (Arm > > Technology China) ; Wang,

[dpdk-dev] [PATCH] examples/fips_validation: fix resource leak on failure

2020-10-28 Thread Ciara Power
The dst variable went out of scope on failure in the get_writeback_data function. This is now freed before returning -1. Coverity issue: 363453 Fixes: 952e10cdad5e ("examples/fips_validation: support scatter gather list") Cc: roy.fan.zh...@intel.com Signed-off-by: Ciara Power --- examples/fips_

Re: [dpdk-dev] [PATCH v10 0/9] Add PMD power mgmt

2020-10-28 Thread Ananyev, Konstantin
> -Original Message- > From: Jerin Jacob > Sent: Wednesday, October 28, 2020 3:40 PM > To: Ananyev, Konstantin > Cc: Thomas Monjalon ; Ma, Liang J > ; dpdk-dev ; Ruifeng Wang (Arm > Technology China) ; Wang, Haiyue > ; Richardson, Bruce > ; Hunt, David ; Neil Horman > ; McDaniel, Tim

Re: [dpdk-dev] [PATCH v10 0/9] Add PMD power mgmt

2020-10-28 Thread Liang, Ma
On 28 Oct 21:06, Jerin Jacob wrote: > On Wed, Oct 28, 2020 at 9:00 PM Liang, Ma wrote: > > > > On 28 Oct 20:44, Jerin Jacob wrote: > > > On Wed, Oct 28, 2020 at 8:27 PM Ananyev, Konstantin > > > wrote: > > > > > > > > > > > > > > > > > 28/10/2020 14:49, Jerin Jacob: > > > > > > On Wed, Oct 28, 20

Re: [dpdk-dev] [PATCH v10 0/9] Add PMD power mgmt

2020-10-28 Thread Jerin Jacob
On Wed, Oct 28, 2020 at 9:04 PM Ananyev, Konstantin wrote: > > > > > > > 28/10/2020 14:49, Jerin Jacob: > > > > > On Wed, Oct 28, 2020 at 7:05 PM Liang, Ma > > > > > wrote: > > > > > > > > > > > > Hi Thomas, > > > > > > I think I addressed all of the questions in relation to V9. I > > > > > >

[dpdk-dev] [PATCH] examples/fips_validation: fix checking return value

2020-10-28 Thread Ciara Power
The return value was not being checked when calling the get_writeback_data function in the AES test case. On failure, this led to a NULL dereference when using memcpy later. The return value is now checked to avoid this NULL dereference. Coverity issue: 363463 Fixes: cd255ccf5764 ("examples/fips_v

Re: [dpdk-dev] [PATCH v10 0/9] Add PMD power mgmt

2020-10-28 Thread Jerin Jacob
On Wed, Oct 28, 2020 at 9:00 PM Liang, Ma wrote: > > On 28 Oct 20:44, Jerin Jacob wrote: > > On Wed, Oct 28, 2020 at 8:27 PM Ananyev, Konstantin > > wrote: > > > > > > > > > > > > > 28/10/2020 14:49, Jerin Jacob: > > > > > On Wed, Oct 28, 2020 at 7:05 PM Liang, Ma > > > > > wrote: > > > > > > >

Re: [dpdk-dev] [PATCH v10 0/9] Add PMD power mgmt

2020-10-28 Thread Ananyev, Konstantin
> > > 28/10/2020 14:49, Jerin Jacob: > > > > On Wed, Oct 28, 2020 at 7:05 PM Liang, Ma wrote: > > > > > > > > > > Hi Thomas, > > > > > I think I addressed all of the questions in relation to V9. I don't > > > > > think I can solve the issue of a generic API on my own. From the > > > Community

Re: [dpdk-dev] [PATCH v10 0/9] Add PMD power mgmt

2020-10-28 Thread Liang, Ma
On 28 Oct 20:44, Jerin Jacob wrote: > On Wed, Oct 28, 2020 at 8:27 PM Ananyev, Konstantin > wrote: > > > > > > > > > 28/10/2020 14:49, Jerin Jacob: > > > > On Wed, Oct 28, 2020 at 7:05 PM Liang, Ma wrote: > > > > > > > > > > Hi Thomas, > > > > > I think I addressed all of the questions in relat

Re: [dpdk-dev] [dpdk-techboard] [v4 1/3] cryptodev: support enqueue callback functions

2020-10-28 Thread Honnappa Nagarahalli
+ Ray for ABI > > On Wed, Oct 28, 2020 at 02:28:43PM +, Akhil Goyal wrote: > > > > Hi Konstantin, > > > > > > > Hi Tech board members, > > > > > > > > > > I have a doubt about the ABI breakage in below addition of field. > > > > > Could you please comment. > > > > > > > > > > > /** The dat

Re: [dpdk-dev] [PATCH 0/3] Rework CTF event description storage

2020-10-28 Thread David Marchand
On Wed, Oct 28, 2020 at 2:09 PM David Marchand wrote: > > echo "trace_autotest" | ./build/app/test/dpdk-test -c 0x3 --trace=.* > > --no-huge --trace=.* > > Err, indeed, thanks for catching. > I did some diff on metadata files, but did not notice this trailing character. > > This is an issue with

Re: [dpdk-dev] [PATCH v10 0/9] Add PMD power mgmt

2020-10-28 Thread Jerin Jacob
On Wed, Oct 28, 2020 at 8:27 PM Ananyev, Konstantin wrote: > > > > > 28/10/2020 14:49, Jerin Jacob: > > > On Wed, Oct 28, 2020 at 7:05 PM Liang, Ma wrote: > > > > > > > > Hi Thomas, > > > > I think I addressed all of the questions in relation to V9. I don't > > > > think I can solve the issue

Re: [dpdk-dev] [dpdk-techboard] [v4 1/3] cryptodev: support enqueue callback functions

2020-10-28 Thread Bruce Richardson
On Wed, Oct 28, 2020 at 02:28:43PM +, Akhil Goyal wrote: > > Hi Konstantin, > > > > > Hi Tech board members, > > > > > > > > I have a doubt about the ABI breakage in below addition of field. > > > > Could you please comment. > > > > > > > > > /** The data structure associated with each crypt

Re: [dpdk-dev] [PATCH v5 11/11] build: update Arm builds with makefile flags

2020-10-28 Thread Bruce Richardson
On Wed, Oct 28, 2020 at 03:04:05PM +0100, Juraj Linkeš wrote: > Not all flags were moved properly from the old Makefile build system. > Disable corresponding drivers and libnuma in cross files and remove > deprecated config. > > Signed-off-by: Juraj Linkeš > --- > config/arm/arm64_armada_linux_g

Re: [dpdk-dev] [PATCH v5 08/11] build: optional NUMA and cpu counts detection

2020-10-28 Thread Bruce Richardson
On Wed, Oct 28, 2020 at 03:04:02PM +0100, Juraj Linkeš wrote: > Add an option to automatically discover the host's numa and cpu counts > and use those values for a non cross-build. > Give users the option to override the per-arch default values or values > from cross files by specifying them on the

Re: [dpdk-dev] [PATCH v10 0/9] Add PMD power mgmt

2020-10-28 Thread Ananyev, Konstantin
> 28/10/2020 14:49, Jerin Jacob: > > On Wed, Oct 28, 2020 at 7:05 PM Liang, Ma wrote: > > > > > > Hi Thomas, > > > I think I addressed all of the questions in relation to V9. I don't > > > think I can solve the issue of a generic API on my own. From the > Community Call last week Jerin also

Re: [dpdk-dev] [v4 1/3] cryptodev: support enqueue callback functions

2020-10-28 Thread Ananyev, Konstantin
Hi Akhil, > Hi Konstantin, > > > > > Hi Tech board members, > > > > > > > > I have a doubt about the ABI breakage in below addition of field. > > > > Could you please comment. > > > > > > > > > /** The data structure associated with each crypto device. */ struct > > > > > rte_cryptodev { > >

Re: [dpdk-dev] [PATCH 1/1] eventdev: increase MAX QUEUES PER DEV to 255

2020-10-28 Thread McDaniel, Timothy
> -Original Message- > From: Jerin Jacob > Sent: Wednesday, October 28, 2020 4:36 AM > To: McDaniel, Timothy > Cc: Richardson, Bruce ; dpdk-dev > ; Carrillo, Erik G ; Eads, Gage > ; Van Haaren, Harry ; > Jerin Jacob > Subject: Re: [dpdk-dev] [PATCH 1/1] eventdev: increase MAX QUEUES PE

Re: [dpdk-dev] [PATCH v5 01/11] build: alias default build as generic

2020-10-28 Thread Bruce Richardson
On Wed, Oct 28, 2020 at 03:03:55PM +0100, Juraj Linkeš wrote: > The current machine='default' build name is not descriptive. The actual > default build is machine='native'. Add an alternative string which does > the same build and better describes what we're building: > machine='generic'. Leave mac

Re: [dpdk-dev] [PATCH v1 40/72] net/mlx5/windows: define errno ETOOMANYREFS

2020-10-28 Thread Tal Shnaiderman
> Subject: Re: [PATCH v1 40/72] net/mlx5/windows: define errno > ETOOMANYREFS > > External email: Use caution opening links or attachments > > > 28/10/2020 00:23, Ophir Munk: > > Errno ETOOMANYREFS may not be supported under Windows. In such > cases > > add its definition. > > Please add it for

Re: [dpdk-dev] [v4 1/3] cryptodev: support enqueue callback functions

2020-10-28 Thread Akhil Goyal
Hi Konstantin, > > > Hi Tech board members, > > > > > > I have a doubt about the ABI breakage in below addition of field. > > > Could you please comment. > > > > > > > /** The data structure associated with each crypto device. */ struct > > > > rte_cryptodev { > > > > dequeue_pkt_burst

Re: [dpdk-dev] [PATCH v10 0/9] Add PMD power mgmt

2020-10-28 Thread Thomas Monjalon
28/10/2020 14:49, Jerin Jacob: > On Wed, Oct 28, 2020 at 7:05 PM Liang, Ma wrote: > > > > Hi Thomas, > > I think I addressed all of the questions in relation to V9. I don't think > > I can solve the issue of a generic API on my own. From the Community Call > > last week Jerin also said that a

Re: [dpdk-dev] [PATCH v4 2/2] vdpa/mlx5: hardware error handling

2020-10-28 Thread Maxime Coquelin
On 10/27/20 9:28 AM, Xueming Li wrote: > When hardware error happens, vdpa didn't get such information and leave > driver in silent: working state but no response. > > This patch subscribes firmware virtq error event and try to recover max > 3 times in 3 seconds, stop virtq if max retry number

Re: [dpdk-dev] [EXT] Re: [PATCH 2/2] vfio: fix partial DMA unmapping for VFIO type1

2020-10-28 Thread Nithin Dabilpuram
On Wed, Oct 28, 2020 at 01:04:26PM +, Burakov, Anatoly wrote: > On 22-Oct-20 1:13 PM, Nithin Dabilpuram wrote: > > Ping. > > > > On Mon, Oct 19, 2020 at 03:13:15PM +0530, Nithin Dabilpuram wrote: > > > On Sat, Oct 17, 2020 at 05:14:55PM +0100, Burakov, Anatoly wrote: > > > > On 16-Oct-20 8:10

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/4] power: fix non thread-safe power env modification

2020-10-28 Thread Thomas Monjalon
28/10/2020 14:53, David Hunt: > On 25/10/2020 6:22 PM, Thomas Monjalon wrote: > > 29/03/2019 16:09, Burakov, Anatoly: > >> On 29-Mar-19 2:14 PM, Thomas Monjalon wrote: > >>> 18/03/2019 12:56, Hajkowski: > From: Marcin Hajkowski > --- a/doc/guides/rel_notes/release_19_05.rst > +++ b/

Re: [dpdk-dev] [PATCH] raw/ioat: fix work-queue config size

2020-10-28 Thread Kevin Laatz
On 28/10/2020 12:45, Bruce Richardson wrote: According to latest DSA spec[1], the work-queue config register size should be based off a value read from the WQ capabilities register. Update driver to read this value and base the start of each WQ config off that value. Fixes: ff06fa2cf3ba ("raw/io

[dpdk-dev] [PATCH v5 11/11] build: update Arm builds with makefile flags

2020-10-28 Thread Juraj Linkeš
Not all flags were moved properly from the old Makefile build system. Disable corresponding drivers and libnuma in cross files and remove deprecated config. Signed-off-by: Juraj Linkeš --- config/arm/arm64_armada_linux_gcc| 2 ++ config/arm/arm64_armv8_linux_gcc | 8 ++-- config/arm/

Re: [dpdk-dev] [v5 1/2] cryptodev: support enqueue & dequeue callback functions

2020-10-28 Thread Gujjar, Abhinandan S
> -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, October 28, 2020 6:56 PM > To: Gujjar, Abhinandan S ; dev@dpdk.org; > Doherty, Declan ; akhil.go...@nxp.com; > honnappa.nagaraha...@arm.com > Cc: Vangati, Narender ; jer...@marvell.com > Subject: RE: [v5 1/2] cryptodev:

[dpdk-dev] [PATCH v5 10/11] build: disable Arm drivers

2020-10-28 Thread Juraj Linkeš
A few options that disabled drivers in the old makefiles were improperly ported to the meson build system. Fix this by adding a to the list of disabled drivers, similarly how the command line option works. Signed-off-by: Juraj Linkeš Acked-by: Bruce Richardson --- config/arm/meson.build | 9 +++

[dpdk-dev] [PATCH v5 08/11] build: optional NUMA and cpu counts detection

2020-10-28 Thread Juraj Linkeš
Add an option to automatically discover the host's numa and cpu counts and use those values for a non cross-build. Give users the option to override the per-arch default values or values from cross files by specifying them on the command line with -Dmax_lcores and -Dmax_numa_nodes. Signed-off-by:

[dpdk-dev] [PATCH v5 09/11] build: add core and NUMA counts to cross files

2020-10-28 Thread Juraj Linkeš
Add support for setting core count and numa nodes in cross files. The values specified in cross files will override the default values. Also add missing default values. Signed-off-by: Juraj Linkeš --- config/arm/arm64_armada_linux_gcc| 2 ++ config/arm/arm64_armv8_linux_gcc | 6 ++

[dpdk-dev] [PATCH v5 06/11] build: use dict in Arm part number config

2020-10-28 Thread Juraj Linkeš
Use dictionary lookup instead of iterating over all elements in the list. Fallback to generic part number if the discovered part number is unknown. Signed-off-by: Juraj Linkeš --- config/arm/meson.build | 85 -- 1 file changed, 48 insertions(+), 37 deletio

[dpdk-dev] [PATCH v5 04/11] build: Arm reformat, comments, move config

2020-10-28 Thread Juraj Linkeš
Change formatting so that it's more consistent and readable, add/modify comments/stdout messages, move configuration options to more appropriate places and make the order consistent according to these rules: 1. First list generic configuration options, then list options that may be overwritten.

[dpdk-dev] [PATCH v5 07/11] build: Arm generic and native build setup

2020-10-28 Thread Juraj Linkeš
Simplify the code. Define native machine args in one place since they're the same regardless of which Arm environment we're building on. Signed-off-by: Juraj Linkeš --- config/arm/meson.build | 56 +++--- 1 file changed, 31 insertions(+), 25 deletions(-) diff

[dpdk-dev] [PATCH v5 01/11] build: alias default build as generic

2020-10-28 Thread Juraj Linkeš
The current machine='default' build name is not descriptive. The actual default build is machine='native'. Add an alternative string which does the same build and better describes what we're building: machine='generic'. Leave machine='default' for backwards compatibility. Signed-off-by: Juraj Link

[dpdk-dev] [PATCH v5 05/11] build: simplify how Arm flags are processed

2020-10-28 Thread Juraj Linkeš
Set flags in one loop. Append flags to a list and use the list in the loop. Signed-off-by: Juraj Linkeš --- config/arm/meson.build | 36 +--- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/config/arm/meson.build b/config/arm/meson.build index c970

[dpdk-dev] [PATCH v5 03/11] build: remove unused or superfluous variables

2020-10-28 Thread Juraj Linkeš
Remove variables that were either not used, referenced just once or not needed. Signed-off-by: Juraj Linkeš --- config/arm/meson.build | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/config/arm/meson.build b/config/arm/meson.build index dacbb947b..bd2acf

[dpdk-dev] [PATCH v5 02/11] build: rename Arm build variables

2020-10-28 Thread Juraj Linkeš
Rename Arm build variables and values so that they better conform to Arm specifications. Also rename generically sounding variable to names that better capture what the variables hold. Rename machine_args_generic to part_number_config_default since the variable contains more than just the generic

[dpdk-dev] [PATCH v5 00/11] Arm build options rework

2020-10-28 Thread Juraj Linkeš
The current way of specifying Arm configuration options is insufficient since we can't identify the SoC we're building for from the MIDR information. For example, we can't distinguish between N1SDP, Graviton2 or Ampere Altra. Add a way to specify the cpu count and numa node count for cross builds.

Re: [dpdk-dev] [PATCH v4 1/2] common/mlx5: add virtq attributes error fields

2020-10-28 Thread Maxime Coquelin
On 10/27/20 9:28 AM, Xueming Li wrote: > Add the needed fields for virtq DevX object to read the error state. > > Acked-by: Matan Azrad > Signed-off-by: Xueming Li > --- > drivers/common/mlx5/mlx5_devx_cmds.c | 3 +++ > drivers/common/mlx5/mlx5_devx_cmds.h | 1 + > drivers/common/mlx5/mlx5_p

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/4] power: fix non thread-safe power env modification

2020-10-28 Thread David Hunt
On 25/10/2020 6:22 PM, Thomas Monjalon wrote: 29/03/2019 16:09, Burakov, Anatoly: On 29-Mar-19 2:14 PM, Thomas Monjalon wrote: 18/03/2019 12:56, Hajkowski: From: Marcin Hajkowski --- a/doc/guides/rel_notes/release_19_05.rst +++ b/doc/guides/rel_notes/release_19_05.rst @@ -120,6 +120,8 @@ AP

  1   2   3   >