[dpdk-dev] [PATCH v9 0/4] add async data path in vhost sample

2020-10-21 Thread Cheng Jiang
This patch set makes vhost-vswitch be able to use vhost async APIs for enqueue operations. Demonstrated how the application leverage IOAT DMA channel with vhost async APIs. We introduce two parameters to enable DMA acceleration for Tx operations of queues: -dma_type This parameter is used to speci

Re: [dpdk-dev] [PATCH v8 0/6] enable large VF configuration

2020-10-21 Thread Xing, Beilei
> -Original Message- > From: Xu, Ting > Sent: Thursday, October 22, 2020 2:49 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Xing, Beilei ; > Wu, Jingjing ; Xu, Ting > Subject: [PATCH v8 0/6] enable large VF configuration > > This patchset supports to configure up to 256 queue pairs per VF

[dpdk-dev] [PATCH v2] gso: fix free issue of mbuf gso segments attach to

2020-10-21 Thread yang_y_yi
From: Yi Yang rte_gso_segment decreased refcnt of pkt by one, but it is wrong if pkt is external mbuf, pkt won't be freed because of incorrect refcnt, the result is application can't allocate mbuf from mempool because mbufs in mempool are run out of. One correct way is application should call rt

[dpdk-dev] [PATCH v8 6/6] net/iavf: add enable/disable queues for large VF

2020-10-21 Thread Ting Xu
The current virtchnl structure for enable/disable queues only supports max 32 queue pairs. Use a new opcode and structure to indicate up to 256 queue pairs, in order to enable/disable queues in large VF case. Signed-off-by: Ting Xu --- drivers/net/iavf/iavf.h | 5 ++ drivers/net/iavf/iav

[dpdk-dev] [PATCH v8 4/6] net/iavf: enable multiple queues configurations for large VF

2020-10-21 Thread Ting Xu
Since the adminq buffer size has a 4K limitation, the current virtchnl command VIRTCHNL_OP_CONFIG_VSI_QUEUES cannot send the message only once to configure up to 256 queues. In this patch, we send the messages multiple times to make sure that the buffer size is less than 4K each time. Signed-off-b

[dpdk-dev] [PATCH v8 3/6] net/iavf: negotiate large VF and request more queues

2020-10-21 Thread Ting Xu
Negotiate large VF capability with PF during VF initialization. If large VF is supported and the number of queues larger than 16 is required, VF requests additional queues from PF. Mark the state that large VF is supported. If the allocated queues number is larger than 16, the max RSS queue region

[dpdk-dev] [PATCH v8 5/6] net/iavf: enable IRQ mapping configuration for large VF

2020-10-21 Thread Ting Xu
The current IRQ mapping configuration only supports max 16 queues and 16 MSIX vectors. Change the queue vector mapping structure to indicate up to 256 queues. A new opcode is used to handle the case with large number of queues. To avoid adminq buffer size limitation, we support to send the virtchnl

[dpdk-dev] [PATCH v8 0/6] enable large VF configuration

2020-10-21 Thread Ting Xu
This patchset supports to configure up to 256 queue pairs per VF. If large VF is supported after capability negotiation, VF will request queues from PF as needed. New virtual channel opcodes and structures are used to indicate 256 queues, so VF is designed to handle the new function of configure VS

[dpdk-dev] [PATCH v8 2/6] net/iavf: add IAVF request queues function

2020-10-21 Thread Ting Xu
Add a new virtchnl function to request additional queues from PF. Current default queue pairs number when creating a VF is 16. In order to support up to 256 queue pairs per VF, enable this request queues function. When requesting queues succeeds, PF will return an event message. If it is handled b

[dpdk-dev] [PATCH v8 1/6] net/iavf: handle virtchnl event message without interrupt

2020-10-21 Thread Ting Xu
Currently, VF can only handle virtchnl event message by calling interrupt. It is not available in two cases: 1. If the event message comes during VF initialization before interrupt is enabled, this message will not be handled correctly. 2. Some virtchnl commands need to receive the event message an

Re: [dpdk-dev] [EXT] [PATCH] net/mvpp2: fix memory leak in error path

2020-10-21 Thread Liron Himi
Acked-by: Liron Himi -Original Message- From: wangyunjian Sent: Thursday, 22 October 2020 07:25 To: dev@dpdk.org Cc: Liron Himi ; jerry.lili...@huawei.com; xudin...@huawei.com; Yunjian Wang ; sta...@dpdk.org Subject: [EXT] [dpdk-dev] [PATCH] net/mvpp2: fix memory leak in error path Ex

[dpdk-dev] [PATCH] net/mvpp2: fix memory leak in error path

2020-10-21 Thread wangyunjian
From: Yunjian Wang In mrvl_create() allocated memory for 'mtr', we don't free it when profile get fails and it will lead to memory leak. We can get profile at the beginning of the function to fix it, before calling mtr = rte_zmalloc_socket(). Fixes: cdb53f8da628 ("net/mvpp2: support metering")

Re: [dpdk-dev] [PATCH v2 3/3] virtio-user: set status on virtio-user reconnect

2020-10-21 Thread Wang, Yinan
Hi Maxime/ Adrian, Thanks for the patch. we can launch vhost-user with client mode with this fix patch. But still fail to get throughput with basic vhost/virtio-user server mode loopback test. This is another problem which introduced by 57912824615fd7787a48a7b18e40661466. Bugzilla: https://bug

Re: [dpdk-dev] [PATCH 02/14] ethdev: move MAC filter type to i40e driver

2020-10-21 Thread Guo, Jia
> -Original Message- > From: Andrew Rybchenko > Sent: Thursday, October 22, 2020 12:09 AM > To: Guo, Jia ; Xing, Beilei ; > Thomas Monjalon ; Yigit, Ferruh > ; Andrew Rybchenko > > Cc: dev@dpdk.org > Subject: Re: [PATCH 02/14] ethdev: move MAC filter type to i40e driver > > On 10/21/20

Re: [dpdk-dev] [PATCH 12/14] ethdev: remove legacy FDIR filter type support

2020-10-21 Thread Guo, Jia
> -Original Message- > From: Andrew Rybchenko > Sent: Thursday, October 22, 2020 12:18 AM > To: Guo, Jia ; Lu, Wenzhuo ; > Xing, Beilei ; Iremonger, Bernard > ; Ray Kinsella ; Neil > Horman ; Ajit Khaparde > ; Somnath Kotur > ; John Daley ; > Hyong Youb Kim ; Wang, Haiyue > ; Matan Azrad

Re: [dpdk-dev] [PATCH 01/14] ethdev: remove legacy MACVLAN filter type support

2020-10-21 Thread Guo, Jia
> -Original Message- > From: Andrew Rybchenko > Sent: Thursday, October 22, 2020 12:05 AM > To: Guo, Jia ; Lu, Wenzhuo ; > Xing, Beilei ; Iremonger, Bernard > ; Ray Kinsella ; Neil > Horman ; Rasesh Mody ; > Shahed Shaikh ; Andrew Rybchenko > ; Thomas Monjalon > ; Yigit, Ferruh > Cc: dev

[dpdk-dev] [PATCH] net/netvsc: use memzone to allocate contiguous physical mem for rndis

2020-10-21 Thread Long Li
From: Long Li When sending data, netvsc assumes the tx_rndis buffer is contiguous and calculates physical addresses based on this assumption. Use memzone to allocate tx_rndis so it's guaranteed that this buffer is physically contiguous. Cc:sta...@dpdk.org Signed-off-by: Long Li --- drivers/ne

[dpdk-dev] [PATCH v6 4/4] test/hash: add tests for integrated RCU QSBR

2020-10-21 Thread Dharmik Thakkar
Add functional and performance tests for the integrated RCU QSBR. Suggested-by: Honnappa Nagarahalli Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng Wang --- app/test/test_hash.c | 390 - app/test/test_hash_readwrite_lf_perf.c | 170 ++- 2

[dpdk-dev] [PATCH v6 0/4] hash: integrate RCU QSBR

2020-10-21 Thread Dharmik Thakkar
Integrate RCU QSBR to make it easier for the applications to use lock free algorithm. Resource reclamation implementation was split from the original series, and has already been part of RCU library. Rework the series to base hash integration on RCU reclamation APIs. Refer 'Resource reclamation f

[dpdk-dev] [PATCH v6 2/4] lib/hash: integrate RCU QSBR

2020-10-21 Thread Dharmik Thakkar
Currently, users have to use external RCU mechanisms to free resources when using lock free hash algorithm. Integrate RCU QSBR process to make it easier for the applications to use lock free algorithm. Refer to RCU documentation to understand various aspects of integrating RCU library into other l

[dpdk-dev] [PATCH v6 3/4] test/hash: replace rte atomic with C11 atomic APIs

2020-10-21 Thread Dharmik Thakkar
Replace rte_atomic APIs with C11 atomic APIs in test_hash_readwrite_lf_perf.c Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng Wang Acked-by: Yipeng Wang --- app/test/test_hash_readwrite_lf_perf.c | 89 +++--- 1 file changed, 36 insertions(+), 53 deletions(-) diff --git

[dpdk-dev] [PATCH v6 1/4] rcu: build on Windows

2020-10-21 Thread Dharmik Thakkar
Build the lib for Windows. Signed-off-by: Dharmik Thakkar Tested-by: Dmitry Kozlyuk --- lib/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/meson.build b/lib/meson.build index dd55b5cb53e4..1bb019720c6a 100644 --- a/lib/meson.build +++ b/lib/meson.build @@ -41,6 +41,7 @@ if

Re: [dpdk-dev] [PATCH v5 4/4] test/hash: add tests for integrated RCU QSBR

2020-10-21 Thread Honnappa Nagarahalli
> > > > Add functional and performance tests for the integrated RCU QSBR. > > > > Suggested-by: Honnappa Nagarahalli > > Signed-off-by: Dharmik Thakkar > > Reviewed-by: Ruifeng Wang > > --- > > app/test/test_hash.c | 390 - > > app/test/test_hash_read

Re: [dpdk-dev] [PATCH v2 01/11] net/bnxt: add stingray support to core layer

2020-10-21 Thread Ajit Khaparde
On Wed, Oct 21, 2020 at 11:07 AM Ferruh Yigit wrote: > > On 10/20/2020 10:55 PM, Ajit Khaparde wrote: > > From: Peter Spreadborough > > > > - Moved P4 specific code under the P4 directory > > - Added P45 skeleton code for SR to build on > > - Add SR support in truflow core layer > > > > Related t

Re: [dpdk-dev] [PATCH v1] net/mlx5: fix port shared data reference count

2020-10-21 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Xueming Li > Sent: Wednesday, October 21, 2020 2:15 PM > To: Matan Azrad ; Slava Ovsiienko > > Cc: dev@dpdk.org; Xueming(Steven) Li ; Asaf Penso > ; Jack Min ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v1] net/mlx5: fix port shared dat

[dpdk-dev] [PATCH] eal: create a runtime directory on windows

2020-10-21 Thread Pallavi Kadam
Added eal_create_runtime_dir() function in order to run any application as a user that does not have administrator access. Currently, since there is no runtime directory set, the code tries to create a file in C:\ which is only writable with administrator privileges. As a result, if the user is not

[dpdk-dev] [PATCH v2 2/2] net/mlx5: implement vectorized MPRQ burst

2020-10-21 Thread Alexander Kozyrev
MPRQ (Multi-Packet Rx Queue) processes one packet at a time using simple scalar instructions. MPRQ works by posting a single large buffer (consisted of multiple fixed-size strides) in order to receive multiple packets at once on this buffer. A Rx packet is then copied to a user-provided mbuf or PMD

[dpdk-dev] [PATCH v2 0/2] net/mlx5: add vectorized mprq

2020-10-21 Thread Alexander Kozyrev
The vectorized Rx burst function helps to accelerate the Rx processing by using SIMD (single instruction, multiple data) extensions for the multi-buffer packet processing. Pre-allocating multiple mbufs and filling them in batches of four greatly improves the throughput of the Rx burst routine. MPR

[dpdk-dev] [PATCH v2 1/2] net/mlx5: refactor vectorized Rx routine

2020-10-21 Thread Alexander Kozyrev
Move the main processing cycle into a separate function: rxq_cq_process_v. Put the regular rxq_burst_v function to a non-arch specific file. Having all SIMD instructions in a single reusable block is a first preparatory step to implement vectorized Rx burst for MPRQ feature. Pass a pointer to the

Re: [dpdk-dev] [v3 1/2] cryptodev: support enqueue callback functions

2020-10-21 Thread Ananyev, Konstantin
Hi Abhinandan, Thanks for the effort, good progress. Though few more comments, see below. > This patch adds APIs to add/remove callback functions. The callback > function will be called for each burst of crypto ops received on a > given crypto device queue pair. > > Signed-off-by: Abhinandan G

Re: [dpdk-dev] [PATCH v2 01/11] net/bnxt: add stingray support to core layer

2020-10-21 Thread Ferruh Yigit
On 10/20/2020 10:55 PM, Ajit Khaparde wrote: From: Peter Spreadborough - Moved P4 specific code under the P4 directory - Added P45 skeleton code for SR to build on - Add SR support in truflow core layer Related to the patch title, as far as I know Stingray device support already added, what

Re: [dpdk-dev] [PATCH] net/bnxt: fix a potential resource leak

2020-10-21 Thread Ajit Khaparde
On Tue, Oct 20, 2020 at 11:00 PM Ajit Khaparde wrote: > > Fix a potential resource leak in case of errors during dev args > parsing during device probe. > > Fixes: 6dc83230b43b ("net/bnxt: support port representor data path") > > Signed-off-by: Ajit Khaparde > Reviewed-by: Kalesh AP Patch applie

Re: [dpdk-dev] [PATCH v4] pci: support both PIO and MMIO BAR for legacy virtio on x86

2020-10-21 Thread Ferruh Yigit
On 10/21/2020 1:32 PM, 谢华伟(此时此刻) wrote: On 2020/10/21 19:49, Ferruh Yigit wrote: On 10/13/2020 9:41 AM, 谢华伟(此时此刻) wrote: From: "huawei.xhw" Legacy virtio-pci only supports PIO BAR resource. As we need to create lots of virtio devices and PIO resource on x86 is very limited, we expose MMIO BA

[dpdk-dev] [PATCH v2] mailmap: add a mailmap file to DPDK

2020-10-21 Thread Bruce Richardson
Since a number of contributors to DPDK have submitted patches to DPDK under more than one email address, we should maintain a mailmap file to properly track their commits using "shortlog". It also helps fix up any mangled names, for example, with surname/firstname reversed, or with incorrect capita

Re: [dpdk-dev] [PATCH 01/14] ethdev: remove legacy MACVLAN filter type support

2020-10-21 Thread Andrew Rybchenko
On 10/20/20 2:07 PM, David Marchand wrote: On Sun, Oct 18, 2020 at 4:10 PM Andrew Rybchenko wrote: RTE flow API should be used for filtering. - We still have some trace in testpmd documentation. $ git grep set.port.*vf.*mac doc/guides/testpmd_app_ug/testpmd_funcs.rst: testpmd> set port (port

Re: [dpdk-dev] [PATCH v2 01/22] event/dlb2: add documentation and meson build infrastructure

2020-10-21 Thread McDaniel, Timothy
> -Original Message- > From: Bruce Richardson > Sent: Monday, October 19, 2020 3:34 AM > To: Jerin Jacob > Cc: McDaniel, Timothy ; Mcnamara, John > ; Kovacevic, Marko > ; Ray Kinsella ; Neil Horman > ; dpdk-dev ; Carrillo, Erik G > ; Eads, Gage ; Van Haaren, > Harry ; Jerin Jacob ; > T

Re: [dpdk-dev] [RFC] doc: announce max Rx packet len field deprecation

2020-10-21 Thread Ferruh Yigit
On 10/21/2020 4:10 PM, Andrew Rybchenko wrote: On 10/21/20 1:18 PM, Ananyev, Konstantin wrote: Signed-off-by: Ferruh Yigit --- Cc: Thomas Monjalon Cc: Andrew Rybchenko Cc: Konstantin Ananyev Cc: Matan Azrad Cc: Olivier Matz Cc: Jerin Jacob --- doc/guides/rel_notes/deprecation.rst | 25

Re: [dpdk-dev] [PATCH 12/14] ethdev: remove legacy FDIR filter type support

2020-10-21 Thread Andrew Rybchenko
On 10/21/20 8:45 AM, Guo, Jia wrote: -Original Message- From: Andrew Rybchenko Sent: Sunday, October 18, 2020 10:09 PM To: Lu, Wenzhuo ; Xing, Beilei ; Iremonger, Bernard ; Ray Kinsella ; Neil Horman ; Ajit Khaparde ; Somnath Kotur ; John Daley ; Hyong Youb Kim ; Guo, Jia ; Wang, Haiyu

Re: [dpdk-dev] [PATCH 03/14] ethdev: remove legacy EtherType filter type support

2020-10-21 Thread Andrew Rybchenko
On 10/21/20 8:38 AM, Guo, Jia wrote: -Original Message- From: Andrew Rybchenko Sent: Sunday, October 18, 2020 10:09 PM To: Lu, Wenzhuo ; Xing, Beilei ; Iremonger, Bernard ; Ray Kinsella ; Neil Horman ; Ajit Khaparde ; Somnath Kotur ; Guo, Jia ; Wang, Haiyue ; Ziyang Xuan ; Xiaoyun Wang

Re: [dpdk-dev] [PATCH 02/14] ethdev: move MAC filter type to i40e driver

2020-10-21 Thread Andrew Rybchenko
On 10/21/20 7:01 AM, Guo, Jia wrote: -Original Message- From: Andrew Rybchenko Sent: Sunday, October 18, 2020 10:09 PM To: Xing, Beilei ; Guo, Jia ; Thomas Monjalon ; Yigit, Ferruh ; Andrew Rybchenko Cc: dev@dpdk.org Subject: [PATCH 02/14] ethdev: move MAC filter type to i40e driver

Re: [dpdk-dev] [PATCH 01/14] ethdev: remove legacy MACVLAN filter type support

2020-10-21 Thread Andrew Rybchenko
On 10/21/20 6:31 AM, Guo, Jia wrote: -Original Message- From: Andrew Rybchenko Sent: Sunday, October 18, 2020 10:09 PM To: Lu, Wenzhuo ; Xing, Beilei ; Iremonger, Bernard ; Ray Kinsella ; Neil Horman ; Guo, Jia ; Rasesh Mody ; Shahed Shaikh ; Andrew Rybchenko ; Thomas Monjalon ; Yigit,

Re: [dpdk-dev] [DPDK_KMODS v4] linux/igb_uio: add Makefile to build the kernel module

2020-10-21 Thread Kalesh Anakkur Purayil
Hi Thomas/Ferruh, It looks like this patch is not yet merged to https://git.dpdk.org/dpdk-kmods/. This impacts the 20.11-rc1 testing which needs the igb_uio driver. Is there any reason to not merge this? Regards, Kalesh On Mon, Oct 19, 2020 at 11:38 PM Ajit Khaparde wrote: > On Thu, Oct 8, 20

Re: [dpdk-dev] [RFC] doc: announce max Rx packet len field deprecation

2020-10-21 Thread Andrew Rybchenko
On 10/21/20 1:18 PM, Ananyev, Konstantin wrote: Signed-off-by: Ferruh Yigit --- Cc: Thomas Monjalon Cc: Andrew Rybchenko Cc: Konstantin Ananyev Cc: Matan Azrad Cc: Olivier Matz Cc: Jerin Jacob --- doc/guides/rel_notes/deprecation.rst | 25 + 1 file changed, 25

Re: [dpdk-dev] [PATCH v10 5/5] doc: add aarch32 build guidance

2020-10-21 Thread Ruifeng Wang
> -Original Message- > From: dev On Behalf Of Juraj Linke? > Sent: Wednesday, September 16, 2020 4:21 PM > To: tho...@monjalon.net; bruce.richard...@intel.com; > acon...@redhat.com; maicolgabr...@hotmail.com > Cc: juraj.lin...@pantheon.tech; dev@dpdk.org; Phil Yang > > Subject: [dpdk-de

Re: [dpdk-dev] [PATCH v10 4/5] ci: add aarch64 -> aarch32 cross compiling jobs

2020-10-21 Thread Ruifeng Wang
> -Original Message- > From: dev On Behalf Of Juraj Linke? > Sent: Wednesday, September 16, 2020 4:21 PM > To: tho...@monjalon.net; bruce.richard...@intel.com; > acon...@redhat.com; maicolgabr...@hotmail.com > Cc: juraj.lin...@pantheon.tech; dev@dpdk.org > Subject: [dpdk-dev] [PATCH v10 4

Re: [dpdk-dev] [RFC PATCH v3 3/6] build: automatic NUMA and cpu counts detection

2020-10-21 Thread Bruce Richardson
On Wed, Oct 21, 2020 at 03:13:19PM +0100, Bruce Richardson wrote: > On Wed, Oct 21, 2020 at 01:01:41PM +, Juraj Linkeš wrote: > > > > > > > -Original Message- > > > From: Bruce Richardson > > > Sent: Wednesday, October 21, 2020 2:02 PM > > > To: Juraj Linkeš > > > Cc: ruifeng.w...@a

Re: [dpdk-dev] [PATCH v10 3/5] build: add aarch32 to meson cross-compilation

2020-10-21 Thread Ruifeng Wang
> -Original Message- > From: dev On Behalf Of Juraj Linke? > Sent: Wednesday, September 16, 2020 4:21 PM > To: tho...@monjalon.net; bruce.richard...@intel.com; > acon...@redhat.com; maicolgabr...@hotmail.com > Cc: juraj.lin...@pantheon.tech; dev@dpdk.org > Subject: [dpdk-dev] [PATCH v10 3

Re: [dpdk-dev] [PATCH v10 2/5] build: add aarch32 meson build flags

2020-10-21 Thread Ruifeng Wang
> -Original Message- > From: dev On Behalf Of Juraj Linke? > Sent: Wednesday, September 16, 2020 4:21 PM > To: tho...@monjalon.net; bruce.richard...@intel.com; > acon...@redhat.com; maicolgabr...@hotmail.com > Cc: juraj.lin...@pantheon.tech; dev@dpdk.org > Subject: [dpdk-dev] [PATCH v10 2

Re: [dpdk-dev] [PATCH V2 1/1] net/mlx5: fix IPv6 next proto validation

2020-10-21 Thread Matan Azrad
From: Eli Britstein > Previous patch added validation of the IPv6 next proto field, in order to > overcome a known limitation. > One of the values checked is IPPROTO_HOPOPTS, which is defined as 0. > If proto field is not specified for matching, or mask=0, as in the following, > a > wrong valid

Re: [dpdk-dev] [RFC PATCH v3 3/6] build: automatic NUMA and cpu counts detection

2020-10-21 Thread Bruce Richardson
On Wed, Oct 21, 2020 at 01:01:41PM +, Juraj Linkeš wrote: > > > > -Original Message- > > From: Bruce Richardson > > Sent: Wednesday, October 21, 2020 2:02 PM > > To: Juraj Linkeš > > Cc: ruifeng.w...@arm.com; honnappa.nagaraha...@arm.com; > > phil.y...@arm.com; vcchu...@amazon.com;

Re: [dpdk-dev] [PATCH] baseband/acc100: remove logically dead code

2020-10-21 Thread Tom Rix
On 10/19/20 2:09 PM, Nicolas Chautru wrote: > Coverity reported dead code for a few error > checks which are indeed not reachable. > > Coverity issue: 363451, 363454, 363455 > > Signed-off-by: Nicolas Chautru This change looks fine. Should remove the 'Coverity issue: ... ' from the log. Revie

Re: [dpdk-dev] [RFC PATCH v3 3/6] build: automatic NUMA and cpu counts detection

2020-10-21 Thread Juraj Linkeš
> -Original Message- > From: Bruce Richardson > Sent: Wednesday, October 21, 2020 2:02 PM > To: Juraj Linkeš > Cc: ruifeng.w...@arm.com; honnappa.nagaraha...@arm.com; > phil.y...@arm.com; vcchu...@amazon.com; dharmik.thak...@arm.com; > jerinjac...@gmail.com; hemant.agra...@nxp.com; dev@

[dpdk-dev] [Bug 562] Cannot bind 82599ES 10-Gigabit to uio_pci_generic

2020-10-21 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=562 Bug ID: 562 Summary: Cannot bind 82599ES 10-Gigabit to uio_pci_generic Product: DPDK Version: 20.08 Hardware: x86 OS: All Status: UNCONFIRMED Severity: critical

Re: [dpdk-dev] [PATCH v2 00/62] net/sfc: support flow API transfer rules

2020-10-21 Thread Andrew Rybchenko
On 10/21/20 2:13 PM, Ferruh Yigit wrote: On 10/20/2020 10:12 AM, Andrew Rybchenko wrote: Transfer rules for Alveo SN1000 SmartNICs support matching on various inner and outer packet headers, traffic source items like PORT_ID, PHY_PORT, PF and VF and actions to route traffic to destination (PORT_

Re: [dpdk-dev] [RFC] doc: announce max Rx packet len field deprecation

2020-10-21 Thread Kinsella, Ray
On 20/10/2020 13:03, Ferruh Yigit wrote: > Signed-off-by: Ferruh Yigit > --- > Cc: Thomas Monjalon > Cc: Andrew Rybchenko > Cc: Konstantin Ananyev > Cc: Matan Azrad > Cc: Olivier Matz > Cc: Jerin Jacob > --- > doc/guides/rel_notes/deprecation.rst | 25 + > 1 file

Re: [dpdk-dev] [PATCH v4] pci: support both PIO and MMIO BAR for legacy virtio on x86

2020-10-21 Thread 谢华伟(此时此刻)
On 2020/10/21 19:49, Ferruh Yigit wrote: On 10/13/2020 9:41 AM, 谢华伟(此时此刻) wrote: From: "huawei.xhw" Legacy virtio-pci only supports PIO BAR resource. As we need to create lots of virtio devices and PIO resource on x86 is very limited, we expose MMIO BAR. Kernel supports both PIO  and MMI

Re: [dpdk-dev] [RFC PATCH v3 1/6] build: rename default Arm build to generic-armv8

2020-10-21 Thread Juraj Linkeš
> -Original Message- > From: Bruce Richardson > Sent: Wednesday, October 21, 2020 1:53 PM > To: Juraj Linkeš > Cc: ruifeng.w...@arm.com; honnappa.nagaraha...@arm.com; > phil.y...@arm.com; vcchu...@amazon.com; dharmik.thak...@arm.com; > jerinjac...@gmail.com; hemant.agra...@nxp.com; dev@

Re: [dpdk-dev] [PATCH 1/7] vhost: fix virtqueues metadata allocation

2020-10-21 Thread Maxime Coquelin
Hi Chenbon On 10/21/20 1:10 PM, Xia, Chenbo wrote: > Hi Maxime, > >> -Original Message- >> From: Maxime Coquelin >> Sent: Tuesday, October 20, 2020 1:34 AM >> To: dev@dpdk.org; Xia, Chenbo ; amore...@redhat.com >> Cc: Maxime Coquelin ; sta...@dpdk.org >> Subject: [PATCH 1/7] vhost: fix v

Re: [dpdk-dev] [RFC PATCH v3 3/6] build: automatic NUMA and cpu counts detection

2020-10-21 Thread Bruce Richardson
On Wed, Oct 21, 2020 at 01:37:38PM +0200, Juraj Linkeš wrote: > The build machine's number of cpus and numa nodes vary, resulting in > mismatched counts of RTE_MAX_LCORE and RTE_MAX_NUMA_NODES for many > builds. Automatically discover the host's numa and cpu counts to remove > this mismatch for nat

Re: [dpdk-dev] [PATCH v10 0/5] aarch64 -> aarch32 cross compilation support

2020-10-21 Thread Thomas Monjalon
21/10/2020 13:42, Juraj Linkeš: > Hi Folks, > > This patch series has been submitted more than a month ago. > There have been no comments. > Should I just wait a bit more or what should I do? First thing to do is to get acks from Arm maintainers. There are other patchset in the same area that I'm

Re: [dpdk-dev] [RFC PATCH v3 1/6] build: rename default Arm build to generic-armv8

2020-10-21 Thread Bruce Richardson
On Wed, Oct 21, 2020 at 01:37:36PM +0200, Juraj Linkeš wrote: > The current machine='default' build name is not descriptive. The actual > default build is machine='native'. Add an alternative string which does > the same build and better describes what we're building: > machine='generic-armv8'. Lea

Re: [dpdk-dev] [PATCH v4] pci: support both PIO and MMIO BAR for legacy virtio on x86

2020-10-21 Thread Ferruh Yigit
On 10/13/2020 9:41 AM, 谢华伟(此时此刻) wrote: From: "huawei.xhw" Legacy virtio-pci only supports PIO BAR resource. As we need to create lots of virtio devices and PIO resource on x86 is very limited, we expose MMIO BAR. Kernel supports both PIO and MMIO BAR for legacy virtio-pci device. We handles

Re: [dpdk-dev] [PATCH v10 0/5] aarch64 -> aarch32 cross compilation support

2020-10-21 Thread Juraj Linkeš
Hi Folks, This patch series has been submitted more than a month ago. There have been no comments. Should I just wait a bit more or what should I do? Thanks, Juraj > -Original Message- > From: Juraj Linkeš > Sent: Wednesday, September 16, 2020 10:21 AM > To: tho...@monjalon.net; bruce.

[dpdk-dev] [RFC PATCH v3 4/6] build: move core and NUMA counts to cross files

2020-10-21 Thread Juraj Linkeš
The values of RTE_MAX_NUMA_NODES and RTE_MAX_LCORE are going to vary for different build machines, even for the same Implementer ID and Part Number combinations. Move the fixed values to cross files and use automatic discovery/values from cmdline options for native build. Use predefined values for

[dpdk-dev] [RFC PATCH v3 5/6] build: disable Arm drivers

2020-10-21 Thread Juraj Linkeš
A few options that disabled drivers in the old makefiles were improperly ported to the meson build system. Fix this by adding a to the list of disabled drivers, similarly how the command line option works. Signed-off-by: Juraj Linkeš Acked-by: Bruce Richardson --- config/arm/meson.build | 9 +++

[dpdk-dev] [RFC PATCH v3 6/6] build: update Arm builds with makefile flags

2020-10-21 Thread Juraj Linkeš
Not all flags were moved properly from the old Makefile build system. Disable corresponding drivers and libnuma in cross files and remove deprecated config. Signed-off-by: Juraj Linkeš --- config/arm/arm64_armada_linux_gcc| 2 ++ config/arm/arm64_armv8_linux_gcc | 8 ++-- config/arm/

[dpdk-dev] [RFC PATCH v3 2/6] build: refactor Arm build

2020-10-21 Thread Juraj Linkeš
* Rename variables to have names that better describe what the variables store * Remove unused or superfluous variables * Change a list to dictionary where key lookup is needed * Add informatory comments in the code * Minor code restructure and reformatting Signed-off-by: Juraj Linkeš --- config

[dpdk-dev] [RFC PATCH v3 3/6] build: automatic NUMA and cpu counts detection

2020-10-21 Thread Juraj Linkeš
The build machine's number of cpus and numa nodes vary, resulting in mismatched counts of RTE_MAX_LCORE and RTE_MAX_NUMA_NODES for many builds. Automatically discover the host's numa and cpu counts to remove this mismatch for native builds. Use current defaults for default builds. Force the users t

[dpdk-dev] [RFC PATCH v3 1/6] build: rename default Arm build to generic-armv8

2020-10-21 Thread Juraj Linkeš
The current machine='default' build name is not descriptive. The actual default build is machine='native'. Add an alternative string which does the same build and better describes what we're building: machine='generic-armv8'. Leave machine='default' for backwards compatibility. Signed-off-by: Jura

[dpdk-dev] [RFC PATCH v3 0/6] Arm build options rework

2020-10-21 Thread Juraj Linkeš
The current way of specifying Arm configuration options is insufficient since we can't identify the SoC we're building for from the MIDR information. Add a way to discover cpu count a numa node count and use that instead of statically defined values. This augments the current native builds. A bon

Re: [dpdk-dev] [PATCH 7/7] vhost: check virtqueue metadata pointer

2020-10-21 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, October 20, 2020 1:34 AM > To: dev@dpdk.org; Xia, Chenbo ; amore...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH 7/7] vhost: check virtqueue metadata pointer > > This patch checks whether the virtqueue metadata pointer >

Re: [dpdk-dev] [PATCH 6/7] vhost: validate index in async API

2020-10-21 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, October 20, 2020 1:34 AM > To: dev@dpdk.org; Xia, Chenbo ; amore...@redhat.com > Cc: Maxime Coquelin ; sta...@dpdk.org > Subject: [PATCH 6/7] vhost: validate index in async API > > This patch validates the queue index parameter

Re: [dpdk-dev] [PATCH 5/7] vhost: validate index in inflight API

2020-10-21 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, October 20, 2020 1:34 AM > To: dev@dpdk.org; Xia, Chenbo ; amore...@redhat.com > Cc: Maxime Coquelin ; sta...@dpdk.org > Subject: [PATCH 5/7] vhost: validate index in inflight API > > This patch validates the queue index parame

Re: [dpdk-dev] [PATCH 3/7] vhost: validate index in guest notification API

2020-10-21 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, October 20, 2020 1:34 AM > To: dev@dpdk.org; Xia, Chenbo ; amore...@redhat.com > Cc: Maxime Coquelin ; sta...@dpdk.org > Subject: [PATCH 3/7] vhost: validate index in guest notification API > > This patch validates the queue in

Re: [dpdk-dev] [PATCH 4/7] vhost: validate index in live-migration API

2020-10-21 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, October 20, 2020 1:34 AM > To: dev@dpdk.org; Xia, Chenbo ; amore...@redhat.com > Cc: Maxime Coquelin ; sta...@dpdk.org > Subject: [PATCH 4/7] vhost: validate index in live-migration API > > This patch validates the queue index

Re: [dpdk-dev] [PATCH 2/7] vhost: validate index in available entries API

2020-10-21 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, October 20, 2020 1:34 AM > To: dev@dpdk.org; Xia, Chenbo ; amore...@redhat.com > Cc: Maxime Coquelin ; sta...@dpdk.org > Subject: [PATCH 2/7] vhost: validate index in available entries API > > This patch validates t

[dpdk-dev] [PATCH v5 2/3] eal: return error code when failure

2020-10-21 Thread wangyunjian
From: Yunjian Wang Fix return value, using -EAGAIN instead of 0 when the callback is busy and using -ENOENT instead of 0 when the callback is not found. Fixes: a753e53d517b ("eal: add device event monitor framework") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang Acked-by: Jeff Guo --- lib/

[dpdk-dev] [PATCH v5 3/3] eal: fix a wrong returned value when callback exists

2020-10-21 Thread wangyunjian
From: Yunjian Wang We should return an error value, when the callback is already exist. Fixes: a753e53d517b ("eal: add device event monitor framework") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang Suggested-by: David Marchand --- lib/librte_eal/common/eal_common_dev.c | 2 ++ 1 file chang

[dpdk-dev] [PATCH v5 1/3] eal: fix memory leak when removing event_cb

2020-10-21 Thread wangyunjian
From: Yunjian Wang The event_cb->dev_name is not freed when freeing event_cb, and this causes a memory leak. Fixes: a753e53d517b ("eal: add device event monitor framework") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang Acked-by: Jeff Guo --- lib/librte_eal/common/eal_common_dev.c | 1 + 1

[dpdk-dev] [PATCH v5 0/3] fixes for device event

2020-10-21 Thread wangyunjian
From: Yunjian Wang This series include three fixes patches for device event. --- v5: * update patch 3/3 code styles suggested by David Marchand v4: * add fix a wrong returned value * remove redundant check suggested by David Marchand v3: * modified the format. Yunjian Wang (3): eal: fix

[dpdk-dev] [PATCH v1] net/mlx5: fix port shared data reference count

2020-10-21 Thread Xueming Li
When probe a representor, tag cache hash table and modification cache hash table allocated memory upon each port, overwrote previous existing cache in shared context data. This patch moves reference check of shared data prior to hash table allocation to avoid such issue. Fixes: 6801116688fe ("net

Re: [dpdk-dev] [PATCH v2 00/62] net/sfc: support flow API transfer rules

2020-10-21 Thread Ferruh Yigit
On 10/20/2020 10:12 AM, Andrew Rybchenko wrote: Transfer rules for Alveo SN1000 SmartNICs support matching on various inner and outer packet headers, traffic source items like PORT_ID, PHY_PORT, PF and VF and actions to route traffic to destination (PORT_ID, PHY_PORT, PF, VF or DROP), MARK, FLAG

Re: [dpdk-dev] [PATCH 1/7] vhost: fix virtqueues metadata allocation

2020-10-21 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, October 20, 2020 1:34 AM > To: dev@dpdk.org; Xia, Chenbo ; amore...@redhat.com > Cc: Maxime Coquelin ; sta...@dpdk.org > Subject: [PATCH 1/7] vhost: fix virtqueues metadata allocation > > The Vhost-user backend impl

Re: [dpdk-dev] [PATCH] net/mlx5: fix xstats reset reinitialization

2020-10-21 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Shiri Kuzin > Sent: Monday, October 19, 2020 9:37 AM > To: dev@dpdk.org > Cc: ma...@mellanox.com; rasl...@mellanox.com; > viachesl...@mellanox.com; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix xstats reset reinitialization > > The mlx5_xstats_reset cl

Re: [dpdk-dev] [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by default

2020-10-21 Thread Ferruh Yigit
On 10/21/2020 11:44 AM, Ananyev, Konstantin wrote: On 10/20/2020 10:07 AM, Ananyev, Konstantin wrote: testpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet length wi

Re: [dpdk-dev] [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by default

2020-10-21 Thread Ananyev, Konstantin
> >> On 10/20/2020 10:07 AM, Ananyev, Konstantin wrote: > >>> > > testpmd will initialize default max packet length to 1518 > which > doesn't include vlan tag size in ether overheader. Once, > send the >

Re: [dpdk-dev] [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by default

2020-10-21 Thread Ferruh Yigit
On 10/21/2020 10:47 AM, Ananyev, Konstantin wrote: On 10/20/2020 10:07 AM, Ananyev, Konstantin wrote: testpmd will initialize default max packet length to 1518 which doesn't include vlan tag size in ether overheader. Once, send the max mtu length packet with vlan tag, the max packet lengt

Re: [dpdk-dev] [RFC] doc: announce max Rx packet len field deprecation

2020-10-21 Thread Ananyev, Konstantin
> > Signed-off-by: Ferruh Yigit > --- > Cc: Thomas Monjalon > Cc: Andrew Rybchenko > Cc: Konstantin Ananyev > Cc: Matan Azrad > Cc: Olivier Matz > Cc: Jerin Jacob > --- > doc/guides/rel_notes/deprecation.rst | 25 + > 1 file changed, 25 insertions(+) > > diff -

Re: [dpdk-dev] [PATCH v1] doc: update ip pipeline and qos scheduler app

2020-10-21 Thread Dumitrescu, Cristian
> -Original Message- > From: Dharmappa, Savinay > Sent: Wednesday, October 21, 2020 8:07 AM > To: Dumitrescu, Cristian ; Singh, Jasvinder > ; dev@dpdk.org > Cc: Dharmappa, Savinay > Subject: [PATCH v1] doc: update ip pipeline and qos scheduler app > > update the user guide of sample a

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix the default RSS key configuration

2020-10-21 Thread oulijun
在 2020/10/21 17:38, Ferruh Yigit 写道: On 10/21/2020 9:19 AM, oulijun wrote: 在 2020/10/20 22:34, Ferruh Yigit 写道: On 10/20/2020 2:35 PM, oulijun wrote: 在 2020/10/20 18:02, Ferruh Yigit 写道: On 10/20/2020 10:00 AM, oulijun wrote: 在 2020/10/16 18:57, Ferruh Yigit 写道: On 10/16/2020 11:04

[dpdk-dev] [PATCH] app/testpmd: set default RSS key as null

2020-10-21 Thread Lijun Ou
From: Ophir Munk When creating an RSS rule without specifying a key (see [1]) it is expected that the device will use the default key. A NULL key is used to indicate to a PMD it should use its default key, however testpmd assigns a non-NULL dummy key (see [2]) instead. This does not enable testin

[dpdk-dev] [PATCH] net/bnxt: fix a potential resource leak

2020-10-21 Thread Ajit Khaparde
Fix a potential resource leak in case of errors during dev args parsing during device probe. Fixes: 6dc83230b43b ("net/bnxt: support port representor data path") Signed-off-by: Ajit Khaparde Reviewed-by: Kalesh AP --- drivers/net/bnxt/bnxt_ethdev.c | 35 +- 1 fi

Re: [dpdk-dev] [PATCH] net/bnxt: fix xstats by id

2020-10-21 Thread Ajit Khaparde
On Tue, Jun 16, 2020 at 8:36 AM Ferruh Yigit wrote: > > The xstat by id device operation seems wrong, it fills 'xstats' struct > via 'bnxt_dev_xstats_get_op()' call, but the retrieved values are not > transferred to user input 'values' array. > > ethdev layer 'rte_eth_xstats_get_by_id()' & > 'rte_

Re: [dpdk-dev] [PATCH v4 3/5] net/ice: fix max mtu size packets with vlan tag cannot be received by default

2020-10-21 Thread Ananyev, Konstantin
> > On 10/20/2020 10:07 AM, Ananyev, Konstantin wrote: > > > >> > >> testpmd will initialize default max packet length to 1518 which > >> doesn't include vlan tag size in ether overheader. Once, send > >> the > >> max mtu length packet

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix the default RSS key configuration

2020-10-21 Thread Ferruh Yigit
On 10/21/2020 9:19 AM, oulijun wrote: 在 2020/10/20 22:34, Ferruh Yigit 写道: On 10/20/2020 2:35 PM, oulijun wrote: 在 2020/10/20 18:02, Ferruh Yigit 写道: On 10/20/2020 10:00 AM, oulijun wrote: 在 2020/10/16 18:57, Ferruh Yigit 写道: On 10/16/2020 11:04 AM, oulijun wrote: 在 2020/10/16 7:53,

Re: [dpdk-dev] [PATCH] net/bnxt: cleanup and fixes in Rx/Tx queue release ops

2020-10-21 Thread Ajit Khaparde
On Mon, Oct 19, 2020 at 9:19 PM Somnath Kotur wrote: > > Some of the ring related memory was not being freed in both the release > ops. Fix to free them now > Add some more NULL ptr checks in the corresponding queue_release_mbufs() > and queue_release_op() respectively. > Also call queue_release_o

Re: [dpdk-dev] [PATCH v2 00/11] bnxt fixes and enhancements to TRUFLOW support

2020-10-21 Thread Ajit Khaparde
On Tue, Oct 20, 2020 at 2:55 PM Ajit Khaparde wrote: > > This patchset has support for VXLAN decap full offload, > SR device support in tf_core and a few bug fixes. > > v1->v2: > - Squashed some patches. > - Updated commit logs. > - Fixed a compilation issue reported during clang builds. Fixed

[dpdk-dev] [PATCH] net/mlx5: implement tunnel offload API

2020-10-21 Thread Gregory Etelson
Tunnel Offload API provides hardware independent, unified model to offload tunneled traffic. Key model elements are: - apply matches to both outer and inner packet headers during entire offload procedure; - restore outer header of partially offloaded packet; - model is implemented as a set of

[dpdk-dev] [PATCH] net/mlx5: fix port shared data reference count

2020-10-21 Thread Xueming Li
When probe a representor, tag cache hash table and modification cache hash table allocated memory upon each port, overwrote previous existing cache in shared context data. This patch moves reference check of shared data prior to hash table allocation to avoid such issue. Fixes: 6801116688fe ("net

Re: [dpdk-dev] [PATCH v2] regexdev: add OOS capability definition

2020-10-21 Thread Ori Kam
> -Original Message- > From: dev On Behalf Of g...@marvell.com > Sent: Wednesday, October 21, 2020 11:04 AM > Subject: [dpdk-dev] [PATCH v2] regexdev: add OOS capability definition > > From: Guy Kaneti > > Add out of order scan capability to check PMD > support for OOS. > > Signed-o

  1   2   >