> -----Original Message----- > From: Andrew Rybchenko <arybche...@solarflare.com> > Sent: Thursday, October 22, 2020 12:05 AM > To: Guo, Jia <jia....@intel.com>; Lu, Wenzhuo <wenzhuo...@intel.com>; > Xing, Beilei <beilei.x...@intel.com>; Iremonger, Bernard > <bernard.iremon...@intel.com>; Ray Kinsella <m...@ashroe.eu>; Neil > Horman <nhor...@tuxdriver.com>; Rasesh Mody <rm...@marvell.com>; > Shahed Shaikh <shsha...@marvell.com>; Andrew Rybchenko > <andrew.rybche...@oktetlabs.ru>; Thomas Monjalon > <tho...@monjalon.net>; Yigit, Ferruh <ferruh.yi...@intel.com> > Cc: dev@dpdk.org > Subject: Re: [PATCH 01/14] ethdev: remove legacy MACVLAN filter type > support > > On 10/21/20 6:31 AM, Guo, Jia wrote: > > > >> -----Original Message----- > >> From: Andrew Rybchenko <arybche...@solarflare.com> > >> Sent: Sunday, October 18, 2020 10:09 PM > >> To: Lu, Wenzhuo <wenzhuo...@intel.com>; Xing, Beilei > >> <beilei.x...@intel.com>; Iremonger, Bernard > >> <bernard.iremon...@intel.com>; Ray Kinsella <m...@ashroe.eu>; Neil > >> Horman <nhor...@tuxdriver.com>; Guo, Jia <jia....@intel.com>; > Rasesh > >> Mody <rm...@marvell.com>; Shahed Shaikh <shsha...@marvell.com>; > >> Andrew Rybchenko <andrew.rybche...@oktetlabs.ru>; Thomas > Monjalon > >> <tho...@monjalon.net>; Yigit, Ferruh <ferruh.yi...@intel.com> > >> Cc: dev@dpdk.org > >> Subject: [PATCH 01/14] ethdev: remove legacy MACVLAN filter type > >> support > >> > >> RTE flow API should be used for filtering. > > > > Look like each patch in the patch set remove one specific legacy > > filter, so I think the removing filter info is need to show in the commit > > log > to make it more clear, please add in the next version. > > Sorry, don't understand. Isn't MACVLAN in summary sufficient?
Sorry, maybe I did't say clear. Basically we concentrate the context in title and then detail more in description, for this description, maybe some confuse that if this patch is wholly for all filtering but eventually it just specific for one filtering.
