> -----Original Message----- > From: Andrew Rybchenko <arybche...@solarflare.com> > Sent: Thursday, October 22, 2020 12:09 AM > To: Guo, Jia <jia....@intel.com>; Xing, Beilei <beilei.x...@intel.com>; > Thomas Monjalon <tho...@monjalon.net>; Yigit, Ferruh > <ferruh.yi...@intel.com>; Andrew Rybchenko > <andrew.rybche...@oktetlabs.ru> > Cc: dev@dpdk.org > Subject: Re: [PATCH 02/14] ethdev: move MAC filter type to i40e driver > > On 10/21/20 7:01 AM, Guo, Jia wrote: > > > >> -----Original Message----- > >> From: Andrew Rybchenko <arybche...@solarflare.com> > >> Sent: Sunday, October 18, 2020 10:09 PM > >> To: Xing, Beilei <beilei.x...@intel.com>; Guo, Jia > >> <jia....@intel.com>; Thomas Monjalon <tho...@monjalon.net>; Yigit, > >> Ferruh <ferruh.yi...@intel.com>; Andrew Rybchenko > >> <andrew.rybche...@oktetlabs.ru> > >> Cc: dev@dpdk.org > >> Subject: [PATCH 02/14] ethdev: move MAC filter type to i40e driver > >> > >> net/i40e driver is the only user of the enum rte_mac_filter_type. > >> Move the define to the driver and use i40e_ prefix instead of rte_. > >> > >> Signed-off-by: Andrew Rybchenko <arybche...@solarflare.com> > >> --- > >> drivers/net/i40e/i40e_ethdev.c | 58 ++++++++++++++++---------------- > >> drivers/net/i40e/i40e_ethdev.h | 15 +++++++-- > >> drivers/net/i40e/i40e_pf.c | 2 +- > >> drivers/net/i40e/rte_pmd_i40e.c | 30 ++++++++--------- > >> lib/librte_ethdev/rte_eth_ctrl.h | 11 ------ > >> 5 files changed, 58 insertions(+), 58 deletions(-) > >> > > > > Where is the related remove in testpmd about the rte_mac_filter_type? > > There is no rte_mac_filter_type in testpmd. > Corresponding filter support is removed in the previous patch including > testpmd.
Oh, seems that there is some overlap between MACVLAN and MAC filter patch, I am not sure if this is a good suggestion that decouple this two testpmd usage or just merge this two patch into one patch, basically flow that one patch involve the removing of the function and corresponding usage.
