> -----Original Message----- > From: Bruce Richardson <bruce.richard...@intel.com> > Sent: Wednesday, October 21, 2020 1:53 PM > To: Juraj Linkeš <juraj.lin...@pantheon.tech> > Cc: ruifeng.w...@arm.com; honnappa.nagaraha...@arm.com; > phil.y...@arm.com; vcchu...@amazon.com; dharmik.thak...@arm.com; > jerinjac...@gmail.com; hemant.agra...@nxp.com; dev@dpdk.org > Subject: Re: [RFC PATCH v3 1/6] build: rename default Arm build to generic- > armv8 > > On Wed, Oct 21, 2020 at 01:37:36PM +0200, Juraj Linkeš wrote: > > The current machine='default' build name is not descriptive. The > > actual default build is machine='native'. Add an alternative string > > which does the same build and better describes what we're building: > > machine='generic-armv8'. Leave machine='default' for backwards > > compatibility. > > > > Signed-off-by: Juraj Linkeš <juraj.lin...@pantheon.tech> --- > > config/arm/meson.build | 31 ++++++++++++++++--------------- > > config/meson.build | 3 --- 2 files changed, 16 insertions(+), 18 > > deletions(-) > > > > diff --git a/config/arm/meson.build b/config/arm/meson.build index > > b49203fa8..c88e34a2b 100644 --- a/config/arm/meson.build +++ > > b/config/arm/meson.build @@ -1,12 +1,13 @@ # SPDX-License-Identifier: > > BSD-3-Clause # Copyright(c) 2017 Intel Corporation. # Copyright(c) > > 2017 Cavium, Inc +# Copyright(c) 2020 PANTHEON.tech s.r.o. > > > > # for checking defines we need to use the correct compiler flags > > march_opt = '-march=@0@'.format(machine) > > > > arm_force_native_march = false -arm_force_default_march = (machine == > > 'default') +arm_force_generic_march = (machine == 'default' or > > machine == 'generic-armv8') > > > > Rather than having this just for arm, how about adding "generic" as a synonym > for "default" at the top level, since it probably better describes what > "default" > does for all architectures.
Okay, makes sense. I'll do that in the next version.
