[dpdk-dev] [PATCH 1/8] net/i40e/base: enable FEC on/off flag setting for X722

2020-07-20 Thread Guinan Sun
Starting with API version 1.10 firmware for X722 devices has ability to change FEC settings in PHY. Code added in this patch checks API version and sets appropriate capability flag. Signed-off-by: Dawid Lukwinski Signed-off-by: Guinan Sun --- drivers/net/i40e/base/i40e_adminq.c | 6 ++

[dpdk-dev] [PATCH 0/8] update i40e base code

2020-07-20 Thread Guinan Sun
update i40e base code. source code of i40e driver: cid-i40e.2020.07.16.tar.gz released by the team which develop basic drivers for any i40e NIC. changelog in ND share repo: >From fc99a1143d3f ("i40e-shared: FEC on/off support flag for X722") To 673ff35c1c73 ("i40e-shared: Add support for firmware

Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix binding interrupt without msix vectors

2020-07-20 Thread Jiang, MaoX
Thanks Jia. Comments as below. > -Original Message- > From: Guo, Jia > Sent: Tuesday, July 21, 2020 11:58 AM > To: Jiang, MaoX ; Ye, Xiaolong > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix binding interrupt without > msix vectors > > hi, jiang m

Re: [dpdk-dev] [PATCH v2] net/i40e: fix incorrect hash look up table

2020-07-20 Thread Xie, WeiX
Tested-by: Zhang, XiX Regards, Xie Wei -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shougang Wang Sent: Tuesday, July 21, 2020 1:49 PM To: dev@dpdk.org Cc: Xing, Beilei ; Guo, Jia ; Wang, ShougangX ; sta...@dpdk.org Subject: [dpdk-dev] [PATCH v2] net/i40e: fi

[dpdk-dev] [PATCH v2] net/i40e: fix incorrect hash look up table

2020-07-20 Thread Shougang Wang
The hash look up table(LUT) will not be initializing when starting testpmd with --disable-rss. So that some invalid queue indexes may still in the LUT. When enable RSS by creating RSS rule, some packets will not be into the valid queues. This patch fixes this issue by initializing the LUT when crea

Re: [dpdk-dev] [PATCH v2] vhost: support async copy free segmentations

2020-07-20 Thread Fu, Patrick
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Monday, July 20, 2020 10:58 PM > To: Fu, Patrick ; dev@dpdk.org; Xia, Chenbo > > Cc: Wang, Yinan > Subject: Re: [PATCH v2] vhost: support async copy free segmentations > > Hi Patrick, > > On 7/15/20 1:15 PM, patrick...@in

[dpdk-dev] [PATCH v3] vhost: fix wrong async completion of multi-seg packets

2020-07-20 Thread patrick . fu
From: Patrick Fu In async enqueue copy, a packet could be split into multiple copy segments. When polling the copy completion status, current async data path assumes the async device callbacks are aware of the packet boundary and return completed segments only if all segments belonging to the sam

Re: [dpdk-dev] Random failure in service_autotest

2020-07-20 Thread Honnappa Nagarahalli
> >>> Subject: Re: [dpdk-dev] Random failure in service_autotest > >>> > >>> Lukasz Wojciechowski writes: > >>> > W dniu 17.07.2020 o 17:19, David Marchand pisze: > > On Fri, Jul 17, 2020 at 10:56 AM David Marchand > > wrote: > >> On Wed, Jul 15, 2020 at 12:41 PM Ferruh Yigit >

Re: [dpdk-dev] net/e1000: fix segfault on tx done clean up

2020-07-20 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Zhao1, Wei > Sent: Thursday, July 16, 2020 5:16 PM > To: Guo, Jia > Cc: bmcf...@redhat.com; dev@dpdk.org > Subject: Re: [dpdk-dev] net/e1000: fix segfault on tx done clean up > > > Reviewed-by: Wei Zhao > > > -Original Message-

Re: [dpdk-dev] [dpdk-dev v1] net/iavf: fix issue for GTPU l4 hash

2020-07-20 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Jia > Sent: Monday, July 20, 2020 12:00 PM > To: Zhang, Qi Z ; Xing, Beilei ; > Wu, Jingjing > Cc: dev@dpdk.org; Guo, Junfeng ; Su, Simei > ; Guo, Jia > Subject: [dpdk-dev v1] net/iavf: fix issue for GTPU l4 hash > > When the configure pattern involv

Re: [dpdk-dev] [dpdk-dev v1] net/ice: fix issue for GTPU l4 hash

2020-07-20 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Jia > Sent: Tuesday, July 21, 2020 10:33 AM > To: Zhang, Qi Z ; Yang, Qiming > Cc: dev@dpdk.org; Su, Simei ; Guo, Jia > Subject: [dpdk-dev v1] net/ice: fix issue for GTPU l4 hash > > When the configure pattern involve GTPU inner l3 and l4, even the c

Re: [dpdk-dev] [PATCH v3] lib/table: fix cache alignment issue

2020-07-20 Thread Xu, Ting
Hi, Cristian > -Original Message- > From: Dumitrescu, Cristian > Sent: Monday, July 20, 2020 10:38 PM > To: Xu, Ting ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH v3] lib/table: fix cache alignment issue > > > > > -Original Message- > > From: Xu, Ting > > Sent: Th

Re: [dpdk-dev] [dpdk-dev v1] net/ice: fix symmetric hash configuration

2020-07-20 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Jia > Sent: Monday, July 20, 2020 5:14 PM > To: Zhang, Qi Z ; Yang, Qiming > Cc: dev@dpdk.org; Su, Simei ; Guo, Jia > Subject: [dpdk-dev v1] net/ice: fix symmetric hash configuration > > Some protocol don't support symmetric hash, need to handle thes

Re: [dpdk-dev] [DPDK v3] net/e1000: add VLAN extend feature to capability

2020-07-20 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Zhao1, Wei > Sent: Tuesday, July 21, 2020 11:31 AM > To: Peng, ZhihongX ; Guo, Jia > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [DPDK v3] net/e1000: add VLAN extend feature to > capability > > Reviewed-by: Wei Zhao > > >

Re: [dpdk-dev] [DPDK v2] net/i40e: add VLAN filter feature to capability

2020-07-20 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Jeff Guo > Sent: Tuesday, July 21, 2020 11:12 AM > To: Peng, ZhihongX ; Xing, Beilei > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [DPDK v2] net/i40e: add VLAN filter feature to > capability > > Acked-by: Jeff Guo > > O

Re: [dpdk-dev] [PATCH v3] net/mlx5: relaxed ordering for multi-packet RQ buffer refcnt

2020-07-20 Thread Alexander Kozyrev
> > > > > Subject: RE: [dpdk-dev] [PATCH v3] net/mlx5: relaxed ordering for > > > > multi- packet RQ buffer refcnt > > > > > > > > Hi Phil Yang, we noticed that this patch gives us 10% of > > > > performance degradation on ARM. > > > > x86 seems to be unaffected though. Do you know what may be th

Re: [dpdk-dev] [PATCH v3] net/mlx5: relaxed ordering for multi-packet RQ buffer refcnt

2020-07-20 Thread Honnappa Nagarahalli
> > > Subject: RE: [dpdk-dev] [PATCH v3] net/mlx5: relaxed ordering for > > > multi- packet RQ buffer refcnt > > > > > > Hi Phil Yang, we noticed that this patch gives us 10% of performance > > > degradation on ARM. > > > x86 seems to be unaffected though. Do you know what may be the > > > reason

Re: [dpdk-dev] [PATCH v3] net/mlx5: relaxed ordering for multi-packet RQ buffer refcnt

2020-07-20 Thread Alexander Kozyrev
> Phil Yang writes: > > <...> > > Subject: RE: [dpdk-dev] [PATCH v3] net/mlx5: relaxed ordering for > > multi- packet RQ buffer refcnt > > > > Hi Phil Yang, we noticed that this patch gives us 10% of performance > > degradation on ARM. > > x86 seems to be unaffected though. Do you know what may b

Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix binding interrupt without msix vectors

2020-07-20 Thread Jeff Guo
hi, jiang mao On 7/9/2020 3:50 AM, Jiang Mao wrote: The value of vsi->nb_msix shouldn`t be zero, otherwise, all of interrupts will be bind to vector 0. Fixes: 4861cde461 (i40e: new poll mode driver) Cc: sta...@dpdk.org Blank line is need before Signed-off. And please remember --reply-to whe

Re: [dpdk-dev] [PATCH v1] vhost: add vq status check in async enqueue poll

2020-07-20 Thread Fu, Patrick
V2 patch sent with revised title > -Original Message- > From: Maxime Coquelin > Sent: Monday, July 20, 2020 11:58 PM > To: Fu, Patrick ; dev@dpdk.org; Xia, Chenbo > > Subject: Re: [PATCH v1] vhost: add vq status check in async enqueue poll > > What about this commit title? > vhost: fix

[dpdk-dev] [PATCH v2] vhost: fix missing virtqueue status check in async path

2020-07-20 Thread patrick . fu
From: Patrick Fu Vring should not be touched if vq is disabled. This patch adds the vq status check in async enqueue polling to avoid accessing to a disabled queue. Fixes: cd6760da1076 ("vhost: introduce async enqueue for split ring") Signed-off-by: Patrick Fu --- v2: revise commit title li

Re: [dpdk-dev] [DPDK v3] net/e1000: add VLAN extend feature to capability

2020-07-20 Thread Zhao1, Wei
Reviewed-by: Wei Zhao > -Original Message- > From: Peng, ZhihongX > Sent: Tuesday, July 21, 2020 11:05 AM > To: Zhao1, Wei ; Guo, Jia > Cc: dev@dpdk.org; Peng, ZhihongX ; > sta...@dpdk.org > Subject: [DPDK v3] net/e1000: add VLAN extend feature to capability > > From: Peng Zhihong >

Re: [dpdk-dev] [PATCH 1/9] net/dpaa2: remove Rx timestamp enable PMD API

2020-07-20 Thread Hemant Agrawal
-Original Message- From: Ferruh Yigit Sent: Tuesday, July 21, 2020 7:03 AM To: Hemant Agrawal ; dev@dpdk.org Subject: Re: [PATCH 1/9] net/dpaa2: remove Rx timestamp enable PMD API Importance: High On 7/10/2020 5:21 PM, Hemant Agrawal wrote: > This experimental API is no longer required

Re: [dpdk-dev] [PATCH v3 1/8] net/dpaa: add support for fmlib in dpdk

2020-07-20 Thread Hemant Agrawal
Hi Thomas, On 20-Jul-20 10:36 PM, Thomas Monjalon wrote: > 20/07/2020 06:50, Hemant Agrawal: >> HI Thomas, >> >> From: Thomas Monjalon >> 17/07/2020 13:36, Ferruh Yigit: >>> On 7/11/2020 9:17 AM, Hemant Agrawal wrote: DPAA platorm MAC interface is known as FMAN i.e. Frame Manager. Ther

[dpdk-dev] [PATCH v3] vhost: fix missing device pointer validity check

2020-07-20 Thread patrick . fu
From: Patrick Fu This patch adds the check of dev pointer in vhost async enqueue completion poll. If a NULL dev pointer detected, the poll function returns immediately. Coverity issue: 360839 Fixes: cd6760da1076 ("vhost: introduce async enqueue for split ring") Signed-off-by: Patrick Fu --- v2

[dpdk-dev] [PATCH] crypto/octeontx2: fix structure alignment

2020-07-20 Thread Tejasree Kondoj
The structure cpt_request_info needs only 8 byte alignment. This patch replaces __rte_cache_aligned of cpt_request_info with __rte_aligned(8) and removes __rte_aligned(8) in cpt_meta_info structure. Fixes: fab634eb87ca ("crypto/octeontx2: support security session data path") Signed-off-by: Tejasr

Re: [dpdk-dev] [PATCH v1] vhost: set zmbufs to NULL when freed

2020-07-20 Thread Fu, Patrick
V2 patch sent with revised title > -Original Message- > From: Maxime Coquelin > Sent: Monday, July 20, 2020 11:52 PM > To: Fu, Patrick ; dev@dpdk.org; Xia, Chenbo > > Cc: Wang, Yinan > Subject: Re: [PATCH v1] vhost: set zmbufs to NULL when freed > > Do you agree with below title? > vho

[dpdk-dev] [PATCH v2] vhost: fix double-free with zero-copy

2020-07-20 Thread patrick . fu
From: Patrick Fu zmbufs should be set to NULL when getting freed to avoid double free on the same buffer pointer Fixes: b0a985d1f340 ("vhost: add dequeue zero copy") Signed-off-by: Patrick Fu --- v2: - revise commit message title lib/librte_vhost/vhost_user.c | 1 + 1 file changed, 1 insert

Re: [dpdk-dev] [DPDK v2] net/i40e: add VLAN filter feature to capability

2020-07-20 Thread Jeff Guo
Acked-by: Jeff Guo On 7/21/2020 10:45 AM, zhihongx.p...@intel.com wrote: From: Peng Zhihong The rte_eth_dev_set_vlan_offload function will check vlan rx offload capability, the i40e vf has vlan filter feature but DEV_RX_OFFLOAD_VLAN_FILTER is not set into the capability, that will cause setti

[dpdk-dev] [DPDK v3] net/e1000: add VLAN extend feature to capability

2020-07-20 Thread zhihongx . peng
From: Peng Zhihong The rte_eth_dev_set_vlan_offload function will check vlan rx offload capability, the i350/i210/i211 nics have vlan extend feature but DEV_RX_OFFLOAD_VLAN_EXTEND is not set into the capability, that will cause setting fail. So need to add this capability in igb_get_rx_port_offlo

Re: [dpdk-dev] [PATCH v1] vhost: support cross page buf in async data path

2020-07-20 Thread Fu, Patrick
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, July 21, 2020 12:40 AM > To: Fu, Patrick ; dev@dpdk.org; Xia, Chenbo > > Subject: Re: [PATCH v1] vhost: support cross page buf in async data path > > The title could be improved, it is not very clear IMHO. How abou

[dpdk-dev] [DPDK v2] net/i40e: add VLAN filter feature to capability

2020-07-20 Thread zhihongx . peng
From: Peng Zhihong The rte_eth_dev_set_vlan_offload function will check vlan rx offload capability, the i40e vf has vlan filter feature but DEV_RX_OFFLOAD_VLAN_FILTER is not set into the capability, that will cause setting fail. So need to add this capability in i40e_vf_representor_dev_infos_get

[dpdk-dev] [dpdk-dev v1] net/ice: fix issue for GTPU l4 hash

2020-07-20 Thread Jeff Guo
When the configure pattern involve GTPU inner l3 and l4, even the configure input set only l3 but not l4, the different l4 protocol header should also be configured for the different l4 protocol. Fixes: 0b952714e9c1 ("net/ice: refactor PF hash flow") Fixes: de32fa2ba27b ("net/ice: support RSS for

Re: [dpdk-dev] [PATCH v6 0/2] introduce asynchronous data path for vhost

2020-07-20 Thread Fu, Patrick
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Monday, July 20, 2020 9:27 PM > To: Fu, Patrick ; dev@dpdk.org; Xia, Chenbo > ; Wang, Zhihong > Cc: Wang, Yinan ; Jiang, Cheng1 > ; Liang, Cunming > Subject: Re: [PATCH v6 0/2] introduce asynchronous data path for vhost >

Re: [dpdk-dev] [PATCH v3] net/mlx5: relaxed ordering for multi-packet RQ buffer refcnt

2020-07-20 Thread Phil Yang
Alexander Kozyrev writes: <...> > Subject: RE: [dpdk-dev] [PATCH v3] net/mlx5: relaxed ordering for multi- > packet RQ buffer refcnt > > Hi Phil Yang, we noticed that this patch gives us 10% of performance > degradation on ARM. > x86 seems to be unaffected though. Do you know what may be the rea

Re: [dpdk-dev] [PATCH 1/9] net/dpaa2: remove Rx timestamp enable PMD API

2020-07-20 Thread Ferruh Yigit
On 7/10/2020 5:21 PM, Hemant Agrawal wrote: > This experimental API is no longer required as the same > purpose can be solved with standard DEV_RX_OFFLOAD_TIMESTAMP > > Signed-off-by: Hemant Agrawal <...> > -/** > - * @warning > - * @b EXPERIMENTAL: this API may change, or be removed, without p

Re: [dpdk-dev] [PATCH v2] net: do fragmented headers check in non-debug build as well

2020-07-20 Thread Ferruh Yigit
On 7/13/2020 3:22 PM, Andrew Rybchenko wrote: > Pseudo-header checksum calculation requires contiguous headers. > There is no any formal requirements on data location and mbuf > structure which could be used by the application. > > Since > > commit dfc6b2fd8da3 ("mbuf: remove Intel offload checks

Re: [dpdk-dev] [PATCH] net: fix compilation with pedantic enabled

2020-07-20 Thread Ferruh Yigit
On 7/16/2020 1:12 PM, Raslan Darawsheh wrote: > when trying to compile rte_mpls with pedantic enabled, > it will complain about bit field defintion. > error: type of bit-field 'bs' is a GCC extension [-Werror=pedantic] > error: type of bit-field 'tc' is a GCC extension [-Werror=pedantic] > error: t

Re: [dpdk-dev] [PATCH v4] net/bonding: change the state machine to defaulted

2020-07-20 Thread Ferruh Yigit
On 7/18/2020 8:08 AM, Wei Hu (Xavier) wrote: > Hi, Weifeng Li > > > On 2020/7/18 12:35, Weifeng Li wrote: >> A dpdk bonding 802.3ad network as follows: >> +--++---+ >> |dpdk lacp |bond1.1 <--> bond2.1|switch lacp| >> | |bond1.2 <--> bond2.2

Re: [dpdk-dev] [PATCH v3] net/mlx5: relaxed ordering for multi-packet RQ buffer refcnt

2020-07-20 Thread Alexander Kozyrev
Hi Phil Yang, we noticed that this patch gives us 10% of performance degradation on ARM. x86 seems to be unaffected though. Do you know what may be the reason of this behavior? Regards, Alex > -Original Message- > From: dev On Behalf Of Phil Yang > Sent: Sunday, July 12, 2020 23:02 > T

Re: [dpdk-dev] [dpdk-stable] [PATCH V2] net/bonding: delete redundant code

2020-07-20 Thread Ferruh Yigit
On 7/4/2020 2:22 AM, Wei Hu (Xavier) wrote: > > > On 2020/7/4 9:15, 197020...@qq.com wrote: >> From: pandongyang <197020...@qq.com> >> >> The function valid_bonded_port_id() has already contains function >> rte_eth_dev_is_valid_port(), so delete redundant check. >> >> Fixes: 588ae95e7983 ("net/bo

Re: [dpdk-dev] Using C11 atomic semantic

2020-07-20 Thread Honnappa Nagarahalli
> > 20/07/2020 17:44, Honnappa Nagarahalli: > > From: Thomas Monjalon > > > > > > In the techboard of April 22, it has been decided to block patches > > > using rte_atomicNN_xx and rte_smp_*mb APIs, starting DPDK 20.08. > > > Meeting minutes: > > > http://mails.dpdk.org/archives/dev/2020-April

Re: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level

2020-07-20 Thread Ori Kam
Hi David, > -Original Message- > From: David Marchand > > On Mon, Jul 20, 2020 at 6:48 PM Thomas Monjalon > wrote: > > > > 20/07/2020 18:21, Ferruh Yigit: > > > On 7/17/2020 2:49 PM, Parav Pandit wrote: > > > > Currently mlx5_common uses CLASS priority to initialize > > > > common code

Re: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level

2020-07-20 Thread Ori Kam
> -Original Message- > From: Ferruh Yigit > > On 7/20/2020 6:26 PM, Ori Kam wrote: > > Hi > > > >> -Original Message- > >> From: Ferruh Yigit > >> On 7/20/2020 5:48 PM, Thomas Monjalon wrote: > >>> 20/07/2020 18:21, Ferruh Yigit: > On 7/17/2020 2:49 PM, Parav Pandit wrote:

Re: [dpdk-dev] [PATCH v2 0/2] Windows bus/vdev support

2020-07-20 Thread Kadam, Pallavi
On 7/7/2020 1:48 AM, tal...@mellanox.com wrote: From: Tal Shnaiderman This patchset implements the EAL functions needed for probing PMDs using vdev on Windows. --- v2: Added missing exports and includes (NarcisaV) --- Tal Shnaiderman (2): eal/windows: add needed calls to detect vdev PM

Re: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level

2020-07-20 Thread David Marchand
On Mon, Jul 20, 2020 at 6:48 PM Thomas Monjalon wrote: > > 20/07/2020 18:21, Ferruh Yigit: > > On 7/17/2020 2:49 PM, Parav Pandit wrote: > > > Currently mlx5_common uses CLASS priority to initialize > > > common code before initializing the PMD. > > > However mlx5_common is not really a class, it

Re: [dpdk-dev] [PATCH v3 00/14] bnxt patches

2020-07-20 Thread Ajit Khaparde
On Sat, Jul 18, 2020 at 12:25 AM Ajit Khaparde wrote: > Some changes, cleanups/fixes in the TF-ULP layer > > v1->v2: Got rid of patch 14 from v1 that was adding debug logs for now > v2->v3: Update commit logs based on review comments > Patches applied to dpdk-next-net-brcm. > > Farah Smith (2):

Re: [dpdk-dev] [PATCH v4 25/27] eal: mark old naming as deprecated

2020-07-20 Thread Stephen Hemminger
On Mon, 20 Jul 2020 13:32:27 +0100 "Burakov, Anatoly" wrote: > On 18-Jul-20 3:22 AM, Stephen Hemminger wrote: > > On Fri, 17 Jul 2020 16:21:37 +0100 > > "Burakov, Anatoly" wrote: > > > >> On 16-Jul-20 11:04 PM, Stephen Hemminger wrote: > >>> On Thu, 16 Jul 2020 14:41:41 +0100 > >>> "Burakov

Re: [dpdk-dev] [PATCH v3 1/8] net/dpaa: add support for fmlib in dpdk

2020-07-20 Thread Stephen Hemminger
On Mon, 20 Jul 2020 04:50:37 + Hemant Agrawal wrote: > >But most importantly, the licensing has not been agreed in techboard and > >govboard. > > [Hemant] you are wrong here. Which license difference are you talking about? > Standard licenses do not need techboard and govboard approval.

Re: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level

2020-07-20 Thread Ferruh Yigit
On 7/20/2020 6:26 PM, Ori Kam wrote: > Hi > >> -Original Message- >> From: Ferruh Yigit >> On 7/20/2020 5:48 PM, Thomas Monjalon wrote: >>> 20/07/2020 18:21, Ferruh Yigit: On 7/17/2020 2:49 PM, Parav Pandit wrote: > Currently mlx5_common uses CLASS priority to initialize > co

Re: [dpdk-dev] [EXT] Re: [PATCH v3 8/8] crypto/octeontx2: add cryptodev sec enqueue and dequeue routines

2020-07-20 Thread Ferruh Yigit
On 7/20/2020 6:20 PM, Tejasree Kondoj wrote: > Hi Ferruh, > > Please see inline. > > Thanks > Tejasree > >> -Original Message- >> From: Ferruh Yigit >> Sent: Monday, July 20, 2020 5:33 PM >> To: Tejasree Kondoj ; Akhil Goyal >> ; Radu Nicolau >> Cc: Vamsi Krishna Attunuru ; Narayana Pr

Re: [dpdk-dev] [PATCH v2 2/2] test/service: fix race condition on stopping lcore

2020-07-20 Thread Lukasz Wojciechowski
W dniu 20.07.2020 o 16:38, Harry van Haaren pisze: > This commit fixes a potential race condition in the tests > where the lcore running a service would increment a counter > that was already reset by the test-suite thread. The resulting > race-condition incremented value could cause CI failures,

Re: [dpdk-dev] [PATCH v2 1/2] service: add API to retrieve service core active

2020-07-20 Thread Lukasz Wojciechowski
W dniu 20.07.2020 o 16:38, Harry van Haaren pisze: > This commit adds a new experimental API which allows the user > to retrieve the active state of an lcore. Knowing when the service > lcore is completed its polling loop can be useful to applications > to avoid race conditions when e.g. finalizi

Re: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level

2020-07-20 Thread Ori Kam
Hi > -Original Message- > From: Ferruh Yigit > On 7/20/2020 5:48 PM, Thomas Monjalon wrote: > > 20/07/2020 18:21, Ferruh Yigit: > >> On 7/17/2020 2:49 PM, Parav Pandit wrote: > >>> Currently mlx5_common uses CLASS priority to initialize > >>> common code before initializing the PMD. > >>>

Re: [dpdk-dev] [EXT] Re: [PATCH v3 8/8] crypto/octeontx2: add cryptodev sec enqueue and dequeue routines

2020-07-20 Thread Tejasree Kondoj
Hi Ferruh, Please see inline. Thanks Tejasree > -Original Message- > From: Ferruh Yigit > Sent: Monday, July 20, 2020 5:33 PM > To: Tejasree Kondoj ; Akhil Goyal > ; Radu Nicolau > Cc: Vamsi Krishna Attunuru ; Narayana Prasad > Raju Athreya ; Anoob Joseph > ; dev@dpdk.org; Thomas Monja

Re: [dpdk-dev] [PATCH v3 1/8] net/dpaa: add support for fmlib in dpdk

2020-07-20 Thread Thomas Monjalon
20/07/2020 06:50, Hemant Agrawal: > HI Thomas, > > From: Thomas Monjalon > 17/07/2020 13:36, Ferruh Yigit: > > On 7/11/2020 9:17 AM, Hemant Agrawal wrote: > > > DPAA platorm MAC interface is known as FMAN i.e. Frame Manager. > > > There are two ways to control it. > > > 1. Statically configure t

Re: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level

2020-07-20 Thread Ferruh Yigit
On 7/20/2020 5:48 PM, Thomas Monjalon wrote: > 20/07/2020 18:21, Ferruh Yigit: >> On 7/17/2020 2:49 PM, Parav Pandit wrote: >>> Currently mlx5_common uses CLASS priority to initialize >>> common code before initializing the PMD. >>> However mlx5_common is not really a class, it is the pre-initializ

Re: [dpdk-dev] [PATCH 1/2] doc: add deprecation notice for make build system removal

2020-07-20 Thread Thomas Monjalon
20/07/2020 15:38, Andrew Rybchenko: > On 7/20/20 4:28 PM, Ferruh Yigit wrote: > > On 7/13/2020 1:31 PM, Bruce Richardson wrote: > >> Add in an official notice that the make build system is being removed in > >> 20.11 and provide a link to instructions on how to build using meson and > >> ninja inst

Re: [dpdk-dev] [PATCH v2] vhost: fix missing null dev pointer check

2020-07-20 Thread Ferruh Yigit
On 7/20/2020 4:55 PM, Maxime Coquelin wrote: > What about below title (we try to avoid passing variable names in commit > titles)? > vhost: fix missing device pointer validity check Existing commit dropped from next-net and patchwork status updated. > > On 7/16/20 5:37 PM, patrick...@intel.com w

Re: [dpdk-dev] [PATCH v1] vhost: add vq status check in async enqueue poll

2020-07-20 Thread Ferruh Yigit
On 7/20/2020 4:57 PM, Maxime Coquelin wrote: > What about this commit title? > vhost: fix missing virtqueue status check in async path Existing commit dropped from next-net and patchwork status updated. > > On 7/16/20 5:30 PM, patrick...@intel.com wrote: >> From: Patrick Fu >> >> Vring should n

Re: [dpdk-dev] [PATCH v2] vhost: support async copy free segmentations

2020-07-20 Thread Ferruh Yigit
On 7/20/2020 3:58 PM, Maxime Coquelin wrote: > Hi Patrick, > > On 7/15/20 1:15 PM, patrick...@intel.com wrote: >> From: Patrick Fu >> >> Vhost async enqueue assumes that all async copies should break at packet >> boundary. i.e. if a packet is splited into multiple copy segments, the >> async engi

Re: [dpdk-dev] [PATCH v1] vhost: set zmbufs to NULL when freed

2020-07-20 Thread Ferruh Yigit
On 7/20/2020 4:51 PM, Maxime Coquelin wrote: > Do you agree with below title? > vhost: fix double-free with zero-copy Existing commit dropped from next-net and patchwork status updated. > > Thanks, > Maxime > > On 7/15/20 5:58 PM, patrick...@intel.com wrote: >> From: Patrick Fu >> >> zmbufs sh

Re: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level

2020-07-20 Thread Thomas Monjalon
20/07/2020 18:21, Ferruh Yigit: > On 7/17/2020 2:49 PM, Parav Pandit wrote: > > Currently mlx5_common uses CLASS priority to initialize > > common code before initializing the PMD. > > However mlx5_common is not really a class, it is the pre-initialization > > code needed for the PMDs. > > > > In

Re: [dpdk-dev] Using C11 atomic semantic

2020-07-20 Thread Thomas Monjalon
20/07/2020 17:44, Honnappa Nagarahalli: > From: Thomas Monjalon > > > > In the techboard of April 22, it has been decided to block patches using > > rte_atomicNN_xx and rte_smp_*mb APIs, starting DPDK 20.08. > > Meeting minutes: > > http://mails.dpdk.org/archives/dev/2020-April/165143.html >

Re: [dpdk-dev] [PATCH v1] vhost: support cross page buf in async data path

2020-07-20 Thread Maxime Coquelin
The title could be improved, it is not very clear IMHO. On 7/20/20 4:52 AM, patrick...@intel.com wrote: > From: Patrick Fu > > Async copy fails when ring buffer cross two physical pages. This patch > fix the failure by letting copies occur in sync mode if crossing page > buffers are given. Woul

Re: [dpdk-dev] [PATCH v2 3/3] eal/windows: librte_net build on Windows

2020-07-20 Thread Dmitry Kozlyuk
On Mon, 20 Jul 2020 12:54:08 +, Fady Bader wrote: [snip] > > Getting the same error with a setup similar to Dmitry's. My setup: SDK > > 10.0.18362, > > I'm sending v4 patch that should resolve this. > > > clang 9.0.0. What version of clang are you using on your system? > > You can try inst

Re: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level

2020-07-20 Thread Ferruh Yigit
On 7/17/2020 2:49 PM, Parav Pandit wrote: > Currently mlx5_common uses CLASS priority to initialize > common code before initializing the PMD. > However mlx5_common is not really a class, it is the pre-initialization > code needed for the PMDs. > > In subsequent patch a needed initialization seque

[dpdk-dev] [PATCH v1] app/crypto-perf: support security protocol in PMDCC mode

2020-07-20 Thread David Coyle
This patch adds support for DOCSIS and PDCP security protocols to the pmd-cyclecount mode of the crypto performance tool. Adding this support involves freeing the correct session type (i.e. security or cryptodev session) when the test ends, depending on the op_type specificed. Signed-off-by: David

[dpdk-dev] [PATCH v1] crypto/qat: add DOCSIS performance optimization

2020-07-20 Thread David Coyle
DOCSIS protocol performance in the downlink direction can be improved significantly in the QAT SYM PMD, especially for larger packets, by pre-processing all CRC generations in a batch before building and enqueuing any requests to the HW. This patch adds this optimization. Fixes: 6f0ef237404b ("cry

Re: [dpdk-dev] [PATCH v1] vhost: add vq status check in async enqueue poll

2020-07-20 Thread Maxime Coquelin
What about this commit title? vhost: fix missing virtqueue status check in async path On 7/16/20 5:30 PM, patrick...@intel.com wrote: > From: Patrick Fu > > Vring should not be touched if vq is disabled. This patch adds the vq > status check in async enqueue polling to avoid accessing to a disab

Re: [dpdk-dev] [PATCH v2] vhost: fix missing null dev pointer check

2020-07-20 Thread Maxime Coquelin
What about below title (we try to avoid passing variable names in commit titles)? vhost: fix missing device pointer validity check On 7/16/20 5:37 PM, patrick...@intel.com wrote: > From: Patrick Fu > > This patch adds the check of dev pointer in vhost async enqueue > completion poll. If a NULL d

Re: [dpdk-dev] [PATCH v1] vhost: set zmbufs to NULL when freed

2020-07-20 Thread Maxime Coquelin
Do you agree with below title? vhost: fix double-free with zero-copy Thanks, Maxime On 7/15/20 5:58 PM, patrick...@intel.com wrote: > From: Patrick Fu > > zmbufs should be set to NULL when getting freed to avoid double free on > the same buffer pointer > > Fixes: b0a985d1f340 ("vhost: add dequ

Re: [dpdk-dev] Using C11 atomic semantic

2020-07-20 Thread Honnappa Nagarahalli
+Ruifeng > -Original Message- > From: Thomas Monjalon > Sent: Monday, July 20, 2020 10:34 AM > To: Honnappa Nagarahalli > Cc: ferruh.yi...@intel.com; david.march...@redhat.com; dev@dpdk.org; Phil > Yang ; techbo...@dpdk.org > Subject: Using C11 atomic semantic > > In the techboard of Ap

[dpdk-dev] Using C11 atomic semantic

2020-07-20 Thread Thomas Monjalon
In the techboard of April 22, it has been decided to block patches using rte_atomicNN_xx and rte_smp_*mb APIs, starting DPDK 20.08. Meeting minutes: http://mails.dpdk.org/archives/dev/2020-April/165143.html Deprecation notice: http://doc.dpdk.org/guides/rel_notes/deprecation.html S

Re: [dpdk-dev] [PATCH v3 07/17] net/mlx5: create Tx queues with DevX

2020-07-20 Thread Ferruh Yigit
On 7/20/2020 3:18 PM, Ferruh Yigit wrote: > On 7/16/2020 9:23 AM, Viacheslav Ovsiienko wrote: >> To provide the packet send schedule on mbuf timestamp the Tx >> queue must be attached to the same UAR as Clock Queue is. >> UAR is special hardware related resource mapped to the host >> memory and pro

Re: [dpdk-dev] [PATCH v2] vhost: support async copy free segmentations

2020-07-20 Thread Maxime Coquelin
Hi Patrick, On 7/15/20 1:15 PM, patrick...@intel.com wrote: > From: Patrick Fu > > Vhost async enqueue assumes that all async copies should break at packet > boundary. i.e. if a packet is splited into multiple copy segments, the > async engine should always report copy completion when entire pac

[dpdk-dev] [PATCH v2 1/2] service: add API to retrieve service core active

2020-07-20 Thread Harry van Haaren
This commit adds a new experimental API which allows the user to retrieve the active state of an lcore. Knowing when the service lcore is completed its polling loop can be useful to applications to avoid race conditions when e.g. finalizing statistics. The service thread itself now has a variable

Re: [dpdk-dev] [PATCH v3] lib/table: fix cache alignment issue

2020-07-20 Thread Dumitrescu, Cristian
> -Original Message- > From: Xu, Ting > Sent: Thursday, July 9, 2020 2:48 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Xu, Ting > ; sta...@dpdk.org > Subject: [PATCH v3] lib/table: fix cache alignment issue > > When create softnic hash table with 16 keys, it failed on 32bit > env

[dpdk-dev] [PATCH v2 2/2] test/service: fix race condition on stopping lcore

2020-07-20 Thread Harry van Haaren
This commit fixes a potential race condition in the tests where the lcore running a service would increment a counter that was already reset by the test-suite thread. The resulting race-condition incremented value could cause CI failures, as indicated by DPDK's CI. This patch fixes the race-condit

Re: [dpdk-dev] [PATCH v7 2/3] test/test_telemetry_data: add unit tests for data to JSON

2020-07-20 Thread Bruce Richardson
On Mon, Jul 20, 2020 at 03:04:02PM +0100, Ciara Power wrote: > From: Louise Kilheeney > > This patch adds tests for verifying telemetry data structures are > converted to JSON as expected. Both flat and recursive data structures > are tested, for all possible value types. > > The app connects to

Re: [dpdk-dev] Intel I350 support in DPDK 17.11

2020-07-20 Thread siddarth rai
+ igb maintainer On Mon, Jul 20, 2020 at 6:29 PM siddarth rai wrote: > Hi, > > I am using DPDK 17.11 in my application. I am facing an RX issue when > running the application with an intel I350 NIC. > Details of the NIC: > driver: igb > version: 5.4.0-k* > firmware-version: 1.63, 0x8d58, 1.1

Re: [dpdk-dev] [PATCH] service: fix stop API to wait for service thread

2020-07-20 Thread Van Haaren, Harry
> -Original Message- > From: Lukasz Wojciechowski > Sent: Monday, July 20, 2020 1:52 PM > To: Van Haaren, Harry ; dev@dpdk.org > Cc: david.march...@redhat.com; igor.roma...@oktetlabs.ru; > honnappa.nagaraha...@arm.com; Yigit, Ferruh ; > n...@arm.com; acon...@redhat.com > Subject: Re: [PATC

Re: [dpdk-dev] [PATCH v3 07/17] net/mlx5: create Tx queues with DevX

2020-07-20 Thread Ferruh Yigit
On 7/16/2020 9:23 AM, Viacheslav Ovsiienko wrote: > To provide the packet send schedule on mbuf timestamp the Tx > queue must be attached to the same UAR as Clock Queue is. > UAR is special hardware related resource mapped to the host > memory and provides doorbell registers, the assigning UAR > to

[dpdk-dev] [PATCH v7 2/3] test/test_telemetry_data: add unit tests for data to JSON

2020-07-20 Thread Ciara Power
From: Louise Kilheeney This patch adds tests for verifying telemetry data structures are converted to JSON as expected. Both flat and recursive data structures are tested, for all possible value types. The app connects to the telemetry socket as a client, and registers one command with a corresp

[dpdk-dev] [PATCH v7 3/3] ethdev: add common stats for telemetry

2020-07-20 Thread Ciara Power
The ethdev library now registers a telemetry command for common ethdev statistics. An example usage is shown below: Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2 {"version": "DPDK 20.08.0-rc1", "pid": 14119, "max_output_len": 16384} --> /ethdev/stats,0 {"/ethdev/stats": {"ipackets": 0, "opack

[dpdk-dev] [PATCH v7 1/3] telemetry: support array values in data objects

2020-07-20 Thread Ciara Power
Arrays of type uint64_t/int/string can now be included within an array or dict. One level of embedded containers is supported. This is necessary to allow for instances such as the ethdev queue stats to be reported as a list of uint64_t values, rather than having multiple dict entries with one uint6

[dpdk-dev] [PATCH v7 0/3] add basic ethdev stats with data object recursion

2020-07-20 Thread Ciara Power
v7: - Simplified connecting to socket by removing use of glob. - Fixed buffer overflow issue when reading from socket. - Split expected response strings over multiple lines. v6: - Fixed FreeBSD build failure for unit tests. - Added comments and expanded commit log. - Add loop to call te

Re: [dpdk-dev] [PATCH 1/2] doc: add deprecation notice for make build system removal

2020-07-20 Thread Andrew Rybchenko
On 7/20/20 4:28 PM, Ferruh Yigit wrote: > On 7/13/2020 1:31 PM, Bruce Richardson wrote: >> Add in an official notice that the make build system is being removed in >> 20.11 and provide a link to instructions on how to build using meson and >> ninja instead. >> >> Cc: Thomas Monjalon >> >> Signed-o

Re: [dpdk-dev] [PATCH 1/2] doc: add deprecation notice for make build system removal

2020-07-20 Thread Ferruh Yigit
On 7/13/2020 1:31 PM, Bruce Richardson wrote: > Add in an official notice that the make build system is being removed in > 20.11 and provide a link to instructions on how to build using meson and > ninja instead. > > Cc: Thomas Monjalon > > Signed-off-by: Bruce Richardson > --- > doc/guides/re

Re: [dpdk-dev] [PATCH v6 0/2] introduce asynchronous data path for vhost

2020-07-20 Thread Maxime Coquelin
Hi Patrick, Thanks for the series. I think we miss a chapter in the Vhost lib documentation to explain what this new API is about. Do you think you can write something by -rc3? Thanks in advance, Maxime On 7/7/20 7:07 AM, patrick...@intel.com wrote: > From: Patrick Fu > > Performing large mem

Re: [dpdk-dev] [PATCH v6 2/3] test/test_telemetry_data: add unit tests for data to JSON

2020-07-20 Thread Bruce Richardson
On Mon, Jul 20, 2020 at 12:19:06PM +0100, Ciara Power wrote: > From: Louise Kilheeney > > This patch adds tests for verifying telemetry data structures are > converted to JSON as expected. Both flat and recursive data structures > are tested, for all possible value types. > > The app connects to

[dpdk-dev] Intel I350 support in DPDK 17.11

2020-07-20 Thread siddarth rai
Hi, I am using DPDK 17.11 in my application. I am facing an RX issue when running the application with an intel I350 NIC. Details of the NIC: driver: igb version: 5.4.0-k* firmware-version: 1.63, 0x8d58, 1.1099.0 Kernel - 3.10.0-957.5.1.el7.x86_64 >From the release notes, I found out that th

Re: [dpdk-dev] [PATCH v1] app/crypto-perf: set mbuf lengths correctly for DOCSIS tests

2020-07-20 Thread Coyle, David
Hi Pablo, > -Original Message- > From: De Lara Guarch, Pablo > Sent: Friday, July 17, 2020 8:04 PM > > @@ -48,6 +48,10 @@ cperf_set_ops_security(struct rte_crypto_op **ops, > > } else > > buf_sz = options->test_buffer_size; > > > > +

Re: [dpdk-dev] [PATCH v2 3/3] eal/windows: librte_net build on Windows

2020-07-20 Thread Fady Bader
> > > Subject: Re: [PATCH v2 3/3] eal/windows: librte_net build on Windows > > > > > > > diff --git a/lib/librte_eal/common/meson.build > > > > b/lib/librte_eal/common/meson.build > > > > index e1bdaf024..05e40a26b 100644 > > > > --- a/lib/librte_eal/common/meson.build > > > > +++ b/lib/librte_ea

Re: [dpdk-dev] [PATCH] service: fix stop API to wait for service thread

2020-07-20 Thread Lukasz Wojciechowski
W dniu 20.07.2020 o 14:09, Harry van Haaren pisze: > This commit improves the service_lcore_stop() implementation, > waiting for the service core in question to return. The service > thread itself now has a variable to indicate if its thread is > active. When zero the service thread has completed

Re: [dpdk-dev] Random failure in service_autotest

2020-07-20 Thread Lukasz Wojciechowski
W dniu 20.07.2020 o 14:09, Van Haaren, Harry pisze: >> -Original Message- >> From: Phil Yang >> Sent: Saturday, July 18, 2020 9:34 AM >> To: Aaron Conole ; Lukasz Wojciechowski >> >> Cc: David Marchand ; Van Haaren, Harry >> ; Igor Romanov ; >> Honnappa Nagarahalli ; dev >> ; Yigit, Fer

[dpdk-dev] [PATCH v2 2/2] crypto/aesni-mb: improve security instance setup

2020-07-20 Thread David Coyle
This patch makes some improvements to the security instance setup for the AESNI-MB PMD, as follows: - fix potential memory leak where the security instance was not freed if an error occurred later in the device creation - tidy-up security instance initialization code by moving it all, including

[dpdk-dev] [PATCH v2 1/2] crypto/qat: improve security instance setup

2020-07-20 Thread David Coyle
This patch makes some improvements to the security instance setup for the QAT SYM PMD, as follows: - fix potential memory leak where the security instance was not freed if an error occurred later in the device creation - tidy-up security instance initialization code by moving it all, including

[dpdk-dev] [PATCH v2 0/2] improve security instance setup

2020-07-20 Thread David Coyle
These patches make some improvements to the security instance setup for the QAT SYM and AESNI-MB PMDs. David Coyle (2): crypto/qat: improve security instance setup crypto/aesni-mb: improve security instance setup drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 18 +- drivers/crypto/qat/

Re: [dpdk-dev] [PATCH v1 1/2] crypto/qat: improve security instance setup

2020-07-20 Thread Coyle, David
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Saturday, July 18, 2020 10:41 PM > > > > This patch makes some minor improvements to the security instance > > > > setup for the QAT SYM PMD. All of this setup code is now in one > > > > '#ifdef RTE_LIBRTE_SECURITY' block. Enablin

  1   2   >