[dpdk-dev] [PATCH] net/i40e: fix incorrect hash look up table

The hash look up table(LUT) will not be initializing when starting testpmd with --disable-rss. So that some queues in LUT will be invalid if rx queues is less than last time. When enable RSS by creating RSS rule, some packets will not be into the valid queues. This patch fixes this issue by initial

Re: [dpdk-dev] [PATCH v1] net/virtio-user: fix uninitialized variable

On 7/14/20 1:03 PM, Chenbo Xia wrote: > This patch fixes an issue that uninitialized has_reply_ack > is used for setting message flags. > > Coverity issue: 360834 > Fixes: c60208dd6384 ("net/virtio-user: support reply-ack") > > Signed-off-by: Chenbo Xia > --- > drivers/net/virtio/virtio_user/

Re: [dpdk-dev] [PATCH v3 1/3] net: fix s_addr redefinition in Windows

> -Original Message- > From: Olivier Matz > Sent: Monday, July 13, 2020 5:39 PM > To: Fady Bader > Cc: dev@dpdk.org; Thomas Monjalon ; Tasnim Bashar > ; Tal Shnaiderman ; Yohad Tor > ; dmitry.kozl...@gmail.com; > harini.ramakrish...@microsoft.com; ocard...@microsoft.com; > pallavi.ka..

[dpdk-dev] [PATCH v2 16/17] common/mlx5: add register access DevX routine

The DevX routine to read/write NIC registers via DevX API is added. This is the preparation step to check timestamp modes and units and gather the extended statistics. Signed-off-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c| 60 + drivers/

[dpdk-dev] [PATCH v2 13/17] net/mlx5: add scheduling support to send routine template

This patch adds send scheduling on timestamps into tx_burst routine template. The feature is controlled by static configuration flag, the actual routines supporting the new feature are generated over this updated template. Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- drivers/ne

[dpdk-dev] [PATCH v2 14/17] net/mlx5: add read device clock support

If send schedule feature is engaged there is the Clock Queue created, that reports reliable the current device clock counter value. The device clock counter can be read directly from the Clock Queue CQE. Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_o

[dpdk-dev] [PATCH v2 17/17] net/mlx5: convert Rx timestamps in realtime format

The ConnectX-6DX supports the timestamps in various formats, the new realtime format is introduced - the upper 32-bit word of timestamp contains the UTC seconds and the lower 32-bit word contains the nanoseconds. This patch detects what format is configured in the NIC and performs the conversion ac

[dpdk-dev] [PATCH v2 15/17] net/mlx5: provide the send scheduling error statistics

The mlx5 PMD exposes the following new introduced extended statistics counter to report the errors of packet send scheduling on timestamps: - txpp_err_miss_int - rearm queue interrupt was not handled was not handled in time and service routine might miss the completions - txpp_err_rea

[dpdk-dev] [PATCH v2 09/17] net/mlx5: introduce clock queue service routine

Service routine is invoked periodically on Rearm Queue completion interrupts, typically once per some milliseconds (1-16) to track clock jitter and wander in robust fashion. It performs the following: - fetches the completed CQEs for Rearm Queue - restarts Rearm Queue on errors - pushes new reques

[dpdk-dev] [PATCH v2 12/17] net/mlx5: prepare Tx datapath to support sheduling

The new static control flag is introduced to control routine generating from template, enabling the scheduling on timestamps. Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_rxtx.c | 97 +++- drivers/net/mlx5/mlx5_txq.c

[dpdk-dev] [PATCH v2 06/17] net/mlx5: create rearm queue for packet pacing

The dedicated Rearm Queue is needed to fire the work requests to the Clock Queue in realtime. The Clock Queue should never stop, otherwise the clock synchronization mignt be broken and packet send scheduling would fail. The Rearm Queue uses cross channel SEND_EN/WAIT operations to provides the requ

[dpdk-dev] [PATCH v2 11/17] net/mlx5: convert timestamp to completion index

The application provides timestamps in Tx mbuf as clocks, the hardware performs scheduling on Clock Queue completion index match. This patch introduces the timestamp-to-completion-index inline routine. Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.h |

[dpdk-dev] [PATCH v2 10/17] net/mlx5: prepare Tx queue structures to support timestamp

The fields to support send scheduling on dynamic timestamp field are introduced and initialized on device start. Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_rxtx.h| 4 drivers/net/mlx5/mlx5_trigger.c | 2 ++ drivers/net/mlx5/mlx5_txq.c | 32

[dpdk-dev] [PATCH v2 08/17] net/mlx5: allocate packet pacing context

This patch allocates the Packet Pacing context from the kernel, configures one according to requested pace send scheduling granularuty and assigns to Clock Queue. Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.h | 2 ++ drivers/net/mlx5/mlx5_txpp.c | 7

[dpdk-dev] [PATCH v2 04/17] net/mlx5: introduce shared UAR resource

This is preparation step before moving the Tx queue creation to the DevX approach. Some features require the shared UAR for Tx queues and scheduling completion queues, the patch manages the shared UAR. Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.c | 14 ++

[dpdk-dev] [PATCH v2 07/17] net/mlx5: create Tx queues with DevX

To provide the packet send schedule on mbuf timestamp the Tx queue must be attached to the same UAR as Clock Queue is. UAR is special hardware related resource mapped to the host memory and provides doorbell registers, the assigning UAR to the queue being created is provided via DevX API only. Sig

[dpdk-dev] [PATCH v2 05/17] net/mlx5: create clock queue for packet pacing

This patch creates the special completion queue providing reference completions to schedule packet send from other transmitting queues. Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- drivers/net/mlx5/Makefile| 1 + drivers/net/mlx5/linux/mlx5_os.c | 3 + drivers/net/m

[dpdk-dev] [PATCH v2 01/17] common/mlx5: update common part to support packet pacing

This patch prepares the common part of the mlx5 PMDs to support packet send scheduling on mbuf timestamps: - the DevX routine to query the packet pacing HCA capabilities - packet pacing Send Queue attributes support - the hardware related definitions Signed-off-by: Viacheslav Ovsiienko Ack

[dpdk-dev] [PATCH v2 02/17] net/mlx5: introduce send scheduling devargs

This patch introduces the new devargs: tx_pp - enables accurate packet send scheduling on mbuf timestamps in the PMD. On the device start if "rte_dynflag_timestamp" dynamic flag is registered and this devarg non-zero value is specified, the driver initializes all necessary internal infrast

[dpdk-dev] [PATCH v2 03/17] net/mlx5: fix UAR lock sharing for multiport devices

The master and representors might be created over the multiport Infiniband devices and the UAR resource allocated for sibling ports might belong to the same underlying Infiniband device. Hardware requires the write access to the UAR must be performed as atomic 64-bit write, on 32-bit systems this i

[dpdk-dev] [PATCH v2 00/17] net/mlx5: introduce accurate packet Tx scheduling

The accurate packet Tx scheduling on timestamps was introduced [1]. This patchset provides the feature implementation on mlx5 PMD side. [1] http://patches.dpdk.org/patch/73742/ Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad Viacheslav Ovsiienko (17): common/mlx5: update common par

Re: [dpdk-dev] [PATCH v3 2/3] net: replace htons with rte_cpu_to_be_16

> -Original Message- > From: Olivier Matz > Sent: Monday, July 13, 2020 5:39 PM > To: Fady Bader > Cc: dev@dpdk.org; Thomas Monjalon ; Tasnim Bashar > ; Tal Shnaiderman ; Yohad Tor > ; dmitry.kozl...@gmail.com; > harini.ramakrish...@microsoft.com; ocard...@microsoft.com; > pallavi.ka..

Re: [dpdk-dev] [PATCH 6/6] app/testpmd: enable empty polls in 5tswap

> -Original Message- > From: dev On Behalf Of Dharmik Thakkar > Sent: Wednesday, July 15, 2020 5:51 AM > To: Wenzhuo Lu ; Beilei Xing > ; Bernard Iremonger > Cc: dev@dpdk.org; nd ; Dharmik Thakkar > > Subject: [dpdk-dev] [PATCH 6/6] app/testpmd: enable empty polls in 5tswap > > Enable e

Re: [dpdk-dev] [PATCH v3 1/2] power: fix power management env detection

Tested-by:ma,Lihong Regards, Ma,lihong -Original Message- From: dev On Behalf Of Anatoly Burakov Sent: Tuesday, July 14, 2020 6:30 PM To: dev@dpdk.org Cc: Hunt, David ; Pattan, Reshma ; Richardson, Bruce Subject: [dpdk-dev] [PATCH v3 1/2] power: fix power management env detection Anyt

[dpdk-dev] [PATCH 4/7] common/mlx5: convert control path memory to unified malloc

This commit allocateis the control path objects memory from the unified malloc function. These objects are all used during the instances initialize, it will not affect the data path. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/common/mlx5/linux/mlx5_glue.c | 13 +++--- driver

[dpdk-dev] [PATCH 7/7] net/mlx5: convert Rx/Tx queue objects to unified malloc

This commit allocates the Rx/Tx queue objects from unified malloc function. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_rxq.c | 37 ++--- drivers/net/mlx5/mlx5_txq.c | 44 +--- 2 files change

[dpdk-dev] [PATCH 6/7] net/mlx5: convert configuration objects to unified malloc

This commit allocates the miscellaneous configuration objects from the unified malloc function. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_ethdev_os.c | 8 +--- drivers/net/mlx5/linux/mlx5_os.c| 26 +- drivers/net/mlx5/

[dpdk-dev] [PATCH 5/7] common/mlx5: convert data path objects to unified malloc

This commit allocates the data path object page and B-tree table memory from unified malloc function with explicit flag MLX5_MEM_RTE. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.c| 10 ++ drivers/common/mlx5/mlx5_common_mr.c | 31 +++

[dpdk-dev] [PATCH 3/7] net/mlx5: convert control path memory to unified malloc

This commit allocates the control path memory from unified malloc function. The objects be changed: 1. hlist; 2. rss key; 3. vlan vmwa; 4. indexed pool; 5. fdir objects; 6. meter profile; 7. flow counter pool; 8. hrxq and indirect table; 9. flow object cache resources; 10. temporary resources in

[dpdk-dev] [PATCH 0/7] net/mlx5: add sys_mem_en devarg

Currently, for MLX5 PMD, once millions of flows created, the memory consumption of the flows are also very huge. For the system with limited memory, it means the system need to reserve most of the memory as huge page memory to serve the flows in advance. And other normal applications will have no c

[dpdk-dev] [PATCH 2/7] net/mlx5: add allocate memory from system devarg

Currently, for MLX5 PMD, once millions of flows created, the memory consumption of the flows are also very huge. For the system with limited memory, it means the system need to reserve most of the memory as huge page memory to serve the flows in advance. And other normal applications will have no c

[dpdk-dev] [PATCH 1/7] common/mlx5: add mlx5 memory management functions

Add the internal mlx5 memory management functions: mlx5_malloc_mem_select(); mlx5_rellaocate(); mlx5_malloc(); mlx5_free(); User will be allowed to manage memory from system or from rte memory with the unified functions. In this case, for the system with limited memory which can not reserve lots

Re: [dpdk-dev] [PATCH v7 1/3] doc: add generic atomic deprecation section

Hi Honnappa, Thanks for your comments and suggestions. I Will update it in the next version. Hi John, I would greatly appreciate it if you kindly give me some feedback on this proposal. Thanks, Phil > Hi Phil, > Few comments. > > > > > Subject: [PATCH v7 1/3] doc: add generic atomic

[dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for rte_epoll_event

From: Yunjian Wang The "rev->epdata.event" assigned to "events.epdata.event" directly, which was wrong in case of epoll events. It should be set to the "evs.events". Fixes: 9efe9c6cdcac ("eal/linux: add epoll wrappers") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- lib/librte_eal/linux/

Re: [dpdk-dev] [PATCH] net/ice: fix tunnel type get error

> -Original Message- > From: Zhao1, Wei > Sent: Wednesday, July 15, 2020 10:08 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Lu, Nannan ; > Zhao1, Wei > Subject: [PATCH] net/ice: fix tunnel type get error > > When get tunnel type for ICE_NON_TUN, there need some upodate for gtp > related pct

Re: [dpdk-dev] [PATCH v3 00/10] bnxt patches

On Mon, Jul 13, 2020 at 2:47 AM Somnath Kotur wrote: > Minor enhancments added to the TF-ULP/Core layers > > Farah Smith (1): > net/bnxt: add changes to support 2 table scopes > > Jay Ding (2): > net/bnxt: implement TF Identifier search > net/bnxt: check index range in bulk get > > Kishore

[dpdk-dev] [PATCH] net/ice: fix tunnel type get error

When get tunnel type for ICE_NON_TUN, there need some upodate for gtp related pctype. Fixes: 418d2563d10b ("net/ice/base: get tunnel type for recipe") Signed-off-by: Wei Zhao --- drivers/net/ice/base/ice_switch.c | 4 ++-- drivers/net/ice/base/ice_switch.h | 1 + 2 files changed, 3 insertions(+

[dpdk-dev] [PATCH] net/ice: fix tunnel type get error

When get tunnel type for ICE_NON_TUN, there need some upodate for gtp realted pctype. Fixes: 418d2563d10b ("net/ice/base: get tunnel type for recipe") Signed-off-by: Wei Zhao --- drivers/net/ice/base/ice_switch.c | 4 ++-- drivers/net/ice/base/ice_switch.h | 1 + 2 files changed, 3 insertions(+

Re: [dpdk-dev] [DPDK] net/ice/base: adjust code order and cleanup coding style

Thank you, Ferruh! > -Original Message- > From: Yigit, Ferruh > Sent: Monday, July 13, 2020 21:55 > To: Guo, Junfeng ; Zhang, Qi Z > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [DPDK] net/ice/base: adjust code order and cleanup coding style > > On 7/13/2020 12:05 PM, Junfeng Guo wr

[dpdk-dev] [PATCH 20.11 v2] raw/ioat: add a flag to control copying handle parameters

Add a flag which controls whether rte_ioat_enqueue_copy and rte_ioat_completed_copies function should process handle parameters to improve the performance when handle parameters are not necessary to use. This is targeting 20.11 release. Signed-off-by: Cheng Jiang --- v2: * optimized the logic of

Re: [dpdk-dev] [PATCH] net/bnxt: fix a segfault during Tx

On Sun, Jul 12, 2020 at 10:23 PM Somnath Kotur wrote: > From: Ajit Khaparde > > When TRUFLOW is not enabled ulp_ctx is not allocated. > In non-vector Tx datapath we are accessing this invalid pointer > resulting in a segfault. Check if TRUFLOW is enabled before > accessing ulp_ctx to avoid this.

Re: [dpdk-dev] [PATCH] drivers/qat: fix lacking memzone lookup in compression pmd

Tested-by: Jiang, YuX -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Dybkowski, AdamX Sent: Monday, July 13, 2020 8:31 PM To: Kusztal, ArkadiuszX ; dev@dpdk.org Cc: akhil.go...@nxp.com; Trahe, Fiona ; Kusztal, ArkadiuszX Subject: Re: [dpdk-dev] [PATCH] drivers

Re: [dpdk-dev] [PATCH v2] app/procinfo: enhance port mempool and crypto info

Yes. Please create one series. Get BlueMail for Android On 15 Jul 2020, at 5:37 AM, Stephen Hemminger mailto:step...@networkplumber.org>> wrote: On Mon, 13 Jul 2020 03:49:30 + Hemant Agrawal wrote: -Original Message- From: Stephen Hemminger Sen

Re: [dpdk-dev] [PATCH v2] app/procinfo: enhance port mempool and crypto info

On Mon, 13 Jul 2020 03:49:30 + Hemant Agrawal wrote: > -Original Message- > From: Stephen Hemminger > Sent: Sunday, July 12, 2020 8:42 AM > To: Hemant Agrawal > Cc: dev@dpdk.org; maryam.tah...@intel.com; reshma.pat...@intel.com > Subject: Re: [dpdk-dev] [PATCH v2] app/procinfo: enh

[dpdk-dev] [PATCH] net/tap: avoid using SIGIO

SIGIO maybe used by application, instead choose another rt-signal. Linux allows any signal to be used for signal based IO. Search for an unused signal in the available rt-signal range. Add more error checking for fcntl and signal handling. Signed-off-by: Stephen Hemminger --- Resending original

[dpdk-dev] [PATCH 3/3] doc: add missing SPDX license tags

A few files in doc directory were missing license tag info. Signed-off-by: Stephen Hemminger --- doc/guides/custom.css| 1 + doc/guides/linux_gsg/nic_perf_intel_platform.rst | 3 +++ doc/guides/prog_guide/build-sdk-meson.rst| 3 +++ 3 files changed, 7 insertio

[dpdk-dev] [PATCH 0/3] Add missing SPDX license tags

Fix some recent gaps in SPDX license information. Stephen Hemminger (3): eal/windows: add missing SPDX license tag net/qede/base: add missing license information doc: add missing SPDX license tags doc/guides/custom.css| 1 + doc/guides/linux_gsg/nic_perf_intel_p

[dpdk-dev] [PATCH 2/3] net/qede/base: add missing license information

Add SPDX header that is the same as other files in the same qede/base directory. Signed-off-by: Stephen Hemminger --- drivers/net/qede/base/ecore_hsi_func_common.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/qede/base/ecore_hsi_func_common.h b/drivers/net/qede/base/eco

[dpdk-dev] [PATCH 1/3] eal/windows: add missing SPDX license tag

This file was added without license information. Add BSD SPDX license with copyright assigned to the original author (as was done for other files in Windows EAL). Signed-off-by: Stephen Hemminger --- lib/librte_eal/windows/eal_hugepages.c | 4 1 file changed, 4 insertions(+) diff --git a/l

Re: [dpdk-dev] [PATCH v5] devtools: add new SPDX license compliance checker

On Tue, 14 Jul 2020 16:21:01 -0700 Stephen Hemminger wrote: > Simple script to look for drivers and scripts that > are missing requires SPDX header. > > Signed-off-by: Stephen Hemminger Preprocessor Directives Because of the long delay in merging this tool new files have come in that are not

Re: [dpdk-dev] [PATCH v4] devtools: add new SPDX license compliance checker

On Fri, 12 Jun 2020 11:05:27 +0200 Gaëtan Rivet wrote: > On 24/02/20 13:01 -0800, Stephen Hemminger wrote: > > Simple script to look for drivers and scripts that > > are missing requires SPDX header. > > > > Update the contribution guidelines to indicate that SPDX license > > identfier is requir

[dpdk-dev] [PATCH v5] devtools: add new SPDX license compliance checker

Simple script to look for drivers and scripts that are missing requires SPDX header. Signed-off-by: Stephen Hemminger --- v5 - address review comments simplify the display logic scan doc and buildtools as well MAINTAINERS | 1 + devtools/check-spdx-tag.s

[dpdk-dev] [PATCH 5/6] app/testpmd: enable burst stats for noisy vnf mode

From: Phil Yang Add burst stats for noisy vnf mode. Fixes: 3c156061b938 ("app/testpmd: add noisy neighbour forwarding mode") Cc: sta...@dpdk.org Cc: jfreim...@redhat.com Signed-off-by: Dharmik Thakkar Signed-off-by: Phil Yang Reviewed-by: Honnappa Nagarahalli Reviewed-by: Ruifeng Wang ---

[dpdk-dev] [PATCH 1/6] app/testpmd: add record-core-cycles runtime config

Convert CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES to a runtime configuration. Signed-off-by: Dharmik Thakkar Tested-by: Phil Yang Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- app/test-pmd/5tswap.c | 16 +++--- app/test-pmd/cmdline.c| 46

[dpdk-dev] [PATCH 3/6] app/testpmd: add record-burst-stats runtime config

Convert CONFIG_RTE_TEST_PMD_RECORD_BURST_STATS to a runtime configuration. Signed-off-by: Dharmik Thakkar Tested-by: Phil Yang Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- app/test-pmd/5tswap.c | 8 ++- app/test-pmd/cmdline.c| 46 +++

[dpdk-dev] [PATCH 6/6] app/testpmd: enable empty polls in 5tswap

Enable empty polls in burst stats within 5tswap.c Signed-off-by: Dharmik Thakkar Reviewed-by: Honnappa Nagarahalli --- app/test-pmd/5tswap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/test-pmd/5tswap.c b/app/test-pmd/5tswap.c index d9026ce86556..3cf1692eaba8 10064

[dpdk-dev] [PATCH 4/6] doc: add record-burst-stats to testpmd funcs doc

Update documentation to include description of 'record-burst-stats' runtime configuration. Signed-off-by: Dharmik Thakkar Reviewed-by: Phil Yang Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- doc/guides/testpmd_app_ug/run_app.rst | 2 ++ doc/guides/testpmd_app_ug/testp

[dpdk-dev] [PATCH 2/6] doc: add record-core-cycles to testpmd funcs doc

Update documentation to include description of 'record-core-cycles' runtime configuration. Signed-off-by: Dharmik Thakkar Reviewed-by: Phil Yang Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli --- doc/guides/testpmd_app_ug/run_app.rst | 6 ++ doc/guides/testpmd_app_ug/t

[dpdk-dev] [PATCH 0/6] app/testpmd: add runtime config

Meson build system lacks support for CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES and CONFIG_RTE_TEST_PMD_RECORD_BURST_STATS configuration options. One solution is to add these options within meson_options.txt Since adding these as runtime config causes no performance impact, it makes sense to enable t

Re: [dpdk-dev] Retrieving lcore worker thread id

On Tue, 14 Jul 2020 18:59:59 + Honnappa Nagarahalli wrote: > > > > > > > > Hi. > > > > Hey, > > > > > In DPDK 19.11, the lcore_config struct of is made > > > private, and with it the possibility to look up the thread id of the > > > lcore worker threads disappears. > > > > > > One us

Re: [dpdk-dev] [PATCH] eal/interrupts: add function to allow interruptible epoll

Hi Stephen, Looks good overall, few nits inline. > -Original Message- > From: dev On Behalf Of Stephen Hemminger > Sent: Wednesday, July 24, 2019 12:21 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH] eal/interrupts: add function to allow > interruptibl

Re: [dpdk-dev] [PATCH] speed-capabilities: Added Speed Capabilitiestest case

Hi all, I just wanted to follow up on the status of the patch. I was wondering if there were plans to merge the patch before testpmd was updated with the speed_capa change. Thanks, Dan On Tue, Jun 30, 2020 at 3:59 PM Daniel Kirichok wrote: > Inline > > On Tue, Jun 30, 2020 at 3:27 AM Morten Br

Re: [dpdk-dev] Retrieving lcore worker thread id

> > > > Hi. > > Hey, > > > In DPDK 19.11, the lcore_config struct of is made > > private, and with it the possibility to look up the thread id of the > > lcore worker threads disappears. > > > > One use case is an application with a monitoring function (on some > > control plane thread), which

Re: [dpdk-dev] [PATCH v7 1/3] doc: add generic atomic deprecation section

Hi Phil, Few comments. > Subject: [PATCH v7 1/3] doc: add generic atomic deprecation section I think we should change this as follows: "doc: add optimizations using C11 atomic built-ins" > > Add deprecating the generic rte_atomic_xx APIs to C11 atomic built-ins guide > and examples. I

Re: [dpdk-dev] [PATCH v4] net/pcap: support snaplen option to truncate packet

On Tue, 14 Jul 2020 11:46:00 + "Pattan, Reshma" wrote: > > -Original Message- > > From: wangzk...@163.com On Behalf Of Zhike Wang > > + "[snaplen=default:0, meaning no > > truncation]'\n", > > From pdump changes, below are couple of comments. > > Bit more descri

Re: [dpdk-dev] [PATCH v4 3/3] examples/ipsec-secgw: Remove the re-implementation of inet_pton

> inet_pton4 and inet_pton6 was reimplemented. Replace implementation of > inet_pton4 and inet_pton6 with libc inet_pton function > > Bugzilla ID: 365 > Fixes: 0d547ed03717 ("examples/ipsec-secgw: support configuration file") > Cc: roy.fan.zh...@intel.com > > Reported-by: David Marchand > Signed

Re: [dpdk-dev] [dpdk-stable] [PATCH] drivers/net/i40e: fixed misplaced arguments

On 7/14/2020 4:58 PM, Muhammad Bilal wrote: > Here I have corrected a misplaced argument of i40e_aq_get_phy_register() > This was also evident after seeing the datatype of its arguments. > > Fixes: 98e60c0d43f1 ("net/i40e: add module EEPROM callbacks for i40e") > Cc: zijie@6wind.com > > Bugzi

Re: [dpdk-dev] [PATCH v4] net/pcap: support snaplen option to truncate packet

On 7/14/2020 9:26 AM, Zhike Wang wrote: > Introduced "snaplen=" option. It is convenient to truncate > large packets to only capture necessary headers. > > Signed-off-by: Zhike Wang <...> > diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c > index 668cbd1..0d2a4b3 1

Re: [dpdk-dev] DPDK PDUMP Issue

On Tue, 14 Jul 2020 08:40:55 + Dikshant Chitkara wrote: > Hi Team, > > We are facing an issue w.r.t to using DPDK PDUMP utility and want to check if > you can help us in this regard. > > This issue is specific to DPDK 19.05 version or may be newer versions and > was not found on DPDK 18.

[dpdk-dev] Retrieving lcore worker thread id

Hi. In DPDK 19.11, the lcore_config struct of is made private, and with it the possibility to look up the thread id of the lcore worker threads disappears. One use case is an application with a monitoring function (on some control plane thread), which uses the thread ids to make sure the work

[dpdk-dev] [PATCH] drivers/net/i40e: fixed misplaced arguments

Here I have corrected a misplaced argument of i40e_aq_get_phy_register() This was also evident after seeing the datatype of its arguments. Fixes: 98e60c0d43f1 ("net/i40e: add module EEPROM callbacks for i40e") Cc: zijie@6wind.com Bugzilla ID: 506 Signed-off-by: Muhammad Bilal --- drivers/ne

[dpdk-dev] [v4 2/3] examples/vm_power_manager: Allowing power managing of idle cores

This change is required to allow the branch ratio algorithm to power manage cores with no workload running on them. This is useful both when idle cores don't use C-states and for a number of hyperthreading scenarios. Signed-off-by: Rory Sexton Reviewed-by: David Hunt --- v4: no changes --- exa

[dpdk-dev] [v4 3/3] doc: update vm_power_manager cmdline options in doc

Updating the vm_power_manager docs to reflect changes made in previous patches in set. Signed-off-by: Rory Sexton Reviewed-by: David Hunt --- v4: no changes --- doc/guides/sample_app_ug/vm_power_management.rst | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a

[dpdk-dev] [v4 1/3] examples/vm_power_manager: Make branch ratio threshold per core

This modification allows for the branch ratio threshold to be set per core rather than system wide. This gives greater flexibility to the branch ration monitoring allowing it to manage different workloads with different characteristics on the same system. Signed-off-by: Rory Sexton Reviewed-by: D

Re: [dpdk-dev] [v3 3/3] doc: update vm_power_manager cmdline options in doc

Replacing patchset with v4 to add an upper limit check to branch ratio value. Rgds, Rory

Re: [dpdk-dev] [PATCH 0/3] fixes for af_packet driver

On 7/6/2020 1:26 PM, wangyunjian wrote: > From: Yunjian Wang > > This series include three fixes patches for af_packet driver. > > Yunjian Wang (3): > net/af_packet: fix check of file descriptors > net/af_packet: fix mem leak on init failure > net/af_packet: fix wrong munmap on init failur

[dpdk-dev] DPDK PDUMP Issue

Hi Team, We are facing an issue w.r.t to using DPDK PDUMP utility and want to check if you can help us in this regard. This issue is specific to DPDK 19.05 version or may be newer versions and was not found on DPDK 18.08 version. The issue is that when we built DPDK in shared library mode and

[dpdk-dev] Qos issue with new DPDK 20.02 and i40e driver

Hi i40e driver experts, We are **not** a typical user of i40e dpdk driver, we are using tx Qos configuration (dcb) with strict latency tx queues. The feature stops working with a new firmware 7.0.x. We are using DDP (another thing that is not standard) to solve the drop rate issue. dpdk 19.05 - wo

Re: [dpdk-dev] [PATCH v6 0/8] fib: implement AVX512 vector lookup

On Tue, 14 Jul 2020 08:31:32 +0100 "Kinsella, Ray" wrote: > On 13/07/2020 23:19, Stephen Hemminger wrote: > > On Mon, 13 Jul 2020 12:11:19 +0100 > > Vladimir Medvedkin wrote: > > > >> This patch series implements vectorized lookup using AVX512 for > >> ipv4 dir24_8 and ipv6 trie algorithms. >

[dpdk-dev] [PATCH v1 7/8] net/mlx5: refactor multi process communication

1. The shared data communication between the primary and the secondary processes is implemented using Linux API. Move the Linux API code under linux directory (file linux/mlx5_os.c). 2. File net/mlx5/mlx5_mp.c handles requests to the primary and secondary processes (e.g. start_rxtx, stop_rxtx). It

[dpdk-dev] [PATCH v1 8/8] mlx5: remove inclusion of verbs header files

Several source files include verbs header files as in (1). These source files will not compile under non-Linux operating systems. This commit removes this inclusion in two cases: Case 1: There is no usage of ibv_* or mlx5dv_* symbols in the source file so the inclusion in (1) can be safely removed

[dpdk-dev] [PATCH v1 6/8] net/mlx5: header file cleanup

The cleanup refers to header file mlx5.h. 1. Remove unused prototypes. 2. Move prototypes under their correct title. 3. Change functions to static and remove their prototye from the header file. Signed-off-by: Ophir Munk Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_ethdev_os.c | 102 ++

[dpdk-dev] [PATCH v1 5/8] net/mlx5: eliminate dependency on Linux in shared header

This commit eliminates Linux dependencies in shared file mlx5.h. 1. All functions using 'struct ifreq' are moved to file linux/mlx5_ethdev_os.c such that this struct can be removed from mlx5.h. 2. Function mlx5_set_flags() that uses Linux flags (e.g. IFF_UP) is changed to static and its prototype

[dpdk-dev] [PATCH v1 3/8] net/mlx5: refactor Linux MAC operations

Move OS specific MAC operations add, remove, modify VF into file linux/mlx5_os.c. Remove unused function mlx5_get_mac(). Signed-off-by: Ophir Munk Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_os.c | 97 drivers/net/mlx5/mlx5.h | 7 ++-

[dpdk-dev] [PATCH v1 4/8] linux/mlx5: add setters for promiscuous and all-multi

This commit adds Linux implementation of routines mlx5_os_set_promisc() and mlx5_os_set_promisc(). The routines call netlink APIs. Signed-off-by: Ophir Munk Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_os.c | 40 drivers/net/mlx5/mlx5.h

[dpdk-dev] [PATCH v1 2/8] net/mlx5: replace Linux specific calls with rte API

The following Linux calls are replaced by their matching rte APIs. mmap ==> rte_mem_map() munmap == >rte_mem_unmap() sysconf(_SC_PAGESIZE) ==> rte_mem_page_size() Signed-off-by: Ophir Munk Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 8 +++- drivers/common/mlx5/mlx5_pr

[dpdk-dev] [PATCH v1 1/8] net/mlx5: move flow prio discovery and adjust under verbs

Function calls mlx5_flow_adjust_priority() and mlx5_flow_discover_priorities() are verbs based. Move them from file mlx5_flow.c to file mlx5_flow_verbs.c Signed-off-by: Ophir Munk Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.h| 1 - drivers/net/mlx5/mlx5_flow.c | 112

[dpdk-dev] [PATCH v1 0/8] mlx5 PMD multi OS support - part #3

This patch series is part of preparing mlx5 PMD to compile and run under multiple OSs. Part #3 v1: Initial version Ophir Munk (8): net/mlx5: move flow prio discovery and adjust under verbs net/mlx5: replace Linux specific calls with rte API net/mlx5: refactor Linux MAC operations linux/ml

[dpdk-dev] [PATCH v3 2/2] raw/ifpga/base: fix NIOS SPI initial

From: Tianfei Zhang Add fecmode setting on NIOS SPI primary initialization. this SPI is shared by NIOS core inside FPGA, NIOS will use this SPI primary to do some one-time initialization after power up, and then release the control to DPDK. Fix the timeout initialization for polling the NIOS_INI

[dpdk-dev] [PATCH v3 1/2] raw/ifpga/base: fix spi transaction issue

From: Tianfei Zhang 0x4a means idle status on physical layer. when encounter 0x4a on raw data, it need insert a ESCAPE character for indication. Fixes: 96ebfcf8 ("raw/ifpga/base: add SPI and MAX10 device driver") Cc: sta...@dpdk.org Signed-off-by: Tianfei Zhang --- v3: resend with threaded op

Re: [dpdk-dev] Retrieving lcore worker thread id

> -Original Message- > From: dev On Behalf Of Mattias Rönnblom > Sent: Tuesday, July 14, 2020 1:04 PM > To: dpdk-dev > Cc: Tomasz Piatkowski > Subject: [dpdk-dev] Retrieving lcore worker thread id > > Hi. Hey, > In DPDK 19.11, the lcore_config struct of is made private, > and with it

Re: [dpdk-dev] [PATCH v2] net/pcap: support snaplen option to truncate packet

Thanks for review. Sent v4. Br, Zhike Wang JDCloud, Product Development, IaaS   Mobile／+86 13466719566 E- mail／wangzh...@jd.com Address／5F Building A,North-Star Century Center,8 Beichen West Street,

[dpdk-dev] [PATCH] metrics: fix installation of metrics header

If Jansson was found, the headers list is overwritten when including rte_metrics_telemetry.h, which prevents rte_metrics.h from being installed. This is now fixed to add to headers, rather than overwrite, to allow both headers be installed when Jansson is present. Fixes: c5b7197f662e ("telemetry:

[dpdk-dev] [PATCH v4] net/pcap: support snaplen option to truncate packet

Introduced "snaplen=" option. It is convenient to truncate large packets to only capture necessary headers. Signed-off-by: Zhike Wang --- app/pdump/main.c | 32 ++- doc/guides/rel_notes/release_20_08.rst | 4 doc/guides/tools/pdump.rst

Re: [dpdk-dev] [PATCH] net/bonding: fix error code when creating bonded device

On 7/14/2020 9:19 AM, Wei Hu (Xavier) wrote: > Because the return value of rte_vdev_init() has multiple non-zero values, > when rte_vdev_init() return non-zero in the rte_eth_bond_create() function, > it should return the actual error code rather than -ENOMEM. > > Fixes: 68451eb6698c ("net/bonding

Re: [dpdk-dev] [PATCH] net/dpaa: announce extended definition of port_id in API 'rte_pmd_dpaa_set_tx_loopback'

Acked-by: Hemant Agrawal -Original Message- From: dev On Behalf Of Ferruh Yigit Sent: Tuesday, July 14, 2020 5:07 PM To: Sachin Saxena (OSS) ; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] net/dpaa: announce extended definition of port_id in API 'rte_pmd_dpaa_set_tx_loopback' On 7/14/20

Re: [dpdk-dev] [PATCH v4] net/pcap: support snaplen option to truncate packet

> -Original Message- > From: wangzk...@163.com On Behalf Of Zhike Wang > + "[snaplen=default:0, meaning no > truncation]'\n", >From pdump changes, below are couple of comments. Bit more descriptive would be nice, how about, disables truncation of captured packets

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix incorrect output format in flow query

On 7/14/2020 11:06 AM, Phil Yang wrote: >> -Original Message- >> From: dev On Behalf Of Chenxu Di >> Sent: Tuesday, July 14, 2020 9:37 AM >> To: dev@dpdk.org >> Cc: beilei.x...@intel.com; david.march...@redhat.com; >> wenzhuo...@intel.com; Chenxu Di >> Subject: [dpdk-dev] [PATCH v2] app/t

Re: [dpdk-dev] [PATCH] mempool: fix memory allocation in memzones during retry.

Thanks for review. Sent out v2. Br, Zhike Wang JDCloud, Product Development, IaaS   Mobile／+86 13466719566 E- mail／wangzh...@jd.com Address／5F Building A,North-Star Century Center,8 Beichen West Str

Re: [dpdk-dev] [PATCH] net/dpaa: announce extended definition of port_id in API 'rte_pmd_dpaa_set_tx_loopback'

On 7/14/2020 12:32 PM, Sachin Saxena (OSS) wrote: > From: Sachin Saxena > > Signed-off-by: Sachin Saxena > --- > doc/guides/rel_notes/deprecation.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > ind

  1   2   >