> -----Original Message-----
> From: wangzk...@163.com <wangzk...@163.com> On Behalf Of Zhike Wang
> +                     "[snaplen=<snap length>default:0, meaning no
> truncation]'\n",

>From pdump changes, below are couple of comments.

Bit more descriptive would be nice,  how about, disables truncation of captured 
packets.?

> +     if (cnt1 == 1) {
> +             v.min = 1;

Min should be 0. User still can pass 0 value.

> +             v.max = UINT16_MAX;

Instead of  allowing big max number, isn't it good to have some restricted max 
value?

Thanks,
Reshma

Reply via email to