On 7/14/2020 4:58 PM, Muhammad Bilal wrote:
> Here I have corrected a misplaced argument of i40e_aq_get_phy_register()
> This was also evident after seeing the datatype of its arguments.
>
> Fixes: 98e60c0d43f1 ("net/i40e: add module EEPROM callbacks for i40e")
> Cc: [email protected]
>
> Bugzilla ID: 506
> Signed-off-by: Muhammad Bilal <[email protected]>
> ---
> drivers/net/i40e/i40e_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 970a31cb2..5fdfadf7b 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -12093,7 +12093,7 @@ static int i40e_get_module_eeprom(struct rte_eth_dev
> *dev,
> }
> status = i40e_aq_get_phy_register(hw,
> I40E_AQ_PHY_REG_ACCESS_EXTERNAL_MODULE,
> - addr, offset, 1, &value, NULL);
> + addr, 1, offset, &value, NULL);
> if (status)
> return -EIO;
> data[i] = (uint8_t)value;
>
Hi Muhammad,
This seems already fixed [1], can you please double check in the 'v20.08-rc1'?
[1]
https://git.dpdk.org/dpdk/commit/?id=2fc1d6da882563ab80786d69b6d7c9d0e4ce860a
https://patches.dpdk.org/patch/72827/
