Re: [dpdk-dev] [PATCH] net/virtio: include host features supported in guest

2020-05-15 Thread Gowrishankar Muthukrishnan
Posted additional testing info with and without this patch in : https://patchwork.ozlabs.org/project/openvswitch/patch/0c4c167ad644d3dda51b992e51ec1c27b8492457.1589605823.git.gmuth...@redhat.com/ Thanks, Gowrishankar On Fri, May 15, 2020 at 10:05 PM Gowrishankar Muthukrishnan < gmuth...@redhat.co

[dpdk-dev] [PATCH v2] doc: update bnxt guide

2020-05-15 Thread Ajit Khaparde
- Update list of supported adapters. - Update list of supported features. - Add some details to describe the features. - Remove obsolete limitations. - Fix and update links. Signed-off-by: JP Lee Signed-off-by: Ajit Khaparde Acked-by: Kovacevic, Marko --- v1->v2: Some lines

[dpdk-dev] [PATCH v4] Test/crypto: check valid test_stats before running test

2020-05-15 Thread Apeksha Gupta
Test_stats is an optional cryptodev op and if it is not defined by the PMD, it should not run the test cases for it. Signed-off-by: Apeksha Gupta --- app/test/test_cryptodev.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/te

[dpdk-dev] [PATCH v1 6/9] net/bnxt: fix to alloc PF info structure

2020-05-15 Thread Ajit Khaparde
Fixes: 804e746c7b73 ("net/bnxt: add hardware resource manager init code") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt.h | 9 +- drivers/net/bnxt/bnxt_cpr.c | 20 ++--- drivers/net/bnxt/bnxt_ethdev

[dpdk-dev] [PATCH v1 7/9] net/bnxt: fix to use RSS config from eth dev struct

2020-05-15 Thread Ajit Khaparde
There is no need to maintain local copy. This helps reduce the size of the bnxt structure. Fixes: fcc0aa1edc10 ("net/bnxt: add RSS hash configuration") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde Reviewed-by: Kalesh AP --- drivers/net/bnxt/bnxt.h| 1 - drivers/net/bnxt/bnxt_ethdev

[dpdk-dev] [PATCH v1 8/9] net/bnxt: fix to remove unneeded structure variable

2020-05-15 Thread Ajit Khaparde
From: Kalesh AP We are maintaining MAC address twice which is unnecessary. This patch removes the copy which helps reduce size of bnxt structure. Fixes: b7778e8a1c00 ("net/bnxt: refactor to properly allocate resources for PF/VF") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Signed-off-by: Aji

[dpdk-dev] [PATCH v1 9/9] net/bnxt: fix to allocate bnxt ulp context

2020-05-15 Thread Ajit Khaparde
From: Mike Baucom Fix to allocate bnxt ulp context when TRUFLOW is enabled. This patch reduces the size of struct bnxt. Fixes: 313ac35ac701 ("net/bnxt: support ULP session manager init") Signed-off-by: Mike Baucom Reviewed-by: Venkat Duvvuru Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/b

[dpdk-dev] [PATCH v1 3/9] net/bnxt: fix to alloc COS queue info dynamically

2020-05-15 Thread Ajit Khaparde
Fixes: 698aa7e95325 ("net/bnxt: add code to determine the Tx COS queue") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt.h| 4 ++-- drivers/net/bnxt/bnxt_ethdev.c | 32 2 fi

[dpdk-dev] [PATCH v1 4/9] net/bnxt: fix to allocate flow stat related structs

2020-05-15 Thread Ajit Khaparde
Consolidate flow stat related structs for performance improvement. The intention of this patch is to reduce the size struct bnxt which had grown because of recent changes and was impacting performance. Fixes: 02a95625fe9c ("net/bnxt: add flow stats in extended stats") Signed-off-by: Ajit Khaparde

[dpdk-dev] [PATCH v1 2/9] net/bnxt: fix to alloc LED config info

2020-05-15 Thread Ajit Khaparde
Dynamically allocate bnxt_led_cfg. This helps reduces memory footprint of struct bnxt. Fixes: bb81e07323b ("net/bnxt: support LED on/off") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt.h| 4 ++-- drivers

[dpdk-dev] [PATCH v1 1/9] net/bnxt: fix error log for command timeout

2020-05-15 Thread Ajit Khaparde
Log the command sequence number to aid debug in case of a FW command timeout. Fixes: 804e746c7b73 ("net/bnxt: add hardware resource manager init code") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde Reviewed-by: Somnath Kotur Reviewed-by: Kalesh AP --- drivers/net/bnxt/bnxt_hwrm.c | 5 +++--

[dpdk-dev] [PATCH v1 0/9] bug fixes for bnxt PMD

2020-05-15 Thread Ajit Khaparde
Patchset with fixes. The patch [1/9] enhances the log message in case of a FW command timeout. The rest of the patches address a perf regression. Recent commits caused a regression in performance because bnxt structure became too big and noticed in rc2. Most of the patches reduce the memory footpr

[dpdk-dev] [PATCH v1 5/9] net/bnxt: fix to alloc link info struct

2020-05-15 Thread Ajit Khaparde
Dynamically alloc link info structure. Fixes: 1d0704f4d793 ("net/bnxt: add device configure operation") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt.h| 2 +- drivers/net/bnxt/bnxt_ethdev.c | 65

Re: [dpdk-dev] [PATCH v2 3/5] doc: add cycles per packet in testpmd user guide

2020-05-15 Thread Dharmik Thakkar
Hi Ferruh, > On May 15, 2020, at 7:15 AM, Ferruh Yigit wrote: > > On 5/8/2020 11:38 PM, Dharmik Thakkar wrote: >> Update documentation for 'show fwd' testpmd runtime function to show >> CPU cycles/packet example. >> >> Signed-off-by: Dharmik Thakkar >> Reviewed-by: Honnappa Nagarahalli >> Rev

Re: [dpdk-dev] [PATCH] hash: fix gcc 10 maybe-uninitialized warning

2020-05-15 Thread Wang, Yipeng1
> -Original Message- > From: Kevin Traynor > Sent: Friday, May 15, 2020 12:18 PM > To: Wang, Yipeng1 ; dev@dpdk.org; Gobriel, > Sameh ; Richardson, Bruce > > Cc: honnappa.nagaraha...@arm.com; Yigit, Ferruh ; > david.march...@redhat.com; sta...@dpdk.org > Subject: Re: [PATCH] hash: fix gcc

Re: [dpdk-dev] [PATCH v2] eal: fix warnings on Windows

2020-05-15 Thread Dmitry Kozlyuk
On Thu, 14 May 2020 13:39:45 -0700 Pallavi Kadam wrote: > This patch fixes bunch of warnings when compiling on Windows > such as the use of an unsafe string function (strerror), > [-Wunused-const-variable] in getopt.c and > [-Wunused-variable], [-Wunused-function] in eal_common_options.c > > v2

Re: [dpdk-dev] [PATCH] hash: fix gcc 10 maybe-uninitialized warning

2020-05-15 Thread Kevin Traynor
On 15/05/2020 20:06, Wang, Yipeng1 wrote: >> -Original Message- >> From: Kevin Traynor >> Sent: Friday, May 15, 2020 7:28 AM >> To: dev@dpdk.org; Wang, Yipeng1 ; Gobriel, >> Sameh ; Richardson, Bruce >> >> Cc: honnappa.nagaraha...@arm.com; Yigit, Ferruh ; >> david.march...@redhat.com; Kev

Re: [dpdk-dev] [PATCH] hash: fix gcc 10 maybe-uninitialized warning

2020-05-15 Thread Wang, Yipeng1
> -Original Message- > From: Kevin Traynor > Sent: Friday, May 15, 2020 7:28 AM > To: dev@dpdk.org; Wang, Yipeng1 ; Gobriel, > Sameh ; Richardson, Bruce > > Cc: honnappa.nagaraha...@arm.com; Yigit, Ferruh ; > david.march...@redhat.com; Kevin Traynor ; > sta...@dpdk.org > Subject: [PATCH]

Re: [dpdk-dev] [PATCH] crypto/qat: support DOCSIS AES-256

2020-05-15 Thread Akhil Goyal
> > Add doc updates for QAT DOCSIS AES-256 support > > Fixes: 2aab3ff3d8cf ("crypto/qat: support DOCSIS AES-256") > Cc: mairtin.oloings...@intel.com > > Signed-off-by: Mairtin o Loingsigh > --- Title and description updated as doc: fix missing release notes for QAT Add release note

Re: [dpdk-dev] [PATCH] drivers/crypto: fix gcc 10 no-common errors

2020-05-15 Thread Akhil Goyal
> > Tidy solution. > Thanks. > > Acked-by: Ray Kinsella Applied to dpdk-next-crypto

Re: [dpdk-dev] [PATCH] test/crypto: remove tests for unsupported descriptors

2020-05-15 Thread Akhil Goyal
> > Hi Anoob. > > Thanks for this longer explanation. > I think can remove the test as intended. > > Acked-by: Adam Dybkowski > Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-15 Thread Nithin Dabilpuram
On Fri, May 15, 2020 at 06:52:23PM +0200, Thomas Monjalon wrote: > 15/05/2020 18:26, Jerin Jacob: > > On Fri, May 15, 2020 at 8:40 PM Thomas Monjalon wrote: > > > 15/05/2020 15:44, Nithin Dabilpuram: > > > > On Fri, May 15, 2020 at 03:12:59PM +0200, Thomas Monjalon wrote: > > > > > 15/05/2020 12:0

Re: [dpdk-dev] [PATCH v3] Test/crypto: check valid test_stats before running test

2020-05-15 Thread Akhil Goyal
Hi Konstantin, > > > Test_stats is an optional cryptodev op and if it is not defined by the > > PMD, it should not run the test cases for it. > > > > Signed-off-by: Apeksha Gupta > > --- > > app/test/test_cryptodev.c | 5 - > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --gi

Re: [dpdk-dev] [PATCH] crypto/virtio: add OOP_LB_IN_LB_OUT feature flag

2020-05-15 Thread Akhil Goyal
Hi Jay, > > Since it will check the feature mask before running out-of-place > test cases and the virtio-crypto device supports OOP_LB_IN_LB_OUT mode. > Is this feature already supported in the PMD and this patch is a fix to the original patch. If that is the case, title should be Crypto/virti

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-15 Thread Jerin Jacob
On Fri, May 15, 2020 at 10:22 PM Thomas Monjalon wrote: > > 15/05/2020 18:26, Jerin Jacob: > > On Fri, May 15, 2020 at 8:40 PM Thomas Monjalon wrote: > > > 15/05/2020 15:44, Nithin Dabilpuram: > > > > On Fri, May 15, 2020 at 03:12:59PM +0200, Thomas Monjalon wrote: > > > > > 15/05/2020 12:08, Nit

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-15 Thread Thomas Monjalon
15/05/2020 18:26, Jerin Jacob: > On Fri, May 15, 2020 at 8:40 PM Thomas Monjalon wrote: > > 15/05/2020 15:44, Nithin Dabilpuram: > > > On Fri, May 15, 2020 at 03:12:59PM +0200, Thomas Monjalon wrote: > > > > 15/05/2020 12:08, Nithin Dabilpuram: > > > > > On Thu, May 14, 2020 at 10:29:31PM +0200, O

[dpdk-dev] [PATCH v2] removing typing error of word 'through' in multiple places

2020-05-15 Thread Muhammad Bilal
Removed the typing error in doc/guides/eventdevs/index.rst, drivers/net/mlx5/mlx5.c and in lib/librte_vhost/rte_vhost.h Cc: dev@dpdk.org Cc: sta...@dpdk.org Cc: jer...@marvell.com Cc: ma...@mellanox.com Cc: shah...@mellanox.com Cc: maxime.coque...@redhat.com Cc: xiaolong...@intel.com Signed-off-by

Re: [dpdk-dev] [PATCH] net/virtio: include host features supported in guest

2020-05-15 Thread Gowrishankar Muthukrishnan
On Thu, May 14, 2020 at 5:48 PM Maxime Coquelin wrote: > Hi, > > On 5/14/20 1:56 PM, Gowrishankar Muthukrishnan wrote: > > Virtio pmd driver can not benefit from tso and csum offload > > as they are not included in negotiation check with host. Add > > them in virtio dev init and let negotiation d

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-15 Thread Jerin Jacob
On Fri, May 15, 2020 at 8:40 PM Thomas Monjalon wrote: > > 15/05/2020 15:44, Nithin Dabilpuram: > > On Fri, May 15, 2020 at 03:12:59PM +0200, Thomas Monjalon wrote: > > > 15/05/2020 12:08, Nithin Dabilpuram: > > > > On Thu, May 14, 2020 at 10:29:31PM +0200, Olivier Matz wrote: > > > > > I don't se

Re: [dpdk-dev] DPDK Release Status Meeting 14/05/2020

2020-05-15 Thread Thomas Monjalon
Hi, Please let's discuss the dates for the next release cycle. > * v20.08 proposal dates, please comment: > * Proposal/V1: Tuesday, 16 June 2020 > * Integration/Merge/RC1:Tuesday, 14 July 2020 > * Release: Friday, 7 August 2020 I prefer a target at the ver

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-15 Thread Thomas Monjalon
15/05/2020 15:44, Nithin Dabilpuram: > On Fri, May 15, 2020 at 03:12:59PM +0200, Thomas Monjalon wrote: > > 15/05/2020 12:08, Nithin Dabilpuram: > > > On Thu, May 14, 2020 at 10:29:31PM +0200, Olivier Matz wrote: > > > > I don't see any better approach than having a mbuf flag. However, I'm > > > >

Re: [dpdk-dev] [PATCH v4] meter: provide experimental alias of API for old apps

2020-05-15 Thread Ray Kinsella
On 15/05/2020 14:31, Thomas Monjalon wrote: > 14/05/2020 18:11, Ferruh Yigit: >> On v20.02 some meter APIs have been matured and symbols moved from >> EXPERIMENTAL to DPDK_20.0.1 block. >> >> This can break the applications that were using these mentioned APIs on >> v19.11. Although there is no

[dpdk-dev] [PATCH v6] abi: provide experimental alias of API for old apps

2020-05-15 Thread Ray Kinsella
From: Ferruh Yigit On v20.02 some APIs matured and symbols moved from EXPERIMENTAL to DPDK_20.0.1 block. This had the affect of breaking the applications that were using these APIs on v19.11. Although there is no modification of the APIs and the action is positive and matures the APIs, the affec

Re: [dpdk-dev] [PATCH v4] meter: provide experimental alias of API for old apps

2020-05-15 Thread Ray Kinsella
On 15/05/2020 14:31, Thomas Monjalon wrote: > 14/05/2020 18:11, Ferruh Yigit: >> On v20.02 some meter APIs have been matured and symbols moved from >> EXPERIMENTAL to DPDK_20.0.1 block. >> >> This can break the applications that were using these mentioned APIs on >> v19.11. Although there is no

[dpdk-dev] [PATCH v5] abi: provide experimental alias of API for old apps

2020-05-15 Thread Ray Kinsella
From: Ferruh Yigit On v20.02 some APIs matured and symbols moved from EXPERIMENTAL to DPDK_20.0.1 block. This had the affect of breaking the applications that were using these APIs on v19.11. Although there is no modification of the APIs and the action is positive and matures the APIs, the affec

Re: [dpdk-dev] [PATCH] event/octeontx: fix memory corruption

2020-05-15 Thread Jerin Jacob
On Fri, May 15, 2020 at 4:51 PM Harman Kalra wrote: > > Since PMD enqueues a single event at a time, fixing the issue by > passing 1 rather than nb_events to avoid any out of bound access as > reported by coverity. > > Coverity issue: 358447 > Fixes: 56a96aa42464 ("event/octeontx: add framework fo

Re: [dpdk-dev] DPDK Release Status Meeting 14/05/2020

2020-05-15 Thread Kevin Traynor
On 14/05/2020 12:17, Ferruh Yigit wrote: > On 5/14/2020 12:13 PM, Ferruh Yigit wrote: >> Minutes 14 May 2020 >> --- > > <...> > >> * gcc10 >> * Akhil's fix for crypto looks good, can replace temporary solution >> * Gavin has patch for mbuf, but this stage can be late/ris

[dpdk-dev] [PATCH] hash: fix gcc 10 maybe-uninitialized warning

2020-05-15 Thread Kevin Traynor
gcc 10.1.1 reports a warning for the ext_bkt_id variable: ../lib/librte_hash/rte_cuckoo_hash.c: In function ‘__rte_hash_add_key_with_hash’: ../lib/librte_hash/rte_cuckoo_hash.c:1104:29: warning: ‘ext_bkt_id’ may be used uninitialized in this function [-Wmaybe-uninitialized] 1104 | (h->buckets_ex

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-15 Thread Nithin Dabilpuram
On Fri, May 15, 2020 at 10:30:30AM +, Ananyev, Konstantin wrote: > > > On Thu, May 14, 2020 at 10:29:31PM +0200, Olivier Matz wrote: > > > Hi Nithin, > > > > > > On Tue, May 05, 2020 at 11:49:20AM +0530, Nithin Dabilpuram wrote: > > > > On Mon, May 04, 2020 at 02:27:35PM +0200, Olivier Matz wr

Re: [dpdk-dev] [PATCH] lib/librte_net: fix bug for checksum calculating

2020-05-15 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of guohongzhi > Sent: Friday, May 15, 2020 3:09 PM > > 1.rte_ipv4_cksum will return invalid checksum value like > 0x.(rfc1624) > 2.__rte_raw_cksum should consider Big Endian. > 3.checksum 0x is invalid for udp, but valid for tcp.(rfc768)

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-15 Thread Nithin Dabilpuram
On Fri, May 15, 2020 at 03:12:59PM +0200, Thomas Monjalon wrote: > 15/05/2020 12:08, Nithin Dabilpuram: > > On Thu, May 14, 2020 at 10:29:31PM +0200, Olivier Matz wrote: > > > I don't see any better approach than having a mbuf flag. However, I'm > > > still not fully convinced that a dynamic flag w

[dpdk-dev] Red Hat DPDK roadmap for v20.08

2020-05-15 Thread Maxime Coquelin
General: - Add API to register external threads Vhost-user library: --- - Advertise REPLY_ACK protocol feature unconditionally * Previously depending on RTE_VHOST_USER_IOMMU_SUPPORT registration flag * REPLY_ACK is necessary to ensure proper Vhost-user master/slave

Re: [dpdk-dev] [PATCH v4] meter: provide experimental alias of API for old apps

2020-05-15 Thread Thomas Monjalon
14/05/2020 18:11, Ferruh Yigit: > On v20.02 some meter APIs have been matured and symbols moved from > EXPERIMENTAL to DPDK_20.0.1 block. > > This can break the applications that were using these mentioned APIs on > v19.11. Although there is no modification on the APIs and the action is > positive

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-15 Thread Thomas Monjalon
15/05/2020 12:08, Nithin Dabilpuram: > On Thu, May 14, 2020 at 10:29:31PM +0200, Olivier Matz wrote: > > I don't see any better approach than having a mbuf flag. However, I'm > > still not fully convinced that a dynamic flag won't do the job. Taking > > 3 additional flags (among 18 remaing) for thi

[dpdk-dev] [PATCH] lib/librte_net: fix bug for checksum calculating

2020-05-15 Thread guohongzhi
1.rte_ipv4_cksum will return invalid checksum value like 0x.(rfc1624) 2.__rte_raw_cksum should consider Big Endian. 3.checksum 0x is invalid for udp, but valid for tcp.(rfc768) Signed-off-by: guohongzhi --- lib/librte_net/rte_ip.h | 15 ++- 1 file changed, 10 insertions(+), 5

Re: [dpdk-dev] [PATCH v3 1/2] net/qede: fix assignment of Rx/Tx handlers

2020-05-15 Thread Jerin Jacob
On Fri, May 15, 2020 at 12:05 PM Rasesh Mody wrote: > > Fix to assign dummy Rx/Tx handlers in dev_stop. > For MTU set, assignment of the appropriate Rx/Tx handlers will be > handled by dev_start/dev_stop. > > Fixes: 81f8804992c9 ("net/qede: enhance Rx CPU utilization") > Fixes: 8de0c4201926 ("net/

Re: [dpdk-dev] [PATCH v2 1/5] app/testpmd: print clock with CPU cycles per pkt

2020-05-15 Thread Ferruh Yigit
On 5/8/2020 11:38 PM, Dharmik Thakkar wrote: > On aarch64 platforms, the cycles are counted using either a > low-resolution generic counter or a high-resolution PMU cycle counter. > Print the clock frequency along with CPU cycles/packet to identify which > cycle counter is being used. > > Signed-o

Re: [dpdk-dev] [PATCH v2 3/5] doc: add cycles per packet in testpmd user guide

2020-05-15 Thread Ferruh Yigit
On 5/8/2020 11:38 PM, Dharmik Thakkar wrote: > Update documentation for 'show fwd' testpmd runtime function to show > CPU cycles/packet example. > > Signed-off-by: Dharmik Thakkar > Reviewed-by: Honnappa Nagarahalli > Reviewed-by: Phil Yang > --- > v2: > - Use shorter lines, up to 100. > --- >

[dpdk-dev] [PATCH 2/2] net/mlx5: fix port action resource initialization

2020-05-15 Thread Bing Zhao
After memory optimization, the organization of some resources are changed from pointer based LIST to the index based ILIST. A lot of code parts are touched due to such change. Some static code checking and analysis tool will complain and raise a false warning on the uninitialized value using. E.g.

[dpdk-dev] [PATCH 1/2] net/mlx5: fix port action assert timing

2020-05-15 Thread Bing Zhao
After memory optimization, some action object handles are changed to index to save the overhead. Assertion in debug mode will be helpful for trouble shooting. In the current implementation, only one port action is supported in switchdev mode for one device flow. In debug mode, an assertion will be

Re: [dpdk-dev] [PATCH v2 2/2] examples/kni: fix MTU change to setup Tx queue

2020-05-15 Thread Ferruh Yigit
On 5/14/2020 5:09 AM, Rasesh Mody wrote: > This patch adds a fix to setup Tx queue when changing KNI interface MTU. > It ensures device can safely start txq post MTU change operation. > > Fixes: fc9ee41b7016 ("examples/kni: convert to new ethdev offloads API") > Cc: sta...@dpdk.org > > Signed-off

[dpdk-dev] [PATCH] event/octeontx: fix memory corruption

2020-05-15 Thread Harman Kalra
Since PMD enqueues a single event at a time, fixing the issue by passing 1 rather than nb_events to avoid any out of bound access as reported by coverity. Coverity issue: 358447 Fixes: 56a96aa42464 ("event/octeontx: add framework for Rx/Tx offloads") Signed-off-by: Harman Kalra --- drivers/even

Re: [dpdk-dev] [PATCH v3 01/12] common/dpaax: move internal symbols into INTERNAL section

2020-05-15 Thread Thomas Monjalon
Adding a bit more definitions to better understand. A "stable" library exports at least one symbol in the current stable ABI. Its soname is suffixed with the current ABI version. If the library exports no symbol in the current ABI, but has a symbol in the next ABI, the soname is suffixed also with

[dpdk-dev] [PATCH] vfio: change default per vfio_cfg map all dpdk segments for DMA

2020-05-15 Thread wangyunjian
From: Yunjian Wang As all vfio_cfgs need to map all dpdk segments for DMA, but now only default_vfio_cfg map it. This patch changes rte_vfio_setup_device() as a default map, so that IOMMU progrming does notneed to map dpdk segments separately. Signed-off-by: Yunjian Wang --- lib/librte_eal/lin

Re: [dpdk-dev] [PATCH v3] net/axgbe: support sfp module EEPROM

2020-05-15 Thread Ferruh Yigit
On 5/15/2020 6:19 AM, asoma...@amd.com wrote: > From: Amaranath Somalapuram > > Adding API for get_module_eeprom and get_module_info. > > Signed-off-by: Amaranath Somalapuram Hi Amaranath, It seems none of the issues are addressed second time, old one is: http://inbox.dpdk.org/dev/f49c492e-f5

Re: [dpdk-dev] [PATCH v2 2/2] net/bonding: fix MAC address when one port resets

2020-05-15 Thread Ferruh Yigit
On 5/15/2020 4:11 AM, Wei Hu (Xavier) wrote: > Hi, Ferruh Yigit & Chas Williams >Could you please give any suggestion? Hi Xavier, Unfortunately we are missing reviews in bonding patches. There are a few more waiting other than this one. If you are already working on it and have enough inform

Re: [dpdk-dev] [EXT] Re: [PATCH 2/2] net/qede: restore Tx queue setup

2020-05-15 Thread Ferruh Yigit
On 5/14/2020 11:43 PM, Rasesh Mody wrote: >> From: Ferruh Yigit >> Sent: Thursday, May 14, 2020 7:33 AM >> >> On 5/6/2020 3:43 AM, Rasesh Mody wrote: >>> Hi, >>> From: Thomas Monjalon Sent: Tuesday, May 05, 2020 2:15 AM 05/05/2020 10:59, Ferruh Yigit: > On 5/5/2020 7:44 AM

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-15 Thread Ananyev, Konstantin
> On Thu, May 14, 2020 at 10:29:31PM +0200, Olivier Matz wrote: > > Hi Nithin, > > > > On Tue, May 05, 2020 at 11:49:20AM +0530, Nithin Dabilpuram wrote: > > > On Mon, May 04, 2020 at 02:27:35PM +0200, Olivier Matz wrote: > > > > On Mon, May 04, 2020 at 03:34:57PM +0530, Nithin Dabilpuram wrote:

Re: [dpdk-dev] [EXT] Re: [PATCH 1/3] mbuf: add Tx offloads for packet marking

2020-05-15 Thread Nithin Dabilpuram
On Thu, May 14, 2020 at 10:29:31PM +0200, Olivier Matz wrote: > Hi Nithin, > > On Tue, May 05, 2020 at 11:49:20AM +0530, Nithin Dabilpuram wrote: > > On Mon, May 04, 2020 at 02:27:35PM +0200, Olivier Matz wrote: > > > On Mon, May 04, 2020 at 03:34:57PM +0530, Nithin Dabilpuram wrote: > > > > On Mo

Re: [dpdk-dev] [PATCH 3/9] vdpa/ifc: add support to vDPA queue enable

2020-05-15 Thread Jason Wang
On 2020/5/15 下午5:42, Wang, Xiao W wrote: Hi, Best Regards, Xiao > -Original Message- > From: Jason Wang > Sent: Friday, May 15, 2020 5:09 PM > To: Maxime Coquelin ; Ye, Xiaolong > ; shah...@mellanox.com; ma...@mellanox.com; > amore...@redhat.com; Wang, Xiao W ; > viachesl...@

[dpdk-dev] [PATCH] crypto/qat: support DOCSIS AES-256

2020-05-15 Thread Mairtin o Loingsigh
Add doc updates for QAT DOCSIS AES-256 support Fixes: 2aab3ff3d8cf ("crypto/qat: support DOCSIS AES-256") Cc: mairtin.oloings...@intel.com Signed-off-by: Mairtin o Loingsigh --- doc/guides/rel_notes/release_20_05.rst |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/do

Re: [dpdk-dev] [PATCH 3/9] vdpa/ifc: add support to vDPA queue enable

2020-05-15 Thread Jason Wang
On 2020/5/15 下午5:42, Wang, Xiao W wrote: Hi, Best Regards, Xiao > -Original Message- > From: Jason Wang > Sent: Friday, May 15, 2020 5:09 PM > To: Maxime Coquelin ; Ye, Xiaolong > ; shah...@mellanox.com; ma...@mellanox.com; > amore...@redhat.com; Wang, Xiao W ; > viachesl...@

Re: [dpdk-dev] [PATCH] lib/librte_net: fix bug for ipv4 checksumcalculating

2020-05-15 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of guohongzhi (A) > Sent: Friday, May 15, 2020 3:05 AM > > Ok, later I will write a patch to solve the problem of tcpdump checksum > > -Original Message- > From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Thursday,May 14,2

Re: [dpdk-dev] [PATCH v3] Test/crypto: check valid test_stats before running test

2020-05-15 Thread Ananyev, Konstantin
> Test_stats is an optional cryptodev op and if it is not defined by the > PMD, it should not run the test cases for it. > > Signed-off-by: Apeksha Gupta > --- > app/test/test_cryptodev.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/app/test/test_cryptodev.c b

[dpdk-dev] [PATCH v8 13/13] bus/fslmc: remove unused symbols

2020-05-15 Thread Hemant Agrawal
rte_dpaa2_memsegs is not being used by any other library or even within bus. Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c| 6 -- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 3 --- drivers/bus/fslmc/rte_bus_fslmc_version.map | 1 - 3 files changed, 10 delet

[dpdk-dev] [PATCH v8 12/13] bus/fslmc: share mcp ptr as function across libs

2020-05-15 Thread Hemant Agrawal
Currently rte_mcp_ptr_list is being shared as a variable across libs. This is only used in control path. This patch change it to a exported function based access. Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/fslmc_vfio.c | 15 --- drivers/bus/fslmc/portal/dpaa2_hw

[dpdk-dev] [PATCH v8 10/13] bus/dpaa: move log into to respective dpaa drivers

2020-05-15 Thread Hemant Agrawal
This is to reduce the number of variables getting exposed from the dpaa bus. They are not required to be in bus. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/dpaa_bus.c | 19 +--- drivers/bus/dpaa/rte_bus_dpaa_version.map | 4 -- drivers/bus/dpaa/rte_dpaa_logs.h

[dpdk-dev] [PATCH v8 07/13] crypto: move internal symbols into INTERNAL section

2020-05-15 Thread Hemant Agrawal
This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_event.h | 5 +++-- drivers/crypto/dpaa2_sec/rte_pmd_dpaa2_sec_version.map | 6 -- drivers/cr

[dpdk-dev] [PATCH v8 08/13] mempool/dpaa2: fix to add the include file

2020-05-15 Thread Hemant Agrawal
rte_dpaa2_mempool.h header was missed to be added in meson.build for header installation. Fixes: 7ed359909556 ("mempool/dpaa2: add functions for CMDIF") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/mempool/dpaa2/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/

[dpdk-dev] [PATCH v8 11/13] bus/dpaa: change netcfg access as function

2020-05-15 Thread Hemant Agrawal
This patch changes the export of fman port config as function call instead of direct variable access. This is in control path, so it will not impact perf. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/dpaa_bus.c | 6 ++ drivers/bus/dpaa/rte_bus_dpaa_version.map | 1 + driv

[dpdk-dev] [PATCH v8 09/13] bus/dpaa: share qman portal ids as function calls

2020-05-15 Thread Hemant Agrawal
qman caam and pool portal ids are only used in control path. This patch changes their inter library access to function call instead of direct shared variable. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/qbman/qman_driver.c | 10 ++ drivers/bus/dpaa/include/fsl_qman.h |

[dpdk-dev] [PATCH v8 04/13] mempool/dpaa2: move internal symbols into INTERNAL section

2020-05-15 Thread Hemant Agrawal
This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- devtools/libabigail.abignore| 8 drivers/mempool/dpaa/rte_mempool_dpaa_version.map | 6 -- drivers/mempo

[dpdk-dev] [PATCH v8 01/13] common/dpaax: move internal symbols into INTERNAL section

2020-05-15 Thread Hemant Agrawal
This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- devtools/libabigail.abignore | 3 +++ drivers/common/dpaax/dpaa_of.h| 15 +++ drivers/com

[dpdk-dev] [PATCH v8 05/13] net/dpaa: move internal symbols into INTERNAL section

2020-05-15 Thread Hemant Agrawal
This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- devtools/libabigail.abignore | 2 ++ drivers/net/dpaa/dpaa_ethdev.h| 2 ++ drivers/net/dpaa/rte_pmd_dpaa_version.map |

[dpdk-dev] [PATCH v8 06/13] net/dpaa2: move internal symbols into INTERNAL section

2020-05-15 Thread Hemant Agrawal
This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.h| 2 ++ drivers/net/dpaa2/rte_pmd_dpaa2_version.map | 12 +++- 2 files changed, 9 insertio

[dpdk-dev] [PATCH v8 02/13] bus/fslmc: move internal symbols into INTERNAL section

2020-05-15 Thread Hemant Agrawal
This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. This patch also removes two symbols, which were not used anywhere else i.e. rte_fslmc_vfio_dmamap & dpaa2_get_qbman_swp Signed-off-by: Hemant Agrawal --- devtools/libabigail.ab

[dpdk-dev] [PATCH v8 03/13] bus/dpaa: move internal symbols into INTERNAL section

2020-05-15 Thread Hemant Agrawal
This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. This patch also removes two symbols, which are not to be exported. rte_dpaa_mem_ptov - static inline in the headerfile fman_ccsr_map_fd - local shared variable. Signed-off-by: H

[dpdk-dev] [PATCH v8 00/13] NXP DPAAx: move internal symbols to INTERNAL

2020-05-15 Thread Hemant Agrawal
v8: fix 32bit compilation v7: using empty DPDK_20.0 to preserve the so name v6: v5 was dirty v5: use empty DPDK_20.0 to avoid so name erriin pmd_dpaa2 v4: pmd_dpaa, mempool_dpaa2 also has external symbols. So, changing the libabigail.abignore exception to only for selected func calls pmd_dpaa2

Re: [dpdk-dev] [PATCH 3/9] vdpa/ifc: add support to vDPA queue enable

2020-05-15 Thread Wang, Xiao W
Hi, Best Regards, Xiao > -Original Message- > From: Jason Wang > Sent: Friday, May 15, 2020 5:09 PM > To: Maxime Coquelin ; Ye, Xiaolong > ; shah...@mellanox.com; ma...@mellanox.com; > amore...@redhat.com; Wang, Xiao W ; > viachesl...@mellanox.com; dev@dpdk.org > Cc: l...@red

[dpdk-dev] [PATCH] crypto/virtio: add OOP_LB_IN_LB_OUT feature flag

2020-05-15 Thread Jay Zhou
Since it will check the feature mask before running out-of-place test cases and the virtio-crypto device supports OOP_LB_IN_LB_OUT mode. Signed-off-by: Jay Zhou --- drivers/crypto/virtio/virtio_cryptodev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/virti

Re: [dpdk-dev] [PATCH v3 01/12] common/dpaax: move internal symbols into INTERNAL section

2020-05-15 Thread Thomas Monjalon
14/05/2020 19:15, Hemant Agrawal (OSS): > > On Thu, May 14, 2020 at 3:31 PM David Marchand > > wrote: > > > On Thu, May 14, 2020 at 2:39 PM Hemant Agrawal (OSS) > > > wrote: > > > > > > > > [Hemant] this is working fine for pmd_dpaa but not for pmd_dpaa2 > > > > > > > > I removed the filename_exp

Re: [dpdk-dev] [PATCH 3/9] vdpa/ifc: add support to vDPA queue enable

2020-05-15 Thread Jason Wang
On 2020/5/14 下午4:02, Maxime Coquelin wrote: This patch adds support to enabling and disabling vrings on a per-vring granularity. Signed-off-by: Maxime Coquelin A question here, I see in qemu peer_attach() may try to generate VHOST_USER_SET_VRING_ENABLE, but just from the name I think it s

[dpdk-dev] [PATCH] net/mlx5: fix counter query fail during port closing

2020-05-15 Thread Suanming Mou
Currently, the DevX counter query works asynchronously with Devx interrupt handler return the query result. When port closes, the interrupt handler will be uninstalled and the Devx comp obj will also be destroyed. Meanwhile the query is still not cancelled. In this case, counter query may use the i

Re: [dpdk-dev] [PATCH 3/9] vdpa/ifc: add support to vDPA queue enable

2020-05-15 Thread Ye Xiaolong
On 05/14, Maxime Coquelin wrote: >This patch adds support to enabling and disabling >vrings on a per-vring granularity. > >Signed-off-by: Maxime Coquelin >--- > drivers/vdpa/ifc/base/ifcvf.c | 9 + > drivers/vdpa/ifc/base/ifcvf.h | 4 > drivers/vdpa/ifc/ifcvf_vdpa.c | 23 +

[dpdk-dev] [PATCH] net/mlx5: fix potential null dereference in port close

2020-05-15 Thread Suanming Mou
The mlx5_dev_close() might be called twice and the priv->sh is NULL on the second pass. The DRV_LOG does not check priv->sh and it causes potential NULL dereference. Check priv->sh before priv->sh->ctx to avoid the potential NULL dereference." Fixes: 942d13e6e7d1 ("net/mlx5: fix sharing context d

Re: [dpdk-dev] [PATCH v2] example/vhost_blk: fix buffer not null terminated

2020-05-15 Thread Maxime Coquelin
On 5/15/20 4:45 PM, Jin Yu wrote: > In vhost_blk_bdev_construct: The string buffer may not have > a null terminator if the source string's length is equal to > the buffer size. > > Fixes: 91d3e2d42997 ("examples/vhost_blk: refactor to increase readability") > Cc: jin...@intel.com > > Signed-of

Re: [dpdk-dev] [PATCH] net/virtio: remove duplicated runtime check

2020-05-15 Thread Maxime Coquelin
On 5/12/20 3:18 PM, Marvin Liu wrote: > Runtime checks for vectorized datapath are organized into device > configuration function. Remove duplicated check in device init > function. > > Signed-off-by: Marvin Liu Applied to dpdk-next-virtio/master. Thanks, Maxime

Re: [dpdk-dev] [PATCH v2] net/virtio: fix unexpected event after reconnect

2020-05-15 Thread Maxime Coquelin
On 5/15/20 4:35 AM, Marvin Liu wrote: > Event notification should be disabled after virtqueue initialization and > enabled by calling rte_eth_dev_rx_intr_enable later. When virtio user > device reconnecting to vhost, virtqueue_disable_intr should be called to > disable event notification. > > F

Re: [dpdk-dev] [PATCH v3] vhost: fix mbuf allocation failures

2020-05-15 Thread Maxime Coquelin
On 5/8/20 1:17 PM, Sivaprasad Tummala wrote: > vhost buffer allocation is successful for packets that fit > into a linear buffer. If it fails, vhost library is expected > to drop the current packet and skip to the next. > > The patch fixes the error scenario by skipping to next packet. > Note:

[dpdk-dev] [PATCH] net/mlx5: fix shared counter search with nested index

2020-05-15 Thread Suanming Mou
Currently, the shared counter search uses the wrong nested index which is used by the pool index. The incorrect nested index using causes the search go to incorrect counter pool is not existed. Add the counter index to fix the incorrect nested use case. Fixes: 4001d7ad26d4 ("net/mlx5: change Dire

Re: [dpdk-dev] [PATCH] net/ice/base: fix FDIR rule passthrough mode

2020-05-15 Thread Su, Simei
Hi, xiaolong > -Original Message- > From: Ye, Xiaolong > Sent: Friday, May 15, 2020 2:50 PM > To: Su, Simei > Cc: Zhang, Qi Z ; dev@dpdk.org; Cao, Yahui > > Subject: Re: [PATCH] net/ice/base: fix FDIR rule passthrough mode > > Hi, simei > > On 05/08, Simei Su wrote: > >This patch adds

Re: [dpdk-dev] [PATCH] build: disable gcc 10 zero-length-bounds warning

2020-05-15 Thread David Marchand
On Thu, May 14, 2020 at 3:19 PM Kevin Traynor wrote: > > gcc 10 issues warnings about the use of rearm_data marker > from struct rte_mbuf. > > e.g. > ../drivers/net/enic/enic_rxtx_vec_avx2.c: In function ‘rx_one’: > ../drivers/net/enic/enic_rxtx_vec_avx2.c:21:2: > warning: > array subscript 0 is o

Re: [dpdk-dev] [PATCH v4] test/graph: fix coverity issues

2020-05-15 Thread David Marchand
On Fri, May 15, 2020 at 9:29 AM wrote: > > From: Kiran Kumar K > > Fix memory leak and weak crypto issues reported by coverity. > > Coverity issue: 358439, 358448, 358451 > Fixes: 6b89650418 ("test/graph: add functional tests") > > Signed-off-by: Kiran Kumar K > Acked-by: Jerin Jacob Applied,

[dpdk-dev] [PATCH] net/mlx5: fix left shift extension of doorbell bitmap

2020-05-15 Thread Bing Zhao
The doorbell record is organized with page and bitmap. When some new doorbell needs to be associated with a queue, the bit will be set in the bitmap to indicate the corresponding doorbell occupied. A counter is used to record the number of doorbell occupied to speed up the searching. If the number

Re: [dpdk-dev] [PATCH] test/graph_perf: fix memory leaks

2020-05-15 Thread David Marchand
On Wed, May 13, 2020 at 10:56 PM wrote: > > From: Pavan Nikhilesh > > Fix memory leaks reported by coverity. > > Coverity issue: 358440, 358441, 358446 > Fixes: 61d77071ab99 ("test/graph: add performance tests") > > Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob Applied, thanks. -- Dav

Re: [dpdk-dev] [PATCH v3 1/4] librte_ethdev: Introduce a function to release HW rings

2020-05-15 Thread Jeff Guo
hi, renata On 5/13/2020 9:14 PM, Renata Saiakhova wrote: Free previously allocated memzone for HW rings Signed-off-by: Renata Saiakhova --- lib/librte_ethdev/rte_ethdev.c | 28 ++-- lib/librte_ethdev/rte_ethdev_driver.h| 20 + lib/librte_et

Re: [dpdk-dev] [PATCH v3] Test/crypto: check valid test_stats before running test

2020-05-15 Thread Ruifeng Wang
> -Original Message- > From: Apeksha Gupta > Sent: Friday, May 15, 2020 3:56 PM > To: dev@dpdk.org > Cc: Ruifeng Wang ; declan.dohe...@intel.com; > asoma...@amd.com; ano...@marvell.com; roy.fan.zh...@intel.com; > fiona.tr...@intel.com; rnagadhee...@marvell.com; adwiv...@marvell.com; > ji

[dpdk-dev] [PATCH v3] Test/crypto: check valid test_stats before running test

2020-05-15 Thread Apeksha Gupta
Test_stats is an optional cryptodev op and if it is not defined by the PMD, it should not run the test cases for it. Signed-off-by: Apeksha Gupta --- app/test/test_cryptodev.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_crypto

[dpdk-dev] [PATCH v4] net/i40e: fix queue region issue in RSS flow

2020-05-15 Thread Shougang Wang
This patch fixes the issue that the queue region does not take effect due to incorrectly setting the flow type. Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") Cc: sta...@dpdk.org Signed-off-by: Shougang Wang Reviewed-by: Jeff Guo Tested-by: Hailin Xu Tested-by: Lunyuan Cui --- v4: -re

Re: [dpdk-dev] [PATCH v2] net/virtio: fix unexpected event after reconnect

2020-05-15 Thread Maxime Coquelin
On 5/15/20 4:35 AM, Marvin Liu wrote: > Event notification should be disabled after virtqueue initialization and > enabled by calling rte_eth_dev_rx_intr_enable later. When virtio user > device reconnecting to vhost, virtqueue_disable_intr should be called to > disable event notification. > > F

  1   2   >