Re: [dpdk-dev] [PATCH v3] net/i40e: fix out of bounds read issue

hi, chenxu On 5/13/2020 10:26 AM, Chenxu Di wrote: This patch fixes (out-of-bounds read) coverity issue. Coverity issue: 357699 Coverity issue: 357694 Fixes: feaae285b342 ("net/i40e: support hash configuration in RSS flow") Signed-off-by: Chenxu Di --- drivers/net/i40e/i40e_ethdev.c | 6 +++

[dpdk-dev] [PATCH] node: fix arm64 build issue for older gcc

Older GCC(~4) complains about uninitialized 'dip' var though all the lanes of the vec register are set. Hence this patch explicitly initializes vec register to fix the issue. Fixes: 16df6a2c6671 ("node: add IPv4 lookup for arm64") Signed-off-by: Nithin Dabilpuram --- lib/librte_node/ip4_lookup_

Re: [dpdk-dev] [PATCH v2] net/i40e: fix failing to create FDIR flow

On 05/13, Shougang Wang wrote: >This patch fixes the issue that the flow which both source MAC mask >and destination MAC mask are all zeros can not be created. > >Fixes: ea0c22fd8227 ("net/i40e: enable MAC address as flow director input set") > >Signed-off-by: Shougang Wang >Tested-by: Hailin Xu

Re: [dpdk-dev] [PATCH] maintainers: update for ice

> -Original Message- > From: Zhang, Qi Z > Sent: Thursday, April 30, 2020 5:28 PM > To: Ye, Xiaolong > Cc: Lu, Wenzhuo ; Yang, Qiming > ; Yigit, Ferruh ; > dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH] maintainers: update for ice > > Replace Wenzhuo Lu with Qi Zhang. > > Signed-off-by

[dpdk-dev] [PATCH] net/bnxt: add support for 200G link speed

From: Kalesh AP When the driver is loaded on a 200G NIC, the port speed is not displayed correctly. Parse the 200G speed before displaying it. Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 2 ++ drivers/net/bnxt/bnxt_hwrm

Re: [dpdk-dev] [PATCH v2] crypto/caam_jr: fix wrong check of fd

> -Original Message- > From: wangyunjian > Sent: Tuesday, May 12, 2020 4:28 PM > To: Gagandeep Singh ; dev@dpdk.org > Cc: Hemant Agrawal ; Lilijun (Jerry) > ; xudingke ; > sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] crypto/caam_jr: fix wrong check of fd > > > -Original Mes

[dpdk-dev] [PATCH v3] net/i40e: fix queue region issue in RSS flow

This patch fixes the issue that the queue region does not take effect due to incorrectly setting the flow type. Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") Cc: sta...@dpdk.org Signed-off-by: Shougang Wang Reviewed-by: Jeff Guo --- drivers/net/i40e/i40e_flow.c | 35 ++

Re: [dpdk-dev] net/iavf: fix rss algorithm configure issue

hi, qi On 5/13/2020 10:17 AM, Zhang, Qi Z wrote: -Original Message- From: Guo, Jia Sent: Wednesday, May 13, 2020 7:20 AM To: Zhang, Qi Z ; Xing, Beilei ; Wu, Jingjing Cc: Ye, Xiaolong ; dev@dpdk.org Subject: Re: [dpdk-dev] net/iavf: fix rss algorithm configure issue hi, qi On 5/12/

Re: [dpdk-dev] [RFC v2] hash: unify crc32 API header for x86 and ARM

> -Original Message- > From: pbhagavat...@marvell.com > Sent: Wednesday, May 13, 2020 4:40 AM > To: jer...@marvell.com; konstantin.anan...@intel.com; > harry.van.haa...@intel.com; Yipeng Wang ; > Sameh Gobriel ; Bruce Richardson > ; Ruifeng Wang > Cc: dev@dpdk.org; Pavan Nikhilesh > Su

[dpdk-dev] [PATCH v2] net/i40e: fix failing to create FDIR flow

This patch fixes the issue that the flow which both source MAC mask and destination MAC mask are all zeros can not be created. Fixes: ea0c22fd8227 ("net/i40e: enable MAC address as flow director input set") Signed-off-by: Shougang Wang Tested-by: Hailin Xu Reviewed-by: Jeff Guo --- v2 change:

[dpdk-dev] [PATCH v3] net/i40e: fix out of bounds read issue

This patch fixes (out-of-bounds read) coverity issue. Coverity issue: 357699 Coverity issue: 357694 Fixes: feaae285b342 ("net/i40e: support hash configuration in RSS flow") Signed-off-by: Chenxu Di --- drivers/net/i40e/i40e_ethdev.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/driv

Re: [dpdk-dev] net/iavf: fix rss algorithm configure issue

> -Original Message- > From: Guo, Jia > Sent: Wednesday, May 13, 2020 7:20 AM > To: Zhang, Qi Z ; Xing, Beilei ; > Wu, Jingjing > Cc: Ye, Xiaolong ; dev@dpdk.org > Subject: Re: [dpdk-dev] net/iavf: fix rss algorithm configure issue > > hi, qi > > On 5/12/2020 10:21 AM, Zhang, Qi Z wro

[dpdk-dev] [PATCH v2] vhost: fix zero-copy cannot be enabled

This patch fixes the situation where vhost-user cannot start as server with dequeue_zero_copy enabled. Using flag instead of vsocket->is_server to determine whether vhost-user is in client mode. Because vsocket->is_server is not ready at this time. Cc: sta...@dpdk.org Signed-off-by: Xuan Ding -

[dpdk-dev] [PATCH v4] app/testpmd: fix DCB set failure

When set DCB in testpmd, there is a segmentation fault. It is because the local variable rss_conf in get_eth_dcb_conf() is not cleared, so that the pointer member variable rss_key has a random address, which leads to an error in the following processing. This patch initialized the local variable rs

[dpdk-dev] [PATCH v3] app/testpmd: fix DCB set failure

When set DCB in testpmd, there is a segmentation fault. It is because the local variable rss_conf in get_eth_dcb_conf() is not cleared, so that the pointer member variable rss_key has a random address, which leads to an error in the following processing. This patch initialized the local variable rs

[dpdk-dev] 答复: [PATCH] lib/librte_hash: add rte_hash_del_key_fixed without compact

> -邮件原件- > 发件人: Wang, Yipeng1 [mailto:yipeng1.w...@intel.com] > 发送时间: 2020年5月13日 7:41 > 收件人: Lilijun (Jerry) ; Honnappa Nagarahalli > ; 'dev@dpdk.org' > 抄送: wangyunjian ; xudingke > ; 'sta...@dpdk.org' ; nd > ; nd > 主题: RE: [dpdk-dev] [PATCH] lib/librte_hash: add rte_hash_del_key_fixed

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/ixgbe: fix statistics error in flow control mode

On 05/12, Guinan Sun wrote: >The register autoneg can't be updated synchronously >with flow control mode setting in the state of port start >, so NIC statistics error occurs. AUTO_NEG Advt register >should be updated by ixgbe_setup_fc() when enabling flow control. >The patch fixes the issue. > >Fix

[dpdk-dev] [PATCH v2 2/2] mempool/octeontx2: move internal symbols to INTERNAL section

From: Pavan Nikhilesh Move the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Pavan Nikhilesh --- devtools/libabigail.abignore| 4 +++- drivers/mempool/octeontx2/otx2_mempool.h

[dpdk-dev] [PATCH v2 1/2] common/octeontx2: move internal symbols to INTERNAL section

From: Pavan Nikhilesh Move the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Pavan Nikhilesh --- v2 Changes: - Sort version map alphabetically - Add libabigail ignore tag for OCTEONTX2 devtools/libabigail.abignore

Re: [dpdk-dev] [PATCH] test/ring: code rework to reduce compilation time

> > > > > > > > > > > > > > > > > > > > > > > > Hi Konstantin, > > > > > > > > > > > > I like the way the tests are organized and it > > > > > > > > > > > > looks > > > good. > > > > > > > > > > > > > > > > > > > > > > > > I am just wondering about the way it is being tested > > > > > >

Re: [dpdk-dev] [PATCH] lib/librte_hash: avoid iterate bugs with delete keys.

> -Original Message- > From: dev On Behalf Of Lilijun (Jerry) > Sent: Sunday, April 26, 2020 8:41 PM > To: 'dev@dpdk.org' > Cc: wangyunjian ; xudingke > ; 'sta...@dpdk.org' > Subject: [dpdk-dev] [PATCH] lib/librte_hash: avoid iterate bugs with delete > keys. > > From 0faea722b82ffe30adf

Re: [dpdk-dev] [PATCH] lib/librte_hash: add rte_hash_del_key_fixed without compact

> -Original Message- > From: Lilijun (Jerry) > Sent: Tuesday, May 5, 2020 6:10 PM > To: Honnappa Nagarahalli ; > 'dev@dpdk.org' > Cc: wangyunjian ; xudingke > ; 'sta...@dpdk.org' ; nd > ; Wang, Yipeng1 ; nd > > Subject: 答复: [dpdk-dev] [PATCH] lib/librte_hash: add > rte_hash_del_key_fixed

Re: [dpdk-dev] net/iavf: fix rss algorithm configure issue

hi, qi On 5/12/2020 10:21 AM, Zhang, Qi Z wrote: -Original Message- From: Zhang, Qi Z Sent: Tuesday, May 12, 2020 10:18 AM To: Guo, Jia ; Xing, Beilei ; Wu, Jingjing Cc: Ye, Xiaolong ; dev@dpdk.org Subject: RE: [dpdk-dev] net/iavf: fix rss algorithm configure issue -Original M

Re: [dpdk-dev] [RFC] eal: adjust barriers for IO on Armv8-a

> > > > Subject: [RFC] eal: adjust barriers for IO on Armv8-a > > > > > > > > Change the barrier APIs for IO to reflect that Armv8-a is > > > > other-multi-copy atomicity memory model. > > > > > > > > Armv8-a memory model has been strengthened to require > > > > other-multi-copy atomicity. This p

Re: [dpdk-dev] [PATCH RFC v1 0/7] relax barriers for ENA PMD and small fixes

Hi Igor, Few comments inline. > > Subject: RE: [PATCH RFC v1 0/7] relax barriers for ENA PMD and small > > fixes > > > > Hi all, > > > > Please see the first batch of comments related to these patches: > > > > 1. Relaxing the register read/write isn't always good enough. > > Specifically

[dpdk-dev] [RFC v2] hash: unify crc32 API header for x86 and ARM

From: Pavan Nikhilesh Merge crc32 hash calculation public API headers for x86 and ARM. Select the best available CRC32 algorithm when unsupported algorithm on a given CPU architecture is requested by an application. Previously, if an application directly includes `rte_crc_arm64.h` without includ

Re: [dpdk-dev] Release candidate 20.05-rc2 ABI

> Subject: [dpdk-dev] Release candidate 20.05-rc2 ABI > > Folks, > > Few ABI observations based on the 20.05-rc2, (please correct me if I am > wrong) > > 1. rte_ring.h - struct rte_ring > > Changes to the structure of rte_ring throws up a whole bunch of false > positives that have been suppre

[dpdk-dev] [PATCH] net/vmxnet3: handle bad host framing

The VMXNet3 protocol has a start-of-packet (SOP) and end-of-packet (EOP) marker. If there was a bug where mbuf arrived without SOP the code that chains the mbuf would dereference a null pointer. Also, record any mbuf's dropped in statistics. Although did the initial code no longer have access to V

[dpdk-dev] [PATCH] doc: fix wrong config option

The documentation says that CONFIG_ENABLE_LTO enables LTO during the build, but the correct value actually is CONFIG_RTE_ENABLE_LTO Fixes: 098cc0fea3be ("build: add option to enable LTO") Signed-off-by: Matteo Croce --- doc/guides/prog_guide/lto.rst | 2 +- 1 file changed, 1 insertion(+), 1 dele

Re: [dpdk-dev] [PATCH v4 4/4] eal/atomic: add wrapper for c11 atomics

Subject: Re: [PATCH v4 4/4] eal/atomic: add wrapper for c11 atomics On Tue, May 12, 2020 at 4:03 pm, Phil Yang wrote: parameter. Signed-off-by: Phil Yang What is the purpose of having rte_atomic at all? Is this level of indirection really

Re: [dpdk-dev] [PATCH v4 4/4] eal/atomic: add wrapper for c11 atomics

On Tue, May 12, 2020 at 4:03 pm, Phil Yang wrote: parameter. Signed-off-by: Phil Yang > What is the purpose of having rte_atomic at all? Is this level of indirection really helping?

Re: [dpdk-dev] [PATCH] pci: properly parse 32-bit domain numbers

On Tue, May 12, 2020 at 3:30 pm, Darek Stojaczyk wrote: The parsing code was bailing on domains greater than UINT16_MAX, but domain numbers like that are still valid and present on some systems. One example is Intel VMD (Volume Management Device), which acts somewhat as a software-managed

Re: [dpdk-dev] [PATCH v3 0/4] add AESNI-MB rawdev for multi-function processing

Hi Fan & Akhil, > -Original Message- > From: Zhang, Roy Fan > Sent: Friday, May 1, 2020 2:18 PM > > Hi Akhil, > > > -Original Message- > > From: dev On Behalf Of Akhil Goyal > > Sent: Wednesday, April 22, 2020 2:44 PM > > To: Coyle, David ; Doherty, Declan > > ; Thomas Monjalon

[dpdk-dev] Release candidate 20.05-rc2 ABI

Folks, Few ABI observations based on the 20.05-rc2, (please correct me if I am wrong) 1. rte_ring.h - struct rte_ring Changes to the structure of rte_ring throws up a whole bunch of false positives that have been suppressed in libabigail.ignore. It is not used by end applications and should

[dpdk-dev] [PATCH 3/5] telemetry: fix closing socket fd on error

The socket fd is now being closed when the connection fails. Coverity issue: 358444 Fixes: b80fe1805eee ("telemetry: introduce backward compatibility") Cc: ciara.po...@intel.com Signed-off-by: Ciara Power --- lib/librte_telemetry/telemetry_legacy.c | 1 + 1 file changed, 1 insertion(+) diff --

[dpdk-dev] [PATCH 4/5] telemetry: fix checking error return for socket creation

The return value from the socket function is now checked, as it can return a negative value on error. Coverity issue: 358443 Fixes: b80fe1805eee ("telemetry: introduce backward compatibility") Cc: ciara.po...@intel.com Signed-off-by: Ciara Power --- lib/librte_telemetry/telemetry_legacy.c | 4 +

[dpdk-dev] [PATCH 0/5] small fixes for telemetry rework.

Ciara Power (5): telemetry: keep telemetry threads separate from data plane telemetry: fix error checking for strchr function telemetry: fix closing socket fd on error telemetry: fix checking error return for socket creation telemetry: fix buffer overrun if max bytes read lib/librte_e

[dpdk-dev] [PATCH 2/5] telemetry: fix error checking for strchr function

The strchr function return was not being checked which could lead to NULL deferencing later in the function. Coverity issue: 358438 Coverity issue: 358445 Fixes: b80fe1805eee ("telemetry: introduce backward compatibility") Cc: ciara.po...@intel.com Signed-off-by: Ciara Power --- lib/librte_tele

[dpdk-dev] [PATCH 1/5] telemetry: keep telemetry threads separate from data plane

The threads for listening on the telemetry sockets are control threads and should be separated from those on the data plane. Since telemetry cannot use the rte_ctrl_thread_create() API, as it does not depend on EAL, we pass the ctrl thread cpu_set to telemetry init and use it directly to ensure tha

[dpdk-dev] [PATCH 5/5] telemetry: fix buffer overrun if max bytes read

If 1024 bytes were received over the socket, this caused buffer_recvf[bytes] to overrun the array. The size of the buffer - 1 is now passed to the read function. Coverity issue: 358442 Fixes: b80fe1805eee ("telemetry: introduce backward compatibility") Cc: ciara.po...@intel.com Signed-off-by: Cia

Re: [dpdk-dev] [PATCH] pci: properly parse 32-bit domain numbers

On 12-May-20 2:30 PM, Darek Stojaczyk wrote: The parsing code was bailing on domains greater than UINT16_MAX, but domain numbers like that are still valid and present on some systems. One example is Intel VMD (Volume Management Device), which acts somewhat as a software-managed PCI switch and its

[dpdk-dev] [PATCH v2 11/12] bus/dpaa: move log into to respective dpaa drivers

This is to reduce the number of variables getting exposed from the dpaa bus. They are not required to be in bus. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/dpaa_bus.c | 19 +--- drivers/bus/dpaa/rte_bus_dpaa_version.map | 4 -- drivers/bus/dpaa/rte_dpaa_logs.h

[dpdk-dev] [PATCH v2 12/12] bus/dpaa: change netcfg access as function

This patch changes the export of fman port config as function call instead of direct variable access. This is in control path, so it will not impact perf. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/dpaa_bus.c | 6 ++ drivers/bus/dpaa/rte_bus_dpaa_version.map | 1 + driv

[dpdk-dev] [PATCH v2 09/12] net/dpaa: move internal symbols into INTERNAL section

This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.h| 2 ++ drivers/net/dpaa/rte_pmd_dpaa_version.map | 9 - 2 files changed, 10 insertions(+), 1

[dpdk-dev] [PATCH v2 08/12] net/dpaa2: move internal symbols into INTERNAL section

This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.h| 2 ++ drivers/net/dpaa2/rte_pmd_dpaa2_version.map | 2 +- 2 files changed, 3 insertions(+), 1 del

[dpdk-dev] [PATCH v2 10/12] bus/dpaa: share qman portal ids as function calls

qman caam and pool portal ids are only used in control path. This patch changes their inter library access to function call instead of direct shared variable. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/qbman/qman_driver.c | 10 ++ drivers/bus/dpaa/include/fsl_qman.h |

[dpdk-dev] [PATCH v2 07/12] crypto: move internal symbols into INTERNAL section

This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_event.h | 5 +++-- drivers/crypto/dpaa2_sec/rte_pmd_dpaa2_sec_version.map | 2 +- drivers/crypto

[dpdk-dev] [PATCH v2 04/12] bus/fslmc: share mcp ptr as function across libs

Currently rte_mcp_ptr_list is being shared as a variable across libs. This is only used in control path. This patch change it to a exported function based access. Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/fslmc_vfio.c | 15 --- drivers/bus/fslmc/portal/dpaa2_hw

[dpdk-dev] [PATCH v2 05/12] bus/fslmc: remove unused symbols

rte_dpaa2_memsegs is not being used by any other library or even within bus. Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c| 6 -- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 3 --- drivers/bus/fslmc/rte_bus_fslmc_version.map | 1 - 3 files changed, 10 delet

[dpdk-dev] [PATCH v2 06/12] bus/dpaa: move internal symbols into INTERNAL section

This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/include/fsl_bman.h | 6 + drivers/bus/dpaa/include/fsl_fman.h | 27 +++ drivers/bus/dpaa/incl

[dpdk-dev] [PATCH v2 01/12] common/dpaax: move internal symbols into INTERNAL section

This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- drivers/common/dpaax/dpaa_of.h| 15 +++ drivers/common/dpaax/dpaax_iova_table.h | 4 drivers/co

[dpdk-dev] [PATCH v2 03/12] bus/fslmc: move internal symbols into INTERNAL section

This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/fslmc_vfio.h| 4 ++ drivers/bus/fslmc/mc/fsl_dpbp.h | 6 +++ drivers/bus/fslmc/mc/fsl_dpci.h

[dpdk-dev] [PATCH v2 02/12] mempool/dpaa2: move internal symbols into INTERNAL section

This patch moves the internal symbols to INTERNAL sections so that any change in them is not reported as ABI breakage. Signed-off-by: Hemant Agrawal --- drivers/mempool/dpaa/rte_mempool_dpaa_version.map | 2 +- drivers/mempool/dpaa2/dpaa2_hw_mempool.h| 1 + drivers/mempool/dpaa2/rt

[dpdk-dev] [PATCH v2] examples/l2fwd: free resources in case of error

Bugzilla ID: 437 Cc: dev@dpdk.org Cc: sta...@dpdk.org Cc: bruce.richard...@intel.com Cc: vipin.vargh...@intel.com Cc: jgraj...@cisco.com Signed-off-by: Muhammad Bilal --- examples/l2fwd/main.c | 76 ++- 1 file changed, 60 insertions(+), 16 deletions(-) dif

[dpdk-dev] [Bug 175] DPDK on Azure using `intel-go/nff-go` fails using `hv_netvsc` driver

https://bugs.dpdk.org/show_bug.cgi?id=175 Asaf Penso (as...@mellanox.com) changed: What|Removed |Added Resolution|--- |INVALID CC|

[dpdk-dev] [PATCH] pci: properly parse 32-bit domain numbers

The parsing code was bailing on domains greater than UINT16_MAX, but domain numbers like that are still valid and present on some systems. One example is Intel VMD (Volume Management Device), which acts somewhat as a software-managed PCI switch and its upstream linux driver assigns all downstream d

[dpdk-dev] Coverity Defects in DPDK 20.05

Hi, The following are Coverity defects in DPDK 20.05, or previous releases, open against your name based on git-log. Please submit fixes. https://scan.coverity.com/projects/dpdk-data-plane-development-kit John CIDType Impact First Detected Owner

Re: [dpdk-dev] [PATCH] test/crypto: remove tests for unsupported descriptors

Hi Adam, The crypto library doesn't specify an upper limit for the nb_descriptors to be passed for queue_pair_setup. So technically all the values that you have passed as invalid is not correct. I did check few PMDs when I saw this issue with OCTEON TX2 crypto PMD. QAT support max 4096 descrip

Re: [dpdk-dev] [PATCH] net/virtio: remove duplicated runtime check

On 5/12/20 3:18 PM, Marvin Liu wrote: > Runtime checks for vectorized datapath are organized into device > configuration function. Remove duplicated check in device init > function. > > Signed-off-by: Marvin Liu > > diff --git a/drivers/net/virtio/virtio_ethdev.c > b/drivers/net/virtio/virti

Re: [dpdk-dev] [PATCH v2] net/virtio: fix AVX512 datapath selection

> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, May 12, 2020 6:04 PM > To: Liu, Yong ; Yigit, Ferruh > Cc: dev@dpdk.org; Thomas Monjalon ; David > Marchand ; Richardson, Bruce > ; Nicolau, Radu ; > Luca Boccassi ; Wang, Zhihong > ; Ye, Xiaolong > Subject: Re: [PATCH v2] n

Re: [dpdk-dev] [PATCH] test/crypto: remove tests for unsupported descriptors

Hi Adam, > > Hi Anoob. > > What's wrong with this test? Is this unit test failing on any PMD now? > I've checked on several (QAT, OpenSSL, SW ZUC, SW KASUMI, SW SNOW3G, > SCHEDULER) and it passes everywhere. Then why should we remove it > completely? > The problem is not with the valid cases. I

[dpdk-dev] [PATCH] net/virtio: remove duplicated runtime check

Runtime checks for vectorized datapath are organized into device configuration function. Remove duplicated check in device init function. Signed-off-by: Marvin Liu diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 49ccef12c7..312871cb48 100644 --- a/driv

Re: [dpdk-dev] [PATCH] test/crypto: remove tests for unsupported descriptors

Hi Anoob. What's wrong with this test? Is this unit test failing on any PMD now? I've checked on several (QAT, OpenSSL, SW ZUC, SW KASUMI, SW SNOW3G, SCHEDULER) and it passes everywhere. Then why should we remove it completely? Adam > -Original Message- > From: dev On Behalf Of Anoob J

[dpdk-dev] [PATCH] net/mlx5: fix counter container resize

The design of counter container resize used double buffer algorithm in order to synchronize between the query thread to the control thread. When the control thread detected resize need, it created new bigger buffer for the counter pools in a new container and change the container index atomically.

Re: [dpdk-dev] [PATCH 0/3] mlx5: relaxed ordering fixes

From: Shiri Kuzin > Fixed some bugs regarding relaxed ordering in mlx5. > > Shiri Kuzin (3): > common/mlx5: fix relaxed ordering support detection > common/mlx5: fix relaxed ordering count object > common/mlx5: disable relaxed ordering in unsuitable cpus Series-acked-by: Matan Azrad >

[dpdk-dev] [PATCH 3/3] common/mlx5: disable relaxed ordering in unsuitable cpus

Relaxed ordering is a PCI optimization that enables reordering reads/writes in order to improve performance. Relaxed ordering was enabled for all processors causing a degradation in performance in Haswell and Broadwell processors that don't support this optimization. In order to avoid that we che

[dpdk-dev] [PATCH 0/3] mlx5: relaxed ordering fixes

Fixed some bugs regarding relaxed ordering in mlx5. Shiri Kuzin (3): common/mlx5: fix relaxed ordering support detection common/mlx5: fix relaxed ordering count object common/mlx5: disable relaxed ordering in unsuitable cpus drivers/common/mlx5/Makefile | 5 +++ drivers/common/mlx

[dpdk-dev] [PATCH 1/3] common/mlx5: fix relaxed ordering support detection

Relaxed ordering is a PCI optimization that allows reordering of reads/writes in order to improve performance. In order to enable this optimization only when relaxed ordering is supported, it is checked if IBV_ACCESS_RELAXED_ORDERING is defined in verbs.h. Since IBV_ACCESS_RELAXED_ORDERING is an

[dpdk-dev] [PATCH 2/3] common/mlx5: fix relaxed ordering count object

In order to improve performance relaxed ordering was enabled when creating count object using Devx. Currently rte enables this optimization by default when using Devx. This causes an issue when using firmware that does not have this capability causing a count object failure. In order to fix this

Re: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: add per core packet stats

Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Friday, May 8, 2020 1:39 PM > To: Anoob Joseph ; Akhil Goyal ; > Nicolau, Radu > Cc: Narayana Prasad Raju Athreya ; dev@dpdk.org > Subject: [EXT] RE: [PATCH v3] examples/ipsec-secgw

Re: [dpdk-dev] [PATCH v3] examples/ipsec-secgw: add per core packet stats

Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, May 7, 2020 9:42 PM > To: Anoob Joseph ; Akhil Goyal ; > Nicolau, Radu > Cc: Narayana Prasad Raju Athreya ; dev@dpdk.org > Subject: [EXT] RE: [PATCH v3] examples/ipsec-sec

Re: [dpdk-dev] [PATCH] common/mlx5: fix umem buffer alignment

Hi, > -Original Message- > From: Dekel Peled > Sent: Monday, May 11, 2020 1:03 PM > To: Matan Azrad ; Slava Ovsiienko > ; Raslan Darawsheh > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] common/mlx5: fix umem buffer alignment > > The value MLX5_WQE_BUF_ALIGNMENT is defined as 512.

Re: [dpdk-dev] [PATCH v1] app/testpmd: fix DCB set failure in FreeBSD by clang

Hi Ting, > -Original Message- > From: Xu, Ting > Sent: Tuesday, May 12, 2020 3:17 AM > To: Yigit, Ferruh ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Xing, Beilei > ; Iremonger, Bernard > ; sta...@dpdk.org; Andrew Rybchenko > ; Thomas Monjalon > Subject: RE: [dpdk-dev] [PATCH v1] app/testpmd: fix

Re: [dpdk-dev] [PATCH v4 4/4] eal/atomic: add wrapper for c11 atomics

> From: Phil Yang [mailto:phil.y...@arm.com] > Sent: Tuesday, May 12, 2020 10:03 AM > > Wraps up compiler c11 atomic built-ins with explicit memory ordering > parameter. > > Signed-off-by: Phil Yang > --- > lib/librte_eal/include/generic/rte_atomic_c11.h | 139 > > lib/

Re: [dpdk-dev] [PATCH] net/mlx5: prefer DevX API to create Rx objects

Hi, > -Original Message- > From: Dekel Peled > Sent: Sunday, May 10, 2020 2:19 PM > To: Matan Azrad ; Slava Ovsiienko > ; Raslan Darawsheh > Cc: dev@dpdk.org > Subject: [PATCH] net/mlx5: prefer DevX API to create Rx objects > > Currently, DevX API is used to create Rx objects (RQ, RQT,

Re: [dpdk-dev] [PATCH v6 2/5] app/flow-perf: add insertion rate calculation

On 5/12/20 1:34 PM, Wisam Monther wrote: >> -Original Message- >> From: Andrew Rybchenko >> Sent: Monday, May 11, 2020 3:05 PM >> To: Wisam Monther ; dev@dpdk.org; Jack Min >> ; Thomas Monjalon ; >> jerinjac...@gmail.com; ajit.khapa...@broadcom.com >> Subject: Re: [PATCH v6 2/5] app/flow-p

Re: [dpdk-dev] [PATCH v2] crypto/caam_jr: fix wrong check of fd

> -Original Message- > From: Gagandeep Singh [mailto:g.si...@nxp.com] > Sent: Tuesday, May 12, 2020 11:49 AM > To: wangyunjian ; dev@dpdk.org > Cc: Hemant Agrawal ; Lilijun (Jerry) > ; xudingke ; > sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] crypto/caam_jr: fix wrong check of fd >

Re: [dpdk-dev] [PATCH v4 1/2] common/mlx5: add rte internal tag and avoid comparison

Hi, > -Original Message- > From: Ophir Munk > Sent: Thursday, May 7, 2020 2:31 PM > To: dev@dpdk.org; David Marchand > Cc: Ray Kinsella ; Matan Azrad ; > Raslan Darawsheh ; Thomas Monjalon > ; Ophir Munk > Subject: [PATCH v4 1/2] common/mlx5: add rte internal tag and avoid > comparison

Re: [dpdk-dev] [PATCH v6 2/5] app/flow-perf: add insertion rate calculation

>-Original Message- >From: Andrew Rybchenko >Sent: Monday, May 11, 2020 3:05 PM >To: Wisam Monther ; dev@dpdk.org; Jack Min >; Thomas Monjalon ; >jerinjac...@gmail.com; ajit.khapa...@broadcom.com >Subject: Re: [PATCH v6 2/5] app/flow-perf: add insertion rate calculation > >On 5/11/20 2:09

Re: [dpdk-dev] [PATCH] net/i40e: fix failing to create FDIR flow

hi, shougang On 5/6/2020 2:14 PM, Shougang Wang wrote: This patch fixes the issue that the flow which both source MAC mask and destination MAC mask are all zeros can not be created. Fixes: ea0c22fd8227 ("net/i40e: enable MAC address as flow director input set") Signed-off-by: Shougang Wang --

Re: [dpdk-dev] [PATCH v2 3/5] doc: add cycles per packet in testpmd user guide

> -Original Message- > From: Dharmik Thakkar > Sent: Friday, May 8, 2020 11:38 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > ; Mcnamara, John > ; Kovacevic, Marko > > Cc: dev@dpdk.org; n...@arm.com; Dharmik Thakkar > > Subject: [PATCH v2 3/5] doc: add cycles per packet in

Re: [dpdk-dev] [PATCH v2 4/5] doc: include config options in testpmd user guide

> -Original Message- > From: Dharmik Thakkar > Sent: Friday, May 8, 2020 11:38 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > ; Mcnamara, John > ; Kovacevic, Marko > > Cc: dev@dpdk.org; n...@arm.com; Dharmik Thakkar > > Subject: [PATCH v2 4/5] doc: include config options in

Re: [dpdk-dev] [PATCH v2 2/5] app/testpmd: print fractional part in CPU cycles

> -Original Message- > From: Dharmik Thakkar > Sent: Friday, May 8, 2020 11:38 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > > Cc: dev@dpdk.org; n...@arm.com; Dharmik Thakkar > > Subject: [PATCH v2 2/5] app/testpmd: print fractional part in CPU cycles > > Change printing

Re: [dpdk-dev] [PATCH v2 1/5] app/testpmd: print clock with CPU cycles per pkt

> -Original Message- > From: Dharmik Thakkar > Sent: Friday, May 8, 2020 11:38 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > > Cc: dev@dpdk.org; n...@arm.com; Dharmik Thakkar > > Subject: [PATCH v2 1/5] app/testpmd: print clock with CPU cycles per pkt > > On aarch64 platf

Re: [dpdk-dev] [PATCH v2] net/virtio: fix AVX512 datapath selection

On 5/12/20 10:46 AM, Liu, Yong wrote: > > >> -Original Message- >> From: Maxime Coquelin >> Sent: Tuesday, May 12, 2020 4:36 PM >> To: Liu, Yong ; Yigit, Ferruh >> Cc: dev@dpdk.org; Thomas Monjalon ; David >> Marchand ; Richardson, Bruce >> ; Nicolau, Radu ; >> Luca Boccassi ; Wang,

[dpdk-dev] [PATCH] vhost: fix dequeue_zero_zopy cannot be enabled

Use flag instead of vsocket->is_server to determine whether vhost is in client mode. Because vsocket->is_server is not ready yet. Cc: sta...@dpdk.org Signed-off-by: Xuan Ding --- lib/librte_vhost/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_vhost/socke

Re: [dpdk-dev] [EXT] Re: [PATCH v5 20/29] node: ipv4 lookup for arm64

On Tue, May 12, 2020 at 11:31:26AM +0200, David Marchand wrote: > External Email > > -- > On Sat, Apr 11, 2020 at 4:16 PM wrote: > > > > From: Nithin Dabilpuram > > > > Add arm64 specific IPv4 lookup process function > > for ip4

Re: [dpdk-dev] [PATCH v2] net/i40e: fix queue region issue in RSS flow

hi, shougang On 4/24/2020 5:36 PM, Shougang Wang wrote: This patch fixes the issue that the queue region does not take effect due to incorrectly setting the flow type. Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") Cc: sta...@dpdk.org Signed-off-by: Shougang Wang --- v2: -Update the v

Re: [dpdk-dev] [PATCH v5 20/29] node: ipv4 lookup for arm64

On Sat, Apr 11, 2020 at 4:16 PM wrote: > > From: Nithin Dabilpuram > > Add arm64 specific IPv4 lookup process function > for ip4_lookup node. This node performs LPM lookup > on every packet received and forwards it to a next > node that is identified by lookup result. > > Signed-off-by: Nithin Da

Re: [dpdk-dev] [PATCH v2] net/virtio: fix AVX512 datapath selection

> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, May 12, 2020 4:36 PM > To: Liu, Yong ; Yigit, Ferruh > Cc: dev@dpdk.org; Thomas Monjalon ; David > Marchand ; Richardson, Bruce > ; Nicolau, Radu ; > Luca Boccassi ; Wang, Zhihong > ; Ye, Xiaolong > Subject: Re: [PATCH v2] n

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix statistics error in flow control mode

Reviewed-by: Wei Zhao > -Original Message- > From: dev On Behalf Of Guinan Sun > Sent: Tuesday, May 12, 2020 4:13 PM > To: dev@dpdk.org > Cc: Sun, GuinanX ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2] net/ixgbe: fix statistics error in flow control > mode > > The register autoneg

Re: [dpdk-dev] [PATCH v2] net/virtio: fix AVX512 datapath selection

On 5/12/20 5:29 AM, Liu, Yong wrote: > > >> -Original Message- >> From: Maxime Coquelin >> Sent: Tuesday, May 12, 2020 3:50 AM >> To: Yigit, Ferruh ; Wang, Zhihong >> ; Ye, Xiaolong ; Liu, >> Yong >> Cc: dev@dpdk.org; Thomas Monjalon ; David >> Marchand ; Richardson, Bruce >> ; Nicol

Re: [dpdk-dev] [PATCH] net/virtio: fix AVX512 datapath selection

On 5/12/20 4:27 AM, Liu, Yong wrote: > > >> -Original Message- >> From: Maxime Coquelin >> Sent: Monday, May 11, 2020 10:47 PM >> To: Liu, Yong ; Ye, Xiaolong ; >> Yigit, Ferruh ; dev@dpdk.org >> Cc: Maxime Coquelin >> Subject: [PATCH] net/virtio: fix AVX512 datapath selection >> >>

Re: [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow control mode

Hi zhaowei > -Original Message- > From: Zhao1, Wei > Sent: Monday, May 11, 2020 9:03 AM > To: Sun, GuinanX ; dev@dpdk.org > Cc: Sun, GuinanX ; sta...@dpdk.org; Guo, Jia > > Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow > control > mode > > > Hi, Guinan > > >

Re: [dpdk-dev] [RFC] eal: adjust barriers for IO on Armv8-a

On Tue, May 12, 2020 at 1:32 PM Ruifeng Wang wrote: > > > > -Original Message- > > From: Jerin Jacob > > Sent: Tuesday, May 12, 2020 2:42 PM > > To: Ruifeng Wang > > Cc: Honnappa Nagarahalli ; > > dev@dpdk.org; jer...@marvell.com; hemant.agra...@nxp.com; Ajit > > Khaparde (ajit.khapa...@

[dpdk-dev] [PATCH v2] net/ixgbe: fix statistics error in flow control mode

The register autoneg can't be updated synchronously with flow control mode setting in the state of port start , so NIC statistics error occurs. AUTO_NEG Advt register should be updated by ixgbe_setup_fc() when enabling flow control. The patch fixes the issue. Fixes: a524f550da6e ("net/ixgbe: fix f

Re: [dpdk-dev] [PATCH v4 0/4] generic rte atomic APIs deprecate proposal

+ David Christensen The PPC c11 atomics maintainer. My apologies, I forgot to cc you on this email. Thanks, Phil Yang > -Original Message- > From: Phil Yang > Sent: Tuesday, May 12, 2020 4:03 PM > To: tho...@monjalon.net; dev@dpdk.org > Cc: bruce.richard...@intel.com; ferruh.yi...@inte

[dpdk-dev] [PATCH v4 0/4] generic rte atomic APIs deprecate proposal

DPDK provides generic rte_atomic APIs to do several atomic operations. These APIs are using the deprecated __sync built-ins and enforce full memory barriers on aarch64. However, full barriers are not necessary in many use cases. In order to address such use cases, C language offers C11 atomic APIs.

[dpdk-dev] [PATCH v4 4/4] eal/atomic: add wrapper for c11 atomics

Wraps up compiler c11 atomic built-ins with explicit memory ordering parameter. Signed-off-by: Phil Yang --- lib/librte_eal/include/generic/rte_atomic_c11.h | 139 lib/librte_eal/include/meson.build | 1 + 2 files changed, 140 insertions(+) create mode 10

[dpdk-dev] [PATCH v4 2/4] maintainers: claim maintainers of c11 atomics code

Add the maintainership of c11 atomics code. Signed-off-by: Phil Yang Reviewed-by: Honnappa Nagarahalli --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6a14622..4435ae5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -266,6 +266,10 @@ F: lib/

  1   2   >