Hi zhaowei
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Monday, May 11, 2020 9:03 AM
> To: Sun, GuinanX <guinanx....@intel.com>; dev@dpdk.org
> Cc: Sun, GuinanX <guinanx....@intel.com>; sta...@dpdk.org; Guo, Jia
> <jia....@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow
> control
> mode
>
>
> Hi, Guinan
>
> > -----Original Message-----
> > From: dev <dev-boun...@dpdk.org> On Behalf Of Guinan Sun
> > Sent: Friday, May 8, 2020 4:30 PM
> > To: dev@dpdk.org
> > Cc: Sun, GuinanX <guinanx....@intel.com>; sta...@dpdk.org
> > Subject: [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow
> > control mode
> >
> > The register autoneg can't be updated synchronously with flow control
> > mode setting in the state of port start , so NIC statistics error
> > occurs. The patch fixes the issue.
> >
> > Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Guinan Sun <guinanx....@intel.com>
> > ---
> > drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > index cf5f1fe70..e6c747aef 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > @@ -2543,6 +2543,8 @@ ixgbe_flow_ctrl_enable(struct rte_eth_dev *dev,
> > struct ixgbe_hw *hw) int err; uint32_t mflcn;
> >
> > +hw->mac.ops.setup_fc(hw);
>
> 1. please use base code API ixgbe_setup_fc(), do not use internal function
> directly.
> 2. please more info for this patch, what register error you want to fix, and
> why it
> can fix.
V2 patch will be send to resolve the problems.
>
>
> > +
> > err = ixgbe_fc_enable(hw);
> >
> > /* Not negotiated is not an error case */
> > --
> > 2.17.1
>
