Hi Anoob. What's wrong with this test? Is this unit test failing on any PMD now? I've checked on several (QAT, OpenSSL, SW ZUC, SW KASUMI, SW SNOW3G, SCHEDULER) and it passes everywhere. Then why should we remove it completely?
Adam > -----Original Message----- > From: dev <[email protected]> On Behalf Of Anoob Joseph > Sent: Tuesday, 12 May, 2020 09:12 > To: Akhil Goyal <[email protected]>; Doherty, Declan > <[email protected]> > Cc: Anoob Joseph <[email protected]>; Narayana Prasad > <[email protected]>; Ankur Dwivedi <[email protected]>; De Lara > Guarch, Pablo <[email protected]>; [email protected] > Subject: [dpdk-dev] [PATCH] test/crypto: remove tests for unsupported > descriptors > > Cryptodev doesn't limit the number of descriptors that can be supported by > the PMD. > > Signed-off-by: Anoob Joseph <[email protected]> > --- > app/test/test_cryptodev.c | 45 --------------------------------------------- > 1 file changed, 45 deletions(-) > > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index > c624018..1ed2df8 100644 > --- a/app/test/test_cryptodev.c > +++ b/app/test/test_cryptodev.c > @@ -891,36 +891,6 @@ test_queue_pair_descriptor_setup(void) > ts_params->valid_devs[0]); > } > > - /* invalid number of descriptors - max supported + 2 */ > - qp_conf.nb_descriptors = MAX_NUM_OPS_INFLIGHT + 2; > - > - for (qp_id = 0; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) { > - TEST_ASSERT_FAIL(rte_cryptodev_queue_pair_setup( > - ts_params->valid_devs[0], qp_id, &qp_conf, > - rte_cryptodev_socket_id( > - ts_params->valid_devs[0])), > - "Unexpectedly passed test for " > - "rte_cryptodev_queue_pair_setup:" > - "num_inflights %u on qp %u on cryptodev > %u", > - qp_conf.nb_descriptors, qp_id, > - ts_params->valid_devs[0]); > - } > - > - /* invalid number of descriptors - max value of parameter */ > - qp_conf.nb_descriptors = UINT32_MAX-1; > - > - for (qp_id = 0; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) { > - TEST_ASSERT_FAIL(rte_cryptodev_queue_pair_setup( > - ts_params->valid_devs[0], qp_id, &qp_conf, > - rte_cryptodev_socket_id( > - ts_params->valid_devs[0])), > - "Unexpectedly passed test for " > - "rte_cryptodev_queue_pair_setup:" > - "num_inflights %u on qp %u on cryptodev > %u", > - qp_conf.nb_descriptors, qp_id, > - ts_params->valid_devs[0]); > - } > - > qp_conf.nb_descriptors = DEFAULT_NUM_OPS_INFLIGHT; > > for (qp_id = 0; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) { > @@ -935,21 +905,6 @@ test_queue_pair_descriptor_setup(void) > ts_params->valid_devs[0]); > } > > - /* invalid number of descriptors - max supported + 1 */ > - qp_conf.nb_descriptors = DEFAULT_NUM_OPS_INFLIGHT + 1; > - > - for (qp_id = 0; qp_id < ts_params->conf.nb_queue_pairs; qp_id++) { > - TEST_ASSERT_FAIL(rte_cryptodev_queue_pair_setup( > - ts_params->valid_devs[0], qp_id, &qp_conf, > - rte_cryptodev_socket_id( > - ts_params->valid_devs[0])), > - "Unexpectedly passed test for " > - "rte_cryptodev_queue_pair_setup:" > - "num_inflights %u on qp %u on cryptodev > %u", > - qp_conf.nb_descriptors, qp_id, > - ts_params->valid_devs[0]); > - } > - > /* test invalid queue pair id */ > qp_conf.nb_descriptors = DEFAULT_NUM_OPS_INFLIGHT; > /*valid */ > > -- > 2.7.4
