Re: [dpdk-dev] [dpdk-stable] [PATCH] net/i40e: fix flow director initialisation

2020-04-20 Thread Ye Xiaolong
On 04/07, Bernard Iremonger wrote: >Remove references to struct rte_fdir_conf which is deprecated, >in i40e_flow_parse_fdir_filter(), i40e_flow_destroy() and >i40e_flow_add_del_fdir_filter(). > >Fixes: c3be43817cfb ("net/i40e: fix unexpected skip FDIR setup") >Fixes: 2e67a7fbf3ff ("net/i40e: config

Re: [dpdk-dev] [PATCH v6 2/9] net/virtio: enable vectorized path

2020-04-20 Thread Liu, Yong
> -Original Message- > From: Maxime Coquelin > Sent: Monday, April 20, 2020 10:08 PM > To: Liu, Yong ; Ye, Xiaolong ; > Wang, Zhihong > Cc: dev@dpdk.org > Subject: Re: [PATCH v6 2/9] net/virtio: enable vectorized path > > Hi Marvin, > > On 4/17/20 12:24 AM, Marvin Liu wrote: > > Prev

Re: [dpdk-dev] [PATCH v5 0/5] net/iavf: support FDIR capabiltiy

2020-04-20 Thread Ye Xiaolong
On 04/21, Simei Su wrote: >[PATCH v5 1/5] support FDIR common patterns and actions. >[PATCH v5 2/5] support FDIR GTPU pattern. >[PATCH v5 3/5] support FDIR L2TPv3, ESP, AH and NAT-T pattern. >[PATCH v5 4/5] support FDIR PFCP node and session pattern. >[PATCH v5 5/5] support FDIR mark action. > >v5:

Re: [dpdk-dev] [PATCH v3] doc: update flow non-cached mode notes

2020-04-20 Thread Ori Kam
> -Original Message- > From: Bing Zhao > Sent: Tuesday, April 21, 2020 9:08 AM > To: john.mcnam...@intel.com; marko.kovace...@intel.com; Slava Ovsiienko > ; Ori Kam ; Matan Azrad > > Cc: Shahaf Shuler ; Raslan Darawsheh > ; dev@dpdk.org; Thomas Monjalon > > Subject: [PATCH v3] doc: up

Re: [dpdk-dev] [PATCH v2] doc: update hairpin data buffer size config

2020-04-20 Thread Ori Kam
> -Original Message- > From: Bing Zhao > Sent: Tuesday, April 21, 2020 8:33 AM > To: john.mcnam...@intel.com; marko.kovace...@intel.com; Slava Ovsiienko > ; Matan Azrad ; Ori Kam > > Cc: Shahaf Shuler ; Raslan Darawsheh > ; dev@dpdk.org; Thomas Monjalon > > Subject: [PATCH v2] doc: up

[dpdk-dev] [PATCH] cryptodev: add support for user callback functions

2020-04-20 Thread Abhinandan Gujjar
In an eventdev world, multiple workers (with ordered queue) will be working on IPsec ESP processing. The ESP header's sequence number is unique and has to be sequentially incremented in an orderly manner. This rises a need for incrementing sequence number in crypto stage especially in event crypto

[dpdk-dev] [PATCH v5 4/5] net/iavf: add support for FDIR PFCP

2020-04-20 Thread Simei Su
This patch enables PFCP node and sesssion packets with S_FIELD for flow director filter. Signed-off-by: Simei Su Reviewed-by: Qi Zhang --- drivers/net/iavf/iavf_fdir.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/net/iavf/iavf_fdir.c b/drivers/net/iav

[dpdk-dev] [PATCH v5 5/5] net/iavf: add support for FDIR mark action

2020-04-20 Thread Simei Su
This patch enables mark action support and takes mark only case into consideration. Signed-off-by: Simei Su Reviewed-by: Qi Zhang --- drivers/net/iavf/iavf.h | 1 + drivers/net/iavf/iavf_fdir.c | 45 +++- 2 files changed, 45 insertions(+), 1 deletio

[dpdk-dev] [PATCH v5 2/5] net/iavf: add support for FDIR GTPU

2020-04-20 Thread Simei Su
This patch enables GTPU with TEID and QFI for flow director filter. Signed-off-by: Simei Su Reviewed-by: Qi Zhang --- drivers/net/iavf/iavf_fdir.c | 63 1 file changed, 63 insertions(+) diff --git a/drivers/net/iavf/iavf_fdir.c b/drivers/net/iavf/ia

[dpdk-dev] [PATCH v5 1/5] net/iavf: add support for FDIR basic rule

2020-04-20 Thread Simei Su
This patch adds FDIR create/destroy/validate function in AVF. Common pattern and queue/qgroup/passthru/drop actions are supported. Signed-off-by: Simei Su Reviewed-by: Qi Zhang --- doc/guides/rel_notes/release_20_05.rst | 1 + drivers/net/iavf/Makefile | 1 + drivers/net/iavf/i

[dpdk-dev] [PATCH v5 0/5] net/iavf: support FDIR capabiltiy

2020-04-20 Thread Simei Su
[PATCH v5 1/5] support FDIR common patterns and actions. [PATCH v5 2/5] support FDIR GTPU pattern. [PATCH v5 3/5] support FDIR L2TPv3, ESP, AH and NAT-T pattern. [PATCH v5 4/5] support FDIR PFCP node and session pattern. [PATCH v5 5/5] support FDIR mark action. v5: * Do rebase on the newest codes.

[dpdk-dev] [PATCH v5 3/5] net/iavf: add support for FDIR L2TPv3 and IPSec

2020-04-20 Thread Simei Su
This patch enables L2TPv3 with SESSION_ID, ESP/AH with SPI, NAT-T with SPI and IP src/dst for flow director filter. Signed-off-by: Simei Su Reviewed-by: Qi Zhang --- drivers/net/iavf/iavf_fdir.c | 91 1 file changed, 91 insertions(+) diff --git a/dr

Re: [dpdk-dev] [PATCH v3 1/1] virt2phys: virtual to physical address translator for Windows

2020-04-20 Thread Ophir Munk
Hi Dmitry, When trying to test the series under Linux (RedHat 7.4, x86_64-native-linuxapp-gcc) I get compilation errors. I am using make. It seems that there are calls from common which are not compiled under linux. x86_64-native-linuxapp-gcc/lib/librte_eal.a(eal_common_memory.o): In function `e

[dpdk-dev] [PATCH v3] ethdev: support flow aging

2020-04-20 Thread Bill Zhou
From: Dong Zhou One of the reasons to destroy a flow is the fact that no packet matches the flow for "timeout" time. For example, when TCP\UDP sessions are suddenly closed. Currently, there is not any DPDK mechanism for flow aging and the applications use their own ways to detect and destroy age

Re: [dpdk-dev] [PATCH] devtools: skip ABI check in static builds

2020-04-20 Thread Ray Kinsella
On 21/04/2020 02:33, Thomas Monjalon wrote: > When running make with CONFIG_RTE_BUILD_SHARED_LIB=n, > no shared library is built. > In this case, no need to run ABI check. > > With meson, both shared and static libraries are always built. You can easily do the same thing for meson, by checking

[dpdk-dev] [PATCH v3] doc: update flow non-cached mode notes

2020-04-20 Thread Bing Zhao
This patch updates the MLX5 PMD and release notes documentations. Adding the notes of the behavior change that rte flows organization is switched into non-cached mode for applications. Signed-off-by: Bing Zhao --- v2: update the description in release notes. v3: update the notes of rte_flow for a

Re: [dpdk-dev] [RFC] Accelerating Data Movement for DPDK vHost with DMA Engines

2020-04-20 Thread Jerin Jacob
On Tue, Apr 21, 2020 at 8:14 AM Fu, Patrick wrote: > > Hi Jerin Hi Patrick, > > > -Original Message- > > From: Jerin Jacob > > Sent: Monday, April 20, 2020 8:15 PM > > To: Maxime Coquelin > > Cc: Liang, Cunming ; Fu, Patrick > > ; dev@dpdk.org; Ye, Xiaolong > > ; Hu, Jiayu ; Wang, Zhih

Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-04-20 Thread Ray Kinsella
On 20/04/2020 18:37, Thomas Monjalon wrote: > 20/04/2020 19:31, Ray Kinsella: >> >> Our only commitment is to the stability of the v19.11/v20 ABI, until v21. >> >> That said, once an ABI migrates from EXPERIMENTAL to v21, it _shouldn't_ be >> changing. >> We don't have a strict commitment to t

Re: [dpdk-dev] [PATCH v6 33/33] doc: add trace library guide

2020-04-20 Thread Jerin Jacob
On Tue, Apr 21, 2020 at 5:49 AM Thomas Monjalon wrote: > > Hi, > > Below is a doc review. > General comment: it is better to split lines after punctuation signs > in order to make future patches easier to read. Thanks for the review. Except below two comments, Everything else accepted and fixed i

[dpdk-dev] [PATCH v2] doc: update hairpin data buffer size config

2020-04-20 Thread Bing Zhao
This patch updates the MLX5 PMD and release notes documentations. Adding the guideline for hairpin data buffer size configuration. Signed-off-by: Bing Zhao --- v2: update the range description of hairpin data buffer size --- doc/guides/nics/mlx5.rst | 16 doc/guide

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/4] ethdev: add tm support for shaper config in pkt mode

2020-04-20 Thread Nithin Dabilpuram
Ping. On Thu, Apr 16, 2020 at 02:48:49PM +0100, Ferruh Yigit wrote: > External Email > > -- > On 4/11/2020 12:44 PM, Nithin Dabilpuram wrote: > > From: Nithin Dabilpuram > > > > Some NIC hardware support shaper to work in packe

Re: [dpdk-dev] [PATCH 1/4] vhost: inroduce operation to get vDPA queue stats

2020-04-20 Thread Shahaf Shuler
Monday, April 20, 2020 7:19 PM, Maxime Coquelin: > Cc: Slava Ovsiienko > Subject: Re: [PATCH 1/4] vhost: inroduce operation to get vDPA queue stats > > > > On 4/20/20 5:57 PM, Shahaf Shuler wrote: > > Monday, April 20, 2020 10:13 AM, Maxime Coquelin: > >> Subject: Re: [PATCH 1/4] vhost: inroduc

[dpdk-dev] [PATCH] examples/ipsec-secgw: add per core packet stats

2020-04-20 Thread Anoob Joseph
Adding per core packet handling stats to analyze traffic distribution when multiple cores are engaged. Since aggregating the packet stats across cores would affect performance, keeping the feature disabled using compile time flags. Signed-off-by: Anoob Joseph --- examples/ipsec-secgw/ipsec-secg

[dpdk-dev] [PATCH 2/2] net/hns3: get Rx/Tx queue fbd in extend device statistics

2020-04-20 Thread Wei Hu (Xavier)
From: Chengwen Feng This patch adds getting Rx/Tx queue fbd information in extended device statistics. The upper level application can get them by calling the rte_eth_xstats_get API function. The fbd registers of every Rx/Tx queue are very useful to identify the Rx/Tx bottleneck. 1. The Rx queue

[dpdk-dev] [PATCH 0/2] updates for hns3 PMD driver

2020-04-20 Thread Wei Hu (Xavier)
This series are updates for hns3 PMD driver. Chengwen Feng (1): net/hns3: get Rx/Tx queue fbd in extend device statistics Wei Hu (Xavier) (1): net/hns3: modify the format for firmware version drivers/net/hns3/hns3_cmd.c | 14 ++- drivers/net/hns3/hns3_cmd.h | 8 ++ drivers/ne

[dpdk-dev] [PATCH 1/2] net/hns3: modify the format for firmware version

2020-04-20 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch modifies the print format for firmware version in the log, It replaces "0x%08x" with "%lu.%lu.%lu.%lu" in the format control string. By the way, this patch adds ".fw_version_get" ops implemation for hns3 VF PMD driver. Signed-off-by: Wei Hu (Xavier) --- drive

[dpdk-dev] [PATCH] lib/rte_eal: fix heap-use-after-free bug

2020-04-20 Thread Wei Hu (Xavier)
From: "Wei Hu (Xavier)" This patch fixes the heap-use-after-free bug which was found by ASAN (Address-Sanitizer) in the vfio_get_default_container_fd function. Fixes: 6bcb7c95fe14 ("vfio: share default container in multi-process") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Signed-off-by:

Re: [dpdk-dev] [PATCH v1] net/ice: check the DSN package file firstly

2020-04-20 Thread Ye Xiaolong
On 04/16, Haiyue Wang wrote: >Align the package file search sequence with PF only for DCF mode. Get >the DSN through the virtual channel firstly to check the package file >accessible. > >Signed-off-by: Haiyue Wang >--- > drivers/net/ice/ice_dcf_parent.c | 30 ++ > 1 file

Re: [dpdk-dev] [PATCH v6 00/11] framework for advanced iAVF PMD

2020-04-20 Thread Ye Xiaolong
On 04/20, Leyi Rong wrote: >This patchset enable framework for advanced iAVF, includes >flexible descriptor support, FDIR mark id and RSS hash support. > >--- >v6: >- Remove some redundant code which may cause ICC build error. > >v5: >- Set rxdid = 0 in iavf_configure_queues() when it's supported a

Re: [dpdk-dev] [PATCH] mem: fix the alloc size roundup overflow

2020-04-20 Thread Bing Zhao
> -Original Message- > From: Burakov, Anatoly > Sent: Monday, April 20, 2020 7:40 PM > To: Bing Zhao > Cc: dev@dpdk.org; sergio.gonzalez.mon...@intel.com; > sta...@dpdk.org > Subject: Re: [PATCH] mem: fix the alloc size roundup overflow > > On 07-Apr-20 11:46 AM, Bing Zhao wrote: > > The

Re: [dpdk-dev] [PATCH v8 0/2] support for VFIO-PCI VF token interface

2020-04-20 Thread Wang, Haiyue
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, April 21, 2020 10:13 > To: David Marchand ; Wang, Haiyue > > Cc: Neil Horman ; dev ; Burakov, Anatoly > ; Vamsi Attunuru ; Jerin > Jacob Kollanukkaran > ; Yigit, Ferruh ; Richardson, > Bruce > ; Kinsella, Ray > Subject: Re:

Re: [dpdk-dev] [PATCH] net/ixgbe: fix link status after port reset

2020-04-20 Thread Wang, ShougangX
Hi, Xiaolong > -Original Message- > From: Ye, Xiaolong > Sent: Tuesday, April 14, 2020 3:54 PM > To: Wang, ShougangX > Cc: dev@dpdk.org; Lu, Wenzhuo ; Yang, Qiming > ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix link status after port reset > > Hi, Shougang > > On

Re: [dpdk-dev] [RFC] Accelerating Data Movement for DPDK vHost with DMA Engines

2020-04-20 Thread Fu, Patrick
Hi Jerin > -Original Message- > From: Jerin Jacob > Sent: Monday, April 20, 2020 8:15 PM > To: Maxime Coquelin > Cc: Liang, Cunming ; Fu, Patrick > ; dev@dpdk.org; Ye, Xiaolong > ; Hu, Jiayu ; Wang, Zhihong > > Subject: Re: [dpdk-dev] [RFC] Accelerating Data Movement for DPDK vHost > wi

Re: [dpdk-dev] [PATCH v4] test/ipsec: measure libipsec performance

2020-04-20 Thread Thomas Monjalon
21/04/2020 04:29, Thomas Monjalon: > 06/03/2020 08:08, Savinay Dharmappa: > > test app to measures the performance of libipsec > > api rte_ipsec_pkt_crypto and rte_ipsec_pkt_process. > > Please make sentences in commit logs. > > > Signed-off-by: Savinay Dharmappa > > Acked-by: Konstantin Ananyev

Re: [dpdk-dev] [PATCH v4] test/ipsec: measure libipsec performance

2020-04-20 Thread Thomas Monjalon
06/03/2020 08:08, Savinay Dharmappa: > test app to measures the performance of libipsec > api rte_ipsec_pkt_crypto and rte_ipsec_pkt_process. Please make sentences in commit logs. > Signed-off-by: Savinay Dharmappa > Acked-by: Konstantin Ananyev > --- > --- a/MAINTAINERS > +++ b/MAINTAINERS > @

Re: [dpdk-dev] [PATCH v8 0/2] support for VFIO-PCI VF token interface

2020-04-20 Thread Thomas Monjalon
21/04/2020 03:38, Wang, Haiyue: > From: Thomas Monjalon > > 20/04/2020 19:37, Wang, Haiyue: > > > From: Thomas Monjalon > > > > 20/04/2020 19:02, Wang, Haiyue: > > > > > From: David Marchand > > > > > > I had a look at the CI, I can see we are still missing bits to > > > > > > handle > > > > >

[dpdk-dev] [PATCH] devtools: remove useless files from ABI reference

2020-04-20 Thread Thomas Monjalon
When building an ABI reference with meson, some static libraries are built and linked in apps. They are useless and take a lot of space. Those binaries, and other useless files (examples and doc files) in the share/ directory, are removed after being installed. In order to save time when building

Re: [dpdk-dev] [PATCH v8 0/2] support for VFIO-PCI VF token interface

2020-04-20 Thread Wang, Haiyue
Hi Thomas & David, > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, April 21, 2020 01:43 > To: Wang, Haiyue > Cc: Neil Horman ; David Marchand > ; dev > ; Burakov, Anatoly ; Vamsi Attunuru > ; > Jerin Jacob Kollanukkaran ; Alex Williamson > > Subject: Re: [PATCH v8 0/2]

[dpdk-dev] [PATCH] devtools: skip ABI check in static builds

2020-04-20 Thread Thomas Monjalon
When running make with CONFIG_RTE_BUILD_SHARED_LIB=n, no shared library is built. In this case, no need to run ABI check. With meson, both shared and static libraries are always built. Signed-off-by: Thomas Monjalon --- devtools/test-build.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/

Re: [dpdk-dev] [PATCH] app/testpmd: configure rxd and txd number correctly

2020-04-20 Thread oulijun
在 2020/4/20 21:29, Ferruh Yigit 写道: On 4/18/2020 3:30 AM, oulijun wrote: 在 2020/4/18 8:42, Ferruh Yigit 写道: On 4/17/2020 11:59 AM, Lijun Ou wrote: When users configure rxds and txds by used port config cmd based on testpmd application, it will not be able to configure rxd and txd accordin

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-20 Thread Ananyev, Konstantin
> > > > > > >> I am agree with Cristian concern here: that patch removes > > > > > > >> ability to > > > > > > >> enable/disable debug on particular library/PMD. If the purpose > > > > > > >> is to > > > > > > >> minimize number of config compile options, I wonder can't it be > > > > > > >>

[dpdk-dev] [PATCH v2] devtools: reduce examples in static builds

2020-04-20 Thread Thomas Monjalon
Static builds can take a lot of space, so reduce the number of examples built when testing those static builds. As makefile-based build is close to end of life, completely skip examples in case of static linkage with make. Signed-off-by: Thomas Monjalon --- v2: invert logic with meson because s

Re: [dpdk-dev] [PATCH v6 33/33] doc: add trace library guide

2020-04-20 Thread Thomas Monjalon
Hi, Below is a doc review. General comment: it is better to split lines after punctuation signs in order to make future patches easier to read. 19/04/2020 12:01, jer...@marvell.com: > +DPDK tracing library features > +- > + > +- A framework to add tracepoints in contro

[dpdk-dev] [PATCH] app: fix usage help of options separated by dashes

2020-04-20 Thread Thomas Monjalon
The EAL options and app-specific options are separated with double dashes. The help of testpmd, test-acl and pdump were missing the dashes after EAL options. Note: testpmd was completely missing the EAL options. Fixes: af75078fece3 ("first public release") Fixes: 26c057ab6c45 ("acl: new test-acl

[dpdk-dev] [PATCH v6 1/3] ip_frag: ensure minimum v4 fragmentation length

2020-04-20 Thread Aaron Conole
Do a formal parameter check of mtu length, as well as checking the the various inputs for validity. If any aren't acceptable, we bail. Acked-by: Konstantin Ananyev Acked-by: Lukasz Wojciechowski Signed-off-by: Aaron Conole --- lib/librte_ip_frag/rte_ipv4_fragmentation.c | 10 ++ 1 fil

[dpdk-dev] [PATCH v6 0/3] ip_frag: add a unit test for fragmentation

2020-04-20 Thread Aaron Conole
This adds a simple unit test for the ip fragmentation library and covers fragmenting ipv4 and ipv6. Additionally, some fixes are introduced, which are really just sanity rather than real issues in the field. v5->v6: - Coding style fixes - Use named defines instead of bare MTU decimal values. v4-

[dpdk-dev] [PATCH v6 3/3] ipfrag: add unit test case

2020-04-20 Thread Aaron Conole
Initial IP fragmentation unit test. Signed-off-by: Aaron Conole --- MAINTAINERS| 1 + app/test/meson.build | 2 + app/test/test_ipfrag.c | 262 + 3 files changed, 265 insertions(+) create mode 100644 app/test/test_ipfrag.c diff --git a/

[dpdk-dev] [PATCH v6 2/3] ip_frag: ensure minimum v6 fragmentation length

2020-04-20 Thread Aaron Conole
In addition, do a formal parameter check. Acked-by: Konstantin Ananyev Acked-by: Lukasz Wojciechowski Signed-off-by: Aaron Conole --- lib/librte_ip_frag/rte_ipv6_fragmentation.c | 9 + lib/librte_net/rte_ip.h | 2 ++ 2 files changed, 11 insertions(+) diff --git a/l

[dpdk-dev] [PATCH v3] examples/ipsec-secgw: remove limitation for crypto sessions

2020-04-20 Thread Vladimir Medvedkin
Get rid of hardcoded limit of cryptodev sessions. Fixes: e1143d7dbbf4 ("examples/ipsec-secgw: get rid of maximum SA limitation") Cc: vladimir.medved...@intel.com Signed-off-by: Vladimir Medvedkin --- examples/ipsec-secgw/ipsec-secgw.c | 25 +++-- examples/ipsec-secgw/ipsec.h

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-20 Thread Bruce Richardson
On Mon, Apr 20, 2020 at 07:35:36PM +0200, Thomas Monjalon wrote: > 20/04/2020 19:30, Bruce Richardson: > > On Mon, Apr 20, 2020 at 07:21:32PM +0200, Thomas Monjalon wrote: > > > 20/04/2020 19:11, Bruce Richardson: > > > > On Mon, Apr 20, 2020 at 04:43:21PM +0200, Lukasz Wojciechowski wrote: > > > >

[dpdk-dev] [PATCH v3] ipsec: use hash lookup with hash sigs in sad lookup

2020-04-20 Thread Vladimir Medvedkin
Change hash function from jhash to crc. Precalculate hash signatures for a bulk of keys and then use rte_hash_lookup_with_hash_bulk_data() to speed up sad lookup Also use rte_hash_add_key_with_hash and _del_key_with_hash with precalculated hash signature for a key in rte_ipsec_sad_add and rte_ipsec

Re: [dpdk-dev] [PATCH v8 0/2] support for VFIO-PCI VF token interface

2020-04-20 Thread Thomas Monjalon
20/04/2020 19:37, Wang, Haiyue: > From: Thomas Monjalon > > 20/04/2020 19:02, Wang, Haiyue: > > > From: David Marchand > > > > I had a look at the CI, I can see we are still missing bits to handle > > > > the ABI failure on rte_vfio_setup_device. > > > > > > Yes, not handle it now. > > > > > > If

Re: [dpdk-dev] rte_vfio_container_dma_map/unmap functions

2020-04-20 Thread Thomas Monjalon
20/04/2020 16:07, Burakov, Anatoly: > On 19-Apr-20 2:10 PM, Thomas Monjalon wrote: > > 19/04/2020 15:09, Thomas Monjalon: > >> 17/04/2020 16:09, Burakov, Anatoly: > >>> On 17-Apr-20 3:05 PM, Burakov, Anatoly wrote: > On 22-Mar-20 5:20 PM, Tal Shnaiderman wrote: > > Hi Anatoly, > > > >>

Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-04-20 Thread Thomas Monjalon
20/04/2020 19:31, Ray Kinsella: > > Our only commitment is to the stability of the v19.11/v20 ABI, until v21. > > That said, once an ABI migrates from EXPERIMENTAL to v21, it _shouldn't_ be > changing. > We don't have a strict commitment to the v21 ABI until v20.11. > > However if v21 is chang

Re: [dpdk-dev] [PATCH v8 0/2] support for VFIO-PCI VF token interface

2020-04-20 Thread Wang, Haiyue
+Neil, > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, April 21, 2020 01:13 > To: Wang, Haiyue > Cc: David Marchand ; dev ; Burakov, > Anatoly > ; Vamsi Attunuru ; Jerin > Jacob Kollanukkaran > ; Alex Williamson > Subject: Re: [PATCH v8 0/2] support for VFIO-PCI VF token

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-20 Thread Thomas Monjalon
20/04/2020 19:30, Bruce Richardson: > On Mon, Apr 20, 2020 at 07:21:32PM +0200, Thomas Monjalon wrote: > > 20/04/2020 19:11, Bruce Richardson: > > > On Mon, Apr 20, 2020 at 04:43:21PM +0200, Lukasz Wojciechowski wrote: > > > > W dniu 20.04.2020 o 16:21, Bruce Richardson pisze: > > > > > On Mon, Apr

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-20 Thread Lukasz Wojciechowski
W dniu 20.04.2020 o 19:30, Bruce Richardson pisze: > On Mon, Apr 20, 2020 at 07:21:32PM +0200, Thomas Monjalon wrote: >> 20/04/2020 19:11, Bruce Richardson: >>> On Mon, Apr 20, 2020 at 04:43:21PM +0200, Lukasz Wojciechowski wrote: W dniu 20.04.2020 o 16:21, Bruce Richardson pisze: > On M

Re: [dpdk-dev] [PATCH v5 3/3] ipfrag: add unit test case

2020-04-20 Thread Aaron Conole
"Burakov, Anatoly" writes: > On 17-Apr-20 2:14 PM, Aaron Conole wrote: >> Initial IP fragmentation unit test. >> >> Signed-off-by: Aaron Conole >> --- > > > >> +if (!pkt_pool) >> +pkt_pool = rte_pktmbuf_pool_create("FRAG_MBUF_POOL", >> +

Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-04-20 Thread Ray Kinsella
Our only commitment is to the stability of the v19.11/v20 ABI, until v21. That said, once an ABI migrates from EXPERIMENTAL to v21, it _shouldn't_ be changing. We don't have a strict commitment to the v21 ABI until v20.11. However if v21 is changing across quarterlies (outside of additions) .

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-20 Thread Bruce Richardson
On Mon, Apr 20, 2020 at 07:21:32PM +0200, Thomas Monjalon wrote: > 20/04/2020 19:11, Bruce Richardson: > > On Mon, Apr 20, 2020 at 04:43:21PM +0200, Lukasz Wojciechowski wrote: > > > > > > W dniu 20.04.2020 o 16:21, Bruce Richardson pisze: > > > > On Mon, Apr 20, 2020 at 01:37:12PM +, Ananyev,

Re: [dpdk-dev] [PATCH v3] cryptodev: version cryptodev info get function

2020-04-20 Thread Ray Kinsella
On 20/04/2020 17:54, Trahe, Fiona wrote: > Hi Ray, Akhil, > > >> On 20/04/2020 15:22, Akhil Goyal wrote: >>> >>> This patch adds versioned function rte_cryptodev_info_get() to prevent some issues with ABI policy. Node v21 works in same way as before, returning driver capabi

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-20 Thread Bruce Richardson
On Mon, Apr 20, 2020 at 06:11:30PM +0100, Bruce Richardson wrote: > On Mon, Apr 20, 2020 at 04:43:21PM +0200, Lukasz Wojciechowski wrote: > > > > W dniu 20.04.2020 o 16:21, Bruce Richardson pisze: > > > On Mon, Apr 20, 2020 at 01:37:12PM +, Ananyev, Konstantin wrote: > > >>> > > > >> I am agr

Re: [dpdk-dev] [PATCH v3] cryptodev: version cryptodev info get function

2020-04-20 Thread Ray Kinsella
On 20/04/2020 17:54, Trahe, Fiona wrote: > Hi Ray, Akhil, > > >> On 20/04/2020 15:22, Akhil Goyal wrote: >>> >>> This patch adds versioned function rte_cryptodev_info_get() to prevent some issues with ABI policy. Node v21 works in same way as before, returning driver capabi

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-20 Thread Thomas Monjalon
20/04/2020 19:11, Bruce Richardson: > On Mon, Apr 20, 2020 at 04:43:21PM +0200, Lukasz Wojciechowski wrote: > > > > W dniu 20.04.2020 o 16:21, Bruce Richardson pisze: > > > On Mon, Apr 20, 2020 at 01:37:12PM +, Ananyev, Konstantin wrote: > > >>> > > > >> I am agree with Cristian concern here:

Re: [dpdk-dev] [PATCH v8 0/2] support for VFIO-PCI VF token interface

2020-04-20 Thread Thomas Monjalon
20/04/2020 19:02, Wang, Haiyue: > From: David Marchand > > > > Hello, > > > > On Sat, Apr 18, 2020 at 7:36 PM Haiyue Wang wrote: > > > > > > v8: Update the document. > > > > Thanks for the last version. > > I had a look at the CI, I can see we are still missing bits to handle > > the ABI failu

Re: [dpdk-dev] [PATCH v8 2/2] eal: support for VFIO-PCI VF token

2020-04-20 Thread Thomas Monjalon
Hi, A general comment, please try to limit line length (80 is a good limit), and prefer breaking lines after a punctuation sign. Try shortening sentences as well. I would love seeing some documentation reviews from english native speakers. 18/04/2020 19:30, Haiyue Wang: > --- a/doc/guides/linux_

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-20 Thread Bruce Richardson
On Mon, Apr 20, 2020 at 04:43:21PM +0200, Lukasz Wojciechowski wrote: > > W dniu 20.04.2020 o 16:21, Bruce Richardson pisze: > > On Mon, Apr 20, 2020 at 01:37:12PM +, Ananyev, Konstantin wrote: > >>> > >> I am agree with Cristian concern here: that patch removes ability to > >> enable/disable

Re: [dpdk-dev] [PATCH v8 0/2] support for VFIO-PCI VF token interface

2020-04-20 Thread Wang, Haiyue
> -Original Message- > From: David Marchand > Sent: Tuesday, April 21, 2020 00:53 > To: Wang, Haiyue > Cc: dev ; Burakov, Anatoly ; Thomas > Monjalon > ; Vamsi Attunuru ; Jerin Jacob > Kollanukkaran > ; Alex Williamson > Subject: Re: [PATCH v8 0/2] support for VFIO-PCI VF token interfa

Re: [dpdk-dev] [PATCH] cryptodev: version rte_cryptodev_info_get function

2020-04-20 Thread Trahe, Fiona
Gentle reminder that we still haven't come to a consensus about whether ABI compatibility is required across quarterly releases or not. See below. > -Original Message- > From: Trahe, Fiona > Sent: Friday, April 17, 2020 12:47 PM > To: Ray Kinsella ; Thomas Monjalon ; > Richardson, Bruce

Re: [dpdk-dev] [PATCH v3] cryptodev: version cryptodev info get function

2020-04-20 Thread Trahe, Fiona
Hi Ray, Akhil, > On 20/04/2020 15:22, Akhil Goyal wrote: > > > > > >> > >> This patch adds versioned function rte_cryptodev_info_get() > >> to prevent some issues with ABI policy. > >> Node v21 works in same way as before, returning driver capabilities > >> directly to the API caller. These capab

Re: [dpdk-dev] [PATCH v8 0/2] support for VFIO-PCI VF token interface

2020-04-20 Thread David Marchand
Hello, On Sat, Apr 18, 2020 at 7:36 PM Haiyue Wang wrote: > > v8: Update the document. Thanks for the last version. I had a look at the CI, I can see we are still missing bits to handle the ABI failure on rte_vfio_setup_device. -- David Marchand

Re: [dpdk-dev] [PATCH v3] eal/ppc64: improve rte_rdtsc() with __ppc_get_timebase()

2020-04-20 Thread David Christensen
On 3/24/20 5:13 PM, Thinh Tran wrote: __ppc_get_timebase() reads and returns the current value of the Time Base Register. It's more efficient as it uses the processor’s time base facility directly the DPDK on FreeBSD currently is not supported on Powerpc64, it should be safe to

Re: [dpdk-dev] [PATCH 1/4] vhost: inroduce operation to get vDPA queue stats

2020-04-20 Thread Maxime Coquelin
On 4/20/20 5:57 PM, Shahaf Shuler wrote: > Monday, April 20, 2020 10:13 AM, Maxime Coquelin: >> Subject: Re: [PATCH 1/4] vhost: inroduce operation to get vDPA queue stats >> >> Hi Shahaf, >> >> On 4/19/20 8:18 AM, Shahaf Shuler wrote: >>> Thursday, April 16, 2020 4:20 PM, Maxime Coquelin: S

Re: [dpdk-dev] [PATCH v2] ethdev: support flow aging

2020-04-20 Thread Thomas Monjalon
20/04/2020 16:06, Ferruh Yigit: > On 4/18/2020 10:44 AM, Thomas Monjalon wrote: > > 18/04/2020 07:04, Bill Zhou: > >> From: Ferruh Yigit > >>> On 4/14/2020 9:32 AM, Dong Zhou wrote: > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -3015,6 +3015,7 @@

[dpdk-dev] [PATCH v2] lib/timer: relax barrier for status update

2020-04-20 Thread Phil Yang
Volatile has no ordering semantics. The rte_timer structure defines timer status as a volatile variable and uses the rte_r/wmb barrier to guarantee inter-thread visibility. This patch optimized the volatile operation with c11 atomic operations and one-way barrier to save the performance penalty. A

Re: [dpdk-dev] [PATCH v5 3/3] ipfrag: add unit test case

2020-04-20 Thread Burakov, Anatoly
On 17-Apr-20 2:14 PM, Aaron Conole wrote: Initial IP fragmentation unit test. Signed-off-by: Aaron Conole --- + if (!pkt_pool) + pkt_pool = rte_pktmbuf_pool_create("FRAG_MBUF_POOL", + NUM_MBUFS, BURST, 0, +

Re: [dpdk-dev] [PATCH] eal: add madvise to avoid dump memory

2020-04-20 Thread Feng Li
Thank you, Marchand, I have just tested your patch, and it doesn't work. The core dump file is still very very large, the same to virtual memory size. David Marchand 于2020年4月20日周一 下午3:13写道: > > On Mon, Apr 20, 2020 at 9:10 AM Li Feng wrote: > > Li Feng 于2020年4月20日周一 下午3:04写道: > > > > > > Avoid

Re: [dpdk-dev] [PATCH 1/4] vhost: inroduce operation to get vDPA queue stats

2020-04-20 Thread Shahaf Shuler
Monday, April 20, 2020 10:13 AM, Maxime Coquelin: > Subject: Re: [PATCH 1/4] vhost: inroduce operation to get vDPA queue stats > > Hi Shahaf, > > On 4/19/20 8:18 AM, Shahaf Shuler wrote: > > Thursday, April 16, 2020 4:20 PM, Maxime Coquelin: > >> Subject: Re: [PATCH 1/4] vhost: inroduce operation

Re: [dpdk-dev] [PATCH v2 2/4] regexdev: add regex core h file

2020-04-20 Thread Ori Kam
Hi, Nice catch. Best, Ori > -Original Message- > From: dev On Behalf Of Guy Kaneti > Sent: Monday, April 20, 2020 1:48 PM > To: Ori Kam ; Jerin Jacob Kollanukkaran > ; xiang.w.w...@intel.com > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > ; Shahaf Shuler ; > hemant.agra...@nxp.com; Op

Re: [dpdk-dev] [PATCH v5 2/3] ip_frag: ensure minimum v6 fragmentation length

2020-04-20 Thread Ananyev, Konstantin
> >> In addition, do a formal parameter check. > >> > >> Acked-by: Lukasz Wojciechowski > >> Signed-off-by: Aaron Conole > >> --- > >> lib/librte_ip_frag/rte_ipv6_fragmentation.c | 9 + > >> 1 file changed, 9 insertions(+) > >> > >> diff --git a/lib/librte_ip_frag/rte_ipv6_fragmentation.

Re: [dpdk-dev] [PATCH] ci: remove aarch64 from Travis jobs

2020-04-20 Thread Ruifeng Wang
> -Original Message- > From: David Marchand > Sent: Sunday, April 19, 2020 4:01 PM > To: Honnappa Nagarahalli ; Ruifeng Wang > > Cc: tho...@monjalon.net; Aaron Conole ; dev > ; Gavin Hu ; Michael Santana > ; nd > Subject: Re: [PATCH] ci: remove aarch64 from Travis jobs > > Honnappa, Ru

[dpdk-dev] [PATCH] app/testpmd: add parsing for multiple VLAN headers

2020-04-20 Thread Raslan Darawsheh
When having multiple VLANs in the packet, parse_ethernet is cabable of parsing only the first vlan. add parsing for mutliple VLAN headers in the packet. Fixes: 51f694dd40f5 ("app/testpmd: rework checksum forward engine") Cc: sta...@dpdk.org Signed-off-by: Raslan Darawsheh --- app/test-pmd/csum

Re: [dpdk-dev] [PATCH v5 2/3] ip_frag: ensure minimum v6 fragmentation length

2020-04-20 Thread Aaron Conole
"Ananyev, Konstantin" writes: >> >> In addition, do a formal parameter check. >> >> Acked-by: Lukasz Wojciechowski >> Signed-off-by: Aaron Conole >> --- >> lib/librte_ip_frag/rte_ipv6_fragmentation.c | 9 + >> 1 file changed, 9 insertions(+) >> >> diff --git a/lib/librte_ip_frag/rte

Re: [dpdk-dev] [PATCH] abi: change references to abi 20.0.1 to abi v21

2020-04-20 Thread Ray Kinsella
On 20/04/2020 13:20, David Marchand wrote: > On Mon, Apr 20, 2020 at 1:57 PM Ray Kinsella wrote: >> >> Travis ABI check warnings, can be safely ignored in this case, I think. >> >> https://travis-ci.com/github/ovsrobot/dpdk/builds/161009923 > > How about comparing to 19.11 ABI then? Theory is

Re: [dpdk-dev] [PATCH v5 1/3] ip_frag: ensure minimum v4 fragmentation length

2020-04-20 Thread Aaron Conole
"Ananyev, Konstantin" writes: > >> Do a formal parameter check of mtu length, as well as >> checking the the various inputs for validity. If any >> aren't acceptable, we bail. >> >> Acked-by: Lukasz Wojciechowski >> Signed-off-by: Aaron Conole >> --- >> lib/librte_ip_frag/rte_ipv4_fragment

Re: [dpdk-dev] [PATCH v3] cryptodev: version cryptodev info get function

2020-04-20 Thread Ray Kinsella
On 20/04/2020 15:22, Akhil Goyal wrote: > > >> >> This patch adds versioned function rte_cryptodev_info_get() >> to prevent some issues with ABI policy. >> Node v21 works in same way as before, returning driver capabilities >> directly to the API caller. These capabilities may include new elem

Re: [dpdk-dev] [PATCH v2 00/16] update and simplifytelemetrylibrary.

2020-04-20 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Monday, April 20, 2020 3:19 PM > > On Fri, Apr 10, 2020 at 08:06:23PM +0200, Morten Brørup wrote: > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wiles, Keith > > > Sent: Friday, April 10, 2020 4:22 PM > > >

Re: [dpdk-dev] [PATCH v2 2/2] net/i40e: restrict pointer aliasing for NEON vPMD

2020-04-20 Thread Ferruh Yigit
On 4/13/2020 4:56 PM, Gavin Hu wrote: > restrict pointer aliasing to optimize the code generated. > > The patch showed ~3% performnace uplift on Arm N1SDP platform, and no > degradation on ThunderX2. The tet case is RFC2544 zero-loss L2 > forwarding running testpmd. > > [1] https://gcc.gnu.org/on

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-20 Thread Lukasz Wojciechowski
W dniu 20.04.2020 o 16:21, Bruce Richardson pisze: > On Mon, Apr 20, 2020 at 01:37:12PM +, Ananyev, Konstantin wrote: >>> >>> -Original Message- From: Lukasz Wojciechowski Sent: Friday, April 17, 2020 10:57 PM To: Thomas Monjalon ; Igor Russkikh ; Pavel Belou

[dpdk-dev] [pull-request] next-crypto 20.05 rc1

2020-04-20 Thread Akhil Goyal
ci: reduce examples in static builds (2020-04-17 23:34:08 +0200) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-crypto for you to fetch changes up to b1419a24f94419e99f1f50d398b903df00525271: test/ipsec: measure libipsec performance (2020-04-20 02:51:05 +0530)

Re: [dpdk-dev] [PATCH v3] cryptodev: version cryptodev info get function

2020-04-20 Thread Akhil Goyal
> > This patch adds versioned function rte_cryptodev_info_get() > to prevent some issues with ABI policy. > Node v21 works in same way as before, returning driver capabilities > directly to the API caller. These capabilities may include new elements > not part of the v20 ABI. > Node v20 functio

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-20 Thread Bruce Richardson
On Mon, Apr 20, 2020 at 01:37:12PM +, Ananyev, Konstantin wrote: > > > > > > > > > -Original Message- > > > From: Lukasz Wojciechowski > > > Sent: Friday, April 17, 2020 10:57 PM > > > To: Thomas Monjalon ; Igor Russkikh > > > ; Pavel Belous ; > > > Lu, Wenzhuo ; Marcin Wojtas > > >

Re: [dpdk-dev] [PATCH] librte_eal: add APIs to speedup virt2iova/phys

2020-04-20 Thread Li Feng
Cool, thank you, Anatoly and Kozlyuk. I haven't found how Windows implements the rte_mem_virt2phy. Using an opaque structure pointer as the first argument is a good idea. Thanks, Feng Li Dmitry Kozlyuk 于2020年4月20日周一 下午9:07写道: > > > On 20-Apr-20 12:09 PM, Li Feng wrote: > > > Using pread to re

Re: [dpdk-dev] [PATCH v6 2/9] net/virtio: enable vectorized path

2020-04-20 Thread Maxime Coquelin
Hi Marvin, On 4/17/20 12:24 AM, Marvin Liu wrote: > Previously, virtio split ring vectorized path is enabled as default. > This is not suitable for everyone because of that path not follow virtio > spec. Add new config for virtio vectorized path selection. By default > vectorized path is enabled.

Re: [dpdk-dev] rte_vfio_container_dma_map/unmap functions

2020-04-20 Thread Burakov, Anatoly
On 19-Apr-20 2:10 PM, Thomas Monjalon wrote: 19/04/2020 15:09, Thomas Monjalon: 17/04/2020 16:09, Burakov, Anatoly: On 17-Apr-20 3:05 PM, Burakov, Anatoly wrote: On 22-Mar-20 5:20 PM, Tal Shnaiderman wrote: Hi Anatoly, I’m working on the implementation of bus/pci driver for Windows, pci_comm

Re: [dpdk-dev] [PATCH v6 10/10] doc: update ring guide

2020-04-20 Thread Ananyev, Konstantin
> > On Mon, Apr 20, 2020 at 2:12 PM Konstantin Ananyev > wrote: > > > > Changed the rte_ring chapter in programmer's guide to reflect > > the addition of new sync modes and peek style API. > > I'd like to split this as follows, see below. > I have a couple of typos too. > > > If you are fine

Re: [dpdk-dev] [PATCH v2] ethdev: support flow aging

2020-04-20 Thread Ferruh Yigit
On 4/18/2020 10:44 AM, Thomas Monjalon wrote: > 18/04/2020 07:04, Bill Zhou: >> From: Ferruh Yigit >>> On 4/14/2020 9:32 AM, Dong Zhou wrote: --- a/lib/librte_ethdev/rte_ethdev.h +++ b/lib/librte_ethdev/rte_ethdev.h @@ -3015,6 +3015,7 @@ enum rte_eth_event_type { RTE_ETH_EVE

Re: [dpdk-dev] [PATCH v6 10/10] doc: update ring guide

2020-04-20 Thread David Marchand
On Mon, Apr 20, 2020 at 2:12 PM Konstantin Ananyev wrote: > > Changed the rte_ring chapter in programmer's guide to reflect > the addition of new sync modes and peek style API. I'd like to split this as follows, see below. I have a couple of typos too. If you are fine with it, I'll proceed and

Re: [dpdk-dev] [PATCH v1 03/17] ethdev: replace library debug flag with global one

2020-04-20 Thread Ananyev, Konstantin
> > > > > -Original Message- > > From: Lukasz Wojciechowski > > Sent: Friday, April 17, 2020 10:57 PM > > To: Thomas Monjalon ; Igor Russkikh > > ; Pavel Belous ; > > Lu, Wenzhuo ; Marcin Wojtas > > ; Michal Krawczyk ; Guy Tzalik > > ; Evgeny Schemeilin ; Igor > > Chauskin ; John Daley

Re: [dpdk-dev] [PATCH] app/testpmd: configure rxd and txd number correctly

2020-04-20 Thread Ferruh Yigit
On 4/18/2020 3:30 AM, oulijun wrote: > > > 在 2020/4/18 8:42, Ferruh Yigit 写道: >> On 4/17/2020 11:59 AM, Lijun Ou wrote: >>> When users configure rxds and txds by used port config cmd based >>> on testpmd application, it will not be able to configure rxd and >>> txd according to the max capability

  1   2   >