21/04/2020 03:38, Wang, Haiyue: > From: Thomas Monjalon <tho...@monjalon.net> > > 20/04/2020 19:37, Wang, Haiyue: > > > From: Thomas Monjalon <tho...@monjalon.net> > > > > 20/04/2020 19:02, Wang, Haiyue: > > > > > From: David Marchand <david.march...@redhat.com> > > > > > > I had a look at the CI, I can see we are still missing bits to > > > > > > handle > > > > > > the ABI failure on rte_vfio_setup_device. > > > > > > > > > > Yes, not handle it now. > > > > > > > > > > If 'rte_vfio_setup_device' can be internal, not official DPDK API, > > > > > then __rte_internal > > > > > is the best way to handle ABI issue. > > > > > > > > Please could you help finishing integration of __rte_internal? > > > > > > I thought it should be Neil ? "Yes, I'll get back to this today" ;-) > > > http://inbox.dpdk.org/dev/cajfav8ydlkv0afehqbh6kea3box0yxb3n0mngtmd4s9bmsg...@mail.gmail.com/ > > > > It did not happen after several months. > > If you want to unblock your patches, I think it is safer to finish yourself. > > > > Unfortunately, this __rte_internal will still make the ci fail to run when > move the function > to INTERNAL session: [...] > +INTERNAL { > + global: > + > + # added in 20.05 > + rte_vfio_setup_device; > +};
Why do you need to move the symbol explicitly in .map? The tool should ignore symbols moving to internal, as an exception until 20.11.
