Re: [dpdk-dev] [PATCHv2] Remove validate-abi.sh from tree

2020-04-09 Thread Ray Kinsella
On 09/04/2020 17:51, Thomas Monjalon wrote: > 09/04/2020 18:29, Ray Kinsella: >> On 09/04/2020 16:18, Thomas Monjalon wrote: >>> 09/04/2020 16:52, Ray Kinsella: On 09/04/2020 11:59, Thomas Monjalon wrote: > 09/04/2020 12:45, Ray Kinsella: >> On 09/04/2020 11:43, Bruce Richardson wro

[dpdk-dev] [PATCH v2] net/ixgbe: fix resource leak after thread exits normally

2020-04-09 Thread taox . zhu
From: Zhu Tao When the thread exits normally, pthread_join() is not called, which can result in a resource leak. Therefore, the thread is set to separation mode using function pthread_detach(), so that no program call pthread_join() is required to recycle, and when the thread exits, the system au

Re: [dpdk-dev] [PATCH dpdk-dev v2 1/2] eal: introduce rte-init queue for libraries initialization

2020-04-09 Thread Jerin Jacob
On Thu, Apr 9, 2020 at 8:33 PM wrote: > > From: Tonghao Zhang > > This patch introduces last-init queue, user can register a > callback for theirs initialization. Running rte_last_init_run(), The above section needs to be rewritten wrt v2 changes. > the almost resource of DPDK are available, su

[dpdk-dev] [PATCH] net/ixgbe: fix resource leak after thread exits normally

2020-04-09 Thread taox . zhu
From: "Zhu, Tao" When the thread exits normally, pthread_join() is not called, which can result in a resource leak. Therefore, the thread is set to separation mode using function pthread_detach(), so that no program call pthread_join() is required to recycle, and when the thread exits, the system

Re: [dpdk-dev] [PATCH v4 18/29] node: add ethdev Rx and Tx node ctrl API

2020-04-09 Thread Nithin Dabilpuram
On Fri, Apr 10, 2020 at 01:07:17AM +0200, Andrzej Ostruszka wrote: > On 4/5/20 10:56 AM, jer...@marvell.com wrote: > > From: Nithin Dabilpuram > > > > Add ctrl api to setup ethdev_rx and ethdev_tx node. > > This ctrl api clones 'N' number of ethdev_rx and ethdev_tx > > nodes with specific (port,

[dpdk-dev] [RFC] An application to apply configuration from files

2020-04-09 Thread Muhammad Ahmad
Hi, I was looking at the DPDK road map(https://core.dpdk.org/roadmap/), there is a point of having “default configuration from files” I have an idea of saving the configuration of ports and respective drivers in CSV or JSON format. Then a script will be used to apply that configuration. The addit

Re: [dpdk-dev] [PATCH 2/2] lib/timer: relax barrier for status update

2020-04-09 Thread Phil Yang
> -Original Message- > From: Carrillo, Erik G > Sent: Friday, April 10, 2020 3:29 AM > To: Honnappa Nagarahalli ; Phil Yang > ; rsanf...@akamai.com; dev@dpdk.org > Cc: david.march...@redhat.com; Burakov, Anatoly > ; tho...@monjalon.net; jer...@marvell.com; > hemant.agra...@nxp.com; Gavin H

Re: [dpdk-dev] [PATCH 1/1] virt2phys: virtual to physical address translator for Windows

2020-04-09 Thread Dmitry Kozlyuk
> > > > > + PHYSICAL_ADDRESS *phys; > > > + size_t size; > > > + NTSTATUS status; > > > + > [snip] > > > + > > > + status = WdfRequestRetrieveOutputBuffer( > > > + request, sizeof(*phys), &phys, &size); > > > > Better to put a (PVOID *)typecast for &phys here: > > status = Wdf

Re: [dpdk-dev] [PATCH 1/1] virt2phys: virtual to physical address translator for Windows

2020-04-09 Thread Dmitry Kozlyuk
> > + > > +_Use_decl_annotations_ > > +VOID > > +virt2phys_device_EvtIoInCallerContext( > > + IN WDFDEVICE device, IN WDFREQUEST request) > > +{ > > + WDF_REQUEST_PARAMETERS params; > > + ULONG code; > > + PVOID *virt; > > Should this be PVOID virt; (instead of PVOID *virt)? > If so, cha

Re: [dpdk-dev] [PATCH 3/3] net/ice/base: force switch to use different recipe for

2020-04-09 Thread Peng, Yuan
Test-by Peng, Yuan -Original Message- From: Zhao1, Wei Sent: Friday, April 10, 2020 8:42 AM To: dev@dpdk.org Cc: Zhang, Qi Z ; Lu, Nannan ; Peng, Yuan ; Zhao1, Wei Subject: [PATCH 3/3] net/ice/base: force switch to use different recipe for When we use profile rule as swicth rule to d

Re: [dpdk-dev] [PATCH 1/3] net/ice/base: check the number of recipe when in chain

2020-04-09 Thread Lu, Nannan
Tested-by: Lu, Nannan -Original Message- From: Zhao1, Wei Sent: Friday, April 10, 2020 8:42 AM To: dev@dpdk.org Cc: Zhang, Qi Z ; Lu, Nannan ; Peng, Yuan ; Zhao1, Wei Subject: [PATCH 1/3] net/ice/base: check the number of recipe when in chain when we add some long switch rule, we need

Re: [dpdk-dev] [PATCH v6] net/i40e: implement hash function in rte flow API

2020-04-09 Thread Xing, Beilei
> -Original Message- > From: Di, ChenxuX > Sent: Monday, March 30, 2020 3:40 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Xing, Beilei > ; Zhao1, Wei ; Di, ChenxuX > > Subject: [PATCH v6] net/i40e: implement hash function in rte flow API > > implement set hash global configurations, set

Re: [dpdk-dev] [PATCH 1/1] virt2phys: virtual to physical address translator for Windows

2020-04-09 Thread Ranjit Menon
On 3/29/2020 9:10 PM, Dmitry Kozlyuk wrote: This patch is for dpdk-kmods tree. This driver supports Windows EAL memory management by translating current process virtual addresses to physical addresses (IOVA). Standalone virt2phys allows using DPDK without PMD and provides a reference implementat

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/5] net/tap: fix mbuf double free when writev fails

2020-04-09 Thread wangyunjian
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, April 9, 2020 10:51 PM > To: wangyunjian > Cc: Ferruh Yigit ; dev@dpdk.org; > keith.wi...@intel.com; Lilijun (Jerry) ; xudingke > ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [dpdk-stable] [

Re: [dpdk-dev] [PATCH v2] test: remove meson dependency on /proc file

2020-04-09 Thread Ruifeng Wang
> -Original Message- > From: Thomas Monjalon > Sent: Friday, April 10, 2020 3:34 AM > To: dev@dpdk.org > Cc: bruce.richard...@intel.com; Lukasz Wojciechowski > ; Aaron Conole > ; Ruifeng Wang ; David > Marchand ; Gavin Hu > Subject: [PATCH v2] test: remove meson dependency on /proc file

Re: [dpdk-dev] [PATCH 2/2] common/iavf: update version

2020-04-09 Thread Xing, Beilei
> -Original Message- > From: dev On Behalf Of Qi Zhang > Sent: Friday, April 10, 2020 8:49 AM > To: Ye, Xiaolong > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [dpdk-dev] [PATCH 2/2] common/iavf: update version > > Update share code release version in readme > > Signed-off-by: Qi Zhang

Re: [dpdk-dev] [PATCH 0/3] update ice switch base code

2020-04-09 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Friday, April 10, 2020 8:42 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Lu, Nannan ; > Peng, Yuan > Subject: [PATCH 0/3] update ice switch base code > > This patch set fix some ice base code bug of switch. > > Wei Zhao (3): > net/ice/ba

[dpdk-dev] [PATCH 1/3] net/ice/base: check the number of recipe when in chain

2020-04-09 Thread Wei Zhao
when we add some long switch rule, we need check the number of final recipe number, if it is large than ICE_MAX_CHAIN_RECIPE, we should refuse this rule. For example: "flow create 0 ingress pattern eth / ipv6 src is CDCD:910A::5498:8475::3900:1536 dst is CDCD:910A::5498:8475::3900:

[dpdk-dev] [PATCH 3/3] net/ice/base: force switch to use different recipe for

2020-04-09 Thread Wei Zhao
When we use profile rule as swicth rule to download, if we download 2 different rules one by one, there will be rejection from function ice_aq_sw_rules(), for example: "flow create 0 priority 0 ingress pattern eth / ipv6 / ah / end actions queue index 3 / end" "flow create 0 priority 0 ingress pat

[dpdk-dev] [PATCH 0/3] update ice switch base code

2020-04-09 Thread Wei Zhao
This patch set fix some ice base code bug of switch. Wei Zhao (3): net/ice/base: check the number of recipe when in chain net/ice/base: add mask check when find switch recipe net/ice/base: force switch to use different recipe for drivers/net/ice/base/ice_switch.c | 23 +

[dpdk-dev] [PATCH 2/3] net/ice/base: add mask check when find switch recipe

2020-04-09 Thread Wei Zhao
In order to find accurate recipe for switch filter, we need to add mask as an element when searching for recipe. If we create different rules with the same input set, but using different masks, then proper recipes should use those different mask. Signed-off-by: Wei Zhao --- drivers/net/ice/base/

[dpdk-dev] [PATCH] common/iavf: update version

2020-04-09 Thread Qi Zhang
Update share code release version in readme Signed-off-by: Qi Zhang --- drivers/common/iavf/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/iavf/README b/drivers/common/iavf/README index b78e89bee..034c7d7ad 100644 --- a/drivers/common/iavf/README +++ b/

[dpdk-dev] [PATCH] common/iavf: update version

2020-04-09 Thread Qi Zhang
Update share code release version in readme Signed-off-by: Qi Zhang --- drivers/common/iavf/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/iavf/README b/drivers/common/iavf/README index b78e89bee..034c7d7ad 100644 --- a/drivers/common/iavf/README +++ b/

[dpdk-dev] [PATCH] net/ice/base: update version

2020-04-09 Thread Qi Zhang
Update share code version in readme. Signed-off-by: Qi Zhang --- drivers/net/ice/base/README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/base/README b/drivers/net/ice/base/README index 88548296d..726593971 100644 --- a/drivers/net/ice/base/README +++ b

[dpdk-dev] [PATCH 2/2] common/iavf: update version

2020-04-09 Thread Qi Zhang
Update share code release version in readme Signed-off-by: Qi Zhang --- drivers/common/iavf/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/iavf/README b/drivers/common/iavf/README index b78e89bee..034c7d7ad 100644 --- a/drivers/common/iavf/README +++ b/

[dpdk-dev] [PATCH] net/ice/base: update version

2020-04-09 Thread Qi Zhang
Update share code version in readme. Signed-off-by: Qi Zhang --- drivers/net/ice/base/README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/base/README b/drivers/net/ice/base/README index 88548296d..726593971 100644 --- a/drivers/net/ice/base/README +++ b

[dpdk-dev] [PATCH 1/2] common/iavf: add flow director support in virtual channel

2020-04-09 Thread Qi Zhang
Adds new ops and structures to support VF to add/delete/validate/ query flow director. ADD and VALIDATE FDIR share one ops: VIRTCHNL_OP_ADD_FDIR_FILTER. VF sends this request to PF by filling out the related field in virtchnl_fdir_add. If the rule is created successfully, PF will return flow id an

[dpdk-dev] [PATCH 1/2] common/iavf: add flow director support in virtual channel

2020-04-09 Thread Qi Zhang
Adds new ops and structures to support VF to add/delete/validate/ query flow director. ADD and VALIDATE FDIR share one ops: VIRTCHNL_OP_ADD_FDIR_FILTER. VF sends this request to PF by filling out the related field in virtchnl_fdir_add. If the rule is created successfully, PF will return flow id an

[dpdk-dev] [PATCH 2/2] common/iavf: update version

2020-04-09 Thread Qi Zhang
Update share code release version in readme Signed-off-by: Qi Zhang --- drivers/common/iavf/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/iavf/README b/drivers/common/iavf/README index b78e89bee..034c7d7ad 100644 --- a/drivers/common/iavf/README +++ b/

Re: [dpdk-dev] [PATCH 0/6] iavf share code update

2020-04-09 Thread Xing, Beilei
> -Original Message- > From: Zhang, Qi Z > Sent: Friday, April 10, 2020 8:35 AM > To: Xing, Beilei > Cc: Wu, Jingjing ; Ye, Xiaolong > ; dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH 0/6] iavf share code update > > Update virtual channel to support > 1) DDP package info query > 2) flex

[dpdk-dev] [PATCH 2/2] common/iavf: update version

2020-04-09 Thread Qi Zhang
Update share code release version in readme Signed-off-by: Qi Zhang --- drivers/common/iavf/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/iavf/README b/drivers/common/iavf/README index b78e89bee..034c7d7ad 100644 --- a/drivers/common/iavf/README +++ b/

[dpdk-dev] [PATCH 2/2] common/iavf: update version

2020-04-09 Thread Qi Zhang
Update share code release version in readme Signed-off-by: Qi Zhang --- drivers/common/iavf/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/iavf/README b/drivers/common/iavf/README index b78e89bee..034c7d7ad 100644 --- a/drivers/common/iavf/README +++ b/

[dpdk-dev] [PATCH 1/2] common/iavf: add flow director support in virtual channel

2020-04-09 Thread Qi Zhang
Adds new ops and structures to support VF to add/delete/validate/ query flow director. ADD and VALIDATE FDIR share one ops: VIRTCHNL_OP_ADD_FDIR_FILTER. VF sends this request to PF by filling out the related field in virtchnl_fdir_add. If the rule is created successfully, PF will return flow id an

[dpdk-dev] [PATCH 0/6] iavf share code update

2020-04-09 Thread Qi Zhang
Update virtual channel to support 1) DDP package info query 2) flexibale RXID negotiate 3) RSS and FDIR Qi Zhang (6): common/iavf: add PTYPE definition common/iavf: add DDP package query in virtual channel common/iavf: add virtual channel support for Flex RXD common/iavf: add virtual cha

[dpdk-dev] [PATCH 6/6] common/iavf: add flow director support in virtual channel

2020-04-09 Thread Qi Zhang
Adds new ops and structures to support VF to add/delete/validate/ query flow director. ADD and VALIDATE FDIR share one ops: VIRTCHNL_OP_ADD_FDIR_FILTER. VF sends this request to PF by filling out the related field in virtchnl_fdir_add. If the rule is created successfully, PF will return flow id an

[dpdk-dev] [PATCH 5/6] common/iavf: add advanced RSS input set change support

2020-04-09 Thread Qi Zhang
Add new ops and a new VIRTCHNL_VF_OFFLOAD_ADV_RSS_PF flag to support VF to add or del a specific rss configuration by virtchnl. Signed-off-by: Jeff Guo Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/common/iavf/virtchnl.h | 24 +++- 1 file changed, 2

[dpdk-dev] [PATCH 3/6] common/iavf: add virtual channel support for Flex RXD

2020-04-09 Thread Qi Zhang
Add new VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC flag, opcode VIRTCHNL_OP_GET_SUPPORTED_RXDIDS and add member rxdid in struct virtchnl_rxq_info to support AVF Flex RXD extension. Signed-off-by: Leyi Rong Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/common/iavf/virtchnl.h | 14

[dpdk-dev] [PATCH 4/6] common/iavf: add virtual channel protocol header

2020-04-09 Thread Qi Zhang
To support advanced AVF's FDIR and RSS feature, we need to figure out what kind of data structure should be passed from VF to PF to describe an FDIR rule or RSS config rule. The common part of the requirement is we need a data structure to represent the input set selection of a rule's hash key. An

[dpdk-dev] [PATCH 2/6] common/iavf: add DDP package query in virtual channel

2020-04-09 Thread Qi Zhang
Add VIRTCHNL_OP_DCF_GET_PKG_INFO to query DDP package identification. Signed-off-by: Leyi Rong Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/common/iavf/virtchnl.h | 24 1 file changed, 24 insertions(+) diff --git a/drivers/common/iavf/virtchn

[dpdk-dev] [PATCH 1/6] common/iavf: add PTYPE definition

2020-04-09 Thread Qi Zhang
Add IAVF_RX_PTYPE_PARSER_ABORTED definition, so iavf driver will know opcode for parser aborted packets. Without this definition driver would have to rely on magic numbers. Signed-off-by: Przemyslaw Patynowski Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- drivers/common/iavf/i

Re: [dpdk-dev] [PATCH v4 00/29] graph: introduce graph subsystem

2020-04-09 Thread Andrzej Ostruszka
On 4/5/20 10:55 AM, jer...@marvell.com wrote: > From: Jerin Jacob > > Using graph traversal for packet processing is a proven architecture > that has been implemented in various open source libraries. > > Graph architecture for packet processing enables abstracting the data > processing function

Re: [dpdk-dev] [PATCH v4 19/29] node: add generic ipv4 lookup node

2020-04-09 Thread Andrzej Ostruszka
On 4/5/20 10:56 AM, jer...@marvell.com wrote: > From: Pavan Nikhilesh > > Add IPv4 lookup process function for ip4_lookup node. > This node performs LPM lookup using simple RTE_LPM API on every packet > received and forwards it to a next node that is identified by lookup > result. > > Signed-off

Re: [dpdk-dev] [PATCH v4 12/29] graph: implement fastpath API routines

2020-04-09 Thread Andrzej Ostruszka
On 4/5/20 10:55 AM, jer...@marvell.com wrote: > From: Jerin Jacob > > Adding implementation for rte_graph_walk() API. This will perform a walk > on the circular buffer and call the process function of each node > and collect the stats if stats collection is enabled. > > Signed-off-by: Jerin Jaco

Re: [dpdk-dev] [PATCH v4 18/29] node: add ethdev Rx and Tx node ctrl API

2020-04-09 Thread Andrzej Ostruszka
On 4/5/20 10:56 AM, jer...@marvell.com wrote: > From: Nithin Dabilpuram > > Add ctrl api to setup ethdev_rx and ethdev_tx node. > This ctrl api clones 'N' number of ethdev_rx and ethdev_tx > nodes with specific (port, queue) pairs updated in their context. > All the ethdev ports and queues are se

Re: [dpdk-dev] [PATCH v4 16/29] node: add ethdev Rx node

2020-04-09 Thread Andrzej Ostruszka
On 4/5/20 10:56 AM, jer...@marvell.com wrote: > From: Nithin Dabilpuram > > Add source rte_node ethdev_rx process function and register > it. This node is a source node that will be called periodically > and when called, performs rte_eth_rx_burst() on a specific > (port, queue) pair and enqueue t

Re: [dpdk-dev] [PATCH v4 25/29] l3fwd-graph: add graph based l3fwd skeleton

2020-04-09 Thread Andrzej Ostruszka
On 4/5/20 10:56 AM, jer...@marvell.com wrote: > From: Nithin Dabilpuram > > Add graph based l3fwd application skeleton with cmdline > parsing support inline with normal l3fwd. > > Signed-off-by: Nithin Dabilpuram [...] > +static int > +parse_config(const char *q_arg) > +{ > + enum fieldname

Re: [dpdk-dev] [PATCH v4 23/29] node: add ipv4 rewrite and lookup ctrl API

2020-04-09 Thread Andrzej Ostruszka
On 4/5/20 10:56 AM, jer...@marvell.com wrote: > From: Nithin Dabilpuram > > Add ip4_rewrite and ip4_lookup ctrl API. ip4_lookup ctrl > API is used to add route entries for LPM lookup with > result data containing next hop id and next proto. > ip4_rewrite ctrl API is used to add rewrite data for >

Re: [dpdk-dev] [PATCH v4 27/29] l3fwd-graph: add graph config and main loop

2020-04-09 Thread Andrzej Ostruszka
On 4/5/20 10:56 AM, jer...@marvell.com wrote: > From: Nithin Dabilpuram > > Add graph creation, configuration logic and graph main loop. > This graph main loop is run on every slave lcore and calls > rte_graph_walk() to walk over lcore specific rte_graph. > Master core accumulates and prints grap

[dpdk-dev] [PATCH v4 3/3] net/mlx5: add multi-segment packets in MPRQ mode

2020-04-09 Thread Alexander Kozyrev
The multi-stride operations now allow to reduce a stride size while supporting Jumbo frames. That means that it is possible to have mbufs configured with a size smaller than the whole packet received. It is not an issue during normal MPRQ operations since we attach external buffers instead of copyi

[dpdk-dev] [PATCH v4 2/3] net/mlx5: enable MPRQ multi-stride operations

2020-04-09 Thread Alexander Kozyrev
MPRQ feature should be updated to allow a packet to be received into multiple strides in order to support the MTU exceeding 8KB. Special care is needed to prevent the headroom corruption in the multi-stride mode since the headroom space is borrowed by the PMD from the tail of the preceding stride.

[dpdk-dev] [PATCH v4 0/3] net/mlx5: add large packet size support to MPRQ

2020-04-09 Thread Alexander Kozyrev
In order to support the 9K MTU the MPRQ feature should be updated to allow a packet to take more than one stride (single linear buffer). Receiving a packet into multiple adjacent strides should be implemented. The reason preventing the packet to be received into multiple strides is that the data bu

[dpdk-dev] [PATCH v4 1/3] net/mlx5: add a devarg to specify MPRQ stride size

2020-04-09 Thread Alexander Kozyrev
Define a device parameter to configure log 2 of a stride size for MPRQ - mprq_log_stride_size. User is able to specify a stride size in a range allowed by an underlying hardware. The default stride size is defined as 2048 bytes to encompass most commonly used packet sizes in the Internet (MTU 1518

Re: [dpdk-dev] [PATCH] net/mlx5: use open/read/close for reading ib stat

2020-04-09 Thread Alexander Kozyrev
> -Original Message- > From: Mohsin Shaikh > Sent: Thursday, April 9, 2020 16:37 > To: dev@dpdk.org > Cc: sta...@dpdk.org; Alexander Kozyrev ; Mohsin > Shaikh > Subject: [PATCH] net/mlx5: use open/read/close for reading ib stat > > fgets(3)/fread(3)/fscanf(3) etc. use mmap(2)/munmap(2) w

[dpdk-dev] [PATCH v3 3/3] net/mlx5: add multi-segment packets in MPRQ mode

2020-04-09 Thread Alexander Kozyrev
The multi-stride operations now allow to reduce a stride size while supporting Jumbo frames. That means that it is possible to have mbufs configured with a size smaller than the whole packet received. It is not an issue during normal MPRQ operations since we attach external buffers instead of copyi

[dpdk-dev] [PATCH v3 1/3] net/mlx5: add a devarg to specify MPRQ stride size

2020-04-09 Thread Alexander Kozyrev
Define a device parameter to configure log 2 of a stride size for MPRQ - mprq_log_stride_size. User is able to specify a stride size in a range allowed by an underlying hardware. The default stride size is defined as 2048 bytes to encompass most commonly used packet sizes in the Internet (MTU 1518

[dpdk-dev] [PATCH v3 2/3] net/mlx5: enable MPRQ multi-stride operations

2020-04-09 Thread Alexander Kozyrev
MPRQ feature should be updated to allow a packet to be received into multiple strides in order to support the MTU exceeding 8KB. Special care is needed to prevent the headroom corruption in the multi-stride mode since the headroom space is borrowed by the PMD from the tail of the preceding stride.

[dpdk-dev] [PATCH v3 0/3] net/mlx5: add large packet size support to MPRQ

2020-04-09 Thread Alexander Kozyrev
In order to support the 9K MTU the MPRQ feature should be updated to allow a packet to take more than one stride (single linear buffer). Receiving a packet into multiple adjacent strides should be implemented. The reason preventing the packet to be received into multiple strides is that the data bu

[dpdk-dev] [PATCH] doc: fix sphinx compatibility

2020-04-09 Thread Thomas Monjalon
The function add_stylesheet() is deprecated since sphinx 1.8. It will be removed in sphinx 4.0. It is replaced by add_css_file(). Cc: sta...@dpdk.org Signed-off-by: Thomas Monjalon --- doc/guides/conf.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/doc/guides/conf.py

Re: [dpdk-dev] First the test fail and than get passed

2020-04-09 Thread Thomas Monjalon
08/04/2020 15:50, Muhammad Bilal: > About 2 days ago, I submitted a patch for a Bug 353. And I saw that > "iol-testing" failed on patchwork for "openSUSE" Environment. Today I > checked and it shows all the tests are passed [ > http://mails.dpdk.org/archives/test-report/2020-April/124201.html]. Is

[dpdk-dev] [PATCH] net/mlx5: use open/read/close for reading ib stat

2020-04-09 Thread Mohsin Shaikh
fgets(3)/fread(3)/fscanf(3) etc. use mmap(2)/munmap(2) which leads to TLB shootdown interrupts to all dpdk app cores including RX cores. This can cause packet drops. Use read(2)/write(2) instead. Bugzilla ID: 440 Cc: sta...@dpdk.org Signed-off-by: Mohsin Shaikh --- drivers/net/mlx5/mlx5_stats.c

Re: [dpdk-dev] [PATCH v2] test: remove meson dependency on /proc file

2020-04-09 Thread Aaron Conole
Thomas Monjalon writes: > Meson is detecting the path /proc/sys/vm/nr_hugepages in the call to cat > in app/test/meson.build and then adding it as a build dependency. > This causes build loop if the timestamp of this file keeps changing. > > It is fixed by hiding hugepage check in a shell script.

Re: [dpdk-dev] [PATCH v2] test: remove meson dependency on /proc file

2020-04-09 Thread Lukasz Wojciechowski
It's perfect now and it still works ;) Reviewed-by: Lukasz Wojciechowski W dniu 09.04.2020 o 21:34, Thomas Monjalon pisze: > Meson is detecting the path /proc/sys/vm/nr_hugepages in the call to cat > in app/test/meson.build and then adding it as a build dependency. > This causes build loop if t

[dpdk-dev] [PATCH v2] test: remove meson dependency on /proc file

2020-04-09 Thread Thomas Monjalon
Meson is detecting the path /proc/sys/vm/nr_hugepages in the call to cat in app/test/meson.build and then adding it as a build dependency. This causes build loop if the timestamp of this file keeps changing. It is fixed by hiding hugepage check in a shell script. Fixes: 77784ef0fba8 ("test: allow

Re: [dpdk-dev] [PATCH 2/2] lib/timer: relax barrier for status update

2020-04-09 Thread Carrillo, Erik G
> -Original Message- > From: Honnappa Nagarahalli > Sent: Wednesday, April 8, 2020 4:56 PM > To: Carrillo, Erik G ; Phil Yang > ; rsanf...@akamai.com; dev@dpdk.org > Cc: david.march...@redhat.com; Burakov, Anatoly > ; tho...@monjalon.net; jer...@marvell.com; > hemant.agra...@nxp.com; Gavin

Re: [dpdk-dev] [PATCH] test: remove meson dependency on /proc file

2020-04-09 Thread Thomas Monjalon
09/04/2020 20:10, Lukasz Wojciechowski: > > W dniu 09.04.2020 o 20:03, Thomas Monjalon pisze: > > Meson is detecting the path /proc/sys/vm/nr_hugepages in the call to cat > > in app/test/meson.build and then adding it as a build dependency. > > This causes build loop if the timestamp of this file

Re: [dpdk-dev] [PATCH] test: remove meson dependency on /proc file

2020-04-09 Thread Lukasz Wojciechowski
works fine Tested-by: Lukasz Wojciechowski W dniu 09.04.2020 o 20:03, Thomas Monjalon pisze: > Meson is detecting the path /proc/sys/vm/nr_hugepages in the call to cat > in app/test/meson.build and then adding it as a build dependency. > This causes build loop if the timestamp of this file keeps

Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-09 Thread Jerin Jacob
On Thu, Apr 9, 2020 at 11:57 PM Jerin Jacob wrote: > > > > > > > > > They are setting levels with regex or globbing. > > > > --log-level supports 3 syntaxes today: > > > > - int (global level) > > > > - globbing:int > > > > - regex,int > > > > > > Here is my understanding.

Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-09 Thread Jerin Jacob
> > > > > > They are setting levels with regex or globbing. > > > --log-level supports 3 syntaxes today: > > > - int (global level) > > > - globbing:int > > > - regex,int > > > > Here is my understanding. > > > > IMO, Actual Syntax is > > - int (global level) > >

[dpdk-dev] [PATCH] net/i40e: enable PPC altivec support for meson builds

2020-04-09 Thread David Christensen
The meson build file does not enable i40e vectorization support for PPC/altivec systems, even though the existing Makefile does enable the support. Add the required architecture check and sources line. Signed-off-by: David Christensen --- drivers/net/i40e/meson.build | 3 +++ 1 file changed, 3 i

Re: [dpdk-dev] [PATCH] test: remove meson dependency on /proc file

2020-04-09 Thread Lukasz Wojciechowski
W dniu 09.04.2020 o 20:03, Thomas Monjalon pisze: > Meson is detecting the path /proc/sys/vm/nr_hugepages in the call to cat > in app/test/meson.build and then adding it as a build dependency. > This causes build loop if the timestamp of this file keeps changing. > > It is fixed by hiding hugepag

[dpdk-dev] [PATCH] test: remove meson dependency on /proc file

2020-04-09 Thread Thomas Monjalon
Meson is detecting the path /proc/sys/vm/nr_hugepages in the call to cat in app/test/meson.build and then adding it as a build dependency. This causes build loop if the timestamp of this file keeps changing. It is fixed by hiding hugepage check in a shell script. Fixes: 77784ef0fba8 ("test: allow

[dpdk-dev] [PATCH v3 12/13] app/test: add rte security capabilities get tests

2020-04-09 Thread Lukasz Wojciechowski
Add unit tests for rte_security_capabilities_get function. Signed-off-by: Lukasz Wojciechowski --- app/test/test_security.c | 138 +++ 1 file changed, 138 insertions(+) diff --git a/app/test/test_security.c b/app/test/test_security.c index 53b9e122e..3570da2a

[dpdk-dev] [Bug 447] ixgbe: ixgbe_dev_link_update_share() leaks memory and memory mappings due to not cleaning up pthreads

2020-04-09 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=447 Bug ID: 447 Summary: ixgbe: ixgbe_dev_link_update_share() leaks memory and memory mappings due to not cleaning up pthreads Product: DPDK Version: 20.02 Hardware: All

[dpdk-dev] [PATCH v3 11/13] app/test: add rte security get userdata tests

2020-04-09 Thread Lukasz Wojciechowski
Add unit tests for rte_security_get_userdata function. Signed-off-by: Lukasz Wojciechowski --- app/test/test_security.c | 191 +++ 1 file changed, 191 insertions(+) diff --git a/app/test/test_security.c b/app/test/test_security.c index 193ab2ba9..53b9e122e 10

[dpdk-dev] [PATCH v3 13/13] app/test: add rte security capability get tests

2020-04-09 Thread Lukasz Wojciechowski
Add unit tests for rte_security_capability_get function. Signed-off-by: Lukasz Wojciechowski --- app/test/test_security.c | 522 +++ 1 file changed, 522 insertions(+) diff --git a/app/test/test_security.c b/app/test/test_security.c index 3570da2a2..724ce56f4

[dpdk-dev] [PATCH v3 09/13] app/test: add rte security session destroy tests

2020-04-09 Thread Lukasz Wojciechowski
Add unit tests for rte_security_session_destroy function. Signed-off-by: Lukasz Wojciechowski --- app/test/test_security.c | 166 +++ 1 file changed, 166 insertions(+) diff --git a/app/test/test_security.c b/app/test/test_security.c index c495449b0..b1a907bd9

[dpdk-dev] [PATCH v3 08/13] app/test: add rte security session stats get tests

2020-04-09 Thread Lukasz Wojciechowski
Add unit tests for rte_security_session_stats_get function. Signed-off-by: Lukasz Wojciechowski --- app/test/test_security.c | 173 +++ 1 file changed, 173 insertions(+) diff --git a/app/test/test_security.c b/app/test/test_security.c index 9c5e7d0da..c495449

[dpdk-dev] [PATCH v3 05/13] app/test: introduce librte security tests

2020-04-09 Thread Lukasz Wojciechowski
This patch introduces set of unit tests of librte_security API functions. Tests are added to dpdk-test application and can be run with "security_autotest" runtime command. This is the first patch in the series of patches as adding all test cases for all API functions in a single patch would make i

[dpdk-dev] [PATCH v3 10/13] app/test: add rte security set pkt metadata tests

2020-04-09 Thread Lukasz Wojciechowski
Add unit tests for rte_security_set_pkt_metadata function. Signed-off-by: Lukasz Wojciechowski --- app/test/test_security.c | 201 +++ 1 file changed, 201 insertions(+) diff --git a/app/test/test_security.c b/app/test/test_security.c index b1a907bd9..193ab2ba

[dpdk-dev] [PATCH v3 04/13] app/test: remove macro definition

2020-04-09 Thread Lukasz Wojciechowski
Remove RTE_TEST_TRACE_FAILURE macro definition from app/test/test.h as it might be already defined and cause build problems. Also it is good to leave the decision of additional logs to the final user of test.h and rte_test.h Fixes: 5afc521eac6a ("eal: add test assert macros") Cc: pbhagavat...@cav

[dpdk-dev] [PATCH v3 07/13] app/test: add rte security session get size tests

2020-04-09 Thread Lukasz Wojciechowski
Add unit tests for rte_security_session_get_size function. Signed-off-by: Lukasz Wojciechowski --- app/test/test_security.c | 132 +++ 1 file changed, 132 insertions(+) diff --git a/app/test/test_security.c b/app/test/test_security.c index daaf30b62..9c5e7d0d

[dpdk-dev] [PATCH v3 06/13] app/test: add rte security session update tests

2020-04-09 Thread Lukasz Wojciechowski
Add unit tests for rte_security_session_update function. Signed-off-by: Lukasz Wojciechowski --- app/test/test_security.c | 229 +++ 1 file changed, 229 insertions(+) diff --git a/app/test/test_security.c b/app/test/test_security.c index 3fc83abae..daaf30b62

[dpdk-dev] [PATCH v3 03/13] security: fix session counter

2020-04-09 Thread Lukasz Wojciechowski
Fix session counter to be decreased in rte_security_session_destroy only when session was successfully destroyed. Formerly session counter was decreased prior session destroying and returning session object to mempool. It remained decreased even if session was not destroyed and mempool object rele

[dpdk-dev] [PATCH v3 00/13] Fixes and unit tests for librte_security

2020-04-09 Thread Lukasz Wojciechowski
Set of patches fix minor issues like proper verification of input parameters and aligning documentation with code in the matter of return values. Another fixed issue is invalid decrementation of the session counter which might cause inconsistency between counter values and a true number of sessions

[dpdk-dev] [PATCH v3 01/13] security: fix verification of parameters

2020-04-09 Thread Lukasz Wojciechowski
This patch adds verification of the parameters to the ret_security API functions. All required parameters are checked if they are not NULL. Checks verify full chain of pointers, e.g. in case of verification of "instance->ops->session_XXX", they check also "instance" and "instance->ops". Fixes: c2

[dpdk-dev] [PATCH v3 02/13] security: fix return types in documentation

2020-04-09 Thread Lukasz Wojciechowski
Enhance returned values description for rte_security_session_destroy and some other minor description changes. Fixes: c261d1431bd8 ("security: introduce security API and framework") Cc: akhil.go...@nxp.com Cc: sta...@dpdk.org Signed-off-by: Lukasz Wojciechowski --- lib/librte_security/rte_secu

Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-09 Thread Thomas Monjalon
09/04/2020 18:34, Jerin Jacob: > On Thu, Apr 9, 2020 at 9:30 PM Thomas Monjalon wrote: > > 09/04/2020 17:36, Jerin Jacob: > > > On Thu, Apr 9, 2020 at 7:30 PM Thomas Monjalon > > > wrote: > > > > As discussed somewhere else, please do not introduce global level > > > > in rte_trace. I think it i

Re: [dpdk-dev] [PATCHv2] Remove validate-abi.sh from tree

2020-04-09 Thread Thomas Monjalon
09/04/2020 18:29, Ray Kinsella: > On 09/04/2020 16:18, Thomas Monjalon wrote: > > 09/04/2020 16:52, Ray Kinsella: > >> On 09/04/2020 11:59, Thomas Monjalon wrote: > >>> 09/04/2020 12:45, Ray Kinsella: > On 09/04/2020 11:43, Bruce Richardson wrote: > > On Thu, Apr 09, 2020 at 06:39:54AM -04

Re: [dpdk-dev] [PATCH v3 09/12] service: avoid race condition for MT unsafe service

2020-04-09 Thread Van Haaren, Harry
> -Original Message- > From: Honnappa Nagarahalli > Sent: Thursday, April 9, 2020 2:32 AM > To: Van Haaren, Harry ; Phil Yang > ; tho...@monjalon.net; Ananyev, Konstantin > ; step...@networkplumber.org; > maxime.coque...@redhat.com; dev@dpdk.org > Cc: david.march...@redhat.com; jer...@marv

Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-09 Thread Jerin Jacob
On Thu, Apr 9, 2020 at 9:30 PM Thomas Monjalon wrote: > > 09/04/2020 17:36, Jerin Jacob: > > On Thu, Apr 9, 2020 at 7:30 PM Thomas Monjalon wrote: > > > 03/04/2020 17:36, jer...@marvell.com: > > > > Features: > > > > ~ > > > > - APIs and Features are similar to rte_log dynamic framework >

Re: [dpdk-dev] [PATCHv2] Remove validate-abi.sh from tree

2020-04-09 Thread Ray Kinsella
On 09/04/2020 16:18, Thomas Monjalon wrote: > 09/04/2020 16:52, Ray Kinsella: >> On 09/04/2020 11:59, Thomas Monjalon wrote: >>> 09/04/2020 12:45, Ray Kinsella: On 09/04/2020 11:43, Bruce Richardson wrote: > On Thu, Apr 09, 2020 at 06:39:54AM -0400, Neil Horman wrote: >> On Thu, Apr

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] mbuf: replace zero-length marker with unnamed union

2020-04-09 Thread Ray Kinsella
On 09/04/2020 11:49, Thomas Monjalon wrote: > 09/04/2020 11:48, Gavin Hu: >> From: David Marchand >>> On Wed, Apr 8, 2020 at 5:05 PM Gavin Hu wrote: From: Kevin Traynor > Hi Gavin, I lost track if v2 is still a candidate for merge. fwiw, it > compiles without giving the zero-leng

Re: [dpdk-dev] [EXT] Re: [PATCH v2 01/13] security: fix verification of parameters

2020-04-09 Thread Lukasz Wojciechowski
W dniu 09.04.2020 o 17:22, Thomas Monjalon pisze: > 09/04/2020 16:21, Lukasz Wojciechowski: >> W dniu 09.04.2020 o 16:07, Lukasz Wojciechowski pisze: >>> W dniu 09.04.2020 o 13:13, Bruce Richardson pisze: On Thu, Apr 09, 2020 at 12:54:10PM +0200, Thomas Monjalon wrote: > 09/04/2020 12:14

Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-09 Thread Thomas Monjalon
09/04/2020 17:36, Jerin Jacob: > On Thu, Apr 9, 2020 at 7:30 PM Thomas Monjalon wrote: > > 03/04/2020 17:36, jer...@marvell.com: > > > Features: > > > ~ > > > - APIs and Features are similar to rte_log dynamic framework > > > API(expect log prints on stdout vs it dumps on trace file) > > >

[dpdk-dev] [PATCH] doc: update hairpin data buffer size config

2020-04-09 Thread Bing Zhao
This patch updates the MLX5 PMD and release notes documentations. Adding the guideline for hairpin data buffer size configuration. Signed-off-by: Bing Zhao --- doc/guides/nics/mlx5.rst | 11 +++ doc/guides/rel_notes/release_20_05.rst | 1 + 2 files changed, 12 insertions(+

[dpdk-dev] [PATCH 5/5] app/test-flow-perf: add packet forwarding support

2020-04-09 Thread Wisam Jaddo
Introduce packet forwarding support to the app to do some performance measurements. The measurements are reported in term of packet per second unit. The forwarding will start after the end of insertion/deletion operations. The support has single and multi performance measurements. Signed-off-by:

[dpdk-dev] [PATCH 3/5] app/test-flow-perf: add deletion rate calculation

2020-04-09 Thread Wisam Jaddo
Add the ability to test deletion rate for flow performance application. This feature is disabled by default, and can be enabled by add "--deletion-rate" in the application command line options. Signed-off-by: Wisam Jaddo --- app/test-flow-perf/main.c | 87 ++

[dpdk-dev] [PATCH 2/5] app/test-flow-perf: add insertion rate calculation

2020-04-09 Thread Wisam Jaddo
Add insertion rate calculation feature into flow performance application. The application now provide the ability to test insertion rate of specific rte_flow rule, by stressing it to the NIC, and calculate the insertion rate. The application offers some options in the command line, to configure w

[dpdk-dev] [PATCH 1/5] app/test-flow-perf: add flow performance skeleton

2020-04-09 Thread Wisam Jaddo
Add flow performance application skeleton. Signed-off-by: Wisam Jaddo --- MAINTAINERS | 5 + app/Makefile | 1 + app/meson.build | 1 + app/test-flow-perf/Makefile | 26 +++ app/test-flow-perf/main.c

[dpdk-dev] [PATCH 4/5] app/test-flow-perf: add memory dump to app

2020-04-09 Thread Wisam Jaddo
Introduce new feature to dump memory statistics of each socket and a total for all before and after the creation. This will give two main advantage: 1- Check the memory consumption for large number of flows "insertion rate scenario alone" 2- Check that no memory leackage after doing insertion the

  1   2   >