[dpdk-dev] [PATCH v3 03/13] security: fix session counter

[Lukasz Wojciechowski]

Fix session counter to be decreased in rte_security_session_destroy
only when session was successfully destroyed.

Formerly session counter was decreased prior session destroying
and returning session object to mempool. It remained decreased even
if session was not destroyed and mempool object released making counter
invalid.

Fixes: c261d1431bd8 ("security: introduce security API and framework")
Cc: akhil.go...@nxp.com

Cc: sta...@dpdk.org

Signed-off-by: Lukasz Wojciechowski <l.wojciec...@partner.samsung.com>
---
 lib/librte_security/rte_security.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/lib/librte_security/rte_security.c 
b/lib/librte_security/rte_security.c
index 38ccc2ea9..d475b0977 100644
--- a/lib/librte_security/rte_security.c
+++ b/lib/librte_security/rte_security.c
@@ -90,14 +90,16 @@ rte_security_session_destroy(struct rte_security_ctx 
*instance,
                        -ENOTSUP);
        RTE_PTR_OR_ERR_RET(sess, -EINVAL);
 
+       ret = instance->ops->session_destroy(instance->device, sess);
+       if (ret != 0)
+               return ret;
+
+       rte_mempool_put(rte_mempool_from_obj(sess), (void *)sess);
+
        if (instance->sess_cnt)
                instance->sess_cnt--;
 
-       ret = instance->ops->session_destroy(instance->device, sess);
-       if (!ret)
-               rte_mempool_put(rte_mempool_from_obj(sess), (void *)sess);
-
-       return ret;
+       return 0;
 }
 
 int
-- 
2.17.1