[dpdk-dev] [DPDK v1] examples/vhost: add vhostpmd support

2020-03-10 Thread Sivaprasad Tummala
Added vHostPMD based configuration of vHost devices. Currently vHost library calls are used for configuring the vhost device. vHostPMD is a pre-requisite for enabling future features supported such as FPGA and possibly CBDMA. With the vHostPMD integration, upstream features in PMD can be easily su

Re: [dpdk-dev] 19.11.1 patches review and test

2020-03-10 Thread Kalesh Anakkur Purayil
Hi Luca, Testing with dpdk v19.11.1-rc1 from Broadcom looks good. - Basic functionality: Send and receive multiple types of traffic. - Changing/checking link status through testpmd. - RSS tests. - TSO tests - VLAN filtering tests. - statistics tests - Checksum offload - MTU tests NIC: BCM57414

[dpdk-dev] [PATCH v5] eal/arm64: fix rdtsc precise version

2020-03-10 Thread Linhaifeng
From 70acca49c2109ef07e59dd035c5b66d7987d Mon Sep 17 00:00:00 2001 From: Haifeng Lin Date: Mon, 9 Mar 2020 16:49:10 +0800 Subject: [PATCH] eal/arm64: fix rdtsc precise version In order to get more accurate the cntvct_el0 reading, SW must invoke isb and arch_counter_enforce_ordering. Referenc

[dpdk-dev] [Bug 418] failsafe/tap PMD drops first UDP packet

2020-03-10 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=418 Bug ID: 418 Summary: failsafe/tap PMD drops first UDP packet Product: DPDK Version: 20.02 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: major Pri

[dpdk-dev] [PATCH v2] vhost: make iotlb cache name unique among multi processes

2020-03-10 Thread Itsuro Oda
Currently, iotlb cache name is comprised of vid and virtqueue index. For example, "iotlb_cache_0_0". Because vid is assigned per process, iotlb cache name is not unique among multi processes. For example a secondary process uses a vhost (ex. eth_vhost0,iface=/tmp/sock0) and another secondary proces

Re: [dpdk-dev] [PATCH v3] app: test: measure libipsec performance

2020-03-10 Thread Thomas Monjalon
10/03/2020 14:24, Ananyev, Konstantin: > > > 05/03/2020 23:51, Ananyev, Konstantin: > > > > > > > 05/03/2020 12:45, Ananyev, Konstantin: > > > > > I think the header need to be "app/test", or "test/ipsec". > > > > > > > > It should be "test/ipsec" as it is an IPsec test command > > > > in the test

Re: [dpdk-dev] [PATCH] eal/service: fix exit by resetting service lcores

2020-03-10 Thread Aaron Conole
Aaron Conole writes: > "Van Haaren, Harry" writes: > >>> -Original Message- >>> From: David Marchand >>> Sent: Tuesday, March 10, 2020 4:31 PM >>> To: Van Haaren, Harry >>> Cc: dev ; Aaron Conole >>> Subject: Re: [PATCH] eal/service: fix exit by resetting service lcores >>> >>> On Tu

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-gw: fix gcc 10 maybe-uninitialized warning

2020-03-10 Thread Ananyev, Konstantin
> >> gcc 10.0.1 reports: > >> > >> ../examples/ipsec-secgw/ipsec_process.c: In function ‘ipsec_process’: > >> ../examples/ipsec-secgw/ipsec_process.c:132:34: > >> error: ‘grp.m’ may be used uninitialized in this function > >> [-Werror=maybe-uninitialized] > >> 132 |grp[n].cnt = pkts + i - gr

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-gw: fix gcc 10 maybe-uninitialized warning

2020-03-10 Thread Kevin Traynor
On 10/03/2020 13:08, Ananyev, Konstantin wrote: > Hi Kevin, > Hi Konstantin, >> gcc 10.0.1 reports: >> >> ../examples/ipsec-secgw/ipsec_process.c: In function ‘ipsec_process’: >> ../examples/ipsec-secgw/ipsec_process.c:132:34: >> error: ‘grp.m’ may be used uninitialized in this function >> [-We

[dpdk-dev] [PATCH 08/10] service: identify service running on another core correctly

2020-03-10 Thread Phil Yang
From: Honnappa Nagarahalli The logic to identify if the MT unsafe service is running on another core can return -EBUSY spuriously. In such cases, running the service becomes more costlier than using atomic operations. Assume that the application passes the right parameters and reduce the number o

[dpdk-dev] [PATCH 07/10] service: avoid race condition for MT unsafe service

2020-03-10 Thread Phil Yang
From: Honnappa Nagarahalli There has possible that a MT unsafe service might get configured to run on another core while the service is running currently. This might result in the MT unsafe service running on multiple cores simultaneously. Use 'execute_lock' always when the service is MT unsafe.

[dpdk-dev] [PATCH 09/10] service: optimize with c11 one-way barrier

2020-03-10 Thread Phil Yang
The num_mapped_cores and execute_lock are synchronized with rte_atomic_XX APIs which is a full barrier, DMB, on aarch64. This patch optimized it with c11 atomic one-way barrier. Signed-off-by: Phil Yang Reviewed-by: Ruifeng Wang Reviewed-by: Gavin Hu Reviewed-by: Honnappa Nagarahalli --- lib/

[dpdk-dev] [PATCH 10/10] service: relax barriers with C11 atomic operations

2020-03-10 Thread Phil Yang
To guarantee the inter-threads visibility of the shareable domain, it uses a lot of rte_smp_r/wmb in the service library. This patch relaxed these barriers for service by using c11 atomic one-way barrier operations. Signed-off-by: Phil Yang Reviewed-by: Ruifeng Wang Reviewed-by: Gavin Hu --- l

[dpdk-dev] [PATCH 06/10] service: remove redundant code

2020-03-10 Thread Phil Yang
The service id validation is verified in the calling function, remove the redundant code inside the service_update function. Fixes: 21698354c832 ("service: introduce service cores concept") Cc: sta...@dpdk.org Signed-off-by: Phil Yang Reviewed-by: Honnappa Nagarahalli --- lib/librte_eal/common

[dpdk-dev] [PATCH 05/10] service: remove rte prefix from static functions

2020-03-10 Thread Phil Yang
Fixes: 3cf5eb1546ed ("service: fix and refactor atomic service accesses") Fixes: 21698354c832 ("service: introduce service cores concept") Cc: sta...@dpdk.org Signed-off-by: Phil Yang Reviewed-by: Honnappa Nagarahalli --- lib/librte_eal/common/rte_service.c | 18 +- 1 file chang

[dpdk-dev] [PATCH 03/10] vhost: optimize broadcast rarp sync with c11 atomic

2020-03-10 Thread Phil Yang
The rarp packet broadcast flag is synchronized with rte_atomic_XX APIs which is a full barrier, DMB, on aarch64. This patch optimized it with c11 atomic one-way barrier. Signed-off-by: Phil Yang Reviewed-by: Gavin Hu Reviewed-by: Honnappa Nagarahalli Reviewed-by: Joyce Kong --- lib/librte_vho

[dpdk-dev] [PATCH 04/10] ipsec: optimize with c11 atomic for sa outbound sqn update

2020-03-10 Thread Phil Yang
For SA outbound packets, rte_atomic64_add_return is used to generate SQN atomically. This introduced an unnecessary full barrier by calling the '__sync' builtin implemented rte_atomic_XX API on aarch64. This patch optimized it with c11 atomic and eliminated the expensive barrier for aarch64. Signe

[dpdk-dev] [PATCH 01/10] doc: add generic atomic deprecation section

2020-03-10 Thread Phil Yang
Add deprecating the generic rte_atomic_xx APIs to c11 atomic built-ins guide and examples. Suggested-by: Honnappa Nagarahalli Signed-off-by: Phil Yang Reviewed-by: Gavin Hu --- doc/guides/prog_guide/writing_efficient_code.rst | 60 +++- 1 file changed, 59 insertions(+), 1 d

[dpdk-dev] [PATCH 02/10] devtools: prevent use of rte atomic APIs in future patches

2020-03-10 Thread Phil Yang
In order to deprecate the rte_atomic APIs, prevent the patches from using rte_atomic APIs. Signed-off-by: Phil Yang Reviewed-by: Gavin Hu Reviewed-by: Honnappa Nagarahalli --- devtools/checkpatches.sh | 9 + 1 file changed, 9 insertions(+) diff --git a/devtools/checkpatches.sh b/devto

[dpdk-dev] [PATCH 00/10] generic rte atomic APIs deprecate proposal

2020-03-10 Thread Phil Yang
DPDK provides generic rte_atomic APIs to do several atomic operations. These APIs are using the deprecated __sync built-ins and enforce full memory barriers on aarch64. However, full barriers are not necessary in many use cases. In order to address such use cases, C language offers C11 atomic APIs.

Re: [dpdk-dev] [PATCH] eal/service: fix exit by resetting service lcores

2020-03-10 Thread Aaron Conole
"Van Haaren, Harry" writes: >> -Original Message- >> From: David Marchand >> Sent: Tuesday, March 10, 2020 4:31 PM >> To: Van Haaren, Harry >> Cc: dev ; Aaron Conole >> Subject: Re: [PATCH] eal/service: fix exit by resetting service lcores >> >> On Tue, Mar 10, 2020 at 2:32 PM Harry v

Re: [dpdk-dev] [PATCH] ethdev: spelling fixes

2020-03-10 Thread Ferruh Yigit
On 3/10/2020 4:24 PM, Stephen Hemminger wrote: > Minor spelling errors found by aspell and codespell > > Signed-off-by: Stephen Hemminger Fixes: 1daa33805824 ("ethdev: validate offloads set by PMD") Fixes: 81f9db8ecc2c ("ethdev: add vlan offload support") Fixes: c8231c63ddcb ("ethdev

Re: [dpdk-dev] [PATCH v3 1/1] net/ionic: use standard stdbool.h

2020-03-10 Thread Ferruh Yigit
On 3/9/2020 9:09 AM, Sunil Kumar Kori wrote: > Any DPDK public header file which includes stdbool.h may conflict with > local definition of bool, if any, which further results in compilation > error. To avoid, used standard stdbool.h instead of defining bool > internally. > > I observed this issue

Re: [dpdk-dev] [RFC v6] regexdev: introduce regexdev subsystem

2020-03-10 Thread Ori Kam
Hi Pavan, > -Original Message- > From: dev On Behalf Of Pavan Nikhilesh Bhagavatula > Sent: Tuesday, March 10, 2020 6:37 PM > To: Ori Kam ; Jerin Jacob Kollanukkaran > ; xiang.w.w...@intel.com > Cc: dev@dpdk.org; Shahaf Shuler ; > hemant.agra...@nxp.com; Opher Reviv ; Alex > Rosenbaum ; D

Re: [dpdk-dev] [PATCH v2 0/5] misc updates and fixes for hns3 PMD driver

2020-03-10 Thread Ferruh Yigit
On 3/9/2020 9:32 AM, Wei Hu (Xavier) wrote: > This series are updates and fixes for hns3 PMD driver. > > Chengchang Tang (3): > net/hns3: remove unnecessary restriction on setting VF's MTU > net/hns3: support promiscuous and allmulticast mode for VF > net/hns3: fix promiscuous mode for PF >

[dpdk-dev] Arm roadmap for 20.05

2020-03-10 Thread Honnappa Nagarahalli
Hello, Following are the work items planned for 20.05: 1) Use C11 atomic APIs in timer library 2) Use C11 atomic APIs in service cores 3) Use C11 atomics in VirtIO split ring 4) Performance optimizations in i40e and MLX drivers for Arm platforms 5) RCU defer API 6) Enable Travis CI with no

Re: [dpdk-dev] [PATCH] eal/service: fix exit by resetting service lcores

2020-03-10 Thread Van Haaren, Harry
> -Original Message- > From: David Marchand > Sent: Tuesday, March 10, 2020 4:31 PM > To: Van Haaren, Harry > Cc: dev ; Aaron Conole > Subject: Re: [PATCH] eal/service: fix exit by resetting service lcores > > On Tue, Mar 10, 2020 at 2:32 PM Harry van Haaren > wrote: > > > > This commi

Re: [dpdk-dev] [EXT] [PATCH 2/3] cryptodev: remove unused element from device operations

2020-03-10 Thread Anoob Joseph
> This commit removes unused function pointer (queue_pair_count) from struct > rte_cryptodev_ops. > > Signed-off-by: Artur Trybula Acked-by: Anoob Joseph

Re: [dpdk-dev] [RFC v6] regexdev: introduce regexdev subsystem

2020-03-10 Thread Pavan Nikhilesh Bhagavatula
Hi Ori, > >Hi Pavan, > >> -Original Message- >> From: dev On Behalf Of Pavan Nikhilesh >Bhagavatula >> Sent: Tuesday, March 10, 2020 3:42 PM >> To: Ori Kam ; Jerin Jacob Kollanukkaran >> ; xiang.w.w...@intel.com >> Cc: dev@dpdk.org; Shahaf Shuler ; >> hemant.agra...@nxp.com; Opher Reviv ;

[dpdk-dev] [PATCH v2] eal: fix spelling errors

2020-03-10 Thread Stephen Hemminger
Fix spelling errors in comments (found with codespell). Note that "inbetween" is not correct in English and should either be two words or better yet, the in can be dropped. https://www.grammarly.com/blog/in-between-or-inbetween/ Signed-off-by: Stephen Hemminger --- v2 - drop mistaken fix to arm/

Re: [dpdk-dev] [EXT] [PATCH 1/3] drivers/crypto: remove unused element from device operations

2020-03-10 Thread Anoob Joseph
> This commit removes unused function pointer (queue_pair_count) from > rte_cryptodev_ops objects. Related functions removed as well. > > Signed-off-by: Artur Trybula Acked-by: Anoob Joseph

Re: [dpdk-dev] support of kni ethtool for other drivers

2020-03-10 Thread Stephen Hemminger
On Tue, 10 Mar 2020 12:20:15 -0400 "Dey, Souvik" wrote: > Hi All, > Is there any plan to support ethtool for other drivers apart > from igb/ixgbe for kni interfaes ? > > -- > Regards, > Souvik No. in fact, the ethtool support for KNI was dropped in later versions (see 19.11)

[dpdk-dev] [PATCH] eal: fix spelling errors

2020-03-10 Thread Stephen Hemminger
Fix spelling errors in comments (found with codespell). Note that "inbetween" is not correct in English and should either be two words or better yet, the in can be dropped. https://www.grammarly.com/blog/in-between-or-inbetween/ Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/eal_com

Re: [dpdk-dev] [PATCH] eal/service: fix exit by resetting service lcores

2020-03-10 Thread David Marchand
On Tue, Mar 10, 2020 at 2:32 PM Harry van Haaren wrote: > > This commit releases all service cores from thier role, > returning them to ROLE_RTE on rte_service_finalize(). > > This may fix an issue relating to the service cores causing > a race-condition on eal_cleanup(), where the service core >

Re: [dpdk-dev] [PATCH] mem: mark pages as not accessed when reserving VA

2020-03-10 Thread Burakov, Anatoly
On 09-Mar-20 2:54 PM, David Marchand wrote: When the memory allocator reserves virtual addresses, it still does not know what they will be used for. Besides, huge areas are reserved for memory hotplug in multiprocess setups. But most of the pages are unused in the whole life of the processes. Ch

[dpdk-dev] [PATCH] lpm6: spelling fixes

2020-03-10 Thread Stephen Hemminger
Fix spelling errors in comments. Signed-off-by: Stephen Hemminger --- lib/librte_lpm/rte_lpm6.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_lpm/rte_lpm6.c b/lib/librte_lpm/rte_lpm6.c index d515600f1ffe..7b2322911181 100644 --- a/lib/librte_lpm/rte_lpm6.c

Re: [dpdk-dev] [PATCH v1] examples/ipsec-secgw: load/unload esp-ah DDP file

2020-03-10 Thread Anoob Joseph
Hi Praveen, [Anoob] Rather than calling PMD specific functions from all applications, it might be better to introduce the same via 'devargs' to the PMD. [Praveen Shetty] We will investigate further on this. Probably let's converge on this before sending v2. I don't think we should add a new op

[dpdk-dev] [PATCH] ethdev: spelling fixes

2020-03-10 Thread Stephen Hemminger
Minor spelling errors found by aspell and codespell Signed-off-by: Stephen Hemminger --- lib/librte_ethdev/rte_ethdev.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index 774c721b3484..708199c1f447

Re: [dpdk-dev] [RFC v6] regexdev: introduce regexdev subsystem

2020-03-10 Thread Ori Kam
Hi Pavan, > -Original Message- > From: dev On Behalf Of Pavan Nikhilesh Bhagavatula > Sent: Tuesday, March 10, 2020 3:42 PM > To: Ori Kam ; Jerin Jacob Kollanukkaran > ; xiang.w.w...@intel.com > Cc: dev@dpdk.org; Shahaf Shuler ; > hemant.agra...@nxp.com; Opher Reviv ; Alex > Rosenbaum ; D

[dpdk-dev] support of kni ethtool for other drivers

2020-03-10 Thread Dey, Souvik
Hi All, Is there any plan to support ethtool for other drivers apart from igb/ixgbe for kni interfaes ? -- Regards, Souvik

Re: [dpdk-dev] Questions on service core feature implementation

2020-03-10 Thread Honnappa Nagarahalli
> > Hi Harry, > > Hey Honnappa, Thanks for your answers. > > > I have few observations on service core feature implementation. > > > > I believe it is allowed to map/unmap a lcore to service while the > > service is running (i.e. not just during initialization stage). Please > > clarify ot

[dpdk-dev] [PATCH] ethdev: add DBDF action to RTE Flow

2020-03-10 Thread kirankumark
From: Kiran Kumar K Adding suuport to DBDF action in the RTE Flow. Application can specify the dbdf value using rte_flow_action_dbdf. Matched traffic will be sent to specified PCI DBDF device. Signed-off-by: Kiran Kumar K --- app/test-pmd/cmdline_flow.c| 64

Re: [dpdk-dev] [PATCH v1] ena_ethdev: don't override the user provided queue length value

2020-03-10 Thread Chauskin, Igor
Acked inline From: Vladislav Zolotarov Sent: Friday, March 6, 2020 12:28 AM To: dev@dpdk.org; Schmeilin, Evgeny ; Chauskin, Igor Subject: RE: [EXTERNAL][dpdk-dev] [PATCH v1] ena_ethdev: don't override the user provided queue length value Igor, Evgeny, Please, review. On 3/5/20 5:23 PM, Vlad Z

Re: [dpdk-dev] [PATCH v3 1/1] net/ionic: use standard stdbool.h

2020-03-10 Thread Alfredo Cardigliano
> On 10 Mar 2020, at 16:21, Ferruh Yigit wrote: > > On 3/9/2020 9:09 AM, Sunil Kumar Kori wrote: >> Any DPDK public header file which includes stdbool.h may conflict with >> local definition of bool, if any, which further results in compilation >> error. To avoid, used standard stdbool.h inste

Re: [dpdk-dev] [RFC]app/testpmd: time-consuming question of mlockall function execution

2020-03-10 Thread David Marchand
On Fri, Mar 6, 2020 at 6:49 PM David Marchand wrote: > > On Wed, Feb 26, 2020 at 4:59 AM humin (Q) wrote: > > We have another question about your patch. It seems that mlockall() also > > takes about two seconds after using this patch(about 0.2 seconds before > > using this patch), if we use "al

Re: [dpdk-dev] Big spike in DPDK VSZ

2020-03-10 Thread David Marchand
On Thu, Jan 30, 2020 at 11:48 AM siddarth rai wrote: > I did some further experiments and found out that version 18.02.2 doesn't > have the problem, but the 18.05.1 release has it. > > Would really appreciate if someone can help, if there is a patch to get over > this issue in the DPDK code ? >

Re: [dpdk-dev] [PATCH v3 1/1] net/ionic: use standard stdbool.h

2020-03-10 Thread Ferruh Yigit
On 3/9/2020 9:09 AM, Sunil Kumar Kori wrote: > Any DPDK public header file which includes stdbool.h may conflict with > local definition of bool, if any, which further results in compilation > error. To avoid, used standard stdbool.h instead of defining bool > internally. > > I observed this issue

Re: [dpdk-dev] [PATCH] lib/librte_net/rte_ether.h:changed RTE_ETHER_MAX_LEN

2020-03-10 Thread Stephen Hemminger
On Tue, 10 Mar 2020 11:50:36 +0500 Muhammad Ahmad wrote: > Change the RTE_ETHER_MAX_LEN from 1518 to 1526 > > Bugzilla ID: 296 > > Fixes: c5b2d13 (net: add rte prefix to ether defines) > > Cc: sta...@dpdk.org > Cc: Oliver Matz > > Reported-by: LAVA > Suggested-by: LAVA > Signed-off-by: Muh

Re: [dpdk-dev] [RFC PATCH] app/testpmd: only lock text pages

2020-03-10 Thread David Marchand
On Tue, Mar 10, 2020 at 4:08 PM Ferruh Yigit wrote: > >> +1 to the idea, testpmd initialization was taking too lock without > >> '--no-mlockall', but this code looks complex for the application level. > >> > >> We can do this for testpmd but does all applications need to do something > >> similar?

Re: [dpdk-dev] [RFC PATCH] app/testpmd: only lock text pages

2020-03-10 Thread Ferruh Yigit
On 3/10/2020 2:55 PM, David Marchand wrote: > On Tue, Mar 10, 2020 at 3:49 PM Ferruh Yigit wrote: >> >> On 3/6/2020 2:48 PM, David Marchand wrote: >>> Since 18.05 and the memory subsystem rework, EAL reserves some big >>> (unused) mappings. >>> >>> In testpmd, we have been locking all pages to avo

Re: [dpdk-dev] [RFC PATCH] app/testpmd: only lock text pages

2020-03-10 Thread David Marchand
On Tue, Mar 10, 2020 at 3:49 PM Ferruh Yigit wrote: > > On 3/6/2020 2:48 PM, David Marchand wrote: > > Since 18.05 and the memory subsystem rework, EAL reserves some big > > (unused) mappings. > > > > In testpmd, we have been locking all pages to avoid page faults during > > benchmark/performance

Re: [dpdk-dev] [RFC PATCH] app/testpmd: only lock text pages

2020-03-10 Thread Ferruh Yigit
On 3/6/2020 2:48 PM, David Marchand wrote: > Since 18.05 and the memory subsystem rework, EAL reserves some big > (unused) mappings. > > In testpmd, we have been locking all pages to avoid page faults during > benchmark/performance regression tests [1]. > However, asking for locking all the pages

Re: [dpdk-dev] [PATCH v2] lpm6: make IPv6 addresses immutable

2020-03-10 Thread Medvedkin, Vladimir
On 10/03/2020 09:13, Andrzej Ostruszka wrote: None of the public functions modify IPv6 address passed. So their parameters are made const - with the exception of bulk functions. This exception is due to compatibility problems - some compilers report problems with const-casting of array of arra

Re: [dpdk-dev] [v2] ethdev: add PFCP header to flow API

2020-03-10 Thread Ferruh Yigit
On 3/9/2020 4:31 PM, Ori Kam wrote: > > >> -Original Message- >> From: Xiao Zhang >> Sent: Friday, March 6, 2020 8:39 AM >> To: dev@dpdk.org >> Cc: Ori Kam ; ferruh.yi...@intel.com; Xiao Zhang >> >> Subject: [v2] ethdev: add PFCP header to flow API >> >> This patch adds the new flow ite

Re: [dpdk-dev] [PATCH 1/6] eal: introduce zmm type for AVX 512-bit

2020-03-10 Thread Medvedkin, Vladimir
Hi Jerin, On 09/03/2020 16:39, Jerin Jacob wrote: On Mon, Mar 9, 2020 at 6:14 PM Vladimir Medvedkin wrote: New data type to manipulate 512 bit AVX values. Signed-off-by: Vladimir Medvedkin --- lib/librte_eal/common/include/arch/x86/rte_vect.h | 20 1 file changed, 20

Re: [dpdk-dev] [PATCH v1 0/4] add Intel DCF PMD support

2020-03-10 Thread Aaron Conole
Ferruh Yigit writes: > On 3/10/2020 7:48 AM, Thomas Monjalon wrote: >> 10/03/2020 03:00, Wang, Haiyue: -Original Message- From: Kevin Traynor Sent: Tuesday, March 10, 2020 03:34 To: Thomas Monjalon ; David Marchand ; Ye, Xiaolong Cc: Wang, Haiyue ; dev

Re: [dpdk-dev] [PATCH v1 0/4] add Intel DCF PMD support

2020-03-10 Thread Aaron Conole
David Marchand writes: > On Mon, Mar 9, 2020 at 3:22 PM Haiyue Wang wrote: >> >> A DCF (Device Config Function) based approach is proposed where a device >> bound to the device's VF0 can act as a sole controlling entity to exercise >> advance functionality (such as switch, ACL) for rest of the V

Re: [dpdk-dev] 19.11.1 patches review and test

2020-03-10 Thread Luca Boccassi
On Tue, 2020-03-10 at 13:26 +, Ali Alnubani wrote: > Hi Luca, > > > -Original Message- > > From: > > luca.bocca...@gmail.com > > < > > luca.bocca...@gmail.com > > > > > Sent: Monday, March 2, 2020 1:11 PM > > To: > > sta...@dpdk.org > > > > Cc: > > dev@dpdk.org > > ; Abhishek Mara

Re: [dpdk-dev] [PATCH] mem: mark pages as not accessed when reserving VA

2020-03-10 Thread Aaron Conole
David Marchand writes: > When the memory allocator reserves virtual addresses, it still does not > know what they will be used for. > Besides, huge areas are reserved for memory hotplug in multiprocess > setups. But most of the pages are unused in the whole life of the > processes. > > Change pro

Re: [dpdk-dev] [RFC v6] regexdev: introduce regexdev subsystem

2020-03-10 Thread Pavan Nikhilesh Bhagavatula
Hi Ori, >+ >+/** >+ * The generic *rte_regex_ops* structure to hold the RegEx attributes >+ * for enqueue and dequeue operation. >+ */ >+struct rte_regex_ops { >+ /* W0 */ >+ uint16_t req_flags; >+ /**< Request flags for the RegEx ops. >+ * @see RTE_REGEX_OPS_REQ_* >+

[dpdk-dev] [PATCH] eal/service: fix exit by resetting service lcores

2020-03-10 Thread Harry van Haaren
This commit releases all service cores from thier role, returning them to ROLE_RTE on rte_service_finalize(). This may fix an issue relating to the service cores causing a race-condition on eal_cleanup(), where the service core could still be executing while the main thread has already free-d the

Re: [dpdk-dev] [RFC] service: stop lcore threads before 'finalize'

2020-03-10 Thread Van Haaren, Harry
> -Original Message- > From: David Marchand > Sent: Tuesday, March 10, 2020 1:05 PM > To: Van Haaren, Harry > Cc: Aaron Conole ; dev > Subject: Re: [RFC] service: stop lcore threads before 'finalize' > > On Fri, Feb 21, 2020 at 1:28 PM Van Haaren, Harry > wrote: > > > > Hi David, > >

Re: [dpdk-dev] 19.11.1 patches review and test

2020-03-10 Thread Ali Alnubani
Hi Luca, > -Original Message- > From: luca.bocca...@gmail.com > Sent: Monday, March 2, 2020 1:11 PM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Akhil Goyal ; Ali Alnubani ; > benjamin.wal...@intel.com; David Christensen ; > Hemant Agrawal ; Ian Stokes > ; Jerin Jacob ;

Re: [dpdk-dev] [PATCH v3] app: test: measure libipsec performance

2020-03-10 Thread Ananyev, Konstantin
> 05/03/2020 23:51, Ananyev, Konstantin: > > > > > 05/03/2020 12:45, Ananyev, Konstantin: > > > > I think the header need to be "app/test", or "test/ipsec". > > > > > > It should be "test/ipsec" as it is an IPsec test command > > > in the test application. > > > > > > > Apart from that: > > > > A

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-gw: fix gcc 10 maybe-uninitialized warning

2020-03-10 Thread Ananyev, Konstantin
Hi Kevin, > gcc 10.0.1 reports: > > ../examples/ipsec-secgw/ipsec_process.c: In function ‘ipsec_process’: > ../examples/ipsec-secgw/ipsec_process.c:132:34: > error: ‘grp.m’ may be used uninitialized in this function > [-Werror=maybe-uninitialized] > 132 |grp[n].cnt = pkts + i - grp[n].m; >

Re: [dpdk-dev] [RFC] service: stop lcore threads before 'finalize'

2020-03-10 Thread David Marchand
On Fri, Feb 21, 2020 at 1:28 PM Van Haaren, Harry wrote: > > > -Original Message- > > From: David Marchand > > Sent: Thursday, February 20, 2020 1:25 PM > > To: Van Haaren, Harry > > Cc: Aaron Conole ; dev > > Subject: Re: [RFC] service: stop lcore threads before 'finalize' > > > > On M

Re: [dpdk-dev] [PATCH] vhost: make iotlb cache name unique among multi processes

2020-03-10 Thread Maxime Coquelin
On 3/10/20 1:44 PM, Van Haaren, Harry wrote: >> -Original Message- >> From: dev On Behalf Of Ye Xiaolong >> Sent: Tuesday, March 10, 2020 11:32 AM >> To: Itsuro Oda >> Cc: dev@dpdk.org; maxime.coque...@redhat.com; Wang, Zhihong >> ; sta...@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] vh

Re: [dpdk-dev] [PATCH v2] eal/ppc64: improve rte_rdtsc with ppc_get_timebase

2020-03-10 Thread David Marchand
On Fri, Jan 31, 2020 at 11:04 PM Thinh Tran wrote: > > __ppc_get_timebase() is GNU extension and is more efficient > > v2: Advoid breaking other ppc_64 flatforms. The __ppc_get_timebase() > seems to be specific to powerpc platform and with GLIBC. dpdk only supports glibc at the moment.

Re: [dpdk-dev] Questions on service core feature implementation

2020-03-10 Thread Van Haaren, Harry
> -Original Message- > From: Honnappa Nagarahalli > Sent: Saturday, March 7, 2020 1:15 AM > To: Van Haaren, Harry > Cc: dev@dpdk.org; Phil Yang ; Gavin Hu > ; nd ; nd > Subject: Questions on service core feature implementation > > Hi Harry, Hey Honnappa, > I have few observation

Re: [dpdk-dev] [PATCH] vhost: make iotlb cache name unique among multi processes

2020-03-10 Thread Van Haaren, Harry
> -Original Message- > From: dev On Behalf Of Ye Xiaolong > Sent: Tuesday, March 10, 2020 11:32 AM > To: Itsuro Oda > Cc: dev@dpdk.org; maxime.coque...@redhat.com; Wang, Zhihong > ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] vhost: make iotlb cache name unique among > multi process

Re: [dpdk-dev] [PATCH v1] examples/ipsec-secgw: load/unload esp-ah DDP file

2020-03-10 Thread Shetty, Praveen
Hi Anoob, Thanks for the review. Please see my response inline. Regards, Praveen -Original Message- From: Anoob Joseph Sent: Friday, March 6, 2020 3:30 PM To: Shetty, Praveen ; dev@dpdk.org; Doherty, Declan ; Iremonger, Bernard ; Ananyev, Konstantin Subject: RE: [dpdk-dev] [PATCH v1

Re: [dpdk-dev] [PATCH] vhost: make iotlb cache name unique among multi processes

2020-03-10 Thread Ye Xiaolong
On 03/10, Itsuro Oda wrote: >Currently, iotlb cache name is comprised of vid and virtqueue >index. For example, "iotlb_cache_0_0". Because vid is assigned >per process, iotlb cache name is not unique among multi processes. >For example a secondary process uses a vhost >(ex. eth_vhost0,iface=/tmp/so

[dpdk-dev] [PATCH v2 3/4] if_proxy: add simple functionality test

2020-03-10 Thread Andrzej Ostruszka
This commit adds simple test of the library notifications. Signed-off-by: Andrzej Ostruszka --- MAINTAINERS | 1 + app/test/Makefile| 5 + app/test/meson.build | 4 + app/test/test_if_proxy.c | 707 +++ 4 files changed, 717 inser

[dpdk-dev] [PATCH v2 4/4] if_proxy: add example application

2020-03-10 Thread Andrzej Ostruszka
Add an example application showing possible library usage. This is a simplified version of l3fwd where: - many performance improvements has been removed in order to simplify logic and put focus on the proxy library usage, - the configuration of forwarding has to be done by the user (using typic

[dpdk-dev] [PATCH v2 1/4] lib: introduce IF Proxy library

2020-03-10 Thread Andrzej Ostruszka
This library allows to designate ports visible to the system (such as Tun/Tap or KNI) as port representors serving as proxies for other DPDK ports. When such a proxy is configured this library initially queries network configuration from the system and later monitors its changes. The information

[dpdk-dev] [PATCH v2 2/4] if_proxy: add library documentation

2020-03-10 Thread Andrzej Ostruszka
This commit adds documentation of IF Proxy library. Signed-off-by: Andrzej Ostruszka --- MAINTAINERS| 1 + doc/guides/prog_guide/if_proxy_lib.rst | 142 + doc/guides/prog_guide/index.rst| 1 + 3 files changed, 144 insertions(+) cre

[dpdk-dev] [PATCH v2 0/4] Introduce IF proxy library

2020-03-10 Thread Andrzej Ostruszka
What is this useful for === Usually, when an ethernet port is assigned to DPDK it vanishes from the system and user looses ability to control it via normal configuration utilities (e.g. those from iproute2 package). Moreover by default DPDK application is not aware of the netw

Re: [dpdk-dev] [PATCH 2/3] cryptodev: remove unused element from device operations

2020-03-10 Thread Trahe, Fiona
> -Original Message- > From: Trybula, ArturX > Sent: Friday, March 6, 2020 11:17 AM > To: dev@dpdk.org; De Lara Guarch, Pablo ; > Doherty, Declan > ; ruifeng.w...@arm.com; g.si...@nxp.com; > ravi1.ku...@amd.com; > akhil.go...@nxp.com; t...@semihalf.com; ano...@marvell.com; Trahe, Fion

Re: [dpdk-dev] [PATCH 1/3] drivers/crypto: remove unused element from device operations

2020-03-10 Thread Trahe, Fiona
> -Original Message- > From: Trybula, ArturX > Sent: Friday, March 6, 2020 11:17 AM > To: dev@dpdk.org; De Lara Guarch, Pablo ; > Doherty, Declan > ; ruifeng.w...@arm.com; g.si...@nxp.com; > ravi1.ku...@amd.com; > akhil.go...@nxp.com; t...@semihalf.com; ano...@marvell.com; Trahe, Fion

[dpdk-dev] [PATCH v4] eal/arm64: fix rdtsc precise version

2020-03-10 Thread Linhaifeng
In order to get more accurate the cntvct_el0 reading, SW must invoke isb and arch_counter_enforce_ordering. Reference of linux kernel: https://git.kernel.org/pub/scm/linux/kernel/git/ torvalds/linux.git/tree/arch/arm64/include/asm/arch_timer.h?h=v5.5#n220 Fixes: ccad39ea0712 ("eal/arm: add cpu cy

Re: [dpdk-dev] [PATCH v3] eal/arm64: fix rdtsc precise version

2020-03-10 Thread Jerin Jacob
On Tue, Mar 10, 2020 at 3:09 PM Linhaifeng wrote: > > In order to get more accurate the cntvct_el0 reading, > SW must invoke isb and arch_counter_enforce_ordering. > > Reference of linux kernel: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/include/asm/arch_t

Re: [dpdk-dev] 19.11.1 patches review and test

2020-03-10 Thread Luca Boccassi
On Tue, 2020-03-10 at 10:13 +, Yu, PingX wrote: > Luca, > Update the test result of Intel part, all passed. > > * Intel(R) Testing > > # Basic Intel(R) NIC testing > * PF(i40e): Passed > * PF(ixgbe): Passed > * PF(ice): Passed > * VF: Passed > * Build or compile: Passed > * Intel NIC single

Re: [dpdk-dev] [PATCH 00/16] NXP DPAAx fixes and enhancements

2020-03-10 Thread Dodji Seketeli
Hello, David Marchand writes: > On Thu, Mar 5, 2020 at 10:19 AM Hemant Agrawal (OSS) > wrote: >> > On Thu, Mar 5, 2020 at 10:06 AM Hemant Agrawal (OSS) >> > wrote: >> > > >> > > Hi David, >> > > > On Mon, Mar 2, 2020 at 10:26 AM Hemant Agrawal >> > > > wrote: >> > > > > >> > > > > This patch

[dpdk-dev] [RFC v6] regexdev: introduce regexdev subsystem

2020-03-10 Thread Ori Kam
From: Jerin Jacob Even though there are some vendors which offer Regex HW offload, due to lack of standard API, It is diffcult for DPDK consumer to use them in a portable way. This _RFC_ attempts to standardize the RegEx/DPI offload APIs for DPDK. This RFC crafted based on SW Regex API framewor

Re: [dpdk-dev] 19.11.1 patches review and test

2020-03-10 Thread Yu, PingX
Luca, Update the test result of Intel part, all passed. * Intel(R) Testing # Basic Intel(R) NIC testing * PF(i40e): Passed * PF(ixgbe): Passed * PF(ice): Passed * VF: Passed * Build or compile: Passed * Intel NIC single core/NIC performance: Passed #Basic cryptodev and virtio testing * vhost/v

[dpdk-dev] [PATCH 3/5] net/sfc/base: reject automatic filter creation by users

2020-03-10 Thread Andrew Rybchenko
From: Igor Romanov The automatic filter priority may only be used by filter implementation, so reject the attempts to create such filters by client drivers. Fixes: f9565517ff4f ("net/sfc/base: import filters support") Cc: sta...@dpdk.org Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybche

[dpdk-dev] [PATCH 4/5] net/sfc/base: refactor filter lookup loop in EF10

2020-03-10 Thread Andrew Rybchenko
From: Igor Romanov The code is refactored to make it more clear and allow for more convenient further changes. Fixes: e7cd430c864f ("net/sfc/base: import SFN7xxx family support") Cc: sta...@dpdk.org Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_fil

[dpdk-dev] [PATCH 5/5] net/sfc/base: handle manual and auto filter clashes in EF10

2020-03-10 Thread Andrew Rybchenko
From: Igor Romanov Make user filters a priority in EF10 datapath. When a manual filter with a specification that is equal to an existing auto filter is inserted, the manual filter: - replaces auto filter if the specification is exclusive; - is inserted along existing auto filter otherwise; In th

[dpdk-dev] [PATCH 1/5] net/sfc: set priority of created filters to manual

2020-03-10 Thread Andrew Rybchenko
From: Igor Romanov The priority should be explicitly set to manual for correct usage of libefx filters. Fixes: a9825ccf5bb8 ("net/sfc: support flow API filters") Cc: sta...@dpdk.org Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_flow.c | 1 + 1 file chang

[dpdk-dev] [PATCH 2/5] net/sfc/base: reduce filter priorities to implemented only

2020-03-10 Thread Andrew Rybchenko
From: Igor Romanov Only implemented filter priorities are manual and auto. Remove unused priorities since exposing unimplemented functionality is of no benefit. Tx filter specification default priority is changed to manual, since required priority does not differ from it in the implementation.

[dpdk-dev] [PATCH 0/5] net/sfc: fix manual and auto filters clash handling

2020-03-10 Thread Andrew Rybchenko
RTE flow API allows to add filters which clash with filters installed by the driver itself. The series fixes the case handling. Igor Romanov (5): net/sfc: set priority of created filters to manual net/sfc/base: reduce filter priorities to implemented only net/sfc/base: reject automatic filte

[dpdk-dev] [PATCH] net/sfc: fix promiscuous and allmulticast toggles errors

2020-03-10 Thread Andrew Rybchenko
From: Igor Romanov Returned errors of ethdev callbacks are negative. Internal sfc funtions return positive errors, so convert them to negative value. Fixes: 9039c8125730 ("ethdev: change promiscuous callbacks to return status") Cc: sta...@dpdk.org Signed-off-by: Igor Romanov Signed-off-by: And

[dpdk-dev] [PATCH v3] eal/arm64: fix rdtsc precise version

2020-03-10 Thread Linhaifeng
In order to get more accurate the cntvct_el0 reading, SW must invoke isb and arch_counter_enforce_ordering. Reference of linux kernel: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/include/asm/arch_timer.h?h=v5.5#n220 Signed-off-by: Haifeng Lin --- .../commo

Re: [dpdk-dev] [PATCH v2] cycles: add isb before read cntvct_el0

2020-03-10 Thread Linhaifeng
> -Original Message- > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Tuesday, March 10, 2020 5:03 PM > To: Linhaifeng > Cc: Gavin Hu ; dev@dpdk.org; tho...@monjalon.net; > chenchanghu ; xudingke > ; Lilijun (Jerry) ; Honnappa > Nagarahalli ; Steve Capper > ; nd > Subject: Re:

Re: [dpdk-dev] [PATCH v1 0/4] add Intel DCF PMD support

2020-03-10 Thread Ferruh Yigit
On 3/10/2020 7:48 AM, Thomas Monjalon wrote: > 10/03/2020 03:00, Wang, Haiyue: >>> -Original Message- >>> From: Kevin Traynor >>> Sent: Tuesday, March 10, 2020 03:34 >>> To: Thomas Monjalon ; David Marchand >>> ; Ye, Xiaolong >>> >>> Cc: Wang, Haiyue ; dev ; Zhang, Qi Z >>> ; Yang, >>>

Re: [dpdk-dev] [PATCH] contigmem: cleanup properly when load fails

2020-03-10 Thread Bruce Richardson
On Mon, Mar 09, 2020 at 03:00:25AM -0700, Jim Harris wrote: > If contigmem is not able to allocate all of the > requested buffers, it frees whatever buffers were > able to be allocated up until that point. > > But the pointers are not set to NULL in that case. > After the load fails, the FreeBSD k

Re: [dpdk-dev] [PATCH v2] net/ice: remove redundant code

2020-03-10 Thread Ye Xiaolong
On 03/09, Qi Zhang wrote: >Remove function ice_clear_queues, since all equivalent code >has already be executed durring ice_rx|tx_queue_stop. s/be/been s/durring/during > >Also function ice_rx|tx_queue_release_mbufs simpley wrapped a s/simpley/simply >function pointer call which is not necessar

[dpdk-dev] [PATCH v2] lpm6: make IPv6 addresses immutable

2020-03-10 Thread Andrzej Ostruszka
None of the public functions modify IPv6 address passed. So their parameters are made const - with the exception of bulk functions. This exception is due to compatibility problems - some compilers report problems with const-casting of array of arrays. Previously only lookup and add were updated t

Re: [dpdk-dev] [PATCH v2] cycles: add isb before read cntvct_el0

2020-03-10 Thread Jerin Jacob
On Tue, Mar 10, 2020 at 1:39 PM Linhaifeng wrote: Please change the subject to more meaningful one: Something like, eal/arm64: fix rdtsc precise version > We should use isb rather than dsb to sync system counter to cntvct_el0. Please tell "why" in commit message, something like this In order

Re: [dpdk-dev] [PATCH v2] cycles: add isb before read cntvct_el0

2020-03-10 Thread Gavin Hu
Reviewed-by: Gavin Hu

  1   2   >