This commit releases all service cores from thier role,
returning them to ROLE_RTE on rte_service_finalize().
This may fix an issue relating to the service cores causing
a race-condition on eal_cleanup(), where the service core
could still be executing while the main thread has already
free-d the service memory, leading to a segfault.
Fixes: 21698354c832 ("service: introduce service cores concept")
Reported-by: David Marchand <david.march...@redhat.com>
Reported-by: Aaron Conole <acon...@redhat.com>
Signed-off-by: Harry van Haaren <harry.van.haa...@intel.com>
---
Please note that this patch is being sent to community for
testing as I cannot reliably reproduce the reported issue on
my local setup (despite code-changes in attempts to make the
problem more visible, and instructions from David on how he
can reproduce it). Email discusson on this topic here:
https://mails.dpdk.org/archives/dev/2020-March/159584.html
---
lib/librte_eal/common/rte_service.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_eal/common/rte_service.c
b/lib/librte_eal/common/rte_service.c
index 7e537b8cd..d400ccf79 100644
--- a/lib/librte_eal/common/rte_service.c
+++ b/lib/librte_eal/common/rte_service.c
@@ -122,6 +122,8 @@ rte_service_finalize(void)
if (!rte_service_library_initialized)
return;
+ rte_service_lcore_reset_all();
+
rte_free(rte_services);
rte_free(lcore_states);
--
2.17.1
