> On 10 Mar 2020, at 16:21, Ferruh Yigit <ferruh.yi...@intel.com> wrote:
>
> On 3/9/2020 9:09 AM, Sunil Kumar Kori wrote:
>> Any DPDK public header file which includes stdbool.h may conflict with
>> local definition of bool, if any, which further results in compilation
>> error. To avoid, used standard stdbool.h instead of defining bool
>> internally.
>>
>> I observed this issue during a development where I included rte_uuid.h
>> into rte_ethdev.h. As rte_ethdev.h is included to PMD driver, it started
>> throwing error as given below:
>>
>> CC ionic_rxtx.o
>> In file included from .../dpdk/build/include/rte_uuid.h:17:0,
>> from .../dpdk/build/include/rte_ethdev.h:161,
>> from .../dpdk/build/include/rte_ethdev_driver.h:18,
>> from .../dpdk/drivers/net/ionic/ionic_rxtx.c:34:
>> .../dpdk/drivers/net/ionic/ionic_osdep.h:48:17: error: two or more data
>> types in declaration specifiers
>> typedef uint8_t bool;
>> ^
>> In file included from .../dpdk/drivers/net/ionic/ionic_dev.h:8:0,
>> from .../dpdk/drivers/net/ionic/ionic.h:13,
>> from .../dpdk/drivers/net/ionic/ionic_mac_api.h:8,
>> from .../dpdk/drivers/net/ionic/ionic_rxtx.c:45:
>> .../dpdk/drivers/net/ionic/ionic_osdep.h:48:1: warning: useless type name in
>> empty declaration
>> typedef uint8_t bool;
>> ^~~~~~~
>> cc1: warning: unrecognized command line option
>> ‘-Wno-address-of-packed-member’
>> .../dpdk/mk/internal/rte.compile-pre.mk:114: recipe for target
>> 'ionic_rxtx.o' failed
>>
>> Fixes: 5ef518098ec6 ("net/ionic: register and initialize adapter")
>> Cc: sta...@dpdk.org
>>
>> Signed-off-by: Sunil Kumar Kori <sk...@marvell.com>
>
> Hi Alfredo,
>
> Do you have any concern/objection on the patch? If not it will be merged soon.
>
> Thanks,
> ferruh
>
Hi Ferruh
it looks fine, please go ahead.
Thank you
Alfredo
