Re: [dpdk-dev] [RFC] mempool: introduce indexed memory pool

2020-03-04 Thread Suanming Mou
Hi Olivier, Sorry for the late response. Xueming is currently busy with other tasks, so I will try continue with the RFC. On 12/26/2019 7:05 PM, Olivier Matz wrote: Hi Xueming, On Thu, Oct 17, 2019 at 06:55:01AM +, Xueming Li wrote: Indexed memory pool manages memory entries by index, a

[dpdk-dev] [PATCH v3] app: test: measure libipsec performance

2020-03-04 Thread Savinay Dharmappa
test app to measures the performance of libipsec api rte_ipsec_pkt_crypto and rte_ipsec_pkt_process. Signed-off-by: Savinay Dharmappa --- MAINTAINERS| 2 + app/test/Makefile | 2 +- app/test/meson.build | 2 + app/test/test_ipsec_perf.c | 618

Re: [dpdk-dev] [PATCH dpdk-dev v2] common/mlx5: fix possible building error

2020-03-04 Thread Tonghao Zhang
On Thu, Mar 5, 2020 at 12:03 AM Matan Azrad wrote: > > > > From: Tonghao Zhang > > On Wed, Mar 4, 2020 at 10:25 PM Matan Azrad > > wrote: > > > > > > > > > > > > From: Tonghao Zhang > > > > On Tue, Mar 3, 2020 at 3:15 PM Matan Azrad > > wrote: > > > > > > > > > > > > > > > Hi > > > > > > > > > >

Re: [dpdk-dev] [PATCH 11/16] net/dpaa: enable Tx queue taildrop

2020-03-04 Thread Gagandeep Singh
Hi Ferruh, > > diff --git a/drivers/bus/dpaa/rte_bus_dpaa_version.map > b/drivers/bus/dpaa/rte_bus_dpaa_version.map > > index e6ca4361e..86f5811b0 100644 > > --- a/drivers/bus/dpaa/rte_bus_dpaa_version.map > > +++ b/drivers/bus/dpaa/rte_bus_dpaa_version.map > > @@ -94,3 +94,10 @@ DPDK_20.0 { > > >

[dpdk-dev] [PATCH] net/bnxt: allow configuring vector mode

2020-03-04 Thread Stephen Hemminger
The bnxt driver has vector mode but it has limitations. For example, rte_flow mark won't work in vector mode. For this reason the user should be able to disable vector mode as part of the config. Make the configuration use the same as other drivers with vector mode: ixge, i40e, ... This will also

Re: [dpdk-dev] [PATCH v2 0/7] vfio/pci: SR-IOV support

2020-03-04 Thread Vamsi Krishna Attunuru
> -Original Message- > From: dev On Behalf Of Alex Williamson > Sent: Thursday, February 20, 2020 12:24 AM > To: k...@vger.kernel.org > Cc: linux-...@vger.kernel.org; linux-ker...@vger.kernel.org; dev@dpdk.org; > mtosa...@redhat.com; tho...@monjalon.net; bl...@debian.org; > jerinjac...@gm

[dpdk-dev] [PATCH] drivers: fix the event dependency on crypto

2020-03-04 Thread Hemant Agrawal
Since the introduction of crypto event adapters, event drivers have dependencies on crypto drivers. /usr/bin/ld: cannot find -lrte_pmd_dpaa_sec collect2: error: ld returned 1 exit status make[9]: *** [.../mk/rte.lib.mk:100: librte_pmd_dpaa_event.so.20.0.2] Error 1 Fixes: b0f66a68ca74 ("ev

Re: [dpdk-dev] [PATCH v2] net/axgbe: add support for Scattered Rx

2020-03-04 Thread Sebastian, Selwin
[AMD Official Use Only - Internal Distribution Only] Thanks and Regards Selwin Sebastian   -Original Message- From: Ferruh Yigit Sent: Wednesday, March 4, 2020 10:44 PM To: Sebastian, Selwin ; dev@dpdk.org Cc: Kumar, Ravi1 Subject: Re: [PATCH v2] net/axgbe: add support for Scattered Rx

[dpdk-dev] [PATCH v3] net/axgbe: add support for Scattered Rx

2020-03-04 Thread ssebasti
From: Selwin Sebastian Enable scattered rx support and add jumbo packet receive capability Signed-off-by: Selwin Sebastian --- doc/guides/nics/features/axgbe.ini | 1 + drivers/net/axgbe/axgbe_common.h | 2 + drivers/net/axgbe/axgbe_ethdev.c | 16 +++- drivers/net/axgbe/axgbe_rxtx.c

[dpdk-dev] [RFC v1 1/1] vfio: set vf token and gain vf device access

2020-03-04 Thread vattunuru
From: Vamsi Attunuru vfio-pci driver enables virtual function access from the DPDK applications when those vf device's physical function is also bound to vfio driver. Patch adds the required configuration and checks to enable DPDK applications to access both pf and it's vf devices through vfio-p

Re: [dpdk-dev] [PATCH v2 2/2] ci: add test suite run without hugepage

2020-03-04 Thread Ruifeng Wang
> -Original Message- > From: Aaron Conole > Sent: Thursday, March 5, 2020 01:31 > To: Ruifeng Wang > Cc: maicolgabr...@hotmail.com; bruce.richard...@intel.com; dev@dpdk.org; > david.march...@redhat.com; Gavin Hu ; Honnappa > Nagarahalli ; juraj.lin...@pantheon.tech; > nd > Subject: Re:

[dpdk-dev] [PATCH v3] net/vhost: fix potential memory leak

2020-03-04 Thread Itsuro Oda
If a vhost device is closed before eth_dev_configure is done to the device, internal resources allocated to the device would not be freed. This patch fixes it. Fixes: 3d01b759d267 ("net/vhost: delay driver setup") Cc: sta...@dpdk.org Signed-off-by: Itsuro Oda Reviewed-by: Xiaolong Ye --- v2: -

[dpdk-dev] [PATCH v2] net/vhost: fix potential memory leak

2020-03-04 Thread Itsuro Oda
If a vhost device is closed before eth_dev_configure is done to the device, internal resources allocated to the device would not be freed. This patch fixes it. Fixes: 3d01b759d267 ("net/vhost: delay driver setup") Cc: sta...@dpdk.org Signed-off-by: Itsuro Oda Reviewd-by: Xiaolong Ye --- v2: - f

Re: [dpdk-dev] [PATCH] net/vhost: fix potential memory leak

2020-03-04 Thread Ye Xiaolong
On 03/03, Itsuro Oda wrote: >If a vhost device is closed before eth_dev_configure is done >to the device, internal resources allocated to the device >does not freed. This patch fixes it. s/does not freed/would not be freed > >Fixes: 3d01b759d267 ("net/vhost: delay driver setup") Cc: sta...@dpdk.

Re: [dpdk-dev] [PATCH] examples/vmdq: fix RSS configuration

2020-03-04 Thread Li, Xiaoyun
> -Original Message- > From: Jiang, JunyuX > Sent: Tuesday, March 3, 2020 17:16 > To: dev@dpdk.org > Cc: Li, Xiaoyun ; Yang, Qiming > ; Jiang, JunyuX ; > sta...@dpdk.org > Subject: [PATCH] examples/vmdq: fix RSS configuration > > In order that all queues of pools can receive packets, add e

[dpdk-dev] Question about rte_hash ext flags on mulitithread read/write

2020-03-04 Thread Lilijun (Jerry)
Hi All, There is some description about RTE hash's multi-thread support in Programmer's Guide. After reading that I still have some questions as follows: 1) There is a sentence " In all modes of operation lookups are thread-safe meaning lookups can be called from multiple threads con

Re: [dpdk-dev] [PATCH v2 5/5] net/fm10k: add switch management support

2020-03-04 Thread Xiaojun Liu
Hi Xiao, Thank you! Did you received my new patches last weekend? BTW, I updated to the latest dpdk as the code base. Best regards, Xiaojun From: Wang, Xiao W Sent: Tuesday, February 25, 2020 7:28 PM To: Xiaojun Liu ; Zhang, Qi Z ; Kwan, Ngai-mint ; Keller, Jac

Re: [dpdk-dev] [RFC 1/1] lib/ring: add scatter gather and serial dequeue APIs

2020-03-04 Thread Honnappa Nagarahalli
> > > > > +/** > > > > + * @internal Reserve ring elements to enqueue several objects on > > > > +the ring > > > > + * > > > > + * @param r > > > > + * A pointer to the ring structure. > > > > + * @param esize > > > > + * The size of ring element, in bytes. It must be a multiple of 4. > > >

Re: [dpdk-dev] Issue with X550 link status

2020-03-04 Thread Dey, Souvik
Little more information. It looks like the below X550 nic is broken as the change related to http://patches.dpdk.org/patch/63951/ is not been backported. The below patch broken the link status for ixgbevf and the fix was done in the above patch but we have only backported the below patch to 18.11

Re: [dpdk-dev] Issue with X550 link status

2020-03-04 Thread Dey, Souvik
The X550 NIC is of the below device id. [root@stdell10 ~]# lspci -nnn | grep -i ether 19:00.0 Ethernet controller [0200]: Intel Corporation Ethernet Controller 10G X550T [8086:1563] (rev 01) 19:00.1 Ethernet controller [0200]: Intel Corporation Ethernet Controller 10G X550T [8086:1563] (rev 01) 1

[dpdk-dev] [PATCH v3 12/14] drivers/baseband: add PMD for FPGA 5GNR FEC

2020-03-04 Thread Nicolas Chautru
From: Nic Chautru Supports for FEC 5G PMD Driver on FPGA card PAC N3000 Signed-off-by: Nic Chautru --- config/common_base |5 + doc/guides/bbdevs/fpga_5gnr_fec.rst| 297 +++ doc/guides/bbdevs/index.rst|1 + doc/gu

[dpdk-dev] [PATCH v3 06/14] test-bbdev: support HARQ validation

2020-03-04 Thread Nicolas Chautru
From: Nic Chautru Adding functionality to validate HARQ for different devices implementation. Adding capacity to fetch HARQ data when required as part of this validation. Signed-off-by: Nic Chautru --- app/test-bbdev/test_bbdev_perf.c | 552 - app/test-bbd

[dpdk-dev] [PATCH v3 13/14] test-bbdev: add support for FPGA driver initialization

2020-03-04 Thread Nicolas Chautru
From: Nic Chautru Adding capacity to initialize the device driver from the test-bbdev environment for the new device FPGA for 5GNR FEC. Signed-off-by: Nic Chautru --- app/test-bbdev/Makefile | 3 +++ app/test-bbdev/meson.build | 3 +++ app/test-bbdev/test_bbdev_perf.c | 58 +++

[dpdk-dev] [PATCH v3 09/14] test-bbdev: support for offload test for LDPC

2020-03-04 Thread Nicolas Chautru
From: Nic Chautru Adding support for the offload latency tests when using the LDPC encoder and decoder operations. Signed-off-by: Nic Chautru --- app/test-bbdev/test_bbdev_perf.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/app/test-bbdev/test

[dpdk-dev] [PATCH v3 11/14] doc: update of testbbdev documentation

2020-03-04 Thread Nicolas Chautru
From: Nic Chautru Update related to the changes introduced by the previous commits. Signed-off-by: Nic Chautru --- doc/guides/tools/testbbdev.rst | 337 +++-- 1 file changed, 291 insertions(+), 46 deletions(-) diff --git a/doc/guides/tools/testbbdev.rst b/d

[dpdk-dev] [PATCH v3 08/14] test-bbdev: support for LDPC interrupt test

2020-03-04 Thread Nicolas Chautru
From: Nic Chautru Adding missing implementation for the interrupt tests for LDPC encoder and decoders. Signed-off-by: Nic Chautru --- app/test-bbdev/test_bbdev_perf.c | 202 ++- 1 file changed, 200 insertions(+), 2 deletions(-) diff --git a/app/test-bbdev/t

[dpdk-dev] [PATCH v3 07/14] test-bbdev: support for performance tests

2020-03-04 Thread Nicolas Chautru
From: Nic Chautru Includes support for BLER wireless performance test with new arguments for SNR and number of iterations for 5G. Signed-off-by: Nic Chautru --- app/test-bbdev/main.c| 29 ++- app/test-bbdev/main.h| 9 +- app/test-bbdev/test_bbdev_perf.c | 523 +++

[dpdk-dev] [PATCH v3 01/14] bbdev: add capability flag for filler bits inclusion in HARQ

2020-03-04 Thread Nicolas Chautru
From: Nic Chautru Adding capability flag for device variants when HARQ buffer may or may not include the filler bits. Minor cosmetic changes in same file. Signed-off-by: Nic Chautru --- lib/librte_bbdev/rte_bbdev.h| 2 ++ lib/librte_bbdev/rte_bbdev_op.h | 12 ++-- 2 files changed,

[dpdk-dev] [PATCH v3 02/14] bbdev: expose device HARQ buffer size at device level

2020-03-04 Thread Nicolas Chautru
From: Nic Chautru This exposes the HARQ buffer size at the device driver level instead of using the capability of a specific operation. This is currently not yet used by a device until future commit. Signed-off-by: Nic Chautru --- drivers/baseband/turbo_sw/bbdev_turbo_software.c | 2 +- lib/l

[dpdk-dev] [PATCH v3 05/14] test-bbdev: rename FPGA LTE macros to be more explicit

2020-03-04 Thread Nicolas Chautru
From: Nic Chautru Self-contained and cosmetic renaming of macro so that to be more explicit for future extension. Signed-off-by: Nic Chautru --- app/test-bbdev/test_bbdev_perf.c | 51 +++- 1 file changed, 19 insertions(+), 32 deletions(-) diff --git a/app/t

[dpdk-dev] [PATCH v3 00/14] bbdev new features

2020-03-04 Thread Nicolas Chautru
v3: squash the release notes updates into the related commits v2: including release note update + fix for typo in commit message reported by DPDK CI. This set includes extending support for the bbdev device drivers for 20.05 and notably add a new baseband PMD for FPGA 5GNR FEC implementation.

[dpdk-dev] [PATCH v3 03/14] baseband/turbo_sw: fix the exposed LLR decimals assumption

2020-03-04 Thread Nicolas Chautru
From: Nic Chautru The actual LLR representation was incorrectly assumed to be 2 instead of 4. This would impact wireless performance but is not critical to be back ported on LTS branches. Fixes: c769c711757a ("baseband/turbo_sw: extend for 5G") Signed-off-by: Nic Chautru --- drivers/baseband/

[dpdk-dev] [PATCH v3 14/14] doc: add feature matrix table for bbdev devices

2020-03-04 Thread Nicolas Chautru
From: Nic Chautru Adding missing overview page in documentation with comparison of feature set by PMD implementation. Signed-off-by: Nic Chautru --- .gitignore | 1 + doc/guides/bbdevs/features/default.ini | 16 doc/guides/bbdevs/featur

[dpdk-dev] [PATCH v3 04/14] baseband/turbo_sw: support large size code block

2020-03-04 Thread Nicolas Chautru
From: Nic Chautru This is to support cases when the input data for decoding a code block is larger than 64kB and would not fit as a contiguous block of data into one mbuf. In that case the length from the opearation supersedes the mbug default structure. Signed-off-by: Nic Chautru --- app/test

Re: [dpdk-dev] [PATCH v2] rte_ethdev: safer memory access by calling Rx callback

2020-03-04 Thread 腾讯网关团队
Thank you raising your concerns. I mean, the original wrong code, but using -O3 optimization yielded a correct result. My patch makes the effects of -O3 and -O0 consistent. Unlike other signals that require busy wait, this callback pointer only needs to be read once. So I don't think memory bar

Re: [dpdk-dev] [PATCH v1 00/14] bbdev new features

2020-03-04 Thread Chautru, Nicolas
Monjalon, Thomas: > > Hi Akhil, Thomas, > > Checking whether there is anything on your end or can we have these patches > > merged? > > I did not include the release note update in that serie but will push a > > trivial patchset for this later on if that's okay. > Why not including the release

[dpdk-dev] [PATCH v2 12/15] drivers/baseband: add PMD for FPGA 5GNR FEC

2020-03-04 Thread Nicolas Chautru
From: Nic Chautru Supports for FEC 5G PMD Driver on FPGA card PAC N3000 Signed-off-by: Nic Chautru --- config/common_base |5 + doc/guides/bbdevs/fpga_5gnr_fec.rst| 297 +++ doc/guides/bbdevs/index.rst|1 + driver

[dpdk-dev] [PATCH v2 11/15] doc: update of testbbdev documentation

2020-03-04 Thread Nicolas Chautru
From: Nic Chautru Update related to the changes introduced by the previous commits. Signed-off-by: Nic Chautru --- doc/guides/tools/testbbdev.rst | 337 +++-- 1 file changed, 291 insertions(+), 46 deletions(-) diff --git a/doc/guides/tools/testbbdev.rst b/d

[dpdk-dev] [PATCH v2 15/15] doc: add release note for bbdev PMD update

2020-03-04 Thread Nicolas Chautru
Add release note update related to the changes to the bbdev PMD in 20.05. Signed-off-by: Nicolas Chautru --- doc/guides/rel_notes/release_20_05.rst | 12 1 file changed, 12 insertions(+) diff --git a/doc/guides/rel_notes/release_20_05.rst b/doc/guides/rel_notes/release_20_05.rst i

[dpdk-dev] [PATCH v2 14/15] doc: add feature matrix table for bbdev devices

2020-03-04 Thread Nicolas Chautru
From: Nic Chautru Adding missing overview page in documentation with comparison of feature set by PMD implementation. Signed-off-by: Nic Chautru --- .gitignore | 1 + doc/guides/bbdevs/features/default.ini | 16 doc/guides/bbdevs/featur

[dpdk-dev] [PATCH v2 13/15] test-bbdev: add support for FPGA driver initialization

2020-03-04 Thread Nicolas Chautru
From: Nic Chautru Adding capacity to initialize the device driver from the test-bbdev environment for the new device FPGA for 5GNR FEC. Signed-off-by: Nic Chautru --- app/test-bbdev/Makefile | 3 +++ app/test-bbdev/meson.build | 3 +++ app/test-bbdev/test_bbdev_perf.c | 58 +++

[dpdk-dev] [PATCH v2 05/15] test-bbdev: rename FPGA LTE macros to be more explicit

2020-03-04 Thread Nicolas Chautru
From: Nic Chautru Self-contained and cosmetic renaming of macro so that to be more explict for future extension. Signed-off-by: Nic Chautru --- app/test-bbdev/test_bbdev_perf.c | 51 +++- 1 file changed, 19 insertions(+), 32 deletions(-) diff --git a/app/te

[dpdk-dev] [PATCH v2 09/15] test-bbdev: support for offload test for LDPC

2020-03-04 Thread Nicolas Chautru
From: Nic Chautru Adding support for the offload latency tests when using the LDPC encoder and decoder operations. Signed-off-by: Nic Chautru --- app/test-bbdev/test_bbdev_perf.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/app/test-bbdev/test

[dpdk-dev] [PATCH v2 08/15] test-bbdev: support for LDPC interrupt test

2020-03-04 Thread Nicolas Chautru
From: Nic Chautru Adding missing implementation for the interrupt tests for LDPC encoder and decoders. Signed-off-by: Nic Chautru --- app/test-bbdev/test_bbdev_perf.c | 202 ++- 1 file changed, 200 insertions(+), 2 deletions(-) diff --git a/app/test-bbdev/t

[dpdk-dev] [PATCH v2 04/15] baseband/turbo_sw: support large size code block

2020-03-04 Thread Nicolas Chautru
From: Nic Chautru This is to support cases when the input data for decoding a code block is larger than 64kB and would not fit as a contiguous block of data into one mbuf. In that case the length from the opearation supersedes the mbug default structure. Signed-off-by: Nic Chautru --- app/test

[dpdk-dev] [PATCH v2 07/15] test-bbdev: support for performance tests

2020-03-04 Thread Nicolas Chautru
From: Nic Chautru Includes support for BLER wireless performance test with new arguments for SNR and number of iterations for 5G. Signed-off-by: Nic Chautru --- app/test-bbdev/main.c| 29 ++- app/test-bbdev/main.h| 9 +- app/test-bbdev/test_bbdev_perf.c | 523 +++

[dpdk-dev] [PATCH v2 06/15] test-bbdev: support HARQ validation

2020-03-04 Thread Nicolas Chautru
From: Nic Chautru Adding functionality to validate HARQ for different devices implementation. Adding capacity to fetch HARQ data when required as part of this validation. Signed-off-by: Nic Chautru --- app/test-bbdev/test_bbdev_perf.c | 552 - app/test-bbd

[dpdk-dev] [PATCH v2 03/15] baseband/turbo_sw: fix the exposed LLR decimals assumption

2020-03-04 Thread Nicolas Chautru
From: Nic Chautru The actual LLR representation was incorrectly assumed to be 2 instead of 4. This would impact wireless performance but is not critical to be back ported on LTS branches. Fixes: c769c711757a ("baseband/turbo_sw: extend for 5G") Signed-off-by: Nic Chautru --- drivers/baseband/

[dpdk-dev] [PATCH v2 02/15] bbdev: expose device HARQ buffer size at device level

2020-03-04 Thread Nicolas Chautru
From: Nic Chautru This exposes the HARQ buffer size at the device driver level instead of using the capability of a specific operation. This is currently not yet used by a device until future commit. Signed-off-by: Nic Chautru --- drivers/baseband/turbo_sw/bbdev_turbo_software.c | 2 +- lib/l

[dpdk-dev] [PATCH v2 00/15] bbdev new features

2020-03-04 Thread Nicolas Chautru
v2: including release note update + fix for typo in commit message reported by DPDK CI. This set includes extending support for the bbdev device drivers for 20.05 and notably add a new baseband PMD for FPGA 5GNR FEC implementation. Documentation is updated as well accordingly. Nic Chautru (

[dpdk-dev] [PATCH v2 01/15] bbdev: add capability flag for filler bits inclusion in HARQ

2020-03-04 Thread Nicolas Chautru
From: Nic Chautru Adding capability flag for device variants when HARQ buffer may or may not include the filler bits. Minor cosmetic changes in same file. Signed-off-by: Nic Chautru --- lib/librte_bbdev/rte_bbdev.h| 2 ++ lib/librte_bbdev/rte_bbdev_op.h | 12 ++-- 2 files changed,

[dpdk-dev] Issue with X550 link status

2020-03-04 Thread Dey, Souvik
Hi All, After upgrading to DPDK 18.11.6 LTS release from 18.11.2 the link_update call for link status update is not working for X550 NICs SR-IOV enabled. On debugging it looks like the change introduced as a part of this patch is causing the issue. https://patches.dpdk.org/patch/

Re: [dpdk-dev] Need Help for Intel - i40e , XL710 40GbE Controller

2020-03-04 Thread Avner Taieb
Thanks Lee. I already read it and tried the potential remedy that is suggested i.e. enabling the multi driver support , but it didn't solved the problem. Are there more setting documented anywhere ? On Wed, Mar 4, 2020 at 7:33 PM Roberts, Lee A. wrote: > See https://www.kernel.org/doc/Documentat

Re: [dpdk-dev] [PATCH v2] rte_ethdev: safer memory access by calling Rx callback

2020-03-04 Thread Stephen Hemminger
On Thu, 5 Mar 2020 01:33:49 +0800 ZY Qiu wrote: > When compiling with -O0, > the compiler does not optimize two memory accesses into one. > Leads to accessing a null pointer when queue post Rx burst callback > removal while traffic is running. > See rte_eth_tx_burst function. > > Signed-off-by:

Re: [dpdk-dev] [PATCH] rte_ethdev: fix unsafe memory access by calling RX callback.

2020-03-04 Thread 腾讯网关团队
So in my patch it was changed to only one memory access. 发件人: Stephen Hemminger 发送时间: 2020年3月5日 1:37 收件人: tgw_team(腾讯网关团队) 抄送: Tencent TGW team; Thomas Monjalon; Ferruh Yigit; Andrew Rybchenko; dev@dpdk.org 主题: Re: [dpdk-dev] [PATCH] rte_ethdev: fix unsafe memor

Re: [dpdk-dev] [PATCH] rte_ethdev: fix unsafe memory access by calling RX callback.(Internet mail)

2020-03-04 Thread Stephen Hemminger
On Wed, 4 Mar 2020 16:38:13 + tgw_team(腾讯网关团队) wrote: > Sorry, I`ll use a real name in patch v2. > > I don't think this is a TOCTOU question. > The original code works fine when compiled with the -O3 option. > At this point the compiler will optimize to one memory access. > But when compiled

[dpdk-dev] [PATCH v2] rte_ethdev: safer memory access by calling Rx callback

2020-03-04 Thread ZY Qiu
When compiling with -O0, the compiler does not optimize two memory accesses into one. Leads to accessing a null pointer when queue post Rx burst callback removal while traffic is running. See rte_eth_tx_burst function. Signed-off-by: ZY Qiu --- lib/librte_ethdev/rte_ethdev.h | 6 ++ 1 file c

Re: [dpdk-dev] Need Help for Intel - i40e , XL710 40GbE Controller

2020-03-04 Thread Roberts, Lee A.
See https://www.kernel.org/doc/Documentation/networking/i40e.rst, in particular, read the paragraph on "Unexpected Issues when the device driver and DPDK share a device". - Lee -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Avner Taieb Se

Re: [dpdk-dev] [PATCH v2 2/2] ci: add test suite run without hugepage

2020-03-04 Thread Aaron Conole
Ruifeng Wang writes: > This test suite is derived from fast-tests suite. Cases in this > suite are run with '--no-huge' flag. > > The suite aims to cover as many as possible test cases out of the > fast-tests suites in the environments without huge pages support, > like containers. > > Signed-off

Re: [dpdk-dev] [PATCH v2] net/axgbe: add support for Scattered Rx

2020-03-04 Thread Ferruh Yigit
On 3/4/2020 1:44 PM, sseba...@amd.com wrote: > From: Selwin Sebastian > > Enable scattered rx support and add jumbo packet receive capability > > Signed-off-by: Selwin Sebastian <...> > @@ -249,6 +249,10 @@ axgbe_dev_start(struct rte_eth_dev *dev) > { > struct axgbe_port *pdata = dev->

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: fix promisc or all-multi mode reporting if dropped

2020-03-04 Thread Ferruh Yigit
On 3/4/2020 3:01 PM, Andrew Rybchenko wrote: > Requested promiscuous or all-multicast mode may be dropped on port > start if FW denies to enable it (e.g. because of no permission > in the case of VF). Return applied value on get. > > Fixes: f5258439ee5d ("net/sfc: avoid failure on port start if Rx

[dpdk-dev] Need Help for Intel - i40e , XL710 40GbE Controller

2020-03-04 Thread Avner Taieb
Hi, I am using XL710 40GbE Controller with two ports. The way I am using them is one port is configured to vfio-pci for using with dpdk in user space and the other is left to the kernel driver and for a seperate application that does not use DPDK. As soon as DPDK initialize and start the port, the

Re: [dpdk-dev] [PATCH v1 1/2] doc/failsafe: improve fail-safe documentation

2020-03-04 Thread Ferruh Yigit
On 2/22/2020 12:14 AM, Gaetan Rivet wrote: > Reading the fail-safe doc with a few years added, a few phrasing > choices are ambiguous or confusing. > > Signed-off-by: Gaetan Rivet > > Acked-by: Marko Kovacevic > Series applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] rte_ethdev: fix unsafe memory access by calling RX callback.(Internet mail)

2020-03-04 Thread 腾讯网关团队
Sorry, I`ll use a real name in patch v2. I don't think this is a TOCTOU question. The original code works fine when compiled with the -O3 option. At this point the compiler will optimize to one memory access. But when compiled with -O0, there will be two memory accesses, which is wrong. This chang

Re: [dpdk-dev] [PATCH] rte_ethdev: fix unsafe memory access by calling RX callback.

2020-03-04 Thread 腾讯网关团队
As a newcomer, I'm sorry for my mistakes. I will try to do better in the future. >On 3/4/20 5:05 PM, Tencent TGW team wrote: >> When compiling with -O0, >> the compiler does not optimize two memory accesses into one. >> Leads to accessing a null pointer when calling the RX callback. >> The way to

Re: [dpdk-dev] [PATCH] rte_ethdev: fix unsafe memory access by calling RX callback.

2020-03-04 Thread Stephen Hemminger
On Wed, 4 Mar 2020 22:05:43 +0800 Tencent TGW team wrote: > When compiling with -O0, > the compiler does not optimize two memory accesses into one. > Leads to accessing a null pointer when calling the RX callback. > The way to access the TX callback is correct. > > Signed-off-by: Tencent TGW te

Re: [dpdk-dev] [RFC] A REST API based daemon of dpdk-devbind.py

2020-03-04 Thread Stephen Hemminger
On Wed, 4 Mar 2020 12:11:05 +0500 Muhammad Ahmad wrote: > Hi, > I have observed that the dpdk-devbind.py is an interactive tool and > not quite useful for automated testing in CI/CD. We are planning to > create “dpdk-usertools-server” for making it streamlined. > The idea is to create a separate

Re: [dpdk-dev] [PATCH dpdk-dev v2] common/mlx5: fix possible building error

2020-03-04 Thread Matan Azrad
From: Tonghao Zhang > On Wed, Mar 4, 2020 at 10:25 PM Matan Azrad > wrote: > > > > > > > > From: Tonghao Zhang > > > On Tue, Mar 3, 2020 at 3:15 PM Matan Azrad > wrote: > > > > > > > > > > > > Hi > > > > > > > > From: xiangxia.m@gmail.com > > > > > From: Tonghao Zhang > > > > > > > > > > W

Re: [dpdk-dev] [PATCH] Fix various typos found by Lintian

2020-03-04 Thread Luca Boccassi
On Wed, 2020-03-04 at 14:34 +, Kevin Traynor wrote: > On 29/02/2020 16:37, > luca.bocca...@gmail.com > wrote: > > From: Luca Boccassi < > > bl...@debian.org > > > > > > > Cc: > > sta...@dpdk.org > > > > > > Signed-off-by: Luca Boccassi < > > bl...@debian.org > > > > > --- > > Debian's lin

Re: [dpdk-dev] [PATCH] mempool: sort the rte_mempool_ops by name

2020-03-04 Thread Tonghao Zhang
On Wed, Mar 4, 2020 at 11:14 PM Jerin Jacob wrote: > > On Wed, Mar 4, 2020 at 8:17 PM Tonghao Zhang wrote: > > > > On Wed, Mar 4, 2020 at 9:33 PM Jerin Jacob wrote: > > > > > > On Wed, Mar 4, 2020 at 6:48 PM Tonghao Zhang > > > wrote: > > > > > > > > On Mon, Mar 2, 2020 at 9:45 PM Jerin Jacob

Re: [dpdk-dev] [PATCH] mempool: sort the rte_mempool_ops by name

2020-03-04 Thread Jerin Jacob
On Wed, Mar 4, 2020 at 8:17 PM Tonghao Zhang wrote: > > On Wed, Mar 4, 2020 at 9:33 PM Jerin Jacob wrote: > > > > On Wed, Mar 4, 2020 at 6:48 PM Tonghao Zhang > > wrote: > > > > > > On Mon, Mar 2, 2020 at 9:45 PM Jerin Jacob wrote: > > > > > > > > On Mon, Mar 2, 2020 at 7:27 AM wrote: > > > >

Re: [dpdk-dev] [PATCH dpdk-dev v2] common/mlx5: fix possible building error

2020-03-04 Thread Tonghao Zhang
On Wed, Mar 4, 2020 at 10:25 PM Matan Azrad wrote: > > > > From: Tonghao Zhang > > On Tue, Mar 3, 2020 at 3:15 PM Matan Azrad wrote: > > > > > > > > > Hi > > > > > > From: xiangxia.m@gmail.com > > > > From: Tonghao Zhang > > > > > > > > When setting the CONFIG_RTE_BUILD_SHARED_LIB to y, and

[dpdk-dev] [PATCH] net/sfc: fix promisc or all-multi mode reporting if dropped

2020-03-04 Thread Andrew Rybchenko
Requested promiscuous or all-multicast mode may be dropped on port start if FW denies to enable it (e.g. because of no permission in the case of VF). Return applied value on get. Fixes: f5258439ee5d ("net/sfc: avoid failure on port start if Rx mode is rejected") Cc: sta...@dpdk.org Signed-off-by

Re: [dpdk-dev] [PATCH] mempool: sort the rte_mempool_ops by name

2020-03-04 Thread Tonghao Zhang
On Wed, Mar 4, 2020 at 9:33 PM Jerin Jacob wrote: > > On Wed, Mar 4, 2020 at 6:48 PM Tonghao Zhang wrote: > > > > On Mon, Mar 2, 2020 at 9:45 PM Jerin Jacob wrote: > > > > > > On Mon, Mar 2, 2020 at 7:27 AM wrote: > > > > > > > > From: Tonghao Zhang > > > > > > > > The order of mempool initiat

Re: [dpdk-dev] [PATCH] Fix various typos found by Lintian

2020-03-04 Thread Kevin Traynor
On 29/02/2020 16:37, luca.bocca...@gmail.com wrote: > From: Luca Boccassi > > Cc: sta...@dpdk.org > > Signed-off-by: Luca Boccassi > --- > Debian's linter is getting more and more annoy^^smart and now parses binaries > for typos too - CC stable to get it off my back in the next release > Mino

Re: [dpdk-dev] [PATCH dpdk-dev v2] common/mlx5: fix possible building error

2020-03-04 Thread Matan Azrad
From: Tonghao Zhang > On Tue, Mar 3, 2020 at 3:15 PM Matan Azrad wrote: > > > > > > Hi > > > > From: xiangxia.m@gmail.com > > > From: Tonghao Zhang > > > > > > When setting the CONFIG_RTE_BUILD_SHARED_LIB to y, and build the > > > mlx5 pmd, there is a building error. > > > To fix it, add RT

Re: [dpdk-dev] [PATCH] rte_ethdev: fix unsafe memory access by calling RX callback.

2020-03-04 Thread Andrew Rybchenko
On 3/4/20 5:05 PM, Tencent TGW team wrote: > When compiling with -O0, > the compiler does not optimize two memory accesses into one. > Leads to accessing a null pointer when calling the RX callback. > The way to access the TX callback is correct. It looks like the patch is not passed through check

[dpdk-dev] [PATCH] rte_ethdev: fix unsafe memory access by calling RX callback.

2020-03-04 Thread Tencent TGW team
When compiling with -O0, the compiler does not optimize two memory accesses into one. Leads to accessing a null pointer when calling the RX callback. The way to access the TX callback is correct. Signed-off-by: Tencent TGW team --- lib/librte_ethdev/rte_ethdev.h | 6 ++ 1 file changed, 2 ins

Re: [dpdk-dev] [RFC] A REST API based daemon of dpdk-devbind.py

2020-03-04 Thread Bruce Richardson
On Wed, Mar 04, 2020 at 12:11:05PM +0500, Muhammad Ahmad wrote: > Hi, > I have observed that the dpdk-devbind.py is an interactive tool and > not quite useful for automated testing in CI/CD. We are planning to > create “dpdk-usertools-server” for making it streamlined. > The idea is to create a sep

Re: [dpdk-dev] [PATCH dpdk-dev v2] common/mlx5: fix possible building error

2020-03-04 Thread Tonghao Zhang
On Tue, Mar 3, 2020 at 3:15 PM Matan Azrad wrote: > > > Hi > > From: xiangxia.m@gmail.com > > From: Tonghao Zhang > > > > When setting the CONFIG_RTE_BUILD_SHARED_LIB to y, and build the mlx5 > > pmd, there is a building error. > > To fix it, add RTE_IBVERBS_LINK_DLOPEN to include relative co

Re: [dpdk-dev] [PATCH v3 1/1] net/octeontx: fix meson build for disabled octeontx drivers

2020-03-04 Thread Bruce Richardson
On Wed, Mar 04, 2020 at 11:17:04AM +0530, agup...@marvell.com wrote: > From: Amit Gupta > > Add a condition to check if octeontx drivers are disabled. > octeontx drivers are built only if dependent drivers i.e. > ethdev, mempool and common/octeontx are enabled. > > Bugzilla ID: 387 > > Fixes: 7

[dpdk-dev] [PATCH v2] net/axgbe: add support for Scattered Rx

2020-03-04 Thread ssebasti
From: Selwin Sebastian Enable scattered rx support and add jumbo packet receive capability Signed-off-by: Selwin Sebastian --- doc/guides/nics/features/axgbe.ini | 1 + drivers/net/axgbe/axgbe_common.h | 2 + drivers/net/axgbe/axgbe_ethdev.c | 17 +++- drivers/net/axgbe/axgbe_rxtx.c

Re: [dpdk-dev] [PATCH 2/2] test/crypto: Add AES-256 DOCSIS test vectors

2020-03-04 Thread Trahe, Fiona
Hi Máirtin, Wasn't this patch already upstreamed with the QAT patchset? If so no need to resend. Fiona > -Original Message- > From: O'loingsigh, Mairtin > Sent: Wednesday, March 4, 2020 9:18 AM > To: Trahe, Fiona ; akhil.go...@nxp.com > Cc: dev@dpdk.org; O'loingsigh, Mairtin > Subject:

Re: [dpdk-dev] [PATCH] mempool: sort the rte_mempool_ops by name

2020-03-04 Thread Jerin Jacob
On Wed, Mar 4, 2020 at 6:48 PM Tonghao Zhang wrote: > > On Mon, Mar 2, 2020 at 9:45 PM Jerin Jacob wrote: > > > > On Mon, Mar 2, 2020 at 7:27 AM wrote: > > > > > > From: Tonghao Zhang > > > > > > The order of mempool initiation affects mempool index in the > > > rte_mempool_ops_table. For examp

[dpdk-dev] [PATCH 2/2] doc: fix QAT GEN3 marketing name in release notes

2020-03-04 Thread Adam Dybkowski
This patch fixes the marketing name of the QAT GEN3 to P5xxx. Fixes: aa983f03ad2e ("crypto/qat: handle Single Pass Crypto Requests on GEN3") Cc: sta...@dpdk.org Signed-off-by: Adam Dybkowski --- doc/guides/rel_notes/release_19_11.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[dpdk-dev] [PATCH 1/2] compress/qat: fix QAT GEN3 marketing name

2020-03-04 Thread Adam Dybkowski
This patch fixes the marketing name of the QAT GEN3 to P5xxx. Updates this name mentioned in the compression PMD as well as in the documentation. Fixes: a124830a6f00 ("compress/qat: enable dynamic huffman encoding") Fixes: 1f5e4053f9b4 ("common/qat: support GEN3 devices") Cc: sta...@dpdk.org Sign

Re: [dpdk-dev] [PATCH] mempool: sort the rte_mempool_ops by name

2020-03-04 Thread Tonghao Zhang
On Mon, Mar 2, 2020 at 9:45 PM Jerin Jacob wrote: > > On Mon, Mar 2, 2020 at 7:27 AM wrote: > > > > From: Tonghao Zhang > > > > The order of mempool initiation affects mempool index in the > > rte_mempool_ops_table. For example, when building APPs with: > > > > $ gcc -lrte_mempool_bucket -lrte_m

Re: [dpdk-dev] [PATCH v1] mbuf: replace zero-length marker with unnamed union

2020-03-04 Thread Kevin Traynor
On 03/03/2020 16:27, Gavin Hu wrote: > gcc 10.0.1 reports: error: array subscript 0 is outside the bounds of an > interior zero-length array 'RTE_MARKER64' {aka 'long unsigned int[0]'} > [-Werror=zero-length-bounds] 310 | *(uint64_t *)(&mbuf->rearm_data) = > val; > > Declaring zero-length arrays

Re: [dpdk-dev] pci device access from dpdk secondary process with igb_uio

2020-03-04 Thread Ferruh Yigit
On 1/2/2020 6:58 PM, vijay mohan wrote: > On Thu, 26 Dec 2019 at 16:58, vijay mohan wrote: >> >> Hi All, >> I am trying to use pci vf device with secondary process in a multiple >> process mode and finding pci_dev->mem_resource[0].addr to be NULL. This >> happens when the pci device is attached

[dpdk-dev] [Bug 417] CentOS7/RHEL7 nasm version too old for intel-ipsec-mb

2020-03-04 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=417 Bug ID: 417 Summary: CentOS7/RHEL7 nasm version too old for intel-ipsec-mb Product: DPDK Version: 20.02 Hardware: All OS: All Status: UNCONFIRMED Severity: normal

[dpdk-dev] [PATCH] net/ice: remove bulk alloc compile option

2020-03-04 Thread Qi Zhang
Remove CONFIG_RTE_LIBRTE_ICE_RX_ALLOW_BULK_ALLOC with below consideration: 1. a default Rx path can always be selected by setting a proper rx_free_thresh value at runtime, see ice_check_rx_burst_bulk_alloc_preconditions. 2. its not a big deal to always reserve more space for desc ring. "

[dpdk-dev] [PATCH] net/ice: remove bulk alloc compile option

2020-03-04 Thread Qi Zhang
Remove CONFIG_RTE_LIBRTE_ICE_RX_ALLOW_BULK_ALLOC with below consideration: 1. a default Rx path can always be selected by setting a proper rx_free_thresh value at runtime, see ice_check_rx_burst_bulk_alloc_preconditions. 2. its not a big deal to always reserve more space for desc ring. "

Re: [dpdk-dev] [PATCH 0/3] examples: fix building with GCC 10

2020-03-04 Thread David Marchand
On Wed, Mar 4, 2020 at 10:37 AM David Marchand wrote: > > On Wed, Feb 5, 2020 at 2:47 PM Timothy Redaelli wrote: > > > > GCC 10 defaults to -fno-common, this means a linker error will now be > > reported if the same global variable is defined in more than one > > compilation unit. > > > > See htt

Re: [dpdk-dev] [PATCH 0/3] fix building with GCC 10

2020-03-04 Thread David Marchand
On Wed, Feb 5, 2020 at 1:51 PM Timothy Redaelli wrote: > GCC 10 defaults to -fno-common, this means a linker error will now be > reported if the same global variable is defined in more than one > compilation unit. > > See https://gcc.gnu.org/gcc-10/porting_to.html for more informations. > > I didn

[dpdk-dev] [PATCH v3] doc: plan splitting the ethdev ops struct

2020-03-04 Thread Ferruh Yigit
For the ABI compatibility it is better to hide internal data structures from the application as much as possible. But because of some inline functions 'struct eth_dev_ops' can't be hidden completely. Plan is to split the 'struct eth_dev_ops' into two as ones used by inline functions and ones not u

Re: [dpdk-dev] [PATCH 0/3] examples: fix building with GCC 10

2020-03-04 Thread David Marchand
On Wed, Feb 5, 2020 at 2:47 PM Timothy Redaelli wrote: > > GCC 10 defaults to -fno-common, this means a linker error will now be > reported if the same global variable is defined in more than one > compilation unit. > > See https://gcc.gnu.org/gcc-10/porting_to.html for more informations. > > I di

[dpdk-dev] [PATCH 1/2] crypto/aesni_mb: support DOCSIS AES-256

2020-03-04 Thread Mairtin o Loingsigh
This patch adds support for DOCSIS AES-256 when using AESNI-MB Signed-off-by: Mairtin o Loingsigh --- drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c b/drivers/crypto/aesni_

[dpdk-dev] [PATCH 2/2] test/crypto: Add AES-256 DOCSIS test vectors

2020-03-04 Thread Mairtin o Loingsigh
This patch adds test vectors for AES-256 and sets AESNI-MB as the target PMD Signed-off-by: Mairtin o Loingsigh --- app/test/test_cryptodev_aes_test_vectors.h | 176 1 files changed, 176 insertions(+), 0 deletions(-) diff --git a/app/test/test_cryptodev_aes_test_ve

[dpdk-dev] [PATCH 1/2] crypto/aesni_mb: support DOCSIS AES-256

2020-03-04 Thread Mairtin o Loingsigh
This patch adds support for DOCSIS AES-256 when using AESNI-MB Signed-off-by: Mairtin o Loingsigh --- drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c b/drivers/crypto/aesni_

[dpdk-dev] [PATCH 2/2] test/crypto: Add AES-256 DOCSIS test vectors

2020-03-04 Thread Mairtin o Loingsigh
This patch adds test vectors for AES-256 and sets AESNI-MB as the target PMD Signed-off-by: Mairtin o Loingsigh --- app/test/test_cryptodev_aes_test_vectors.h | 176 1 files changed, 176 insertions(+), 0 deletions(-) diff --git a/app/test/test_cryptodev_aes_test_ve

  1   2   >