On Wed, Mar 4, 2020 at 10:37 AM David Marchand <david.march...@redhat.com> wrote: > > On Wed, Feb 5, 2020 at 2:47 PM Timothy Redaelli <tredae...@redhat.com> wrote: > > > > GCC 10 defaults to -fno-common, this means a linker error will now be > > reported if the same global variable is defined in more than one > > compilation unit. > > > > See https://gcc.gnu.org/gcc-10/porting_to.html for more informations. > > > > I didn't put -fcommon to CFLAGS since: > > Compiling with -fno-common is useful on targets for which it provides > > better performance, or if you wish to verify that the program will work > > on other systems that always treat uninitialized variable definitions > > this way. > > from gcc man page > > For the series, > Acked-by: David Marchand <david.march...@redhat.com>
Series applied, thanks. -- David Marchand