Re: [dpdk-dev] [RFC PATCH 0/5] graph: introduce graph subsystem

2020-01-31 Thread Jerin Jacob
On Sat, Feb 1, 2020 at 12:05 AM Ray Kinsella wrote: > > Hi Jerin, Hi Ray, > Much kudos on a huge contribution to the community. All the authors of this patch set spend at least the last 3/4 months to bring this up RFC with performance data with an l3fwd-graph example application. We hope it wou

[dpdk-dev] [PATCH v7 6/9] eal: include SSE4 support for windows

2020-01-31 Thread Pallavi Kadam
Modified \common\include\arch\x86\rte_vect.h to include SSE4 header for Windows. Signed-off-by: Antara Ganesh Kolar Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon Reviewed-by: Keith Wiles --- lib/librte_eal/common/include/arch/x86/rte_vect.h | 4 +++- 1 file changed, 3 insertions(+),

[dpdk-dev] [PATCH v7 5/9] eal: add function to detect process type

2020-01-31 Thread Pallavi Kadam
Adding a function to detect process type, also included header files to contain suitable function declarations and to support extra warning flags. Signed-off-by: Pallavi Kadam Signed-off-by: Antara Ganesh Kolar Reviewed-by: Ranjit Menon Reviewed-by: Keith Wiles --- lib/librte_eal/windows/eal/

[dpdk-dev] [PATCH v7 4/9] eal: getopt implementation for windows

2020-01-31 Thread Pallavi Kadam
Adding getopt files to support parsing option on Windows. The original contribution is under BSD-2 license. https://raw.githubusercontent.com/greenplum-db/libusual/master/usual/getopt.c https://raw.githubusercontent.com/greenplum-db/libusual/master/usual/getopt.h Signed-off-by: Antara Ganesh Kola

[dpdk-dev] [PATCH v7 9/9] eal: add minimum viable code to support parsing

2020-01-31 Thread Pallavi Kadam
Adding specific logic for eal.c to support parsing on Windows. Signed-off-by: Pallavi Kadam Signed-off-by: Antara Ganesh Kolar Reviewed-by: Ranjit Menon Reviewed-by: Keith Wiles --- lib/librte_eal/windows/eal/eal.c | 133 ++- 1 file changed, 130 insertions(+), 3 de

[dpdk-dev] [PATCH v7 3/9] eal: add additional function overrides in windows header files

2020-01-31 Thread Pallavi Kadam
Adding additional function definitions for pthread, cpuset implementation, asprintf implementation, in order to support common code. Signed-off-by: Bruce Richardson Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon Reviewed-by: Keith Wiles --- lib/librte_eal/windows/eal/include/pthread.h

[dpdk-dev] [PATCH v7 2/9] eal: dirent.h implementation for windows

2020-01-31 Thread Pallavi Kadam
Adding dirent.h on Windows to support common code. eal_common_options.c includes this file. The original contribution is under MIT license. https://github.com/tronkko/dirent Signed-off-by: Antara Ganesh Kolar Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon Reviewed-by: Keith Wiles ---

[dpdk-dev] [PATCH v7 7/9] eal: remove syslog and dlfcn support for windows

2020-01-31 Thread Pallavi Kadam
Excluding syslog/ dlfcn definitions and parameters from Windows by adding #ifndef RTE_EXEC_ENV_WINDOWS. Note: This is a temporary change. In future, separate 'unix' directory will be created for unix specific functions. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- lib/librte_eal/

[dpdk-dev] [PATCH v7 0/9] Windows patchset with additional EAL functionalities

2020-01-31 Thread Pallavi Kadam
This patchset includes additional functionalities for Windows EAL to support command-line parsing feature and some EAL common code on Windows. This patchset can be applied to windpdk-next-dev branch in the draft repo. v7 changes: Removed Windows "eal_filesystem.h" for now and will be adde

[dpdk-dev] [PATCH v7 8/9] build: add additional common files support

2020-01-31 Thread Pallavi Kadam
Added support for additional common files in meson build to expand Windows EAL and to support the lcore parsing feature on Windows. Signed-off-by: Pallavi Kadam Signed-off-by: Antara Ganesh Kolar Reviewed-by: Ranjit Menon Reviewed-by: Keith Wiles --- lib/librte_eal/windows/eal/meson.build | 8

[dpdk-dev] [PATCH v7 1/9] license: add license exception for windows

2020-01-31 Thread Pallavi Kadam
The Governing Board and Tech Board have provided exceptions for MIT and BSD-2-Clause license files for DPDK support on Windows. Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- license/exceptions.txt | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/lice

[dpdk-dev] [Bug 388] ixgbe: link state race condition can occur when starting a fiber port

2020-01-31 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=388 Bug ID: 388 Summary: ixgbe: link state race condition can occur when starting a fiber port Product: DPDK Version: 19.08 Hardware: x86 OS: Linux Status: U

[dpdk-dev] [PATCH v2] eal/ppc64: improve rte_rdtsc with ppc_get_timebase

2020-01-31 Thread Thinh Tran
__ppc_get_timebase() is GNU extension and is more efficient v2: Advoid breaking other ppc_64 flatforms. The __ppc_get_timebase() seems to be specific to powerpc platform and with GLIBC. Signed-off-by: Thinh Tran --- lib/librte_eal/common/include/arch/ppc_64/rte_cycles.h | 7 +++

Re: [dpdk-dev] [PATCH v6 03/10] eal: include filesystem implementation for windows

2020-01-31 Thread Pallavi Kadam
Hi Dmitry, Thank you for reviewing the code and for your comments. On 1/30/2020 10:04 PM, Dmitry Kozliuk wrote: Hello Pallavi, +#include "eal_internal_cfg.h" + +/* sets up platform-specific runtime data dir */ +int +eal_create_runtime_dir(void); + +/* returns runtime dir */ +const char * +eal

Re: [dpdk-dev] [PATCH] net/mlx5: make FDB default rule optional

2020-01-31 Thread Kevin Traynor
On 30/01/2020 13:06, Raslan Darawsheh wrote: > Hi, >> -Original Message- >> From: dev On Behalf Of Matan Azrad >> Sent: Tuesday, January 28, 2020 7:07 PM >> To: Slava Ovsiienko >> Cc: dev@dpdk.org; sta...@dpdk.org >> Subject: [dpdk-dev] [PATCH] net/mlx5: make FDB default rule optional >>

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: increase number of qps to lcore_params

2020-01-31 Thread Ananyev, Konstantin
> > > > > Currently only one qp will be used for one core. The number of qps > > > > > can be increased to match the number of lcore params. > > > > > > > > I don't really understand the purpose of that patch > > > > As I understand, all it does - unconditionally increases number of > > > > cry

Re: [dpdk-dev] [PATCH] vhost: flush shadow tx if there is no more packets

2020-01-31 Thread Kevin Traynor
Hi Eugenio, On 29/01/2020 19:33, Eugenio Pérez wrote: > The current implementation of vhost_net in packed vring tries to fill > the shadow vector before send any actual changes to the guest. While > this can be beneficial for the throughput, it conflicts with some > bufferfloats methods like the l

Re: [dpdk-dev] [RFC PATCH 0/5] graph: introduce graph subsystem

2020-01-31 Thread Ray Kinsella
Hi Jerin, Much kudos on a huge contribution to the community. Look forward to spend more time looking at it in the next few days. I'll bite and ask the obvious questions - why would I use rte_graph over FD.io VPP? Ray K On 31/01/2020 17:01, jer...@marvell.com wrote: > From: Jerin Jacob > >

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/axgbe: support flow control API

2020-01-31 Thread Kevin Traynor
On 31/01/2020 13:47, Ferruh Yigit wrote: > On 1/30/2020 6:35 AM, asoma...@amd.com wrote: >> From: Amaranath Somalapuram >> >> adding api for flow_ctrl_get and flow_ctrl_set >> by default axgbe driver flow control is dissabled >> adding dpdk flow control to set water high and low s/dissabled/disab

[dpdk-dev] [PATCH v3] app/testpmd: add portlist option to the testpmd

2020-01-31 Thread Hariprasad Govindharajan
In current version, we are setting the ports using portmask. With portmask, we can use only upto 64 ports. This portlist option enables the user to use more than 64 ports. Now we can specify the ports in 2 different ways - Using portmask (-p [0x]nnn): mask must be in hex for

[dpdk-dev] [PATCH v6 5/8] examples/ipsec-secgw: get rid of maximum sp limitation

2020-01-31 Thread Vladimir Medvedkin
Get rid of maximum SP limitation. Keep parsed SP's into the sorted by SPI value array. Use binary search in the sorted SP array to find appropriate SP for a given SPI. Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev Acked-by: Akhil Goyal --- examples/ipsec-secgw/parser.c | 2 +

[dpdk-dev] [PATCH v6 6/8] examples/ipsec-secgw: add SAD cache

2020-01-31 Thread Vladimir Medvedkin
Introduce SAD cache. Stores the most recent SA in a per lcore cache. Cache represents flat array containing SA's indexed by SPI. Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev Acked-by: Akhil Goyal --- examples/ipsec-secgw/ipsec-secgw.c | 30 +- examples/ipsec-secgw/ip

[dpdk-dev] [PATCH v6 8/8] doc: update ipsec-secgw guide

2020-01-31 Thread Vladimir Medvedkin
Add new SAD cache option in ipsec-secgw guide. Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- doc/guides/sample_app_ug/ipsec_secgw.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/sample_app_ug/ipsec_secgw.rst b/doc/guides/sample_app_ug/ipsec_secgw.r

[dpdk-dev] [PATCH v6 7/8] examples/ipsec-secgw: set/use mbuf ptype

2020-01-31 Thread Vladimir Medvedkin
Set mbuf ptype in prepare_one_packet() after parsing ether_type. Use mbuf ptype after to recognize packet's address family. Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- examples/ipsec-secgw/ipsec-secgw.c | 2 ++ examples/ipsec-secgw/sad.h | 2 +- 2 files changed, 3

[dpdk-dev] [PATCH v6 4/8] examples/ipsec-secgw: get rid of maximum sa limitation

2020-01-31 Thread Vladimir Medvedkin
Get rid of maximum SA limitation. Keep parsed SA's into the sorted by SPI value array. Use binary search in the sorted SA array to find appropriate SA for a given SPI. Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev Acked-by: Akhil Goyal --- examples/ipsec-secgw/ipsec.h | 1 -

[dpdk-dev] [PATCH v6 0/8] integrate librte_ipsec SAD into ipsec-secgw

2020-01-31 Thread Vladimir Medvedkin
This series integrates SA database (SAD) capabilities from ipsec library. The goal is to make ipsec-secgw RFC compliant regarding inbound SAD. Also patch series removes hardcoded limitation for maximum number of SA's and SP's. According to our measurements, after this series of patches, ipsec-secgw

[dpdk-dev] [PATCH v6 3/8] examples/ipsec-secgw: integrate inbound SAD

2020-01-31 Thread Vladimir Medvedkin
Integrate ipsec SAD support into secgw app: 1. Use SAD library for inbound SA lookup 2. Changes in struct sa_ctx: - sa array allocates dynamically depending on number of configured sa - All SA's are kept one by one without using SPI2IDX 3. SP's userdata now contain index of SA in sa_ctx instea

[dpdk-dev] [PATCH v6 1/8] ipsec: move ipsec sad name length into .h

2020-01-31 Thread Vladimir Medvedkin
Move IPSEC_SAD_NAMESIZE into public header and rename it to RTE_IPSEC_SAD_NAMESIZE Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev Acked-by: Akhil Goyal --- lib/librte_ipsec/ipsec_sad.c | 20 ++-- lib/librte_ipsec/rte_ipsec_sad.h | 2 ++ 2 files changed, 12

[dpdk-dev] [PATCH v6 2/8] examples/ipsec-secgw: implement inbound SAD

2020-01-31 Thread Vladimir Medvedkin
Add initial support for librte_ipsec SAD library Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev Acked-by: Akhil Goyal --- examples/ipsec-secgw/ipsec.h | 7 +++ examples/ipsec-secgw/sad.c | 109 +++ examples/ipsec-secgw/sad.h | 75 +

Re: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: increase number of qps to lcore_params

2020-01-31 Thread Ananyev, Konstantin
> Currently only one qp will be used for one core. The number of qps can > be increased to match the number of lcore params. > > Signed-off-by: Anoob Joseph > Signed-off-by: Lukasz Bartosik > --- > examples/ipsec-secgw/ipsec-secgw.c | 32 ++-- > examples/ipsec-secg

[dpdk-dev] [PATCH v2] mempool/octeontx2: optimize for L1D cache architecture

2020-01-31 Thread pbhagavatula
From: Pavan Nikhilesh OCTEON TX2 has 8 sets, 41 ways L1D cache, VA<9:7> bits dictate the set selection. Add additional padding to ensure that the element size always occupies odd number of cachelines to ensure even distribution of elements among L1D cache sets. Signed-off-by: Pavan Nikhilesh Si

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: increase number of qps to lcore_params

2020-01-31 Thread Anoob Joseph
Hi Konstantin, Please see inline. Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Friday, January 31, 2020 10:02 PM > To: Anoob Joseph ; Akhil Goyal ; > Nicolau, Radu > Cc: Jerin Jacob Kollanukkaran ; Lukas Bartosik > ; Narayana Prasad Raju Athreya > ; dev@dpdk.o

[dpdk-dev] [RFC PATCH 4/5] test: add graph performance test cases.

2020-01-31 Thread jerinj
From: Pavan Nikhilesh Example command to execute the test: echo "graph_perf_autotest" | sudo ./build/app/test/dpdk-test -c 0x30 Signed-off-by: Pavan Nikhilesh --- app/test/Makefile | 1 + app/test/meson.build | 1 + app/test/test_graph_perf.c | 888 +

[dpdk-dev] [RFC PATCH 5/5] example/l3fwd_graph: l3fwd using graph architecture

2020-01-31 Thread jerinj
From: Nithin Dabilpuram This example application showcase the l3fwd implementation using graph architecture. The graphical topology representation of the l3fwd-graph is the following, http://bit.ly/39UPPGm Signed-off-by: Nithin Dabilpuram --- examples/Makefile|3 + example

[dpdk-dev] [RFC PATCH 3/5] test: add graph functional tests

2020-01-31 Thread jerinj
From: Kiran Kumar K Example command to execute the test: echo "graph_autotest" | sudo ./build/app/test/dpdk-test -c 0x30 Signed-off-by: Kiran Kumar K --- app/test/Makefile | 4 + app/test/meson.build | 1 + app/test/test_graph.c | 820 ++ 3 fil

[dpdk-dev] [RFC PATCH 1/5] graph: introduce graph subsystem

2020-01-31 Thread jerinj
From: Jerin Jacob Abstracting the data processing functions as “nodes” and “link” them together to create complex “graph” to enable reusable data processing functions has been identified as proven architecture. Introducing the graph infrastructure for packet processing. Signed-off-by: Jerin Jac

[dpdk-dev] [RFC PATCH 2/5] node: add packet processing nodes

2020-01-31 Thread jerinj
From: Nithin Dabilpuram Signed-off-by: Nithin Dabilpuram Signed-off-by: Jerin Jacob Signed-off-by: Pavan Nikhilesh --- app/test/meson.build | 7 +- config/common_base | 6 + lib/Makefile | 4 + lib/librte_node/Makefile

[dpdk-dev] [RFC PATCH 0/5] graph: introduce graph subsystem

2020-01-31 Thread jerinj
From: Jerin Jacob This RFC is targeted for v20.05 release. This RFC patch includes an implementation of graph architecture for packet processing using DPDK primitives. Using graph traversal for packet processing is a proven architecture that has been implemented in various open source libraries

Re: [dpdk-dev] [PATCH v2 13/13] vdpa/mlx5: disable ROCE

2020-01-31 Thread Maxime Coquelin
On 1/29/20 11:09 AM, Matan Azrad wrote: > In order to support virtio queue creation by the FW, ROCE mode > should be disabled in the device. > > Do it by netlink which is like the devlink tool commands: > 1. devlink dev param set pci/[pci] name enable_roce value false > cmode dri

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: increase number of qps to lcore_params

2020-01-31 Thread Ananyev, Konstantin
> > > > -- > > > > > > > > > > Currently only one qp will be used for one core. The number of qps can > > > be increased to match the number of lcore params. > > > > I don't really understand the purpose of that patch > > As

[dpdk-dev] [PATCH v2] app/testpmd: add portlist option to the testpmd

2020-01-31 Thread Hariprasad Govindharajan
In current version, we are setting the ports using portmask. With portmask, we can use only upto 64 ports. This portlist option enables the user to use more than 64 ports. Now we can specify the ports in 2 different ways - Using portmask (-p [0x]nnn):

[dpdk-dev] Issue while running testpmd with sr-iov setting

2020-01-31 Thread 김영득
Hi. I have a fail in SR-IOV I use a HPE Eth 631SFP28 2port NIC Setting up SR-IOV will cause problems on the second port (port 1). The configuration of SR-IOV is assigned one VF on each port. I added this information to the last table. l Error Log testpmd> port stop 0 Stopping po

[dpdk-dev] [dpdk-announce] DPDK 18.11.6 (LTS) released

2020-01-31 Thread Kevin Traynor
Hi all, Here is a new LTS release: https://fast.dpdk.org/rel/dpdk-18.11.6.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=18.11 It has almost 300 bugfixes since the previous release. Thanks to the authors who helped with backports and to the following who helpe

Re: [dpdk-dev] [PATCH v2 12/13] vdpa/mlx5: support close and config operations

2020-01-31 Thread Maxime Coquelin
On 1/29/20 11:09 AM, Matan Azrad wrote: > Support dev_conf and dev_conf operations. > These operations allow vdpa traffic. > > Signed-off-by: Matan Azrad > Acked-by: Viacheslav Ovsiienko > --- > drivers/vdpa/mlx5/mlx5_vdpa.c | 58 > --- > drivers/vdpa

Re: [dpdk-dev] [PATCH v2 11/13] vdpa/mlx5: support live migration

2020-01-31 Thread Maxime Coquelin
On 1/29/20 11:09 AM, Matan Azrad wrote: > Add support for live migration feature by the HW: > Create a single Mkey that maps the memory address space of the > VHOST live migration log file. > Modify VIRTIO_NET_Q object and provide vhost_log_page, > dirty_b

Re: [dpdk-dev] [PATCH] mempool/octeontx2: optimize for L1D cache architecture

2020-01-31 Thread Jerin Jacob
On Fri, Jan 31, 2020 at 6:21 PM wrote: > > From: Pavan Nikhilesh > > OCTEON TX2 has 8 sets, 41 ways L1D cache, VA<9:7> bits dictate > the set selection. > Add additional padding to ensure that the element size always > occupies odd number of cachelines to ensure even distribution > of elements am

Re: [dpdk-dev] [PATCH] ci: increase unit test timeout

2020-01-31 Thread Honnappa Nagarahalli
> > Subject: Re: [dpdk-dev] [PATCH] ci: increase unit test timeout > > > > 28/01/2020 21:53, Aaron Conole: > > > Ferruh Yigit writes: > > > > > > > Timeout multiplier was 3, which gives 30 seconds for unit test but > > > > still some unit test was timing out time to time and travis > > > > reporti

Re: [dpdk-dev] [PATCH v2 10/13] vdpa/mlx5: map doorbell

2020-01-31 Thread Maxime Coquelin
On 1/29/20 11:09 AM, Matan Azrad wrote: > The HW supports only 4 bytes doorbell writing detection. > The virtio device set only 2 bytes when it rings the doorbell. > > Map the virtio doorbell detected by the virtio queue kickfd to the HW > VAR space when it expects to get the virtio emulation d

Re: [dpdk-dev] [PATCH v3 14/15] net/octeontx2: add inline Tx path changes

2020-01-31 Thread Anoob Joseph
Hi Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Friday, January 31, 2020 7:06 PM > To: Anoob Joseph ; Declan Doherty > ; Thomas Monjalon > Cc: Ankur Dwivedi ; Jerin Jacob Kollanukkaran > ; Narayana Prasad Raju Athreya > ; Kiran Kumar Kokkilag

Re: [dpdk-dev] [PATCH v2 09/13] vdpa/mlx5: support queue state operation

2020-01-31 Thread Maxime Coquelin
On 1/29/20 11:09 AM, Matan Azrad wrote: > Add support for set_vring_state operation. > > Using DevX API the virtq state can be changed as described in PRM: > enable - move to ready state. > disable - move to suspend state. > > Signed-off-by: Matan Azrad > Acked-by: Viacheslav Ovsi

Re: [dpdk-dev] [PATCH] eal/ppc64: improve rte_rdtsc with ppc_get_timebase

2020-01-31 Thread Thinh Tran
Need to resubmit a new patch, since the same code may be used by other ppc platform such as FreeBSD that may not have the sys/platform/ppc.h Thinh Tran On 1/28/2020 3:02 PM, Thinh Tran wrote: __ppc_get_timebase() is GNU extention and is more efficient Signed-off-by: Thinh Tran --- .../com

Re: [dpdk-dev] [PATCH] net/mlx5: add Rx/Tx burst mode info callbacks

2020-01-31 Thread Slava Ovsiienko
> -Original Message- > From: Alexander Kozyrev > Sent: Thursday, January 30, 2020 18:28 > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Matan Azrad > ; Slava Ovsiienko ; > ferruh.yi...@intel.com; Thomas Monjalon > Subject: [PATCH] net/mlx5: add Rx/Tx burst mode info callbacks > > Get a burst

Re: [dpdk-dev] [PATCH v2 08/13] vdpa/mlx5: add basic steering configurations

2020-01-31 Thread Maxime Coquelin
On 1/29/20 11:09 AM, Matan Azrad wrote: > Add a steering object to be managed by a new file mlx5_vdpa_steer.c. > > Allow promiscuous flow to scatter the device Rx packets to the virtio > queues using RSS action. > > In order to allow correct RSS in L3 and L4, split the flow to 7 flows > as req

Re: [dpdk-dev] [PATCH v3 11/15] net/octeontx2: add inline ipsec Rx path changes

2020-01-31 Thread Anoob Joseph
Hi Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: dev On Behalf Of Akhil Goyal > Sent: Friday, January 31, 2020 7:09 PM > To: Anoob Joseph ; Declan Doherty > ; Thomas Monjalon > Cc: Tejasree Kondoj ; Jerin Jacob Kollanukkaran > ; Narayana Prasad Raju Athreya > ; K

Re: [dpdk-dev] [PATCH v2 06/13] vdpa/mlx5: prepare virtio queues

2020-01-31 Thread Maxime Coquelin
On 1/31/20 8:34 AM, Matan Azrad wrote: > > > From: Maxime Coquelin >> On 1/29/20 11:09 AM, Matan Azrad wrote: >>> The HW virtq object represents an emulated context for a VIRTIO_NET >>> virtqueue which was created and managed by a VIRTIO_NET driver as >>> defined in VIRTIO Specification. >>> >

Re: [dpdk-dev] [PATCH v2 05/13] vdpa/mlx5: prepare HW queues

2020-01-31 Thread Maxime Coquelin
On 1/31/20 7:56 AM, Matan Azrad wrote: > > Hi > > From: Maxime Coquelin >> On 1/29/20 11:09 AM, Matan Azrad wrote: >>> As an arrangement to the vitrio queues creation, a 2 QPs and CQ may be >>> created for the virtio queue. >>> >>> The design is to trigger an event for the guest and for the vd

Re: [dpdk-dev] [PATCH v5 8/8] doc: add cpu crypto related documentation

2020-01-31 Thread Akhil Goyal
> > Update documentation with a description of cpu crypto in cryptodev, > ipsec and security libraries. > > Add release notes for 20.02. > > Signed-off-by: Marcin Smoczynski > --- This patch need to be split and squashed in the relevant patches of this series.

Re: [dpdk-dev] [PATCH 2/2] eal: add eal_parse_optionlist to parse user input

2020-01-31 Thread Govindharajan, Hariprasad
> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, January 29, 2020 7:20 PM > To: Yigit, Ferruh > Cc: David Marchand ; Thomas Monjalon > ; Govindharajan, Hariprasad > ; dev > Subject: Re: [dpdk-dev] [PATCH 2/2] eal: add eal_parse_optionlist to parse > user input > > On We

Re: [dpdk-dev] [PATCH v5 3/8] test/crypto: add CPU crypto tests

2020-01-31 Thread Akhil Goyal
> > Add unit and performance tests for CPU crypto mode currently implemented > by AESNI-GCM cryptodev. Unit tests cover AES-GCM and GMAC test vectors. > > Signed-off-by: Marcin Smoczynski > Acked-by: Pablo de Lara > --- Is it not possible to add it in test_cryptodev.c? Why do we need to reg

Re: [dpdk-dev] [PATCH v5 2/8] crypto/aesni_gcm: cpu crypto support

2020-01-31 Thread Akhil Goyal
> > Add support for CPU crypto mode by introducing required handler. > Crypto mode (sync/async) is chosen during sym session create if an > appropriate flag is set in an xform type number. Update description of the patch here also for xform. > > Authenticated encryption and decryption are sup

Re: [dpdk-dev] [PATCH v5 1/8] cryptodev: introduce cpu crypto support API

2020-01-31 Thread Akhil Goyal
Hi Marcin/Konstantin, > > Add new API allowing to process crypto operations in a synchronous > manner. Operations are performed on a set of SG arrays. > > Sync mode is selected by setting appropriate flag in an xform > type number. Cryptodevs which allows CPU crypto operation mode have to > use R

Re: [dpdk-dev] [PATCH v5 4/8] security: add cpu crypto action type

2020-01-31 Thread Akhil Goyal
Hi Marcin/Konstantin, > Introduce CPU crypto action type allowing to differentiate between > regular async 'none security' and synchronous, CPU crypto accelerated > sessions. > > Signed-off-by: Marcin Smoczynski > Acked-by: Konstantin Ananyev > Acked-by: Fan Zhang > --- > lib/librte_security/

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-01-31 Thread Trahe, Fiona
> > > I believe these enums will be used only in case of ASYM case which is > > > experimental. > > > > Independent from being experiment and not, this shouldn't be a problem, I > > think > > this is a false positive. > > > > The ABI break can happen when a struct has been shared between the >

Re: [dpdk-dev] [PATCH v3] app/testpmd: fix copying the name of the dynflag

2020-01-31 Thread Ferruh Yigit
On 1/30/2020 9:04 PM, Ori Kam wrote: > When working with testpmd and setting the dynflag name, we copy the > name given by the cmd to the dynflag name. > > The issue is that the size of the dynflag name is smaller then the > string used by testpmd. > > This commit solves this issue by checking th

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/axgbe: support flow control API

2020-01-31 Thread Ferruh Yigit
On 1/30/2020 6:35 AM, asoma...@amd.com wrote: > From: Amaranath Somalapuram > > adding api for flow_ctrl_get and flow_ctrl_set > by default axgbe driver flow control is dissabled > adding dpdk flow control to set water high and low > Cc: sta...@dpdk.org > > Signed-off-by: Amaranath Somalapuram

Re: [dpdk-dev] [PATCH v3 11/15] net/octeontx2: add inline ipsec Rx path changes

2020-01-31 Thread Akhil Goyal
Hi Anoob, > > From: Tejasree Kondoj > > Adding post-processing required for inline IPsec inbound packets. > > Signed-off-by: Ankur Dwivedi > Signed-off-by: Anoob Joseph > Signed-off-by: Archana Muniganti > Signed-off-by: Tejasree Kondoj > Signed-off-by: Vamsi Attunuru > --- > drivers/cryp

Re: [dpdk-dev] [PATCH v3 14/15] net/octeontx2: add inline Tx path changes

2020-01-31 Thread Akhil Goyal
Hi Anoob, > > From: Ankur Dwivedi > > Adding pre-processing required for inline IPsec outbound packets. > > Signed-off-by: Ankur Dwivedi > Signed-off-by: Anoob Joseph > Signed-off-by: Archana Muniganti > Signed-off-by: Tejasree Kondoj > Signed-off-by: Vamsi Attunuru > --- > drivers/event

Re: [dpdk-dev] [PATCH] net/ionic: fix packet type mask

2020-01-31 Thread Ferruh Yigit
On 1/30/2020 5:26 PM, Alfredo Cardigliano wrote: > Fix the IONIC_RXQ_COMP_PKT_TYPE_MASK define. This fixes > the coverity defect #353608 > > Signed-off-by: Alfredo Cardigliano Coverity issue: 353608 Fixes: 01489e5d79a7 ("net/ionic: add hardware structures definitions") Applied to dpdk-n

Re: [dpdk-dev] [PATCH v5 0/6] integrate librte_ipsec SAD into ipsec-secgw

2020-01-31 Thread Akhil Goyal
> > This series integrates SA database (SAD) capabilities from ipsec library. > The goal is to make ipsec-secgw RFC compliant regarding inbound SAD. > Also patch series removes hardcoded limitation for maximum number of SA's > and SP's. > According to our measurements, after this series of patch

[dpdk-dev] [PATCH] mempool/octeontx2: optimize for L1D cache architecture

2020-01-31 Thread pbhagavatula
From: Pavan Nikhilesh OCTEON TX2 has 8 sets, 41 ways L1D cache, VA<9:7> bits dictate the set selection. Add additional padding to ensure that the element size always occupies odd number of cachelines to ensure even distribution of elements among L1D cache sets. Signed-off-by: Pavan Nikhilesh Si

[dpdk-dev] Minutes of Technical Board Meeting, 2020-01-29

2020-01-31 Thread Olivier Matz
Minutes of Technical Board Meeting, 2020-01-29 Members Attending - - Bruce - Ferruh - Hemant - Honnappa - Jerin - Kevin - Konstantin - Olivier (chair) - Stephen - Thomas NOTE: The technical board meetings every second Wednesday on IRC channel #dpdk-board, at 3pm UTC. Meetings are

Re: [dpdk-dev] Big spike in DPDK VSZ

2020-01-31 Thread siddarth rai
Hi, I have created a ticket for the same - https://bugs.dpdk.org/show_bug.cgi?id=386 Regards, Siddarth On Thu, Jan 30, 2020 at 6:45 PM Meunier, Julien (Nokia - FR/Paris-Saclay) < julien.meun...@nokia.com> wrote: > Hi, > > I noticed also this same behavior since DPDK 18.05. As David said, it is

Re: [dpdk-dev] [PATCH 2/2] eal: add eal_parse_optionlist to parse user input

2020-01-31 Thread Govindharajan, Hariprasad
Hi, I am planning to move the existing parser function to the testpmd file instead of keeping it in the eal and will revert the eal back. Also, I am planning to create an util file in eal with this parser and do a RFC. @Stephen Hemminger, We already investigated the existing function and then d

Re: [dpdk-dev] [PATCH] app/testpmd: fix uninitialized members of mpls

2020-01-31 Thread Ferruh Yigit
On 1/30/2020 4:59 PM, Ori Kam wrote: > Some of the memebers of the mpls struct are not initialized. > this commit init the uninitialized members. > > Coverity issue: 325735 > Fixes: 3e77031be855 ("app/testpmd: add MPLSoGRE encapsulation") > Cc: sta...@dpdk.org > > Signed-off-by: Ori Kam > --- >

Re: [dpdk-dev] [PATCH] testpmd: fix init mpls struct

2020-01-31 Thread Ferruh Yigit
On 1/30/2020 4:18 PM, Ori Kam wrote: > When adding mpls item we copy the structure, in some cases > the item is not initialized. > > This commit solves this by initializing the struct. > > Coverity issue: 325734 > Fixes: a1191d39cb57 ("app/testpmd: add MPLSoUDP encapsulation") > Cc: sta...@dpdk.o

Re: [dpdk-dev] [PATCH v5 0/5] net/mlx: assert cleanup in mlx drivers

2020-01-31 Thread Ferruh Yigit
On 1/30/2020 4:14 PM, Alexander Kozyrev wrote: > net/mlx: assert cleanup in mlx drivers > > The Mellanox PMD uses the NDEBUG definition to control built-in debug > features including the asserting one. The DPDK uses a bit different > approach and provides RTE_ASSERT macro and appropriate global >

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-01-31 Thread Ananyev, Konstantin
> > On 1/30/2020 8:18 PM, Thomas Monjalon wrote: > > 30/01/2020 17:09, Ferruh Yigit: > >> On 1/29/2020 8:13 PM, Akhil Goyal wrote: > >>> > >>> > > On Wed, Jan 29, 2020 at 7:10 PM Anoob Joseph wrote: > > The asymmetric crypto library is experimental. Changes to experimental >

[dpdk-dev] [PATCH v3 15/15] net/octeontx2: sync inline tag type

2020-01-31 Thread Anoob Joseph
From: Vamsi Attunuru Tag type configuration for the inline processed packets is set during ethdev configuration, it might conflict with tag type configuration done during Rx adapter configuration which would be setup later. This conflict is fixed as part of flow rule creation by updating tag typ

[dpdk-dev] [PATCH v3 13/15] drivers/octeontx2: add sec in Tx fastpath framework

2020-01-31 Thread Anoob Joseph
From: Archana Muniganti Added new flag for SECURITY in compiler optimized Tx fastpath framework. With this, compiler autogenerates functions which have security enabled. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Archana Muniganti Signed-off-by: Tejasree Kondoj S

[dpdk-dev] [PATCH v3 14/15] net/octeontx2: add inline Tx path changes

2020-01-31 Thread Anoob Joseph
From: Ankur Dwivedi Adding pre-processing required for inline IPsec outbound packets. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Archana Muniganti Signed-off-by: Tejasree Kondoj Signed-off-by: Vamsi Attunuru --- drivers/event/octeontx2/meson.build| 3

[dpdk-dev] [PATCH v3 12/15] drivers/octeontx2: add sec in Rx fastpath framework

2020-01-31 Thread Anoob Joseph
From: Archana Muniganti Added new flag for SECURITY in Rx compiler optimized fastpath framework. With this, compiler autogenerates functions which have security enabled. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Archana Muniganti Signed-off-by: Tejasree Kondoj S

[dpdk-dev] [PATCH v3 10/15] net/octeontx2: add lookup mem changes to hold sa indices

2020-01-31 Thread Anoob Joseph
From: Archana Muniganti lookup_mem provides fast accessing of data path fields. Storing sa indices in lookup_mem which are required in inline rx data path. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Archana Muniganti Signed-off-by: Tejasree Kondoj Signed-off-by:

[dpdk-dev] [PATCH v3 11/15] net/octeontx2: add inline ipsec Rx path changes

2020-01-31 Thread Anoob Joseph
From: Tejasree Kondoj Adding post-processing required for inline IPsec inbound packets. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Archana Muniganti Signed-off-by: Tejasree Kondoj Signed-off-by: Vamsi Attunuru --- drivers/crypto/octeontx2/Makefile| 3 +- d

[dpdk-dev] [PATCH v3 06/15] net/octeontx2: add eth security capabilities

2020-01-31 Thread Anoob Joseph
From: Ankur Dwivedi Adding security capabilities supported by the eth PMD. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Archana Muniganti Signed-off-by: Tejasree Kondoj Signed-off-by: Vamsi Attunuru --- drivers/net/octeontx2/otx2_ethdev_sec.c | 124 ++

[dpdk-dev] [PATCH v3 09/15] net/octeontx2: add datapath ops in eth security ctx

2020-01-31 Thread Anoob Joseph
From: Ankur Dwivedi Adding data path ops in eth security ctx. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Archana Muniganti Signed-off-by: Tejasree Kondoj Signed-off-by: Vamsi Attunuru --- drivers/net/octeontx2/otx2_ethdev_sec.c | 23 +++ 1 f

[dpdk-dev] [PATCH v3 08/15] net/octeontx2: add eth security session operations

2020-01-31 Thread Anoob Joseph
Adding security session operations in eth security ctx. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Archana Muniganti Signed-off-by: Tejasree Kondoj Signed-off-by: Vamsi Attunuru --- drivers/common/octeontx2/otx2_sec_idev.c | 63 drivers/common/oct

[dpdk-dev] [PATCH v3 07/15] crypto/octeontx2: enable CPT to share QP with ethdev

2020-01-31 Thread Anoob Joseph
Adding the infrastructure to save one opaque pointer in idev and implement the consumer-producer in the PMDs which uses it accordingly. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Archana Muniganti Signed-off-by: Tejasree Kondoj Signed-off-by: Vamsi Attunuru --- d

[dpdk-dev] [PATCH v3 04/15] net/octeontx2: create eth security ctx

2020-01-31 Thread Anoob Joseph
Adding security ctx to the eth device. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Archana Muniganti Signed-off-by: Tejasree Kondoj Signed-off-by: Vamsi Attunuru --- MAINTAINERS | 1 + drivers/net/octeontx2/Makefile | 1 + dr

[dpdk-dev] [PATCH v3 01/15] common/octeontx2: add CPT LF mbox for inline inbound

2020-01-31 Thread Anoob Joseph
Adding the new mbox introduced to configure CPT LF to be used for inline inbound. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj --- drivers/common/octeontx2/otx2_mbox.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/common/octeontx2/otx2_mbox.h b/drivers/common

[dpdk-dev] [PATCH v3 05/15] net/octeontx2: add security in eth dev configure

2020-01-31 Thread Anoob Joseph
From: Tejasree Kondoj Adding security in eth device configure. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph Signed-off-by: Archana Muniganti Signed-off-by: Tejasree Kondoj Signed-off-by: Vamsi Attunuru --- doc/guides/nics/octeontx2.rst | 20 + doc/guides/rel_

[dpdk-dev] [PATCH v3 02/15] common/octeontx2: add routine to check if sec capable otx2

2020-01-31 Thread Anoob Joseph
From: Vamsi Attunuru This routine returns true if given rte_eth_dev is security offload capable and belongs to octeontx2. Signed-off-by: Anoob Joseph Signed-off-by: Tejasree Kondoj Signed-off-by: Vamsi Attunuru --- MAINTAINERS| 5 drivers/common/

[dpdk-dev] [PATCH v3 03/15] crypto/octeontx2: configure for inline IPsec

2020-01-31 Thread Anoob Joseph
From: Tejasree Kondoj For enabling outbound inline IPsec, a CPT queue needs to be tied to a NIX PF_FUNC. Distribute CPT queues fairly among all available otx2 eth ports. For inbound, one CPT LF will be assigned and initialized by kernel. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph

[dpdk-dev] [PATCH v3 00/15] add OCTEON TX2 inline IPsec support

2020-01-31 Thread Anoob Joseph
This series adds inline IPsec support in OCTEON TX2 PMD. In the inbound path, rte_flow framework need to be used to configure the NPC block, which does the h/w lookup. The packets would get processed by the crypto block and would submit to the scheduling block, SSO. So inline IPsec mode can be ena

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-01-31 Thread Ananyev, Konstantin
> -Original Message- > From: Yigit, Ferruh > Sent: Friday, January 31, 2020 9:07 AM > To: Ananyev, Konstantin ; Thomas Monjalon > ; Anoob Joseph > ; akhil.go...@nxp.com; Trahe, Fiona > > Cc: dev@dpdk.org; David Marchand ; Richardson, > Bruce ; > nhor...@tuxdriver.com; Mcnamara, John

Re: [dpdk-dev] [RFC v2] meter: fix ABI break due to experimental tag removal

2020-01-31 Thread Ferruh Yigit
On 1/30/2020 12:33 PM, Thomas Monjalon wrote: > Hi, > > I disagree with the need of this patch. > The symbol was experimental, meaning we can change it. > Removing experimental tag is not an ABI break. In theory what you said is correct, this is experimental API and anything can happen to it, thi

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-01-31 Thread Ferruh Yigit
On 1/30/2020 11:49 PM, Ananyev, Konstantin wrote: > > >> -Original Message- >> From: dev On Behalf Of Thomas Monjalon >> Sent: Thursday, January 30, 2020 4:00 PM >> To: Anoob Joseph ; akhil.go...@nxp.com; Trahe, Fiona >> >> Cc: dev@dpdk.org; David Marchand ; Richardson, >> Bruce ; >>

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-01-31 Thread Ferruh Yigit
On 1/30/2020 8:18 PM, Thomas Monjalon wrote: > 30/01/2020 17:09, Ferruh Yigit: >> On 1/29/2020 8:13 PM, Akhil Goyal wrote: >>> >>> On Wed, Jan 29, 2020 at 7:10 PM Anoob Joseph wrote: > The asymmetric crypto library is experimental. Changes to experimental > code paths is al

Re: [dpdk-dev] [PATCH v2] net/e1000: update UPDATE_VF_STAT to handle rollover

2020-01-31 Thread Ye Xiaolong
On 01/29, Ferruh Yigit wrote: >On 1/26/2020 5:25 PM, David Harton wrote: >> Modified UPDATE_VF_STAT to properly handle rollover conditions. >> >> Fixes: d82170d27918 ("igb: add VF support") >> Cc: intel.com >> >> Signed-off-by: David Harton >> --- >> drivers/net/e1000/igb_ethdev.c | 14