On 1/30/2020 4:14 PM, Alexander Kozyrev wrote: > net/mlx: assert cleanup in mlx drivers > > The Mellanox PMD uses the NDEBUG definition to control built-in debug > features including the asserting one. The DPDK uses a bit different > approach and provides RTE_ASSERT macro and appropriate global > configuration option: CONFIG_RTE_ENABLE_ASSERT. > The patch set introduces the MLX_ASSERT macros that allows to follow > the DPDK approach in a unified fashion and, at the same time, > provides the opportunity to turn on Mellanox PMD assert feature with > dedicated local configuration options: CONFIG_RTE_LIBRTE_MLX_DEBUG. > Note that the direct configuration MLX_DEBUG is clearer than > double negation "ifndef NDEBUG" used before. > This patch set triggers another false positive warning with ICC. > To spare future development efforts we disable the treatments of > compilation warnings as errors in ICC config. GCC stays as a guard. > > Signed-off-by: Alexander Kozyrev <akozy...@mellanox.com> > --- > v1: http://patches.dpdk.org/cover/65082/ > v2: http://patches.dpdk.org/cover/65089/ > - Corrects typos and make commit messages more accurate. > - Fixes broken compilation due to an undefined function in debug mode. > v3: http://patches.dpdk.org/cover/65145/ > - Uses RTE_LIBRTE_MLX_DEBUG directly instead of MLX_DEBUG > v4: http://patches.dpdk.org/cover/65364/ > - Covers a new mlx5 common library driver > v5: > - Merges with a new version of mlx5 > > Alexander Kozyrev (5): > mk/icc: disable treatment of warnings as errors > net/mlx4: use mlx4 debug flag instead of NDEBUG > net/mlx4: introduce the mlx4 version of the assert > drivers: use mlx5 debug flag instead of NDEBUG > drivers: introduce the mlx5 version of the assert
Series applied to dpdk-next-net/master, thanks.
