Hi Akhil,
Please see inline.
Thanks,
Anoob
> -----Original Message-----
> From: dev <dev-boun...@dpdk.org> On Behalf Of Akhil Goyal
> Sent: Friday, January 31, 2020 7:09 PM
> To: Anoob Joseph <ano...@marvell.com>; Declan Doherty
> <declan.dohe...@intel.com>; Thomas Monjalon <tho...@monjalon.net>
> Cc: Tejasree Kondoj <ktejas...@marvell.com>; Jerin Jacob Kollanukkaran
> <jer...@marvell.com>; Narayana Prasad Raju Athreya
> <pathr...@marvell.com>; Kiran Kumar Kokkilagadda
> <kirankum...@marvell.com>; Nithin Kumar Dabilpuram
> <ndabilpu...@marvell.com>; Pavan Nikhilesh Bhagavatula
> <pbhagavat...@marvell.com>; Ankur Dwivedi <adwiv...@marvell.com>;
> Archana Muniganti <march...@marvell.com>; Vamsi Krishna Attunuru
> <vattun...@marvell.com>; Lukas Bartosik <lbarto...@marvell.com>;
> dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 11/15] net/octeontx2: add inline ipsec Rx
> path changes
>
> Hi Anoob,
> >
> > From: Tejasree Kondoj <ktejas...@marvell.com>
> >
> > Adding post-processing required for inline IPsec inbound packets.
> >
> > Signed-off-by: Ankur Dwivedi <adwiv...@marvell.com>
> > Signed-off-by: Anoob Joseph <ano...@marvell.com>
> > Signed-off-by: Archana Muniganti <march...@marvell.com>
> > Signed-off-by: Tejasree Kondoj <ktejas...@marvell.com>
> > Signed-off-by: Vamsi Attunuru <vattun...@marvell.com>
> > ---
> > drivers/crypto/octeontx2/Makefile | 3 +-
> > drivers/crypto/octeontx2/meson.build | 2 +
> > drivers/event/octeontx2/Makefile | 1 +
> > drivers/event/octeontx2/meson.build | 2 +
> > drivers/net/octeontx2/otx2_rx.h | 73
> > ++++++++++++++++++++++++++++++++++++
> > 5 files changed, 80 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/crypto/octeontx2/Makefile
> > b/drivers/crypto/octeontx2/Makefile
> > index 3ba67ed..1458e2b 100644
> > --- a/drivers/crypto/octeontx2/Makefile
> > +++ b/drivers/crypto/octeontx2/Makefile
> > @@ -11,7 +11,7 @@ LIB = librte_pmd_octeontx2_crypto.a CFLAGS +=
> > $(WERROR_FLAGS)
> >
> > LDLIBS += -lrte_eal -lrte_ethdev -lrte_mbuf -lrte_mempool -lrte_ring
> > -LDLIBS += -lrte_cryptodev
> > +LDLIBS += -lrte_cryptodev -lrte_security
> > LDLIBS += -lrte_pci -lrte_bus_pci
> > LDLIBS += -lrte_common_cpt -lrte_common_octeontx2
> >
> > @@ -20,6 +20,7 @@ VPATH += $(RTE_SDK)/drivers/crypto/octeontx2
> > CFLAGS += -O3
> > CFLAGS += -I$(RTE_SDK)/drivers/common/cpt CFLAGS +=
> > -I$(RTE_SDK)/drivers/common/octeontx2
> > +CFLAGS += -I$(RTE_SDK)/drivers/crypto/octeontx2
>
> Why do you need to include self path for the driver?
[Anoob] Well this is interesting. I cannot explain this but when I'm building
otx2_cryptodev*.c files which include otx2_ethdev_sec.h, it's throwing an error
that otx2_ipsec_fp.h is not found (in case of shared build and meson, I guess).
The file otx2_ethdev_sec.h is in net/octeontx2 and it includes otx2_ipsec_fp.h
which is in crypto/octeontx2.
I'll cross check and let you know if it's needed in both Makefile & meson.
>
> > CFLAGS += -I$(RTE_SDK)/drivers/mempool/octeontx2
> > CFLAGS += -I$(RTE_SDK)/drivers/net/octeontx2
> > CFLAGS += -DALLOW_EXPERIMENTAL_API
> > diff --git a/drivers/crypto/octeontx2/meson.build
> > b/drivers/crypto/octeontx2/meson.build
> > index 67deca3..a531799 100644
> > --- a/drivers/crypto/octeontx2/meson.build
> > +++ b/drivers/crypto/octeontx2/meson.build
> > @@ -9,6 +9,7 @@ deps += ['bus_pci']
> > deps += ['common_cpt']
> > deps += ['common_octeontx2']
> > deps += ['ethdev']
> > +deps += ['security']
> > name = 'octeontx2_crypto'
> >
> > allow_experimental_apis = true
> > @@ -32,5 +33,6 @@ endforeach
> >
> > includes += include_directories('../../common/cpt')
> > includes += include_directories('../../common/octeontx2')
> > +includes += include_directories('../../crypto/octeontx2')
>
> Same here.
>
> > includes += include_directories('../../mempool/octeontx2')
> > includes += include_directories('../../net/octeontx2')
> > diff --git a/drivers/event/octeontx2/Makefile
> > b/drivers/event/octeontx2/Makefile
> > index 6dab69c..bcd22ee 100644
> > --- a/drivers/event/octeontx2/Makefile
> > +++ b/drivers/event/octeontx2/Makefile
> > @@ -11,6 +11,7 @@ LIB = librte_pmd_octeontx2_event.a
> >
> > CFLAGS += $(WERROR_FLAGS)
> > CFLAGS += -I$(RTE_SDK)/drivers/common/octeontx2
> > +CFLAGS += -I$(RTE_SDK)/drivers/crypto/octeontx2
> > CFLAGS += -I$(RTE_SDK)/drivers/mempool/octeontx2
> > CFLAGS += -I$(RTE_SDK)/drivers/event/octeontx2
> > CFLAGS += -I$(RTE_SDK)/drivers/net/octeontx2
> > diff --git a/drivers/event/octeontx2/meson.build
> > b/drivers/event/octeontx2/meson.build
> > index 807818b..56febb8 100644
> > --- a/drivers/event/octeontx2/meson.build
> > +++ b/drivers/event/octeontx2/meson.build
> > @@ -32,3 +32,5 @@ foreach flag: extra_flags endforeach
> >
> > deps += ['bus_pci', 'common_octeontx2', 'mempool_octeontx2',
> > 'pmd_octeontx2']
> > +
> > +includes += include_directories('../../crypto/octeontx2')
