Re: [dpdk-dev] [EXT] [PATCH v5 1/3] security: add anti replay window size

2019-10-31 Thread Anoob Joseph
Hi Hemant, Please see inline. > -Original Message- > From: Hemant Agrawal > Sent: Thursday, October 31, 2019 6:45 PM > To: dev@dpdk.org; akhil.go...@nxp.com > Cc: konstantin.anan...@intel.com; Anoob Joseph ; > Hemant Agrawal > Subject: [EXT] [PATCH v5 1/3] security: add anti replay wind

[dpdk-dev] [PATCH] net/bnx2x: fix meson build failure

2019-10-31 Thread Rasesh Mody
Use kernel headers for __le* types to avoid potential conflicts resulting in redefinition errors during Linux builds. Add check for BSD builds. Fixes: 38dff79ba736 ("net/bnx2x: update HSI") Signed-off-by: Rasesh Mody Tested-by: Dharmik Thakkar Tested-by: Gavin Hu --- drivers/net/bnx2x/bnx2x_o

Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: fix build with clang 3.4.2

2019-10-31 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH 1/2] test/meson: hash test split into shorter subtests

2019-10-31 Thread Amit Gupta
Ping! > -Original Message- > From: Amit Gupta > Sent: Thursday, October 17, 2019 10:33 AM > To: Wang, Yipeng1 ; Gobriel, Sameh > ; Richardson, Bruce > ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org > Subject: RE: [PATCH 1/2] test/meson: hash test split into shorter subtests > > > > > ---

Re: [dpdk-dev] [PATCH v2 0/6] mempool: avoid objects allocations across pages

2019-10-31 Thread Nipun Gupta
Series Acked-by: Nipun Gupta > -Original Message- > From: dev On Behalf Of Olivier Matz > Sent: Wednesday, October 30, 2019 8:06 PM > To: dev@dpdk.org > Cc: Anatoly Burakov ; Andrew Rybchenko > ; Ferruh Yigit ; > Giridharan, Ganesan ; Jerin Jacob Kollanukkaran > ; Kiran Kumar Kokkilagadd

[dpdk-dev] [PATCH v3] net/ice: optimize protocol extraction by dynamic mbuf API

2019-10-31 Thread Haiyue Wang
The original design is to use rte_mbuf::udata64 to save the metadata of protocol extraction which has network protocol data fields and type, a private API is used to decode this metadata. It is not so generic. Use the new dynamic mbuf field and flags to handle protocol extraction. Then the metadat

[dpdk-dev] [PATCH v2] net/ixgbe: fix port close in FreeBSD OS

2019-10-31 Thread Di ChenxuX
FreeBSD OS don't support igb_uio interrupt, so it will fail when unregister the interrupt callback in port close. We can fix the issue by passing -ENOENT when check the return value of unregister interrupt callback function. Fixes: f2f4990eff94 ("net/ixgbe: release port upon close") Signed-off-

[dpdk-dev] [PATCH v5] vhost: add vhost-user-blk example which support inflight

2019-10-31 Thread Jin Yu
A vhost-user-blk example that support inflight feature. It uses the new APIs that introduced in the first patch, so it can show how these APIs work to support inflight feature. Signed-off-by: Jin Yu --- v1 - add the case. v2 - add the rte_vhost prefix. v3 - add packed ring support v4 - fix build,

Re: [dpdk-dev] [PATCH v2] config: disable 1588 timer support on DPAA2

2019-10-31 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH] net/i40e: force promiscuous state after VF reset

2019-10-31 Thread Xing, Beilei
> -Original Message- > From: Eelco Chaudron [mailto:echau...@redhat.com] > Sent: Tuesday, October 29, 2019 3:47 PM > To: Zhang, Xiao ; Xing, Beilei > Cc: Zhang, Qi Z ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/i40e: force promiscuous state after VF > reset > > > > On 29 Oct 2

Re: [dpdk-dev] [PATCH v6] net/ixgbe: fix macsec setting

2019-10-31 Thread Ye Xiaolong
On 10/31, Sun GuinanX wrote: >macsec setting is not valid when port is stopped. >In order to make it valid, the patch changes the setting >to where port is started. > >Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API") >Cc: sta...@dpdk.org > >Signed-off-by: Sun GuinanX Reviewed-b

Re: [dpdk-dev] [PATCH v3] net/ice: remove GTPU tunnel support for inner L4

2019-10-31 Thread Ye Xiaolong
On 10/31, Yahui Cao wrote: >Remove unsupported flow as title. > >Fixes: efc16c621415 ("net/ice: support flow director GTPU tunnel") > >Signed-off-by: Yahui Cao >--- > drivers/net/ice/ice_fdir_filter.c | 13 - > 1 file changed, 13 deletions(-) > >diff --git a/drivers/net/ice/ice_fdir_fil

[dpdk-dev] [RFC v2 1/2] vhost: populate guest memory for DMA-accelerated vhost-user

2019-10-31 Thread Jiayu Hu
DMA engines, like I/OAT, are efficient in moving large data within memory. Offloading large copies in vhost side to DMA engines can save precious CPU cycles and improve vhost performance. However, using the DMA engine requires to populate guest's memory. This patch is to enable DMA-accelerated vho

[dpdk-dev] [RFC v2 0/2] Add a PMD for DMA-accelerated vhost-user

2019-10-31 Thread Jiayu Hu
In vhost-user enqueue and dequeue operations, where data movement is heavily involved, performing large memory copies usually takes up a major part of CPU cycles and becomes the hot spot. To offload expensive memory operations from the CPU, this patch set proposes to leverage DMA engines, e.g., I/O

[dpdk-dev] [RFC v2 2/2] net/vhost_dma: add vHost DMA driver

2019-10-31 Thread Jiayu Hu
This patch introduces a new PMD for DMA accelerated vhost-user, which provides basic functionality of packet reception and transmission. This PMD leverages librte_vhost to handle vhost messages, but it implements own vring's enqueue and dequeue operations. The PMD leverages DMA engines (e.g., I/OA

Re: [dpdk-dev] [PATCH v2] net/ice/base: add new device IDs

2019-10-31 Thread Ye Xiaolong
On 11/01, Qi Zhang wrote: >Add device IDs for E810_XXV. > >Signed-off-by: Paul M Stillwell Jr >Signed-off-by: Qi Zhang >--- > >V2: >- fix missing pci id mapping. > > doc/guides/rel_notes/release_19_11.rst | 1 + > drivers/net/ice/base/ice_devids.h | 6 ++ > drivers/net/ice/ice_ethde

Re: [dpdk-dev] [PATCH v6 10/12] net/i40e: clean LTO build warnings (maybe-uninitialized)

2019-10-31 Thread Xing, Beilei
> -Original Message- > From: Andrzej Ostruszka [mailto:aostrus...@marvell.com] > Sent: Tuesday, October 29, 2019 10:12 PM > To: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z > > Cc: mattias.ronnb...@ericsson.com; step...@networkplumber.org > Subject: [PATCH v6 10/12] net/i40e: clean LTO build

Re: [dpdk-dev] [PATCH] net/i40e: qinq strip is not supported by i40e

2019-10-31 Thread Xing, Beilei
> -Original Message- > From: Zhu, TaoX > Sent: Thursday, October 31, 2019 2:22 AM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org; Zhu, TaoX > Subject: [PATCH] net/i40e: qinq strip is not supported by i40e > > From: Zhu Tao > > Qinq strip is not supported by i40e. When user trie

[dpdk-dev] [PATCH v2] net/ice/base: add new device IDs

2019-10-31 Thread Qi Zhang
Add device IDs for E810_XXV. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- V2: - fix missing pci id mapping. doc/guides/rel_notes/release_19_11.rst | 1 + drivers/net/ice/base/ice_devids.h | 6 ++ drivers/net/ice/ice_ethdev.c | 3 +++ 3 files change

[dpdk-dev] [PATCH] net/mlx5: fix set VLAN id/pcp in new VLAN header

2019-10-31 Thread Xiaoyu Min
Currently if user want to set VLAN id/pcp on an about to be pushed VLAN header, the of_set_vlan_vid/of_set_vlan_pcp must be present _before_ action of_push_vlan: [1] ... actions of_set_vlan_vid vlan_vid 2 / of_push_vlan ... This is misleading because people think rule [1] intends to set VLAN id o

Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from host

2019-10-31 Thread Thomas Monjalon
30/10/2019 10:15, Jerin Jacob: > On Wed, Oct 30, 2019 at 2:26 PM Thomas Monjalon wrote: > > > > 30/10/2019 05:08, Jerin Jacob: > > > On Wed, Oct 30, 2019 at 12:21 AM Thomas Monjalon > > > wrote: > > > > > > > > In a virtual environment, the network controller may have to configure > > > > some S

Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from host

2019-10-31 Thread Thomas Monjalon
30/10/2019 10:24, Jerin Jacob: > On Wed, Oct 30, 2019 at 12:52 PM Shahaf Shuler wrote: > > Wednesday, October 30, 2019 6:09 AM, Jerin Jacob: > > > Subject: Re: [dpdk-dev] [PATCH v2 0/3] ethdev: configure SR-IOV VF from > > > host > > > > > > On Wed, Oct 30, 2019 at 12:21 AM Thomas Monjalon > > >

[dpdk-dev] [RFC PATCH] net/i[xgb|40]e: set VF MAC address from host

2019-10-31 Thread Thomas Monjalon
Allow to configure the default MAC address of a VF via its representor port in the host, when the VF is explicitly targeted with RTE_ETH_PORT_VF_FLAG. In the long term, the representor behaviour should be changed to configure itself when the VF is not targeted. This RFC patch will be split for ix

Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

2019-10-31 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Thomas Monjalon > Sent: Thursday, October 31, 2019 10:50 PM > To: Andrew Rybchenko > Cc: dev@dpdk.org; Ori Kam ; > pbhagavat...@marvell.com; Yigit, Ferruh ; > jer...@marvell.com; Mcnamara, John ; Kovacevic, > Marko ; Adrien Mazarguil > ; da

[dpdk-dev] [PATCH] net/ice/base: add new device IDs

2019-10-31 Thread Qi Zhang
Add device IDs for E810_XXV. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Qi Zhang --- doc/guides/rel_notes/release_19_11.rst | 1 + drivers/net/ice/base/ice_devids.h | 6 ++ 2 files changed, 7 insertions(+) diff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_no

Re: [dpdk-dev] [PATCH] net/ice: fix unexpected link down

2019-10-31 Thread Stillwell Jr, Paul M
Hi Xiaolong, > -Original Message- > From: dev On Behalf Of Ye Xiaolong > Sent: Monday, October 28, 2019 10:35 PM > To: Zhang, Qi Z > Cc: Yang, Qiming ; dev@dpdk.org; > sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/ice: fix unexpected link down > > Hi, Qi > > On 10/29, Qi Zhang

Re: [dpdk-dev] [PATCH] doc: remove Flow Director feature from hns3.ini and hns3_vf.ini

2019-10-31 Thread Ferruh Yigit
On 10/25/2019 12:08 PM, Thomas Monjalon wrote: > 15/10/2019 13:11, Ferruh Yigit: >> On 10/11/2019 3:29 AM, Wei Hu (Xavier) wrote: >>> This patch removes deprecated feature 'Flow Director' from hns3.ini >>> and hns3_vf.ini because the feature has been removed from the >>> feature list in the followi

Re: [dpdk-dev] [PATCH v7 08/14] app/testpmd: add hairpin support

2019-10-31 Thread Ori Kam
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, October 31, 2019 7:55 PM > To: Ori Kam ; Wenzhuo Lu ; > Jingjing Wu ; Bernard Iremonger > > Cc: dev@dpdk.org; step...@networkplumber.org > Subject: Re: [dpdk-dev] [PATCH v7 08/14] app/testpmd: add hairpin support > > On 10/31/

Re: [dpdk-dev] [PATCH v4] ethdev: add flow tag

2019-10-31 Thread Ferruh Yigit
On 10/27/2019 7:11 PM, Ori Kam wrote: > > >> -Original Message- >> From: Viacheslav Ovsiienko >> Sent: Sunday, October 27, 2019 8:42 PM >> To: dev@dpdk.org >> Cc: Thomas Monjalon ; Matan Azrad >> ; Ori Kam ; Yongseok Koh >> >> Subject: [PATCH v4] ethdev: add flow tag >> >> A tag is a tr

Re: [dpdk-dev] [PATCH] ethdev: remove deprecated port count function

2019-10-31 Thread Ferruh Yigit
On 10/28/2019 1:03 PM, Neil Horman wrote: > On Mon, Oct 28, 2019 at 11:49:34AM +0100, Thomas Monjalon wrote: >> The function rte_eth_dev_count() was marked as deprecated in DPDK 18.05 >> in commit d9a42a69febf ("ethdev: deprecate port count function"). >> It was planned to be removed after 19.11 LT

Re: [dpdk-dev] [PATCH] app/testpmd: fix IP next proto in set raw decap/encap

2019-10-31 Thread Slava Ovsiienko
> -Original Message- > From: dev On Behalf Of Xiaoyu Min > Sent: Thursday, October 31, 2019 12:11 > To: Ori Kam ; Adrien Mazarguil > ; Wenzhuo Lu ; > Jingjing Wu ; Bernard Iremonger > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] app/testpmd: fix IP next proto in set r

[dpdk-dev] DPDK Release Status Meeting 31/10/2019

2019-10-31 Thread Ferruh Yigit
Minutes 31 October 2019 --- Agenda: * Release Dates * Subtrees Participants: * Arm * Debian/Microsoft * Intel * Marvell * Mellanox * NXP * Red Hat Release Dates - * v19.11 dates: * RC1 is released on Sunday 27 October * https://mails.dpdk.org/archives/anno

Re: [dpdk-dev] [PATCH] net/bnxt: don't log at error level on flow creation

2019-10-31 Thread Ajit Khaparde
On Thu, Oct 31, 2019 at 11:23 AM Ajit Khaparde wrote: > > > On Mon, Oct 28, 2019 at 9:53 AM Stephen Hemminger < > step...@networkplumber.org> wrote: > >> Creating a flow is a normal event; should not be logged at error level. >> >> Fixes: 5c1171c97216 ("net/bnxt: refactor filter/flow") >> Signed-

Re: [dpdk-dev] [PATCH] net/bnxt: don't log at error level on flow creation

2019-10-31 Thread Ajit Khaparde
On Mon, Oct 28, 2019 at 9:53 AM Stephen Hemminger < step...@networkplumber.org> wrote: > Creating a flow is a normal event; should not be logged at error level. > > Fixes: 5c1171c97216 ("net/bnxt: refactor filter/flow") > Signed-off-by: Stephen Hemminger > Acked-by: Ajit Khaparde > --- > driv

Re: [dpdk-dev] [EXT] [PATCH v3 1/1] test/compress: unit tests refactoring

2019-10-31 Thread Shally Verma
> -Original Message- > From: Artur Trybula > Sent: Thursday, October 24, 2019 2:46 PM > To: dev@dpdk.org; fiona.tr...@intel.com; Shally Verma > ; adamx.dybkow...@intel.com; > arturx.tryb...@intel.com; akhil.go...@nxp.com > Subject: [EXT] [PATCH v3 1/1] test/compress: unit tests refactor

Re: [dpdk-dev] [PATCH] app/testpmd: fix IP next proto in set raw decap/encap

2019-10-31 Thread Ori Kam
> -Original Message- > From: Xiaoyu Min > Sent: Thursday, October 31, 2019 12:11 PM > To: Ori Kam ; Adrien Mazarguil > ; Wenzhuo Lu ; > Jingjing Wu ; Bernard Iremonger > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] app/testpmd: fix IP next proto in set raw decap/encap > > Th

Re: [dpdk-dev] [PATCH] mk: fix dpaax library dependency

2019-10-31 Thread Ferruh Yigit
On 10/31/2019 9:50 AM, Thierry Herbelot wrote: > On 10/31/19 8:14 AM, Gagandeep Singh wrote: >> This patch fixes dpaax library dependency for >> NXP's PMDs. >> >> Fixes: e56463ec47f0 ('net/enetc: enable dpaax library') >> Fixes: 67fc3ff97c39 ('net/pfe: introduce basic functions') >> Fixes: 9e727d4a

Re: [dpdk-dev] [PATCH v7 08/14] app/testpmd: add hairpin support

2019-10-31 Thread Ferruh Yigit
On 10/31/2019 5:36 PM, Ori Kam wrote: > Hi Ferruh, > > Thanks, for the comments PSB, > >> -Original Message- >> From: Ferruh Yigit >> Sent: Thursday, October 31, 2019 7:12 PM >> To: Ori Kam ; Wenzhuo Lu ; >> Jingjing Wu ; Bernard Iremonger >> >> Cc: dev@dpdk.org; step...@networkplumber.

Re: [dpdk-dev] [RFC PATCH] drivers/net: deprecate private API for VF ports

2019-10-31 Thread Ferruh Yigit
On 10/8/2019 3:23 PM, Yigit, Ferruh wrote: > On 7/30/2019 4:59 PM, Thomas Monjalon wrote: >> Since the concept of representors was introduced, >> we do not need any specific API for VF ports. >> Any VF port should be able to be configured through >> its representor port in a more generic fashion. >

Re: [dpdk-dev] [PATCH v3] vhost: fix vhost user virtqueue not accessible

2019-10-31 Thread Adrian Moreno
Hi Marvin, On 10/31/19 3:54 PM, Liu, Yong wrote: > > >> -Original Message- >> From: Bie, Tiwei >> Sent: Thursday, October 31, 2019 6:42 PM >> To: Liu, Yong >> Cc: maxime.coque...@redhat.com; Wang, Zhihong ; >> amore...@redhat.com; dev@dpdk.org >> Subject: Re: [PATCH v3] vhost: fix vhost

Re: [dpdk-dev] DPDK QoS scheduler changes, are we there yet?

2019-10-31 Thread Singh, Jasvinder
> -Original Message- > From: Yigit, Ferruh > Sent: Thursday, October 31, 2019 3:14 PM > To: Gladchun, Glenn ; dev@dpdk.org > Cc: Singh, Jasvinder ; Dumitrescu, Cristian > > Subject: Re: [dpdk-dev] DPDK QoS scheduler changes, are we there yet? > > On 10/30/2019 6:35 PM, Gladchun, Glenn wr

Re: [dpdk-dev] [PATCH v7 08/14] app/testpmd: add hairpin support

2019-10-31 Thread Ori Kam
Hi Ferruh, Thanks, for the comments PSB, > -Original Message- > From: Ferruh Yigit > Sent: Thursday, October 31, 2019 7:12 PM > To: Ori Kam ; Wenzhuo Lu ; > Jingjing Wu ; Bernard Iremonger > > Cc: dev@dpdk.org; step...@networkplumber.org > Subject: Re: [dpdk-dev] [PATCH v7 08/14] app/te

Re: [dpdk-dev] [PATCH v8 2/2] ethdev: move egress metadata to dynamic field

2019-10-31 Thread Olivier Matz
On Thu, Oct 31, 2019 at 04:48:26PM +, Viacheslav Ovsiienko wrote: > The dynamic mbuf fields were introduced by [1]. The egress metadata is > good candidate to be moved from statically allocated field tx_metadata to > dynamic one. Because mbufs are used in half-duplex fashion only, it is > safe

[dpdk-dev] [PATCH] crypto/aesni_gcm: support in-place chained mbufs

2019-10-31 Thread Pablo de Lara
IPSec Multi buffer library supports encryption on multiple segments. When dealing with chained buffers (multiple segments), as long as the operation is in-place, the destination buffer does not have to be contiguous (unlike in the case of out-of-place operation). Therefore, the limitation of not su

[dpdk-dev] [PATCH v1 2/3] net/i40e: remove the specific burst mode bit set

2019-10-31 Thread Haiyue Wang
Just keep the vectorization related burst mode bit set, others are not so generic. Signed-off-by: Haiyue Wang --- drivers/net/i40e/i40e_rxtx.c | 37 +--- 1 file changed, 13 insertions(+), 24 deletions(-) diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40

[dpdk-dev] [PATCH v1 3/3] ethdev: enhance the API for getting burst mode information

2019-10-31 Thread Haiyue Wang
1. Change the rte_eth_rx/tx_burst_mode_get ethdev APIs to convert the 'uint64_t options' to string and append it to 'alternate_options', so that application access the string directly. 2. Change the 'enum rte_eth_burst_mode_option' to macro definition, since ISO C restricts enumerator values to ra

[dpdk-dev] [PATCH v1 1/3] net/ice: remove the specific burst mode bit set

2019-10-31 Thread Haiyue Wang
Just keep the vectorization related burst mode bit set, others are not so generic. Signed-off-by: Haiyue Wang --- drivers/net/ice/ice_rxtx.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c index

Re: [dpdk-dev] [PATCH v7 00/14] add hairpin feature

2019-10-31 Thread Ferruh Yigit
On 10/30/2019 11:53 PM, Ori Kam wrote: > This patch set implements the hairpin feature. > The hairpin feature was introduced in RFC[1] > > The hairpin feature (different name can be forward) acts as "bump on the > wire", > meaning that a packet that is received from the wire can be modified using

Re: [dpdk-dev] [PATCH v7 08/14] app/testpmd: add hairpin support

2019-10-31 Thread Ferruh Yigit
On 10/30/2019 11:53 PM, Ori Kam wrote: > This commit introduce the hairpin queues to the testpmd. > the hairpin queue is configured using --hairpinq= > the hairpin queue adds n queue objects for both the total number > of TX queues and RX queues. > The connection between the queues are 1 to 1, firs

Re: [dpdk-dev] [PATCH v1 1/1] kernel/linux: introduce vfio_pf kernel module

2019-10-31 Thread Thomas Monjalon
We don't get enough attention on this topic. Let me rephrase the issue and the proposals with more people Cc'ed. We are talking about SR-IOV VFs in VMs with a PF managed on the host by DPDK. The PF driver is either a (1) bifurcated (Mellanox case), or (2) bound to UIO with igb_uio, or (3) bound to

Re: [dpdk-dev] [PATCH v3] port: Eventdev port support added in the rte_port library

2019-10-31 Thread Ferruh Yigit
On 10/1/2019 7:05 PM, Rahul Shah wrote: > Adding a new port type called eventdev to the > rte_port library. > > Signed-off-by: Rahul Shah > --- > lib/librte_port/Makefile | 4 +- > lib/librte_port/meson.build | 8 +- > lib/librte_port/rte_port_eventdev.c | 585 +

Re: [dpdk-dev] [PATCH v15 5/7] examples/eventdev_pipeline: add new Rx RSS hash offload

2019-10-31 Thread Pavan Nikhilesh Bhagavatula
>29/10/2019 16:37, pbhagavat...@marvell.com: >> From: Pavan Nikhilesh >> >> Since pipeline_generic uses `rte_mbuf::hash::rss` add the new Rx >offload >> flag `DEV_RX_OFFLOAD_RSS_HASH` to inform PMD to copy the RSS >hash result >> into the mbuf. >> >> Signed-off-by: Pavan Nikhilesh >> --- >> exam

Re: [dpdk-dev] [PATCH v15 4/7] drivers/net: update Rx RSS hash offload capabilities

2019-10-31 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: dev On Behalf Of Thomas Monjalon >Sent: Thursday, October 31, 2019 7:33 PM >To: Pavan Nikhilesh Bhagavatula >Cc: dev@dpdk.org; ferruh.yi...@intel.com; >arybche...@solarflare.com; Jerin Jacob Kollanukkaran >; Ajit Khaparde ; >Somnath Kotur ; Rahul Lakkireddy >

[dpdk-dev] [PATCH v8 1/2] ethdev: extend flow metadata

2019-10-31 Thread Viacheslav Ovsiienko
Currently, metadata can be set on egress path via mbuf tx_metadata field with PKT_TX_METADATA flag and RTE_FLOW_ITEM_TYPE_META matches metadata. This patch extends the metadata feature usability. 1) RTE_FLOW_ACTION_TYPE_SET_META When supporting multiple tables, Tx metadata can also be set by a r

[dpdk-dev] [PATCH v8 2/2] ethdev: move egress metadata to dynamic field

2019-10-31 Thread Viacheslav Ovsiienko
The dynamic mbuf fields were introduced by [1]. The egress metadata is good candidate to be moved from statically allocated field tx_metadata to dynamic one. Because mbufs are used in half-duplex fashion only, it is safe to share this dynamic field with ingress metadata. The shared dynamic field c

[dpdk-dev] [PATCH v8 0/2] extend flow metadata feature

2019-10-31 Thread Viacheslav Ovsiienko
This patchset just combines two metadata related patches to provide right applying order. The first patch introduces the ingress metadata with mbuf dynamic field usage, the second one moves egress metadata to the dynamic field presented by first patch. Signed-off-by: Viacheslav Ovsiienko Viaches

Re: [dpdk-dev] [EXT] Re: [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-10-31 Thread Pavan Nikhilesh Bhagavatula
>29/10/2019 16:37, pbhagavat...@marvell.com: >> From: Pavan Nikhilesh >> --- a/lib/librte_ethdev/rte_ethdev.c >> +++ b/lib/librte_ethdev/rte_ethdev.c >> +static int >> +_rte_eth_dev_validate_offloads(uint16_t port_id, uint64_t >req_offloads, >> + uint64_t set_offloads, >>

Re: [dpdk-dev] [PATCH v5 1/2] ethdev: expose basic xstats for driver use

2019-10-31 Thread Stephen Hemminger
On Thu, 26 Sep 2019 15:46:52 +0300 Andrew Rybchenko wrote: > On 9/19/19 4:17 PM, Stephen Hemminger wrote: > > Avoid duplication by having generic basic xstats available > > for use by drivers. A later patch uses this for failsafe > > driver. > > > > Signed-off-by: Stephen Hemminger > > Acked-by:

Re: [dpdk-dev] [PATCH v15 1/7] ethdev: add set ptype function

2019-10-31 Thread Pavan Nikhilesh Bhagavatula
>29/10/2019 16:37, pbhagavat...@marvell.com: >> From: Pavan Nikhilesh >> --- a/doc/guides/rel_notes/release_19_11.rst >> +++ b/doc/guides/rel_notes/release_19_11.rst >> @@ -231,6 +231,14 @@ New Features >>* Added a console command to testpmd app, ``show port (port_id) >ptypes`` which >> g

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-10-31 Thread Pavan Nikhilesh Bhagavatula
>From: Pavan Nikhilesh Bhagavatula >> Hi Matan, >> >> >Hi Pavan >> > >> >From: Pavan Nikhilesh >> >> Some PMDs cannot work when certain offloads are >enable/disabled, >> >as a >> >> workaround PMDs auto enable/disable offloads internally and >expose >> >it >> >> through dev->data->dev_conf.rxmode.

Re: [dpdk-dev] [PATCH v2] config: disable 1588 timer support on DPAA2

2019-10-31 Thread David Marchand
On Thu, Oct 31, 2019 at 2:04 PM Nipun Gupta wrote: > > This patch disables the 1588 timer support by default on DPAA2 > platform due to the performance impact. > By default it is disabled in the common/base, so remove the entry config/common_base > from DPAA2. > > Signed-off-by: Nipun Gupta > -

Re: [dpdk-dev] [PATCH] bus/fslmc: fix for resource leak coverity issue

2019-10-31 Thread David Marchand
On Tue, Sep 10, 2019 at 9:33 AM Agalya Babu RadhaKrishnan wrote: > > From: Agalya Babu RadhaKrishnan > > 1 issue caught by 344967 > Leaked_storage: Variable sep going out of scope leaks the > storage it points to. > > When 'sep' is not null and sep_exist is 0, 'sep' is freed > before going out of

Re: [dpdk-dev] [PATCH v7 1/2] ethdev: extend flow metadata

2019-10-31 Thread Slava Ovsiienko
Hi Olivier, > -Original Message- > From: Olivier Matz > Sent: Thursday, October 31, 2019 17:47 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Matan Azrad ; Raslan > Darawsheh ; Thomas Monjalon > ; arybche...@solarflare.com; Ori Kam > ; Yongseok Koh > Subject: Re: [PATCH v7 1/2] ethdev: exten

Re: [dpdk-dev] [PATCH v7 2/2] ethdev: move egress metadata to dynamic field

2019-10-31 Thread Slava Ovsiienko
Hi, > -Original Message- > From: Olivier Matz > Sent: Thursday, October 31, 2019 17:51 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Matan Azrad ; Raslan > Darawsheh ; Thomas Monjalon > ; arybche...@solarflare.com; Ori Kam > > Subject: Re: [PATCH v7 2/2] ethdev: move egress metadata to dyn

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add the API for getting burst mode information

2019-10-31 Thread Wang, Haiyue
> -Original Message- > From: Yigit, Ferruh > Sent: Thursday, October 31, 2019 23:30 > To: Wang, Haiyue ; Jerin Jacob > Cc: Thomas Monjalon ; dpdk-dev ; Ye, > Xiaolong > ; Kinsella, Ray ; Iremonger, > Bernard > ; Sun, Chenmin ; Andrew > Rybchenko > ; Slava Ovsiienko ; > Stephen Hemming

Re: [dpdk-dev] [PATCH v7 2/2] ethdev: move egress metadata to dynamic field

2019-10-31 Thread Olivier Matz
Hi, On Thu, Oct 31, 2019 at 01:05:21PM +, Viacheslav Ovsiienko wrote: > The dynamic mbuf fields were introduced by [1]. The egress metadata is > good candidate to be moved from statically allocated field tx_metadata to > dynamic one. Because mbufs are used in half-duplex fashion only, it is >

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-10-31 Thread Matan Azrad
From: Pavan Nikhilesh Bhagavatula > Hi Matan, > > >Hi Pavan > > > >From: Pavan Nikhilesh > >> Some PMDs cannot work when certain offloads are enable/disabled, > >as a > >> workaround PMDs auto enable/disable offloads internally and expose > >it > >> through dev->data->dev_conf.rxmode.offloads.

Re: [dpdk-dev] [PATCH v7 1/2] ethdev: extend flow metadata

2019-10-31 Thread Olivier Matz
Hi Slava, One comment at the end. On Thu, Oct 31, 2019 at 01:05:20PM +, Viacheslav Ovsiienko wrote: > Currently, metadata can be set on egress path via mbuf tx_metadata field > with PKT_TX_METADATA flag and RTE_FLOW_ITEM_TYPE_META matches metadata. > > This patch extends the metadata feature

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add the API for getting burst mode information

2019-10-31 Thread Ferruh Yigit
On 10/31/2019 3:07 PM, Wang, Haiyue wrote: >> -Original Message- >> From: Yigit, Ferruh >> Sent: Thursday, October 31, 2019 22:58 >> To: Wang, Haiyue ; Jerin Jacob >> Cc: Thomas Monjalon ; dpdk-dev ; Ye, >> Xiaolong >> ; Kinsella, Ray ; Iremonger, >> Bernard >> ; Sun, Chenmin ; Andrew

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-10-31 Thread Pavan Nikhilesh Bhagavatula
Hi Matan, >Hi Pavan > >From: Pavan Nikhilesh >> Some PMDs cannot work when certain offloads are enable/disabled, >as a >> workaround PMDs auto enable/disable offloads internally and expose >it >> through dev->data->dev_conf.rxmode.offloads. >> >> After device specific dev_configure is called comp

Re: [dpdk-dev] DPDK QoS scheduler changes, are we there yet?

2019-10-31 Thread Ferruh Yigit
On 10/30/2019 6:35 PM, Gladchun, Glenn wrote: > Hi guys, > > I stumbled upon this 11 month old post (https://narkive.com/ZwBXg4Xe) that > goes over future enhancements to the scheduler. All of them are vital, and I > am especially interested in 16 TCs per pipe… Christian and/or Jasvinder, is >

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-10-31 Thread Matan Azrad
Hi Pavan From: Pavan Nikhilesh > Some PMDs cannot work when certain offloads are enable/disabled, as a > workaround PMDs auto enable/disable offloads internally and expose it > through dev->data->dev_conf.rxmode.offloads. > > After device specific dev_configure is called compare the requested of

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add the API for getting burst mode information

2019-10-31 Thread Wang, Haiyue
> -Original Message- > From: Yigit, Ferruh > Sent: Thursday, October 31, 2019 22:58 > To: Wang, Haiyue ; Jerin Jacob > Cc: Thomas Monjalon ; dpdk-dev ; Ye, > Xiaolong > ; Kinsella, Ray ; Iremonger, > Bernard > ; Sun, Chenmin ; Andrew > Rybchenko > ; Slava Ovsiienko ; > Stephen Hemming

Re: [dpdk-dev] [PATCH v7 3/4] doc: updates to versioning guide for abi versions

2019-10-31 Thread Mcnamara, John
> -Original Message- > From: Ray Kinsella > Sent: Friday, October 25, 2019 5:29 PM > To: dev@dpdk.org > Cc: m...@ashroe.eu; tho...@monjalon.net; step...@networkplumber.org; > Richardson, Bruce ; Yigit, Ferruh > ; Ananyev, Konstantin > ; jer...@marvell.com; > olivier.m...@6wind.com; nhor

Re: [dpdk-dev] [PATCH v7 4/4] doc: add maintainer for abi policy

2019-10-31 Thread Mcnamara, John
> -Original Message- > From: Ray Kinsella > Sent: Friday, October 25, 2019 5:29 PM > To: dev@dpdk.org > Cc: m...@ashroe.eu; tho...@monjalon.net; step...@networkplumber.org; > Richardson, Bruce ; Yigit, Ferruh > ; Ananyev, Konstantin > ; jer...@marvell.com; > olivier.m...@6wind.com; nhor

Re: [dpdk-dev] [PATCH v7 2/4] doc: changes to abi policy introducing major abi versions

2019-10-31 Thread Mcnamara, John
> -Original Message- > From: Ray Kinsella > Sent: Friday, October 25, 2019 5:29 PM > To: dev@dpdk.org > Cc: m...@ashroe.eu; tho...@monjalon.net; step...@networkplumber.org; > Richardson, Bruce ; Yigit, Ferruh > ; Ananyev, Konstantin > ; jer...@marvell.com; > olivier.m...@6wind.com; nhor.

Re: [dpdk-dev] [PATCH v7 1/4] doc: separate versioning.rst into version and policy

2019-10-31 Thread Mcnamara, John
> -Original Message- > From: Ray Kinsella > Sent: Friday, October 25, 2019 5:29 PM > To: dev@dpdk.org > Cc: m...@ashroe.eu; tho...@monjalon.net; step...@networkplumber.org; > Richardson, Bruce ; Yigit, Ferruh > ; Ananyev, Konstantin > ; jer...@marvell.com; > olivier.m...@6wind.com; nhor

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add the API for getting burst mode information

2019-10-31 Thread Ferruh Yigit
On 10/31/2019 11:16 AM, Wang, Haiyue wrote: >> -Original Message- >> From: Jerin Jacob >> Sent: Thursday, October 31, 2019 18:46 >> To: Wang, Haiyue >> Cc: Yigit, Ferruh ; Thomas Monjalon >> ; dpdk-dev >> ; Ye, Xiaolong ; Kinsella, Ray >> ; >> Iremonger, Bernard ; Sun, Chenmin >> ; And

Re: [dpdk-dev] [PATCH v3] vhost: fix vhost user virtqueue not accessible

2019-10-31 Thread Liu, Yong
> -Original Message- > From: Bie, Tiwei > Sent: Thursday, October 31, 2019 6:42 PM > To: Liu, Yong > Cc: maxime.coque...@redhat.com; Wang, Zhihong ; > amore...@redhat.com; dev@dpdk.org > Subject: Re: [PATCH v3] vhost: fix vhost user virtqueue not accessible > > On Wed, Oct 30, 2019 at 1

Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

2019-10-31 Thread Thomas Monjalon
31/10/2019 10:49, Andrew Rybchenko: > On 10/28/19 5:00 PM, Ori Kam wrote: > >> -Original Message- > > From: Andrew Rybchenko > >> On 10/28/19 1:50 PM, Ori Kam wrote: > >>> Hi Pavan, > >>> > >>> Sorry for jumping in late. > >>> > >>> I don't understand why we need this feature. If the user

Re: [dpdk-dev] Link status issue with i40e firmware 7.0x

2019-10-31 Thread David Marchand
On Wed, Oct 30, 2019 at 3:20 PM David Marchand wrote: > > Hello, > > We recently upgraded a XXV710 nic on a Dell R740 server (running RHEL > 7.7) to firmware version 7.00. > > # ethtool -i enp59s0f0 > driver: i40e > version: 2.8.10-k > firmware-version: 7.00 0x80004cf8 1.2154.0 > expansion-rom-ver

[dpdk-dev] [PATCH] crypto/dpaa2_sec: fix build with clang 3.4.2

2019-10-31 Thread Ciara Power
Building with clang 3.4.2 caused the following error: CC dpaa2_sec_dpseci.o In file included from /dpdk/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:40: In file included from /dpdk/drivers/common/dpaax/caamflib/desc/ipsec.h:11: In file included from /dpdk/drivers/common/dpaax/caamflib/rta.h:11: I

[dpdk-dev] [PATCH] examples/ipsec-secgw: fix gcm iv length

2019-10-31 Thread Marcin Smoczynski
The example IPsec application does not work properly when using AES-GCM with crypto_openssl. ESP with AES-GCM uses standard 96bit long algorithm IV ([1]) which later concatenated with be32(1) forms a J0 block. GCM specification ([2], chapter 7.1) states that when length of IV is different than 96b

Re: [dpdk-dev] [PATCH v15 5/7] examples/eventdev_pipeline: add new Rx RSS hash offload

2019-10-31 Thread Thomas Monjalon
29/10/2019 16:37, pbhagavat...@marvell.com: > From: Pavan Nikhilesh > > Since pipeline_generic uses `rte_mbuf::hash::rss` add the new Rx offload > flag `DEV_RX_OFFLOAD_RSS_HASH` to inform PMD to copy the RSS hash result > into the mbuf. > > Signed-off-by: Pavan Nikhilesh > --- > examples/event

Re: [dpdk-dev] [PATCH v15 4/7] drivers/net: update Rx RSS hash offload capabilities

2019-10-31 Thread Thomas Monjalon
29/10/2019 16:37, pbhagavat...@marvell.com: > From: Pavan Nikhilesh > > Add DEV_RX_OFFLOAD_RSS_HASH flag for all PMDs that support RSS hash > delivery. > > Signed-off-by: Pavan Nikhilesh > Reviewed-by: Andrew Rybchenko > Reviewed-by: Hemant Agrawal > Acked-by: Jerin Jacob > Acked-by: Ajit Kh

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-10-31 Thread Thomas Monjalon
29/10/2019 16:37, pbhagavat...@marvell.com: > From: Pavan Nikhilesh > --- a/lib/librte_ethdev/rte_ethdev.c > +++ b/lib/librte_ethdev/rte_ethdev.c > +static int > +_rte_eth_dev_validate_offloads(uint16_t port_id, uint64_t req_offloads, > +uint64_t set_offloads, > +

Re: [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD

2019-10-31 Thread Thomas Monjalon
29/10/2019 17:53, Andrew Rybchenko: > On 10/29/19 6:37 PM, pbhagavat...@marvell.com wrote: > > From: Pavan Nikhilesh > > --- a/lib/librte_ethdev/rte_ethdev.c > > +++ b/lib/librte_ethdev/rte_ethdev.c > > +static int > > +_rte_eth_dev_validate_offloads(uint16_t port_id, uint64_t req_offloads, > > I

Re: [dpdk-dev] [PATCH v15 2/7] ethdev: add mbuf RSS update as an offload

2019-10-31 Thread Thomas Monjalon
29/10/2019 16:37, pbhagavat...@marvell.com: > --- a/doc/guides/rel_notes/release_19_11.rst > +++ b/doc/guides/rel_notes/release_19_11.rst > @@ -239,6 +239,13 @@ New Features >* This scheme will allow PMDs to avoid lookup to internal ptype table on > Rx > and thereby improve Rx performan

Re: [dpdk-dev] [PATCH v15 1/7] ethdev: add set ptype function

2019-10-31 Thread Thomas Monjalon
29/10/2019 16:37, pbhagavat...@marvell.com: > From: Pavan Nikhilesh > --- a/doc/guides/rel_notes/release_19_11.rst > +++ b/doc/guides/rel_notes/release_19_11.rst > @@ -231,6 +231,14 @@ New Features >* Added a console command to testpmd app, ``show port (port_id) ptypes`` > which > gives

Re: [dpdk-dev] [PATCH v7 2/2] ethdev: move egress metadata to dynamic field

2019-10-31 Thread Ori Kam
> -Original Message- > From: dev On Behalf Of Viacheslav Ovsiienko > Sent: Thursday, October 31, 2019 3:05 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Thomas Monjalon ; > olivier.m...@6wind.com; arybche...@solarflare.com; Ori Kam > > Subject: [dpdk-dev] [PATCH v7 2/2

[dpdk-dev] [PATCH v5 3/3] crypto/dpaa2_sec: enable anti replay window config

2019-10-31 Thread Hemant Agrawal
This patch usages the anti replay window size to config the anti replay checking in decap path for lookaside IPSEC offload Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 24 +++ drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 6 +++-- drivers/cryp

[dpdk-dev] [PATCH v5 2/3] ipsec: remove redundant replay_win_sz

2019-10-31 Thread Hemant Agrawal
The rte_security lib has introduced replay_win_sz, so it can be removed from the rte_ipsec lib. Also, the relaved tests,app are also update to reflect the usages. Signed-off-by: Hemant Agrawal Acked-by: Konstantin Ananyev --- app/test/test_ipsec.c | 2 +- doc/guides/rel_notes/

[dpdk-dev] [PATCH v5 1/3] security: add anti replay window size

2019-10-31 Thread Hemant Agrawal
At present the ipsec xfrom is missing the important step to configure the anti replay window size. The newly added field will also help in to enable or disable the anti replay checking, if available in offload by means of non-zero or zero value. Signed-off-by: Hemant Agrawal Acked-by: Konstantin

[dpdk-dev] [PATCH v7 1/2] ethdev: extend flow metadata

2019-10-31 Thread Viacheslav Ovsiienko
Currently, metadata can be set on egress path via mbuf tx_metadata field with PKT_TX_METADATA flag and RTE_FLOW_ITEM_TYPE_META matches metadata. This patch extends the metadata feature usability. 1) RTE_FLOW_ACTION_TYPE_SET_META When supporting multiple tables, Tx metadata can also be set by a r

[dpdk-dev] [PATCH v7 2/2] ethdev: move egress metadata to dynamic field

2019-10-31 Thread Viacheslav Ovsiienko
The dynamic mbuf fields were introduced by [1]. The egress metadata is good candidate to be moved from statically allocated field tx_metadata to dynamic one. Because mbufs are used in half-duplex fashion only, it is safe to share this dynamic field with ingress metadata. The shared dynamic field c

[dpdk-dev] [PATCH v7 0/2] extend flow metadata feature

2019-10-31 Thread Viacheslav Ovsiienko
This patchset just combines two metadata related patches to provide right applying order. The first patch introduces the ingress metadata with mbuf dynamic field usage, the second one moves egress metadata to the dynamic field presented by first patch. Signed-off-by: Viacheslav Ovsiienko Viaches

[dpdk-dev] [PATCH v2] config: disable 1588 timer support on DPAA2

2019-10-31 Thread Nipun Gupta
This patch disables the 1588 timer support by default on DPAA2 platform due to the performance impact. By default it is disabled in the common/base, so remove the entry from DPAA2. Signed-off-by: Nipun Gupta --- Changes in v2: - Change only the 1588 timestamp option in DPAA2 and do not touch

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/ena: fix false indication of bad L4 Rx csums

2019-10-31 Thread Ferruh Yigit
On 10/28/2019 10:23 AM, Michal Krawczyk wrote: > From: Igor Chauskin > > Add checking of l4_csum_checked and frag flags before checking the > l4_csum_error flag. > > In case of IP fragment/unchecked L4 csum - add PKT_RX_L4_CKSUM_UNKNOWN > flag to the indicated mbuf. > > Fixes: 1173fca25af9 ("en

Re: [dpdk-dev] [PATCH] bus/fslmc: fix for resource leak coverity issue

2019-10-31 Thread Sachin Saxena
> -Original Message- > From: David Marchand > Sent: Friday, October 25, 2019 12:47 AM > To: Sachin Saxena > Cc: Babu Radhakrishnan, AgalyaX ; > dev@dpdk.org; Pattan, Reshma ; Hemant > Agrawal ; Parthasarathy, JananeeX M > ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] bus/fslmc: fix

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add the API for getting burst mode information

2019-10-31 Thread Wang, Haiyue
> -Original Message- > From: Jerin Jacob > Sent: Thursday, October 31, 2019 18:46 > To: Wang, Haiyue > Cc: Yigit, Ferruh ; Thomas Monjalon > ; dpdk-dev > ; Ye, Xiaolong ; Kinsella, Ray > ; > Iremonger, Bernard ; Sun, Chenmin > ; Andrew > Rybchenko ; Slava Ovsiienko > ; Stephen Hemming

  1   2   >