>-----Original Message-----
>From: dev <[email protected]> On Behalf Of Thomas Monjalon
>Sent: Thursday, October 31, 2019 7:33 PM
>To: Pavan Nikhilesh Bhagavatula <[email protected]>
>Cc: [email protected]; [email protected];
>[email protected]; Jerin Jacob Kollanukkaran
><[email protected]>; Ajit Khaparde <[email protected]>;
>Somnath Kotur <[email protected]>; Rahul Lakkireddy
><[email protected]>; Hemant Agrawal
><[email protected]>; Sachin Saxena
><[email protected]>; Wenzhuo Lu <[email protected]>;
>John Daley <[email protected]>; Hyong Youb Kim
><[email protected]>; Qi Zhang <[email protected]>; Xiao Wang
><[email protected]>; Ziyang Xuan <[email protected]>;
>Xiaoyun Wang <[email protected]>; Guoyang Zhou
><[email protected]>; Beilei Xing <[email protected]>;
>Jingjing Wu <[email protected]>; Qiming Yang
><[email protected]>; Konstantin Ananyev
><[email protected]>; Shijith Thotton
><[email protected]>; Srisivasubramanian Srinivasan
><[email protected]>; Matan Azrad <[email protected]>;
>Shahaf Shuler <[email protected]>; Viacheslav Ovsiienko
><[email protected]>; Stephen Hemminger
><[email protected]>; K. Y. Srinivasan <[email protected]>;
>Haiyang Zhang <[email protected]>; Alejandro Lucero
><[email protected]>; Nithin Kumar Dabilpuram
><[email protected]>; Kiran Kumar Kokkilagadda
><[email protected]>; Rasesh Mody <[email protected]>;
>Shahed Shaikh <[email protected]>; Maciej Czekaj
><[email protected]>; Yong Wang <[email protected]>
>Subject: Re: [dpdk-dev] [PATCH v15 4/7] drivers/net: update Rx RSS
>hash offload capabilities
>
>29/10/2019 16:37, [email protected]:
>> From: Pavan Nikhilesh <[email protected]>
>>
>> Add DEV_RX_OFFLOAD_RSS_HASH flag for all PMDs that support RSS
>hash
>> delivery.
>>
>> Signed-off-by: Pavan Nikhilesh <[email protected]>
>> Reviewed-by: Andrew Rybchenko <[email protected]>
>> Reviewed-by: Hemant Agrawal <[email protected]>
>> Acked-by: Jerin Jacob <[email protected]>
>> Acked-by: Ajit Khaparde <[email protected]>
>> ---
>> + if (!(dev->data->dev_conf.rxmode.offloads &
>DEV_RX_OFFLOAD_RSS_HASH))
>> + dev->data->dev_conf.rxmode.offloads |=
>DEV_RX_OFFLOAD_RSS_HASH;
>
>Excuse me, I miss why you need a check before setting the bit.
Currently, none of the PMDs support disabling RSS_HASH (except octeontx2) since
it involves
adding an if check in Rx routine that might lead to perf impact.
So, we are implicitly enabling the offload for all the PMDs if an application
decides to disable
RSS_HASH. In future if PMD maintainer decides to add this feature she/he can
remove the check.
>
