> -----Original Message-----
> From: dev <dev-boun...@dpdk.org> On Behalf Of Viacheslav Ovsiienko
> Sent: Thursday, October 31, 2019 3:05 PM
> To: dev@dpdk.org
> Cc: Matan Azrad <ma...@mellanox.com>; Raslan Darawsheh
> <rasl...@mellanox.com>; Thomas Monjalon <tho...@monjalon.net>;
> olivier.m...@6wind.com; arybche...@solarflare.com; Ori Kam
> <or...@mellanox.com>
> Subject: [dpdk-dev] [PATCH v7 2/2] ethdev: move egress metadata to dynamic
> field
>
> The dynamic mbuf fields were introduced by [1]. The egress metadata is
> good candidate to be moved from statically allocated field tx_metadata to
> dynamic one. Because mbufs are used in half-duplex fashion only, it is
> safe to share this dynamic field with ingress metadata.
>
> The shared dynamic field contains either egress (if application going to
> transmit mbuf with tx_burst) or ingress (if mbuf is received with rx_burst)
> metadata and can be accessed by RTE_FLOW_DYNF_METADATA() macro or
> with
> rte_flow_dynf_metadata_set() and rte_flow_dynf_metadata_get() helper
> routines. PKT_TX_DYNF_METADATA/PKT_RX_DYNF_METADATA flag will be set
> along with the data.
>
> The mbuf dynamic field must be registered by calling
> rte_flow_dynf_metadata_register() prior accessing the data.
>
> The availability of dynamic mbuf metadata field can be checked with
> rte_flow_dynf_metadata_avail() routine.
>
> DEV_TX_OFFLOAD_MATCH_METADATA offload and configuration flag is
> removed.
> The metadata support in PMDs is engaged on dynamic field registration.
>
> Metadata feature is getting complex. We might have some set of actions
> and items that might be supported by PMDs in multiple combinations,
> the supported values and masks are the subjects to query by perfroming
> trials (with rte_flow_validate).
>
> [1]
> https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatches.dp
> dk.org%2Fpatch%2F62040%2F&data=02%7C01%7Corika%40mellanox.com
> %7C59c1c0e65ad7436cb8f708d75e031341%7Ca652971c7d2e4d9ba6a4d14925
> 6f461b%7C0%7C0%7C637081239629362825&sdata=A%2Fe1hjy02uGsgK5A
> ouK6pF%2BRdju5lcANP3ye3xx6qKs%3D&reserved=0
>
> Signed-off-by: Viacheslav Ovsiienko <viachesl...@mellanox.com>
> ---
>
> v7: - updates release notes
> v6: -
> https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatches.dp
> dk.org%2Fpatch%2F62244%2F&data=02%7C01%7Corika%40mellanox.com
> %7C59c1c0e65ad7436cb8f708d75e031341%7Ca652971c7d2e4d9ba6a4d14925
> 6f461b%7C0%7C0%7C637081239629362825&sdata=72hW3BfXHQ0KGzNq
> o3M1TR%2BI4oQdJ5sU4wYzK74rF%2FA%3D&reserved=0
>
> app/test-pmd/cmdline.c | 3 ++-
> app/test-pmd/testpmd.c | 4 ----
> app/test-pmd/testpmd.h | 2 +-
> app/test-pmd/util.c | 15 +++++++++------
> app/test/test_mbuf.c | 1 -
> doc/guides/prog_guide/rte_flow.rst | 6 +++---
> doc/guides/rel_notes/release_19_11.rst | 5 +++++
> drivers/net/mlx5/mlx5_flow_dv.c | 19 ++++++-------------
> drivers/net/mlx5/mlx5_rxtx.c | 22 +++++++++++-----------
> drivers/net/mlx5/mlx5_rxtx_vec.h | 6 ------
> drivers/net/mlx5/mlx5_txq.c | 4 ----
> lib/librte_ethdev/rte_ethdev.c | 1 -
> lib/librte_ethdev/rte_ethdev.h | 5 -----
> lib/librte_ethdev/rte_flow.h | 19 ++++++++++---------
> lib/librte_mbuf/rte_mbuf.c | 2 --
> lib/librte_mbuf/rte_mbuf_core.h | 19 +------------------
> 16 files changed, 48 insertions(+), 85 deletions(-)
>
Acked-by: Ori Kam <or...@mellanox.com>
Thanks,
Ori
