29/10/2019 17:53, Andrew Rybchenko: > On 10/29/19 6:37 PM, pbhagavat...@marvell.com wrote: > > From: Pavan Nikhilesh <pbhagavat...@marvell.com> > > --- a/lib/librte_ethdev/rte_ethdev.c > > +++ b/lib/librte_ethdev/rte_ethdev.c > > +static int > > +_rte_eth_dev_validate_offloads(uint16_t port_id, uint64_t req_offloads, > > I'm not sure about underscore in function name. May be Thomas or > Ferruh can comment.
If it is private, don't use the rte_ prefix at all. This function can be simply named "validate_offloads".
