Re: [dpdk-dev] [PATCH v6 4/5] mbuf: add a pktmbuf copy routine

On Tue, Oct 08, 2019 at 09:33:49AM -0700, Stephen Hemminger wrote: > This is a commonly used operation that surprisingly the > DPDK has not supported. The new rte_pktmbuf_copy does a > deep copy of packet. This is a complete copy including > meta-data. > > It handles the case where the source mbuf

Re: [dpdk-dev] [PATCH v2] net/ice: invoke callback func when link status change

On 10/16, Leyi Rong wrote: >Needs to call _rte_eth_dev_callback_process to run registered >callbacks when link status change. > Is it a must to call _rte_eth_dev_callback_process after link status change, I see ice_link_update is also called in ice_dev_start, do we need to apply the same change th

Re: [dpdk-dev] [PATCH v5] eventdev: flag to identify same destined packets enqueue

Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH 2/2] event/dpaa: support Tx adapter

Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH] kni: add ability to set min/max MTU

On Fri, Oct 11, 2019 at 6:16 PM Ferruh Yigit wrote: > > On 9/19/2019 12:22 PM, Igor Ryzhov wrote: > > Starting with kernel version 4.10, there are new min/max MTU values in > > net_device structure, which are set to ETH_MIN_MTU and ETH_DATA_LEN by > > default. We should be able to change these val

Re: [dpdk-dev] [PATCH 1/2] event/dpaa: fix number of supported atomic flows

Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH 0/2] add RSS support in ice vector path

On 10/15, Leyi Rong wrote: >This patchset support 32 bits RSS in FlexMD fields in >ice vector path, both SSE and AVX paths. > >Leyi Rong (2): > net/ice: add RSS support in SSE path > net/ice: add RSS support in AVX path > > drivers/net/ice/ice_rxtx_vec_avx2.c | 8 > drivers/net/ice/ice_rx

[dpdk-dev] [PATCH v2] net/ice: invoke callback func when link status change

Needs to call _rte_eth_dev_callback_process to run registered callbacks when link status change. Fixes: cf911d90e366 ("net/ice: support link update") Signed-off-by: Leyi Rong --- v2: - adds fixline in commit log. --- drivers/net/ice/ice_ethdev.c | 6 +- 1 file changed, 5 insertions(+), 1 d

Re: [dpdk-dev] [PATCH] net/ixgbe: avoid multpile definitions of 'bool'

Hi, On 10/03, Dharmik Thakkar wrote: >Compilation issue arises due to multiple definitions of 'bool' >in 'ixgbe_ethdev.h'. Which compiler would trigger this compilation issue? And we have several "typedef int bool" in multiple drivers, drivers/net/bnx2x/bnx2x_ethdev.h:50:typedef int bool; driver

Re: [dpdk-dev] [PATCH 2/2] net/ice: add RSS support in AVX path

Hi, > -Original Message- > From: Rong, Leyi > Sent: Tuesday, October 15, 2019 3:51 PM > To: Lu, Wenzhuo ; Zhang, Qi Z > ; Ye, Xiaolong > Cc: dev@dpdk.org; Rong, Leyi > Subject: [PATCH 2/2] net/ice: add RSS support in AVX path > > Support 32 bits RSS in FlexMD fields in AVX path. > > Si

Re: [dpdk-dev] [PATCH 1/2] net/ice: add RSS support in SSE path

Hi, > -Original Message- > From: Rong, Leyi > Sent: Tuesday, October 15, 2019 3:51 PM > To: Lu, Wenzhuo ; Zhang, Qi Z > ; Ye, Xiaolong > Cc: dev@dpdk.org; Rong, Leyi > Subject: [PATCH 1/2] net/ice: add RSS support in SSE path > > Support 32 bits RSS in FlexMD fields in SSE path. > > Si

Re: [dpdk-dev] [PATCH v2 0/5] add asym support in crypto_octeontx PMD

> > Hi Akhil > > You can use the following description. > > +* **Added asymmetric support to Marvell OCTEON TX crypto PMD.** > + > + Added support for asymmetric operations in Marvell OCTEON TX cypto PMD. > Supports RSA > + and modexp operations. > + > Updated with enq/deq patch. Thanks.

Re: [dpdk-dev] [PATCH] net/ice: correct lut type for RSS

On 10/11, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Su, Simei >> Sent: Friday, October 11, 2019 1:12 PM >> To: Zhang, Qi Z ; Yang, Qiming >> ; Lu, Wenzhuo >> Cc: dev@dpdk.org; Su, Simei ; sta...@dpdk.org >> Subject: [PATCH] net/ice: correct lut type for RSS >> >> This patch ch

Re: [dpdk-dev] [PATCH] net/ice: invoke callback func when link status change

Hi, Leyi On 10/14, Leyi Rong wrote: >Call _rte_eth_dev_callback_process when link status change. Could you elaborate more in commit log, like why we need this patch, what's the impact without this patch, is it a fix, etc? Thanks, Xiaolong > >Signed-off-by: Leyi Rong >--- > drivers/net/ice/ice

Re: [dpdk-dev] make install with igb_uio

+ dev On Tuesday, October 15, 2019, 04:28:11 PM GMT+5:30, sachin gupta wrote: Hi,I would like to compile dpdk source without the igb_uio driver.Can someone help with this. RegardsSachin

Re: [dpdk-dev] [PATCH v2 0/5] add asym support in crypto_octeontx PMD

Hi Akhil You can use the following description. +* **Added asymmetric support to Marvell OCTEON TX crypto PMD.** + + Added support for asymmetric operations in Marvell OCTEON TX cypto PMD. Supports RSA + and modexp operations. + Thanks, Anoob > -Original Message- > From: Akhil Goyal

Re: [dpdk-dev] [PATCH] net/virtio: fix broken transmit functionality

On Tue, Oct 15, 2019 at 09:11:27AM +0100, Andrew Rybchenko wrote: > Previous fix removes usage of rte_pktmbuf_prepend() to get pointer > to virtio net header which changes mbuf data_off and data_len. > Size of virtio net header is added to segment length when Tx descriptor > is composed, but segmen

Re: [dpdk-dev] [PATCH v2 0/3] examples/ipsec-secgw: set default

Hi Akhil, Marvell is NOT OK with this change in this cycle. The library is still emerging and the boundary between ipsec-secgw and lib ipsec still hasn't emerged clearly. Moreover, lib_ipsec mode isn't even working with the default conf (I believe the fix for this still in discussion. The issue

Re: [dpdk-dev] [v2] net/i40e: fix integer overflow

On 10/15, Xiao Zhang wrote: >When config i40e rx queue, the temporary variable to store max packet >length is not big enough which leads to integer overflow issue. This >patch is to fix the issue by removing the variable and using the >expression directly since the variable only used once. > >Fixes

Re: [dpdk-dev] [EXT] Re: [PATCH] ethdev: add HIGIG2 key field to flow API

> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, October 15, 2019 10:17 PM > To: Kiran Kumar Kokkilagadda > Cc: Adrien Mazarguil ; John McNamara > ; Marko Kovacevic ; > Thomas Monjalon ; Ferruh Yigit > ; Andrew Rybchenko ; > dev@dpdk.org; ajit.khapa...@broadcom.com > Sub

Re: [dpdk-dev] [PATCH v2 0/2] net/ice: protocol extraction related issues

On 10/14, Haiyue Wang wrote: >v1 -> v2: > Split into two patches, one is fixing a commit > >Haiyue Wang (2): > net/ice: fix the missed memory free when dev is closed > net/ice: avoid the parsed devargs value being overwritten > > drivers/net/ice/ice_ethdev.c | 44 +--

Re: [dpdk-dev] [PATCH v4 5/5] net/ice: rework switch filter

Hi, Xiaolong I will fix the coding style warning and send v5. Thanks -Ying > -Original Message- > From: Ye, Xiaolong > Sent: Wednesday, October 16, 2019 10:55 AM > To: Wang, Ying A > Cc: Zhang, Qi Z ; dev@dpdk.org; Yang, Qiming > ; Zhao1, Wei > Subject: Re: [PATCH v4 5/5] net/ice: rewo

Re: [dpdk-dev] [PATCH v4 5/5] net/ice: rework switch filter

Hi, Could you check below warning in patchwork? http://mails.dpdk.org/archives/test-report/2019-October/102523.html Thanks, Xiaolong On 10/14, Ying Wang wrote: >From: wei zhao > >The patch reworks packet process engine's binary classifier >(switch) for the new framework. It also adds support

[dpdk-dev] [PATCH v2] eal/ppc: fix 64 bit atomic exchange operation

The rte_atomic64_exchange operation for ppc_64 incorrectly linked back to a 32 bit generic operation (__atomic_exchange_4) rather than the 64 bit generic operation (__atomic_exchange_8). As a result, applications that used rte_eth_link_get_nowait() would only receive the link speed, they would not

[dpdk-dev] [dpdk-announce] Live! Agenda for DPDK Summit NA 2019

Hi Folks, The final agenda for the upcoming DPDK Summit NA, November 12-13 in Mountain View, CA, is now live: https://events19.linuxfoundation.org/events/dpdknorthamerica2019/program/schedule/ Registration is also live,

Re: [dpdk-dev] [PATCH] eal: fix link status issue on ppc_64

The rte_atomic64_exchange operation for ppc_64 incorrectly linked back to a 32 bit generic operation (__atomic_exchange_4) rather than the 64 bit generic operation (__atomic_exchange_8). As a result, only the link speed was passed to the application, not the link state, link duplex, on link au

Re: [dpdk-dev] [PATCH] doc: remove deprecated ethdev features

On Tue, Oct 15, 2019 at 9:19 AM Jerin Jacob wrote: > On Tue, Oct 15, 2019 at 9:26 PM Ferruh Yigit > wrote: > > > > On 10/15/2019 3:16 PM, Jerin Jacob wrote: > > > @@ -36,13 +36,6 @@ VMDq = > > > SR-IOV = > > > DCB = > > > VLAN

Re: [dpdk-dev] [pull-request] next-eventdev 19.11 PRE-RC1

05/10/2019 15:50, Jerin Jacob Kollanukkaran: > http://dpdk.org/git/next/dpdk-next-eventdev Was pulled on last Saturday. > Note: > - I will be on vacation next week. > - Following are the pending patches in Eventdev tree for 19.11. Based on the > review comments and time the review completes, W

[dpdk-dev] [PATCH v5] vhost: add support for large buffers

The rte_vhost_dequeue_burst supports two ways of dequeuing data. If the data fits into a buffer, then all data is copied and a single linear buffer is returned. Otherwise it allocates additional mbufs and chains them together to return a multiple segments mbuf. While that covers most use cases, it

Re: [dpdk-dev] [PATCH v4] vhost: add support for large buffers

On Tue, 15 Oct 2019 19:41:52 +0200 Ilya Maximets wrote: > Hi. > Not a full review. Few comments inline. > > Best regards, Ilya Maximets. Thanks for reviewing Ilya, see below. [...] > > @@ -870,6 +878,8 @@ rte_vhost_driver_register(const char *path, > > uint64_t flags) goto out_free; > > }

Re: [dpdk-dev] [PATCH v2] service: print errors to rte log

On Wed, Aug 21, 2019 at 11:11 AM Harry van Haaren wrote: > > From: Stephen Hemminger > > EAL should always use rte_log instead of putting errors to > stderr (which maybe redirected to /dev/null in a daemon). > > Also checks for null before rte_free are unnecessary. > Minor code consistency improv

Re: [dpdk-dev] [PATCH v2] eal: unmap undesired address upon config reattach failure

On Mon, Aug 19, 2019 at 5:29 PM David Marchand wrote: > > On Mon, Aug 19, 2019 at 3:58 PM Arnon Warshavsky wrote: > > > > Have rte_eal_config_reattach clean up the mapped address > > which is a valid address but not the one intended. > > > > Coverity issue: 343439 > > Fixes: 4e8854ae89fa ("eal: d

Re: [dpdk-dev] [PATCH] vfio: free mp_reply msgs in failure cases

On Mon, Oct 14, 2019 at 4:47 PM David Marchand wrote: > > On Mon, Oct 14, 2019 at 3:49 PM Harris, James R > wrote: > > On 10/14/19, 4:18 AM, "David Marchand" wrote: > > > > On Fri, Aug 16, 2019 at 9:19 PM Jim Harris > > wrote: > > > > > > The code checks both rte_mp_request_sync()

Re: [dpdk-dev] [PATCH v2 1/3] lib/ethdev: add ethdev op to get hash index

> -Original Message- > From: dev On Behalf Of Ferruh Yigit > Sent: Tuesday, October 15, 2019 10:17 PM > To: Vamsi Krishna Attunuru ; dev@dpdk.org > Cc: arybche...@solarflare.com; Jerin Jacob Kollanukkaran > ; tho...@monjalon.net > Subject: Re: [dpdk-dev] [PATCH v2 1/3] lib/ethdev: add et

Re: [dpdk-dev] [dpdk-stable] 18.11.3 (LTS) patches review and test

On 15/10/2019 18:12, Abhishek Marathe wrote: > Hi Kevin, > > We tried reverting all netvsc and failsafe patches, still we got the same > results. We are still looking into it. > "PERF-DPDK-MULTICORE-PPS-F32" testcase failed because of performance is lower > than threshold. > Following performanc

Re: [dpdk-dev] [PATCH v2 1/1] doc: document new compress perf option

> -Original Message- > From: Dybkowski, AdamX > Sent: Tuesday, October 15, 2019 3:10 PM > To: dev@dpdk.org; Trahe, Fiona > Cc: Dybkowski, AdamX > Subject: [PATCH v2 1/1] doc: document new compress perf option > > This patch documents the new compress perf tool > option --external-mbuf

Re: [dpdk-dev] [PATCH v5] net/memif: zero-copy slave

On 10/4/2019 2:23 PM, Ferruh Yigit wrote: > On 8/22/2019 9:18 AM, Jakub Grajciar wrote: >> Zero-copy slave support for memif PMD. >> Slave interface exposes DPDK memory to >> master interface. Only single file segments >> are supported (EAL option --single-file-segments). >> >> Signed-off-by: Jakub

Re: [dpdk-dev] [PATCH v1 1/5] lib/eal: implement the family of rte bit operation APIs

On Tue, 15 Oct 2019 15:49:57 +0800 Joyce Kong wrote: > +static inline void > +rte_set_bit(unsigned int nr, unsigned long *addr) > +{ > + __atomic_fetch_or(addr, (1UL << nr), __ATOMIC_ACQ_REL); > +} > + > +static inline void > +rte_clear_bit(int nr, unsigned long *addr) > +{ > + __atomic_f

Re: [dpdk-dev] [PATCH v1 0/5] implement common rte bit operation APIs in PMDs

On Tue, 15 Oct 2019 15:49:56 +0800 Joyce Kong wrote: > There are a lot functions of bit operations scattered in > PMDs, consolidate them into a common API family and applied > in different PMDs to reduce code duplication. > > Joyce Kong (5): > lib/eal: implement the family of rte bit operation

[dpdk-dev] [PATCH v2] cryptodev: fix check related to device id

Each cryptodev are indexed with dev_id in the global rte_crypto_devices variable. nb_devs is incremented / decremented each time a cryptodev is created / deleted. The goal of nb_devs was to prevent the user to get an invalid dev_id. Let's imagine DPDK has configured N cryptodevs. If the cryptodev=

Re: [dpdk-dev] [PATCH v2 2/3] app/test: add hash index verify autotest

On 10/15/2019 10:52 AM, vattun...@marvell.com wrote: > From: Vamsi Attunuru > > Patch adds a autotest to validate rte_eth_dev_rss_hash_index_get() > ethdev op. > > Test configures the ethport in loopback mode and enables RSS for > IP packets. The hash indices returned by those API gets validated

Re: [dpdk-dev] [PATCH v3 2/3] lib/rcu: add resource reclamation APIs

Hi Honnappa, On 13/10/2019 04:02, Honnappa Nagarahalli wrote: Hi Vladimir, Apologies for the delayed response, I had to run few experiments. Hi Honnappa, On 01/10/2019 07:29, Honnappa Nagarahalli wrote: Add resource reclamation APIs to make it simple for applications and libraries

Re: [dpdk-dev] [PATCH] ethdev: add HIGIG2 key field to flow API

On Mon, 14 Oct 2019 09:59:56 +0530 wrote: > +/** > + * RTE_FLOW_ITEM_TYPE_HIGIG2 > + * Matches higig2 header. > + */ > +struct rte_higig2_frc { > + uint32_t ksop:8; > + uint32_t resv:3; > + uint32_t mcst:1; > + uint32_t tc:4; > + uint32_t dst_modid:8; > + uint32_t dst_pid:

Re: [dpdk-dev] [PATCH v2 1/3] lib/ethdev: add ethdev op to get hash index

On 10/15/2019 10:52 AM, vattun...@marvell.com wrote: > From: Vamsi Attunuru > > Some networking devices may use custom algos for computing > hash indices and spread the packets accordingly. > > Patch adds an eth_dev op to get the hash index correspond > to the given hash value received in the in

Re: [dpdk-dev] [BUG] service_lcore_en_dis_able from service_autotest failing

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Van Haaren, Harry > Sent: Monday, October 14, 2019 5:49 PM > To: Aaron Conole > Cc: David Marchand ; dev@dpdk.org > Subject: Re: [dpdk-dev] [BUG] service_lcore_en_dis_able from service_autotest > failing > > > ---

Re: [dpdk-dev] [dpdk-stable] 18.11.3 (LTS) patches review and test

On 11/10/2019 22:19, Kevin Traynor wrote: > On 11/10/2019 17:33, Ju-Hyoung Lee wrote: >> Is there any other partners have done DPDK performance test with different >> OS distro? > > There was a few other perf testings reported elsewhere in reply to this > thread and there wasn't other perf drop r

Re: [dpdk-dev] [PATCH] doc: remove deprecated ethdev features

On Tue, Oct 15, 2019 at 9:26 PM Ferruh Yigit wrote: > > On 10/15/2019 3:16 PM, Jerin Jacob wrote: > > @@ -36,13 +36,6 @@ VMDq = > > SR-IOV = > > DCB = > > VLAN filter = > > -Ethertype filter = > > -N-tuple fi

[dpdk-dev] [PATCH v4] vhost: add support for large buffers

The rte_vhost_dequeue_burst supports two ways of dequeuing data. If the data fits into a buffer, then all data is copied and a single linear buffer is returned. Otherwise it allocates additional mbufs and chains them together to return a multiple segments mbuf. While that covers most use cases, it

Re: [dpdk-dev] [PATCH 2/2] sched: modify internal structs and functions for 64 bit values

> -Original Message- > From: Dumitrescu, Cristian > Sent: Tuesday, October 15, 2019 4:47 PM > To: Singh, Jasvinder ; dev@dpdk.org > Cc: Krakowiak, LukaszX > Subject: RE: [PATCH 2/2] sched: modify internal structs and functions for 64 > bit > values > > Hi Jasvinder, > > > -Origin

Re: [dpdk-dev] [PATCH] doc: remove deprecated ethdev features

On 10/15/2019 3:16 PM, Jerin Jacob wrote: > @@ -36,13 +36,6 @@ VMDq = > SR-IOV = > DCB = > VLAN filter = > -Ethertype filter = > -N-tuple filter = > -SYN filter = > -Tunnel filter

Re: [dpdk-dev] testpmd / SR-IOV RX packets, but TX-errors

Thank you for the suggestion Lance, but that didn't correct the problem. That being said, I would think that testpmd in "io" mode would just forward the packets in the SR-IOV case just as it successfully does with testpmd across the PFs (non SR-IOV) - but I could be wrong. On Tue, Oct 15, 2019 at

Re: [dpdk-dev] [PATCH 2/2] sched: modify internal structs and functions for 64 bit values

Hi Jasvinder, > -Original Message- > From: Singh, Jasvinder > Sent: Monday, October 14, 2019 6:25 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Krakowiak, > LukaszX > Subject: [PATCH 2/2] sched: modify internal structs and functions for 64 bit > values > > Modify internal structure

Re: [dpdk-dev] [PATCH v10 4/5] kni: add IOVA=VA support in KNI module

On Tue, 15 Oct 2019 16:43:08 +0100 "Yigit, Ferruh" wrote: > On 8/16/2019 7:12 AM, vattun...@marvell.com wrote: > > From: Kiran Kumar K > > > > Patch adds support for kernel module to work in IOVA = VA mode, > > the idea is to get physical address from IOVA address using > > iommu_iova_to_phys A

Re: [dpdk-dev] [PATCH v10 4/5] kni: add IOVA=VA support in KNI module

On 8/16/2019 7:12 AM, vattun...@marvell.com wrote: > From: Kiran Kumar K > > Patch adds support for kernel module to work in IOVA = VA mode, > the idea is to get physical address from IOVA address using > iommu_iova_to_phys API and later use phys_to_virt API to > convert the physical address to k

Re: [dpdk-dev] [PATCH v10 3/5] kni: add app specific mempool create and free routines

On 8/16/2019 7:12 AM, vattun...@marvell.com wrote: > From: Vamsi Attunuru > > When KNI operates in IOVA = VA mode, it requires mbuf memory > to be physically contiguous to ensure KNI kernel module could > translate IOVA addresses properly. Patch adds a KNI specific > mempool create routine to pop

Re: [dpdk-dev] [PATCH v10 2/5] kni: add IOVA=VA support in KNI lib

On 8/16/2019 7:12 AM, vattun...@marvell.com wrote: > From: Vamsi Attunuru > > Current KNI implementation only operates in IOVA=PA mode, patch adds > required functionality in KNI lib to support IOVA=VA mode. > > KNI kernel module requires device info to get iommu domain related > information for

Re: [dpdk-dev] [PATCH v10 0/5] kni: add IOVA=VA support

On 8/16/2019 7:12 AM, vattun...@marvell.com wrote: > From: Vamsi Attunuru > > --- > V10 Changes: > * Fixed function return code on failure when min_chunk_size > pg_sz. > * Marked new mempool populate routine as EXPERIMENTAL. > > V9 Changes: > * Used rte_mempool_ops_calc_mem_size() instead of def

Re: [dpdk-dev] [PATCH 1/2] sched: add support for 64 bit values

> -Original Message- > From: Singh, Jasvinder > Sent: Monday, October 14, 2019 6:25 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Krakowiak, > LukaszX > Subject: [PATCH 1/2] sched: add support for 64 bit values > > To support high bandwidth NICs, all rates (port, subport level > t

Re: [dpdk-dev] [PATCH v6 2/4] doc: changes to abi policy introducing major abi versions

Hello, On Fri, Sep 27, 2019 at 6:55 PM Ray Kinsella wrote: > > This policy change introduces major ABI versions, these are > declared every year, typically aligned with the LTS release > and are supported by subsequent releases in the following year. > This change is intended to improve ABI stabi

[dpdk-dev] [PATCH v14 3/3] app/testpmd: add RSS offload types extending support

This patch adds cmdline support for extended rss types configuration. Signed-off-by: Simei Su Reviewed-by: Qi Zhang --- app/test-pmd/cmdline.c | 14 -- app/test-pmd/config.c | 4 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test

[dpdk-dev] [PATCH v14 2/3] ethdev: extend RSS offload types

This patch reserves several bits as input set selection from the high end of the 64 bits. It is combined with exisiting ETH_RSS_* to represent RSS types. This patch also checks the simultaneous use of SRC_ONLY and DST_ONLY of the same level. Signed-off-by: Simei Su Reviewed-by: Qi Zhang Acked-by

[dpdk-dev] [PATCH v14 1/3] ethdev: decouple flow types and RSS offload types

This patch decouples RTE_ETH_FLOW_* and ETH_RSS_*. The former defines flow types and the latter defines RSS offload types. Signed-off-by: Simei Su Reviewed-by: Qi Zhang Acked-by: Ori Kam Acked-by: Andrew Rybchenko --- lib/librte_ethdev/rte_ethdev.h | 51 ---

[dpdk-dev] [PATCH v14 0/3] extend RSS offload types

[PATCH v14 1/3] ethdev: decouple flow types and RSS offload types. [PATCH v14 2/3] ethdev: add several bits for extending rss offload types. [PATCH v14 3/3] app/testpmd: add cmdline support for extending rss types. v14: * Adjust the location of the inline function. v13: * Define an inline functio

Re: [dpdk-dev] [PATCH] net/mlx5: fix build with strict alignment enabled

> -Original Message- > From: Ali Alnubani > Sent: Tuesday, October 15, 2019 17:56 > To: dev@dpdk.org > Cc: Slava Ovsiienko ; Jeremy Plsek > > Subject: [PATCH] net/mlx5: fix build with strict alignment enabled > > This patch converts some of the casts to unaligned integer types. > > This

Re: [dpdk-dev] [PATCH v2 0/3] examples/ipsec-secgw: set default

> > > > > > 11/10/2019 14:40, Akhil Goyal: > > > > Hi All, > > > > > > > > This patchset would need ack from more vendors as it will impact > > > > user > > > experience > > > > on a key example application which is normally demonstrated to > > customers. > > > > > > > > IPSec library is still e

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

> > > > Hi Akhil, > > > > Thanks for the review and comments! > > Knowing you are extremely busy. Here is my point in brief: > > I think placing the CPU synchronous crypto in the rte_security make sense, > > as > > > > 1. rte_security contains inline crypto and lookaside crypto action type >

Re: [dpdk-dev] [PATCH v13 2/3] ethdev: extend RSS offload types

> -Original Message- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Tuesday, October 15, 2019 9:08 PM > To: Su, Simei ; Zhang, Qi Z ; Ye, > Xiaolong ; Yigit, Ferruh > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v13 2/3] ethdev: extend RSS offload types > > On

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

Hi Fan, > > Hi Akhil, > > Thanks for the review and comments! > Knowing you are extremely busy. Here is my point in brief: > I think placing the CPU synchronous crypto in the rte_security make sense, as > > 1. rte_security contains inline crypto and lookaside crypto action type > already, > ad

[dpdk-dev] [PATCH] net/mlx5: fix build with strict alignment enabled

This patch converts some of the casts to unaligned integer types. This fixes the following error, which is seen on x86, with gcc 7.4.0: drivers/net/mlx5/mlx5_rxtx.c: In function ‘mlx5_tx_dseg_iptr’: drivers/net/mlx5/mlx5_rxtx.c:2740:9: error: passing argument 1 of ‘memcpy’ makes pointer from inte

Re: [dpdk-dev] [PATCH] cryptodev: fix invalid dev_id after a pmd close

Hi On 15/10/2019 15:44, Akhil Goyal wrote: > >> >> Hi Julien >> >>> >>> Each cryptodev are indexed with its dev_id in the global >>> rte_crypto_devices variable. nb_devs is incremented / decremented each >>> time a cryptodev is created / deleted. The goal of nb_devs is to prevent >>> the user to

Re: [dpdk-dev] [PATCH v6 2/4] examples/ipsec-secgw: add fallback session feature

Hi Konstantin, > > Hi Akhil, > > > > > > > Inline processing is limited to a specified subset of traffic. It is > > > often unable to handle more complicated situations, such as fragmented > > > traffic. When using inline processing such traffic is dropped. > > > > > > Introduce fallback session

Re: [dpdk-dev] [PATCH] net/octeontx2: add Rx/Tx burst mode get callbacks

On Mon, Sep 30, 2019 at 12:29 PM Sunil Kumar Kori wrote: > > Retrieve burst mode options according to the selected Rx/Tx burst > function. > > Signed-off-by: Sunil Kumar Kori > --- > > Below implementation is based on following patchset > http://patches.dpdk.org/patch/59907/ Depend patch got mer

Re: [dpdk-dev] testpmd / SR-IOV RX packets, but TX-errors

Hi Bill, This is just a guess, but perhaps the transmit drops are due to MAC anti-spoofing checks? You could probably prove/disprove by making the packet source MAC match the transmit VF's MAC. Lance On Tue, Oct 15, 2019 at 10:01 AM Bill Michalowski wrote: > > I'm trying run testpmd with

Re: [dpdk-dev] [PATCH] doc: remove deprecated ethdev features

> >>> @@ -36,13 +36,6 @@ VMDq = > >>> SR-IOV = > >>> DCB = > >>> VLAN filter = > >>> -Ethertype filter = > >>> -N-tuple filter = > >>> -SYN filter = > >>> -Tunnel filter= > >>> -Flexible filter = > >>> -H

[dpdk-dev] [PATCH v2 1/1] doc: document new compress perf option

This patch documents the new compress perf tool option --external-mbufs. Signed-off-by: Adam Dybkowski --- doc/guides/rel_notes/release_19_11.rst | 5 + doc/guides/tools/comp_perf.rst | 2 ++ 2 files changed, 7 insertions(+) diff --git a/doc/guides/rel_notes/release_19_11.rst b/doc

[dpdk-dev] [PATCH v2 0/1] doc: document new compress perf option

This patch documents the new compress perf tool option --external-mbufs. --- v2: * Fix the indentation in comp_perf.rst file. Adam Dybkowski (1): doc: document new compress perf option doc/guides/rel_notes/release_19_11.rst | 5 + doc/guides/tools/comp_perf.rst | 2 ++ 2 files chan

Re: [dpdk-dev] Testpmd parameter --enable-lro fails on Mellanox ConnectX5

Hello Georgios, Thanks for your mail! We'll have a deeper look internally and will contact you about our results. Regards, Asaf Penso > -Original Message- > From: dev On Behalf Of Georgios Katsikas > Sent: Tuesday, October 15, 2019 9:06 AM > To: dev@dpdk.org > Cc: Tom Barbette > Subjec

Re: [dpdk-dev] [PATCH v3 0/3] support ECB for AES and TDES

> > > -Original Message- > > > From: michae...@marvell.com > > > Sent: Tuesday, October 1, 2019 4:53 PM > > > To: Akhil Goyal > > > Cc: dev@dpdk.org; marko.kovace...@intel.com; lir...@marvell.com; > > > michae...@marvell.com > > > Subject: [PATCH v3 0/3] support ECB for AES and TDES > >

[dpdk-dev] testpmd / SR-IOV RX packets, but TX-errors

I'm trying run testpmd with SR-IOV, specifically across two VFs. I see packets being received successfully by the application but they are not being transmitted. They are dropped with the 'TX-errors' counters incrementing. However, if I generate the same traffic and the DUT isn't programmed with

Re: [dpdk-dev] [PATCH v3 3/3] examples/fips_validation: separate ECB and CBC

Subject: [PATCH v3 3/3] examples/fips_validation: separate ECB and CBC From: Michael Shamis Separate initialization of IV, PT and CT according to TDES ECB and CBC crypto modes Signed-off-by: Michael Shamis --- examples/fips_validation/main.c | 66 + 1 file cha

Re: [dpdk-dev] [PATCH v2 1/2] examples/ipsec-secgw: fix SAD selection logic

> > Ok, so to confirm: > Your only issue here is that patch is that we have to split ipsec-secgw SADB > into > two? > > No objections to other part: > - search for given SPI value across both SPDs (IPv4 and IPv6) > - for each positive result create a new SA. > So if we have same SPI in both IPv

Re: [dpdk-dev] [PATCH v3 2/3] examples/fips_validation: add AES ECB support

Subject: [PATCH v3 2/3] examples/fips_validation: add AES ECB support From: Michael Shamis Signed-off-by: Michael Shamis --- .../fips_validation/fips_validation_aes.c | 1 + examples/fips_validation/main.c | 96 +-- 2 files changed, 91 insertions(+), 6 dele

Re: [dpdk-dev] [PATCH v3 1/3] examples/fips_validation: add TDES ECB support

Subject: [PATCH v3 1/3] examples/fips_validation: add TDES ECB support From: Michael Shamis Signed-off-by: Michael Shamis --- examples/fips_validation/fips_validation.c| 1 + examples/fips_validation/fips_validation.h| 7 + .../fips_validation/fips_validation_tdes.c| 7 +

[dpdk-dev] [PATCH v2] maintainers: claim maintainership of ptpclient example app

Claim maintainership of examples/ptpclient/ Signed-off-by: Kirill Rybalchenko --- v2 changes: * Fixed typo --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index f8a56e2..0c896ab 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1495,6 +1495,7 @@ M: John

Re: [dpdk-dev] [PATCH] cryptodev: fix invalid dev_id after a pmd close

> > Hi Julien > > > > > Each cryptodev are indexed with its dev_id in the global > > rte_crypto_devices variable. nb_devs is incremented / decremented each > > time a cryptodev is created / deleted. The goal of nb_devs is to prevent > > the user to get an invalid dev_id. > > > > Let's imagine D

Re: [dpdk-dev] [PATCH] crypto/qat: fix null auth issues when using vfio_pci

Hi Fiona, Could you please Ack the following change. Thanks, Akhil > -Original Message- > From: Damian Nowak > Sent: Friday, August 9, 2019 2:59 PM > To: dev@dpdk.org > Cc: Akhil Goyal ; fiona.tr...@intel.com; > arkadiuszx.kusz...@intel.com; Damian Nowak > Subject: [PATCH] crypto/qat:

Re: [dpdk-dev] [PATCH v3 0/3] support ECB for AES and TDES

Hi Marko, A kind reminder. We are approaching RC1 date. Could you please review this series? Regards, Akhil > -Original Message- > From: Akhil Goyal > Sent: Friday, October 4, 2019 4:04 PM > To: marko.kovace...@intel.com > Cc: dev@dpdk.org; lir...@marvell.com; michae...@marvell.com > Subj

[dpdk-dev] [PATCH v2 7/7] examples/server_node_efd: add server binary to meson build

Signed-off-by: Bruce Richardson --- examples/meson.build| 1 + examples/server_node_efd/server/meson.build | 13 + 2 files changed, 14 insertions(+) create mode 100644 examples/server_node_efd/server/meson.build diff --git a/examples/meson.build b/examples/m

[dpdk-dev] [PATCH v2 4/7] examples/performance-thread: add l3fwd-thread to meson

Limited to x86_64 systems, as it fails to compile on any others and is disabled in the examples makefile for non-x86_64 systems. Signed-off-by: Bruce Richardson --- examples/meson.build | 3 ++- .../l3fwd-thread/meson.build | 27 +++ exa

[dpdk-dev] [PATCH v2 5/7] examples/performance-thread: add pthread shim to meson

Signed-off-by: Bruce Richardson --- examples/meson.build | 1 + .../pthread_shim/meson.build | 28 +++ 2 files changed, 29 insertions(+) create mode 100644 examples/performance-thread/pthread_shim/meson.build diff --git a/examples/meson

[dpdk-dev] [PATCH v2 6/7] examples/server_node_efd: add node binary to meson build

Signed-off-by: Bruce Richardson --- examples/meson.build| 3 ++- examples/server_node_efd/{ => node}/meson.build | 9 ++--- 2 files changed, 8 insertions(+), 4 deletions(-) rename examples/server_node_efd/{ => node}/meson.build (60%) diff --git a/examples/meson.b

[dpdk-dev] [PATCH v2 3/7] examples/performance-thread: remove warning disabling

The warnings about functions not returning values can be removed from the code by just adding an attribute to the function to specifies it doesn't return. The GCC bug referenced in the makefile which prevents this from working has been fixed for >10 years according to bugzilla. Signed-off-by: Bruc

[dpdk-dev] [PATCH v2 0/7] support all examples in a meson build

When build with meson, some examples were skipped when "-Dexamples=all" parameter was passed. Ignoring examples slated for removal by other patches[1], this set adds support for building the rest of the examples. The only exception is "bpf" which is a set of code snippets rather than code to be nat

[dpdk-dev] [PATCH v2 2/7] examples/ethtool: allow building as part of meson build

Since the code for the ethtool example was contained in subdirectories the compilation of this example is different from most of the other apps, and it had not been abled when the user requests a build with "-Dexamples=all". To simplify the build with meson, the separate ethtool library is not bui

[dpdk-dev] [PATCH v2 1/7] examples/bpf: remove from list of examples to build

The examples/bpf directory does not contain an example app, but rather example code for use with testpmd's BPF support. Therefore, we should not attempt to build it when the user requests "examples=all". This also synchronises the meson behaviour with make which similarly doesn't compile up the cod

Re: [dpdk-dev] [PATCH v2 0/5] add asym support in crypto_octeontx PMD

> > Hi Anoob, > > I believe this should also be updated in the release notes. > If yes, please reply to this mail with appropriate description. > I will update it while merging. > Please send the release note update. I will squash the change with this patchset. Applied to dpdk-next-crypto T

Re: [dpdk-dev] [PATCH v2 00/10] NXP DPAAx crypto fixes

> > > > > > > > > > This patch series largely content > > > 1. fixes in crypto drivers > > > 2. supprot ESN like cases > > > 3. enabling snow/ZUC for dpaa_sec > > > > > > v2: fix the clang compilation errors in 10/10 > > > > > > Hemant Agrawal (7): > > > test/crypto: fix PDCP test support >

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] app/testpmd: fix CRC strip command failure

On 10/15/2019 10:40 AM, Iremonger, Bernard wrote: >> -Original Message- >> From: Xu, Ting >> Sent: Tuesday, October 15, 2019 10:14 AM >> To: dev@dpdk.org >> Cc: Lu, Wenzhuo ; Wu, Jingjing >> ; Iremonger, Bernard >> ; Mcnamara, John >> ; Kovacevic, Marko >> ; sta...@dpdk.org >> Subject: [PAT

Re: [dpdk-dev] [PATCH v2 00/17] Introduces net/ionic PMD

On 10/15/2019 9:22 AM, Alfredo Cardigliano wrote: > The patch series provides an initial version of a > poll mode driver for Pensando network adapters. > The driver name is ionic. > > v2 Changes: > -- > - Fix checkpatch warnings > - Remove unused log macros > - Remove -Wno-deprecated-decl

Re: [dpdk-dev] [PATCH v13 2/3] ethdev: extend RSS offload types

On 10/15/19 3:56 PM, Simei Su wrote: This patch reserves several bits as input set selection from the high end of the 64 bits. It is combined with exisiting ETH_RSS_* to represent RSS types. This patch also checks the simultaneous use of SRC_ONLY and DST_ONLY of the same level. Signed-off-by: Si

  1   2   3   >