Hi Akhil, Marvell is NOT OK with this change in this cycle. The library is still emerging and the boundary between ipsec-secgw and lib ipsec still hasn't emerged clearly. Moreover, lib_ipsec mode isn't even working with the default conf (I believe the fix for this still in discussion. The issue was reported by a Marvell engineer some time back). There are questionable features getting pushed, for which Marvell's concerns were subdued.
I would expect this taken up after lib ipsec is found stable for atleast one release cycle. As for the performance, we found 2-3% drop with the lib ipsec in the last release (lookaside crypto mode). Yet to try out with latest codebase. With some of the recent submissions, I expect an even higher performance hit. Also, eventmode ipsec-secgw (already submitted RFC) is using non lib ipsec mode. We don't have plans to move that to lib ipsec mode until lib ipsec is made stable. Thanks, Anoob > -----Original Message----- > From: Akhil Goyal <akhil.go...@nxp.com> > Sent: Friday, October 11, 2019 6:10 PM > To: Bernard Iremonger <bernard.iremon...@intel.com>; dev@dpdk.org; > konstantin.anan...@intel.com; Anoob Joseph <ano...@marvell.com>; > Jerin Jacob Kollanukkaran <jer...@marvell.com>; 'Thomas Monjalon' > <tho...@monjalon.net> > Subject: [EXT] RE: [PATCH v2 0/3] examples/ipsec-secgw: set default > > External Email > > ---------------------------------------------------------------------- > Hi All, > > This patchset would need ack from more vendors as it will impact user > experience on a key example application which is normally demonstrated to > customers. > > IPSec library is still evolving and there are new functionality added every > release. > Atleast from NXP side we are not OK with this change. > > I would hold this patch till RC2 atleast. > > Regards, > Akhil > > > -----Original Message----- > > From: Bernard Iremonger <bernard.iremon...@intel.com> > > Sent: Tuesday, October 1, 2019 8:48 PM > > To: dev@dpdk.org; konstantin.anan...@intel.com; Akhil Goyal > > <akhil.go...@nxp.com> > > Cc: Bernard Iremonger <bernard.iremon...@intel.com> > > Subject: [PATCH v2 0/3] examples/ipsec-secgw: set default > > > > This patch set, sets the default code path in the ipsec-secgw > > application to use the librte_ipsec. > > The *_old test scripts have been modified to use the legacy code path. > > > > Changes in v2: > > ------------- > > The error messages for the -l option have been updated. > > The pktest.sh script has been updated to drop the -l option. > > > > Bernard Iremonger (3): > > examples/ipsec-secgw: set default to IPsec library mode > > examples/ipsec-secgw: add -l 0 parameter to old scripts > > examples/ipsec-secgw: update pktest.sh script > > > > doc/guides/rel_notes/release_19_11.rst | 8 ++++ > > doc/guides/sample_app_ug/ipsec_secgw.rst | 6 ++- > > examples/ipsec-secgw/ipsec-secgw.c | 46 > > ++++++++++++++------- > - > > examples/ipsec-secgw/test/pkttest.sh | 1 - > > .../ipsec-secgw/test/trs_3descbc_sha1_old_defs.sh | 2 +- > > .../ipsec-secgw/test/trs_aescbc_sha1_old_defs.sh | 2 +- > > .../ipsec-secgw/test/trs_aesctr_sha1_old_defs.sh | 2 +- > > .../test/trs_aesgcm_inline_crypto_old_defs.sh | 2 +- > > examples/ipsec-secgw/test/trs_aesgcm_old_defs.sh | 2 +- > > .../ipsec-secgw/test/tun_3descbc_sha1_old_defs.sh | 2 +- > > .../ipsec-secgw/test/tun_aescbc_sha1_old_defs.sh | 2 +- > > .../ipsec-secgw/test/tun_aesctr_sha1_old_defs.sh | 2 +- > > .../test/tun_aesgcm_inline_crypto_old_defs.sh | 2 +- > > examples/ipsec-secgw/test/tun_aesgcm_old_defs.sh | 2 +- > > 14 files changed, 52 insertions(+), 29 deletions(-) > > > > -- > > 2.7.4
