Re: [dpdk-dev] [PATCH v6 14/15] net/hinic: add Rx/Tx package burst
2019-07-12
Thread
Xuanziyang (William, Chip Application Design Logic and Hardware Development Dept IT_Products & Solutions)
> On 6/27/2019 9:19 AM, Ziyang Xuan wrote: > > This patch add package sending and receiving function codes. > > > > Signed-off-by: Ziyang Xuan > > Hi Ziyang, > > The lgtm.com tool is reporting some errors on this patch, can you please > check: > > https://lgtm.com/projects/g/DPDK/dpdk/snapshot/
[dpdk-dev] [PATCH v3] vfio: fix expanding DMA area in ppc64le
In ppc64le, expanding DMA areas always fail because we cannot remove a DMA window. As a result, we cannot allocate more than one memseg in ppc64le. This is because vfio_spapr_dma_mem_map() doesn't unmap all the mapped DMA before removing the window. This patch fixes this incorrect behavior. I also
Re: [dpdk-dev] [PATCH v1] examples/power: fix FreeBSD meson lib dependency
On Fri, 12 Jul 2019 10:06:51 +0100 David Hunt wrote: > Samples apps that depend on the power library should not build if > the power library is not present. So now the following apps will > check to see if it's built, else skip building. > * l3fwd-pwer > * vm_power_manager > * guest_cli > > Fixe
[dpdk-dev] [PATCH 2/2] net/mlx5: fix crash in dev_info_get in secondary process
mlx5_dev_info_get calls mlx5_get_ifname, but mlx5_get_ifname uses priv->ctx which is not a valid pointer in a secondary process. The fix is to cache the value in primary. In the primary process, get and store the interface index of the device so that secondary process can see it. Fixes: e60fbd5b2
[dpdk-dev] [PATCH 0/2] fix dev_info_get in mlx secondary process
Both drivers had the same problem. Stephen Hemminger (2): net/mlx4: fix crash in dev_info_get in secondary process net/mlx5: fix crash in dev_info_get in secondary process drivers/net/mlx4/mlx4.c| 19 +-- drivers/net/mlx4/mlx4.h| 1 + drivers/net/mlx4/mlx4_et
[dpdk-dev] [PATCH 1/2] net/mlx4: fix crash in dev_info_get in secondary process
mlx4_dev_info_get calls mlx4_get_ifname, but mlx4_get_ifname uses priv->ctx which is not a valid pointer in a secondary process. The fix is to cache the value in primary. In the primary process, get and store the interface index of the device so that secondary process can see it. Bugzilla ID:320
Re: [dpdk-dev] [Bug 320] mlx4: info get fails in secondary process
On Fri, 12 Jul 2019 20:04:26 + bugzi...@dpdk.org wrote: > https://bugs.dpdk.org/show_bug.cgi?id=320 > > Bug ID: 320 >Summary: mlx4: info get fails in secondary process >Product: DPDK >Version: 19.08 > Hardware: All > OS
Re: [dpdk-dev] [PATCH v5 6/6] lib/lpm: data update optimization for v20
Similar to 5/6, this patch can also be merged into 4/6. > -Original Message- > From: Ruifeng Wang > Sent: Thursday, July 11, 2019 10:09 PM > To: vladimir.medved...@intel.com; bruce.richard...@intel.com > Cc: dev@dpdk.org; Honnappa Nagarahalli ; > Gavin Hu (Arm Technology China) ; nd ; > R
Re: [dpdk-dev] [PATCH v5 5/6] lib/lpm: data update optimization for v1604
IMO, this can be merged into 4/6. > -Original Message- > From: Ruifeng Wang > Sent: Thursday, July 11, 2019 10:09 PM > To: vladimir.medved...@intel.com; bruce.richard...@intel.com > Cc: dev@dpdk.org; Honnappa Nagarahalli ; > Gavin Hu (Arm Technology China) ; nd ; > Ruifeng Wang (Arm Techn
[dpdk-dev] [Bug 320] mlx4: info get fails in secondary process
https://bugs.dpdk.org/show_bug.cgi?id=320 Bug ID: 320 Summary: mlx4: info get fails in secondary process Product: DPDK Version: 19.08 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Pr
[dpdk-dev] [PATCH v2] net/ena: Fix admin cq polling for 32-bit apps
Recent modifications to admin command queue polling logic did not support 32-bit applications. Updated the driver to work for 32 or 64 bit applications Fixes: 3adcba9a89 ("net/ena: update HAL to the newer version") Signed-off-by: David Harton --- v2: Leave existing timeout method and only arch
Re: [dpdk-dev] [PATCH v6 0/9] kni: fixes and cleanups
On 6/24/2019 5:47 PM, Stephen Hemminger wrote: > While testing KNI with netvsc, saw lots of places more code > could be safely removed from KNI kernel driver. > > v6 - more updates to documentation > v5 - add minimal ethtool, fix checkpath author complaints > v4 - add more style fixes > v3 - rebas
Re: [dpdk-dev] [PATCH] config: fix meson build failure on ThunderX2
> > > > Since gcc-8.3(I tried 8.3 and 9.1), the meson build failed on ThunderX2. > > It got the following compiling errors: > > /usr/lib/gcc/aarch64-linux-gnu/9/include/arm_neon.h:26493:1: error: > > inlining failed in call to always_inline ‘vmull_p64’: target specific > > option mismatch 26493 | v
[dpdk-dev] ConnectX-4/mlx5 crashes around rxq_cqe_comp_en?
Hi, I get a crash when I put a significant amount of load on ConnectX-4/mlx5, i.e., 50Gbps for 100GbE port. Thread 22 "lcore-slave-19" received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7fffe77ee700 (LWP 33519)] 0x55f010a3 in _mm_storeu_si128 (__B=..., __P=0x10) at
Re: [dpdk-dev] [EXT] Re: [PATCH v6 4/4] kernel/linux/kni: add IOVA support in kni module
> -Original Message- > From: Ferruh Yigit > Sent: Friday, July 12, 2019 4:40 PM > To: Vamsi Krishna Attunuru ; dev@dpdk.org > Cc: olivier.m...@6wind.com; arybche...@solarflare.com; Kiran Kumar > Kokkilagadda > Subject: Re: [EXT] Re: [PATCH v6 4/4] kernel/linux/kni: add IOVA support in >
Re: [dpdk-dev] [PATCH] net/af_xdp: fix xdp_get_channels_info return value
On 7/12/2019 4:48 PM, Stephen Hemminger wrote: > On Fri, 12 Jul 2019 16:35:55 +0100 > Ferruh Yigit wrote: > >> On 7/12/2019 4:10 PM, Stephen Hemminger wrote: >>> On Fri, 12 Jul 2019 09:55:46 +0200 >>> Július Milan wrote: >>> Procedure xdp_get_channels_info was returning error code -1 in
[dpdk-dev] [Bug 282] Fix missing headers in FreeBSD CURRENT build
https://bugs.dpdk.org/show_bug.cgi?id=282 Conrad Meyer (c...@freebsd.org) changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRM
[dpdk-dev] [PATCH] test: make multiprocess launch error more informative
Currently, if there is no procfs mounted, test application will fail to run any multiprocess-related autotests (EAL flags etc.) without a clear explanation as to why this happens. Add a check specifically for that condition, as well as add a general stringified error message to rte_panic. Signed-
Re: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the ring when not in use
> -Original Message- > From: Honnappa Nagarahalli > Sent: Friday, July 12, 2019 11:41 PM > To: Gavin Hu (Arm Technology China) ; Olivier Matz > > Cc: tho...@monjalon.net; dev@dpdk.org; nd ; > jer...@marvell.com; hemant.agra...@nxp.com; nipun.gu...@nxp.com; > i.maxim...@samsung.com; sta...
[dpdk-dev] [PATCH v9 2/2] hash: flush the rings instead of dequeuing one by one
Within rte_hash_reset, calling a while loop to dequeue one by one from the ring, while not using them at all, is wasting cycles, The patch just flush the ring by resetting the indices can save cpu cycles. Fixes: b26473ff8f4a ("hash: add reset function") Fixes: 75706568a7eb ("hash: add extendable b
[dpdk-dev] [PATCH v9 0/2] new ring reset api and use it by hash
V2: - fix the coding style issue(commit message line too long) V3: - allow experimental API for meson build V4: - include the ring perf test case enhancement patch in the series. - replace ARRAY_SIZE with RTE_DIM. - call memset to avoid clang compling complains. V5: - commit message tweaking for r
[dpdk-dev] [PATCH v9 1/2] ring: add reset API to flush the ring when not in use
Currently, the flush is done by dequeuing the ring in a while loop. It is much simpler to flush the queue by resetting the head and tail indices. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Gavin Hu Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli
Re: [dpdk-dev] [PATCH] net/af_xdp: fix xdp_get_channels_info return value
On Fri, 12 Jul 2019 16:35:55 +0100 Ferruh Yigit wrote: > On 7/12/2019 4:10 PM, Stephen Hemminger wrote: > > On Fri, 12 Jul 2019 09:55:46 +0200 > > Július Milan wrote: > > > >> Procedure xdp_get_channels_info was returning error code -1 in case of > >> ioctl command SIOCETHTOOL was not support
Re: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the ring when not in use
> > > > > > > > > > > > 29/03/2019 15:17, Olivier Matz: > > > > > > > Hi, > > > > > > > > > > > > > > On Fri, Mar 15, 2019 at 11:31:25AM +0800, Gavin Hu wrote: > > > > > > > > Currently, the flush is done by dequeuing the ring in a while > > > > > > > > loop. > > It is > > > > > > > > much simpl
Re: [dpdk-dev] [PATCH] net/af_xdp: fix xdp_get_channels_info return value
On 7/12/2019 4:10 PM, Stephen Hemminger wrote: > On Fri, 12 Jul 2019 09:55:46 +0200 > Július Milan wrote: > >> Procedure xdp_get_channels_info was returning error code -1 in case of >> ioctl command SIOCETHTOOL was not supported. This patch sets return >> value back to 0 as it is valid case. >> >
Re: [dpdk-dev] [PATCH] net/af_xdp: fix xdp_get_channels_info return value
On Fri, 12 Jul 2019 16:01:39 +0100 Ferruh Yigit wrote: > On 7/12/2019 4:43 PM, Ye Xiaolong wrote: > > Hi, > > > > Thanks for the patch. > > > > On 07/12, Július Milan wrote: > >> Procedure xdp_get_channels_info was returning error code -1 in case of > >> ioctl command SIOCETHTOOL was not sup
Re: [dpdk-dev] [PATCH] net/af_xdp: fix xdp_get_channels_info return value
On Fri, 12 Jul 2019 09:55:46 +0200 Július Milan wrote: > Procedure xdp_get_channels_info was returning error code -1 in case of > ioctl command SIOCETHTOOL was not supported. This patch sets return > value back to 0 as it is valid case. > > Fixes: 339b88c6a9 ("net/af_xdp: support multi-queue") >
Re: [dpdk-dev] [PATCH] net/af_xdp: fix xdp_get_channels_info return value
On Fri, 12 Jul 2019 09:40:37 +0200 Július Milan wrote: > diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c > b/drivers/net/af_xdp/rte_eth_af_xdp.c > index ff8e90589..33352e10a 100644 > --- a/drivers/net/af_xdp/rte_eth_af_xdp.c > +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c > @@ -852,9 +852,13 @@ xdp_
Re: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the ring when not in use
Hi Olivier, > -Original Message- > From: Olivier Matz > Sent: Friday, July 12, 2019 7:49 PM > To: Gavin Hu (Arm Technology China) > Cc: tho...@monjalon.net; dev@dpdk.org; nd ; > jer...@marvell.com; hemant.agra...@nxp.com; nipun.gu...@nxp.com; > Honnappa Nagarahalli ; > i.maxim...@samsung
Re: [dpdk-dev] [PATCH 01/15] net/bnxt: fix extended port counter statistics
On Fri, 12 Jul 2019 11:36:08 +0530 Ajit Khaparde wrote: > + snprintf(mz_name, RTE_MEMZONE_NAMESIZE, > + "bnxt_%04x:%02x:%02x:%02x-%s", pci_dev->addr.domain, > + pci_dev->addr.bus, pci_dev->addr.devid, > + pci_dev->addr.function, "rx_port_stats"); You co
Re: [dpdk-dev] [PATCH] net/af_xdp: fix xdp_get_channels_info return value
On 7/12/2019 4:43 PM, Ye Xiaolong wrote: > Hi, > > Thanks for the patch. > > On 07/12, Július Milan wrote: >> Procedure xdp_get_channels_info was returning error code -1 in case of >> ioctl command SIOCETHTOOL was not supported. This patch sets return >> value back to 0 as it is valid case. >> >
Re: [dpdk-dev] [PATCH] eal/bsd: fix config creation
On Fri, Jul 12, 2019 at 03:48:08PM +0100, Anatoly Burakov wrote: > The config create function did not store the mem config address in > the shared memconfig structure, so the secondary processes couldn't > map it at the requred address. > > Fixes: b149a7064261 ("eal/freebsd: add config reattach in
Re: [dpdk-dev] [RFC] mbuf: support dynamic fields and flags
On 10.07.2019 12:29, Olivier Matz wrote: Many features require to store data inside the mbuf. As the room in mbuf structure is limited, it is not possible to have a field for each feature. Also, changing fields in the mbuf structure can break the API or ABI. This commit addresses these issues, b
[dpdk-dev] [PATCH] eal/bsd: fix config creation
The config create function did not store the mem config address in the shared memconfig structure, so the secondary processes couldn't map it at the requred address. Fixes: b149a7064261 ("eal/freebsd: add config reattach in secondary process") Signed-off-by: Anatoly Burakov --- lib/librte_eal/f
Re: [dpdk-dev] [PATCH v1] examples/vm_power: fix strcpy buffer overrun
On Fri, Jul 12, 2019 at 03:04:02PM +0100, David Hunt wrote: > replace strcpy with rte_strlcpy to prevent buffer overrun > With fix, attempting to use a VERY lonng vm name results in a nicely > truncated 32 character name rather than a segfault: > Setting VM Name to [sdfdsfsfsdffdsdsasdsadasdakjshd]
Re: [dpdk-dev] [PATCH v1] examples/vm_power: fix strcpy buffer overrun
On 12-Jul-19 3:04 PM, David Hunt wrote: replace strcpy with rte_strlcpy to prevent buffer overrun With fix, attempting to use a VERY lonng vm name results in a nicely truncated 32 character name rather than a segfault: Setting VM Name to [sdfdsfsfsdffdsdsasdsadasdakjshd] Cc: sta...@dpdk.org Fixe
[dpdk-dev] [PATCH v1] examples/vm_power: fix strcpy buffer overrun
replace strcpy with rte_strlcpy to prevent buffer overrun With fix, attempting to use a VERY lonng vm name results in a nicely truncated 32 character name rather than a segfault: Setting VM Name to [sdfdsfsfsdffdsdsasdsadasdakjshd] Cc: sta...@dpdk.org Fixes: 59287933a0bb ("examples/vm_power: add o
Re: [dpdk-dev] [PATCH] net/tap: fix Rx miss the packets
> On Jul 12, 2019, at 5:20 AM, donald_...@trendmicro.com wrote: > > From: Donald Lee > > > > After pmd_rx_burst be triggered, it doesn't retrieve all the frames. > > It may leave some pending frames there. > > > > Signed-off-by: Donald Lee > > --- > > drivers/net/tap/rte_eth_tap.c |
Re: [dpdk-dev] [PATCH 13/15] net/bnxt: fix a compilation warning
No worries. I will get to it. >From mobile device > On Jul 12, 2019, at 11:36, Ajit Khaparde wrote: > > Compiler complains of an uninitialized variable. > Initializing it to avoid the issue. > > Fixes: db678d5c2b54 ("net/bnxt: add HWRM VNIC configure") > > Signed-off-by: Ajit Khaparde > Reviewe
Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: remove invalid parameter from af_xdp example
On 7/11/2019 11:15 PM, Ye Xiaolong wrote: > On 07/11, David Marchand wrote: >> queue= parameter does not exist. >> It might have been the previous name of the queue_count parameter, but >> anyway, the default value 1 for the number of queues works fine. >> >> Fixes: f1debd77efaf ("net/af_xdp: intro
Re: [dpdk-dev] [PATCH] app/testpmd: fix doubling of 'total TX dropped'
Hi Aideen, > -Original Message- > From: Mcloughlin, Aideen > Sent: Friday, July 12, 2019 9:32 AM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > > Cc: dev@dpdk.org; Mcloughlin, Aideen ; > david.march...@redhat.com; sta...@dpdk.org > Subject: [PATCH] app/testpmd: fix doubling of
Re: [dpdk-dev] [PATCH 2/2] eal: fix IOVA mode selection as VA for pci drivers
On Fri, Jul 12, 2019 at 01:58:46PM +0100, Burakov, Anatoly wrote: > On 12-Jul-19 1:43 PM, Thomas Monjalon wrote: > > If we consider running as root an exception, then it makes > > sense to pick address mode which fits this exception (PA). > > > > When you put it that way, that does indeed make se
Re: [dpdk-dev] [PATCH v1 0/2] add tests for RSA key type CRT
In future we could unify tests even more (i.e. passing padding type as a param, or even information if it is encryption or signature generation) like Fan once done with blockcipher. > -Original Message- > From: Ayuj Verma [mailto:ayve...@marvell.com] > Sent: Thursday, July 11, 2019 3:23
Re: [dpdk-dev] [PATCH 2/2] eal: fix IOVA mode selection as VA for pci drivers
On 12-Jul-19 1:43 PM, Thomas Monjalon wrote: 12/07/2019 13:03, Burakov, Anatoly: On 10-Jul-19 10:48 PM, David Marchand wrote: The incriminated commit broke the use of RTE_PCI_DRV_IOVA_AS_VA which was intended to mean "driver only supports VA" but had been understood as "driver supports both PA
Re: [dpdk-dev] [PATCH 2/2] eal: fix IOVA mode selection as VA for pci drivers
12/07/2019 13:03, Burakov, Anatoly: > On 10-Jul-19 10:48 PM, David Marchand wrote: > > The incriminated commit broke the use of RTE_PCI_DRV_IOVA_AS_VA which > > was intended to mean "driver only supports VA" but had been understood > > as "driver supports both PA and VA" by most net drivers and use
Re: [dpdk-dev] [PATCH v2] common/octeontx2: add CNF95xx SoC support
> -Original Message- > From: Nithin Dabilpuram > Sent: Friday, July 12, 2019 2:56 PM > To: Jerin Jacob Kollanukkaran ; Nithin Kumar > Dabilpuram ; Vamsi Krishna Attunuru > ; John McNamara ; > Marko Kovacevic ; Kiran Kumar Kokkilagadda > > Cc: dev@dpdk.org > Subject: [PATCH v2] common/octe
Re: [dpdk-dev] [EXT] Re: [PATCH v6 0/4] add IOVA = VA support in KNI
> -Original Message- > From: Burakov, Anatoly > Sent: Friday, July 12, 2019 5:40 PM > To: Jerin Jacob Kollanukkaran ; Ferruh Yigit > ; Vamsi Krishna Attunuru > ; dev@dpdk.org > Cc: olivier.m...@6wind.com; arybche...@solarflare.com > Subject: [EXT] Re: [dpdk-dev] [PATCH v6 0/4] add IOVA = V
Re: [dpdk-dev] [EXT] Re: [PATCH v6 4/4] kernel/linux/kni: add IOVA support in kni module
From: Ferruh Yigit Sent: Friday, July 12, 2019 4:40 PM To: Vamsi Krishna Attunuru; dev@dpdk.org Cc: olivier.m...@6wind.com; arybche...@solarflare.com; Kiran Kumar Kokkilagadda Subject: Re: [EXT] Re: [PATCH v6 4/4] kernel/linux/kni: add IOVA support in kni modu
Re: [dpdk-dev] [RFC] mbuf: support dynamic fields and flags
> -Original Message- > From: dev On Behalf Of Olivier Matz > Sent: Thursday, July 11, 2019 1:07 PM > To: Stephen Hemminger > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC] mbuf: support dynamic fields and flags > > On Wed, Jul 10, 2019 at 10:49:17AM -0700, Stephen Hemminger wrote: > >
Re: [dpdk-dev] [PATCH v6 0/4] add IOVA = VA support in KNI
On 12-Jul-19 12:37 PM, Jerin Jacob Kollanukkaran wrote: -Original Message- From: Burakov, Anatoly Sent: Friday, July 12, 2019 4:19 PM To: Jerin Jacob Kollanukkaran ; Ferruh Yigit ; Vamsi Krishna Attunuru ; dev@dpdk.org Cc: olivier.m...@6wind.com; arybche...@solarflare.com Subject: [EXT]
Re: [dpdk-dev] [PATCH 05/15] net/bnxt: reset Rx allocation state on port restart
On Fri, Jul 12, 2019 at 8:06 AM Lance Richardson wrote: > > On Fri, Jul 12, 2019 at 2:06 AM Ajit Khaparde > wrote: > > > > From: Lance Richardson > > > > Move call site of bnxt_rxq_vec_setup() to ensure that rxq->rxrearm_nb > > and rxq->rxrearm_start are reinitialized correctly when a port is >
Re: [dpdk-dev] [PATCH 05/15] net/bnxt: reset Rx allocation state on port restart
On Fri, Jul 12, 2019 at 2:06 AM Ajit Khaparde wrote: > > From: Lance Richardson > > Move call site of bnxt_rxq_vec_setup() to ensure that rxq->rxrearm_nb > and rxq->rxrearm_start are reinitialized correctly when a port is > restarted. > > Fixes: af3ed597e305 ("net/bnxt: initial vector-mode driver
Re: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the ring when not in use
Hi Gavin, On Fri, Jul 12, 2019 at 11:06:28AM +, Gavin Hu (Arm Technology China) wrote: > Hi Olivier, > > > -Original Message- > > From: Olivier Matz > > Sent: Friday, July 12, 2019 5:54 PM > > To: Gavin Hu (Arm Technology China) > > Cc: tho...@monjalon.net; dev@dpdk.org; nd ; > > je
Re: [dpdk-dev] [PATCH v6 0/4] add IOVA = VA support in KNI
> -Original Message- > From: Burakov, Anatoly > Sent: Friday, July 12, 2019 4:19 PM > To: Jerin Jacob Kollanukkaran ; Ferruh Yigit > ; Vamsi Krishna Attunuru > ; dev@dpdk.org > Cc: olivier.m...@6wind.com; arybche...@solarflare.com > Subject: [EXT] Re: [dpdk-dev] [PATCH v6 0/4] add IOVA = V
Re: [dpdk-dev] [PATCH] config: fix meson build failure on ThunderX2
> -Original Message- > From: Gavin Hu > Sent: Friday, July 12, 2019 3:29 PM > To: dev@dpdk.org > Cc: n...@arm.com; tho...@monjalon.net; Jerin Jacob Kollanukkaran > ; Pavan Nikhilesh Bhagavatula > ; honnappa.nagaraha...@arm.com; > gavin...@arm.com; sta...@dpdk.org > Subject: [EXT] [PATCH] c
Re: [dpdk-dev] [EXT] Re: [PATCH v6 2/4] lib/kni: add PCI related information
On 7/12/2019 12:02 PM, Vamsi Krishna Attunuru wrote: > > > > > *From:* dev on behalf of Ferruh Yigit > > *Sent:* Thursday, July 11, 2019 9:52 PM > *To:* Vamsi Krishna Attunuru; dev@dpdk.org > *Cc:* olivier.m...@6w
Re: [dpdk-dev] [EXT] Re: [PATCH v6 4/4] kernel/linux/kni: add IOVA support in kni module
On 7/12/2019 11:38 AM, Vamsi Krishna Attunuru wrote: > > > > > *From:* Ferruh Yigit > *Sent:* Thursday, July 11, 2019 10:00 PM > *To:* Vamsi Krishna Attunuru; dev@dpdk.org > *Cc:* olivier.m...@6wind.com; arybche...
Re: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the ring when not in use
Hi Olivier, > -Original Message- > From: Olivier Matz > Sent: Friday, July 12, 2019 5:54 PM > To: Gavin Hu (Arm Technology China) > Cc: tho...@monjalon.net; dev@dpdk.org; nd ; > jer...@marvell.com; hemant.agra...@nxp.com; nipun.gu...@nxp.com; > Honnappa Nagarahalli ; > i.maxim...@samsung
Re: [dpdk-dev] [PATCH 2/2] eal: fix IOVA mode selection as VA for pci drivers
On 10-Jul-19 10:48 PM, David Marchand wrote: The incriminated commit broke the use of RTE_PCI_DRV_IOVA_AS_VA which was intended to mean "driver only supports VA" but had been understood as "driver supports both PA and VA" by most net drivers and used to let dpdk processes to run as non root (whic
Re: [dpdk-dev] [EXT] Re: [PATCH v6 2/4] lib/kni: add PCI related information
From: dev on behalf of Ferruh Yigit Sent: Thursday, July 11, 2019 9:52 PM To: Vamsi Krishna Attunuru; dev@dpdk.org Cc: olivier.m...@6wind.com; arybche...@solarflare.com Subject: [EXT] Re: [dpdk-dev] [PATCH v6 2/4] lib/kni: add PCI related information Extern
[dpdk-dev] [PATCH v4 1/1] app/test-compress-perf: report header improvement
This patch adds extra features to the compress performance test. Some important parameters (memory allocation, number of ops, number of segments) are calculated and printed out on the screen. Information about compression threads is also provided. Signed-off-by: Artur Trybula --- .../comp_perf_t
[dpdk-dev] [PATCH v4 0/1] add extra features to test-compress-perf
v4 changes: - information about compression threads printed on screen v3 changes: - commented code removed v2 changes: - merged with the series "add multiple cores feature to test-compress-perf" - function renamed: print_report_header() -> print_tes
Re: [dpdk-dev] [PATCH v6 0/4] add IOVA = VA support in KNI
On 12-Jul-19 11:26 AM, Jerin Jacob Kollanukkaran wrote: -Original Message- From: Burakov, Anatoly Sent: Friday, July 12, 2019 3:28 PM To: Jerin Jacob Kollanukkaran ; Ferruh Yigit ; Vamsi Krishna Attunuru ; dev@dpdk.org Cc: olivier.m...@6wind.com; arybche...@solarflare.com Subject: [EXT]
Re: [dpdk-dev] [EXT] Re: [PATCH v6 4/4] kernel/linux/kni: add IOVA support in kni module
From: Ferruh Yigit Sent: Thursday, July 11, 2019 10:00 PM To: Vamsi Krishna Attunuru; dev@dpdk.org Cc: olivier.m...@6wind.com; arybche...@solarflare.com; Kiran Kumar Kokkilagadda Subject: [EXT] Re: [PATCH v6 4/4] kernel/linux/kni: add IOVA support in kni modul
Re: [dpdk-dev] [PATCH v6 0/4] add IOVA = VA support in KNI
> -Original Message- > From: Burakov, Anatoly > Sent: Friday, July 12, 2019 3:28 PM > To: Jerin Jacob Kollanukkaran ; Ferruh Yigit > ; Vamsi Krishna Attunuru > ; dev@dpdk.org > Cc: olivier.m...@6wind.com; arybche...@solarflare.com > Subject: [EXT] Re: [dpdk-dev] [PATCH v6 0/4] add IOVA = V
[dpdk-dev] [PATCH] net/tap: fix Rx miss the packets
From: Donald Lee After pmd_rx_burst be triggered, it doesn't retrieve all the frames. It may leave some pending frames there. Signed-off-by: Donald Lee --- drivers/net/tap/rte_eth_tap.c | 7 ++- drivers/net/tap/rte_eth_tap.h | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) d
[dpdk-dev] [PATCH v3] net/af_packet: add string error for system errors
From: Krzysztof Kanas Print system error to make easier diagnosis of errors with af_packet. Signed-off-by: Krzysztof Kanas --- drivers/net/af_packet/rte_eth_af_packet.c | 53 ++- 1 file changed, 24 insertions(+), 29 deletions(-) diff --git a/drivers/net/af_packet/rte_eth_a
[dpdk-dev] [PATCH] config: fix meson build failure on ThunderX2
Since gcc-8.3(I tried 8.3 and 9.1), the meson build failed on ThunderX2. It got the following compiling errors: /usr/lib/gcc/aarch64-linux-gnu/9/include/arm_neon.h:26493:1: error: inlining failed in call to always_inline ‘vmull_p64’: target specific option mismatch 26493 | vmull_p64 (poly64_t a, po
Re: [dpdk-dev] [PATCH v6 0/4] add IOVA = VA support in KNI
On 12-Jul-19 10:17 AM, Jerin Jacob Kollanukkaran wrote: -Original Message- From: Ferruh Yigit Sent: Thursday, July 11, 2019 9:52 PM To: Jerin Jacob Kollanukkaran ; Vamsi Krishna Attunuru ; dev@dpdk.org Cc: olivier.m...@6wind.com; arybche...@solarflare.com; Burakov, Anatoly Subject: [E
[dpdk-dev] [PATCH v4 11/11] sched: remove redundant macros
Remove unused macros from the library, and update release notes. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- doc/guides/rel_notes/release_19_08.rst | 10 +- lib/librte_sched/rte_sched.h | 10 -- 2 files changed, 9 in
[dpdk-dev] [PATCH v4 07/11] net/softnic: add config flexibility to softnic tm
Update softnic tm function for configuration flexiblity of pipe traffic classes and queues size. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- drivers/net/softnic/rte_eth_softnic.c | 131 + drivers/net/softnic/rte_eth_softnic_cli.c
[dpdk-dev] [PATCH v4 10/11] examples/qos_sched: add tc and queue config flexibility
Update qos sched sample app for configuration flexibility of pipe traffic classes and queues. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- examples/qos_sched/app_thread.c | 9 +- examples/qos_sched/cfg_file.c | 119 +-- examples/qo
[dpdk-dev] [PATCH v4 09/11] examples/ip_pipeline: add config flexibility to tm function
Update ip pipeline sample app for configuration flexiblity of pipe traffic classes and queues. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- examples/ip_pipeline/cli.c | 45 +++--- examples/ip_pipeline/tmgr.c
[dpdk-dev] [PATCH v4 08/11] test_sched: modify tests for config flexibility
update unit tests for configuration flexibility of pipe traffic classes and queues size. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- app/test/test_sched.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/app/test
[dpdk-dev] [PATCH v4 04/11] sched: rename tc3 params to best-effort tc
Change the traffic class 3 related params name to best-effort(be) traffic class. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c | 48 ++-- 1 file changed, 24 insertions(+), 24 deletion
[dpdk-dev] [PATCH v4 05/11] sched: improve error log messages
Replace hard-coded numbers for reporting errors with error messages. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c | 294 ++- 1 file changed, 220 insertions(+), 74 deletions(-) diff
[dpdk-dev] [PATCH v4 06/11] sched: improve doxygen comments
Improve doxygen comments. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.h | 145 ++- 1 file changed, 93 insertions(+), 52 deletions(-) diff --git a/lib/librte_sched/rte_sched.h b/lib/l
[dpdk-dev] [PATCH v4 02/11] sched: add config flexibility to tc queue sizes
Add support for zero queue sizes of the traffic classes. The queues which are not used can be set to zero size. This helps in reducing memory footprint of the hierarchical scheduler. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sche
[dpdk-dev] [PATCH v4 03/11] sched: add max pipe profiles config in run time
Allow setting the maximum number of pipe profiles in run time. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar Signed-off-by: Lukasz Krakowiak --- lib/librte_sched/rte_sched.c | 8 +--- lib/librte_sched/rte_sched.h | 2 ++ 2 files changed, 7 insertions(+), 3 deletions(-) diff
[dpdk-dev] [PATCH v4 01/11] sched: remove wrr from strict priority tc queues
All higher priority traffic classes contain only one queue, thus remove wrr function for them. The lowest priority best-effort traffic class conitnue to have multiple queues and packet are scheduled from its queues using wrr function. Signed-off-by: Jasvinder Singh Signed-off-by: Abraham Tovar S
[dpdk-dev] [PATCH v4 00/11] sched: feature enhancements
This patchset refactors the dpdk qos sched library to allow flexibile configuration of the pipe traffic classes and queue sizes. Currently, each pipe has 16 queues hardwired into 4 TCs scheduled with strict priority, and each TC has exactly with 4 queues that are scheduled with Weighted Fair Queui
Re: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the ring when not in use
Hi Gavin, On Fri, Jul 12, 2019 at 09:32:39AM +, Gavin Hu (Arm Technology China) wrote: > Hi Olivier and Thomas, > > > -Original Message- > > From: Thomas Monjalon > > Sent: Thursday, July 4, 2019 10:42 PM > > To: Gavin Hu (Arm Technology China) > > Cc: dev@dpdk.org; Olivier Matz ; n
Re: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the ring when not in use
Hi Olivier and Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Thursday, July 4, 2019 10:42 PM > To: Gavin Hu (Arm Technology China) > Cc: dev@dpdk.org; Olivier Matz ; nd > ; jer...@marvell.com; hemant.agra...@nxp.com; > nipun.gu...@nxp.com; Honnappa Nagarahalli > ; i.maxim.
[dpdk-dev] [PATCH v2] common/octeontx2: add CNF95xx SoC support
Update platform support of CNF95xx in documentation and also, update the HW cap based on PCI subsystem id and revision id. This patch also changes HW capability handling to be based on PCI Revision ID. PCI Revision ID contains a unique identifier to identify chip, major and minor revisions. Signed
Re: [dpdk-dev] [PATCH v1] examples/power: fix FreeBSD meson lib dependency
On 7/12/2019 10:22 AM, Bruce Richardson wrote: > On Fri, Jul 12, 2019 at 10:06:51AM +0100, David Hunt wrote: >> Samples apps that depend on the power library should not build if >> the power library is not present. So now the following apps will >> check to see if it's built, else skip building. >>
[dpdk-dev] [PATCH v8 1/2] ring: add reset API to flush the ring when not in use
Currently, the flush is done by dequeuing the ring in a while loop. It is much simpler to flush the queue by resetting the head and tail indices. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Gavin Hu Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli
[dpdk-dev] [PATCH v8 2/2] hash: flush the rings instead of dequeuing one by one
Within rte_hash_reset, calling a while loop to dequeue one by one from the ring, while not using them at all, is wasting cycles, The patch just flush the ring by resetting the indices can save cpu cycles. Fixes: b26473ff8f4a ("hash: add reset function") Fixes: 75706568a7eb ("hash: add extendable b
[dpdk-dev] [PATCH v8 0/2] new ring reset api and use it by hash
V2: - fix the coding style issue(commit message line too long) V3: - allow experimental API for meson build V4: - include the ring perf test case enhancement patch in the series. - replace ARRAY_SIZE with RTE_DIM. - call memset to avoid clang compling complains. V5: - commit message tweaking for r
Re: [dpdk-dev] [PATCH v1] examples/power: fix FreeBSD meson lib dependency
On Fri, Jul 12, 2019 at 10:06:51AM +0100, David Hunt wrote: > Samples apps that depend on the power library should not build if > the power library is not present. So now the following apps will > check to see if it's built, else skip building. > * l3fwd-pwer > * vm_power_manager > * guest_cli > >
Re: [dpdk-dev] [RFC] mbuf: support dynamic fields and flags
On Thu, Jul 11, 2019 at 08:31:19AM -0700, Stephen Hemminger wrote: > On Thu, 11 Jul 2019 09:26:19 +0200 > Olivier Matz wrote: > > > For generic fields, I think they should be declared in this file. For > > instance, if we decide to replace the current m->timestamp field by a > > dynamic field, we
Re: [dpdk-dev] [PATCH v6 0/4] add IOVA = VA support in KNI
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, July 11, 2019 9:52 PM > To: Jerin Jacob Kollanukkaran ; Vamsi Krishna Attunuru > ; dev@dpdk.org > Cc: olivier.m...@6wind.com; arybche...@solarflare.com; Burakov, Anatoly > > Subject: [EXT] Re: [dpdk-dev] [PATCH v6 0/4] add IOVA
Re: [dpdk-dev] [RFC] mbuf: support dynamic fields and flags
Hi, On Thu, Jul 11, 2019 at 02:37:23PM +, Wiles, Keith wrote: > > > > On Jul 11, 2019, at 2:53 AM, Olivier Matz wrote: > > > > Hi Keith, > > > > On Wed, Jul 10, 2019 at 06:12:16PM +, Wiles, Keith wrote: > >> > >> > >>> On Jul 10, 2019, at 12:49 PM, Stephen Hemminger > >>> wrote: >
[dpdk-dev] [PATCH v1] examples/power: fix FreeBSD meson lib dependency
Samples apps that depend on the power library should not build if the power library is not present. So now the following apps will check to see if it's built, else skip building. * l3fwd-pwer * vm_power_manager * guest_cli Fixes: e0130788576f ("examples/power: support meson/ninja build") Fixes: 89
Re: [dpdk-dev] [PATCH] net/af_xdp: fix xdp_get_channels_info return value
Hi, Thanks for the patch. On 07/12, Július Milan wrote: >Procedure xdp_get_channels_info was returning error code -1 in case of >ioctl command SIOCETHTOOL was not supported. This patch sets return >value back to 0 as it is valid case. > >Fixes: 339b88c6a9 ("net/af_xdp: support multi-queue") > >S
[dpdk-dev] [PATCH] app/testpmd: fix doubling of 'total TX dropped'
The 'Accumulated forward statistics for all ports' incorrectly displayed double the actual value for 'total_tx_dropped'. This was because 2 lines in the same function both incremented total_tx_dropped every time a packet was dropped. I removed one of these lines to fix this issue. Fixes: 53324971
Re: [dpdk-dev] [PATCH 6/9] net/ring: remove redundant rte_vdev_drive declaration
On Thu, Jul 11, 2019 at 01:03:06PM -0700, Stephen Hemminger wrote: > The rte_vdev_driver is declared twice. > The first one is not necessary. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/ring/rte_eth_ring.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/ring/r
Re: [dpdk-dev] [PATCH 2/2] eal: fix IOVA mode selection as VA for pci drivers
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, July 11, 2019 8:11 PM > To: dev@dpdk.org > Cc: David Marchand ; > anatoly.bura...@intel.com; Jerin Jacob Kollanukkaran > ; John McNamara ; > Marko Kovacevic ; Igor Russkikh > ; Pavel Belous ; > Ajit Khaparde ; Somnath Kotur > ;
[dpdk-dev] [PATCH] net/af_xdp: fix xdp_get_channels_info return value
Procedure xdp_get_channels_info was returning error code -1 in case of ioctl command SIOCETHTOOL was not supported. This patch sets return value back to 0 as it is valid case. Fixes: 339b88c6a9 ("net/af_xdp: support multi-queue") Signed-off-by: Július Milan --- drivers/net/af_xdp/rte_eth_af_xdp
[dpdk-dev] [DPDK] drivers/net: fix dereference after null check coverity
This patch tries to fix the coverity issues of dereference after null check. Coverity issue: 343452 Coverity issue: 343447 Coverity issue: 343422 Coverity issue: 343416 Coverity issue: 343407 Coverity issue: 343403 Coverity issue: 13245 Signed-off-by: Xiao Zhang --- drivers/net/fm10k/fm10k_rxtx
[dpdk-dev] [PATCH] net/af_xdp: fix xdp_get_channels_info return value
Procedure xdp_get_channels_info was returning error code -1 in case of unsupported ioctl command SIOCETHTOOL. This patch sets return value back to 0 as it is valid case. Fixes: 339b88c6a9 ("net/af_xdp: support multi-queue") Signed-off-by: Július Milan --- drivers/net/af_xdp/rte_eth_af_xdp.c | 1
