[dpdk-dev] [PATCH v3] net/af_xdp: support need wakeup feature

2019-06-20 Thread Xiaolong Ye
This patch enables need_wakeup flag for Tx and fill rings, when this flag is set by the driver, it means that the userspace application has to explicitly wake up the kernel Rx or kernel Tx processing by issuing a syscall. Poll() can wake up both and sendto() or its alternatives will wake up Tx proc

[dpdk-dev] [PATCH v4 3/3] net/ice: add UDP tunnel port support

2019-06-20 Thread Qiming Yang
Enabled UDP tunnel port add and delete functions. Signed-off-by: Qiming Yang --- drivers/net/ice/ice_ethdev.c | 54 1 file changed, 54 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 8ee06d1..949d293 10064

[dpdk-dev] [PATCH v4 2/3] net/ice: add generic flow API

2019-06-20 Thread Qiming Yang
This patch adds ice_flow_create, ice_flow_destroy, ice_flow_flush and ice_flow_validate support, these are used to handle all the generic filters. Signed-off-by: Qiming Yang --- drivers/net/ice/Makefile | 1 + drivers/net/ice/ice_ethdev.c | 44 +++ drivers/net/ice/ice_ethdev.h

[dpdk-dev] [PATCH v4 1/3] net/ice: enable switch filter

2019-06-20 Thread Qiming Yang
From: wei zhao The patch enables the backend of rte_flow. It transfers rte_flow_xxx to device specific data structure and configures packet process engine's binary classifier (switch) properly. Signed-off-by: Wei Zhao --- drivers/net/ice/Makefile| 1 + drivers/net/ice/ice_ethdev.

[dpdk-dev] [PATCH v4 0/3] Enable rte_flow API in ice driver

2019-06-20 Thread Qiming Yang
This patch set enables the backend of rte_flow, and the generic filter related functions in ice driver. Supported flows include ipv4, tcpv4, udpv4, ipv6, tcpv6, udpv6, tunnel, etc. This patch set depends on shared code update. --- v2 changes: - added UDP tunnel port support. - fixed compile issu

Re: [dpdk-dev] [PATCH v3 2/3] net/ice: add generic flow API

2019-06-20 Thread Yang, Qiming
Hi, Xiao Other comments are all fixed. Left this one. "fields & (~inset)" can't replace it. Qiming -Original Message- From: Wang, Xiao W Sent: Thursday, June 20, 2019 5:32 PM To: Yang, Qiming ; dev@dpdk.org Cc: Zhang, Qi Z ; Xing, Beilei Subject: RE: [dpdk-dev] [PATCH v3 2/3] net/ice: a

Re: [dpdk-dev] [PATCH] net/i40e: fix core dumped when setting txq or rxq to 0 in VF

2019-06-20 Thread Ye Xiaolong
On 06/21, Andy Pei wrote: >Testpmd stucked and core dumped >when set invalid VF queue number. >This patch fix this issue. It's better to wrap the commit message within 72 characters. Perhaps something like: Testpmd would stuck and result in core dump when user specifies an invalid VF queue numb

Re: [dpdk-dev] [PATCH] vhost: log Virtio and Vhost-user negotiated features

2019-06-20 Thread Tiwei Bie
On Thu, Jun 20, 2019 at 10:07:12PM +0200, Maxime Coquelin wrote: > Having this info logged by default when analysing bug reports > has proved to be useful. > > Signed-off-by: Maxime Coquelin > --- > lib/librte_vhost/vhost_user.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/lib/

[dpdk-dev] [PATCH] net/i40e: fix core dumped when setting txq or rxq to 0 in VF

2019-06-20 Thread Andy Pei
Testpmd stucked and core dumped when set invalid VF queue number. This patch fix this issue. Fixes: d6b19729093e ("i40evf: support configurable crc stripping") Cc: helin.zh...@intel.com Cc: sta...@dpdk.org Signed-off-by: Andy Pei --- Cc: roy.fan.zh...@intel.com Cc: qi.z.zh...@intel.com Cc: jingj

Re: [dpdk-dev] [PATCH v3 2/3] net/ice: add generic flow API

2019-06-20 Thread Yang, Qiming
Thanks for your comments. I'll add it in v4. > -Original Message- > From: Aaron Conole [mailto:acon...@redhat.com] > Sent: Thursday, June 20, 2019 9:34 PM > To: Yang, Qiming > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 2/3] net/ice: add generic flow API > > Qiming Yang writes:

Re: [dpdk-dev] [PATCH v3 00/69] shared code update

2019-06-20 Thread Zhang, Qi Z
> -Original Message- > From: Yigit, Ferruh > Sent: Friday, June 21, 2019 4:18 AM > To: Zhang, Qi Z ; Rong, Leyi > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 00/69] shared code update > > On 6/20/2019 2:55 AM, Zhang, Qi Z wrote: > > > > > >> -Original Message- > >> From

Re: [dpdk-dev] [RFC] ethdev: reserve the RX offload most-significant bits for PMD scartch

2019-06-20 Thread Wang, Haiyue
Not so frightening in real world for an application to be aware of its NICs: https://github.com/Juniper/contrail-vrouter/blob/master/dpdk/vr_dpdk_ethdev.c#L387 Yes, we need to avoid this kind of design. BR, Haiyue From: Andrew Rybchenko [mailto:arybche...@solarflare.com] Sent: Friday, June 21, 2

[dpdk-dev] [PATCH v4 1/5] raw/ifpga_rawdev: fix use of untrusted scalar value

2019-06-20 Thread Tianfei zhang
Add checking the buffer size and use const char * for buffer declaration. Coverity issue: 279449 Fixes: ef1e8ede ("raw/ifpga: add Intel FPGA bus rawdev driver") Cc: sta...@dpdk.org Signed-off-by: Tianfei zhang Acked-by: Rosen Xu --- drivers/raw/ifpga_rawdev/base/ifpga_api.c | 4 +-- drive

[dpdk-dev] [PATCH v4 5/5] raw/ifpga_rawdev/base: fix retimer link status issue

2019-06-20 Thread Tianfei zhang
Fix the readout retimer link status incorrectly when we remove the linux intel-fpga-driver and run the DPDK application. The linux driver will stop the retimer when remove the kernel modules. Fixes: 8a256bef ("raw/ifpga/base: add eth group driver") Cc: sta...@dpdk.org Reported-by: Sampath Amrutha

[dpdk-dev] [PATCH v4 4/5] raw/ifpga_rawdev/base: fix miss physical address

2019-06-20 Thread Tianfei zhang
Fix miss phy_addr on ifpga_acc_get_region_info() function. Fixes: 56bb54ea1bd ("raw/ifpga/base: add Intel FPGA OPAE share code") Cc: sta...@dpdk.org Signed-off-by: Tianfei zhang Acked-by: Rosen Xu --- drivers/raw/ifpga_rawdev/base/ifpga_api.c | 1 + 1 file changed, 1 insertion(+) diff --git a

[dpdk-dev] [PATCH v4 2/5] raw/ifpga_rawdev: fix logically dead code

2019-06-20 Thread Tianfei zhang
add temporary variable in max10_reg_write(). Coverity issue: 337927 Fixes: 96ebfcf ("raw/ifpga/base: add SPI and MAX10 device driver") Cc: sta...@dpdk.org Signed-off-by: Tianfei zhang Acked-by: Rosen Xu --- drivers/raw/ifpga_rawdev/base/opae_intel_max10.c | 6 -- 1 file changed, 4 insertio

Re: [dpdk-dev] [RFC] ethdev: reserve the RX offload most-significant bits for PMD scartch

2019-06-20 Thread Wang, Haiyue
Hi > -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, June 21, 2019 02:36 > To: Wang, Haiyue > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [RFC] ethdev: reserve the RX offload most-significant > bits for PMD scartch > > On Thu, 20 Jun 2019

[dpdk-dev] [PATCH v4 3/5] raw/ifpga_rawdev/base: fix bit fields definition

2019-06-20 Thread Tianfei zhang
Fix CTRL_DEV_SELECT bit fields definition about eth_group devices. Fixes: 8a256bef32 ("raw/ifpga/base: add eth group driver") Cc: sta...@dpdk.org Signed-off-by: Tianfei zhang Acked-by: Rosen Xu --- drivers/raw/ifpga_rawdev/base/opae_eth_group.h | 2 +- 1 file changed, 1 insertion(+), 1 deletio

Re: [dpdk-dev] [PATCH 00/28] vhost: add virtio-vhost-user transport

2019-06-20 Thread Nikos Dragazis
On 20/6/19 2:32 μ.μ., Ilya Maximets wrote: > On 19.06.2019 18:14, Nikos Dragazis wrote: >> Hi everyone, > Hi. I didn't look at the code, just a few comments inline. > >> this patch series introduces the concept of the virtio-vhost-user >> transport. This is actually a revised version of an earlier

Re: [dpdk-dev] [PATCH v7 1/3] baseband/turbo_sw: option to build turbosw PMD without SDK

2019-06-20 Thread Mokhtar, Amr
> -Original Message- > From: Chautru, Nicolas > Sent: Wednesday 19 June 2019 18:49 > To: akhil.go...@nxp.com; dev@dpdk.org > Cc: Yigit, Ferruh ; tho...@monjalon.net; > Mokhtar, Amr ; Chalupnik, KamilX > ; acon...@redhat.com; Chautru, Nicolas > > Subject: [PATCH v7 1/3] baseband/turbo_sw:

Re: [dpdk-dev] [PATCH] Revert "net/mlx: support IOVA VA mode"

2019-06-20 Thread Stephen Hemminger
On Fri, 7 Jun 2019 16:08:41 -0700 Stephen Hemminger wrote: > From: Stephen Hemminger > > This reverts commit 69c06d0e357ed0064b498d510d169603cf7308cd. > That commit breaks support for netvsc PMD with MLX SRIOV > on both Hyper-V and Azure. > > Signed-off-by: Stephen Hemminger Could one of th

[dpdk-dev] [PATCH 1/2] net/netvsc: set id in xstats_get

2019-06-20 Thread Stephen Hemminger
From: Mohsin Mazhar Shaikh The xstats_get was not setting id correctly for each entry. Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") Signed-off-by: Mohsin Mazhar Shaikh Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c | 12 1 file changed, 8 in

[dpdk-dev] [PATCH 0/2] net/netvsc: xstat fixes

2019-06-20 Thread Stephen Hemminger
A couple of fixes for the xstats functionality in netvsc PMD. Mohsin Mazhar Shaikh (1): net/netvsc: set id in xstats_get Stephen Hemminger (1): net/netvsc: fix xstats for VF device drivers/net/netvsc/hn_ethdev.c | 14 +- drivers/net/netvsc/hn_var.h| 2 +- drivers/net/netvsc

[dpdk-dev] [PATCH 2/2] net/netvsc: fix xstats for VF device

2019-06-20 Thread Stephen Hemminger
The id values for VF stats were not being offset correctly. And getting xstats for VF device only worked if VF device supported it; it did not support the generic stats. Fixes: dc7680e8597c ("net/netvsc: support integrated VF") Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c

[dpdk-dev] [PATCH v2] doc: add multi-proc shared lib mempool note

2019-06-20 Thread Gage Eads
The mempool library assigns handler ops indexes based on the dynamic load order of mempool handlers. Indexes are used so a mempool can be used by multiple processes, but this only works if all processes agree on the mapping from index to mempool handler. When using the '-d' argument, it's possible

Re: [dpdk-dev] [PATCH v3 00/69] shared code update

2019-06-20 Thread Ferruh Yigit
On 6/20/2019 2:55 AM, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Rong, Leyi >> Sent: Wednesday, June 19, 2019 11:18 PM >> To: Zhang, Qi Z >> Cc: dev@dpdk.org; Rong, Leyi >> Subject: [PATCH v3 00/69] shared code update >> >> Main changes: >> 1. Advanced switch rule support. >>

Re: [dpdk-dev] [PATCH] eal: promote some service core functions to stable

2019-06-20 Thread David Marchand
On Thu, Jun 20, 2019 at 9:45 PM David Marchand wrote: > > > On Thu, Jun 20, 2019 at 8:26 PM Aaron Conole wrote: > >> Gage Eads writes: >> >> > The functions rte_service_may_be_active(), rte_service_lcore_attr_get(), >> > and rte_service_attr_reset_all() were introduced nearly a year ago in >> D

[dpdk-dev] [PATCH] vhost: log Virtio and Vhost-user negotiated features

2019-06-20 Thread Maxime Coquelin
Having this info logged by default when analysing bug reports has proved to be useful. Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c index c9e29ece8..37086486

Re: [dpdk-dev] [PATCH] eal: promote some service core functions to stable

2019-06-20 Thread David Marchand
On Thu, Jun 20, 2019 at 8:26 PM Aaron Conole wrote: > Gage Eads writes: > > > The functions rte_service_may_be_active(), rte_service_lcore_attr_get(), > > and rte_service_attr_reset_all() were introduced nearly a year ago in > DPDK > > 18.08. They can be considered non-experimental for the 19.08

[dpdk-dev] [PATCH v5 7/9] doc: update KNI documentation

2019-06-20 Thread Stephen Hemminger
Make the KNI documentation reflect modern kernel networking. Ifconfig has been superseded by iproute2 for 15 years. Iproute2 is well maintained, supports current feature set. Ethtool is no longer supported by KNI. Tshark is a better replacement for tcpdump. Signed-off-by: Stephen Hemminger ---

[dpdk-dev] [PATCH v5 9/9] kni: add minimal ethtool

2019-06-20 Thread Stephen Hemminger
Some applications use ethtool so add the minimum ethtool ops. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_dev.h | 2 ++ kernel/linux/kni/kni_misc.c | 1 + kernel/linux/kni/kni_net.c | 14 ++ 3 files changed, 17 insertions(+) diff --git a/kernel/linux/kni/kni_dev.h

[dpdk-dev] [PATCH v5 8/9] kni: fix style issues

2019-06-20 Thread Stephen Hemminger
rte_kni does not follow standard style rules. Noticed some extra \ line continuation etc. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_net.c | 7 --- lib/librte_kni/rte_kni.c | 38 +++--- 2 files changed, 23 insertions(+), 22 deletions(-) diff

[dpdk-dev] [PATCH v5 6/9] kni: return -EFAULT if copy_from_user fails

2019-06-20 Thread Stephen Hemminger
The correct thing to return if user gives a bad data is to return -EFAULT. Logging is also discouraged because it could be used as a DoS attack. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_misc.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/

[dpdk-dev] [PATCH v5 5/9] kni: use proper type for kni fifo's

2019-06-20 Thread Stephen Hemminger
Using void * instead of proper type is unsafe practice. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_dev.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/kernel/linux/kni/kni_dev.h b/kernel/linux/kni/kni_dev.h index f3e6c3ca4efa..ceba5f73c1d9 100644

[dpdk-dev] [PATCH v5 4/9] kni: drop unused fields

2019-06-20 Thread Stephen Hemminger
Several fields were either totally unused or set and never used. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_dev.h | 5 - kernel/linux/kni/kni_misc.c | 1 - 2 files changed, 6 deletions(-) diff --git a/kernel/linux/kni/kni_dev.h b/kernel/linux/kni/kni_dev.h index 21e4b0d92368

[dpdk-dev] [PATCH v5 3/9] kni: don't keep stats in kni_net

2019-06-20 Thread Stephen Hemminger
Since kernel 2.6.28 the network subsystem has provided dev->stats for devices to use statistics handling and is the default if no ndo_get_stats is provided. This allow allows for 64 bit (rather than just 32 bit) statistics with KNI. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_dev.

[dpdk-dev] [PATCH v5 2/9] kni: use netdev_alloc_skb

2019-06-20 Thread Stephen Hemminger
netdev_alloc_skb is optimized to any alignment or setup of skb->dev that is required. The kernel has chosen to not pad packets on x86 (for many years), because it is faster. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_net.c | 17 +++-- 1 file changed, 3 insertions(+), 1

[dpdk-dev] [PATCH v5 1/9] kni: don't need stubs for rx_mode or ioctl

2019-06-20 Thread Stephen Hemminger
The netdev subsystem already handles case where network sevice does not support ioctl. If device has no rx_mode hook it is not called. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_net.c | 19 --- 1 file changed, 19 deletions(-) diff --git a/kernel/linux/kni/kni_net

[dpdk-dev] [PATCH v5 0/9] kni: fixes and cleanups

2019-06-20 Thread Stephen Hemminger
While testing KNI with netvsc, saw lots of places more code could be safely removed from KNI kernel driver. v5 - add minimal ethtool, fix checkpath author complaints v4 - add more style fixes v3 - rebase to current master, add style fix patch v2 - get rid of unnecessary padding, combine the unused

Re: [dpdk-dev] [PATCH] doc: add multi-proc shared lib mempool note

2019-06-20 Thread Eads, Gage
> -Original Message- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Thursday, June 20, 2019 1:01 PM > To: Eads, Gage ; dev@dpdk.org > Cc: olivier.m...@6wind.com; sta...@dpdk.org > Subject: Re: [PATCH] doc: add multi-proc shared lib mempool note > > On 6/18/19 9:48 PM

[dpdk-dev] [PATCH v2] eal: promote some service core functions to stable

2019-06-20 Thread Gage Eads
The functions rte_service_may_be_active(), rte_service_lcore_attr_get(), and rte_service_attr_reset_all() were introduced nearly a year ago in DPDK 18.08. They can be considered non-experimental for the 19.08 release. rte_service_may_be_active() is used by the sw PMD, and this commit allows it to

Re: [dpdk-dev] [PATCH] eal: promote some service core functions to stable

2019-06-20 Thread Eads, Gage
> Gage Eads writes: > > > The functions rte_service_may_be_active(), > > rte_service_lcore_attr_get(), and rte_service_attr_reset_all() were > > introduced nearly a year ago in DPDK 18.08. They can be considered non- > experimental for the 19.08 release. > > > > rte_service_may_be_active() is use

Re: [dpdk-dev] [RFC] ethdev: reserve the RX offload most-significant bits for PMD scartch

2019-06-20 Thread Stephen Hemminger
On Thu, 20 Jun 2019 15:25:52 +0800 Haiyue Wang wrote: > Generally speaking, the DEV_RX_OFFLOAD_xxx for RX offload capabilities > of a device is one-bit field definition, it has 64 different values at > most. > > Nowdays the receiving queue of NIC has rich features not just checksum > offload, li

Re: [dpdk-dev] [RFC] ethdev: reserve the RX offload most-significant bits for PMD scartch

2019-06-20 Thread Andrew Rybchenko
CC ethdev maintainers On 6/20/19 10:25 AM, Haiyue Wang wrote: Generally speaking, the DEV_RX_OFFLOAD_xxx for RX offload capabilities of a device is one-bit field definition, it has 64 different values at most. Nowdays the receiving queue of NIC has rich features not just checksum offload, like

Re: [dpdk-dev] [PATCH] eal: promote some service core functions to stable

2019-06-20 Thread Aaron Conole
Gage Eads writes: > The functions rte_service_may_be_active(), rte_service_lcore_attr_get(), > and rte_service_attr_reset_all() were introduced nearly a year ago in DPDK > 18.08. They can be considered non-experimental for the 19.08 release. > > rte_service_may_be_active() is used by eventdev and

Re: [dpdk-dev] [PATCH 01/28] vhost: introduce vhost transport operations structure

2019-06-20 Thread Nikos Dragazis
On 20/6/19 1:30 μ.μ., Bruce Richardson wrote: > On Wed, Jun 19, 2019 at 04:14:09PM -0400, Aaron Conole wrote: >> Nikos Dragazis writes: >> >>> This is the first of a series of patches, whose purpose is to add >>> support for the virtio-vhost-user transport. This is a vhost-user >>> transport imple

Re: [dpdk-dev] [PATCH 01/28] vhost: introduce vhost transport operations structure

2019-06-20 Thread Nikos Dragazis
On 19/6/19 11:14 μ.μ., Aaron Conole wrote: > Nikos Dragazis writes: > >> This is the first of a series of patches, whose purpose is to add >> support for the virtio-vhost-user transport. This is a vhost-user >> transport implementation that is different from the default AF_UNIX >> transport. It us

Re: [dpdk-dev] [PATCH] doc: add multi-proc shared lib mempool note

2019-06-20 Thread Andrew Rybchenko
On 6/18/19 9:48 PM, Gage Eads wrote: The mempool library assigns handler ops indexes based on the dynamic load order of mempool handlers. Indexes are used so a mempool can be used by multiple processes, but this only works if all processes agree on the mapping from index to mempool handler. When

Re: [dpdk-dev] [PATCH 1/3] net: new ipv6 header extension parsing function

2019-06-20 Thread Ananyev, Konstantin
Hi Akhil, > > Hi Marcin, > > > > > Introduce new function for IPv6 header extension parsing able to > > determine extension length and next protocol number. > > > > This function is helpful when implementing IPv6 header traversing. > > > > Signed-off-by: Marcin Smoczynski > > --- > > lib/lib

Re: [dpdk-dev] [PATCH v7 0/3] BBDEV turbo_sw PMD compilation fix

2019-06-20 Thread Ferruh Yigit
On 6/19/2019 6:48 PM, Nicolas Chautru wrote: > Update v7: Remove architecture specific reference to RTE_CPUFLAG_SSE4_2 > reported on travis-ci > Update v6: Cosmetic change to commit message to include previous Acked-by. > Update v5: Cosmetic change to remove trailing space and to commit message.

Re: [dpdk-dev] [PATCH] eal: resort symbols in EXPERIMENTAL section

2019-06-20 Thread David Marchand
On Fri, Jun 14, 2019 at 5:32 PM Ferruh Yigit wrote: > On 6/14/2019 8:44 AM, David Marchand wrote: > > On Fri, Jun 14, 2019 at 9:39 AM Thomas Monjalon > wrote: > > > >> 06/04/2019 05:30, Stephen Hemminger: > >>> The symbols in the EXPERIMENTAL were close to alphabetic > >>> order but running sort

Re: [dpdk-dev] [dpdk-announce] DPDK 18.11.2 (LTS) released

2019-06-20 Thread Ju-Hyoung Lee
Hello, DPDK https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.dpdk.org%2Fdpdk-stable%2Fsnapshot%2Fdpdk-stable-v18.11.2.tar.gz&data=02%7C01%7Cv-advlad%40microsoft.com%7Cf25bf3676935492f47a908d6f586fbdf%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636966357449547606&sdata=3Vkt83

[dpdk-dev] [PATCH] eal: promote some service core functions to stable

2019-06-20 Thread Gage Eads
The functions rte_service_may_be_active(), rte_service_lcore_attr_get(), and rte_service_attr_reset_all() were introduced nearly a year ago in DPDK 18.08. They can be considered non-experimental for the 19.08 release. rte_service_may_be_active() is used by eventdev and the sw PMD, and this commit

Re: [dpdk-dev] [PATCH v4 8/8] app/testpmd: use rte_ether_unformat_addr

2019-06-20 Thread Stephen Hemminger
On Thu, 20 Jun 2019 14:18:18 + "Iremonger, Bernard" wrote: > Hi Stephen, > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen > > Hemminger > > Sent: Wednesday, June 5, 2019 7:10 PM > > To: dev@dpdk.org > > Cc: Stephen Hemminger > > Subject: [dpd

Re: [dpdk-dev] [RFC] app/testpmd: add profiling for Rx/Tx burst routines

2019-06-20 Thread Iremonger, Bernard
Hi Slava, > -Original Message- > From: Slava Ovsiienko [mailto:viachesl...@mellanox.com] > Sent: Monday, June 10, 2019 5:40 AM > To: Iremonger, Bernard ; dev@dpdk.org > Cc: Yigit, Ferruh > Subject: RE: [dpdk-dev] [RFC] app/testpmd: add profiling for Rx/Tx burst > routines > > > > st

Re: [dpdk-dev] [PATCH] maintainers: update dpdk-next-net-intel

2019-06-20 Thread Ferruh Yigit
On 6/19/2019 9:24 AM, Qi Zhang wrote: > Xiaolong Ye will replace Beilei Xing as co-maintainer of > dpdk-next-net-intel. > > Signed-off-by: Qi Zhang Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v2] ipsec: support multi-segment packets

2019-06-20 Thread Ananyev, Konstantin
Hi Akhil, > Hi Konstantin, > > > > > Add support for packets that consist of multiple segments. > > Take into account that trailer bytes (padding, ESP tail, ICV) > > can spawn across multiple segments. > > > > Signed-off-by: Konstantin Ananyev > > --- > > Which all action types does this patch

Re: [dpdk-dev] [PATCH] doc/cryptodev: clarify that full xform struct should be zeroed before use

2019-06-20 Thread Akhil Goyal
Hi Fiona, > > Hi Akhil, etc, > Is a deprecation notice necessary for this patch? > If this patch is accepted I will send a follow-up patchset zeroing the xforms > in > crypto apps. > Fiona > Sorry for late reply. I don't think this patch need deprecation notice. > > -Original Message--

Re: [dpdk-dev] [PATCH v4 8/8] app/testpmd: use rte_ether_unformat_addr

2019-06-20 Thread Iremonger, Bernard
Hi Stephen, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen > Hemminger > Sent: Wednesday, June 5, 2019 7:10 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH v4 8/8] app/testpmd: use > rte_ether_unformat_addr > > The cmdline_p

Re: [dpdk-dev] [PATCH] cryptodev: extend api of asymmetric crypto by sessionless

2019-06-20 Thread Akhil Goyal
> > Asymmetric cryptography algorithms may more likely use > sessionless API so there is need to extend API. > > Signed-off-by: Arek Kusztal > --- Acked-by: Akhil Goyal

Re: [dpdk-dev] [PATCH] cryptodev: add ff_disable field in cryptodev config

2019-06-20 Thread Akhil Goyal
> > Adding a new field, ff_disable, to allow applications to control the > features enabled on the crypto device. This would allow for efficient > usage of HW/SW offloads by disabling the features not required by the > application. > > Signed-off-by: Anoob Joseph > --- Acked-by: Akhil Goyal

Re: [dpdk-dev] [PATCH v6] baseband/fpga_lte_fec: adding driver for FEC on FPGA

2019-06-20 Thread Ferruh Yigit
On 6/18/2019 7:40 AM, Chalupnik, KamilX wrote: >> -Original Message- >> From: Chautru, Nicolas >> Sent: Friday, June 14, 2019 6:18 PM >> To: akhil.go...@nxp.com; dev@dpdk.org >> Cc: Yigit, Ferruh ; tho...@monjalon.net; Mokhtar, >> Amr ; Chalupnik, KamilX >> ; Chautru, Nicolas >> >> Subject

Re: [dpdk-dev] [PATCH v3 2/3] net/ice: add generic flow API

2019-06-20 Thread Aaron Conole
Qiming Yang writes: > This patch adds ice_flow_create, ice_flow_destroy, > ice_flow_flush and ice_flow_validate support, > these are used to handle all the generic filters. > > Signed-off-by: Qiming Yang > --- > drivers/net/ice/Makefile | 1 + > drivers/net/ice/ice_ethdev.c |

Re: [dpdk-dev] [PATCH v3] ipsec: include high order bytes of esn in pkt len

2019-06-20 Thread Akhil Goyal
> > > > When esn is used then high-order 32 bits are included in ICV > > calculation however are not transmitted. Update packet length > > to be consistent with auth data offset and length before crypto > > operation. High-order 32 bits of esn will be removed from packet > > length in crypto pos

Re: [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: fix not working inline ipsec modes

2019-06-20 Thread Akhil Goyal
Hi Marius, > Application ipsec-secgw is not working for IPv4 transport mode and for > IPv6 both transport and tunnel mode. > > IPv6 tunnel mode is not working due to wrongly assigned fields of > security association patterns, as it was IPv4, during creation of > inline crypto session. > > IPv6

Re: [dpdk-dev] [PATCH v2] ipsec: support multi-segment packets

2019-06-20 Thread Akhil Goyal
Hi Konstantin, > > Add support for packets that consist of multiple segments. > Take into account that trailer bytes (padding, ESP tail, ICV) > can spawn across multiple segments. > > Signed-off-by: Konstantin Ananyev > --- Which all action types does this patch work well with? Will it work fo

Re: [dpdk-dev] [PATCH v9] app/pdump: exit with primary process

2019-06-20 Thread Pattan, Reshma
> -Original Message- > From: Suanming.Mou [mailto:mousuanm...@huawei.com] > Sent: Wednesday, May 15, 2019 6:11 AM > To: dev@dpdk.org > Cc: Varghese, Vipin ; Burakov, Anatoly > ; tho...@monjalon.net; Pattan, Reshma > > Subject: [PATCH v9] app/pdump: exit with primary process > > From: S

Re: [dpdk-dev] [PATCH v1] lib/ipsec: add support for header construction

2019-06-20 Thread Akhil Goyal
Hi Marko, Could you please address to the comments from Konstantin? We have an RC1 date coming. Thanks, Akhil > Hi, > > > > > Add support for RFC 4301(5.1.2) to update of > > Type of service field and Traffic class field > > bits inside ipv4/ipv6 packets for outbound cases > > and inbound case

Re: [dpdk-dev] [PATCH 2/3] ipsec: fix transport mode for ipv6 with extensions

2019-06-20 Thread Akhil Goyal
Hi Marcin, > > Reconstructing IPv6 header after encryption or decryption requires > updating 'next header' value in the preceding protocol header, which > is determined by parsing IPv6 header and iteratively looking for > next IPv6 header extension. > > It is required that 'l3_len' in the mbuf m

[dpdk-dev] DPDK Release Status Meeting 20/6/2019

2019-06-20 Thread Ferruh Yigit
Minutes 20 June 2019 Agenda: * Release Dates * Subtrees * OvS * Opens Participants: * Intel * Marvell * Mellanox * NXP * Red Hat Release Dates - * v19.08 dates: * RC1 date pushed to *Monday 08 July* * Release    Thurs  01 August 2019 * Reminder

[dpdk-dev] Your Bugzilla bug list needs attention.

2019-06-20 Thread bugzilla
[This e-mail has been automatically generated.] You have one or more bugs assigned to you in the Bugzilla bug tracking system (http://dpdk.space:8000/) that require attention. All of these bugs are in the CONFIRMED state, and have not been touched in 7 days or more. You need to take a look at th

Re: [dpdk-dev] [PATCH 1/3] net: new ipv6 header extension parsing function

2019-06-20 Thread Akhil Goyal
Hi Marcin, > > Introduce new function for IPv6 header extension parsing able to > determine extension length and next protocol number. > > This function is helpful when implementing IPv6 header traversing. > > Signed-off-by: Marcin Smoczynski > --- > lib/librte_net/rte_ip.h | 49 +

Re: [dpdk-dev] [PATCH 00/28] vhost: add virtio-vhost-user transport

2019-06-20 Thread Maxime Coquelin
Hi Nikos, On 6/19/19 5:14 PM, Nikos Dragazis wrote: Hi everyone, this patch series introduces the concept of the virtio-vhost-user transport. This is actually a revised version of an earlier RFC implementation that has been proposed by Stefan Hajnoczi [1]. Though this is a great feature, it see

Re: [dpdk-dev] [PATCH 00/28] vhost: add virtio-vhost-user transport

2019-06-20 Thread Ilya Maximets
On 19.06.2019 18:14, Nikos Dragazis wrote: > Hi everyone, Hi. I didn't look at the code, just a few comments inline. > > this patch series introduces the concept of the virtio-vhost-user > transport. This is actually a revised version of an earlier RFC > implementation that has been proposed by

Re: [dpdk-dev] [PATCH v4] eal: rename state values in rte_lcore_state

2019-06-20 Thread David Marchand
On Wed, Jun 19, 2019 at 9:24 PM Stephen Hemminger < step...@networkplumber.org> wrote: > C language does not really treat enum's as first class symbols. > The values in an enum live in a global namespace. That means if > DPDK defines "RUNNING" it can't be used by another enum in an > application

Re: [dpdk-dev] [PATCH v2 3/3] lib/lpm: remove unnecessary inline

2019-06-20 Thread Ruifeng Wang (Arm Technology China)
Hi Vladimir, > -Original Message- > From: Medvedkin, Vladimir > Sent: Wednesday, June 19, 2019 20:51 > To: Ruifeng Wang (Arm Technology China) ; > bruce.richard...@intel.com > Cc: dev@dpdk.org; Honnappa Nagarahalli > ; Gavin Hu (Arm Technology China) > ; nd > Subject: Re: [PATCH v2 3/3]

Re: [dpdk-dev] [PATCH 01/28] vhost: introduce vhost transport operations structure

2019-06-20 Thread Bruce Richardson
On Wed, Jun 19, 2019 at 04:14:09PM -0400, Aaron Conole wrote: > Nikos Dragazis writes: > > > This is the first of a series of patches, whose purpose is to add > > support for the virtio-vhost-user transport. This is a vhost-user > > transport implementation that is different from the default AF_U

[dpdk-dev] [PATCH v7 6/6] doc: update docs for ntb driver

2019-06-20 Thread Xiaoyun Li
Update related documents for ntb pmd and example. Signed-off-by: Xiaoyun Li --- MAINTAINERS| 8 + doc/guides/rawdevs/index.rst | 1 + doc/guides/rawdevs/ntb_rawdev.rst | 41 ++ doc/guides/rel_notes/release_19_08.rst | 15 ++

[dpdk-dev] [PATCH v7 5/6] usertools/dpdk-devbind.py: add support for ntb

2019-06-20 Thread Xiaoyun Li
In order to allow binding/unbinding of devices for use by the ntb_rawdev, we need to update the devbind script to add a new class of device, and add device ids for the specific HW instances. And only support skx platform right now. Signed-off-by: Xiaoyun Li --- usertools/dpdk-devbind.py | 9

[dpdk-dev] [PATCH v7 4/6] examples/ntb: enable an example for ntb

2019-06-20 Thread Xiaoyun Li
Enable an example for rawdev ntb. Support interactive mode to send file on one host and receive file from another host. The command line would be 'send [filepath]' and 'receive [filepath]'. But since the FIFO is not enabled right now, use rte_memcpy as the enqueue and dequeue functions and only su

[dpdk-dev] [PATCH v7 3/6] raw/ntb: add handshake process

2019-06-20 Thread Xiaoyun Li
Add handshake process using doorbell so that two hosts can communicate to start and stop. Signed-off-by: Xiaoyun Li --- drivers/raw/ntb_rawdev/ntb_rawdev.c | 336 +++- 1 file changed, 335 insertions(+), 1 deletion(-) diff --git a/drivers/raw/ntb_rawdev/ntb_rawdev.c b/dr

[dpdk-dev] [PATCH v7 2/6] raw/ntb: add intel ntb support

2019-06-20 Thread Xiaoyun Li
Add in the list of registers for the device. And enable ntb device ops for intel skylake platform. Signed-off-by: Xiaoyun Li --- drivers/raw/ntb_rawdev/Makefile | 1 + drivers/raw/ntb_rawdev/meson.build| 3 +- drivers/raw/ntb_rawdev/ntb_hw_intel.c | 369 ++

[dpdk-dev] [PATCH v7 1/6] raw/ntb: introduce ntb rawdev driver

2019-06-20 Thread Xiaoyun Li
Introduce rawdev driver support for NTB (Non-transparent Bridge) which can help to connect two separate hosts with each other. Signed-off-by: Xiaoyun Li --- config/common_base| 5 + drivers/raw/Makefile | 1 + drivers/raw/meson.build

[dpdk-dev] [PATCH v7 0/6] rawdev driver for ntb

2019-06-20 Thread Xiaoyun Li
This patch set adds support for Intel NTB device with Skylake platform. It is a raw device for allowing two hosts to communicate with each other and access the peer memory. This patch set also provides a simple example to transmit a file between two hosts. But since there is no FIFO here, only sup

Re: [dpdk-dev] [PATCH v2 02/10] meson: add BUILDING_RTE_SDK

2019-06-20 Thread Bruce Richardson
On Thu, Jun 13, 2019 at 10:23:36AM -0400, Neil Horman wrote: > The __rte_internal macro is defined dependent on the value of the build > environment variable BUILDING_RTE_SDK. This variable was set in the > Makefile environment but not the meson environment, so lets reconcile > the two by defining

Re: [dpdk-dev] [PATCH v3 2/3] net/ice: add generic flow API

2019-06-20 Thread Wang, Xiao W
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qiming Yang > Sent: Thursday, June 20, 2019 1:35 PM > To: dev@dpdk.org > Cc: Yang, Qiming > Subject: [dpdk-dev] [PATCH v3 2/3] net/ice: add generic flow API > > This patch adds ice_flow_create, ice_flow_destr

Re: [dpdk-dev] [PATCH v2 02/10] meson: add BUILDING_RTE_SDK

2019-06-20 Thread Bruce Richardson
On Wed, Jun 19, 2019 at 02:34:43PM -0400, Neil Horman wrote: > On Wed, Jun 19, 2019 at 11:46:12AM +0100, Bruce Richardson wrote: > > On Wed, Jun 19, 2019 at 06:39:00AM -0400, Neil Horman wrote: > > > On Thu, Jun 13, 2019 at 03:44:02PM +0100, Bruce Richardson wrote: > > > > On Thu, Jun 13, 2019 at 1

Re: [dpdk-dev] [PATCH v6 3/6] raw/ntb: add handshake process

2019-06-20 Thread Li, Xiaoyun
Thanks for comments for patch 1 & 2. Will refine them in the coming v7. And > -Original Message- > From: Wu, Jingjing > Sent: Wednesday, June 19, 2019 00:08 > To: Li, Xiaoyun ; Wiles, Keith ; > Liang, Cunming ; Maslekar, Omkar > > Cc: dev@dpdk.org > Subject: RE: [PATCH v6 3/6] raw/ntb: add

Re: [dpdk-dev] [PATCH] vhost/crypto: fix inferred misuse of enum

2019-06-20 Thread Maxime Coquelin
On 5/15/19 6:09 PM, Fan Zhang wrote: This patch fixes the inferred misuse of enum of crypto algorithms. Coverity issue: 325879 Fixes: e80a98708166 ("vhost/crypto: add session message handler") Cc: sta...@dpdk.org Signed-off-by: Fan Zhang --- lib/librte_vhost/vhost_crypto.c | 93 ++

Re: [dpdk-dev] [PATCH] vhost/crypto: fix logically dead code

2019-06-20 Thread Maxime Coquelin
On 5/15/19 6:19 PM, Fan Zhang wrote: This patch fixes a few same class bugs that causes the logically dead code in vhost_crypto. Coverity issue: 277236 Coverity issue: 277233 Coverity issue: 277220 Coverity issue: 277214 Fixes: 3bb595ecd682 ("vhost/crypto: add request handler") Cc: sta...@dp

Re: [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked return value

2019-06-20 Thread Maxime Coquelin
On 5/15/19 6:25 PM, Fan Zhang wrote: This patch tries to fix the coverity issue of unchecked return value. Since the function that causes the problem is unused, it is removed completely. Coverity issue: 336816 Fixes: f5188211c721 ("examples/vhost_crypto: add sample application") Cc: sta...@dp

Re: [dpdk-dev] [PATCH 0/5] virtio: release port upon close

2019-06-20 Thread Maxime Coquelin
On 6/5/19 11:43 AM, Tiwei Bie wrote: Tiwei Bie (5): net/virtio: fix queue memory leak on error net/virtio: unmap port IO for legacy device net/virtio: unmap device on initialization error net/virtio: release port upon close app/testpmd: drop the workaround for virtio-user app

Re: [dpdk-dev] [PATCH] examples/vdpa: remove trace of legacy "linuxapp"

2019-06-20 Thread Maxime Coquelin
On 6/17/19 9:54 AM, David Marchand wrote: This check on Linux environment has been added at a time when we already had switched to using the boolean RTE_EXEC_ENV_LINUXAPP. It was then missed when converting to RTE_EXEC_ENV_LINUX. Fixes: edbed86d1cc3 ("examples/vdpa: introduce a new sample for

Re: [dpdk-dev] [PATCH v4 2/2] net/virtio: move VLAN tag insertion to Tx prepare

2019-06-20 Thread Maxime Coquelin
On 6/17/19 1:31 PM, Andrew Rybchenko wrote: From: Dilshod Urazov VLAN tag insertion should be in Tx prepare, not in Tx burst functions. One of Tx prepare goals is to be able to do preparations in advance (possibliy on different CPU core) and then transmit it fast. Also Tx prepare can report t

Re: [dpdk-dev] [PATCH v4 1/2] net/virtio: add Tx preparation

2019-06-20 Thread Maxime Coquelin
On 6/17/19 1:31 PM, Andrew Rybchenko wrote: From: Dilshod Urazov Virtio requires pseudo-header checksum in TCP/UDP checksum to do offload, but it was lost when Tx prepare is introduced. Also rte_validate_tx_offload() should be used to validate Tx offloads. Also it is incorrect to do virtio_t

Re: [dpdk-dev] [PATCH v2 0/4] Some fixes for mergeable Rx

2019-06-20 Thread Maxime Coquelin
On 6/20/19 4:34 AM, Tiwei Bie wrote: v2: - Fix commit log (Maxime); Tiwei Bie (4): net/virtio: fix memory leak in in-order Rx net/virtio: fix memory leak in mergeable Rx net/virtio: fix memory leak in mergeable packed Rx net/virtio: fix packets check in mergeable packed Rx driv

Re: [dpdk-dev] [PATCH v2] vhost: fix add a missing include

2019-06-20 Thread Maxime Coquelin
On 6/20/19 7:44 AM, Noa Ezra wrote: Add a missing include with the defines for vhost-user driver features. Fixes: 5fbb3941da9f ("vhost: introduce driver features related APIs") Cc:sta...@dpdk.org Signed-off-by: Noa Ezra Reviewed-by: Maxime Coquelin Reviewed-by: Matan Azrad --- v2 remove chec

Re: [dpdk-dev] [PATCH] vhost/crypto: fix inferred misuse of enum

2019-06-20 Thread Maxime Coquelin
On 5/15/19 6:09 PM, Fan Zhang wrote: This patch fixes the inferred misuse of enum of crypto algorithms. Coverity issue: 325879 Fixes: e80a98708166 ("vhost/crypto: add session message handler") Cc: sta...@dpdk.org Signed-off-by: Fan Zhang --- lib/librte_vhost/vhost_crypto.c | 93 ++

Re: [dpdk-dev] [PATCH] vhost/crypto: fix logically dead code

2019-06-20 Thread Maxime Coquelin
On 5/15/19 6:19 PM, Fan Zhang wrote: This patch fixes a few same class bugs that causes the logically dead code in vhost_crypto. Coverity issue: 277236 Coverity issue: 277233 Coverity issue: 277220 Coverity issue: 277214 Fixes: 3bb595ecd682 ("vhost/crypto: add request handler") Cc: sta...@dp

Re: [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked return value

2019-06-20 Thread Maxime Coquelin
On 5/15/19 6:25 PM, Fan Zhang wrote: This patch tries to fix the coverity issue of unchecked return value. Since the function that causes the problem is unused, it is removed completely. Coverity issue: 336816 Fixes: f5188211c721 ("examples/vhost_crypto: add sample application") Cc: sta...@dp

  1   2   >