Re: [dpdk-dev] [PATCH v2] rcu/test: make gloabl variable per core

2019-06-06 Thread Honnappa Nagarahalli
> > Bad start, there is a typo in the title :) I guess, my apologies do not have any meaning anymore > > 16/05/2019 03:14, Honnappa Nagarahalli: > > Each hash entry has a pointer to one uint32 memory location. > > However, all the readers increment the same location causing race > > conditions.

Re: [dpdk-dev] [PATCH] acl: fix build issue with some arm64 compiler

2019-06-06 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Honnappa Nagarahalli > Sent: Friday, June 7, 2019 11:05 AM > To: Jerin Jacob Kollanukkaran ; dev@dpdk.org > Cc: tho...@monjalon.net; Gavin Hu (Arm Technology China) > ; msant...@redhat.com; acon...@redhat.com; Jerin > Jacob Kollanukkaran ; Honnappa Nag

Re: [dpdk-dev] [PATCH v1 1/2] lib/ring: add enqueue-dequeue callabck

2019-06-06 Thread Honnappa Nagarahalli
> > Add callback event handler for enqueue dequeue operation on ring. > The pre-enqueue and post-dequeue operation on ring is selected to invoke > user callback handler. Can you provide a use case for this to better understand the need? > > Signed-off-by: Vipin Varghese > --- > config/common_b

Re: [dpdk-dev] [EXT] Re: [PATCH v1 48/58] net/octeontx2: add FW version get operation

2019-06-06 Thread Vamsi Krishna Attunuru
From: Ferruh Yigit Sent: Thursday, June 6, 2019 9:36 PM To: Jerin Jacob Kollanukkaran; dev@dpdk.org; John McNamara; Marko Kovacevic; Nithin Kumar Dabilpuram; Kiran Kumar Kokkilagadda Cc: Vamsi Krishna Attunuru Subject: [EXT] Re: [dpdk-dev] [PATCH v1 48/58] net

Re: [dpdk-dev] [PATCH] acl: fix build issue with some arm64 compiler

2019-06-06 Thread Honnappa Nagarahalli
On 6/6/19 10:50 AM, mailto:jer...@marvell.com wrote: From: Jerin Jacob mailto:jer...@marvell.com Some compilers reporting the following error, though the existing code doesn't have any uninitialized variable case. Just to make compiler happy, initialize the int32x4_t variable one shot in C languag

Re: [dpdk-dev] [PATCH] acl: fix build issue with some arm64 compiler

2019-06-06 Thread Honnappa Nagarahalli
> Subject: [dpdk-dev] [PATCH] acl: fix build issue with some arm64 compiler > > From: Jerin Jacob > > Some compilers reporting the following error, though the existing code > doesn't have any uninitialized variable case. > Just to make compiler happy, initialize the int32x4_t variable one shot i

Re: [dpdk-dev] [PATCH v1 3/3] test/mcslock: add mcs queued lock unit test

2019-06-06 Thread Honnappa Nagarahalli
> Hi, > > > > > Unit test and perf test for MCS queued lock. > > Perf test is important of course, but first I think we need more robust > functional test to make sure that lock does work properly. > At least something like ticketlock test but probably with bigger number of > iterations. > 10K se

Re: [dpdk-dev] [PATCH v1 56/58] net/octeontx2: add device stop and close operations

2019-06-06 Thread Nithin Dabilpuram
On Thu, Jun 06, 2019 at 05:23:12PM +0100, Ferruh Yigit wrote: > On 6/2/2019 4:24 PM, jer...@marvell.com wrote: > > From: Nithin Dabilpuram > > > > Add device stop, close and reset operations. > > > > Signed-off-by: Nithin Dabilpuram > > Signed-off-by: Vamsi Attunuru > > <...> > > > @@ -1792,

Re: [dpdk-dev] DPDK compilation on arm is failing in Travis

2019-06-06 Thread Honnappa Nagarahalli
> > > > Thomas Monjalon writes: > > > > > > > > The compilation of the master branch is failing for aarch64: > > > > https://travis-ci.com/DPDK/dpdk > > > > The log is so much verbose that I am not able to understand what > > > > is really wrong. > > > > Please help to diagnose and fix, thanks.

Re: [dpdk-dev] [PATCH v1 58/58] doc: add Marvell OCTEON TX2 ethdev documentation

2019-06-06 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, June 6, 2019 10:20 PM > To: Jerin Jacob Kollanukkaran ; dev@dpdk.org; Thomas > Monjalon ; John McNamara > ; Marko Kovacevic > ; Nithin Kumar Dabilpuram > ; Kiran Kumar Kokkilagadda > ; Vamsi Krishna Attunuru > > Subject: Re: [dpd

[dpdk-dev] [PATCH 2/2] doc: add the description for option pflink_fullchk in ixgbevf

2019-06-06 Thread Haiyue Wang
Add the detail description for this pflink_fullchk option, when it will be used, and it is used for fixing what kind of issue. Signed-off-by: Haiyue Wang --- doc/guides/nics/ixgbe.rst | 18 ++ 1 file changed, 18 insertions(+) diff --git a/doc/guides/nics/ixgbe.rst b/doc/guides/n

[dpdk-dev] [PATCH v1 2/2] doc: add the description for option pflink_fullchk in ixgbevf

2019-06-06 Thread Haiyue Wang
Add the detail description for this pflink_fullchk option, when it will be used, and it is used for fixing what kind of issue. Signed-off-by: Haiyue Wang --- doc/guides/nics/ixgbe.rst | 18 ++ 1 file changed, 18 insertions(+) diff --git a/doc/guides/nics/ixgbe.rst b/doc/guides/n

[dpdk-dev] [PATCH 1/2] net/ixgbevf: add an option pflink_fullchk to get link status quickly

2019-06-06 Thread Haiyue Wang
In some scenario, if the PF's running status is stopped, the VF link status can be detected as down by checking the mailbox status. This fully checking will introduce mailbox interrupt in PF, and it will be bad if many VFs are running and the application is checking the VF's link status quickly (wa

[dpdk-dev] [PATCH v1 1/2] net/ixgbevf: add an option pflink_fullchk to get link status quickly

2019-06-06 Thread Haiyue Wang
In some scenario, if the PF's running status is stopped, the VF link status can be detected as down by checking the mailbox status. This fully checking will introduce mailbox interrupt in PF, and it will be bad if many VFs are running and the application is checking the VF's link status quickly (wa

[dpdk-dev] [PATCH] vfio: retry creating sPAPR DMA window

2019-06-06 Thread Takeshi Yoshimura
sPAPR allows only page_shift from VFIO_IOMMU_SPAPR_TCE_GET_INFO ioctl. However, Linux 4.17 or before returns incorrect page_shift for Power9. I added the code for retrying creation of sPAPR DMA window. Signed-off-by: Takeshi Yoshimura --- lib/librte_eal/linux/eal/eal_vfio.c | 26

Re: [dpdk-dev] rte_eth_dev_count() returns 0 with ENA device

2019-06-06 Thread Reeve Yang
some followup ... I debugged more, it looks like rte_pci_probe is not happening, so the rte_eth_dev_allocate is not called at all ..., buy why is that? I ran testpmd, it shows no probed ethernet device. # /opt/bluecoat/sslv/bin/testpmd testpmd -n 2 -l 2-3 -w :00:04.0 -m 256 -- -i EAL: Detected

Re: [dpdk-dev] [PATCH] net/i40e: uninitialized value fixed in i40e_flow_parse_fdir_action

2019-06-06 Thread Zhang, Qi Z
> -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Friday, June 7, 2019 3:58 AM > To: Ergin, Mesut A ; Xing, Beilei > ; Zhang, Qi Z > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/i40e: uninitialized value fixed in > i40e_flow_parse_fdir_action > >

Re: [dpdk-dev] [PATCH] pktgen: enable RSS on versions of DPDK after 18.05

2019-06-06 Thread Wiles, Keith
> On Jun 6, 2019, at 4:45 PM, David Christensen wrote: > > When backwards compatibility was added for earlier releases of DPDK, > default enablement of RSS was lost for versions of DPDK after 18.05. > This change restores the old behavior and enables RSS by default. > > Fixes: ae81c62f194c ("

[dpdk-dev] [PATCH] pktgen: enable RSS on versions of DPDK after 18.05

2019-06-06 Thread David Christensen
When backwards compatibility was added for earlier releases of DPDK, default enablement of RSS was lost for versions of DPDK after 18.05. This change restores the old behavior and enables RSS by default. Fixes: ae81c62f194c ("backward compat to 18.02 at least") Cc: keith.wi...@intel.com Signed-of

[dpdk-dev] rte_eth_dev_count() returns 0 with ENA device

2019-06-06 Thread Reeve Yang
Hi Gurus, I'm trying to bring VM under Amzaon EC2 R4.16xlarge instance, so the ethernet device is uising Amazon ENA driver. The kernel is 3.10, dpdk is 18.02. All ether device are bound successfully, but for some reason, the DPDK data path cannot be initialized because rte_eth_dev_count() always r

Re: [dpdk-dev] [PATCH] net/i40e: uninitialized value fixed in i40e_flow_parse_fdir_action

2019-06-06 Thread Kevin Traynor
On 06/06/2019 17:30, Mesut Ali Ergin wrote: > Initializes mark_spec pointer to NULL. > > Fixes: 0bbcfc706a2b ("net/i40e: support MARK and RSS flow action") > Coverity issue: 341075 > > Signed-off-by: Mesut Ali Ergin Acked-by: Kevin Traynor > --- > drivers/net/i40e/i40e_flow.c | 2 +- > 1 fil

Re: [dpdk-dev] [PATCH v1 1/2] lib/ring: add enqueue-dequeue callabck

2019-06-06 Thread Stephen Hemminger
On Fri, 7 Jun 2019 00:03:54 +0530 Vipin Varghese wrote: > Add callback event handler for enqueue dequeue operation on ring. > The pre-enqueue and post-dequeue operation on ring is selected to > invoke user callback handler. > > Signed-off-by: Vipin Varghese > --- NAK What is the use case for

[dpdk-dev] [PATCH v1 2/2] examples/packet_ordering: add ring callback

2019-06-06 Thread Vipin Varghese
update example with ring register-unregister for enqueue-dequeue callabck. Signed-off-by: Vipin Varghese --- examples/packet_ordering/Makefile| 1 + examples/packet_ordering/main.c | 40 examples/packet_ordering/meson.build | 1 + 3 files changed, 42 inser

Re: [dpdk-dev] [RFC 2/3] ethdev: add flow modify mark action

2019-06-06 Thread Yongseok Koh
> On Jun 6, 2019, at 3:35 AM, Jerin Jacob Kollanukkaran > wrote: > >> -Original Message- >> From: dev On Behalf Of Yongseok Koh >> Sent: Tuesday, June 4, 2019 3:03 AM >> To: shah...@mellanox.com; tho...@monjalon.net; ferruh.yi...@intel.com; >> arybche...@solarflare.com; adrien.mazarg.

[dpdk-dev] [PATCH v1 1/2] lib/ring: add enqueue-dequeue callabck

2019-06-06 Thread Vipin Varghese
Add callback event handler for enqueue dequeue operation on ring. The pre-enqueue and post-dequeue operation on ring is selected to invoke user callback handler. Signed-off-by: Vipin Varghese --- config/common_base | 1 + lib/librte_ring/Makefile | 1 + lib/libr

[dpdk-dev] Incorrect install_dir for Linux kernel modules

2019-06-06 Thread Igor Ryzhov
Hi everyone, I faced an issue today with install directory for rte_kni and igb_uio. Modules are installed to '/usr/src/...' instead of '/lib/modules/...'. Right now install_dir for both modules is set to: install_dir: kernel_dir + '/../extra/dpdk' where 'kernel_dir' is set manually or automatic

[dpdk-dev] [PATCH v1] lib/bpf: add event callback for bpf

2019-06-06 Thread Vipin Varghese
The patch series adds bpf load-unload to event pre-enqueue and post-dequeue stages. Signed-off-by: Vipin Varghese --- lib/librte_bpf/bpf_event.c | 432 + lib/librte_bpf/rte_bpf_eventdev.h | 117 lib/librte_bpf/rte_bpf_version.map | 4 + 3 files cha

[dpdk-dev] [PATCH v1 2/2] examples/event: add callback handle

2019-06-06 Thread Vipin Varghese
To add register and unregister for event pre-enqueue and post-dequeue callback handler. Signed-off-by: Vipin Varghese --- examples/eventdev_pipeline/main.c | 49 +++ 1 file changed, 49 insertions(+) diff --git a/examples/eventdev_pipeline/main.c b/examples/eventdev_

[dpdk-dev] [PATCH v1 1/2] lib/event: add callback handlers for event

2019-06-06 Thread Vipin Varghese
Add callback event handler for enqueue dequeue operation on event device. The pre-enqueue and post-dequeue are the selected to invoke user callback handler. Signed-off-by: Vipin Varghese --- config/common_base | 1 + lib/librte_eventdev/rte_eventdev.c | 361

[dpdk-dev] [PATCH v1 0/2] event enqueue-dequeue callback handler

2019-06-06 Thread Vipin Varghese
The patch series is an attempt to add callback handlers to event device. Motivation == Allow user to debug and modify the event list in event device enqueue-dequeue stages. The enqueue stage is modified to allow user handler to be invoked prior to actual device enqueue. The dequeue stage

[dpdk-dev] [PATCH 2/2] net/sfc: add Rx interrupts support for ef10 datapath

2019-06-06 Thread Andrew Rybchenko
From: Georgiy Levashov Similar to support for efx datapath, Rx interrupt disabling just avoids rearming the next time. Signed-off-by: Georgiy Levashov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ef10.h| 12 +++ drivers/net/sfc/sfc_ef10_rx.c | 48 +++

[dpdk-dev] [PATCH 1/2] net/sfc: add Rx interrupts support for efx datapath

2019-06-06 Thread Andrew Rybchenko
From: Georgiy Levashov When Rx interrupts are disabled, we simply disable rearm when the interrupt fires the next time. So, the next packet will trigger interrupt (if it is not happened yet after previous Rx burst processing). Signed-off-by: Georgiy Levashov Signed-off-by: Andrew Rybchenko ---

[dpdk-dev] [PATCH v3 3/3] baseband/turbo_sw: meson build support for PMD driver

2019-06-06 Thread Nicolas Chautru
Signed-off-by: Nicolas Chautru --- drivers/baseband/meson.build | 2 +- drivers/baseband/turbo_sw/meson.build | 30 ++ 2 files changed, 31 insertions(+), 1 deletion(-) create mode 100644 drivers/baseband/turbo_sw/meson.build diff --git a/drivers/baseband/me

[dpdk-dev] [PATCH v3 2/3] docs/guides: updating turbo_sw building steps

2019-06-06 Thread Nicolas Chautru
The documentation is clarified to point to steps on building the SDK libraries which are now publicly available: https://software.intel.com/en-us/articles/flexran-lte-and-5g-nr-fec-software-development-kit-modules Signed-off-by: Nicolas Chautru --- doc/guides/bbdevs/turbo_sw.rst | 81 +++

[dpdk-dev] [PATCH v3 1/3] baseband/turbo_sw: option to build turbosw PMD without SDK

2019-06-06 Thread Nicolas Chautru
Adding compile flag to allow to build the turbo_sw PMD without dependency to have the SDK libraries installed. Signed-off-by: Nicolas Chautru --- config/common_base | 3 +- drivers/baseband/turbo_sw/Makefile | 13 drivers/baseband/turbo_sw/bb

[dpdk-dev] [PATCH v3 0/3] BBDEV turbo_sw PMD compilation fix

2019-06-06 Thread Nicolas Chautru
Update v3: Cosmetic changes in documentation commit to be more 4G/AVX2 specific. Update v2: Splitting into 3 patches as recommended (ignore previous v2 which had a typo) Based on discussion with maintainer, pushing first a patch to help maintenance of the baseband_turbo_sw which had been lacki

Re: [dpdk-dev] DPDK compilation on arm is failing in Travis

2019-06-06 Thread Michael Santana Francisco
On 6/6/19 10:57 AM, Jerin Jacob Kollanukkaran wrote: -Original Message- From: dev On Behalf Of Michael Santana Francisco Sent: Thursday, June 6, 2019 4:09 AM To: Honnappa Nagarahalli ; Aaron Conole ; tho...@monjalon.net Cc: Ruifeng Wang (Arm Technology China) ; Gavin Hu (Arm Technology C

Re: [dpdk-dev] [PATCH v2 2/3] docs/guides: updating turbo_sw building steps

2019-06-06 Thread Chautru, Nicolas
>-Original Message- >From: Yigit, Ferruh >Sent: Thursday, June 6, 2019 3:34 AM > >On 6/5/2019 9:10 PM, Nicolas Chautru wrote: >> The documentation is clarified to point to steps on building the SDK >> libraries which are now publicly available. >> > >I can see new SDK link is in the docu

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

2019-06-06 Thread Neil Horman
On Thu, Jun 06, 2019 at 04:23:26PM +, Jerin Jacob Kollanukkaran wrote: > > -Original Message- > > From: Neil Horman > > Sent: Thursday, June 6, 2019 8:57 PM > > To: Jerin Jacob Kollanukkaran > > Cc: Bruce Richardson ; dev@dpdk.org; > > Thomas Monjalon > > Subject: Re: [EXT] [RFC PATC

Re: [dpdk-dev] [PATCH 1/2] net/sfc: advertise offload caps directly by Rx datapaths

2019-06-06 Thread Ferruh Yigit
On 6/1/2019 9:42 AM, Andrew Rybchenko wrote: > Rx datapath feature bits were useful on migration from the old offload API > to the new one. However, right now it just adds indirection which > complicates code reading and understanding. Also addition of a new > offloads requires addition of a new fe

Re: [dpdk-dev] [PATCH v1 58/58] doc: add Marvell OCTEON TX2 ethdev documentation

2019-06-06 Thread Ferruh Yigit
On 6/2/2019 4:24 PM, jer...@marvell.com wrote: > From: Jerin Jacob > > Add Marvell OCTEON TX2 ethdev documentation. > > This patch also updates the MAINTAINERS file and > shared library versions in release_19_08.rst. > > Cc: John McNamara > Cc: Thomas Monjalon > > Signed-off-by: Jerin Jacob

Re: [dpdk-dev] [EXT] Re: [PATCH v1 01/58] net/octeontx2: add build infrastructure

2019-06-06 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, June 6, 2019 9:03 PM > To: Jerin Jacob Kollanukkaran ; dev@dpdk.org; Thomas > Monjalon ; John McNamara > ; Marko Kovacevic > ; Nithin Kumar Dabilpuram > ; Kiran Kumar Kokkilagadda > > Cc: Pavan Nikhilesh Bhagavatula > Subject: [

Re: [dpdk-dev] [PATCH v2 3/3] baseband/fpga_lte_fec: meson support

2019-06-06 Thread Chautru, Nicolas
>-Original Message- >From: Yigit, Ferruh >Sent: Thursday, June 6, 2019 3:16 AM > >On 6/6/2019 9:25 AM, Bruce Richardson wrote: >> On Wed, Jun 05, 2019 at 02:21:00PM -0700, Nicolas Chautru wrote: >>> Adding support for meson build environment for the new BBDEV PMD >>> driver. >>> >>> Signe

[dpdk-dev] [PATCH] net/i40e: uninitialized value fixed in i40e_flow_parse_fdir_action

2019-06-06 Thread Mesut Ali Ergin
Initializes mark_spec pointer to NULL. Fixes: 0bbcfc706a2b ("net/i40e: support MARK and RSS flow action") Coverity issue: 341075 Signed-off-by: Mesut Ali Ergin --- drivers/net/i40e/i40e_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_flow.c b/dri

Re: [dpdk-dev] [EXT] Re: [PATCH v1 09/58] net/octeontx2: add context debug utils

2019-06-06 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, June 6, 2019 9:49 PM > To: Jerin Jacob Kollanukkaran ; dev@dpdk.org; Nithin > Kumar Dabilpuram ; Kiran Kumar Kokkilagadda > > Cc: Vivek Kumar Sharma > Subject: Re: [EXT] Re: [dpdk-dev] [PATCH v1 09/58] net/octeontx2: add > conte

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

2019-06-06 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Neil Horman > Sent: Thursday, June 6, 2019 8:57 PM > To: Jerin Jacob Kollanukkaran > Cc: Bruce Richardson ; dev@dpdk.org; > Thomas Monjalon > Subject: Re: [EXT] [RFC PATCH 0/2] introduce __rte_internal tag > > On Thu, Jun 06, 2019 at 03:14:42PM +, Jerin

Re: [dpdk-dev] [PATCH v1 56/58] net/octeontx2: add device stop and close operations

2019-06-06 Thread Ferruh Yigit
On 6/2/2019 4:24 PM, jer...@marvell.com wrote: > From: Nithin Dabilpuram > > Add device stop, close and reset operations. > > Signed-off-by: Nithin Dabilpuram > Signed-off-by: Vamsi Attunuru <...> > @@ -1792,6 +1844,24 @@ otx2_eth_dev_uninit(struct rte_eth_dev *eth_dev, bool > mbox_close) >

Re: [dpdk-dev] [PATCH v1 25/58] net/octeontx2: add ptype support

2019-06-06 Thread Ferruh Yigit
On 6/6/2019 4:59 PM, Jerin Jacob Kollanukkaran wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: Thursday, June 6, 2019 9:20 PM >> To: Jerin Jacob Kollanukkaran ; dev@dpdk.org; John >> McNamara ; Marko Kovacevic >> ; Nithin Kumar Dabilpuram >> ; Kiran Kumar Kokkilagadda >>

Re: [dpdk-dev] [EXT] Re: [PATCH v1 09/58] net/octeontx2: add context debug utils

2019-06-06 Thread Ferruh Yigit
On 6/6/2019 5:04 PM, Jerin Jacob Kollanukkaran wrote: >> -Original Message- >> From: Ferruh Yigit >> Sent: Thursday, June 6, 2019 9:12 PM >> To: Jerin Jacob Kollanukkaran ; dev@dpdk.org; Nithin >> Kumar Dabilpuram ; Kiran Kumar Kokkilagadda >> >> Cc: Vivek Kumar Sharma >> Subject: [EXT]

[dpdk-dev] [PATCH v3] baseband/fpga_lte_fec: adding driver for FEC on FPGA

2019-06-06 Thread Nicolas Chautru
Supports for FEC 4G PMD Driver on FPGA card PAC N3000 Signed-off-by: Nicolas Chautru --- config/common_base |6 + doc/guides/bbdevs/fpga_lte_fec.rst | 318 +++ doc/guides/bbdevs/index.rst|1 + drivers/baseband/Makef

[dpdk-dev] [PATCH v3] baseband/fpga_lte_fec: adding driver for FEC on FPGA

2019-06-06 Thread Nicolas Chautru
Update since v2 : Squashing 3 previous patches into one as recommended. This is adding a new PMD driver for BBDEV device based on FPGA implementation on PAC N3000 HW to provide FEC 4G acceleration. v1 was shared earlier on this patchwork : https://patches.dpdk.org/patch/53409/ The existing BBD

[dpdk-dev] [PATCH] net/netvsc: initialize vf spinlock

2019-06-06 Thread Stephen Hemminger
The VF spinlock was never initialized. It works because it is in zmalloc'd memory and an unlocked lock on x86 is 0. But for good practice, all spinlock's should be initialized. Fixes: dc7680e8597c ("net/netvsc: support integrated VF") Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_et

Re: [dpdk-dev] [PATCH v1 48/58] net/octeontx2: add FW version get operation

2019-06-06 Thread Ferruh Yigit
On 6/2/2019 4:24 PM, jer...@marvell.com wrote: > From: Vamsi Attunuru > > Add firmware version get operation. > > Signed-off-by: Vamsi Attunuru <...> > @@ -209,6 +209,28 @@ otx2_nix_tx_done_cleanup(void *txq, uint32_t free_cnt) > return 0; > } > > +int > +otx2_nix_fw_version_get(stru

Re: [dpdk-dev] [EXT] Re: [PATCH v1 09/58] net/octeontx2: add context debug utils

2019-06-06 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, June 6, 2019 9:12 PM > To: Jerin Jacob Kollanukkaran ; dev@dpdk.org; Nithin > Kumar Dabilpuram ; Kiran Kumar Kokkilagadda > > Cc: Vivek Kumar Sharma > Subject: [EXT] Re: [dpdk-dev] [PATCH v1 09/58] net/octeontx2: add context > d

Re: [dpdk-dev] [PATCH v1 25/58] net/octeontx2: add ptype support

2019-06-06 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, June 6, 2019 9:20 PM > To: Jerin Jacob Kollanukkaran ; dev@dpdk.org; John > McNamara ; Marko Kovacevic > ; Nithin Kumar Dabilpuram > ; Kiran Kumar Kokkilagadda > > Cc: Harman Kalra > Subject: Re: [dpdk-dev] [PATCH v1 25/58] ne

Re: [dpdk-dev] [PATCH] acl: fix build issue with some arm64 compiler

2019-06-06 Thread Michael Santana Francisco
On 6/6/19 10:50 AM, jer...@marvell.com wrote: From: Jerin Jacob Some compilers reporting the following error, though the existing code doesn't have any uninitialized variable case. Just to make compiler happy, initialize the int32x4_t variable one shot in C language. ../lib/librte_acl/acl_run_

Re: [dpdk-dev] [PATCH v1 25/58] net/octeontx2: add ptype support

2019-06-06 Thread Ferruh Yigit
On 6/2/2019 4:24 PM, jer...@marvell.com wrote: > From: Jerin Jacob > > The fields from CQE needs to be converted to > ptype and rx ol flags in mbuf. This patch adds > create lookup memory for those items to be > used in Fastpath. > > Signed-off-by: Jerin Jacob > Signed-off-by: Kiran Kumar K >

Re: [dpdk-dev] [PATCH v1 09/58] net/octeontx2: add context debug utils

2019-06-06 Thread Ferruh Yigit
On 6/2/2019 4:23 PM, jer...@marvell.com wrote: > From: Jerin Jacob > > Add RQ,SQ,CQ context and CQE structure dump utils. > > Signed-off-by: Jerin Jacob > Signed-off-by: Vivek Sharma <...> > @@ -23,6 +23,9 @@ nix_lf_err_irq(void *param) > > /* Clear interrupt */ > otx2_write64(

[dpdk-dev] [PATCH] kernel/freebsd: fix module build on latest head

2019-06-06 Thread Bruce Richardson
Internal changes in the freebsd kernel have meant that additional includes are now necessary to build the kernel modules for DPDK. Tested with latest bsd HEAD revision. Bugzilla ID: 282 Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- kernel/freebsd/contigmem/contigmem.c | 3 +++ kernel/

Re: [dpdk-dev] [PATCH v1 01/58] net/octeontx2: add build infrastructure

2019-06-06 Thread Ferruh Yigit
On 6/2/2019 4:23 PM, jer...@marvell.com wrote: > From: Jerin Jacob > > Adding bare minimum PMD library and doc build infrastructure. > > Signed-off-by: Jerin Jacob > Signed-off-by: Kiran Kumar K > Signed-off-by: Pavan Nikhilesh > --- > config/common_base| 5 +++ >

[dpdk-dev] [PATCH 4/4] net/enic: remove locks from rte flow code

2019-06-06 Thread Hyong Youb Kim
From: John Daley There is no requirement for thread safety in the flow PMD code and no need for the locks. Fixes: 6ced137607d0 ("net/enic: flow API for NICs with advanced filters enabled") Cc: sta...@dpdk.org Signed-off-by: John Daley Reviewed-by: Hyong Youb Kim --- drivers/net/enic/enic.h

[dpdk-dev] [PATCH 3/4] net/enic: remove support for flow count action

2019-06-06 Thread Hyong Youb Kim
From: John Daley The firmware in 1400 series VIC adapters which would support COUNT flow action was postponed and reworked. The capability will be re-added in a future release when the firmware is available. This reverts the following commits. commit 86df6c4e2fce ("net/enic: support flow counter

[dpdk-dev] [PATCH 2/4] net/enic: report speed capabilities

2019-06-06 Thread Hyong Youb Kim
Available link speeds are based on VIC adapter model, which is encoded in PCI subsystem device ID. Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- doc/guides/nics/features/enic.ini | 1 + drivers/net/enic/enic_ethdev.c| 51 +++ 2 files changed,

[dpdk-dev] [PATCH 1/4] net/enic: set min and max MTU

2019-06-06 Thread Hyong Youb Kim
These values correspond to those used in the MTU handler (enic_set_mtu). Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/enic_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c index 80fbf595e

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

2019-06-06 Thread Neil Horman
On Thu, Jun 06, 2019 at 03:14:42PM +, Jerin Jacob Kollanukkaran wrote: > > > I don't have any strong opinion on name prefix vs marking as __rte_internal. > Or combination of both. I am fine any approach. > > I have only strong option on not to induce objdump dependency for > checkpatch. >

[dpdk-dev] [PATCH 0/4] net/enic: minor updates

2019-06-06 Thread Hyong Youb Kim
The first two patches report the min/max MTU and speed capabilities to support applications that rely on them. The other two patches remove unnecessary/unsupported code from the flow implementation. We do not expect more patches for 19.08. Hyong Youb Kim (2): net/enic: set min and max MTU net/

Re: [dpdk-dev] [PATCH v1 00/58] OCTEON TX2 Ethdev driver

2019-06-06 Thread Ferruh Yigit
On 6/2/2019 4:23 PM, jer...@marvell.com wrote: > From: Jerin Jacob > > This patchset adds support for OCTEON TX2 ethdev driver. > > This patch set is depended on "OCTEON TX2 common and mempool driver" series. > http://mails.dpdk.org/archives/dev/2019-June/133329.html Hi Jerin, I will wait for

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

2019-06-06 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Neil Horman > Sent: Thursday, June 6, 2019 8:34 PM > To: Jerin Jacob Kollanukkaran > Cc: Bruce Richardson ; dev@dpdk.org; > Thomas Monjalon > Subject: Re: [EXT] [RFC PATCH 0/2] introduce __rte_internal tag > > On Thu, Jun 06, 2019 at 02:02:03PM +, Jerin

Re: [dpdk-dev] [DPDK v2] net/ipn3ke: modifications on AFU configurations

2019-06-06 Thread Ferruh Yigit
On 5/30/2019 3:58 PM, Dan Wei wrote: > Modify AFU configurations for new Blue Bitstream of A10 on N3000 card: > - AFU register access: RTL changes the UPL base address and the read/write > commands of register indirect access. > - Add delays to wait for the HW reset completion. > - Refine log for d

Re: [dpdk-dev] [PATCH] ethdev: add a check on mempool during rxq setup

2019-06-06 Thread Ferruh Yigit
On 6/5/2019 5:46 PM, Andrew Rybchenko wrote: > On 5/17/19 11:15 AM, David Marchand wrote: >> We currently have no check on the mempool pointer passed to >> rte_eth_rx_queue_setup. >> Let's avoid a plain crash when dereferencing it. >> >> Suggested-by: Jens Freimann >> Signed-off-by: David Marchand

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

2019-06-06 Thread Neil Horman
On Thu, Jun 06, 2019 at 02:02:03PM +, Jerin Jacob Kollanukkaran wrote: > > -Original Message- > > From: Neil Horman > > Sent: Thursday, June 6, 2019 7:05 PM > > To: Jerin Jacob Kollanukkaran > > Cc: Bruce Richardson ; dev@dpdk.org; > > Thomas Monjalon > > Subject: Re: [EXT] [RFC PATC

Re: [dpdk-dev] DPDK compilation on arm is failing in Travis

2019-06-06 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: dev On Behalf Of Michael Santana > Francisco > Sent: Thursday, June 6, 2019 4:09 AM > To: Honnappa Nagarahalli ; Aaron Conole > ; tho...@monjalon.net > Cc: Ruifeng Wang (Arm Technology China) ; Gavin > Hu (Arm Technology China) ; Dharmik Thakkar > ; jerin.ja...

Re: [dpdk-dev] [PATCH] net/ena: update Rx checksum errors on Rx path

2019-06-06 Thread Ferruh Yigit
On 5/28/2019 9:28 AM, Michal Krawczyk wrote: > Rx checksum flags and input errors shouldn't be updated on Tx, as it > would work only for packets forwarding. > > The ierrors statistic should be updated on Rx, right after checking > Rx checksum flags if the Rx checksum offload is enabled. > > Sign

Re: [dpdk-dev] DPDK compilation on arm is failing in Travis

2019-06-06 Thread Aaron Conole
Honnappa Nagarahalli writes: > > > > > From: Michael Santana Francisco > Sent: Wednesday, June 5, 2019 5:39 PM > To: Honnappa Nagarahalli ; Aaron Conole > ; tho...@monjalon.net > Cc: Ruifeng Wang (Arm Technology China) ; Gavin Hu (Arm > Technology > China) ; Dharmik Thakkar ; > jerin.ja...

[dpdk-dev] [PATCH] acl: fix build issue with some arm64 compiler

2019-06-06 Thread jerinj
From: Jerin Jacob Some compilers reporting the following error, though the existing code doesn't have any uninitialized variable case. Just to make compiler happy, initialize the int32x4_t variable one shot in C language. ../lib/librte_acl/acl_run_neon.h: In function 'search_neon_4' ../lib/librt

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

2019-06-06 Thread Neil Horman
On Thu, Jun 06, 2019 at 01:53:47PM +, Wiles, Keith wrote: > > > > On Jun 6, 2019, at 8:43 AM, Neil Horman wrote: > > > > On Thu, Jun 06, 2019 at 01:18:29PM +, Wiles, Keith wrote: > >> > >> > >>> On Jun 6, 2019, at 7:04 AM, Jerin Jacob Kollanukkaran > >>> wrote: > >>> > -Or

Re: [dpdk-dev] [PATCH v3] ipsec: include high order bytes of esn in pkt len

2019-06-06 Thread Ananyev, Konstantin
> -Original Message- > From: Lukasz Bartosik [mailto:lbarto...@marvell.com] > Sent: Wednesday, June 5, 2019 4:31 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org; ano...@marvell.com; Lukasz Bartosik > Subject: [PATCH v3] ipsec: include high order bytes of esn in pkt len > > When esn is

Re: [dpdk-dev] [PATCH] net/ena: fix counting of per-queue number of Tx pkts

2019-06-06 Thread Ferruh Yigit
On 5/14/2019 12:11 PM, Rafal Kozik wrote: > Instead of counting number of used NIC Tx bufs just count number > of Tx packets. > > Fixes: 45b6d86184fc ("net/ena: add per-queue software counters stats") > Cc: sta...@dpdk.org > > Signed-off-by: Rafal Kozik > Acked-by: Michal Krawczyk Applied to d

[dpdk-dev] [PATCH] net/mlx5: fix check for rte calloc return value

2019-06-06 Thread Asaf Penso
rte_calloc functions returns a non-null pointer in case of success and null pointer in case of failure. The return value should be checked and the function flow should take that into consideration. This patch adds a check for rte_calloc return value in function flow_list_create. Fixes: 84c406e7

Re: [dpdk-dev] [PATCH] kni: remove PCI related information

2019-06-06 Thread Ferruh Yigit
On 6/6/2019 2:26 PM, Igor Ryzhov wrote: > As there is no ethtool support in KNI anymore, > PCI related information is no longer needed. > > Signed-off-by: Igor Ryzhov Fixes: ea6b39b5b847 ("kni: remove ethtool support") Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v12] net/memif: introduce memory interface (memif) PMD

2019-06-06 Thread Ferruh Yigit
On 6/6/2019 12:38 PM, Jakub Grajciar wrote: > Shared memory packet interface (memif) PMD allows for DPDK and any other > client using memif (DPDK, VPP, libmemif) to communicate using shared > memory. The created device transmits packets in a raw format. It can be > used with Ethernet mode, IP mode,

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

2019-06-06 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Neil Horman > Sent: Thursday, June 6, 2019 7:05 PM > To: Jerin Jacob Kollanukkaran > Cc: Bruce Richardson ; dev@dpdk.org; > Thomas Monjalon > Subject: Re: [EXT] [RFC PATCH 0/2] introduce __rte_internal tag > > On Thu, Jun 06, 2019 at 12:04:57PM +, Jerin

[dpdk-dev] DPDK Release Status Meeting 6/6/2019

2019-06-06 Thread Ferruh Yigit
Minutes 6 June 2019 --- Agenda: * Release Dates * Subtrees * OvS * Conferences * Opens Participants: * Debian/Microsoft * Intel * Marvell * NXP * Red Hat Release Dates - * v19.08 dates: * Proposal deadline passed, it was on 3 June * Integration/Merge/RC1 Mo

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

2019-06-06 Thread Wiles, Keith
> On Jun 6, 2019, at 8:43 AM, Neil Horman wrote: > > On Thu, Jun 06, 2019 at 01:18:29PM +, Wiles, Keith wrote: >> >> >>> On Jun 6, 2019, at 7:04 AM, Jerin Jacob Kollanukkaran >>> wrote: >>> -Original Message- From: Neil Horman Sent: Thursday, June 6, 2019 5:04

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

2019-06-06 Thread Neil Horman
On Thu, Jun 06, 2019 at 01:18:29PM +, Wiles, Keith wrote: > > > > On Jun 6, 2019, at 7:04 AM, Jerin Jacob Kollanukkaran > > wrote: > > > >> -Original Message- > >> From: Neil Horman > >> Sent: Thursday, June 6, 2019 5:04 PM > >> To: Jerin Jacob Kollanukkaran > >> Cc: Bruce Richar

Re: [dpdk-dev] [PATCH v1 3/3] test/mcslock: add mcs queued lock unit test

2019-06-06 Thread Ananyev, Konstantin
Hi, > > Unit test and perf test for MCS queued lock. Perf test is important of course, but first I think we need more robust functional test to make sure that lock does work properly. At least something like ticketlock test but probably with bigger number of iterations. 10K seems quite small he

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

2019-06-06 Thread Neil Horman
On Thu, Jun 06, 2019 at 12:04:57PM +, Jerin Jacob Kollanukkaran wrote: > > -Original Message- > > From: Neil Horman > > Sent: Thursday, June 6, 2019 5:04 PM > > To: Jerin Jacob Kollanukkaran > > Cc: Bruce Richardson ; dev@dpdk.org; > > Thomas Monjalon > > Subject: Re: [EXT] [RFC PATC

[dpdk-dev] [PATCH] kni: remove PCI related information

2019-06-06 Thread Igor Ryzhov
As there is no ethtool support in KNI anymore, PCI related information is no longer needed. Signed-off-by: Igor Ryzhov --- kernel/linux/kni/kni_dev.h| 3 --- kernel/linux/kni/kni_misc.c | 6 -- lib/librte_eal/linux/eal/include/rte_kni_common.h |

Re: [dpdk-dev] [PATCH 3/8] raw/ioat: add register definition file

2019-06-06 Thread Bruce Richardson
On Thu, May 30, 2019 at 04:53:05PM -0700, Stephen Hemminger wrote: > On Thu, 30 May 2019 22:25:20 +0100 > Bruce Richardson wrote: > > > + > > +#ifdef __cplusplus > > +extern "C" { > > +#endif > > + > > This a driver private file, why the C++ guard here? It's not just a private file, it's includ

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

2019-06-06 Thread Wiles, Keith
> On Jun 6, 2019, at 7:04 AM, Jerin Jacob Kollanukkaran > wrote: > >> -Original Message- >> From: Neil Horman >> Sent: Thursday, June 6, 2019 5:04 PM >> To: Jerin Jacob Kollanukkaran >> Cc: Bruce Richardson ; dev@dpdk.org; >> Thomas Monjalon >> Subject: Re: [EXT] [RFC PATCH 0/2] in

[dpdk-dev] [PATCH] net/mlx5: fix master device Netlink socket sharing

2019-06-06 Thread Viacheslav Ovsiienko
There is the patch [1] that uses master device Netlink socket to retrieve master device link settings. This is not thread safe because this resource may be in use by other call to the master device itself. Using the same Netlink socket concurrently from the multiple threads causes Netlink requests

Re: [dpdk-dev] [PATCH] net/af_xdp: fix failure on rte_dev_remove

2019-06-06 Thread David Marchand
Ferruh, On Wed, Jun 5, 2019 at 5:30 PM Ferruh Yigit wrote: > On 6/1/2019 5:13 PM, Ye Xiaolong wrote: > > On 05/31, William Tu wrote: > >> When users call rte_eth_dev_close() and rte_dev_remove(), the af_xdp > >> pmd return -1 (EPERM) due to eth_dev == NULL. > >> > >> Since the af_xdp pmd driver

Re: [dpdk-dev] [PATCH] [RFC] ethdev: support flow aging

2019-06-06 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Matan Azrad > Sent: Thursday, June 6, 2019 4:22 PM > To: Jerin Jacob Kollanukkaran ; Adrien Mazarguil > ; dev@dpdk.org > Subject: [EXT] RE: [PATCH] [RFC] ethdev: support flow aging > > Hi Jerin Hi Matan, > > From: Jerin Jacob > > > -Original Message

Re: [dpdk-dev] [EXT] [RFC PATCH 0/2] introduce __rte_internal tag

2019-06-06 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Neil Horman > Sent: Thursday, June 6, 2019 5:04 PM > To: Jerin Jacob Kollanukkaran > Cc: Bruce Richardson ; dev@dpdk.org; > Thomas Monjalon > Subject: Re: [EXT] [RFC PATCH 0/2] introduce __rte_internal tag > > On Thu, Jun 06, 2019 at 09:44:52AM +, Jerin

[dpdk-dev] [PATCH v6] doc: add meson ut info in prog guide

2019-06-06 Thread Hari Kumar Vemula
Add a programmer's guide section for meson ut Signed-off-by: Hari Kumar Vemula Acked-by: Bruce Richardson --- v6: Updated comments v5: Modified v4: Typos corrected v3: Modified v2: Removed enhancement details --- doc/guides/prog_guide/index.rst| 1 + doc/guides/prog_guide/meson_ut.rst | 1

[dpdk-dev] [PATCH v2 5/5] doc: update ipsec-secgw guide

2019-06-06 Thread Konstantin Ananyev
Update ipsec-secgw guide to reflect latest changes: support packets fragmentation/reassembly and related new command-line options. Signed-off-by: Konstantin Ananyev --- doc/guides/sample_app_ug/ipsec_secgw.rst | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --

[dpdk-dev] [PATCH v2 1/5] examples/ipsec-secgw: fix invalid packet length

2019-06-06 Thread Konstantin Ananyev
for packets smaller then 64B some NICs reports pkt_len=64B. As ipsec-secgw (and librte_ipsec) relies on pkt_len value to determine payload length, that causes problems for small packets. To fix the issue, check that pkt_len matches values in IPv4/IPv6 header and re-adjust pkt_len if necessary. Fix

[dpdk-dev] [PATCH v2 4/5] examples/ipsec-secgw: add bypass test case

2019-06-06 Thread Konstantin Ananyev
Add simple test-case with all traffic in BYPASS mode. Useful for some basic test of your network environment. Signed-off-by: Konstantin Ananyev --- examples/ipsec-secgw/test/bypass_defs.sh | 45 1 file changed, 45 insertions(+) create mode 100644 examples/ipsec-secgw/te

[dpdk-dev] [PATCH v2 2/5] examples/ipsec-secgw: support packet fragmentation and reassembly

2019-06-06 Thread Konstantin Ananyev
Add optional ability to fragment packet bigger then mtu, and reassemble fragmented packet. To minimize possible performance effect, reassembly is implemented as RX callback. To support these features ipsec-secgw relies on librte_ipsec ability to handle multi-segment packets. Also when reassemble/fr

[dpdk-dev] [PATCH v2 3/5] examples/ipsec-secgw: add multi-segment test cases

2019-06-06 Thread Konstantin Ananyev
Enhance test scripts to support fragmentation/reassemble functionality. Signed-off-by: Konstantin Ananyev --- examples/ipsec-secgw/test/common_defs.sh | 18 +++--- examples/ipsec-secgw/test/data_rxtx.sh | 18 ++ examples/ipsec-secgw/test/linux_test4.sh | 17

  1   2   >