On Thu, Jun 06, 2019 at 05:23:12PM +0100, Ferruh Yigit wrote:
> On 6/2/2019 4:24 PM, jer...@marvell.com wrote:
> > From: Nithin Dabilpuram <ndabilpu...@marvell.com>
> >
> > Add device stop, close and reset operations.
> >
> > Signed-off-by: Nithin Dabilpuram <ndabilpu...@marvell.com>
> > Signed-off-by: Vamsi Attunuru <vattun...@marvell.com>
>
> <...>
>
> > @@ -1792,6 +1844,24 @@ otx2_eth_dev_uninit(struct rte_eth_dev *eth_dev,
> > bool mbox_close)
> > return 0;
> > }
> >
> > +static void
> > +otx2_nix_dev_close(struct rte_eth_dev *eth_dev)
> > +{
> > + otx2_eth_dev_uninit(eth_dev, true);
> > +}
>
> 'close' should free all PMD resources, with 'RTE_ETH_DEV_CLOSE_REMOVE' flag
> ethdev API can free the ethdev level allocated memory itself.
>
Agreed, we are adhering to the spec and handling close with
RTE_ETH_DEV_CLOSE_REMOVE flag
behavior where close cannot return error and even rte_eth_dev will itself be
freed.
Do you see any issue ?
>
>
