On Thu, May 30, 2019 at 04:53:05PM -0700, Stephen Hemminger wrote:
> On Thu, 30 May 2019 22:25:20 +0100
> Bruce Richardson <bruce.richard...@intel.com> wrote:
>
> > +
> > +#ifdef __cplusplus
> > +extern "C" {
> > +#endif
> > +
>
> This a driver private file, why the C++ guard here?
It's not just a private file, it's included in the regular driver .h file,
as the inline functions there need access to the register definitions.
As for whether the functions need to be inline, most of them are inline for
performance reasons, and the one that I would consider suitable for moving
to the driver is inline also so that the user does not need to link their
application against the PMD in order to use the device. Having the header
at compile-time, and then the driver loaded at runtime is sufficient.
/Bruce
