> -----Original Message----- > From: Ferruh Yigit <[email protected]> > Sent: Thursday, June 6, 2019 9:12 PM > To: Jerin Jacob Kollanukkaran <[email protected]>; [email protected]; Nithin > Kumar Dabilpuram <[email protected]>; Kiran Kumar Kokkilagadda > <[email protected]> > Cc: Vivek Kumar Sharma <[email protected]> > Subject: [EXT] Re: [dpdk-dev] [PATCH v1 09/58] net/octeontx2: add context > debug utils > On 6/2/2019 4:23 PM, [email protected] wrote: > > From: Jerin Jacob <[email protected]> > > > > Add RQ,SQ,CQ context and CQE structure dump utils. > > > > Signed-off-by: Jerin Jacob <[email protected]> > > Signed-off-by: Vivek Sharma <[email protected]> > > <...> > > > @@ -23,6 +23,9 @@ nix_lf_err_irq(void *param) > > > > /* Clear interrupt */ > > otx2_write64(intr, dev->base + NIX_LF_ERR_INT); > > + > > + otx2_nix_queues_ctx_dump(eth_dev); > > + rte_panic("nix_lf_error_interrupt\n"); > > } > > > > static int > > @@ -75,6 +78,9 @@ nix_lf_ras_irq(void *param) > > > > /* Clear interrupt */ > > otx2_write64(intr, dev->base + NIX_LF_RAS); > > + > > + otx2_nix_queues_ctx_dump(eth_dev); > > + rte_panic("nix_lf_ras_interrupt\n"); > > } > > > > static int > > @@ -232,6 +238,9 @@ nix_lf_q_irq(void *param) > > > > /* Clear interrupt */ > > otx2_write64(intr, dev->base + NIX_LF_QINTX_INT(qintx)); > > + > > + otx2_nix_queues_ctx_dump(eth_dev); > > + rte_panic("nix_lf_q_interrupt\n"); > > rte_panic() is not allowed in the PMDs, please remove them.
It an error interrupt handler ie. fatal error and driver can not proceed. Should I call abort() or simply return ? I think, we can treat this as a special case for rte_panic() if it is in error interrupt handler. Thoughts? > > > } > > > > int > >
