Hi, Markus
On 04/23, Markus Theil wrote:
>Hi Xiaolong,
>
>I tested your commit "net/af_xdp: fix creating multiple instance" on the
>current master branch. It does not work for me in the following minimal
>test setting:
>
>1) allocate 2x 1GB huge pages for DPDK
>
>2) ip link add p1 type veth peer n
> -Original Message-
> From: Ananyev, Konstantin
> Sent: Tuesday, April 23, 2019 7:35 PM
> To: Akhil Goyal ; Iremonger, Bernard
> ; dev@dpdk.org
> Cc: sta...@dpdk.org
> Subject: RE: [PATCH v4 1/2] examples/ipsec-secgw: fix 1st packet dropped for
> inline crypto
>
>
>
> > >
> > > >
>
> On 18/04/2019 11:28, Bruce Richardson wrote:
> > On Thu, Apr 18, 2019 at 04:34:53AM +, Honnappa Nagarahalli wrote:
> >>>
> >>> On Wed, Apr 17, 2019 at 05:12:43AM +, Honnappa Nagarahalli
> wrote:
> Hello,
> There was a conversation [1] in the context of RCU library. I
> tho
> > > On Wed, Apr 17, 2019 at 05:12:43AM +, Honnappa Nagarahalli
> wrote:
> > > > Hello,
> > > > There was a conversation [1] in the context of RCU library. I
> > > > thought it needs participation from broader audience. Summary for
> > > > the context (please look at [1] for full detai
Hi,
> -Original Message-
> From: dev On Behalf Of Pavan Nikhilesh
> Bhagavatula
> Sent: Tuesday, April 23, 2019 17:13
> To: tho...@monjalon.net
> Cc: dev@dpdk.org; jer...@marvell.com; Marko Kovacevic
> ; Ori Kam ; Bruce
> Richardson ; Pablo de Lara
> ; Radu Nicolau ;
> akhil.go...@nxp.com
Fix the issues reported by Coverity check, "Null-checking
vsi suggests that it may be null, but it has already been
dereferenced on all paths leading to the check."
Coverity issue: 328509
Coverity issue: 328519
Coverity issue: 328523
Fixes: e0dcf94a0d7f ("net/ice: support VLAN ops")
Fixes: ff963bf
Fix the potential overflow in expression 1 << begin by using 1ULL.
Coverity issue: 279437, 279445
Fixes: c73a9071877a ("app/testpmd: add commands to test new offload API")
Cc: sta...@dpdk.org
Signed-off-by: Tiwei Bie
---
app/test-pmd/cmdline.c | 4 ++--
1 file changed, 2 insertions(+), 2 deleti
Hi Ferruh,
> -Original Message-
> From: Yigit, Ferruh
> Sent: Tuesday, April 23, 2019 6:40 PM
> To: Lu, Wenzhuo ; dev@dpdk.org
> Cc: sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/ice: fix coverity issues
>
> On 4/18/2019 2:31 AM, Wenzhuo Lu wrote:
> > Fix the issues reported by Co
Signed-off-by: Peng Huang
---
devtools/validate-abi.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/devtools/validate-abi.sh b/devtools/validate-abi.sh
index 54df2e4..138436d 100755
--- a/devtools/validate-abi.sh
+++ b/devtools/validate-abi.sh
@@ -9,7 +9,7 @@ set -e
abiche
Hi,
I saw Qiang's patch on patchwork today,
[v3] drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr
So I think it seems OK to ignore my patch.
-Original Message-
From: Thomas Monjalon [mailto:tho...@monjalon.net]
Sent: Tuesday, April 23, 2019 4:45 PM
To: Pei, Andy
Cc: Xu, Rosen ; s
ibv_destroy_flow_action() refers to QP. QP must not be freed until
corresponding action is destroyed.
Fixes: 3eb004431072 ("net/mlx5: fix release of jump to queue action")
Cc: or...@mellanox.com
Signed-off-by: Yongseok Koh
---
drivers/net/mlx5/mlx5_rxq.c | 8
1 file changed, 4 insertio
Attendees:
(Present)
Thomas (tho...@monjalon.net)
Harini (harini.ramakrish...@microsoft.com)
Bruce (bruce.richard...@intel.com)
Cathal (cathal.oh...@intel.com)
Anand (anand.ra...@intel.com)
Pallavi (pallavi.ka...@intel.com)
Ranjit (ranjit.me...@intel.com)
Eilon (eil...@mellanox.com)
Raslan (rasl
On Tue, 23 Apr 2019 23:06:40 +0100
Bruce Richardson wrote:
> As part of the meson build, a pkg-config file for libdpdk is created, which
> allows apps to be compiled and linked against DPDK by taking the cflags and
> lib parameter from pkgconfig. The example app makefiles have been reworked
> to
If libbsd is enabled in DPDK, the strlcpy and strlcat functions in
rte_string_fns.h redirect to the varients in libbsd, only using the
fallbacks if it is not enabled. Therefore, if libbsd is enabled, it needs
to be called out as a DPDK dependency in the pkgconfig file.
To ensure that we don't have
The pkg-config file generated as part of the build of DPDK should allow
applications to be built with an installed DPDK. We can test this as
part of the build by doing an install of DPDK to a temporary directory
within the build folder, and by then compiling up a few sample apps
using make working
Using find rather than shelling out to a one-liner script is easier to
read and understand, as well as allowing shorter lines in the code.
Signed-off-by: Bruce Richardson
---
examples/meson.build | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/examples/meson.build b/exam
As part of the meson build, a pkg-config file for libdpdk is created, which
allows apps to be compiled and linked against DPDK by taking the cflags and
lib parameter from pkgconfig. The example app makefiles have been reworked
to take account of this support, but the build of them against the .pc f
When we install dpdk onto a system, we want to put the examples into
the /usr/share/dpdk (or /usr/local/share/dpdk) directory for reference.
Signed-off-by: Bruce Richardson
---
examples/meson.build | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/examples/mes
>
> On Mon, Apr 22, 2019 at 11:31:28PM -0500, Honnappa Nagarahalli wrote:
> > Add RCU library supporting quiescent state based memory reclamation
> method.
> > This library helps identify the quiescent state of the reader threads
> > so that the writers can free the memory associated with the lock
On Tue, Apr 23, 2019 at 11:19:16AM +, Ori Kam wrote:
> When creating a flow rule without the port_id pattern item, always the
> PF was selected.
>
> This commit fixes this issue, if no port_id pattern item is available
> then we use the port that the flow was created on as source port.
>
> Fi
> On Apr 23, 2019, at 10:43 AM, Herakliusz Lipiec
> wrote:
>
> When sending synchronous IPC requests, the caller must free the response
> buffer even if the request returned failure. Fix the code to correctly
> use the IPC API.
>
> Bugzilla ID:228
> Fixes: 0b259b8e9655 ("net/mlx4: enable se
> On Apr 23, 2019, at 10:43 AM, Herakliusz Lipiec
> wrote:
>
> When sending synchronous IPC requests, the caller must free the response
> buffer even if the request returned failure. Fix the code to correctly
> use the IPC API.
>
> Bugzilla ID:228
> Fixes: 9a8ab29b84d3 ("net/mlx5: replace I
> On Apr 23, 2019, at 1:09 AM, Burakov, Anatoly
> wrote:
>
> On 22-Apr-19 6:51 PM, Yongseok Koh wrote:
>>> On Apr 17, 2019, at 7:44 AM, Herakliusz Lipiec
>>> wrote:
>>>
>>> When sending multiple requests, rte_mp_request_sync
>>> can succeed sending a few of those requests, but then
>>> fail
Added documentation for Windows support on 19.05 release.
Signed-off-by: Pallavi Kadam
Reviewed-by: Anand Rawat
Reviewed-by: Ranjit Menon
---
doc/guides/rel_notes/release_19_05.rst | 4
1 file changed, 4 insertions(+)
diff --git a/doc/guides/rel_notes/release_19_05.rst
b/doc/guides/rel_
When sending synchronous IPC requests, the caller must free the response
buffer even if the request returned failure. Fix the code to correctly
use the IPC API.
Bugzilla ID:228
Fixes: 9a8ab29b84d3 ("net/mlx5: replace IPC socket with EAL API")
Fixes: c18cf501a7af ("net/mlx5: enable secondary proc
When sending synchronous IPC requests, the caller must free the response
buffer even if the request returned failure. Fix the code to correctly
use the IPC API.
Bugzilla ID:228
Fixes: 0b259b8e9655 ("net/mlx4: enable secondary process to register DMA
memory")
Cc: ys...@mellanox.com
Signed-off-by
When sending synchronous IPC requests, the caller must free the response
buffer even if the request returned failure. Fix the code to correctly
use the IPC API.
Bugzilla ID: 228
Fixes: c9aa56edec8e ("net/tap: access primary process queues from secondary")
Cc: rasl...@mellanox.com
Cc: sta...@dpdk
When sending synchronous IPC requests, the caller must free the response
buffer even if the request returned failure. Fix the code to correctly
use the IPC API.
Bugzilla ID: 228
Fixes: 660098d61f57 ("pdump: use generic multi-process channel")
Cc: jianfeng@intel.com
Cc: sta...@dpdk.org
Signed
When sending synchronous IPC requests, the caller must free the response
buffer even if the request returned failure. Fix the code to correctly
use the IPC API.
Bugzilla ID: 228
Fixes: cdb068f031c6 ("bus/vdev: scan by multi-process channel")
Cc: jianfeng@intel.com
Cc: sta...@dpdk.org
Signed-
When sending synchronous IPC requests, the caller must free the response
buffer even if the request returned failure. Fix the code to correctly
use the IPC API.
Bugzilla ID: 228
Fixes: 83a73c5fef66 ("vfio: use generic multi-process channel")
Cc: jianfeng@intel.com
Cc: sta...@dpdk.org
Signed-
When sending synchronous IPC requests, the caller must free the response
buffer even if the request returned failure. Fix the code to correctly
use the IPC API.
Bugzilla ID: 228
Fixes: ac9e4a17370f ("eal: support attach/detach shared device from secondary")
Cc: qi.z.zh...@intel.com
Cc: sta...@dp
When sending multiple requests, rte_mp_request_sync
can succeed sending a few of those requests, but then
fail on a later one and in the end return with rc=-1.
The upper layers - e.g. device hotplug - currently
handles this case as if no messages were sent and no
memory for response buffers was all
When sending multiple requests, rte_mp_request_sync
can succeed sending a few of those requests, but then
fail on a later one and in the end return with rc=-1.
The upper layers - e.g. device hotplug - currently
handles this case as if no messages were sent and no
memory for response buffers was all
On 2019-04-23 17:31, Stephen Hemminger wrote:
On Mon, 22 Apr 2019 19:44:39 +0200
Mattias Rönnblom wrote:
On 2019-04-22 17:52, Mattias Rönnblom wrote:
On 2019-04-22 13:34, Neil Horman wrote:
+uint64_t __rte_experimental
+rte_rand(void)
Do you really want to mark this as experimental? I
On 2019-04-23 13:33, Neil Horman wrote:
On Mon, Apr 22, 2019 at 07:44:39PM +0200, Mattias Rönnblom wrote:
On 2019-04-22 17:52, Mattias Rönnblom wrote:
On 2019-04-22 13:34, Neil Horman wrote:
+uint64_t __rte_experimental
+rte_rand(void)
Do you really want to mark this as experimental? I know
The ring name is passed in as part of this drivers API, but it
doesn't check that the name is not truncated.
Signed-off-by: Stephen Hemminger
---
v2 - fix whitespace creep
drivers/net/ring/rte_eth_ring.c | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/driv
Use rte_calloc_socket instead of computing size.
Signed-off-by: Stephen Hemminger
---
drivers/net/ring/rte_eth_ring.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
index 2e4ca3b16a1c..0355f2b7c4d8 100
Don't hard code string length in two place; use sizeof() instead.
Ring name shoudl use RTE_RING_NAMESIZE.
Signed-off-by: Stephen Hemminger
---
drivers/net/ring/rte_eth_ring.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/ne
Minor fixes and cleanups for the net/ring driver.
Stephen Hemminger (4):
net/ring: fix coding style
net/ring: use sizeof() with snprintf
net/ring: use rte_calloc_socket
net/ring: check length of ring name
drivers/net/ring/rte_eth_ring.c | 90 -
1 file chan
Whitespace fixes to bring inline with current DPDK style.
Signed-off-by: Stephen Hemminger
---
v2 - fix signoff line
drivers/net/ring/rte_eth_ring.c | 58 ++---
1 file changed, 32 insertions(+), 26 deletions(-)
diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/
Use rte_calloc_socket instead of computing size.
Signed-off-by: Stephen Hemminger
---
drivers/net/ring/rte_eth_ring.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
index 2e4ca3b16a1c..0355f2b7c4d8 100
The ring name is passed in as part of this drivers API, but it
doesn't check that the name is not truncated.
Signed-off-by: Stephen Hemminger
---
drivers/net/ring/rte_eth_ring.c | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ring/rte_eth_ring.c
Don't hard code string length in two place; use sizeof() instead.
Ring name shoudl use RTE_RING_NAMESIZE.
Signed-off-by: Stephen Hemminger
---
drivers/net/ring/rte_eth_ring.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/ne
Whitespace fixes to bring inline with current DPDK style.
Signed-off-by: Stephen Hemminger
---
drivers/net/ring/rte_eth_ring.c | 58 ++---
1 file changed, 32 insertions(+), 26 deletions(-)
diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
Minor fixes for the net/ring driver.
Stephen Hemminger (4):
net/ring: fix coding style
net/ring: use sizeof() with snprintf
net/ring: use rte_calloc_socket
net/ring: check length of ring name
drivers/net/ring/rte_eth_ring.c | 90 -
1 file changed, 55 inser
Tested by Ju-Hyoung Lee. All Rx packets are missing.
[LISAv2 Test Results Summary]
Test Run On : 04/23/2019 10:56:54
ARM Image Under Test : Canonical : UbuntuServer : 18.04-LTS : latest
Total Test Cases : 8 (0 Passed, 6 Failed, 2 Aborted, 0 Skipped)
Total Time (dd:hh:mm) : 0:4:57
On 4/22/2019 3:42 PM, Thomas Monjalon wrote:
10/04/2019 23:00, Pallavi Kadam:
Added documentation for Windows support on 19.05 release.
Signed-off-by: Pallavi Kadam
Reviewed-by: Anand Rawat
---
+* **Added Windows Support.**
+
+ * Added Windows support to compile and build Hello World Sampl
Hi Xiaolong,
I tested your commit "net/af_xdp: fix creating multiple instance" on the
current master branch. It does not work for me in the following minimal
test setting:
1) allocate 2x 1GB huge pages for DPDK
2) ip link add p1 type veth peer name p2
3) ./dpdk-testpmd --vdev=net_af_xdp0,iface=
On 4/23/2019 4:44 PM, Andrew Rybchenko wrote:
> On 4/23/19 6:04 PM, Ferruh Yigit wrote:
>> On 4/23/2019 4:02 PM, Ferruh Yigit wrote:
>>> On 4/12/2019 2:12 PM, Andrew Rybchenko wrote:
Setting exact link speed makes sense if auto-negotiation is
disabled. Fixed flag is required to disable au
On Tue, Apr 23, 2019 at 04:31:00PM +0100, Ferruh Yigit wrote:
> 'rte_eth_dev_get_port_by_name()' return value is not checked caught by
> coverity, adding return value check.
>
> Coverity issue: 305853
> Fixes: 96cb19521147 ("net/ring: use EAL APIs in PMD specific API")
> Cc: sta...@dpdk.org
>
> S
On 4/23/19 6:04 PM, Ferruh Yigit wrote:
On 4/23/2019 4:02 PM, Ferruh Yigit wrote:
On 4/12/2019 2:12 PM, Andrew Rybchenko wrote:
Setting exact link speed makes sense if auto-negotiation is
disabled. Fixed flag is required to disable auto-negotiation.
Hi Andrew,
Fixed link speed is not supporte
The version check for the IPSec_MB library present in the aesni_gcm
library's meson.build file is a little cleaner than that given here,
so update this one so that both work identically.
While one could use the checks done in the other right now, potentially in
future they may have different versi
The aesni_mb driver has a check in its Makefile for the correct version of
the IPsec_MB library, but this check was missed for the aesni_gcm driver.
Add this check to the makefile, removing an unnecessary assignment in the
process.
Suggested-by: Pablo de Lara
Signed-off-by: Bruce Richardson
---
The aesni_mb driver and the aesni_gcm driver both require the same version
of the IPSec_MB library, but only the former has a check of the library
found by meson to see if it's the correct version. Add a similar check to
the aesni_gcm library's meson.build file, so that the auto-detection of
depend
For both meson and make builds, the version checks for IPsec_MB library
were incomplete. This fixes both and makes the checks consistent.
Bruce Richardson (3):
crypto/aesni_gcm: add dependency version check
crypto/aesni_mb: cleanup of version check code
crypto/aesni_gcm: add check for build
'rte_kni_release()' return value is not checked, adding it.
Coverity issue: 336837
Fixes: 75e2bc54c018 ("net/kni: add KNI PMD")
Cc: sta...@dpdk.org
Signed-off-by: Ferruh Yigit
---
drivers/net/kni/rte_eth_kni.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/k
include rte_crypto_sym.h in asym header file.
Signed-off-by: Ayuj Verma
Signed-off-by: Shally Verma
---
lib/librte_cryptodev/rte_crypto_asym.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_cryptodev/rte_crypto_asym.h
b/lib/librte_cryptodev/rte_crypto_asym.h
index 5e43620..a5
include rte_crypto_sym.h in asym header file.
Changes in v2:
- Change commit summary from “fix alphabetical ordering of headers”
to better reflect intent of change. Previous patch set version
http://mails.dpdk.org/archives/dev/2019-April/130010.html .
- revert change in rte_crypto.h
Ayuj Ve
On Mon, 22 Apr 2019 19:44:39 +0200
Mattias Rönnblom wrote:
> On 2019-04-22 17:52, Mattias Rönnblom wrote:
> > On 2019-04-22 13:34, Neil Horman wrote:
> >
> >>> +uint64_t __rte_experimental
> >>> +rte_rand(void)
> >> Do you really want to mark this as experimental? I know it will
> >> trigg
'rte_eth_dev_get_port_by_name()' return value is not checked caught by
coverity, adding return value check.
Coverity issue: 305853
Fixes: 96cb19521147 ("net/ring: use EAL APIs in PMD specific API")
Cc: sta...@dpdk.org
Signed-off-by: Ferruh Yigit
---
drivers/net/ring/rte_eth_ring.c | 6 +-
1
Hello,
I am currently working on a patch to fix the eal_flags_autotest test as
it currently fails on many platforms.
I have made some progress, however I stumbled upon a possible issue with
EAL and hugepages.
Looking at the code and some documentation it appears to me that
hupepages are suppos
On 4/23/2019 4:02 PM, Ferruh Yigit wrote:
> On 4/12/2019 2:12 PM, Andrew Rybchenko wrote:
>> Setting exact link speed makes sense if auto-negotiation is
>> disabled. Fixed flag is required to disable auto-negotiation.
>
> Hi Andrew,
>
> Fixed link speed is not supported by all PMDs and this chang
On 4/12/2019 2:12 PM, Andrew Rybchenko wrote:
> Setting exact link speed makes sense if auto-negotiation is
> disabled. Fixed flag is required to disable auto-negotiation.
Hi Andrew,
Fixed link speed is not supported by all PMDs and this change is breaking them
to set the speed in testpmd.
As lo
On Tue, Apr 23, 2019 at 03:38:58PM +0100, De Lara Guarch, Pablo wrote:
>
>
> > -Original Message-
> > From: Richardson, Bruce
> > Sent: Friday, April 19, 2019 11:01 AM
> > To: dev@dpdk.org
> > Cc: De Lara Guarch, Pablo ; Doherty,
> > Declan ; Richardson, Bruce
> >
> > Subject: [PATCH 1/2
> -Original Message-
> From: Richardson, Bruce
> Sent: Friday, April 19, 2019 11:01 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo ; Doherty,
> Declan ; Richardson, Bruce
>
> Subject: [PATCH 1/2] crypto/aesni_gcm: add dependency version check
>
> The aesni_mb driver and the aesni_gc
> -Original Message-
> From: Richardson, Bruce
> Sent: Friday, April 19, 2019 11:01 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo ; Doherty,
> Declan ; Richardson, Bruce
>
> Subject: [PATCH 2/2] crypto/aesni_mb: cleanup of version check code
>
> The version check for the IPSec_MB l
On 18/04/2019 06:56, Jerin Jacob Kollanukkaran wrote:
>
>> -Original Message-
>> From: Stephen Hemminger
>> Sent: Thursday, April 18, 2019 12:21 AM
>> To: Jerin Jacob Kollanukkaran
>> Cc: Bruce Richardson ; Honnappa Nagarahalli
>> ; dev@dpdk.org; Ananyev, Konstantin
>> ; tho...@monjal
On 4/23/2019 2:51 PM, Agalya Babu RadhaKrishnan wrote:
> Added some missing help info for interactive mode commands
>
> Fixes: 6673fe0ce2 ("app/testpmd: add TM commands to mark packets")
> Fixes: c73a907187 ("app/testpmd: add commands to test new offload API")
> Fixes: e977e4199a ("app/testpmd: ad
On 17/04/2019 19:51, Stephen Hemminger wrote:
> On Wed, 17 Apr 2019 17:46:34 +
> Jerin Jacob Kollanukkaran wrote:
>
>>> -Original Message-
>>> From: dev On Behalf Of Bruce Richardson
>>> Sent: Wednesday, April 17, 2019 2:07 PM
>>> To: Honnappa Nagarahalli
>>> Cc: dev@dpdk.org; St
On 18/04/2019 11:28, Bruce Richardson wrote:
> On Thu, Apr 18, 2019 at 04:34:53AM +, Honnappa Nagarahalli wrote:
>>>
>>> On Wed, Apr 17, 2019 at 05:12:43AM +, Honnappa Nagarahalli wrote:
Hello,
There was a conversation [1] in the context of RCU library. I thought
it nee
> >
> > >
> > > > -Original Message-
> > > > From: Akhil Goyal
> > > > Sent: Thursday, April 18, 2019 7:21 PM
> > > > To: Bernard Iremonger ; dev@dpdk.org;
> > > > konstantin.anan...@intel.com
> > > > Cc: sta...@dpdk.org
> > > > Subject: RE: [PATCH v4 1/2] examples/ipsec-secgw: fix 1st p
Added some missing help info for interactive mode commands
Fixes: 6673fe0ce2 ("app/testpmd: add TM commands to mark packets")
Fixes: c73a907187 ("app/testpmd: add commands to test new offload API")
Fixes: e977e4199a ("app/testpmd: add commands to load/unload BPF filters")
Fixes: c18feafa19 ("app/t
Hi Konstantin,
> Hi Akhil,
>
> >
> > > -Original Message-
> > > From: Akhil Goyal
> > > Sent: Thursday, April 18, 2019 7:21 PM
> > > To: Bernard Iremonger ; dev@dpdk.org;
> > > konstantin.anan...@intel.com
> > > Cc: sta...@dpdk.org
> > > Subject: RE: [PATCH v4 1/2] examples/ipsec-secgw: f
Hi Akhil,
>
> > -Original Message-
> > From: Akhil Goyal
> > Sent: Thursday, April 18, 2019 7:21 PM
> > To: Bernard Iremonger ; dev@dpdk.org;
> > konstantin.anan...@intel.com
> > Cc: sta...@dpdk.org
> > Subject: RE: [PATCH v4 1/2] examples/ipsec-secgw: fix 1st packet dropped for
> > inlin
>
> Acked-by: Konstantin Ananyev
>
Applied to dpdk-next-crypto
> -Original Message-
> From: Zhang, Roy Fan
> Sent: Friday, April 5, 2019 12:10 AM
> To: Ananyev, Konstantin ; dev@dpdk.org
> Cc: Akhil Goyal ; Ananyev, Konstantin
> ; sta...@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix SPD no-match is
> misinterpreted
>
>
>
> -Original Message-
> From: Akhil Goyal [mailto:akhil.go...@nxp.com]
> Sent: Tuesday, April 23, 2019 1:20 PM
> To: dev@dpdk.org
> Cc: Nicolau, Radu ; Ananyev, Konstantin
> ; Akhil Goyal ;
> Zhang, Roy Fan ; sta...@dpdk.org
> Subject: [PATCH v2] examples/ipsec-secgw: fix pool usage for
Currently, two separate mempools are being used for creating crypto
sessions and its private data.
crypto sessions are created and initialized separately, so a separate
mempool is passed to each API, but in case of security sessions, where
only one API create and initialize the private data as well
>
>
> Looks good to me , but seems incomplete.
> I think we also need to:
> static int32_t
> cryptodevs_init(void)
> {
>...
>
> /* create session pools for eth devices that implement security */
> RTE_ETH_FOREACH_DEV(port_id) {
> if ((enabled_port_mask & (1 <<
Hi Akhil,
> Currently, two separate mempools are being used for creating crypto
> sessions and its private data.
> crypto sessions are created and initialized separately, so a separate
> mempool is passed to each API, but in case of security sessions, where
> only one API create and initialize the
On 4/23/2019 11:44 AM, Agalya Babu RadhaKrishnan wrote:
> Added some missing documentation for interactive mode commands
>
> Fixes: 01b2092a5e ("testpmd: add dump commands for debug")
> Fixes: caf05a1b86 ("app/testpmd: new command to dump log types")
> Fixes: 0f62d63593ed ("app/testpmd: support tu
On 4/23/2019 9:14 AM, Andrew Rybchenko wrote:
> From: Igor Romanov
>
> Rx queue setup function checks configured MTU to make sure that
> no oversized packets can be received. But a following call to
> set MTU function might make this check irrelevant.
>
> Add a function to check MTU size against
On Mon, Apr 22, 2019 at 07:44:39PM +0200, Mattias Rönnblom wrote:
> On 2019-04-22 17:52, Mattias Rönnblom wrote:
> > On 2019-04-22 13:34, Neil Horman wrote:
> >
> > > > +uint64_t __rte_experimental
> > > > +rte_rand(void)
> > > Do you really want to mark this as experimental? I know it will
> > >
When creating a flow rule without the port_id pattern item, always the
PF was selected.
This commit fixes this issue, if no port_id pattern item is available
then we use the port that the flow was created on as source port.
Fixes: 822fb3195348 ("net/mlx5: add port id item to Direct Verbs")
Signe
Hi Bernard,
> -Original Message-
> From: Akhil Goyal
> Sent: Thursday, April 18, 2019 7:21 PM
> To: Bernard Iremonger ; dev@dpdk.org;
> konstantin.anan...@intel.com
> Cc: sta...@dpdk.org
> Subject: RE: [PATCH v4 1/2] examples/ipsec-secgw: fix 1st packet dropped for
> inline crypto
>
> Hi
On 23/04/2019 06:50, Nikhil Rao wrote:
> Add the experimental tag back to the Rx event adapter callback
> and the Rx event callback register functions. This patch also
You should add an explanation why in the commit message. It is an
unusual thing to do and the other mail thread would be too hard
On 4/22/2019 3:18 AM, Qiming Yang wrote:
> stats_reset has been missed when support stats in iavf driver.
> This patch add statistics reset function.
>
> Fixes: f4a41a6953af ("net/avf: support stats")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Qiming Yang
<...>
> @@ -977,16 +979,71 @@ iavf_dev_s
Added some missing documentation for interactive mode commands
Fixes: 01b2092a5e ("testpmd: add dump commands for debug")
Fixes: caf05a1b86 ("app/testpmd: new command to dump log types")
Fixes: 0f62d63593ed ("app/testpmd: support tunneled TSO in checksum engine")
Fixes: 8fff667578a7
("app/
On 23/04/2019 11:31, Hunt, David wrote:
> Hi Kevin,
>
> On 23/4/2019 11:26 AM, Kevin Traynor wrote:
>> On 18/04/2019 16:14, Pattan, Reshma wrote:
Fixes: d26c18c93260 ("examples/vm_power: cpu frequency in host")
Coverity issue: 337660
>>> Candidate for sta...@dpdk.org?
>> There is n
On 4/18/2019 2:31 AM, Wenzhuo Lu wrote:
> Fix the issues reported by Coverity check, "Null-checking
> vsi suggests that it may be null, but it has already been
> dereferenced on all paths leading to the check."
Hi Wenzhuo,
Can you please list the coverity issues addressed, the format we have is:
Hi Kevin,
On 23/4/2019 11:26 AM, Kevin Traynor wrote:
On 18/04/2019 16:14, Pattan, Reshma wrote:
Fixes: d26c18c93260 ("examples/vm_power: cpu frequency in host")
Coverity issue: 337660
Candidate for sta...@dpdk.org?
There is no reply to this comment - re-asking as I will probably have
t
On 18/04/2019 16:14, Pattan, Reshma wrote:
>> Fixes: d26c18c93260 ("examples/vm_power: cpu frequency in host")
>> Coverity issue: 337660
> Candidate for sta...@dpdk.org?
There is no reply to this comment - re-asking as I will probably have
the same question in a few weeks :-)
>-Original Message-
>From: dev On Behalf Of Thomas Monjalon
>Sent: Tuesday, April 23, 2019 2:05 PM
>To: Pavan Nikhilesh Bhagavatula
>Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Marko
>Kovacevic ; Ori Kam ;
>Bruce Richardson ; Pablo de Lara
>; Radu Nicolau ;
>Akhil Goyal ; Tomasz Kant
On 22-Apr-19 5:39 AM, kirankum...@marvell.com wrote:
From: Kiran Kumar K
With current KNI implementation kernel module will work only in
IOVA=PA mode. This patch will add support for kernel module to work
with IOVA=VA mode.
The idea is to get the physical address from iova address using
api io
The freqs array in freq_info struct has RTE_MAX_LCORE_FREQS elements,
yet the code can attempt to look at the index at RTE_MAX_LCORE,
which may be greater than RTE_MAX_LCORE_FREQS. Fix to limit index to
RTE_MAX_LCORE_FREQS.
Fixes: d26c18c93260 ("examples/vm_power: cpu frequency in host")
Cov
> -Original Message-
> From: Nikhil Rao
> Sent: Tuesday, April 23, 2019 11:20 AM
> To: tho...@monjalon.net
> Cc: dev@dpdk.org; Nikhil Rao ; Jerin Jacob Kollanukkaran
>
> Subject: [EXT] [PATCH] eventdev: add experimental tag back
>
> ---
When you need to re-send a patch, please apply it with "git am"
so the original author is kept.
Another nit: the title is full of abbreviation, it is hard to read.
The title prefix should be "raw/ifpga", even if checkpatch complains.
Please re-send, thanks.
23/04/2019 03:36, Xu, Rosen:
> Hi Tho
23/04/2019 04:47, Pavan Nikhilesh Bhagavatula:
>From: Thomas Monjalon
> >10/04/2019 09:29, Pavan Nikhilesh Bhagavatula:
> >> From: Pavan Nikhilesh
> >>
> >> Currently, l3wfd em mode has two datapath modes em_sequential and
> >> em_hlm. We can select either of them by defining
> >NO_HASH_MULTI_LOO
On 23/4/2019 9:33 AM, Thomas Monjalon wrote:
23/04/2019 10:21, Hunt, David:
Hi Thomas,
On 22/4/2019 10:54 PM, Thomas Monjalon wrote:
10/04/2019 14:49, David Hunt:
The freqs array in freq_info struct has RTE_MAX_LCORE_FREQS elements,
yet the code can attemtp to look at the index at POWER_MAN
23/04/2019 10:21, Hunt, David:
> Hi Thomas,
>
> On 22/4/2019 10:54 PM, Thomas Monjalon wrote:
> > 10/04/2019 14:49, David Hunt:
> >> The freqs array in freq_info struct has RTE_MAX_LCORE_FREQS elements,
> >> yet the code can attemtp to look at the index at POWER_MANAGER_MAX_CPUS,
> >> which may be
1 - 100 of 106 matches
Mail list logo
