When sending synchronous IPC requests, the caller must free the response 
buffer even if the request returned failure. Fix the code to correctly 
use the IPC API.

Bugzilla ID: 228
Fixes: ac9e4a17370f ("eal: support attach/detach shared device from secondary")
Cc: qi.z.zh...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Herakliusz Lipiec <herakliusz.lip...@intel.com>
---
 lib/librte_eal/common/hotplug_mp.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/librte_eal/common/hotplug_mp.c 
b/lib/librte_eal/common/hotplug_mp.c
index 4052a5c7f..2c8366afa 100644
--- a/lib/librte_eal/common/hotplug_mp.c
+++ b/lib/librte_eal/common/hotplug_mp.c
@@ -377,6 +377,7 @@ int eal_dev_hotplug_request_to_primary(struct 
eal_dev_mp_req *req)
        ret = rte_mp_request_sync(&mp_req, &mp_reply, &ts);
        if (ret || mp_reply.nb_received != 1) {
                RTE_LOG(ERR, EAL, "cannot send request to primary");
+               free(mp_reply.msgs);
                if (!ret)
                        return -1;
                return ret;
@@ -405,6 +406,7 @@ int eal_dev_hotplug_request_to_secondary(struct 
eal_dev_mp_req *req)
        ret = rte_mp_request_sync(&mp_req, &mp_reply, &ts);
        if (ret != 0) {
                RTE_LOG(ERR, EAL, "rte_mp_request_sync failed\n");
+               free(mp_reply.msgs);
                return ret;
        }
 
-- 
2.17.2

Reply via email to