On Mon, 22 Apr 2019 19:44:39 +0200 Mattias Rönnblom <mattias.ronnb...@ericsson.com> wrote:
> On 2019-04-22 17:52, Mattias Rönnblom wrote: > > On 2019-04-22 13:34, Neil Horman wrote: > > > >>> +uint64_t __rte_experimental > >>> +rte_rand(void) > >> Do you really want to mark this as experimental? I know it will > >> trigger the > >> symbol checker with a warning if you don't, but this function already > >> existed > >> previously and was accepted as part of the ABI. Given that the > >> prototype hasn't > >> changed, I think you just need to accept it as a non-experimental > >> function > >> > > > > I'll remove the experimental tag and move it into the 19_05 section > > (without suggesting it should go into 19.05). That maneuver seems not to > > trigger any build warnings/errors. > > > > OK, so that wasn't true. It does trigger a build error, courtesy of > buildtools/check-experimental-syms.sh. > > I can't see any obvious way around it. Ideas, anyone? Ignore the error, the build tool is not smart enough for this kind of change.
