Re: [dpdk-dev] [EXT] [PATCH 2/6] meson: change default cache line size for cortex-a72

2019-04-12 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Yongseok Koh > Sent: Saturday, April 13, 2019 4:55 AM > To: bruce.richard...@intel.com; Jerin Jacob Kollanukkaran > ; Pavan Nikhilesh Bhagavatula > ; shah...@mellanox.com > Cc: dev@dpdk.org; tho...@monjalon.net; gavin...@arm.com; > honnappa.nagaraha...@arm.c

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-12 Thread Jerin Jacob Kollanukkaran
> > > > +machine_args_cavium = [ > > > > + ['default', ['-march=armv8-a+crc+crypto','-mcpu=thunderx']], > > > > + ['native', ['-march=native']], > > > > + ['0xa1', ['-mcpu=thunderxt88'], flags_thunderx_extra], > > > > + ['0xa2', ['-mcpu=thunderxt81'], flags_thunderx_extra],

Re: [dpdk-dev] [EXT] [PATCH 1/6] meson: disable octeontx for buggy compilers on arm64

2019-04-12 Thread Pavan Nikhilesh Bhagavatula
Hi Yongseok, >-- >Disable octeontx for gcc 4.8.5 as compiler is emitting "internal compiler >error" >for aarch64 > >Fixes: bd77f2d64c44 ("event/octeontx: build with meson") >Fixes: 4f760550a093 ("mk: disable OcteonTx for buggy co

Re: [dpdk-dev] [PATCH v4 1/3] net/mlx5: prepare Direct Verbs for Direct Rule

2019-04-12 Thread Yongseok Koh
> On Apr 12, 2019, at 4:51 PM, dwilder wrote: > > I am seeing a build break when building on ubuntu 19.04 beta after this > commit (cbb66daa3). > > The build produces a number of the following errors. > > drivers/net/mlx5/mlx5_glue.c:194:2: error: implicit declaration of function > ‘free’ >

Re: [dpdk-dev] [PATCH v4 1/3] net/mlx5: prepare Direct Verbs for Direct Rule

2019-04-12 Thread dwilder
I am seeing a build break when building on ubuntu 19.04 beta after this commit (cbb66daa3). The build produces a number of the following errors. drivers/net/mlx5/mlx5_glue.c:194:2: error: implicit declaration of function ‘free’ drivers/net/mlx5/mlx5_glue.c:552:11: error: incompatible imp

[dpdk-dev] [PATCH 6/6] mk: disable armv8 crypto extension for Mellanox BlueField

2019-04-12 Thread Yongseok Koh
Mellanox BlueField has a variant which doesn't have armv8 crypto extension. If crypto enabled binary runs on such a pltform, rte_eal_init() fails. To have binary compatibility across multiple variants, it is disabled by default and can be enabled for crypto enabled parts. Signed-off-by: Yongseok K

[dpdk-dev] [PATCH 2/6] meson: change default cache line size for cortex-a72

2019-04-12 Thread Yongseok Koh
Per the email discussion [1], the default cache line size of armv8 cortex-a72 is changed to 64 bytes. [1] https://mails.dpdk.org/archives/dev/2019-January/123218.html Signed-off-by: Yongseok Koh --- config/arm/meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/co

[dpdk-dev] [PATCH 5/6] build: add option for armv8 crypto extension

2019-04-12 Thread Yongseok Koh
Per armv8 crypto extension support, make build always enable it by default as long as compiler supports the feature while meson build only enables it for 'default' machine of generic armv8 architecture. For example, specifying '-mcpu=cortex-a72' doesn't enable it but '+crypto' is required in order

[dpdk-dev] [PATCH 4/6] meson: add Mellanox BlueField cross-compile config

2019-04-12 Thread Yongseok Koh
Mellanox BlueField is armv8 CPU having cortex-a72. The implementor ID is 0x41 (arm) and the primary part number is 0xd08 (cortex-a72). Signed-off-by: Yongseok Koh --- config/arm/arm64_bluefield_linux_gcc | 16 1 file changed, 16 insertions(+) create mode 100644 config/arm/arm64

[dpdk-dev] [PATCH 3/6] net/mlx: fix library search in meson build

2019-04-12 Thread Yongseok Koh
If MLNX_OFED is installed, there's no .pc file installed for libraries and dependency() can't find libraries by pkg-config. By adding fallback of using cc.find_library(), libraries are properly located. Fixes: e30b4e566f47 ("build: improve dependency handling") Cc: bl...@debian.org Cc: sta...@dpdk

[dpdk-dev] [PATCH 0/6] build: fix build for arm64

2019-04-12 Thread Yongseok Koh
This patchset depends on "meson: add infra to support machine specific flags" [1] [1] http://patches.dpdk.org/patch/52606/ Yongseok Koh (6): meson: disable octeontx for buggy compilers on arm64 meson: change default cache line size for cortex-a72 net/mlx: fix library search in meson build

[dpdk-dev] [PATCH 1/6] meson: disable octeontx for buggy compilers on arm64

2019-04-12 Thread Yongseok Koh
Disable octeontx for gcc 4.8.5 as compiler is emitting "internal compiler error" for aarch64 Fixes: bd77f2d64c44 ("event/octeontx: build with meson") Fixes: 4f760550a093 ("mk: disable OcteonTx for buggy compilers") Fixes: f3af3e44a444 ("mk: disable OcteonTx for buggy compilers only on arm64") Cc:

Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-12 Thread Stephen Hemminger
On Fri, 12 Apr 2019 22:24:45 + Honnappa Nagarahalli wrote: > > > > On Fri, 12 Apr 2019 15:20:37 -0500 > > Honnappa Nagarahalli wrote: > > > > > Add RCU library supporting quiescent state based memory reclamation > > method. > > > This library helps identify the quiescent state of the

Re: [dpdk-dev] [PATCH] build: automatically create windows exports file

2019-04-12 Thread Anand Rawat
On 4/12/2019 1:29 AM, Bruce Richardson wrote: Rather than having a separate version.map file for linux/BSD and an exports definition file for windows for each library, generate the latter from the former automatically at build time. Signed-off-by: Bruce Richardson Acked-by: Anand Rawat -- A

Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-12 Thread Honnappa Nagarahalli
> > On Fri, 12 Apr 2019 15:20:37 -0500 > Honnappa Nagarahalli wrote: > > > Add RCU library supporting quiescent state based memory reclamation > method. > > This library helps identify the quiescent state of the reader threads > > so that the writers can free the memory associated with the lock

Re: [dpdk-dev] [PATCH v2] net/af_packet: fix vlan_insert corruption

2019-04-12 Thread Stephen Hemminger
On Fri, 12 Apr 2019 17:28:17 +0100 Ferruh Yigit wrote: > On 4/8/2019 5:41 PM, Stephen Hemminger wrote: > > If the af_packet transmit is sending a VLAN packet, > > and the transmit path to the kernel os full, then it would > > mismanage the outgoing mbuf. The original mbuf would end up > > being f

Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-12 Thread Stephen Hemminger
On Fri, 12 Apr 2019 15:20:37 -0500 Honnappa Nagarahalli wrote: > Add RCU library supporting quiescent state based memory reclamation method. > This library helps identify the quiescent state of the reader threads so > that the writers can free the memory associated with the lock less data > struc

Re: [dpdk-dev] [PATCH] ethdev: missing typecast from void in eth_dev_pci_specific_init

2019-04-12 Thread Stephen Hemminger
On Fri, 12 Apr 2019 18:29:46 +0100 Ferruh Yigit wrote: > On 4/12/2019 6:25 PM, Ferruh Yigit wrote: > > On 4/12/2019 6:15 PM, Ananyev, Konstantin wrote: > >> > >> > >>> -Original Message- > >>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > >>> Sent: Friday, April

[dpdk-dev] [PATCH v5 2/3] test/rcu_qsbr: add API and functional tests

2019-04-12 Thread Honnappa Nagarahalli
From: Dharmik Thakkar Add API positive/negative test cases, functional tests and performance tests. Signed-off-by: Malvika Gupta Signed-off-by: Dharmik Thakkar Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Acked-by: Konstantin Ananyev --- app/test/Makefile |2 +

Re: [dpdk-dev] [PATCH v4 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-12 Thread Honnappa Nagarahalli
> > > > > > On Wed, Apr 10, 2019 at 06:20:04AM -0500, Honnappa Nagarahalli > wrote: > > > > Add RCU library supporting quiescent state based memory > > > > reclamation > > > method. > > > > This library helps identify the quiescent state of the reader > > > > threads so that the writers can free

[dpdk-dev] [PATCH v5 3/3] doc/rcu: add lib_rcu documentation

2019-04-12 Thread Honnappa Nagarahalli
Add lib_rcu QSBR API and programmer guide documentation. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Marko Kovacevic --- doc/api/doxy-api-index.md | 3 +- doc/api/doxy-api.conf.in | 1 + .../prog_guide/img/rcu_general_info.svg | 509 ++

[dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-12 Thread Honnappa Nagarahalli
Add RCU library supporting quiescent state based memory reclamation method. This library helps identify the quiescent state of the reader threads so that the writers can free the memory associated with the lock less data structures. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Steve Capper R

[dpdk-dev] [PATCH v5 0/3] lib/rcu: add RCU library supporting QSBR mechanism

2019-04-12 Thread Honnappa Nagarahalli
Lock-less data structures provide scalability and determinism. They enable use cases where locking may not be allowed (for ex: real-time applications). In the following paras, the term 'memory' refers to memory allocated by typical APIs like malloc or anything that is representative of memory, for

Re: [dpdk-dev] [PATCH 1/1] app/testpmd: fix port detach cleanup

2019-04-12 Thread Yongseok Koh
> On Apr 12, 2019, at 8:48 AM, Viacheslav Ovsiienko > wrote: > > At port detach routine after calling the rte_dev_remove() > testpmd performs some cleanup, checking the statuses of > remaining ports and closes the appropriate ones. The port > scanning is based on the new sibling iterator which

Re: [dpdk-dev] [PATCH 1/1] net/mlx5: share Memory Regions for multiport device

2019-04-12 Thread Yongseok Koh
On Fri, Apr 12, 2019 at 03:45:40PM +, Viacheslav Ovsiienko wrote: > The multiport Infiniband device support was introduced [1]. > All active ports, belonging to the same Infiniband device use the signle > shared Infiniband context of that device and share the resources: > - QPs are created wi

[dpdk-dev] DPDK techboard minutes of Feb 27

2019-04-12 Thread Jerin Jacob Kollanukkaran
Meeting notes for the DPDK technical board meeting held on 2019-02-27. Attendees: - Bruce Richardson - Ferruh Yigit - Hemant Agrawal - Jerin Jacob - Konstantin Ananyev - Maxime Coquelin - Olivier Matz - Stephen Hemminger -

[dpdk-dev] [Bug 253] Unable to run DPDK test with "make test" command

2019-04-12 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=253 Bug ID: 253 Summary: Unable to run DPDK test with "make test" command Product: DPDK Version: 18.11 Hardware: x86 OS: Linux Status: CONFIRMED Severity: normal

Re: [dpdk-dev] [PATCH 01/10] ethdev: introduce MACSEC device ops

2019-04-12 Thread Ferruh Yigit
On 4/10/2019 12:18 PM, Igor Russkikh wrote: > MACSEC related device ops, API and parameters are taken from the > existing ixgbe PMD ops > > Signed-off-by: Igor Russkikh <...> > @@ -3872,6 +3872,121 @@ rte_eth_dev_pool_ops_supported(uint16_t port_id, > const char *pool); > void * > rte_eth_de

Re: [dpdk-dev] [PATCH v2 3/3] app/test/meson: auto detect number of cores

2019-04-12 Thread Aaron Conole
Bruce Richardson writes: > On Fri, Apr 12, 2019 at 12:21:41PM -0400, Aaron Conole wrote: >> The arguments being passed will cause failures on laptops that have, >> for instance, 2 cores only. Most of the tests don't require more >> than a single core. Some require multiple cores (but those test

Re: [dpdk-dev] [PATCH] net/vmxnet3: v4 boot and guest UDP RSS configuration

2019-04-12 Thread Yong Wang
-Original Message- From: Eduard Serra Miralles Date: Wednesday, April 10, 2019 at 9:44 PM To: Yong Wang Cc: "dev@dpdk.org" , Eduard Serra Miralles Subject: [PATCH] net/vmxnet3: v4 boot and guest UDP RSS configuration From: Eduard Serra This patch introduces: - VMxnet3

Re: [dpdk-dev] [PATCH 1/1] net/qede: update feature support matrix with flow API

2019-04-12 Thread Ferruh Yigit
On 4/12/2019 11:12 AM, Shahed Shaikh wrote: > Commit 267d32de46a8 ("net/qede: support generic flow API") > added a support for RTE_FLOW APIs but did not update the feature > support matrix. > > Fixes: 267d32de46a8 ("net/qede: support generic flow API") > > Signed-off-by: Shahed Shaikh Applied t

Re: [dpdk-dev] ethdev flow director/filtering/steering API

2019-04-12 Thread Ferruh Yigit
On 4/11/2019 9:43 AM, Andrew Rybchenko wrote: > On 4/11/19 10:49 AM, Thomas Monjalon wrote: >> About the features called flow director, filtering or flow steering, >> we have some overlap in our API that we should clean. >> It is especially important when considering to freeze the API for stability

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/1] net/mlx5: fix memory region cleanup routine

2019-04-12 Thread Yongseok Koh
> On Apr 12, 2019, at 8:45 AM, Viacheslav Ovsiienko > wrote: > > mlx5 driver has a global list of Memory Regions created by > device, and there is a ml5_mr_release() routine which makes > a memory cleanup at device closing. The head of device MR list > was fetched outside the rwlock protected

Re: [dpdk-dev] [PATCH] ethdev: missing typecast from void in eth_dev_pci_specific_init

2019-04-12 Thread Ferruh Yigit
On 4/12/2019 6:25 PM, Ferruh Yigit wrote: > On 4/12/2019 6:15 PM, Ananyev, Konstantin wrote: >> >> >>> -Original Message- >>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit >>> Sent: Friday, April 12, 2019 6:09 PM >>> To: Stephen Hemminger ; Richardson, Bruce >>> >>> Cc

Re: [dpdk-dev] [PATCH] ethdev: missing typecast from void in eth_dev_pci_specific_init

2019-04-12 Thread Ferruh Yigit
On 4/12/2019 6:15 PM, Ananyev, Konstantin wrote: > > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit >> Sent: Friday, April 12, 2019 6:09 PM >> To: Stephen Hemminger ; Richardson, Bruce >> >> Cc: David Christensen ; tho...@monjalon.net; >> ary

Re: [dpdk-dev] [PATCH] ethdev: missing typecast from void in eth_dev_pci_specific_init

2019-04-12 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Friday, April 12, 2019 6:09 PM > To: Stephen Hemminger ; Richardson, Bruce > > Cc: David Christensen ; tho...@monjalon.net; > arybche...@solarflare.com; dev@dpdk.org; > radhika.chi...@ibm.c

Re: [dpdk-dev] [PATCH v2] kni: implement header_ops parse method

2019-04-12 Thread Ferruh Yigit
On 4/12/2019 6:12 PM, Igor Ryzhov wrote: > Hi Ferruh, > > I didn't test it with any special application, but FRR's ISIS works for me > after > the patch, and it didn't work before. That is good enough, and by work you mean that you are able to get correct value on 'sll_addr', right? > > Igor >

Re: [dpdk-dev] [PATCH] ethdev: missing typecast from void in eth_dev_pci_specific_init

2019-04-12 Thread Ferruh Yigit
On 4/10/2019 10:14 PM, Thomas Monjalon wrote: > 10/04/2019 22:58, David Christensen: >>> This is a duplicate of this patch: >>> >>> https://patches.dpdk.org/patch/52505/ >>> >>> You are from 2 different Linux teams at IBM, >>> you hit the same issue at the same time, >>> you both miss to give an ex

Re: [dpdk-dev] [PATCH v2] kni: implement header_ops parse method

2019-04-12 Thread Igor Ryzhov
Hi Ferruh, I didn't test it with any special application, but FRR's ISIS works for me after the patch, and it didn't work before. Igor On Fri, Apr 12, 2019 at 5:53 PM Ferruh Yigit wrote: > On 4/12/2019 3:52 PM, Ferruh Yigit wrote: > > On 4/10/2019 11:30 AM, Igor Ryzhov wrote: > >> It allows ap

Re: [dpdk-dev] [PATCH] ethdev: missing typecast from void in eth_dev_pci_specific_init

2019-04-12 Thread Ferruh Yigit
On 4/11/2019 12:08 AM, Stephen Hemminger wrote: > On Wed, 10 Apr 2019 22:00:18 +0100 > Bruce Richardson wrote: > >> On Wed, Apr 10, 2019 at 03:16:16PM -0500, David Christensen wrote: >>> The function eth_dev_pci_specific_init is missing a typecast to >>> (struct rte_pci_device *) for the input ar

Re: [dpdk-dev] [PATCH v2] examples/vm_power: add conditional compilation for PMD specific code

2019-04-12 Thread David Christensen
Bugzilla ID: 237 Fixes: Running test-build.sh Fails on ppc_64 fails due to hard-coded requirement for IXGBE_PMD in examples/vm_power_manager Signed-off-by: David Christensen Ping.

Re: [dpdk-dev] [PATCH] doc: fix spelling in testpmd guide

2019-04-12 Thread Ferruh Yigit
On 4/10/2019 11:04 PM, Rami Rosen wrote: > Stephen Hemminger ‏: > >> Minor spelling errors found with aspell. >> >> Signed-off-by: Stephen Hemminger >> -- >> > Acked-by: Rami Rosen > Fixes: e76d7a768ce0 ("doc: fix syntax in testpmd user guide") Fixes: fb73e096110a ("app/testpmd: enable

[dpdk-dev] [Bug 252] Possible access to invalid FDs in rte_eth_tap

2019-04-12 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=252 Bug ID: 252 Summary: Possible access to invalid FDs in rte_eth_tap Product: DPDK Version: 18.11 Hardware: All OS: All Status: CONFIRMED Severity: normal

Re: [dpdk-dev] [PATCH v7 00/14] Add patch set for IPN3KE

2019-04-12 Thread Ferruh Yigit
On 4/10/2019 7:27 AM, Rosen Xu wrote: > v7 updates: > = > - Fix Stephen comments > > v6 updates: > == > - Fix v5 comments > - Fix TM Shaper rate issue > > v5 updates: > == > - Fix EXPERIMENTAL symbol definition issue > > v4 updates: > == > - Fix coding style

Re: [dpdk-dev] [PATCH v2 3/3] app/test/meson: auto detect number of cores

2019-04-12 Thread Bruce Richardson
On Fri, Apr 12, 2019 at 12:21:41PM -0400, Aaron Conole wrote: > The arguments being passed will cause failures on laptops that have, > for instance, 2 cores only. Most of the tests don't require more > than a single core. Some require multiple cores (but those tests > should be modified to 'SKIP'

Re: [dpdk-dev] [RFC v2] net: fix rte_vlan_insert with shared mbuf

2019-04-12 Thread Ferruh Yigit
On 3/28/2019 8:53 PM, Stephen Hemminger wrote: > If mbuf is shared then rte_vlan_insert() would clobber the original > Ethernet header. The changed version handles this by getting > an mbuf that will hold the new Ethernet and VLAN header followed > by another mbuf (cloned) for the data. Hi Stephen

Re: [dpdk-dev] [PATCH v2] net/af_packet: fix vlan_insert corruption

2019-04-12 Thread Ferruh Yigit
On 4/8/2019 5:41 PM, Stephen Hemminger wrote: > If the af_packet transmit is sending a VLAN packet, > and the transmit path to the kernel os full, then it would > mismanage the outgoing mbuf. The original mbuf would end up > being freed twice, once by AF_PACKET PMD and once by caller. This comment

[dpdk-dev] [PATCH v2 0/3] travis: enhancements for build (plus a meson fix)

2019-04-12 Thread Aaron Conole
This series improves the travis integration a bit, and adds the ability for the meson system to auto-detect the number of cores. v1->v2 (all patch 3/3 changes): * Fix a spelling mistake * Add support for FreeBSD * Include a default fallback * Use a more robust core-mask argument source (rather tha

[dpdk-dev] [PATCH v2 3/3] app/test/meson: auto detect number of cores

2019-04-12 Thread Aaron Conole
The arguments being passed will cause failures on laptops that have, for instance, 2 cores only. Most of the tests don't require more than a single core. Some require multiple cores (but those tests should be modified to 'SKIP' when the correct number of cores aren't available). The unit test re

[dpdk-dev] [PATCH v2 1/3] travis: enable ccache

2019-04-12 Thread Aaron Conole
We try to make the planet happy travis builds dpdk. Also, the 'sudo' flag was recently deprecated. Drop it. Suggested-by: Luca Boccassi Signed-off-by: Aaron Conole Reviewed-by: David Marchand Acked-by: Luca Boccassi --- .travis.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) di

[dpdk-dev] [PATCH v2 2/3] travis: add a distinguisher to the 'extra' builds

2019-04-12 Thread Aaron Conole
This helps in two ways: 1. When looking at travis page for dpdk, it's a visual distinction 2. For ccache support, the build IDs include the 'env', so we get unique cache data. Signed-off-by: Aaron Conole Reviewed-by: David Marchand Acked-by: Luca Boccassi --- .travis.yml | 16 +++

Re: [dpdk-dev] [RFC PATCH 1/2] ethdev: introduce internal rxq/txq stats API

2019-04-12 Thread Stephen Hemminger
On Fri, 12 Apr 2019 16:32:01 +0200 David Marchand wrote: > On Fri, Apr 12, 2019 at 3:29 PM Thomas Monjalon wrote: > > > 26/03/2019 10:29, David Marchand: > > > On Tue, Mar 19, 2019 at 6:18 PM Ferruh Yigit > > wrote: > > > > > > > On 3/14/2019 3:13 PM, David Marchand wrote: > > > > >

[dpdk-dev] [PATCH] lib/librte_power: set new frequecy on turbo_disable

2019-04-12 Thread Lee Daly
This patch will ensure the correct max frequency of a core is set in the lcore_power_info struct when disabling turbo, while using the intel pstate driver. Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility") Cc: liang.j...@intel.com Cc: sta...@dpdk.org Signed-off-by: Lee Daly --- li

Re: [dpdk-dev] [PATCH 00/12] rxq q_errors[] statistics fixes

2019-04-12 Thread Ferruh Yigit
On 4/12/2019 4:45 PM, Thomas Monjalon wrote: > 12/04/2019 17:38, Ferruh Yigit: >> On 4/12/2019 4:07 PM, Thomas Monjalon wrote: >>> 11/03/2019 18:22, Ferruh Yigit: On 3/4/2019 11:18 AM, David Marchand wrote: > According to the api, the q_errors[] per queue statistic is for reception > e

[dpdk-dev] [PATCH 1/1] net/mlx5: add support for PF representor

2019-04-12 Thread Viacheslav Ovsiienko
On BlueField platform we have the new entity - PF representor. This one represents the PCI PF attached to external host on the side of ARM. The traffic sent by the external host to the NIC via PF will be seem by ARM on this PF representor. This patch extends port recognizing capability on the base

[dpdk-dev] [PATCH 1/1] app/testpmd: fix port detach cleanup

2019-04-12 Thread Viacheslav Ovsiienko
At port detach routine after calling the rte_dev_remove() testpmd performs some cleanup, checking the statuses of remaining ports and closes the appropriate ones. The port scanning is based on the new sibling iterator which uses the invalid (already closed) port for reference. This patch replaces t

[dpdk-dev] [PATCH 1/1] net/mlx5: fix memory region cleanup routine

2019-04-12 Thread Viacheslav Ovsiienko
mlx5 driver has a global list of Memory Regions created by device, and there is a ml5_mr_release() routine which makes a memory cleanup at device closing. The head of device MR list was fetched outside the rwlock protected section. Also some noticed typos are fixed. Fixes: 974f1e7ef146 ("net/mlx5:

[dpdk-dev] [PATCH 1/1] net/mlx5: share Memory Regions for multiport device

2019-04-12 Thread Viacheslav Ovsiienko
The multiport Infiniband device support was introduced [1]. All active ports, belonging to the same Infiniband device use the signle shared Infiniband context of that device and share the resources: - QPs are created within shared context - Verbs flows are also created with specifying port inde

Re: [dpdk-dev] [PATCH 00/12] rxq q_errors[] statistics fixes

2019-04-12 Thread Thomas Monjalon
12/04/2019 17:38, Ferruh Yigit: > On 4/12/2019 4:07 PM, Thomas Monjalon wrote: > > 11/03/2019 18:22, Ferruh Yigit: > >> On 3/4/2019 11:18 AM, David Marchand wrote: > >>> According to the api, the q_errors[] per queue statistic is for reception > >>> errors not transmit errors. > >>> This is a first

Re: [dpdk-dev] [PATCH 00/12] rxq q_errors[] statistics fixes

2019-04-12 Thread Ferruh Yigit
On 4/12/2019 4:07 PM, Thomas Monjalon wrote: > 11/03/2019 18:22, Ferruh Yigit: >> On 3/4/2019 11:18 AM, David Marchand wrote: >>> According to the api, the q_errors[] per queue statistic is for reception >>> errors not transmit errors. >>> This is a first cleanup on statistics before looking at oer

Re: [dpdk-dev] [PATCH v1] fix alphabetical ordering of headers

2019-04-12 Thread Trahe, Fiona
Hi Ayuj, > -Original Message- > From: Ayuj Verma [mailto:ayve...@marvell.com] > Sent: Friday, April 12, 2019 8:03 AM > To: akhil.go...@nxp.com; Kusztal, ArkadiuszX ; > Trahe, Fiona > > Cc: shal...@marvell.com; ss...@marvell.com; kkotamar...@marvell.com; > ade...@marvell.com; > dev@dpdk.

Re: [dpdk-dev] [PATCH 00/12] rxq q_errors[] statistics fixes

2019-04-12 Thread Thomas Monjalon
11/03/2019 18:22, Ferruh Yigit: > On 3/4/2019 11:18 AM, David Marchand wrote: > > According to the api, the q_errors[] per queue statistic is for reception > > errors not transmit errors. > > This is a first cleanup on statistics before looking at oerrors. > > > > Yes, the patchset looks aligned

[dpdk-dev] [RFC PATCH] mbuf: outer offsets must be zero for non-tunnel packets

2019-04-12 Thread Ivan Malov
Make sure that outer L2 and L3 header length fields are equal to zero for non-tunnel packets in order to ensure consistent and predictable behaviour in network drivers. Explain this expectation in comments to help developers. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko --- Notes:

Re: [dpdk-dev] [PATCH] net/nfb: remove redundant linking

2019-04-12 Thread Ferruh Yigit
On 4/12/2019 3:37 PM, Rastislav Cernay wrote: > From: Rastislav Cernay > > Signed-off-by: Rastislav Cernay Squashed into relevant commit in next-net, thanks.

[dpdk-dev] [PATCH 1/2] net/af_xdp: enqueue buf ring when allocate Tx queue fails

2019-04-12 Thread Xiaolong Ye
When it fails to allocate enough slots in Tx queue for transmitting packets, we need to return the dequeued addrs to buf ring. Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") Signed-off-by: Xiaolong Ye --- drivers/net/af_xdp/rte_eth_af_xdp.c | 1 + 1 file changed, 1 insertion(+) diff

[dpdk-dev] [PATCH 2/2] net/af_xdp: make reserve/submit peek/release consistent

2019-04-12 Thread Xiaolong Ye
As David pointed out, if we reserve N slots, but only submit n slots, we would end up with an incorrect opinion of the number of available slots later, we also would get wrong idx when we call xsk_ring_prod__reserve next time. It also applies to xsk_ring_cons__peek()/xsk_ring_cons__release(). This

Re: [dpdk-dev] [PATCH v2] kni: implement header_ops parse method

2019-04-12 Thread Ferruh Yigit
On 4/12/2019 3:52 PM, Ferruh Yigit wrote: > On 4/10/2019 11:30 AM, Igor Ryzhov wrote: >> It allows applications running packet sockets over KNI interfaces to get >> source Ethernet addresses of packets received using recvfrom function. >> >> Signed-off-by: Igor Ryzhov > > Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v2] kni: implement header_ops parse method

2019-04-12 Thread Ferruh Yigit
On 4/10/2019 11:30 AM, Igor Ryzhov wrote: > It allows applications running packet sockets over KNI interfaces to get > source Ethernet addresses of packets received using recvfrom function. > > Signed-off-by: Igor Ryzhov Acked-by: Ferruh Yigit Hi Igor, I tested this with a quick application

Re: [dpdk-dev] [PATCH] app/testpmd: set fixed flag when exact link speed is chosen

2019-04-12 Thread Iremonger, Bernard
> -Original Message- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Friday, April 12, 2019 2:13 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] app/testpmd: set fixed flag when exact link speed is > ch

[dpdk-dev] [PATCH] net/nfb: remove redundant linking

2019-04-12 Thread Rastislav Cernay
From: Rastislav Cernay Signed-off-by: Rastislav Cernay --- drivers/net/nfb/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/nfb/Makefile b/drivers/net/nfb/Makefile index 21b09b3..a84b423 100644 --- a/drivers/net/nfb/Makefile +++ b/drivers/net/nfb/Makefile @@ -16,7 +16,6 @

Re: [dpdk-dev] [RFC PATCH 1/2] ethdev: introduce internal rxq/txq stats API

2019-04-12 Thread David Marchand
On Fri, Apr 12, 2019 at 3:29 PM Thomas Monjalon wrote: > 26/03/2019 10:29, David Marchand: > > On Tue, Mar 19, 2019 at 6:18 PM Ferruh Yigit > wrote: > > > > > On 3/14/2019 3:13 PM, David Marchand wrote: > > > > Introduce a new api to retrieve per queue statistics from the > drivers. > > > > The

[dpdk-dev] [PATCH v2] app/test/ipsec: fix logic around dequeue burst

2019-04-12 Thread Bernard Iremonger
Added crypto_dequeue_burst() function to call rte_crypto_dequeue_burst() in a loop with a delay to ensure that all the packets are dequeued from the crtpto device. Fixes: 59d7353b0df0 ("test/ipsec: fix test suite setup") Cc: sta...@dpdk.org Signed-off-by: Bernard Iremonger Acked-by: Fiona Trahe

[dpdk-dev] [PATCH 2/2] net/ice: fix promiscuous mode

2019-04-12 Thread Wang Ying A
When device promiscuous mode has already been enabled, if user re-enables the promisc mode, he/she should be prompted with "Promisc has already been enabled" rather than "Failed to enable promisc". Fixes: c945e4bf9063 ("net/ice: support promiscuous mode") Cc: sta...@dpdk.org Signed-off-by: Wang Y

[dpdk-dev] [PATCH 0/2] ice: code clean and promisc mode fix

2019-04-12 Thread Wang Ying A
Patch 1/2 modifies the variable type of "status" from "uint16_t" to "int" to follow the standard programming style. Patch 2/2 adds a return value check to give user a correct prompt. Wang Ying A (2): net/ice: code clean net/ice: fix promiscuous mode drivers/net/ice/ice_ethdev.c | 12 +++

[dpdk-dev] [PATCH 1/2] net/ice: code clean

2019-04-12 Thread Wang Ying A
Variable "status" should be difined as "int" instead of "uint_16t". This patch fixes the issue. Fixes: c945e4bf9063 ("net/ice: support promiscuous mode") Cc: sta...@dpdk.org Signed-off-by: Wang Ying A --- drivers/net/ice/ice_ethdev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

Re: [dpdk-dev] [PATCH 2/4] net/bonding: fix LACP fast queue Rx handler

2019-04-12 Thread Chas Williams
I should have some time this weekend to run these patches through our regression system. On 4/10/19 8:53 AM, David Marchand wrote: fast queue Rx burst function is missing checks on promisc and the slave collecting state. Define an inline wrapper to have a common base. Fixes: 112891cd27e5 ("net/

Re: [dpdk-dev] [RFC PATCH 1/2] ethdev: introduce internal rxq/txq stats API

2019-04-12 Thread Thomas Monjalon
26/03/2019 10:29, David Marchand: > On Tue, Mar 19, 2019 at 6:18 PM Ferruh Yigit wrote: > > > On 3/14/2019 3:13 PM, David Marchand wrote: > > > Introduce a new api to retrieve per queue statistics from the drivers. > > > The api objectives: > > > - easily add some common per queue statistics and

Re: [dpdk-dev] [RFC PATCH 1/2] ethdev: introduce internal rxq/txq stats API

2019-04-12 Thread Thomas Monjalon
19/03/2019 18:54, Stephen Hemminger: > My preference would be: > 1. Make all DPDK drivers consistent in usage of current statistic values. > 2. Propose an enhancement to have new ethdev statistics match some > pre-existing > standard like SNMP or other RFC. This patch is about basic stat

[dpdk-dev] [PATCH] app/testpmd: set fixed flag when exact link speed is chosen

2019-04-12 Thread Andrew Rybchenko
Setting exact link speed makes sense if auto-negotiation is disabled. Fixed flag is required to disable auto-negotiation. Fixes: 88fbedcd5e5a ("app/testpmd: move speed and duplex parsing in a function") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- app/test-pmd/cmdline.c | 12 ++--

[dpdk-dev] [PATCH] vhost: fix silent queue enabling with legacy guests

2019-04-12 Thread Ilya Maximets
vhost should notify the application in case of all vring state changes. In general, application should not care about negotiation of VHOST_USER_F_PROTOCOL_FEATURES. Protocol details like this should be hidden by the vhost library. With this patch applications like OVS will be able to assume that

[dpdk-dev] [PATCH v4 12/13] net/enetc: enable Rx checksum offload validation

2019-04-12 Thread Gagandeep Singh
Checksum Validation on Rx is supported. Signed-off-by: Gagandeep Singh --- doc/guides/nics/features/enetc.ini | 2 + drivers/net/enetc/base/enetc_hw.h | 5 ++ drivers/net/enetc/enetc_ethdev.c | 15 +++- drivers/net/enetc/enetc_rxtx.c | 107 + 4 files chang

[dpdk-dev] [PATCH v4 13/13] net/enetc: fix crash at high speed traffic

2019-04-12 Thread Gagandeep Singh
On xmit side, there should be a check whether BD ring has free BDs available before transmit a packet to avoid data corruption and buffer leak issue. Fixes: 469c6111a799 ("net/enetc: enable Rx and Tx") Cc: sta...@dpdk.org Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc_rxtx.c | 7 +++

[dpdk-dev] [PATCH v4 11/13] net/enetc: enable CRC offload feature

2019-04-12 Thread Gagandeep Singh
CRC offload keep feature supported Signed-off-by: Gagandeep Singh --- doc/guides/nics/enetc.rst | 1 + doc/guides/nics/features/enetc.ini | 1 + drivers/net/enetc/base/enetc_hw.h | 1 + drivers/net/enetc/enetc.h | 1 + drivers/net/enetc/enetc_ethdev.c | 20 ++

[dpdk-dev] [PATCH v4 09/13] net/enetc: add MTU update and jumbo frames support

2019-04-12 Thread Gagandeep Singh
Enable the jumbo frames and mtu update feature. Signed-off-by: Gagandeep Singh --- doc/guides/nics/enetc.rst | 1 + doc/guides/nics/features/enetc.ini | 2 + drivers/net/enetc/base/enetc_hw.h | 6 ++- drivers/net/enetc/enetc.h | 5 ++ drivers/net/enetc/enetc_ethdev.c | 8

[dpdk-dev] [PATCH v4 10/13] net/enetc: enable Rx-Tx queue start/stop feature

2019-04-12 Thread Gagandeep Singh
Rx and Tx queue start-stop and deferred queue start features enabled. Signed-off-by: Gagandeep Singh --- doc/guides/nics/enetc.rst | 2 + doc/guides/nics/features/enetc.ini | 1 + drivers/net/enetc/enetc_ethdev.c | 185 - 3 files changed, 134 insertions

[dpdk-dev] [PATCH v4 08/13] net/enetc: enable promiscuous and allmulticast feature

2019-04-12 Thread Gagandeep Singh
Promiscuous and allmulticast enable/disable APIs added. Signed-off-by: Gagandeep Singh --- doc/guides/nics/enetc.rst | 2 + doc/guides/nics/features/enetc.ini | 2 + drivers/net/enetc/base/enetc_hw.h | 3 +- drivers/net/enetc/enetc_ethdev.c | 90 +- 4 f

[dpdk-dev] [PATCH v4 07/13] net/enetc: remove forward declarations

2019-04-12 Thread Gagandeep Singh
Remove unneeded forward declarations and re-order the code. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc_ethdev.c | 237 ++- 1 file changed, 107 insertions(+), 130 deletions(-) diff --git a/drivers/net/enetc/enetc_ethdev.c b/drivers/net/enetc/enetc_ethd

[dpdk-dev] [PATCH v4 06/13] net/enetc: replace register read/write macros with functions

2019-04-12 Thread Gagandeep Singh
Replacing read-write macros with already available read-write functions. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc.h| 7 +--- drivers/net/enetc/enetc_ethdev.c | 61 2 files changed, 31 insertions(+), 37 deletions(-) diff --git a/drivers

[dpdk-dev] [PATCH v4 04/13] net/enetc: set interface mode for SXGMII

2019-04-12 Thread Gagandeep Singh
Support for SXGMII port has been enabled. It will depends on boot loader information passed through IERB. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/base/enetc_hw.h | 13 - drivers/net/enetc/enetc_ethdev.c | 11 +++ 2 files changed, 23 insertions(+), 1 deletion(-)

[dpdk-dev] [PATCH v4 05/13] net/enetc: add basic statistics

2019-04-12 Thread Gagandeep Singh
Enable basic statistics APIs enetc_stats_get and enetc_stats_reset. Signed-off-by: Gagandeep Singh --- doc/guides/nics/enetc.rst | 1 + doc/guides/nics/features/enetc.ini | 1 + drivers/net/enetc/base/enetc_hw.h | 27 +++- drivers/net/enetc/enetc_ethdev.c | 41 +

[dpdk-dev] [PATCH v4 03/13] net/enetc: fix big endian build and correct buffer allocation

2019-04-12 Thread Gagandeep Singh
There was an error at rte_constant_bswap64 while compiling with big endian toolchain. so fixing it by adding type cast. Also, rte_pktmbuf_alloc API should be used to allocate mbuf instead of rte_pktmbuf_raw_alloc to avoid use of stale mbuf information. Fixes: 469c6111a799 ("net/enetc: enable Rx a

[dpdk-dev] [PATCH v4 00/13] ENETC PMD basic features and bug fixes

2019-04-12 Thread Gagandeep Singh
*V1 log: * support added for MTU, jumbo frame, queue start/stop, promiscuous, multicast, crc offload, RX checksum validation, basic stats * some bug fixes V2 change-log: * remove unneeded code from stats get * fix big endian compilation v3 change-log: * commit message updated for 03/13 pa

[dpdk-dev] [PATCH v4 02/13] net/enetc: fix SMMU unhandled context fault

2019-04-12 Thread Gagandeep Singh
First configure ring with BDs properly then enable the ring. Fixes: 469c6111a799 ("net/enetc: enable Rx and Tx") Cc: sta...@dpdk.org Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/enetc/en

[dpdk-dev] [PATCH v4 01/13] net/enetc: support physical addressing mode

2019-04-12 Thread Gagandeep Singh
Support added for physical addressing mode and change driver flags to don't care. Signed-off-by: Gagandeep Singh --- drivers/net/enetc/enetc_ethdev.c | 22 -- drivers/net/enetc/enetc_rxtx.c | 6 +++--- 2 files changed, 15 insertions(+), 13 deletions(-) diff --git a/driver

Re: [dpdk-dev] [PATCH v3] net/ice: stop lldp by default

2019-04-12 Thread Zhang, Qi Z
> -Original Message- > From: Yang, Qiming > Sent: Friday, April 12, 2019 6:10 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > Subject: [PATCH v3] net/ice: stop lldp by default > > This patch stopped lldp by default to avoid the statistics error. > > Signed-off-by: Qiming Yang

Re: [dpdk-dev] [PATCH v4 1/3] rcu: add RCU library supporting QSBR mechanism

2019-04-12 Thread Paul E. McKenney
On Thu, Apr 11, 2019 at 04:35:04AM +, Honnappa Nagarahalli wrote: > Hi Paul, > Thank you for your feedback. > > > -Original Message- > > From: Paul E. McKenney > > Sent: Wednesday, April 10, 2019 1:15 PM > > To: Honnappa Nagarahalli > > Cc: konstantin.anan...@intel.com; step...

Re: [dpdk-dev] [RFC 00/12] introduce s390x architecture

2019-04-12 Thread Pradeep Satyanarayana
> > > We are still seeing some compilation issues regularly on Power. > > > Before going to DTS, I think you should extend your compilation testing, > > > and basic feature testing with builtin unit tests. > > > > We have not observed any compilation issues since we started the CI. The > > last i

Re: [dpdk-dev] [PATCH v7] net/nfb: new netcope driver

2019-04-12 Thread Ferruh Yigit
On 4/7/2019 4:03 PM, Rastislav Cernay wrote: > From: Rastislav Cernay > > Added new net driver for Netcope nfb cards > > Signed-off-by: Rastislav Cernay Hi Rastislav, Welcome to DPDK! Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v7] net/nfb: new netcope driver

2019-04-12 Thread Ferruh Yigit
On 4/7/2019 4:03 PM, Rastislav Cernay wrote: > From: Rastislav Cernay > > Added new net driver for Netcope nfb cards > > Signed-off-by: Rastislav Cernay <...> > +CFLAGS += -O3 > +CFLAGS += $(WERROR_FLAGS) > +CFLAGS += $(shell command -v pkg-config > /dev/null 2>&1 && pkg-config > --cflags ne

Re: [dpdk-dev] [PATCH] app/test/ipsec: fix logic around dequeue burst

2019-04-12 Thread Iremonger, Bernard
Hi Konstantin, > > Call rte_crypto_dequeue_burst() in a loop with a delay to ensure that > > all the packets are dequeued from the crtpto device. > > > > Fixes: 59d7353b0df0 ("test/ipsec: fix test suite setup") > > Cc: sta...@dpdk.org > > Signed-off-by: Bernard Iremonger > > --- > > app/test/t

  1   2   >