On 4/7/2019 4:03 PM, Rastislav Cernay wrote: > From: Rastislav Cernay <cer...@netcope.com> > > Added new net driver for Netcope nfb cards > > Signed-off-by: Rastislav Cernay <cer...@netcope.com>
<...> > +CFLAGS += -O3 > +CFLAGS += $(WERROR_FLAGS) > +CFLAGS += $(shell command -v pkg-config > /dev/null 2>&1 && pkg-config > --cflags netcope-common) > +LDLIBS += -lnfb > +LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool > +LDLIBS += -lrte_ethdev -lrte_net > +LDLIBS += -lrte_bus_pci > +LDLIBS += $(shell command -v pkg-config > /dev/null 2>&1 && pkg-config > --libs netcope-common) With this pkg-config line, isn't it above "LDLIBS += -lnfb" become redundant, can we remove that line? If so please send a seperate patch to remove it, I can squash into original one.