> > On Fri, 12 Apr 2019 15:20:37 -0500 > Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> wrote: > > > Add RCU library supporting quiescent state based memory reclamation > method. > > This library helps identify the quiescent state of the reader threads > > so that the writers can free the memory associated with the lock less > > data structures. > > > > Signed-off-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> > > Reviewed-by: Steve Capper <steve.cap...@arm.com> > > Reviewed-by: Gavin Hu <gavin...@arm.com> > > Reviewed-by: Ola Liljedahl <ola.liljed...@arm.com> > > Acked-by: Konstantin Ananyev <konstantin.anan...@intel.com> > > After evaluating long term API/ABI issues, I think you need to get rid of > almost > all use of inline and visible structures. Yes it might be marginally slower, > but > you thank me the first time you have to fix something. > Agree, I was planning on another version to address this (I am yet to take a look at your patch addressing the ABI). The structure visibility definitely needs to be addressed. For the inline functions, is the plan to convert all the inline functions in DPDK? If yes, I think we need to consider the performance difference. May be consider L3-fwd application, change all the inline functions in its path and run a test?
> Even the log macro should be private.
